Günther Deschner [Fri, 28 Nov 2008 23:12:26 +0000 (00:12 +0100)]
s3-libnetjoin: Fix bug #5749. Re-set acctflags while joining. fix from metze.
Guenther
Günther Deschner [Fri, 28 Nov 2008 23:10:18 +0000 (00:10 +0100)]
s3-libnetjoin: remove unused md4_trust_password, found by metze.
Guenther
Günther Deschner [Fri, 28 Nov 2008 21:01:18 +0000 (22:01 +0100)]
s4-smbtorture: add some more testcases to pwdlastset test.
Guenther
Günther Deschner [Fri, 28 Nov 2008 20:58:25 +0000 (21:58 +0100)]
s4-smbtorture: fix RPC-SAMR-PASSWORDS-PWDLASTSET with samba3 option.
Guenther
Günther Deschner [Fri, 28 Nov 2008 10:15:29 +0000 (11:15 +0100)]
s3-samr: add init_samr_user_info25 and init_samr_user_info26.
Guenther
Günther Deschner [Thu, 27 Nov 2008 16:25:13 +0000 (17:25 +0100)]
selftest: s4 does not have a pwdlastset implementation yet.
Guenther
Günther Deschner [Fri, 28 Nov 2008 11:10:56 +0000 (12:10 +0100)]
s4-smbtorture: allow to disable full testing of all possible opcode combinations.
Guenther
Günther Deschner [Thu, 27 Nov 2008 11:09:39 +0000 (12:09 +0100)]
s4-smbtorture: move test to SAMR-PASSWORDS-PWDLASTSET.
Guenther
Günther Deschner [Tue, 25 Nov 2008 01:46:25 +0000 (02:46 +0100)]
s4-smbtorture: add test for samr password_expired flag while setting passwords.
Guenther
Günther Deschner [Fri, 28 Nov 2008 11:04:09 +0000 (12:04 +0100)]
s4-smbtorture: add test_SetUserPass_level_ex.
Guenther
Günther Deschner [Fri, 28 Nov 2008 00:56:09 +0000 (01:56 +0100)]
s4-smbtorture: add samr_rand_pass_silent.
Guenther
Günther Deschner [Thu, 27 Nov 2008 16:45:01 +0000 (17:45 +0100)]
s4-samr: fix samr passwdord_expired callers.
Guenther
Günther Deschner [Mon, 24 Nov 2008 17:49:37 +0000 (18:49 +0100)]
s3-samr: fix init_samr_user_info{23,24} callers.
Guenther
Günther Deschner [Mon, 24 Nov 2008 15:32:18 +0000 (16:32 +0100)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 24 Nov 2008 15:31:49 +0000 (16:31 +0100)]
samr: fix samr_UserInfo24 and samr_UserInfo26.
Guenther
Volker Lendecke [Sun, 9 Nov 2008 16:25:40 +0000 (17:25 +0100)]
Remove "conn" parameter from np_open, smb_request contains it
Volker Lendecke [Sun, 9 Nov 2008 11:07:57 +0000 (12:07 +0100)]
Remove inbuf references from the trans2ioctl code
Volker Lendecke [Sat, 8 Nov 2008 16:08:57 +0000 (17:08 +0100)]
Consolidate the buffer checks for the reply_trans style functions
This is the one where I found the problem that led to 3.2.5. So if there is one
checkin in the last year that I would like others to review and *understand*,
it is this one :-)
Volker
Volker Lendecke [Sat, 8 Nov 2008 15:48:20 +0000 (16:48 +0100)]
Move cli_trans_oob to lib/util.c
Rename it to trans_oob, it will be used in the server routines.
Volker Lendecke [Sat, 8 Nov 2008 15:14:12 +0000 (16:14 +0100)]
Remove the variable "size" from reply_nttrans
This converts the range checks for the setup[] array to rely on req->wct being
set correctly in init_smb_request. As that already verifies the vwv array to be
in the range of the smb_request inbuf, we don't have to do overflow checks here
anymore.
Jeremy, please check thoroughly! :-)
Thanks,
Volker
Volker Lendecke [Sat, 8 Nov 2008 15:14:12 +0000 (16:14 +0100)]
Remove the variable "size" from reply_trans
This converts the range checks for the setup[] array to rely on req->wct being
set correctly in init_smb_request. As that already verifies the vwv array to be
in the range of the smb_request inbuf, we don't have to do overflow checks here
anymore.
Jeremy, please check thoroughly! :-)
Thanks,
Volker
Volker Lendecke [Sat, 8 Nov 2008 15:03:07 +0000 (16:03 +0100)]
Remove an unused variable
Volker Lendecke [Sat, 8 Nov 2008 14:44:20 +0000 (15:44 +0100)]
Remove two direct inbuf references from reply_sesssetup_and_X_spnego()
Günther Deschner [Thu, 27 Nov 2008 16:29:30 +0000 (17:29 +0100)]
s3-samr: never allow to alter pwdlastset directly.
Guenther
Günther Deschner [Thu, 27 Nov 2008 00:25:46 +0000 (01:25 +0100)]
s3-samr: fix return code for invalid password sets in SetUserInfo.
Guenther
Günther Deschner [Thu, 27 Nov 2008 00:22:39 +0000 (01:22 +0100)]
s3-samr: fix return code for invalid name in _samr_LookupDomain.
Guenther
Günther Deschner [Thu, 27 Nov 2008 00:21:49 +0000 (01:21 +0100)]
s3-samr: avoid enumeration and user creation on builtin domain handle.
Guenther
Günther Deschner [Tue, 25 Nov 2008 14:51:35 +0000 (15:51 +0100)]
s3-samr: support samr_CreateUser as well.
Guenther
Günther Deschner [Tue, 25 Nov 2008 14:50:28 +0000 (15:50 +0100)]
s3-samr: support samr_QueryUserInfo2 as well.
Guenther
Günther Deschner [Tue, 25 Nov 2008 11:21:37 +0000 (12:21 +0100)]
s3-samr: add support for _samr_QueryUserInfo level 5.
Guenther
Günther Deschner [Tue, 25 Nov 2008 11:18:39 +0000 (12:18 +0100)]
s3-samr: add init_samr_user_info5.
Guenther
Günther Deschner [Thu, 27 Nov 2008 08:44:51 +0000 (09:44 +0100)]
s4-smbtorture: fix some build warnings.
Guenther
Volker Lendecke [Sat, 8 Nov 2008 16:14:06 +0000 (17:14 +0100)]
Fix the offset checks in the trans routines
This fixes a potential crash bug, a client can make us read memory we
should not read. Luckily I got the disp checks right...
Volker
(cherry picked from commit
64a1d80851da5b05e70ec6c96f6e9bd473748369)
(cherry picked from commit
f04c5650a3aeca23591ddc781c4b297caaf9bb3f)
Jelmer Vernooij [Wed, 26 Nov 2008 17:20:51 +0000 (18:20 +0100)]
Move netr_SamDatabaseID8Bit to netlogon.idl to prevent problems with
forward enum declarations when compiled with C++.
Jelmer Vernooij [Wed, 26 Nov 2008 15:55:32 +0000 (16:55 +0100)]
Don't filter out any variables for config.pm, only for config.mk.
Andreas Schneider [Wed, 29 Oct 2008 13:12:04 +0000 (14:12 +0100)]
Fix circular dependency error with autoconf 2.6.3.
Signed-off-by: Andreas Schneider <anschneider@suse.de>
Jelmer Vernooij [Wed, 26 Nov 2008 15:22:11 +0000 (16:22 +0100)]
Use a simple shell loop instead of _AC_SUBST_VARS.
Autoconf has removed _AC_SUBST_VARS in newer versions.
Jeremy Allison [Tue, 25 Nov 2008 23:53:56 +0000 (15:53 -0800)]
Fix bug #5914 - Build failure: redefinition of struct name_list
Jeremy.
Jelmer Vernooij [Tue, 25 Nov 2008 14:42:47 +0000 (15:42 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Sam Liddicott [Tue, 25 Nov 2008 14:41:07 +0000 (15:41 +0100)]
Make sure dom_sid.h is installed.
Günther Deschner [Tue, 25 Nov 2008 11:19:35 +0000 (12:19 +0100)]
s3-samr: fix _samr_LookupNames return code.
Guenther
Michael Adam [Tue, 25 Nov 2008 14:24:43 +0000 (15:24 +0100)]
Revert "UNFINISHED - s3:idmap_ad: multi-domain"
This reverts commit
6a4957d35d50e6508917aca62b282ae4904187c8.
Sorry - this got accidentially pushed.
Michael
Michael Adam [Sun, 23 Nov 2008 21:59:40 +0000 (22:59 +0100)]
UNFINISHED - s3:idmap_ad: multi-domain
Michael
Michael Adam [Mon, 17 Nov 2008 09:29:41 +0000 (10:29 +0100)]
[s3]zfsacl: "return" is not a function.
Michael
Nils Goroll [Sun, 16 Nov 2008 23:55:16 +0000 (00:55 +0100)]
[s3]zfsacl: Prevent calling POSIX ACL vfs methods on zfs share.
This is a proposed fix for Bugs #5135 and #5446.
Signed-off-by: Michael Adam <obnox@samba.org>
Kai Blin [Sun, 23 Nov 2008 16:11:09 +0000 (17:11 +0100)]
libwbclient: Implement wbcGetgrent and wbcGetgrlist
Kai Blin [Sun, 23 Nov 2008 15:36:01 +0000 (16:36 +0100)]
libwbclient: Implement wbcGetpwent
Kai Blin [Sun, 23 Nov 2008 14:16:17 +0000 (15:16 +0100)]
libwbclient: Add placeholder function for WINBINDD_CCACHE_NTLMAUTH
Kai Blin [Sun, 23 Nov 2008 10:18:40 +0000 (11:18 +0100)]
libwbclient: Fix typo in wbcGetgrent docstring.
Kai Blin [Sun, 23 Nov 2008 10:17:42 +0000 (11:17 +0100)]
libwbclient: Add placeholder function for WINBINDD_GETGRLST
Kai Blin [Sat, 22 Nov 2008 23:57:33 +0000 (00:57 +0100)]
libwbclient: Add placeholder functions for wbcQuery[GSU]idTo[GSU]id
Dan Sledz [Mon, 17 Nov 2008 01:40:03 +0000 (17:40 -0800)]
Allow SYSLOG_FACILITY to be modified with a new configure option called --with-syslog-facility
Jeremy Allison [Mon, 24 Nov 2008 23:28:11 +0000 (15:28 -0800)]
Fix bug #5873 - ACL inheritance cannot be broken. This regresses #4308, but that will have to
be fixed another way.
Jeremy.
Mathias Dietz [Wed, 12 Nov 2008 13:32:45 +0000 (14:32 +0100)]
Search for gpfs functions in both libgpfs_gpl.so an libgpfs.so
As of GPFS 3.2.1 PTF8 libgpfs will be available as GPL, so we don't need the
special libgpfs_gpl lib anymore. For backwards compatibility with pre-PTF8 GPFS
installations, still look there.
Stefan Metzmacher [Mon, 24 Nov 2008 14:04:12 +0000 (15:04 +0100)]
s3:libads/ldap.c: return an error instead of crashing when no realm is given
The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't ex
and "disable netbios = yes".
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 24 Nov 2008 07:56:46 +0000 (08:56 +0100)]
Fix nonempty blank lines
Volker Lendecke [Sun, 23 Nov 2008 22:48:17 +0000 (23:48 +0100)]
Get rid of pipes_struct->pipe_user, we have server_info now --- YESSS!
Volker Lendecke [Sun, 23 Nov 2008 22:14:39 +0000 (23:14 +0100)]
Remove unused make_connection_with_chdir()
Volker Lendecke [Sun, 23 Nov 2008 22:13:11 +0000 (23:13 +0100)]
Convert delete_driver_files to use create_conn_struct
Jerry, please check!
Volker Lendecke [Sun, 23 Nov 2008 22:01:24 +0000 (23:01 +0100)]
Convert get_correct_cversion to use create_conn_struct
Jerry, please check!
Volker Lendecke [Sun, 23 Nov 2008 21:46:08 +0000 (22:46 +0100)]
Convert move_driver_to_download_area to use create_conn_struct
This removes a use of struct current_user and the vuid
The become_user() here is unnecessary, within the spoolss handling code we have
switched to the authenticated pipe user anyway.
Jerry, please check!
Steven Danneman [Mon, 24 Nov 2008 02:20:19 +0000 (18:20 -0800)]
Fix to allow setting of NULL DACL/SACL
This is a modification of Jeremy's
7522ef15aca2429ef57c75d8297dd8121e79c9da
commit.
If no DACL/SACL is present in the packet, the SEC_INFO field should still be
passed down as is to the VFS layer to signal the creation of a NULL DACL/SACL.
As seen in metze RAW-ACL test_nttrans_create_null_dacl(), a NULL DACL is set
regardless of the SEC_DESC_DACL_PRESENT bit being set.
Kai Blin [Sun, 23 Nov 2008 22:54:27 +0000 (23:54 +0100)]
s3-rpcclient; Really fix compile warning.
Screwed up in
526c609d, now the real fix.
Michael Adam [Sun, 23 Nov 2008 09:43:10 +0000 (10:43 +0100)]
libcli/nbt: fix some extrasemi compile warnings.
Michael
Volker Lendecke [Sun, 23 Nov 2008 21:21:26 +0000 (22:21 +0100)]
Add auth_serversupplied_info to create_conn_struct
srvsvc needs it, as will printing
Kai Blin [Sun, 23 Nov 2008 21:20:58 +0000 (22:20 +0100)]
s3-rpcclient: Fix a compile warning.
Kai Blin [Mon, 17 Nov 2008 15:38:02 +0000 (16:38 +0100)]
ctags: Ignore source3/includes/proto.h for tags.
Volker Lendecke [Sun, 23 Nov 2008 18:37:36 +0000 (19:37 +0100)]
Fix an uninitialized variable warning
Andreas Schneider, please check!
Volker Lendecke [Sun, 23 Nov 2008 11:13:48 +0000 (12:13 +0100)]
fix the build
Stefan Metzmacher [Sun, 23 Nov 2008 10:24:29 +0000 (11:24 +0100)]
RPC sessions on np connections need the real session key transferred
Michael Adam [Sun, 23 Nov 2008 00:59:30 +0000 (01:59 +0100)]
s3 build: when detecting to use internal zlib, put "-I../lib/zlib" first in CFLAGS
This should fix a build error on our Tru64 build farm box where a zlib.h is
found in an include path handed in via external CFLAGS, but that zlib.h belongs
to an old zlib. So in ndr_compression.c, "#include <zlib.h>" includes the wrong
header for the internal zlib.
Michael
Michael Adam [Sun, 23 Nov 2008 00:11:29 +0000 (01:11 +0100)]
s3-build: do not auto-genereate ndr tables but use checked-in tables.
This removes the build-dependency on perl that was introduced in
commit
e0905c30908b4d621030689d33de28a13c04a690.
The tables can now be re-built with "make ndr-tables".
This is also called by make samba3-idl to ensure that the tables
are updated after idl changes.
This hopefully fixes the build on some build farm hosts (e.g. gwen).
Michael
Michael Adam [Sat, 22 Nov 2008 22:25:14 +0000 (23:25 +0100)]
s3 build: don't specify ZLIB_LIBS (i.e. "-lz") in object collections.
This causes make to fail on at least HP-UX and MacOS X with message
"no rule to make target -lz" or similar, when these object collections
are specified in dependencies.
Michael
Volker Lendecke [Sat, 22 Nov 2008 17:31:52 +0000 (18:31 +0100)]
Add "net machinepw"
Provide a C-based alternative to the python script "mymachinepw"
Jeremy Allison [Sat, 22 Nov 2008 06:51:20 +0000 (22:51 -0800)]
Fix a C90 error.
Jeremy.
Jeremy Allison [Sat, 22 Nov 2008 06:48:37 +0000 (22:48 -0800)]
Rever
83ff6979f504d50caf725ee62549604630b69be7 - "Fix the logic bug that caused us to
run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On
opening the base_fsp we must break existing oplocks." as it broke make test.
Jeremy.
Jeremy Allison [Sat, 22 Nov 2008 02:20:38 +0000 (18:20 -0800)]
Fix the logic bug that caused us to run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks.
Jeremy.
Jeremy Allison [Sat, 22 Nov 2008 02:20:33 +0000 (18:20 -0800)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Michael Adam [Mon, 17 Nov 2008 11:48:26 +0000 (12:48 +0100)]
[s3]nfs4_acls: make prototype header match definition for smb_set_nt_acl_nfs4()
Add the const from nfs4_acls.c to nfs4_acls.h
This fixes my build of the zfsacl module on solaris.
Michael
Dan Sledz [Sat, 15 Nov 2008 02:41:17 +0000 (18:41 -0800)]
FreeBSD configure check for backtrace_symbols
On FreeBSD backtrace_symbols is defined in libexecinfo.so.1. Look for it
there as well.
Jeremy Allison [Sat, 22 Nov 2008 00:02:31 +0000 (16:02 -0800)]
Use fxattr calls whenever possible (trying to work around the strange Linux kernel oplock bug).
Jeremy.
Jeremy Allison [Fri, 21 Nov 2008 23:42:03 +0000 (15:42 -0800)]
Second part of the fix for bug #5903 - vfs_streams_xattr breaks contents of the file
(also fix a bad merge of the previous patch from 3.3).
Jeremy.
Michael Adam [Fri, 21 Nov 2008 22:17:05 +0000 (23:17 +0100)]
s3-winbindd: make all winbind rpc-methods static.
Now that the methods are no longer needed in winbindd_ads,
we can make them static again.
Michael
Michael Adam [Fri, 21 Nov 2008 01:26:50 +0000 (02:26 +0100)]
s3-winbindd_ads: use the reconnect methods instead of the rpc methods directly
Some of the ads methods just point to the rpc methods.
This makes winbindd_ads use the reconnect methods instead of
calling the rpc methods directly in order to prevent
negative cache entries for e.g. name_to_sid, when the dc
has closed the connection without sending a reset.
Michael
Michael Adam [Thu, 20 Nov 2008 15:57:44 +0000 (16:57 +0100)]
s3-winbindd_ads: prevent negative GM/ cache entries due to broken connections
The ads lookup_groupmem() function calls lda_lookupsids to resolve sids
to names. This is tried only once. So in case the connection was broken,
e.g. closed by the server (without a reset packet), there will be an empty
GM/ cache entry for the requested group which will prevent proper working
of access checks among other checks for the expiry period.
This patch works around this problem by retrying once if the lsa_lookupsids
call fails, re-establishing the dc-connection, as we already do in many other
places (e.g. the winbindd retry methods for the rpc layer).
Michael
Jeremy Allison [Fri, 21 Nov 2008 20:14:53 +0000 (12:14 -0800)]
First part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.
Restructures parts of open code so that fsp must be allocated before calling
open_file_ntcreate(_internal). Also fix up file ref-counting inside files.c.
Jeremy.
Jelmer Vernooij [Fri, 21 Nov 2008 16:57:44 +0000 (17:57 +0100)]
Fix include path for installation.
Günther Deschner [Fri, 21 Nov 2008 14:56:30 +0000 (15:56 +0100)]
s3-libnetjoin: fix build warning.
Guenther
Günther Deschner [Thu, 6 Nov 2008 12:37:03 +0000 (13:37 +0100)]
s3-libnetjoin: try to show a better error message upon invalid configuration.
Guenther
Tim Prouty [Fri, 21 Nov 2008 02:03:33 +0000 (18:03 -0800)]
s3/s4 build: Fix "might be unitialized" warning
Günther Deschner [Thu, 20 Nov 2008 23:53:11 +0000 (00:53 +0100)]
s3-winbindd: for now only change machine pwd when not using a system krb5 keytab.
Guenther
Tim Prouty [Thu, 20 Nov 2008 01:29:49 +0000 (17:29 -0800)]
s3 build: Fix incomplete types warnings
Yasuma Takeda [Thu, 20 Nov 2008 19:38:37 +0000 (11:38 -0800)]
Fix bug #5909 - MS-DFS does not work on Vista, if link name includes multibyte character.
Jeremy Allison [Thu, 20 Nov 2008 18:56:14 +0000 (10:56 -0800)]
Second part of fix for bug #5891 - smbd crashed when viewing the eventlog exported by "eventlog list". Don't leak memory on error paths.
Jeremy.
Jeremy Allison [Thu, 20 Nov 2008 18:45:18 +0000 (10:45 -0800)]
Fix the build, by some cut-and-paste error I got two versions of the same functions here.
Jeremy.
Günther Deschner [Thu, 20 Nov 2008 12:33:24 +0000 (13:33 +0100)]
s3-eventlog: remove trailing whitespace.
Guenther
Günther Deschner [Thu, 20 Nov 2008 12:30:34 +0000 (13:30 +0100)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 20 Nov 2008 12:29:44 +0000 (13:29 +0100)]
eventlog: fill in some unknowns and use flags bitmap in IDL.
Guenther
Günther Deschner [Thu, 20 Nov 2008 09:55:03 +0000 (10:55 +0100)]
s3-eventlog: avoid passing down full prs_struct in eventlog server.
Guenther
Günther Deschner [Wed, 19 Nov 2008 22:44:07 +0000 (23:44 +0100)]
s3-eventlog: move non rpc eventlog headers to own include file.
Guenther