Jeremy Allison [Fri, 4 Nov 2011 17:51:29 +0000 (10:51 -0700)]
Move the SEC_DIR_LIST check into dptr_create for SMB2 and now for SMB1.
The pathname check still needs fixing.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Nov 5 01:38:00 CET 2011 on sn-devel-104
Jeremy Allison [Fri, 4 Nov 2011 23:01:16 +0000 (16:01 -0700)]
can_write_to_file() does now take share permissions into account. Fix comment.
Jeremy Allison [Fri, 4 Nov 2011 22:56:15 +0000 (15:56 -0700)]
No longer do the pre-check on DELETE_ACCESS - we're correctly checking the ACL every time now.
Jeremy Allison [Fri, 4 Nov 2011 22:55:11 +0000 (15:55 -0700)]
Remove can_access_file_acl(). We no longer need this duplicate code (hurrah!).
Jeremy Allison [Fri, 4 Nov 2011 22:45:13 +0000 (15:45 -0700)]
Remove can_access_file_data() - make it use the standard smbd_check_access_rights() instead.
Jeremy Allison [Fri, 4 Nov 2011 22:39:55 +0000 (15:39 -0700)]
Add const to the smb_filename argument of smbd_check_access_rights().
Jeremy Allison [Fri, 4 Nov 2011 21:37:26 +0000 (14:37 -0700)]
Expose smbd_check_access_rights() to other modules.
Jeremy Allison [Fri, 4 Nov 2011 21:28:08 +0000 (14:28 -0700)]
Rename smbd_check_open_rights() to smbd_check_access_rights() as we're going to remove the static from this.
Jeremy Allison [Fri, 4 Nov 2011 21:21:35 +0000 (14:21 -0700)]
Replace smb1_file_se_access_check() with just se_access_check().
Jeremy Allison [Fri, 4 Nov 2011 21:07:23 +0000 (14:07 -0700)]
Move root check out of smb1_file_se_access_check() in preparation for deleting this function.
Jeremy Allison [Fri, 4 Nov 2011 20:11:01 +0000 (13:11 -0700)]
smb1_file_se_access_check() is now static to smbd/open.c
Jeremy Allison [Thu, 3 Nov 2011 18:49:22 +0000 (11:49 -0700)]
Revert "Change function signature of check_parent_access() to take char * instead of struct smb_filename."
This reverts commit
a11c0a41a35aa2b1c14333552045a65e3e50df1e.
Not needed.
Jeremy Allison [Thu, 3 Nov 2011 18:49:05 +0000 (11:49 -0700)]
Revert "Call check_parent_access() on readdir."
This reverts commit
a763edaf9c76afe2546c035fc090370301dd347b.
Checking the wrong thing..
Henry Wong [Fri, 4 Nov 2011 18:20:10 +0000 (11:20 -0700)]
Properly fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
Ensure we correctly null out the referenced pointer when we decrease the ref. count.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 4 21:12:13 CET 2011 on sn-devel-104
Christian Ambach [Fri, 4 Nov 2011 17:02:30 +0000 (18:02 +0100)]
s3:docs fix a series of typos in wbinfo manpage
s/choide/choice/
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Nov 4 19:38:53 CET 2011 on sn-devel-104
Christian Ambach [Fri, 4 Nov 2011 16:56:02 +0000 (17:56 +0100)]
s3:docs: some corrections for wbinfo
Parameters for --sid-aliases and --sid-to-fullname were not listed
properly in the SYNOPSIS section
Christian Ambach [Fri, 4 Nov 2011 16:34:48 +0000 (17:34 +0100)]
s3:smbd increase a debug level
logging disconnected clients with level 1 swamps the logs
Kai Blin [Fri, 30 Sep 2011 02:31:07 +0000 (19:31 -0700)]
dns: Fix offset check in ndr_pull_component
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Nov 4 17:25:16 CET 2011 on sn-devel-104
Kai Blin [Fri, 30 Sep 2011 02:30:39 +0000 (19:30 -0700)]
nbt: Fix offset check in ndr_pull_component
Kai Blin [Wed, 28 Sep 2011 02:51:55 +0000 (19:51 -0700)]
s4 dns: the opcode is called OPCODE_UPDATE in the RFC, not OPCODE_REGISTER
Kai Blin [Wed, 28 Sep 2011 01:05:38 +0000 (18:05 -0700)]
s4 dns: Handle QCLASS_NONE queries
Kai Blin [Wed, 28 Sep 2011 00:36:42 +0000 (17:36 -0700)]
s4 dns: Support DNS_QTYPE_ALL queries
Kai Blin [Tue, 27 Sep 2011 05:25:51 +0000 (22:25 -0700)]
dns: Build the python bindings
Stefan Metzmacher [Fri, 4 Nov 2011 12:49:05 +0000 (13:49 +0100)]
s3:smbd: also send the server name in the negprot response
This matches W2K (at least sp4) and higher.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 4 15:50:06 CET 2011 on sn-devel-104
Stefan Metzmacher [Fri, 4 Nov 2011 11:59:54 +0000 (12:59 +0100)]
s3:libsmb: also remember the optional server name from the negprot response
W2K (at least sp4) and higher also send the server name.
metze
Stefan Metzmacher [Fri, 4 Nov 2011 11:52:44 +0000 (12:52 +0100)]
s3:libsmb: the workgroup in the non-extended-security negprot is not aligned (#8573)
I've tested the fix against NT4 sp6a, W2K sp4, W2K8R2 and Win8pre0.
metze
Andreas Schneider [Wed, 2 Nov 2011 15:53:27 +0000 (16:53 +0100)]
systemd: Fix dependencies.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Nov 4 12:36:04 CET 2011 on sn-devel-104
Kai Blin [Fri, 21 Oct 2011 09:56:10 +0000 (11:56 +0200)]
s4 provision/dns: Move DNS-related setup to sambadns module
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Nov 4 09:15:54 CET 2011 on sn-devel-104
Kai Blin [Fri, 21 Oct 2011 09:04:07 +0000 (11:04 +0200)]
s4 provision/dns: Move secretsdb_setup_dns to the AD DNS specific setup
Michael Adam [Thu, 3 Nov 2011 22:59:55 +0000 (23:59 +0100)]
s3:selftest: improve logging in the registry upgrade test
Don't only log to the log file. Give "make test" a cance to grab
some output. And add some more messages.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Nov 4 01:58:20 CET 2011 on sn-devel-104
Björn Baumbach [Wed, 2 Nov 2011 19:02:35 +0000 (20:02 +0100)]
s3-selftest: add new registry upgrade test to test list
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Wed, 2 Nov 2011 19:05:24 +0000 (20:05 +0100)]
s3-selftest: introduce registry upgrade test
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Thu, 3 Nov 2011 21:30:11 +0000 (14:30 -0700)]
Fix bug #8562 - talloc: double free error.
Ensure we don't access an undefined pointer.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 4 00:09:46 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Thu, 27 Oct 2011 07:54:06 +0000 (09:54 +0200)]
s4:lib/registry - enhance registry tests in respect to default values
Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 3 21:41:17 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 28 Oct 2011 17:52:49 +0000 (19:52 +0200)]
s4:lib/registry/ldb.c - quit the deletion of a not-existing default value with WERR_BADFILE
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Tue, 25 Oct 2011 18:08:31 +0000 (20:08 +0200)]
s4:lib/registry/ldb.c - don't use search filters for base searches
They are not necessary in this case.
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Fri, 28 Oct 2011 16:20:47 +0000 (18:20 +0200)]
s4:lib/registry/regf.c - always generate debug messages on error cases
We need to know what is going on.
Reviewed-by: Jelmer
Günther Deschner [Thu, 3 Nov 2011 08:34:04 +0000 (09:34 +0100)]
s4-smbtorture: add some ndr validation tests for netlogon_samlogon_response structs.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Nov 3 20:08:20 CET 2011 on sn-devel-104
Günther Deschner [Thu, 3 Nov 2011 10:33:16 +0000 (11:33 +0100)]
torture: add torture_assert_guid_equal() macro.
Guenther
Günther Deschner [Wed, 2 Nov 2011 17:05:59 +0000 (18:05 +0100)]
waf: convert NDR_NBT into shared library.
Guenther
Günther Deschner [Wed, 12 Oct 2011 12:58:46 +0000 (14:58 +0200)]
nbt: create standard ndr_pull/push interface for common netlogon samlogon replies.
Guenther
Günther Deschner [Thu, 3 Nov 2011 09:30:37 +0000 (10:30 +0100)]
nbt: move netlogon_samlogon_response into librpc/ndr/ndr_nbt.h.
Guenther
Günther Deschner [Thu, 3 Nov 2011 13:40:46 +0000 (14:40 +0100)]
nbt: trim down header dependencies of nbt.idl.
Guenther
Günther Deschner [Thu, 3 Nov 2011 13:07:09 +0000 (14:07 +0100)]
s4: add some missing header dependencies.
Guenther
Günther Deschner [Thu, 3 Nov 2011 13:39:50 +0000 (14:39 +0100)]
nbt: move nbt_string ndr functions to ndr/ndr_nbt.c helper.
Guenther
Günther Deschner [Wed, 2 Nov 2011 17:31:40 +0000 (18:31 +0100)]
nbt: merge in LIBCLI_NDR_NETLOGON helper into NDR_NBT.
Guenther
Günther Deschner [Wed, 2 Nov 2011 19:08:25 +0000 (20:08 +0100)]
librpc: remove nbt dependency to svcctl.
Guenther
Günther Deschner [Wed, 2 Nov 2011 19:07:42 +0000 (20:07 +0100)]
librpc: remove nbt dependency to samr.
Guenther
Günther Deschner [Wed, 2 Nov 2011 17:14:07 +0000 (18:14 +0100)]
librpc: only let NDR_NBT depend on NDR_NBT_BUF.
Guenther
Stefan Metzmacher [Wed, 2 Nov 2011 18:08:54 +0000 (19:08 +0100)]
s3:param: change default of "* signing" to "default"
This should not change the bahavior.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 3 18:33:34 CET 2011 on sn-devel-104
Stefan Metzmacher [Wed, 2 Nov 2011 18:07:45 +0000 (19:07 +0100)]
s3:smbd: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:55:55 +0000 (18:55 +0100)]
s3:libsmb: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 18:00:57 +0000 (19:00 +0100)]
s3:lib: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:55:55 +0000 (18:55 +0100)]
s3:libsmb: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:libsmb: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:torture: s/Undefined/SMB_SIGNING_DEFAULT/ s/Required/SMB_SIGNING_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:lib: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:lib/netapi: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:libnet: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:winbindd: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:web: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:utils: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:nmbd: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:auth: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:client: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:34:27 +0000 (18:34 +0100)]
s3:param: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:21:49 +0000 (18:21 +0100)]
libcli/smb: use the same values for SMB_SIGNING_* as the source3 code uses
The source3 code currently uses:
#define Undefined (-1)
#define False false
#define True true
#define Required (3)
In order to make the rewrite easier we should match the values.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:19:18 +0000 (18:19 +0100)]
libcli/smb: remove unused SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:16:01 +0000 (18:16 +0100)]
s4:smb_server: s/SMB_SIGNING_SUPPORTED/SMB_SIGNING_IF_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:16:01 +0000 (18:16 +0100)]
s4:libcli/smb2: s/SMB_SIGNING_SUPPORTED/SMB_SIGNING_IF_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:16:01 +0000 (18:16 +0100)]
s4:libcli/raw: s/SMB_SIGNING_SUPPORTED/SMB_SIGNING_IF_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:13:45 +0000 (18:13 +0100)]
lib/param: use SMB_SIGNING_IF_REQUIRED instead of SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:11:51 +0000 (18:11 +0100)]
libcli/smb: add SMB_SIGNING_IF_REQUIRED as replacement for SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:10:17 +0000 (18:10 +0100)]
libcli/smb: SMB_SIGNING_AUTO is no longer used
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:09:23 +0000 (18:09 +0100)]
s4:libcli/smb2: remove unused SMB_SIGNING_AUTO handling
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:09:23 +0000 (18:09 +0100)]
s4:libcli/raw: remove unused SMB_SIGNING_AUTO handling
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:06:12 +0000 (18:06 +0100)]
lib/param: map "* signing = auto" to SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:03:24 +0000 (18:03 +0100)]
s4:smb_server: change the default for "server signing" to "default"
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:03:24 +0000 (18:03 +0100)]
lib/param: change the default for "client signing" to "default"
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:59:54 +0000 (17:59 +0100)]
s4:libcli/smb2: SMB_SIGNING_DEFAULT matches SMB_SIGNING_SUPPORTED on the client for now
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:59:54 +0000 (17:59 +0100)]
s4:libcli/raw: SMB_SIGNING_DEFAULT matches SMB_SIGNING_SUPPORTED on the client for now
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:25:45 +0000 (17:25 +0100)]
libcli/smb: add SMB_SIGNING_DEFAULT
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:50:23 +0000 (17:50 +0100)]
s4:smb_server/smb2: add the same SMB_SIGNING_AUTO logic as for smb1
metze
Stefan Metzmacher [Thu, 3 Nov 2011 06:34:30 +0000 (07:34 +0100)]
selftest/Samba4: use "server signing = on" for now
Otherwise the smb2.compound test fails as it doesn't work
with signing yet.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:48:45 +0000 (17:48 +0100)]
s4:smb_server/smb: make the SMB_SIGNING_AUTO behavior a bit easier to follow
The prepares a future change to SMB_SIGNING_DEFAULT.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:30:34 +0000 (17:30 +0100)]
s3:param: the behavior of "client/server signing = auto" is the same as "true"
So remove the special case for 'Auto'.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:21:03 +0000 (17:21 +0100)]
s4:libcli/smb2: let SMB_SIGNING_AUTO behave like SMB_SIGNING_SUPPORTED
This matches the smb1 behavior.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:02:03 +0000 (17:02 +0100)]
s4:libcli/raw: only use smb signing if required
This matches the source3 code, I want to have the behavior
in common before I put the config options in common.
Later we may change this consitently in all code.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 14:43:54 +0000 (15:43 +0100)]
s3:libsmb: restore the 3.6.x behavior signing config parameters
metze
Giampaolo Lauria [Tue, 1 Nov 2011 19:21:32 +0000 (15:21 -0400)]
samba-tool: Fix short description and error msgs in domain level
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Nov 3 16:53:16 CET 2011 on sn-devel-104
Giampaolo Lauria [Tue, 1 Nov 2011 19:16:53 +0000 (15:16 -0400)]
samba-tool: Fix --quiet option in domain samba3upgrade
--quiet option does not require an argument
Giampaolo Lauria [Fri, 21 Oct 2011 16:05:07 +0000 (12:05 -0400)]
samba-tool: Improve "delegation" command error handling
Change samdb toggle_userAccountFlags fcn to display more
meaningful error messages
Add flags string param to toggle_userAccountFlags
Change call to toggle_userAccountFlags in delegation command
to pass the flag name to be displayed in case of errors
Giampaolo Lauria [Fri, 21 Oct 2011 15:57:34 +0000 (11:57 -0400)]
samba-tool: Improve "delegation" command error message
Write a more specific error msg when the on|off arg is invalid
Giampaolo Lauria [Fri, 21 Oct 2011 15:49:29 +0000 (11:49 -0400)]
samba-tool: Improve "delegation" command error handling
Display a more meaningful error msg when user account not found
Assert when returned number of entries is not 0 or 1
Giampaolo Lauria [Fri, 21 Oct 2011 15:35:36 +0000 (11:35 -0400)]
samba-tool: Fix "delegation show" command synopsis
Removed "show" from synopsis as it is no longer necessary
David Disseldorp [Thu, 3 Nov 2011 11:54:00 +0000 (12:54 +0100)]
pkg: add comments to the systemd sysconfig file
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Thu Nov 3 15:11:27 CET 2011 on sn-devel-104
Björn Baumbach [Wed, 2 Nov 2011 14:27:30 +0000 (15:27 +0100)]
s3-build: add bin/dbwrap_tool to the BIN_PROGS2 dependencies
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Nov 3 11:52:53 CET 2011 on sn-devel-104
Björn Baumbach [Wed, 2 Nov 2011 12:40:36 +0000 (13:40 +0100)]
s3-registry: fix upgrade code
Assume REGDB_VERSION_V1 if no version key found in registry.tdb
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Wed, 2 Nov 2011 12:38:18 +0000 (13:38 +0100)]
s3-utils: net - Fix one error/usage message
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Fri, 28 Oct 2011 12:29:56 +0000 (14:29 +0200)]
s3-printing: fix typo
Signed-off-by: Michael Adam <obnox@samba.org>
git.samba.org / mat / samba.git / log