Stefan Metzmacher [Tue, 6 Apr 2010 10:22:54 +0000 (12:22 +0200)]
s3:rpc_transport_np: handle trans rdata like the output of a normal read
Inspired by bug #7159.
metze
(cherry picked from commit
911287285cc4c8485b75edfad3c1ece901a69b0b)
(cherry picked from commit
e2739a2bf37e654c37cbea6e510f63a7ce4adfea)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
2ce1bcd4e4430f311decb73b659c9b615d5bb4e9)
Stefan Metzmacher [Tue, 6 Apr 2010 12:14:53 +0000 (14:14 +0200)]
s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
36493bf2f6634b84c57107bcb86bcbf3e82e80fc)
(similar to commit
b58b359881c91ec382cfa1d6ba3007b8354b29cb)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
6166e1809516e6ab5911b56b20a4128b088828cf)
Stefan Metzmacher [Tue, 6 Apr 2010 12:06:39 +0000 (14:06 +0200)]
Fix broken pipe handling
Metze is right: If we have *any* error at the socket level, we just can
not continue.
Also, apply some defensive programming: With this async stuff someone else
might already have closed the socket.
(cherry picked from commit
f140bf2e6578e45b8603d4a6c5feef9a3b735804)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
67b51cc9e773fcbbc2b942a1de256e2c5b695008)
Stefan Metzmacher [Tue, 6 Apr 2010 12:04:33 +0000 (14:04 +0200)]
s3:rpc_client: close the socket when pipe is broken
Signed-off-by: Bo Yang <boyang@samba.org>
(similar to commit
aa70e44cd0576e5280e24cf35000369a47dd958f)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
407b9577febff6dfbe29106d783d64c41d6fe4e4)
Stefan Metzmacher [Tue, 6 Apr 2010 09:53:33 +0000 (11:53 +0200)]
s3: fix crash in winbindd (similar to commit
f8cc0e88fbbb082ead023e0cb437b1e12cf35459)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
be9a46c9cae2d05a7eb54e871e05480bd8caa609)
Karolin Seeger [Tue, 13 Apr 2010 18:06:14 +0000 (20:06 +0200)]
s3-docs: Fix typo in man idmap_ad.
Karolin
(cherry picked from commit
6389fac6db2f54d148222009b5e209cef5c6bdd7)
(cherry picked from commit
39dbf73a6fb4ad45eac259124b70042994d4f215)
(cherry picked from commit
1038d91f3c6d2be0a594226059c5379d3e2ffe58)
Björn Jacke [Wed, 6 Jan 2010 23:41:50 +0000 (00:41 +0100)]
s3:lib/time: remove TIME_T_MIN/MAX defines
we already get them from lib/util/time.h
(cherry picked from commit
f5729dbb6e720cb6076ea053f1ad0680259e6b39)
The last two patches address bug #7352 (TIME_T_MAX defines inconsistent).
(cherry picked from commit
be86206167acb55bee2722c48a5ea09535cf2b99)
Björn Jacke [Wed, 6 Jan 2010 23:40:09 +0000 (00:40 +0100)]
lib/util: move TIME_T_MIN/MAX defines into header file (cherry picked from commit
571ee54b791b93ad46e09ed563ef4a5582dcf0c8)
(cherry picked from commit
32b0c2c2c1d0e8f69de264f2c3c3b1d473f9ec4f)
Karolin Seeger [Mon, 12 Apr 2010 07:10:21 +0000 (09:10 +0200)]
WHATSNEW: Start release notes for Samba 3.4.8.
Karolin
(cherry picked from commit
6af316b30898cc2933d8a5925a62f4c8187fd6aa)
Jeremy Allison [Fri, 19 Feb 2010 22:24:17 +0000 (14:24 -0800)]
Second part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.
If server returns zero on a NP read. Report pipe broken.
Prevents client from looping if it thinks there should be
more data.
Jeremy.
(cherry picked from commit
0055e33dbed0e81548464d01bcf864255bab3159)
(cherry picked from commit
f5ca9f84e9b511c2ba7a4280b1997daa441f9877)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
c150cf25f1aa5f034baa08360d5be9b8b532b7cb)
Stefan Metzmacher [Tue, 6 Apr 2010 10:20:02 +0000 (12:20 +0200)]
First part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.
Ensure that subreq is *always* talloc_free'd in the _done
function, as it has an event timeout attached. If the
read requests look longer than the cli->timeout, then
the timeout fn is called with already freed data.
Jeremy.
(cherry picked from commit
ad77ae1d5870e06f8587ecf634e0b6bdcbb950d7)
(similar to commit
6e5b6b5acb30869eb63b25ed1406014101a5e89d)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
0223d59ea950c8180047fd5de6c85f92c4e37ad2)
Volker Lendecke [Mon, 5 Apr 2010 22:16:22 +0000 (15:16 -0700)]
s3: Fix bug 7326 -- can't write with vfs_full_audit active
(cherry picked from commit
d232dd9df261ff251fd624b2b984355d247bb301)
Bo Yang [Tue, 9 Feb 2010 09:02:20 +0000 (17:02 +0800)]
s3: signals are processed twice in child.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
8c8bb51de1ac2baa46ac0736fae12c034288e5d4)
Fix bug #7206 (duplicate signal handler, signals are processed twice in child
process).
(cherry picked from commit
e41d9e75084170fa41a9e313fa79bf351f879840)
Jeremy Allison [Wed, 31 Mar 2010 05:24:19 +0000 (22:24 -0700)]
Fix bug 7310 - DOS attribute inconsistency with MS Office
On rename we need to set the archive bit on the renamed file.
Jeremy
(cherry picked from commit
d5029023e1a44e1bfcbd4e5822d937fa03ba5a1b)
Jeremy Allison [Mon, 29 Mar 2010 21:24:18 +0000 (14:24 -0700)]
Fix bug 7307 - man net usershare mistake
Fix bad usage message, reported by headset001@yahoo.com.
Jeremy.
(cherry picked from commit
e14a6fbf8c9e4d16b2727e48c708ceccfd157e59)
(cherry picked from commit
9620f5fbe64910d86cae51345156a1a4dd71e231)
(cherry picked from commit
41c5ab50749b36557af7e2a16076d330d1c0063b)
Jeremy Allison [Fri, 26 Mar 2010 00:09:23 +0000 (17:09 -0700)]
Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
Ensure we don't dereference an array with an index of -1.
Jeremy.
(cherry picked from commit
e4127ab299e654777c43d983b2e0a158baa7d79a)
(cherry picked from commit
fcb4c51e79f648ae02f77784d46bcc9c7331d3cb)
Kai Blin [Fri, 26 Mar 2010 21:28:43 +0000 (14:28 -0700)]
s3 ntlm_auth: Don't malloc data that will be talloc_free()d
This fixes bug #7290
Thanks to Mohan <mohann@silver-peak.com> for the bug report.
(cherry picked from commit
36ecc6bed9bbf7ed6437433d89ec9d49da43e5ee)
Michael Karcher [Thu, 25 Mar 2010 00:33:21 +0000 (17:33 -0700)]
Fix bug #7269 - Job management commands don't work for CUPS queues.
Samba needs to retrieve pjob->sysjob from the CUPS response (as
is done in the iprint backend).
(cherry picked from commit
1790e88f0f9c4fae90dcb53101f70c97ba6a6a5d)
(cherry picked from commit
dc83d031398819c1b2c57aacf4f34c304cf09682)
Jeremy Allison [Thu, 18 Mar 2010 10:21:15 +0000 (11:21 +0100)]
s3-printing: Fix "printer admin" functionality.
Fix bug #7255 ("printer admin" parameter does not work as expected).
(cherry picked from commit
0d6d068bc4f76c2816f969fcce6013e1945794d4)
(cherry picked from commit
e74ced9f90ade37fa7bd179a91803f775c77e25b)
(cherry picked from commit
a99d9e7678de17486bf34320ef0fda071b24197a)
Günther Deschner [Tue, 16 Mar 2010 09:30:04 +0000 (10:30 +0100)]
s3-spoolss: Fix value-needed calculation in_spoolss_EnumPrinterData().
Guenther
Fix bug #7256 (incorrect value-needed calculation in
_spoolss_EnumPrinterData()).
(cherry picked from commit
400801c2314c5effd5165e77cdefc833dee1b6b2)
(cherry picked from commit
78ef22a6f297dcc8045e2479a3af6c1cba34ad16)
Volker Lendecke [Sun, 14 Mar 2010 20:18:34 +0000 (21:18 +0100)]
s3: Fix an uninitialized variable read
Found by Laurent Gaffie <laurent.gaffie@gmail.com>
Thanks for that,
Volker
Fix bug #7254 (An uninitialized variable read could cause an smbd crash).
(cherry picked from commit
9280051bfba337458722fb157f3082f93cbd9f2b)
(cherry picked from commit
3373b973ef892f013dbf6a1df805de158c0ff4e2)
Michael Adam [Mon, 8 Mar 2010 22:37:21 +0000 (23:37 +0100)]
s3:release-scripts: fix create-tarball to treat vendor patch level correctly
(cherry picked from commit
b845025daf2da85eb1af6cbfa7878cf59a32f2a6)
(cherry picked from commit
95c6a5a782caa77bc8bbe75de6ca249bc255507e)
(cherry picked from commit
64fbfee4d322381b8b877feaf1f71b778a88b7f4)
Günther Deschner [Tue, 9 Mar 2010 13:08:57 +0000 (14:08 +0100)]
s3: re-run make samba3-idl.
Guenther
The last 16 patches address bug #6727 (Printer issues on 3.4.x).
(cherry picked from commit
7586069115f9b385bba40c7c022a5b516463736f)
Günther Deschner [Mon, 7 Dec 2009 10:28:56 +0000 (11:28 +0100)]
s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.
Guenther
(cherry picked from commit
ef9d6580efc55ee040458b7cd76ebdc2e1276e98)
(cherry picked from commit
beeb98c693cba71573b1ff7fc6b0349ea4eda8ca)
Günther Deschner [Thu, 4 Mar 2010 16:58:49 +0000 (17:58 +0100)]
s3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx IDL change.
Guenther
(cherry picked from commit
9d5aa986357983fb6a422c0990a3f134e44874d5)
Günther Deschner [Thu, 4 Mar 2010 15:47:10 +0000 (16:47 +0100)]
s3-rpcclient: fix rpcclient after spoolss_EnumPrinterDataEx IDL change.
Guenther
(cherry picked from commit
becbb624eb90b84ff20b128de1aee5f5acfc3dbc)
(cherry picked from commit
e6168075943bf01af1bcf8c0b0ff50b4dc1de82d)
Günther Deschner [Thu, 4 Mar 2010 15:46:53 +0000 (16:46 +0100)]
s3-net: fix net after spoolss_EnumPrinterDataEx IDL change.
Guenther
(cherry picked from commit
a99ac4f236d9a93d4ca8bd874cbab89b155c644a)
(cherry picked from commit
9c752851bc7291edf05e364ef2f8f387a9984bfa)
Günther Deschner [Thu, 4 Mar 2010 15:47:33 +0000 (16:47 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl
Guenther
(cherry picked from commit
55326549852a3ab1114a8cb1536578ae02183eb8)
(cherry picked from commit
6e677a1242115f57b84eff254ed55af2651df771)
Günther Deschner [Thu, 4 Mar 2010 15:40:31 +0000 (16:40 +0100)]
spoolss: fix spoolss_EnumPrinterDataEx IDL.
Guenther
(cherry picked from commit
4df1047e8398a9af4df94c7e245d993d1f60ef5f)
(cherry picked from commit
a947b5f827884c18f0f4535f7be7e7cd5b42ee9c)
Günther Deschner [Thu, 4 Mar 2010 14:46:28 +0000 (15:46 +0100)]
s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.
Guenther
(cherry picked from commit
345eba78f7fc72f067cd3d95a7698081e09be85f)
Günther Deschner [Thu, 4 Mar 2010 14:39:59 +0000 (15:39 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDataEx after IDL change.
Guenther
(cherry picked from commit
fbb6d00eed6bca960aa53a5967a2dea426cacfe2)
(cherry picked from commit
017c4ac6c1c2a19345d1f79acf8179a995f38cb5)
Günther Deschner [Fri, 4 Dec 2009 23:52:28 +0000 (00:52 +0100)]
s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.
Guenther
(cherry picked from commit
697e615843e83d097c5479858a324195450f6c87)
Günther Deschner [Tue, 9 Mar 2010 12:20:10 +0000 (13:20 +0100)]
spoolss: rollback GetPrinterData{Ex} IDL.
Guenther
(cherry picked from commit
45195a2689f59be434037274f616083fd8930ffa)
Günther Deschner [Thu, 4 Mar 2010 14:34:22 +0000 (15:34 +0100)]
s3-net: fix net after spoolss_SetPrinterData{Ex} IDL change.
Guenther
(cherry picked from commit
b2adbea53007d560f95c09af407c1c51a8e78d14)
Günther Deschner [Thu, 4 Mar 2010 14:34:49 +0000 (15:34 +0100)]
s3-rpcclient: fix rpcclient after spoolss_SetPrinterData{Ex} IDL change.
Guenther
(cherry picked from commit
4956650369156dfff96ccc827e55697ec642240d)
(cherry picked from commit
7711fe5ca643b32a3873a94d21dc5ec9155ef940)
Günther Deschner [Thu, 4 Mar 2010 16:00:34 +0000 (17:00 +0100)]
s3-spoolss: fix _spoolss_SetPrinterData{Ex} after IDL change.
Guenther
(cherry picked from commit
9a934832797c3e72859770719e05d19a5eefa14d)
(cherry picked from commit
20cc464b000beab223aea4b58ff974da9a943806)
Günther Deschner [Fri, 4 Dec 2009 23:56:55 +0000 (00:56 +0100)]
s3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.
Guenther
(cherry picked from commit
167dca0cbf18baf40dd923f6f92421123d34b5a3)
(cherry picked from commit
6f9d646f8071543287466a4a616246b32c80e2ca)
Günther Deschner [Tue, 9 Mar 2010 12:01:13 +0000 (13:01 +0100)]
spoolss: rollback SetPrinterData{Ex} IDL.
Guenther
(cherry picked from commit
8c00f95c8d86f2c3c73ce84d3cc0f038d8e0ceb2)
Michael Adam [Mon, 8 Mar 2010 21:32:41 +0000 (22:32 +0100)]
s3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.
Michael
(cherry picked from commit
9113e14b291c10c824d2d8ea5cb28ffc0adcb63b)
Fix bug #7231 (vfs_tsmsm not built automatically).
(cherry picked from commit
8087ceb42d72f2a07f70e8ab5462775a08303546)
(cherry picked from commit
de89fcc1f60d7f287f87507d2187d4ca8966791c)
Volker Lendecke [Tue, 9 Mar 2010 10:14:14 +0000 (11:14 +0100)]
s3: Fix a NULL pointer dereference
Found by Laurent Gaffie <laurent.gaffie@gmail.com>.
Thanks!
Volker
(cherry picked from commit
25452a2268ac7013da28125f3df22085139af12d)
Fix bug #7229 (NULL pointer dereference).
(cherry picked from commit
bf40d130a1761daa14ce6a2cf3d02dbd9095c2b5)
(cherry picked from commit
6e8c643688a323c9a68baa9f015cffec65d75115)
SATOH Fumiyasu [Wed, 10 Mar 2010 03:15:44 +0000 (12:15 +0900)]
vfs_netatalk: Segfault if hide files or veto files has no ".AppleDouble"
Fix bug #1206 (netatalk vfs causes segfaults in samba).
(cherry picked from commit
531a9ebd52fe65196bb01632a296b40a92a43b4c)
(cherry picked from commit
12dc7210fdba44d4df87102d44ee1bb7fc51f9f3)
Karolin Seeger [Tue, 9 Mar 2010 09:42:40 +0000 (10:42 +0100)]
WHATSNEW: Start release notes for Samba 3.4.8.
Karolin
(cherry picked from commit
cf679452b32de243cea61349f93e661f61ba4988)
Karolin Seeger [Tue, 9 Mar 2010 09:39:40 +0000 (10:39 +0100)]
VERSION: Raise version number up to 3.4.8.
Karolin
(cherry picked from commit
16f92f795d8403988919f0890445acffa249e29a)
Karolin Seeger [Mon, 8 Mar 2010 19:53:38 +0000 (20:53 +0100)]
Revert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond to a read or write."
This reverts commit
c81c109a6ce83741bb5149a51ceb4ab30855e9f9.
This fixes bug #7222 (All users have full rigths on all shares)(CVE-2010-0728).
Karolin Seeger [Mon, 8 Mar 2010 19:52:56 +0000 (20:52 +0100)]
WHATSNEW: Prepare release notes for Samba 3.4.7.
Karolin
Karolin Seeger [Wed, 24 Feb 2010 15:08:26 +0000 (16:08 +0100)]
WHATSNEW: Start release notes for Samba 3.4.7.
Karolin
(cherry picked from commit
c8fbbbb888a6cc67e603ba04510f5504596b67d8)
Karolin Seeger [Wed, 24 Feb 2010 15:06:32 +0000 (16:06 +0100)]
VERSION: Raise version number up to 3.4.7.
Karolin
(cherry picked from commit
b280381ed338920b1746d0b2b7cd6ea6eb1f92b9)
Karolin Seeger [Tue, 23 Feb 2010 09:34:37 +0000 (10:34 +0100)]
WHATSNEW: Fix typo.
Karolin
(cherry picked from commit
7ca9130556239eca52ecf8586c19e77780851d93)
Karolin Seeger [Mon, 22 Feb 2010 14:57:46 +0000 (15:57 +0100)]
WHATSNEW: Update changes since 3.4.5.
Karolin
(cherry picked from commit
7b195c33584ed1c8125c174518fe8e3cd5337ded)
Stefan Metzmacher [Fri, 19 Feb 2010 07:11:24 +0000 (08:11 +0100)]
librpc/ndr: don't overwrite the content in ndr_push_relative_ptr2_end()
metze
(cherry picked from commit
76aa37f653fec2d511921768381db7da661750cb)
The last 25 patches address bug #6888 (REGRESSION: printing support for 64 bit
windows clients broken).
(cherry picked from commit
58b089f2176e564bf5563fbffa034cd22525ed6e)
Günther Deschner [Sat, 13 Feb 2010 02:45:25 +0000 (03:45 +0100)]
spoolss: use ndr_push_spoolss_PrinterInfo2 hand-marshalled version (moves devmode relative pointer down to sd).
Guenther
(cherry picked from commit
31a097560efddfabf31c4cc54e683603ee24521f)
Günther Deschner [Tue, 16 Feb 2010 01:48:01 +0000 (02:48 +0100)]
spoolss: add spoolss_security_descriptor.
Guenther
(cherry picked from commit
18564787e2f169cac26d361201c1a954b7e263b7)
Günther Deschner [Tue, 9 Feb 2010 15:47:32 +0000 (16:47 +0100)]
s3: re-run make samba3-idl.
Guenther
(cherry picked from commit
d35eb81c50340ed2ac14cdb9965fd13876ea8e64)
Günther Deschner [Tue, 16 Feb 2010 09:46:07 +0000 (10:46 +0100)]
security: make two bitmaps public.
Guenther
(cherry picked from commit
f10a2d773d141f67319e19b45c40101bb9cb6cf4)
(cherry picked from commit
b9748d59c09ffe9de7cbb953939cf89017dc8087)
Günther Deschner [Sat, 13 Feb 2010 03:27:05 +0000 (04:27 +0100)]
spoolss: make two bitmaps public.
Guenther
(cherry picked from commit
b64cd9857086f56e1e698ae34e51413b6414eb0b)
Stefan Metzmacher [Thu, 18 Feb 2010 14:36:08 +0000 (15:36 +0100)]
spoolss: make all security descriptors and devicemodes 4 byte aligned and add missing subcontexts.
Guenther
(cherry picked from commit
8f52957369bf8ce7591d5d9a1436ccb7e384c612)
(cherry picked from commit
a4cb14987143c2c1f28e82e5b6476e079ea051d3)
Günther Deschner [Mon, 14 Dec 2009 16:22:39 +0000 (17:22 +0100)]
spoolss: set NDR_RELATIVE_REVERSE flag for various unions that have relative pointers.
Guenther
(cherry picked from commit
6d0a39741dacd81e33b25a91fa28cdf983d10d84)
(cherry picked from commit
93aab77e24ecdd95ced8efe0c0f7bcdfb5ed2a1b)
Stefan Metzmacher [Thu, 18 Feb 2010 14:17:42 +0000 (15:17 +0100)]
ndr_spoolss_buf: use LIBNDR_FLAG_NO_NDR_SIZE in NDR_SPOOLSS_SIZE_*
metze
(cherry picked from commit
2059a165ee6f4d231aa4075d8ddea70b8df8944f)
(cherry picked from commit
3174acb66089b649ec2b859c1ef673814c44ffa4)
Stefan Metzmacher [Wed, 23 Dec 2009 14:52:39 +0000 (15:52 +0100)]
spoolss: use subcontext in NDR_SPOOLSS_PUSH_ENUM_OUT macro.
metze
(cherry picked from commit
a4c3aeb79306190b09e284a6a28e3b40fbc5823b)
(cherry picked from commit
4a8dda5b149a82b83d22dc7b0cf77573ef35580d)
Stefan Metzmacher [Thu, 18 Feb 2010 14:13:20 +0000 (15:13 +0100)]
libndr: fix ndr_size_* calculation with relative reverse buffers
metze
(cherry picked from commit
8310f02414efd3b792857ed20c636c4c114e1ba2)
(cherry picked from commit
56a6011221aec94b64ac4499b825ff96d1ed22b4)
Stefan Metzmacher [Thu, 18 Feb 2010 12:40:44 +0000 (13:40 +0100)]
libndr: for now align reverse relative pointers to 2 bytes by default.
This is just a hack and we should let the callers use FLAG_ALIGN2
explicit in future.
metze
(cherry picked from commit
4a76d29374769ba4c075b8d5767498848d2e17d6)
(cherry picked from commit
00d97b0a06bd1c2d0cb6d15b5560f2850323c1a9)
Stefan Metzmacher [Wed, 17 Feb 2010 20:24:40 +0000 (21:24 +0100)]
libndr: implement LIBNDR_RELATIVE_REVERSE handling
This is based on Guenther's initial code.
metze
(cherry picked from commit
31c7780c16651b284009874cf3da04587dc36d19)
(cherry picked from commit
33d03a884eefad8d8c43f3dbe457866282219965)
Günther Deschner [Mon, 14 Dec 2009 14:33:32 +0000 (15:33 +0100)]
libndr: store a subcontext buffer size in ndr_push_subcontext_start.
Guenther
(cherry picked from commit
05347754ee61f06466d6d9b7f390001992f793ce)
(cherry picked from commit
4efead4bea29aee555473e1350c3f5671b56c829)
Stefan Metzmacher [Wed, 17 Feb 2010 19:27:08 +0000 (20:27 +0100)]
libndr: give an error when ndr_push_relative_ptr2_start()/_end() is used with the RELATIVE_REVERSE flag
metze
(cherry picked from commit
b5f9c44da55abb28222441a7e064a2a25891981f)
(cherry picked from commit
2f8872bdff4f193043f5195f11ec6a8b44e0f8f1)
Günther Deschner [Tue, 9 Feb 2010 17:27:37 +0000 (18:27 +0100)]
libndr: add LIBNDR_FLAG_NO_RELATIVE_REVERSE so that relative reverse processing can be disabled for single structure elements.
Guenther
(cherry picked from commit
a2c34296fa6ca2ffb69cb69698a9b5f81803e8a8)
(cherry picked from commit
a026311c81bc8d7f154dad96b77c6121432384a3)
Günther Deschner [Mon, 14 Dec 2009 14:09:00 +0000 (15:09 +0100)]
libndr: add LIBNDR_FLAG_RELATIVE_REVERSE flag.
Guenther
(cherry picked from commit
ee13a51b0514ec3ac4ca9c532c2b101a08ec9784)
(cherry picked from commit
d0eb23b3cd9dbdd174d2c0cdbcdb41fbf2a6df53)
Günther Deschner [Wed, 16 Dec 2009 21:54:02 +0000 (22:54 +0100)]
libndr: change subcontext buffer allocation to allocate on subcontext_start.
Guenther
(cherry picked from commit
c9fa97b01774d767acfabaf1eec7a6aad1510440)
(cherry picked from commit
d2bb2f150a8cf4e18c0bbbc357e237261942dccb)
Stefan Metzmacher [Wed, 17 Feb 2010 19:00:36 +0000 (20:00 +0100)]
librpc/ndr: make ndr_push_relative_ptr2() static
metze
(cherry picked from commit
d4606cd2663823831d61a98ee719d6121cdcf450)
Stefan Metzmacher [Wed, 17 Feb 2010 19:00:04 +0000 (20:00 +0100)]
librpc/ndr_krb5pac: use ndr_push_relative_ptr2_start()/_end()
metze
(cherry picked from commit
e03591111a1b9c2f05c29a7afac4641f23f455f4)
(cherry picked from commit
8abc4b5dc5e06e846f0966c74a75f22e27504287)
Stefan Metzmacher [Wed, 17 Feb 2010 18:59:19 +0000 (19:59 +0100)]
librpc/ndr_drsblobs: use ndr_push_relative_ptr2_start()/_end()
metze
(cherry picked from commit
b423bd2115e006f9af5d40cf5b651e03739d53a0)
(cherry picked from commit
c495dd164771cfc8358713c5b07ddd07642fd33c)
Günther Deschner [Thu, 11 Feb 2010 17:54:31 +0000 (18:54 +0100)]
spoolss: fix relative pointers in ndr_push_spoolss_DriverInfo101.
Guenther
(cherry picked from commit
bfd6edb3e9339d602eb6514ff50c3bb6c671174e)
(cherry picked from commit
8232ada560194fc967cfcb4cb3d14e55e221c321)
Günther Deschner [Mon, 14 Dec 2009 13:17:05 +0000 (14:17 +0100)]
s3: re-run make full_idl.
Guenther
(cherry picked from commit
9be36f59cfd1d973feeb045da975aafc869abfbd)
Günther Deschner [Mon, 14 Dec 2009 13:09:22 +0000 (14:09 +0100)]
pidl: use ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
Guenther
(cherry picked from commit
a049d75193b284fe9efb28d303ea46ba407e5a7a)
(cherry picked from commit
c1c56a0ebd6a8c777d8aa8b7d45858d03e7dce57)
Günther Deschner [Mon, 14 Dec 2009 13:08:34 +0000 (14:08 +0100)]
libndr: add ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
Guenther
(cherry picked from commit
f52de6e2293de4a7ba4726025dd936228b51b5b5)
Jeremy Allison [Thu, 18 Feb 2010 19:22:44 +0000 (11:22 -0800)]
Fix bug #7154 - mangling method = hash can crash storing a name not containing a '.'
Fix use of uninitialized variable. This can lead to crashes if
mangling = hash processes names with no '.'.
Jeremy.
(cherry picked from commit
df13b1303a751962d8f7d5298b39e4a7500fef15)
(cherry picked from commit
7eaeb891c8aee880fb06733f998b2feb95ef9c36)
Jeremy Allison [Thu, 18 Feb 2010 20:21:10 +0000 (12:21 -0800)]
Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
The charset array allocated in init_chartest() is allocated
by MALLOC, but only some elements of it being set after allocation. Fix is to
memset to zero after allocation.
Jeremy.
(cherry picked from commit
a4e8210ba7d6d471cb9f17754244393b9c1e5930)
(cherry picked from commit
fcca63d5fd0b900bc4bdcfbfb21b14f655abbbf7)
Jeremy Allison [Wed, 17 Feb 2010 18:46:42 +0000 (10:46 -0800)]
Fix bug #6557 - Do not work VFS full_audit
Re-arrange the operations order so SMB_VFS_CONNECT is done
first as root (to allow modules to correctly initialize themselves).
Reviewed modules to check if they needed CONNECT invoked as
a user (which we previously did) and it turns out any of them
that cared needed root permissions anyway.
Jeremy.
(cherry picked from commit
2eb33851a753cbd5594d44243802388cff5ae152)
Karolin Seeger [Wed, 17 Feb 2010 16:39:15 +0000 (17:39 +0100)]
WHATSNEW: Update changes since 3.4.5.
Karolin
(cherry picked from commit
05e26adc494ad9066e2d4f438368a782db553916)
Jeff Layton [Tue, 16 Feb 2010 14:16:42 +0000 (09:16 -0500)]
cifs.upcall: allocate a talloc context for smb_krb5_unparse_name
cifs.upcall calls smb_krb5_unparse_name with a NULL talloc context.
Older versions of this function though will conditionally use
SMB_REALLOC instead of TALLOC_REALLOC when a NULL context is passed
in. To make it more consistent, just spawn a talloc context that
we can pass into this function.
Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=565446
https://bugzilla.samba.org/show_bug.cgi?id=6868
Reported-by: Ludek Finstrle <luf@seznam.cz>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
a8cc2fa09ed43a167f62711bef363a5ac335dc78)
Fix bug #6868 (make bin/cifs.upcall fails).
(cherry picked from commit
fa8d57323c0ff4f92f0aca57b41d237340121720)
Karolin Seeger [Tue, 9 Feb 2010 15:36:39 +0000 (16:36 +0100)]
s3-docs: Add missing para end tag.
Karolin
(cherry picked from commit
b78de63ef3cde53e3aabbe46654aac5a335f16a8)
(cherry picked from commit
d3738dbe1cabb0ad0acf5f8c9b5e8106285ca9a1)
Günther Deschner [Mon, 15 Feb 2010 10:34:17 +0000 (11:34 +0100)]
spoolss: disable GetPrinterDriver level 101 (as called by XP).
We still dont get the marshalling right, disable and XP will just fall back to
level 6.
Guenther
Fix bug #7136 (spoolss getprinterdriver2 level 101 marshalling bad).
(cherry picked from commit
4a55047465029f302c92c7490aeebc1daa7b4e85)
Günther Deschner [Thu, 7 Jan 2010 11:05:18 +0000 (12:05 +0100)]
s3-docs: fix eventlogadm manpage typo.
Guenther
(cherry picked from commit
c1ca00047d26ace240fa5f34b428392b5d61e6c3)
Fix bug #7137 (eventlogadm manpage typo for dump command).
(cherry picked from commit
5c4fff696638d3e682fa3c8951d560e891196fc4)
Jeremy Allison [Fri, 12 Feb 2010 00:03:02 +0000 (16:03 -0800)]
Fixes issue with preexec scripts creating a share directory, and problems if a smb.conf reload turns wide links back on after a connection is establised.
Includes git refs :
cd18695fc2e4d09ab75e9eab2f0c43dcc15adf0b
94865e4dbd3d721c9855aada8c55e02be8b3881e
5d92d969dda450cc3564dd2265d2b042d832c542
02a5078f1fe6285e4a0b6ad95a3aea1c5bb3e8cf
a6f402ad87ff0ae14d57d97278d67d0ceaaa1d82
from master.
Jeremy.
Fix bug #7104 ("wide links" and "unix extensions" are incompatible.)
(cherry picked from commit
16e73d88944ce644cccfa19a99338f5903c061f0)
Volker Lendecke [Sat, 13 Feb 2010 15:38:25 +0000 (16:38 +0100)]
s3: Fix typo found by jhell <jhell@DataIX.net>
(cherry picked from commit
271a4c60dbec0d001dc55df58de8e54274137853)
(cherry picked from commit
eb390b8f917f52eb28f46f39a19abdc717051f3d)
(cherry picked from commit
f8dbb021393edf9d8394b5b7adf03c3432257ce7)
Günther Deschner [Wed, 10 Feb 2010 23:44:06 +0000 (00:44 +0100)]
s3-spoolss: implement spoolss_EnumJobs level 3.
Level 3 has been added with NT 4.0 and Windows 7 (at least 64bit version) makes
use of it in order to display queued jobs. Windows 7 will *not* fall back to
level 2 if we just return WERR_UNKNOWN_LEVEL, instead there will be no printjobs
displayed at all.
Guenther
(cherry picked from commit
25001bbd1b0b32073073dab7cf5b78a2b902163f)
(cherry picked from commit
eacb3b7be16884bb6bfcc3b4db97708566d66c40)
Fix bug #7130 (enumjobs level 3 is required by win7).
(cherry picked from commit
7132ca8d41ce936287e5f64e3596c5d1d1b67769)
Stefan Metzmacher [Tue, 9 Feb 2010 11:57:01 +0000 (12:57 +0100)]
s3:passdb: only use gid_to_sid() result if the result is a group of our local sam
Otherwise retry with pdb_gid_to_sid().
metze
(cherry picked from commit
4dc2be2264926fe415e4e40e212f94793c9831d1)
Last seven patches address bug #7116 (pdb_ldap performance fixes).
(cherry picked from commit
8946a47fcebe57f459c59ee2cb163e15901ff996)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
5b5df3d1223d15d4fde9a2a2db83c60aaa266ca4)
Stefan Metzmacher [Fri, 5 Feb 2010 15:20:21 +0000 (16:20 +0100)]
s3:pdb_ldap: don't search for the users primary group, if we already know it
metze
(cherry picked from commit
6753fb1cf6a834b12b2a9dce3b1a9555390c17be)
(cherry picked from commit
da7cb9feacc7cb84499c73ef463d187a7b2754e8)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
0b2dd730a52ae9dbd622c50fb70492398f6503d9)
Stefan Metzmacher [Wed, 3 Feb 2010 10:32:41 +0000 (11:32 +0100)]
s3:pdb_ldap: optimize ldapsam_alias_memberships() and cache ldap searches.
ldapsam_alias_memberships() does the same LDAP search twice, triggered
via add_aliases() from create_local_nt_token().
This happens when no domain aliases are used.
metze
(cherry picked from commit
49ace81e19de231825216cbf07c7422687131bb6)
(cherry picked from commit
cb31c1df92b195b3fb80b6e21bfba83b8cd867fd)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
8f1c7c117b3bca058024daa34f777efa5ece88f8)
Stefan Metzmacher [Thu, 4 Feb 2010 16:19:57 +0000 (17:19 +0100)]
s3:pdb_ldap: try to build the full unix_pw structure with ldapsam:trusted support
And also store the gid_to_sid mappings in the idmap_cache.
metze
(cherry picked from commit
25038fa85ff69962ca0975f31802218a897aa1ec)
(cherry picked from commit
66a48d2226d245c373b744c7edea60b3daa57f0f)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
a2ff5f0dd08c40fdbea8cb11e1b18d996a4d8c39)
Stefan Metzmacher [Thu, 4 Feb 2010 16:16:59 +0000 (17:16 +0100)]
s3:passdb: speed up pdb_get_group_sid()
Use the cached version gid_to_sid() instead
of pdb_gid_to_sid().
And also avoid the expensive lookup_sid() call
for wellkown domain groups.
metze
(cherry picked from commit
e10d0869567436902c8b8cfb50f8c64148d554cb)
(cherry picked from commit
b0c8ff971934ef8aa21abece8693807e0a2ca722)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
5d97d5703dcf62f2c610316b2ba47483652368b3)
Volker Lendecke [Sun, 31 Jan 2010 14:18:51 +0000 (15:18 +0100)]
s3: Make pdb_copy_sam_account also copy the group sid
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
b99046fed1bf4a908ed856afb17c3c934c6d305d)
(cherry picked from commit
a1862c23346959cd0aa77653bf488e0686d14376)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
66b472fdd6e55550abe4db04b0666d56ec700a0e)
Stefan Metzmacher [Sat, 30 Jan 2010 21:28:19 +0000 (22:28 +0100)]
s3: shortcut gid_to_sid when "ldapsam:trusted = yes"
The normal gid_to_sid behaviour is to call sys_getgrgid()
to get the name for the given gid and then call the
getsamgrnam passdb method for the resulting name.
In the ldapsam:trusted case we can reduce the gid_to_sid
operation to one simple search for the gidNumber attribute
and only get the sambaSID attribute from the correspoinding
LDAP object. This reduces the number of ldap roundtrips
for this operation.
metze
(similar to commit
0fb99386d41241f62312d4bb535976344e5d6492)
(cherry picked from commit
479087716f50e8a1961163750b1d651dcd23dfc2)
Michael Adam [Sat, 14 Nov 2009 00:21:42 +0000 (01:21 +0100)]
s3:is_trusted_domain: shortcut if domain name == global_sam_name
A domain can't have a trust with itself.
This saves some roundtrips to the ldap server for ldapsam.
Michael
(cherry picked from commit
dc3a90cf21813526854c12db126d08ebf32f8ae5)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
c48405ed0ab0e3c3a0c1472e3bf874a4a64c0261)
Michael Adam [Sat, 14 Nov 2009 00:12:22 +0000 (01:12 +0100)]
s3:is_trusted_domain: shortcut if domain name is NULL or empty
This saves some roundtrips to LDAP in an ldapsm setup.
Michael
(cherry picked from commit
0aa5a60d3033fddd652eb4ea89abdf97db912df3)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
85d8565e8c5a290698d0f0599f851dc0bee50245)
Michael Adam [Mon, 16 Nov 2009 10:37:18 +0000 (11:37 +0100)]
s3: shortcut uid_to_sid when "ldapsam:trusted = yes"
The normal uid_to_sid behaviour is to call sys_getpwuid()
to get the name for the given uid and then call the
getsampwnam passdb method for the resulting name.
In the ldapsam:trusted case we can reduce the uid_to_sid
operation to one simple search for the uidNumber attribute
and only get the sambaSID attribute from the correspoinding
LDAP object. This reduces the number of ldap roundtrips
for this operation.
Michael
(cherry picked from commit
37dcc8a400ea41fb0a0559c9922cc41ac28ad045)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
91e40dfde99b08158b809590c44c22b503403157)
Michael Adam [Fri, 13 Nov 2009 15:16:50 +0000 (16:16 +0100)]
s3:smbd: also fill the memcache with sid<->id mappings in ldapsam_sid_to_id()
not only the persistent idmap cache.
Michael
(cherry picked from commit
ee2565bd461ccfb916c5290c883e5ced3af72141)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
05f23a8dd6824bb6af3f60304096e621e534f4d4)
Michael Adam [Fri, 13 Nov 2009 14:51:33 +0000 (15:51 +0100)]
s3:smbd: make idmap cache persistent for "ldapsam:trusted".
This stores the mappings found in the idmap cache (which lives
inside gencache). This cache is already read in sid_to_Xid()
and Xid_to_sid() for ldapsam:trusted, this fills the opposite
direction, massively reducing the number of ldap roundtrips
across smbd restarts.
Michael
(cherry picked from commit
d5537cbbf931f0bca519371bfd084fb0051acd57)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
c7220ff3a8281867ffc1a3bcaa992ca9eafba6ed)
Volker Lendecke [Mon, 18 May 2009 14:04:04 +0000 (16:04 +0200)]
Fix large paged search
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
afb06a8af3c4e86ef9960c8beb19a22f5fd0f3c2)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
cc529f47e10a87ef6688b14ec399edcd2e4e884d)
Björn Jacke [Fri, 30 Oct 2009 20:50:41 +0000 (21:50 +0100)]
=?utf-8?q?=D1=953:ldap:=20search=20for=20account=20policies=20in=20objectclass=20sambaDomain,=20not=20*
=20(cherry=20picked=20from=20commit=
20e5f41591504769b5c7beb5a35bb0f95b33d27a8b)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
4e66860d89872d2ba808761e0d58ed18e7ed428e)
Björn Jacke [Fri, 30 Oct 2009 23:45:09 +0000 (00:45 +0100)]
s3:ldap: don't search when no values where found (cherry picked from commit
70063522065ab3e5a21fb11db0097b808aa11100)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
0b7d7e7c3d6a5abe94a0864f1ccaf9d1c00b8b7d)