samba.git
13 years agovfs_gpfs: Block sendfile for offline files
Volker Lendecke [Wed, 4 May 2011 13:47:42 +0000 (15:47 +0200)]
vfs_gpfs: Block sendfile for offline files
(cherry picked from commit 41bde55821a6c18ace24330aede8d4928215e658)
(cherry picked from commit c2c29533fc4a7467130dff0582249cccc49e001e)

13 years agovfs_gpfs: Store the winattrs in st.vfs_private
Volker Lendecke [Wed, 4 May 2011 13:42:54 +0000 (15:42 +0200)]
vfs_gpfs: Store the winattrs in st.vfs_private

This avoids a considerable amount of gpfs_winattr calls
(cherry picked from commit 2329fb56a701804585d866817586b4d567966b92)
(cherry picked from commit 03a9d9dbce61ceb2506a0f193d6407c7d8f4c7e6)

13 years agos3: Properly deal with exited winbind children
Volker Lendecke [Wed, 4 May 2011 10:11:04 +0000 (12:11 +0200)]
s3: Properly deal with exited winbind children

When a winbind child exits, we need to immediately close the socket. If not,
the next request to that child will be sent to a socket without a listener,
leading to a failed request. This failed request will then trigger a proper
re-init.

This patch avoids the one failed request.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 13:32:16 CEST 2011 on sn-devel-104
(cherry picked from commit d08414b6799747f224ba02300585c8b15ac6bc0e)
(cherry picked from commit 2f6e5436a707f4eed15130dff664327352c776fa)

13 years agos3: Filter out duplicates in name_query()
Volker Lendecke [Tue, 3 May 2011 19:28:37 +0000 (21:28 +0200)]
s3: Filter out duplicates in name_query()

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 00:03:47 CEST 2011 on sn-devel-104
(cherry picked from commit 7febcb5ffeb2d92f2a4f8abe2c0dac91f5c8a53e)
(cherry picked from commit 64e7b7bf09940ab67a0beb5d770849f8bf9336e3)

13 years agos3-includes: when MADVISE support was reverted back in 2009, someone forgot this...
Günther Deschner [Tue, 3 May 2011 14:28:44 +0000 (16:28 +0200)]
s3-includes: when MADVISE support was reverted back in 2009, someone forgot this hunk.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May  3 22:06:20 CEST 2011 on sn-devel-104
(cherry picked from commit c616379e14f7db35429ac849bbc6eb3d4dc641ec)
(cherry picked from commit c4689460524a88f087a39423bb81ffd61ab885b7)

13 years agoѕ3/configure: move out generic CPPFLAGS in the solaris case here
Björn Jacke [Wed, 20 Apr 2011 21:40:30 +0000 (23:40 +0200)]
ѕ3/configure: move out generic CPPFLAGS in the solaris case here

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 862ff644ee564b2b3ed316da8c19df2f958aef66)
(cherry picked from commit 26f6f3bb7f5c79f6a5c95218f37f4f01620b5234)

13 years agoѕ3/configure: move out generic LDFLAGS in the solaris case here
Björn Jacke [Wed, 20 Apr 2011 21:32:12 +0000 (23:32 +0200)]
ѕ3/configure: move out generic LDFLAGS in the solaris case here

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 9738f35f2cef0af11c3390162a9c2a3841d6073b)
(cherry picked from commit ee0a341c8963ed72ccd1799c10567e4f5d400016)

13 years agos3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path
Björn Jacke [Wed, 20 Apr 2011 22:11:21 +0000 (00:11 +0200)]
s3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue May  3 13:04:11 CEST 2011 on sn-devel-104
(cherry picked from commit cd9a7c143c87fa0f1fda8a6c9b331b21ae6148a2)
(cherry picked from commit 56d3232ec117d5791c88bc771432ad4f9bfa775f)

13 years agos3: Handle EINTR from sys_poll correctly
Volker Lendecke [Tue, 3 May 2011 15:04:06 +0000 (17:04 +0200)]
s3: Handle EINTR from sys_poll correctly

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May  3 18:06:48 CEST 2011 on sn-devel-104
(cherry picked from commit 023260487517e835edd7f16c8485f9e84cf44667)
(cherry picked from commit 67acc4c263f0b3dd4951615e684bfe572f644812)

13 years agos3: Tune broadcast namequeries for unique names
Volker Lendecke [Mon, 2 May 2011 21:35:06 +0000 (23:35 +0200)]
s3: Tune broadcast namequeries for unique names

If we get a unique name via a broadcast query, there's no point in waiting the
full timeout. A unique name is just what its name says: unique. No point in
waiting longer.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May  3 00:57:24 CEST 2011 on sn-devel-104
(cherry picked from commit 8da8c36b53cc115f0d446b666fc24fc9423d808e)
(cherry picked from commit 9bffdda7f9b8a7e3e36c07f31fae227e2d8a7570)

13 years agos3: Make name_resolve_bcast return sockaddr_storage
Volker Lendecke [Sat, 30 Apr 2011 17:23:55 +0000 (19:23 +0200)]
s3: Make name_resolve_bcast return sockaddr_storage

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 20:40:46 CEST 2011 on sn-devel-104
(cherry picked from commit d87427973c0f43d85546f5875b223929ac1a50d4)
(cherry picked from commit 49bcea3c5022e451402005029c187d7dbac6c761)

13 years agos3: Remove ip_sevice from get_ipc_connect_master_ip
Volker Lendecke [Sat, 30 Apr 2011 15:10:35 +0000 (17:10 +0200)]
s3: Remove ip_sevice from get_ipc_connect_master_ip

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 18:16:28 CEST 2011 on sn-devel-104
(cherry picked from commit 020b691cf842f30ff42474c2b0102751b5fa17ac)
(cherry picked from commit ae0436dc7b3cce8fe2e7d9fa5e12deb12cd07f77)

13 years agoAdd POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a...
Jeremy Allison [Fri, 29 Apr 2011 23:18:14 +0000 (16:18 -0700)]
Add POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a directory are denied with EISDIR.

Don't strip access bits from wire flags when opening a directory.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 02:21:24 CEST 2011 on sn-devel-104
(cherry picked from commit de87f549b75d05a1198c490f6aa5c7e62c3fd4a5)
(cherry picked from commit 498bb38093e91b7d8c555e6ce900bd1af0789e2f)

13 years agoFix bug #8112 - POSIX extension opens of a directory are denied with EISDIR.
Jeremy Allison [Fri, 29 Apr 2011 23:15:55 +0000 (16:15 -0700)]
Fix bug #8112 - POSIX extension opens of a directory are denied with EISDIR.

Ensure create_options are passed down to SMB_VFS_CREATE_FILE().
Correctly set create_options is SMB_O_DIRECTORY is set or pathname
is known to be a directory.

Jeremy.
(cherry picked from commit 2cb53f066e0e42d923be89dd3a7e18ea7a1b7340)
(cherry picked from commit 1c64ff3b0d5b0379c1b5e6637ccdc67f3caec33f)

13 years agos4:libcli/util/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
s4:libcli/util/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May  2 15:02:56 CEST 2011 on sn-devel-104
(cherry picked from commit 6dd97ac093ee00281ed029d549d5882d76c2735d)
(cherry picked from commit d2c3354f2641350518792f8c10d34323d2053f5c)

13 years agos3:libsmb/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
s3:libsmb/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE

metze
(cherry picked from commit 76b3867547dd61d4ac9eda1551945c7c76087f4c)
(cherry picked from commit 38ea4e9526528228f04c362a2b3301f84539663f)

13 years agolibcli/util/ntstatus: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
libcli/util/ntstatus: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE

metze
(cherry picked from commit aae1f86952ceea7be0594ca44bf86536fb9aea37)
(cherry picked from commit ad8be76e21374df799e6156d013f5f4663c15ddd)

13 years agotalloc: use TC_UNDEFINE_SHRINK_CHUNK() instead of TC_INVALIDATE_SHRINK_CHUNK() for...
Stefan Metzmacher [Mon, 2 May 2011 11:50:52 +0000 (13:50 +0200)]
talloc: use TC_UNDEFINE_SHRINK_CHUNK() instead of TC_INVALIDATE_SHRINK_CHUNK() for realloc path

If we optimize on top of raw realloc() we need
TC_INVALIDATE_SHRINK_CHUNK together with TC_UNDEFINE_GROW_CHUNK
(with was missing and caused false positive valgrind warnings).

But that is really slow, as we do a lot of talloc_realloc calls in samba.

That's why we only to TC_UNDEFINE_SHRINK_CHUNK() for now.

metze
(cherry picked from commit f0f5ac18e55062dcde28003cebc09fa3eb6ae6a5)
(cherry picked from commit bae2c28276405ff68818a74c140d64101ce72f88)

13 years agotorture test for bug #8111 - CIFS VFS: unexpected error on SMB posix open.
Jeremy Allison [Fri, 29 Apr 2011 21:27:45 +0000 (14:27 -0700)]
torture test for bug #8111 - CIFS VFS: unexpected error on SMB posix open.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 00:33:40 CEST 2011 on sn-devel-104
(cherry picked from commit 440d71f6c76a4363f69eaf70cada69bdcb98c7bf)
(cherry picked from commit 187cd188635620ce66740dc0c86f55a211bfb9c7)

13 years agoFix bug 8111 - CIFS VFS: unexpected error on SMB posix open
Jeremy Allison [Fri, 29 Apr 2011 21:27:32 +0000 (14:27 -0700)]
Fix bug 8111 - CIFS VFS: unexpected error on SMB posix open

We are conflating the O_CREAT|O_EXCL with the O_TRUNC
processing, they need to be separate. We need to chose
using (O_CREAT|O_EXCL) first, then modify if O_TRUNC is
set. This needs two separate switch statements.

Jeremy
(cherry picked from commit 76739435fc8abf1f47193ec4db35a567b564c785)
(cherry picked from commit c5182ced05e4c259bd93fd6b8fdf84985ea123ad)

13 years agos3: Avoid a potential 100% CPU loop in winbindd
Volker Lendecke [Fri, 29 Apr 2011 11:00:14 +0000 (13:00 +0200)]
s3: Avoid a potential 100% CPU loop in winbindd

In the clustering case if ctdb is unhappy, winbindd_reinit_after_fork fails.
This can lead to an endless loop depending on the scheduling of the parent vs
child. Parent forks, child is immediately scheduled and exits. Parent gets
SIGCHLD, parent is then scheduled before it sends the request out to the child.
Parent tries to fork again immediately.

The code before this patch did not really take into account that
reinit_after_fork can fail. The code now sends the result of
winbindd_reinit_after_fork to the parent and the parent only considers the
child alive when it got NT_STATUS_OK.

This was seen in 3.4 winbind. winbind has changed significantly since then, so
it might be possible that this does not happen anymore in exactly this way. But
passing up the status of reinit_after_fork and only consider the child alive
when that's ok is the correct thing to do anyway.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr 29 17:58:19 CEST 2011 on sn-devel-104
(cherry picked from commit df099e66240c7670c9f7b7dcccb1c38216bac3ec)
(cherry picked from commit 59d1c3a296cede628b46edb74693e08e7f388c38)

13 years agos3: Make winbindd_reinit_after_fork return NTSTATUS
Volker Lendecke [Fri, 29 Apr 2011 10:53:13 +0000 (12:53 +0200)]
s3: Make winbindd_reinit_after_fork return NTSTATUS
(cherry picked from commit aa5abcaf7e2844e3bd3d8e8fe26488673ad3c00e)
(cherry picked from commit 31b9258c40365f97fdd707c9756764bc94392726)

13 years agos3: In winbind, close parent/child sockets
Volker Lendecke [Thu, 28 Apr 2011 11:26:57 +0000 (13:26 +0200)]
s3: In winbind, close parent/child sockets

This should further reduce fd load in winbind children
(cherry picked from commit 0757688eb34ec1a22bf8c28f72416d6684756647)
(cherry picked from commit 114cc59409932f6afc2149fd758784a8556374e9)

13 years agos3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH
Andrew Bartlett [Fri, 29 Apr 2011 02:00:57 +0000 (12:00 +1000)]
s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 0520da2bbe246c45d89bfdec0d399862ecb867ba)
(cherry picked from commit a02d91689858e0195f660e9b7f5d88004c06c8e0)

13 years agos3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR
Andrew Bartlett [Fri, 29 Apr 2011 01:57:02 +0000 (11:57 +1000)]
s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 0eca33bbf620678759bbe39efaa74f33f96efb74)
(cherry picked from commit 51023a0d5a46334e6370b9dec9f9722ddb28c1d8)

13 years agos3-smb Use FILE_ATTRIBUTE_VOLUME intead of aVOLID
Andrew Bartlett [Fri, 29 Apr 2011 01:52:48 +0000 (11:52 +1000)]
s3-smb Use FILE_ATTRIBUTE_VOLUME intead of aVOLID

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 08c90d6f2df85499f43c5766a62839e80437290f)
(cherry picked from commit 6b2730f1c6a32c198fa948749e9aed496e99366c)

13 years agos3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM
Andrew Bartlett [Fri, 29 Apr 2011 03:23:14 +0000 (13:23 +1000)]
s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 0a3c84b554f3862b3e558f62e67ceb8311b248ce)
(cherry picked from commit 983e1ac9f0051e924890c64be99c9a4e35ee411a)

13 years agos3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN
Andrew Bartlett [Fri, 29 Apr 2011 01:43:35 +0000 (11:43 +1000)]
s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 317e19aeb3fbdb21573b6ef1bc8c2af646a7e61e)
(cherry picked from commit a0071e39d67411d578e34a7d03dff9906ff5ea94)

13 years agos3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY
Andrew Bartlett [Fri, 29 Apr 2011 01:36:14 +0000 (11:36 +1000)]
s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 7f66ebde2e2975b079f6c135b131d064dab38624)
(cherry picked from commit 163267bb107368d5dd457cde5fbad40a6434752e)

13 years agoAdd FILE_ATTRIBUTE_VOLUME.
Jeremy Allison [Fri, 29 Apr 2011 16:08:20 +0000 (09:08 -0700)]
Add FILE_ATTRIBUTE_VOLUME.
(cherry picked from commit 2805f8596c42f2834db089c6f96a81651db6ad33)

13 years agos3-tevent: only include ../lib/util/tevent wrappers where needed.
Günther Deschner [Thu, 28 Apr 2011 15:38:09 +0000 (17:38 +0200)]
s3-tevent: only include ../lib/util/tevent wrappers where needed.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
(cherry picked from commit 50883cfeb4eed3d538f71443060745f8747044c9)
(cherry picked from commit c3b2d2579e1d7310724a2f9576f6d2af7843d457)

13 years agos3-tsocket: only include ../lib/tsocket/tsocket.h where needed.
Günther Deschner [Thu, 28 Apr 2011 15:26:40 +0000 (17:26 +0200)]
s3-tsocket: only include ../lib/tsocket/tsocket.h where needed.

Guenther
(cherry picked from commit 12476223c6aa7473c55bcf529639eefce8450680)
(cherry picked from commit 0afb13fed8d62fd147d59d14f3028a069203b224)

13 years agos3-build: remove some unused headers.
Günther Deschner [Thu, 28 Apr 2011 14:37:05 +0000 (16:37 +0200)]
s3-build: remove some unused headers.

Guenther
(cherry picked from commit bc6f24e89f2dd6204209fc9bacc7bfa9c22d0a57)
(cherry picked from commit 7ca8ea51f8fc5ca77a27211106007f323857341a)

13 years agos3: Close the winbind client fds after forking
Volker Lendecke [Wed, 27 Apr 2011 15:52:30 +0000 (17:52 +0200)]
s3: Close the winbind client fds after forking

In an overload situation, the winbind helper child process inherits all those
hundreds of fd's which it will never talk to. Close them.

We (Christian Ambach and me) just saw a crash in libkrb5. Christian's analysis
showed that libkrb5 also does select, probably exceeding FD_SETSIZE and
crashing due to that reason. The parent winbind in theory does not do Kerberos
at all, so this should fix that problem.

The crash is interesting because the child process did not really crash.
Somewhere in glibc backtrace() is called, probably due to an assert() or some
explicit consistency check. This then somehow generates a signal probably due
to corrupted memory structures. That signal triggers Samba to again call
backtrace(). This blocks hard on a ptrace_once(). Sorry for the long backtrace
here, but this *is* interesting.

The child process blocking and not really crashing makes the situation worse:
The parent process does not get told the child has crashed and more client
sockets pile up.

This patch is intended to put some relief on this problem by closing the
majority of sockets the parent holds.

(gdb) bt
\#0  0x00002ad686a2b07b in pthread_once () from /lib64/libpthread.so.0
\#1  0x00002ad6867adf87 in backtrace () from /lib64/libc.so.6
\#2  0x00002ad683eab27c in log_stack_trace () at lib/util.c:1580
\#3  0x00002ad683eab34b in smb_panic (why=0x2ad6841c6ec3 "internal error") at lib/util.c:1481
\#4  0x00002ad683e9af3e in fault_report (sig=1) at lib/fault.c:52
\#5  sig_fault (sig=1) at lib/fault.c:75 #6  <signal handler called>
\#7  0x00002ad68673b005 in _int_malloc () from /lib64/libc.so.6
\#8  0x00002ad68673c95d in calloc () from /lib64/libc.so.6
\#9  0x00002ad684503e25 in _dl_new_object () from /lib64/ld-linux-x86-64.so.2
\#10 0x00002ad6844ffadc in _dl_map_object_from_fd () from /lib64/ld-linux-x86-64.so.2
\#11 0x00002ad684501d43 in _dl_map_object () from /lib64/ld-linux-x86-64.so.2
\#12 0x00002ad68450ac8d in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
\#13 0x00002ad684506ed6 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2
\#14 0x00002ad68450a68c in _dl_open () from /lib64/ld-linux-x86-64.so.2
\#15 0x00002ad6867d0ba0 in do_dlopen () from /lib64/libc.so.6
\#16 0x00002ad684506ed6 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2
\#17 0x00002ad6867d0d07 in __libc_dlopen_mode () from /lib64/libc.so.6
\#18 0x00002ad6867adeea in init () from /lib64/libc.so.6
\#19 0x00002ad686a2b083 in pthread_once () from /lib64/libpthread.so.0
\#20 0x00002ad6867adf87 in backtrace () from /lib64/libc.so.6
\#21 0x00002ad68673285f in __libc_message () from /lib64/libc.so.6
\#22 0x00002ad68673a30f in _int_free () from /lib64/libc.so.6
\#23 0x00002ad68673a76b in free () from /lib64/libc.so.6
\#24 0x00002ad6853fe346 in krb5int_sendto () from /usr/lib64/libkrb5.so.3
\#25 0x00002ad6853fe511 in krb5_sendto_kdc () from /usr/lib64/libkrb5.so.3
\#26 0x00002ad6853df7c4 in ?? () from /usr/lib64/libkrb5.so.3
\#27 0x00002ad6853e0919 in krb5_get_init_creds () from /usr/lib64/libkrb5.so.3
\#28 0x00002ad6853e2a94 in krb5_get_init_creds_password () from /usr/lib64/libkrb5.so.3
\#29 0x00002ad684169ff1 in kerberos_kinit_password_ext (principal=0x2ad684702180 "<sanitized>", password=0x2ad6844c5bb0 "<sanitized>", time_offset=0, expire_time=0x2ad6846bf380, renew_till_time=0x0, cache_name=0x2ad6843cb3e0 "MEMORY:winbind_ccache", request_pac=false, add_netbios_addr=false, renewable_time=<value optimized out>, ntstatus=0x0) at libads/kerberos.c:223
\#30 0x00002ad68416a223 in ads_kinit_password (ads=0x2ad6846bf330) at libads/kerberos.c:327
\#31 0x00002ad68415f725 in ads_sasl_spnego_bind (ads=0x2ad6846bf330) at libads/sasl.c:812
\#32 0x00002ad68415dbc1 in ads_sasl_bind (ads=0x2ad6846bf330) at libads/sasl.c:1114
\#33 0x00002ad68415c09b in ads_connect (ads=0x2ad6846bf330) at libads/ldap.c:711
\#34 0x00002ad683e1b8f7 in ads_cached_connection (domain=0x2ad6846b07c0) at winbindd/winbindd_ads.c:124
\#35 0x00002ad683e1bc85 in sequence_number (domain=0x2ad6846b07c0, seq=0x2ad6846b0cd8) at winbindd/winbindd_ads.c:1233
\#36 0x00002ad683dffdd7 in refresh_sequence_number (domain=0x2ad6846b07c0, force=128) at winbindd/winbindd_cache.c:510
\#37 0x00002ad683e00520 in wcache_fetch (cache=<value optimized out>, domain=0x2ad6846b07c0, format=0x2ad68419901e "U/%s") at winbindd/winbindd_cache.c:638
\#38 0x00002ad683e04ac8 in query_user (domain=0x2ad6846b07c0, mem_ctx=0x2ad6846bc920, user_sid=0x7fff1d0cb8c0, info=0x7fff1d0cb810) at winbindd/winbindd_cache.c:1910
\#39 0x00002ad683df2d38 in winbindd_dual_userinfo (domain=0x2ad6846b07c0, state=0x7fff1d0cc9c0) at winbindd/winbindd_user.c:173
\#40 0x00002ad683e232e0 in fork_domain_child (child=0x2ad6846c2440) at winbindd/winbindd_dual.c:485
\#41 schedule_async_request (child=0x2ad6846c2440) at winbindd/winbindd_dual.c:319
\#42 0x00002ad683e229f2 in async_request_fail (state=0x2ad6846c1d00) at winbindd/winbindd_dual.c:214
\#43 0x00002ad683ebabec in run_events (ev=0x2ad6846aebf0, selrtn=0, read_fds=0x7fff1d0ce910, write_fds=<value optimized out>) at lib/events.c:123
\#44 0x00002ad683df08cb in process_loop (argc=<value optimized out>, argv=<value optimized out>, envp=<value optimized out>) at winbindd/winbindd.c:1113
\#45 main (argc=<value optimized out>, argv=<value optimized out>, envp=<value optimized out>) at winbindd/winbindd.c:1437

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Apr 28 12:06:12 CEST 2011 on sn-devel-104
(cherry picked from commit 2e1522f3785d542c429fce83264ad67f35bcef68)
(cherry picked from commit 284c00d86265b4f5e9be34e7896ea315d52cf082)

13 years agos3: Fix a strange German translation
Volker Lendecke [Thu, 28 Apr 2011 08:12:47 +0000 (10:12 +0200)]
s3: Fix a strange German translation
(cherry picked from commit a672707a185277343e06ca37fe85caf3bbfd6168)
(cherry picked from commit b71bd9ea78803df88996c283854d357db47704db)

13 years agoRemove another fstring in this code.
Jeremy Allison [Thu, 28 Apr 2011 00:16:36 +0000 (17:16 -0700)]
Remove another fstring in this code.
(cherry picked from commit d808d55af1bf86f2c89078aba8f8d4dbf7282b9f)
(cherry picked from commit 3d55b6ff8b9a2903b73434fee0a373c122d2bfe1)

13 years agoFixup (C) - we've both worked lots on this :-).
Jeremy Allison [Tue, 26 Apr 2011 23:31:28 +0000 (16:31 -0700)]
Fixup (C) - we've both worked lots on this :-).

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 27 21:56:29 CEST 2011 on sn-devel-104
(cherry picked from commit af599b3d90e10ea8858bd9ae6b44028c814690c4)
(cherry picked from commit 4e2dfb0c249723054869fc891b751ecba7dc1571)

13 years agoRemove fstrings from client struct. Properly talloc strings (ensuring we never end...
Jeremy Allison [Wed, 27 Apr 2011 19:06:25 +0000 (12:06 -0700)]
Remove fstrings from client struct. Properly talloc strings (ensuring we never end up with a NULL pointer).
(cherry picked from commit 1815f0298f33c949f78e181477e8474a37663ccd)
(cherry picked from commit 9cf389041ccc0605fe22d7f092a33a9bd9e698b3)

13 years agos3: Make cli_session_setup_lanman2 async
Volker Lendecke [Thu, 28 Apr 2011 00:02:37 +0000 (17:02 -0700)]
s3: Make cli_session_setup_lanman2 async
(cherry picked from commit a644eff10ef3fee53f4841652f204a124ab73c15)

13 years agos3: Make cli_session_setup_nt1 async
Volker Lendecke [Sun, 3 Apr 2011 09:44:35 +0000 (11:44 +0200)]
s3: Make cli_session_setup_nt1 async

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 531628e5580b41f693a7dcaeb846fb270752e00d)
(cherry picked from commit 3f206126825d29df8388dc86c998c8a631af997e)

13 years agos3: Make plaintext session setup async
Volker Lendecke [Sat, 2 Apr 2011 21:54:07 +0000 (23:54 +0200)]
s3: Make plaintext session setup async

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 40e2ee9cb622edb85f6c75902f8bd152ff21c7e7)
(cherry picked from commit b57b711c9cbbd1ed39bc81ecb32b67bfa0ca4d11)

13 years agos3: Remove cli_write
Volker Lendecke [Sat, 2 Apr 2011 14:44:40 +0000 (16:44 +0200)]
s3: Remove cli_write

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ca9ac7c4c7adc9d726f1fc1fa2b061bd181e3d7a)
(cherry picked from commit cd31054a5a437c8a7c6b896bf62ca58636ded226)

13 years agos3: Use cli_writeall instead of cli_write
Volker Lendecke [Sat, 2 Apr 2011 09:46:30 +0000 (11:46 +0200)]
s3: Use cli_writeall instead of cli_write

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0226428eb9d7c6d3a4984d571622f21e9c82e408)
(cherry picked from commit f7fe965685251e4fd884e8b93a3f28557e53af14)

13 years agos3: Add cli_writeall
Volker Lendecke [Tue, 26 Apr 2011 17:52:39 +0000 (10:52 -0700)]
s3: Add cli_writeall

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d018fccb705e91f33f3211cdc5b8a4006d032f65)
(cherry picked from commit 3cf133a258ca2e8016ba806eb334e69bfbb169af)

13 years agos3: Properly clean up in pthreadpool_init in case of failure
Volker Lendecke [Wed, 27 Apr 2011 20:18:12 +0000 (22:18 +0200)]
s3: Properly clean up in pthreadpool_init in case of failure

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 27 23:57:19 CEST 2011 on sn-devel-104
(cherry picked from commit a8a6433fec0a8dfa6a584cd7b742d469ccfa6273)
(cherry picked from commit 9078ceb6109a3f375afbcb864307d456bc4057dd)

13 years agos3-netapi: Fix Coverity CID #2302: FORWARD_NULL
Günther Deschner [Wed, 27 Apr 2011 13:41:49 +0000 (15:41 +0200)]
s3-netapi: Fix Coverity CID #2302: FORWARD_NULL

Guenther
(cherry picked from commit ee0b0dd3a150dea35ef57d5867519a7df382137c)
(cherry picked from commit 73a5bd3343c54579e0927eefd186f438f9275d85)

13 years agodocs: Fix a bogus )
Samba-JP oota [Wed, 27 Apr 2011 07:21:56 +0000 (09:21 +0200)]
docs: Fix a bogus )

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 27 10:21:14 CEST 2011 on sn-devel-104
(cherry picked from commit 9d5138fb2b37c4c7de5d62081e71600096fcf413)
(cherry picked from commit 5ca46ff1c66e956cf2962773cda0bdbe0e559602)

13 years agos3:vfs use gpfs_lib_init
Christian Ambach [Mon, 21 Feb 2011 17:25:36 +0000 (18:25 +0100)]
s3:vfs use gpfs_lib_init

With newer GPFS releases, libgpfs contains a function
gpfs_lib_init(). It marks the pseudo-device the lib uses
as interface to the GPFS kernel module to not be to
destroyed after each call to GPFS.
This saves us some microseconds creating and removing the device
each time we do a call to libgpfs.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Apr 26 20:52:36 CEST 2011 on sn-devel-104
(cherry picked from commit 7a4cff842d342d77631912fdcee05521506eec52)
(cherry picked from commit 89e7a97b3a9987e6c921b68335b554473f50cde2)

13 years agoWHATSNEW: %i and %I no langer contain IPv4 mapped IPv6 addresses
Stefan Metzmacher [Mon, 25 Apr 2011 15:35:44 +0000 (17:35 +0200)]
WHATSNEW: %i and %I no langer contain IPv4 mapped IPv6 addresses

metze
(cherry picked from commit b397f7896e76ead07aed3e6683995b0ede054573)

13 years agoWHATSNEW: Update changes since pre2. samba-3.6.0pre3
Karolin Seeger [Tue, 26 Apr 2011 17:58:48 +0000 (19:58 +0200)]
WHATSNEW: Update changes since pre2.

Karolin
(cherry picked from commit 6f4ce6270bd32566d85d75f00aa966c964827cdb)

13 years agos3-utils: Fix Bug #8106. Fix the build of smbget on HP NonStop.
Günther Deschner [Tue, 26 Apr 2011 12:58:01 +0000 (14:58 +0200)]
s3-utils: Fix Bug #8106. Fix the build of smbget on HP NonStop.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Apr 26 16:41:17 CEST 2011 on sn-devel-104
(cherry picked from commit 633dbabe912f43fd4199453720fab299ccfefe03)
(cherry picked from commit dfe0029521f67163bdea3f82ccd90d91f82d74e6)

13 years agos3-waf: try to fix the build on sunos5.
Günther Deschner [Thu, 21 Apr 2011 22:49:54 +0000 (00:49 +0200)]
s3-waf: try to fix the build on sunos5.

Guenther
(cherry picked from commit 0e003515703469e9f66f5119d401366697cdb767)
(cherry picked from commit 47a442c221024d5b18a61ce1c4c3b6bfd8c2fa6e)

13 years agos3-waf: fix typo in comment.
Günther Deschner [Thu, 21 Apr 2011 22:49:28 +0000 (00:49 +0200)]
s3-waf: fix typo in comment.

Guenther
(cherry picked from commit a505806aa088470c74ad3fbffac223d5400481fc)
(cherry picked from commit 77ecb74ac65fe12b387312f079aa4795076de791)

13 years agos3: Fix a typo
Volker Lendecke [Tue, 26 Apr 2011 10:40:07 +0000 (12:40 +0200)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Apr 26 13:31:08 CEST 2011 on sn-devel-104
(cherry picked from commit 77ea148f7fca0b3d19fa5d4ec99010bba55c618d)
(cherry picked from commit 218e1fc61d91020faf08cfc9f8b0a9b3e483ebb4)

13 years agos3: Allow unlimited parallelism in pthreadpool
Volker Lendecke [Mon, 25 Apr 2011 18:05:31 +0000 (20:05 +0200)]
s3: Allow unlimited parallelism in pthreadpool
(cherry picked from commit dbc36befb5459cd59ffe2527261886ec962ea941)
(cherry picked from commit efc70fd0039302daa97223004d56f8c87f63a0df)

13 years agos3: Remove unused code
Volker Lendecke [Mon, 25 Apr 2011 16:29:59 +0000 (18:29 +0200)]
s3: Remove unused code

This is done in name_query_send these days

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 25 19:24:58 CEST 2011 on sn-devel-104
(cherry picked from commit 80c395aef44785497387d8c41eb767efa435bf3e)
(cherry picked from commit 4572b3334f3a24facae6842087ac5cf649a6b0a2)

13 years agos3: Move setting the name_query timeout
Volker Lendecke [Mon, 25 Apr 2011 15:37:08 +0000 (17:37 +0200)]
s3: Move setting the name_query timeout

An async caller might want a different timeout behaviour
(cherry picked from commit a3d35ac44b53b8a79eac5c927ff771c1c6ceec12)
(cherry picked from commit 60b221587baeb6ced2ef2bf0559802c3756b1c74)

13 years agoNo longer need to call SMB_VFS_LSTAT - check name hasn't changed above is sufficient.
Jeremy Allison [Mon, 25 Apr 2011 19:45:49 +0000 (12:45 -0700)]
No longer need to call SMB_VFS_LSTAT - check name hasn't changed above is sufficient.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Apr 25 23:35:37 CEST 2011 on sn-devel-104
(cherry picked from commit d00f1febd50b4779e8c5588055ee1f601448550c)
(cherry picked from commit e4f6038fdefafd0e1020782f265843577bd44b53)

13 years agoCorrectly detect and deny symlinks anywhere in a path (not just the last component...
Jeremy Allison [Fri, 22 Apr 2011 05:29:06 +0000 (22:29 -0700)]
Correctly detect and deny symlinks anywhere in a path (not just the last component) if "follow symlinks = no".
(cherry picked from commit eeb24c17739dd0bccf561b142841a7d2e560cdd0)
(cherry picked from commit 78623e8ab4cef8e28194260dbb87535402cafd30)

13 years agos3-selftest Rename s3 DC environment to s3dc
Jeremy Allison [Mon, 25 Apr 2011 20:12:23 +0000 (13:12 -0700)]
s3-selftest Rename s3 DC environment to s3dc

This should avoid a clash with the s4 DC environment in a future
combined 'make test'.
(cherry picked from commit 2698b40a3d920cfc5bb85333818d98f2fced9d9d)

13 years agoselftest: put the target on the environment
Andrew Bartlett [Mon, 18 Apr 2011 03:44:36 +0000 (13:44 +1000)]
selftest: put the target on the environment

This will allow us to have a 'switch' target type that creates
environments from Samba3 or Samba4 as required.

Andrew Bartlett
(cherry picked from commit d041ed233d1b10604ef1b9f7f1e68f6f5cd96132)
(cherry picked from commit 2df698ffec823938566de0a3c7120d149b57bf0a)

13 years agos3: Run pthreadpooltest in make test
Volker Lendecke [Sun, 24 Apr 2011 08:36:56 +0000 (10:36 +0200)]
s3: Run pthreadpooltest in make test

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 25 10:39:12 CEST 2011 on sn-devel-104
(cherry picked from commit 422b2fa0d064f2afeeec400223bb8a47deecc4a5)
(cherry picked from commit 4aba6e44cbd2d3cb3b20d864008971f424d99878)

13 years agos3: Add pthreadpooltest to main build
Volker Lendecke [Sat, 23 Apr 2011 14:49:04 +0000 (16:49 +0200)]
s3: Add pthreadpooltest to main build
(cherry picked from commit 39375de8354b676904e1fea097a68178acd987e4)
(cherry picked from commit 37d963684aae4c80c4a3286bb22503592156b630)

13 years agos3: pthreadpool_sig_fd->pthreadpool_signal_fd
Volker Lendecke [Sun, 24 Apr 2011 08:09:45 +0000 (10:09 +0200)]
s3: pthreadpool_sig_fd->pthreadpool_signal_fd
(cherry picked from commit f4a0f856f31291dd316a937f8060d2f205e8d4d6)
(cherry picked from commit 28394b98affe38650c56cf37e110d08c71145f0f)

13 years agos3: Tiny doc for pthreadpool
Volker Lendecke [Sat, 23 Apr 2011 20:25:36 +0000 (22:25 +0200)]
s3: Tiny doc for pthreadpool
(cherry picked from commit 3c405f5e1d81d33a01ab822aeba93634338d5b25)
(cherry picked from commit 39ab4b06f8fde50489d68a554102fdcea78c1fec)

13 years agos3: Many pthreadpool fixes
Volker Lendecke [Fri, 22 Apr 2011 09:47:11 +0000 (11:47 +0200)]
s3: Many pthreadpool fixes

In particular, this makes it fork-safe
(cherry picked from commit 62689d8166b8e070f855e6910470796dd7e1b2c8)
(cherry picked from commit 2caf8e097cd8f724c7cd93c3f8e1fc3cd095d8ff)

13 years agos3: Fix Coverity ID 2478, UNINIT
Volker Lendecke [Sat, 23 Apr 2011 08:31:14 +0000 (10:31 +0200)]
s3: Fix Coverity ID 2478, UNINIT

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 23 14:11:22 CEST 2011 on sn-devel-104
(cherry picked from commit 123e5c1a75a7e6cfe245af05d2954ab126238acf)
(cherry picked from commit 5f21737a7413750622d87f1f71dbd6eec843e882)

13 years agos3:rpc_client: map fault codes to NTSTATUS with dcerpc_fault_to_nt_status()
Stefan Metzmacher [Sat, 23 Apr 2011 22:00:40 +0000 (00:00 +0200)]
s3:rpc_client: map fault codes to NTSTATUS with dcerpc_fault_to_nt_status()

Most fault codes have a NTSTATUS representation, so use that.

This brings the fault handling in common with the source4/librpc/rpc code,
which make it possible to share more highlevel code, between source3 and
source4 as the error checking can be the same now.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Apr 24 10:44:53 CEST 2011 on sn-devel-104
(cherry picked from commit f7bc84409a7a6736ec2cf1110dd7200a954e3b7e)
(cherry picked from commit 7031faeefc1c9ec5af5fdaee0bcfd3410640ff00)

13 years agos3:winbindd: let winbindd_lookup_names() use dcerpc_binding_handle functions
Stefan Metzmacher [Sat, 23 Apr 2011 21:57:19 +0000 (23:57 +0200)]
s3:winbindd: let winbindd_lookup_names() use dcerpc_binding_handle functions

metze
(cherry picked from commit e7cf7204e60552b45952325f343ea894fda21346)
(cherry picked from commit f8415f5cefa640a4da513335bc2d00a1bdc30bdf)

13 years agos3:winbindd: let winbindd_lookup_sids() dcerpc_binding_handle functions
Stefan Metzmacher [Sat, 23 Apr 2011 21:56:27 +0000 (23:56 +0200)]
s3:winbindd: let winbindd_lookup_sids() dcerpc_binding_handle functions

metze
(cherry picked from commit 7309daa532c9689d64ce3f33da522f23635213d6)
(cherry picked from commit 8b9bb30a6cc21152b642a8382cc2876d189cacde)

13 years agodocs-xml/smb.conf.5: %i and %I no longer contain IPv4 mapped IPv6 addresses
Stefan Metzmacher [Mon, 25 Apr 2011 15:40:25 +0000 (17:40 +0200)]
docs-xml/smb.conf.5: %i and %I no longer contain IPv4 mapped IPv6 addresses

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Apr 25 18:38:16 CEST 2011 on sn-devel-104
(cherry picked from commit 7269e455a7d4f659777b4ab7db5d8b68376c8d19)
(cherry picked from commit 632e11fa52cc790e962808e67da36ba0155f53b5)

13 years agos3:lib/util_sock: listen on IPv6 addresses with IPV6_ONLY (bug #7383)
Stefan Metzmacher [Sat, 23 Apr 2011 09:29:51 +0000 (11:29 +0200)]
s3:lib/util_sock: listen on IPv6 addresses with IPV6_ONLY (bug #7383)

This avoids getting IPv4 addresses as mapped IPv6 addresses
(e.g. ::ffff:192.168.0.1).

Before the bahavior was inconsistent between operating system
and distributions. Some system have IPV6_ONLY as default.

Now we consistently get AF_INET for IPv4 addresses and AF_INET6
for IPv6 addresses.

It also makes it possible to listen only on IPv6 now
as "::" doesn't imply "0.0.0.0" anymore. Which also
avoids confusing log messages that we were not able to
bind to "0.0.0.0".

metze
(cherry picked from commit a3a38ee90ab4ab2be68ac71d9c581daa6b9ee189)
(cherry picked from commit c4c49be416aeac890628c9a9f2fd7975860884d4)

13 years agos3:lib/access: normalize IPv4 mapped IPv6 addresses in both directions (bug #7383)
Stefan Metzmacher [Sun, 24 Apr 2011 19:20:19 +0000 (21:20 +0200)]
s3:lib/access: normalize IPv4 mapped IPv6 addresses in both directions (bug #7383)

metze
(cherry picked from commit 4bfe2d5655d97fbc7e65744425b5a098e77f5ba1)
(cherry picked from commit 62b2083c627abeb8a2fb7e5adc793c630d0d561c)

13 years agolib/util: add RBVAL, RBVALS, RSBVAL and RSRBVALS macros
Stefan Metzmacher [Sat, 23 Apr 2011 09:01:34 +0000 (11:01 +0200)]
lib/util: add RBVAL, RBVALS, RSBVAL and RSRBVALS macros

They pull and push [u]int64_t values in big endian.

metze
(cherry picked from commit c0441b17e6580de65d87d28bfd9ae72d09a3508f)
(cherry picked from commit 79c65e434283f41a1739cdbc132f0e78010b0b47)

13 years agos3:includes: simplify INO_T_VAL macros
Stefan Metzmacher [Sat, 23 Apr 2011 09:15:30 +0000 (11:15 +0200)]
s3:includes: simplify INO_T_VAL macros

metze
(cherry picked from commit 5b327085775f279976c66cdd5f105132fda0965a)
(cherry picked from commit 0ef0fd81ba863379f28e1bde2808fc48fbe38d4b)

13 years agos3:includes: simplify BIG_UINT macros
Stefan Metzmacher [Sat, 23 Apr 2011 09:10:05 +0000 (11:10 +0200)]
s3:includes: simplify BIG_UINT macros

metze
(cherry picked from commit d7aa2eb7b664c10551cb45c36d3b564d829e9d44)
(cherry picked from commit 90edf53dd5d3768ad97748cca90cb177709223dd)

13 years agos3:smbd/trans2: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's
Stefan Metzmacher [Sat, 23 Apr 2011 08:30:59 +0000 (10:30 +0200)]
s3:smbd/trans2: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's

We rely on uint64_t for a long time now...

metze
(cherry picked from commit 9127e555ab043000adc516a9177e43812e52fd4b)
(cherry picked from commit 3a9f8ec79c8a80430df81d97833f9c2816cfaef6)

13 years agos3:include/vfs.h: remove very old hints for vfs modules with interface version < 8
Stefan Metzmacher [Sat, 23 Apr 2011 08:17:27 +0000 (10:17 +0200)]
s3:include/vfs.h: remove very old hints for vfs modules with interface version < 8

The interface version is at 28 now, and this defines cause problem
on some systems, e.g. Tru64 defines vfs_init in the system headers.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Apr 23 12:07:35 CEST 2011 on sn-devel-104
(cherry picked from commit 64e7fba1be0d2897c5cee40b41f869bd9e5b272a)
(cherry picked from commit b82b990e30fe54d2733c4eb58e6e184c99a1acfe)

13 years agos3:smbd/nttrans: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's
Stefan Metzmacher [Sat, 23 Apr 2011 08:30:59 +0000 (10:30 +0200)]
s3:smbd/nttrans: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's

We rely on uint64_t for a long time now...

metze
(cherry picked from commit 4a4a774e61aa5d95fa4c90485c538629ce5d0c92)
(cherry picked from commit ae132446595bf6af167d32c32430e8dceecc94a0)

13 years agos3:lib/sysquota: remove ugly LARGE_SMB_OFF_T ifdef's
Stefan Metzmacher [Sat, 23 Apr 2011 08:27:37 +0000 (10:27 +0200)]
s3:lib/sysquota: remove ugly LARGE_SMB_OFF_T ifdef's

We rely on uint64_t for a long time now...

metze
(cherry picked from commit 5186209277e0fec5c9f0c4df2ac57a5e16f74470)
(cherry picked from commit 005ec263ac515bf76915a3364bd89d9ccf172107)

13 years agos3:libsmb: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's
Stefan Metzmacher [Sat, 23 Apr 2011 08:22:32 +0000 (10:22 +0200)]
s3:libsmb: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's

We rely on uint64_t for a long time now...

metze
(cherry picked from commit 75ad18037955b1e787e48648a09b0016b1cdce8f)
(cherry picked from commit 9e944049ea2b1cf6f7aed2e3b6319bb5138a5b65)

13 years agoWHATSNEW: Update changes since pre2.
Karolin Seeger [Mon, 25 Apr 2011 17:31:32 +0000 (19:31 +0200)]
WHATSNEW: Update changes since pre2.

Karolin
(cherry picked from commit 6c08f12699e8c527c26dae042e74d0453ebb6bf5)

13 years agoWHATSNEW: Add changes since pre2.
Karolin Seeger [Mon, 25 Apr 2011 17:22:44 +0000 (19:22 +0200)]
WHATSNEW: Add changes since pre2.

Karolin
(cherry picked from commit 423bad15899fb28bb7fa3ed4e02718cc478e29d1)

13 years agos3: Add a 10-second timeout for the 445 or netbios connection to a DC
Volker Lendecke [Sun, 17 Apr 2011 18:16:07 +0000 (20:16 +0200)]
s3: Add a 10-second timeout for the 445 or netbios connection to a DC
(cherry picked from commit 23a6af46c84cd9b738af403d80c5187d858eac03)
(cherry picked from commit 6be972bd5b55c29f3a3a1ebcbee654a2ece020b6)

13 years agos3: Fix Coverity ID 2047, UNUSED_VALUE
Volker Lendecke [Fri, 22 Apr 2011 08:05:42 +0000 (10:05 +0200)]
s3: Fix Coverity ID 2047, UNUSED_VALUE

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr 22 10:53:24 CEST 2011 on sn-devel-104
(cherry picked from commit b48e22347d9b2d0b3b128197b4ef662558b0f2e9)
(cherry picked from commit 045895d9e23edc6aa47f90eefe92799c80f746a3)

13 years agos3: Fix Coverity ID 2325, RESOURCE_LEAK
Volker Lendecke [Fri, 22 Apr 2011 07:51:42 +0000 (09:51 +0200)]
s3: Fix Coverity ID 2325, RESOURCE_LEAK
(cherry picked from commit 726fa732facef55da6a27750f9daf12145db6639)
(cherry picked from commit fab8a81963897659814b339254f2409292272a5d)

13 years agos3: Fix Coverity ID 2336, NULL_RETURNS
Volker Lendecke [Fri, 22 Apr 2011 07:48:10 +0000 (09:48 +0200)]
s3: Fix Coverity ID 2336, NULL_RETURNS
(cherry picked from commit f9e3af71d391027de353f0240f70e425e766c0e5)
(cherry picked from commit ec2513cc5baa1aafc173887a7dec45660506cf35)

13 years agos3: Fix Coverity ID 2335, CHECKED_RETURN
Volker Lendecke [Fri, 22 Apr 2011 07:45:54 +0000 (09:45 +0200)]
s3: Fix Coverity ID 2335, CHECKED_RETURN
(cherry picked from commit 018595e2587b5b5dd90bf318a1cf8b675e47b66b)
(cherry picked from commit 13d72e42e17c05c63670ce102981e9f8dd038290)

13 years agoasn1: Fix Coverity ID 2299, CHECKED_RETURN
Volker Lendecke [Fri, 22 Apr 2011 07:41:52 +0000 (09:41 +0200)]
asn1: Fix Coverity ID 2299, CHECKED_RETURN
(cherry picked from commit 4981adcca37391b6745f10f5849fedd7c944410d)
(cherry picked from commit ec3ca4ba431fdccfb3fdd3ddf13189158db8ab62)

13 years agos3: Fix Coverity ID 2307, NULL_RETURNS
Volker Lendecke [Fri, 22 Apr 2011 07:39:37 +0000 (09:39 +0200)]
s3: Fix Coverity ID 2307, NULL_RETURNS
(cherry picked from commit 3e8a8fad59cfdd053ad96afc39ea7d6e98b91764)
(cherry picked from commit 135cb711f0b052c37595f64e1859606c8d0e58b2)

13 years agos3: Fix Coverity ID 986, BUFFER_SIZE_WARNING
Volker Lendecke [Fri, 22 Apr 2011 07:34:35 +0000 (09:34 +0200)]
s3: Fix Coverity ID 986, BUFFER_SIZE_WARNING

strncpy can leave the destination unterminated
(cherry picked from commit 9a0676d5c947033ac41f700be9ba92ab1666814e)
(cherry picked from commit e3c271560adfab50568e06c7bfaba02cb5aae997)

13 years agos3: Fix Coverity ID 1340, NULL_RETURNS
Volker Lendecke [Thu, 21 Apr 2011 20:09:27 +0000 (22:09 +0200)]
s3: Fix Coverity ID 1340, NULL_RETURNS
(cherry picked from commit 7e7ad53cbd77ce2201fd46bd2c08a601725f9f5b)
(cherry picked from commit 139336bd8b58cea93c82f7da9c100d6cccfe5180)

13 years agoCosmetic. Fix bad indentation.
Jeremy Allison [Fri, 22 Apr 2011 00:25:13 +0000 (17:25 -0700)]
Cosmetic. Fix bad indentation.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 22 03:16:43 CEST 2011 on sn-devel-104
(cherry picked from commit e919e767fb846fc91160cf44cbc838a9b4f2a832)
(cherry picked from commit 67636bb27c75fb291a8adf36c6da0903fea3a8e9)

13 years agoFix compiler warning in debug message.
Jeremy Allison [Fri, 22 Apr 2011 00:22:44 +0000 (17:22 -0700)]
Fix compiler warning in debug message.
(cherry picked from commit 644046f064d73ff97f95a7dfbc5fca199f0dd973)
(cherry picked from commit 5adbcb5b293effd7cf26fd38f1cde821671b2085)

13 years agoRemove duplicate code - move to parent_dirname() as a common function.
Jeremy Allison [Thu, 21 Apr 2011 23:50:49 +0000 (16:50 -0700)]
Remove duplicate code - move to parent_dirname() as a common function.
(cherry picked from commit 20baa11f33c5282c609258e21a07c7255df7ae30)
(cherry picked from commit 42b2f84837f3978b0c24f3374dd876e7d7d84de7)

13 years agos3-vfs: rename open function to open_fn.
Günther Deschner [Wed, 20 Apr 2011 20:55:25 +0000 (22:55 +0200)]
s3-vfs: rename open function to open_fn.

This should finally fix the AIX build and allow to remove AIX specific ifdefs.

Guenther

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 21 02:01:20 CEST 2011 on sn-devel-104
(cherry picked from commit c7073f8b545976719bfdba7b7bbd460d595041d5)
(cherry picked from commit 02770631597d489851e52521a3f438533d18055e)

13 years agos3-build: move MAP_FILE define to the only place used.
Günther Deschner [Wed, 20 Apr 2011 16:21:25 +0000 (18:21 +0200)]
s3-build: move MAP_FILE define to the only place used.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Apr 20 19:16:47 CEST 2011 on sn-devel-104
(cherry picked from commit 0b89ce671250daddc86400ef4e1996c37c126025)
(cherry picked from commit c65b54c8ee1b9c1982eb81a1d7fa43ae46c0a378)

13 years agos4-smbtorture: restructure documentname handling in spoolss test a bit.
Günther Deschner [Wed, 20 Apr 2011 15:53:43 +0000 (17:53 +0200)]
s4-smbtorture: restructure documentname handling in spoolss test a bit.

Guenther
(cherry picked from commit c8f9515f193e634da2ef01c525e2a05a3d519862)
(cherry picked from commit bb88fdade421b0226805d32c448fa1be9eb7faa5)

13 years agos3-spoolss: fix debug statement in spoolss_addprinterex_level_2().
Günther Deschner [Wed, 20 Apr 2011 15:19:15 +0000 (17:19 +0200)]
s3-spoolss: fix debug statement in spoolss_addprinterex_level_2().

Guenther
(cherry picked from commit 0cf9b47725b50fd916a7ca56ca3f7e9c9263411a)
(cherry picked from commit 3d14ed92bb698a5f0f33c10f65cc840b330bb65c)

13 years agos3-smbd: fix the AIX 5.3 build.
Günther Deschner [Wed, 20 Apr 2011 15:54:24 +0000 (17:54 +0200)]
s3-smbd: fix the AIX 5.3 build.

(AIX defines open to be open64)

Guenther
(cherry picked from commit ae61a5c3d05192457f5a0b24dd9bd34317df566f)
(cherry picked from commit 317b5d8fad7320f186c71b64d4d0470be634c71d)