Jeremy Allison [Thu, 27 Oct 2011 23:48:13 +0000 (16:48 -0700)]
Remove the order dependency in parent_override_delete(), just check for & not ==.
Jeremy Allison [Thu, 27 Oct 2011 23:41:18 +0000 (16:41 -0700)]
The xcopy test requires "dos filemode=yes" as it opens with WRITE_OWNER.
Jeremy Allison [Wed, 26 Oct 2011 23:02:40 +0000 (16:02 -0700)]
Remove the mkdir and open functions from the ACL modules - main code paths now handle this.
Jeremy Allison [Wed, 26 Oct 2011 22:30:00 +0000 (15:30 -0700)]
Remove unused "struct security_descriptor" parameter from check_parent_access()
Jeremy Allison [Wed, 26 Oct 2011 22:03:28 +0000 (15:03 -0700)]
Finally do all the open checks inside open_file(). Checks inside
vfs_acl_common can now be removed.
Jeremy Allison [Wed, 26 Oct 2011 21:58:32 +0000 (14:58 -0700)]
Simplify smbd_check_open_rights() and move all the special casing inside it.
Jeremy Allison [Wed, 26 Oct 2011 21:47:52 +0000 (14:47 -0700)]
Move parent_override_delete() to before I need to use it.
Jeremy Allison [Wed, 26 Oct 2011 21:06:41 +0000 (14:06 -0700)]
Make smbd_check_open_rights() static.
Günther Deschner [Fri, 28 Oct 2011 10:03:58 +0000 (12:03 +0200)]
s3-net: Make sure to always re-use the "good" dc for the DNS updates as well.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 28 19:13:49 CEST 2011 on sn-devel-104
Andrew Bartlett [Tue, 25 Oct 2011 00:39:47 +0000 (11:39 +1100)]
lib/util Add ABI to the samba-module library
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Oct 28 14:42:43 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 24 Oct 2011 23:34:13 +0000 (10:34 +1100)]
lib/util Rename samba_modules_load -> samba_module_init_fns_for_subsystem
This is to provide a cleaner namespace in the public samba plugin
functions.
Andrew Bartlett
Andrew Bartlett [Mon, 24 Oct 2011 23:30:14 +0000 (10:30 +1100)]
lib/util Rename samba_init_module -> samba_module_init
This is to provide a cleaner namespace in the public samba plugin
functions.
Andrew Bartlett
Andrew Bartlett [Mon, 24 Oct 2011 23:11:06 +0000 (10:11 +1100)]
lib/util Rename samba_init_module_fns_run -> samba_module_init_fns_run
This is to provide a cleaner namespace in the public samba plugin
functions.
Andrew Bartlett
Andrew Bartlett [Mon, 24 Oct 2011 20:43:06 +0000 (07:43 +1100)]
lib/util Rename samba_init_module_fn -> samba_module_init_fn
This is to provide a cleaner namespace in the public samba plugin
functions.
Andrew Bartlett
Andrew Bartlett [Mon, 24 Oct 2011 08:39:53 +0000 (19:39 +1100)]
lib/util Split samba-modules library into public and private parts
This will allow OpenChange to get at the symbols it needs, without
exposing any more of this as a public API than we must.
Andrew Bartlett
Andrew Bartlett [Mon, 24 Oct 2011 08:07:12 +0000 (19:07 +1100)]
lib/util Rename load_samba_modules -> samba_modules_load
This is to provide a cleaner namespace in the public samba plugin
functions.
Andrew Bartlett
Andrew Bartlett [Mon, 24 Oct 2011 08:01:16 +0000 (19:01 +1100)]
lib/util Rename run_init_functions -> samba_init_module_fns_run
This is to provide a cleaner namespace in the public samba plugin
functions.
Andrew Bartlett
Andrew Bartlett [Sun, 23 Oct 2011 22:49:26 +0000 (09:49 +1100)]
lib/util Rename init_module_fn to samba_init_module_fn
This prepares for making the samba_module.h header public again, for OpenChange.
I am keen to avoid too much API namespace pollution if we can.
Andrew Bartlett [Sat, 22 Oct 2011 00:48:30 +0000 (11:48 +1100)]
gensec: Add parinoia about integer wrapping
Andrew Bartlett [Wed, 26 Oct 2011 06:59:47 +0000 (17:59 +1100)]
s3-selftest Add all the LOCAL-* smbtorture tests to make test
The extra knownfail and skip entries are for tests the currently do
not pass or hang. We need to work out why this happens, and fix the
test or the test invocation.
Andrew Bartlett
Andrew Bartlett [Wed, 26 Oct 2011 06:32:55 +0000 (17:32 +1100)]
s3-build: Remove libbigballofmud.so
We no longer need this, as all the small test binaries have either
been converted rolled into python bindings and python-subunit tests, or have
been moved into smbtorture.
--------------
/ \
/ REST \
/ IN \
/ PEACE \
/ \
| libbigballofmud.so |
| |
| |
| 26 October |
| |
| 2011 |
*| * * * | *
_________)/\\_//(\/(/\)/\//\/\///|_)_______
Andrew Bartlett
Andrew Bartlett [Wed, 26 Oct 2011 06:30:45 +0000 (17:30 +1100)]
s3-torture Remove t_stringoverflow as fstrcpy now uses strlcpy
Because we no longer use safe_strcpy() internally, we no longer have a
mode where we write to the end of the buffer in developer mode, and so
there isn't anything for this test to test.
Andrew Bartlett
Andrew Bartlett [Wed, 26 Oct 2011 06:25:59 +0000 (17:25 +1100)]
s3-selftest: Add LOCAL-sprintf_append
Andrew Bartlett [Wed, 26 Oct 2011 06:21:04 +0000 (17:21 +1100)]
s3-torture run t_strappend tests as LOCAL-sprintf_append
Andrew Bartlett [Wed, 26 Oct 2011 06:13:36 +0000 (17:13 +1100)]
s3-torture Run t_strappend test for less time
Andrew Bartlett [Wed, 26 Oct 2011 06:13:16 +0000 (17:13 +1100)]
s3-torture Fix t_strappend test
Andrew Bartlett [Wed, 26 Oct 2011 02:38:15 +0000 (13:38 +1100)]
selftest: Have only one set of selftest knownfail and skip files
Listing tests that are not ever proposed (eg samba4.* in the samba3 selftest)
is not an error, so just combine the lists.
This is being done because some folks trying to learn how our 'make
test' works are having trouble following the distributed nature of the
selftest system.
Andrew Bartlett
Andrew Bartlett [Wed, 26 Oct 2011 04:21:11 +0000 (15:21 +1100)]
selftest: Remove --target option and the ability to run 'samba4 only' tests
This simplifies the selftest system, and by default we always tested
all of samba3 and samba4 in the waf build. This simply removes a
rarely used option for testing only part of the system. The make test
TESTS="^samba3" syntax remains unchanged, so no functionality is lost.
Andrew Bartlett
Andrew Bartlett [Tue, 25 Oct 2011 22:28:08 +0000 (09:28 +1100)]
s3-torture remove unused t_push_ucs2.c t_strcmp.c t_strstr.c
These tests were incorportated into
source4/scripting/python/samba/tests/strings.py with
fa3e2fc8bb3e935c65b7043382cad1d649cb68a6.
Andrew Bartlett
Andrew Bartlett [Tue, 25 Oct 2011 22:22:40 +0000 (09:22 +1100)]
s3-torture remove unused t_asn1.c
This test was incorportated into lib/util/test/asn1_test.c with
ede98c0e5190bf59461703629d5a4742ad8e044f
Andrew Bartlett
Andrew Bartlett [Tue, 25 Oct 2011 01:52:00 +0000 (12:52 +1100)]
examples: rework wscript to use a loop
I think this format is more compact and easier to understand.
Andrew Bartlett
Günther Deschner [Thu, 27 Oct 2011 14:28:27 +0000 (16:28 +0200)]
s3-passdb: use tevent_context in passdb.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 28 13:09:47 CEST 2011 on sn-devel-104
Günther Deschner [Thu, 27 Oct 2011 14:19:07 +0000 (16:19 +0200)]
s3-smbldap: use tevent_context in smbldap.
Guenther
Andreas Schneider [Thu, 27 Oct 2011 15:11:19 +0000 (17:11 +0200)]
Add systemd service files.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Oct 28 11:34:27 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 27 Oct 2011 20:55:17 +0000 (22:55 +0200)]
s4:librpc/dcerpc_smb2: fix smb2_write_callback()
The should use smb2_write_recv() to get the result.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct 28 09:55:48 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 27 Oct 2011 20:55:17 +0000 (22:55 +0200)]
s4:librpc/dcerpc_smb: fix smb_write_callback()
The should use smb_raw_write_recv() to get the result.
metze
Michael Adam [Thu, 27 Oct 2011 22:11:08 +0000 (00:11 +0200)]
s4:torture:smb2: avoid leaking tree connects up to the main function from the durable_open test
The tree connects are handed in from the calling wrapper.
Those that are freed and reconnected inside the test function
can not be freed in the wrapper and stick to the torture_context
until this is released in the main function.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Oct 28 02:37:25 CEST 2011 on sn-devel-104
Michael Adam [Thu, 27 Oct 2011 22:05:44 +0000 (00:05 +0200)]
s4:torture:smb2: fix a nasty double free error.
This error manifested itself in sporadic "talloc_free with references" error.
Michael Adam [Thu, 27 Oct 2011 11:06:32 +0000 (13:06 +0200)]
s4:torture:smb2: fix a comment
Michael Adam [Wed, 26 Oct 2011 20:48:29 +0000 (22:48 +0200)]
s4:torture:smb2: be leass leaky in wrap_simple_2smb2_test()
Volker Lendecke [Thu, 27 Oct 2011 13:21:29 +0000 (15:21 +0200)]
s3-ctdb: Fix ctdb_read_req
If a complete request has come in already before we consumed it, the
ctdb_packet_fd_read_sync will block indefinitely. So always try packet_handler
first and only if that fails due to insufficient data, read from the socket.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Oct 27 22:12:05 CEST 2011 on sn-devel-104
Volker Lendecke [Wed, 26 Oct 2011 15:51:09 +0000 (17:51 +0200)]
s3-ctdb: Add debug to ctdb_processes_exist
Volker Lendecke [Wed, 26 Oct 2011 11:43:07 +0000 (13:43 +0200)]
s3: Use serverids_exist in parse_share_modes
This is the main reason for the preceding commits. We need to reduce the number
of round-trips to ctdb when checking the locking record entries for existence.
Using the plural version of process_exists gets the number of round-trips to
ctdb for process_exists down to 1.
Volker Lendecke [Wed, 26 Oct 2011 11:36:56 +0000 (13:36 +0200)]
s3: Add serverids_exist
Volker Lendecke [Wed, 26 Oct 2011 10:18:21 +0000 (12:18 +0200)]
s3: Add processes_exist
Volker Lendecke [Wed, 26 Oct 2011 09:36:21 +0000 (11:36 +0200)]
s3-ctdb: Make ctdbd_process_exists use ctdbd_processes_exist
Not strictly necessary, but more code exercise is good
Volker Lendecke [Sun, 23 Oct 2011 19:38:54 +0000 (21:38 +0200)]
s3-ctdb: Add ctdb_processes_exist
This sends out a number of process_exists controls in parallel and collects the
replies as they come in.
Volker Lendecke [Wed, 26 Oct 2011 08:58:25 +0000 (10:58 +0200)]
s3-ctdb: Allow ctdb_read_req to read any reqid
Volker Lendecke [Wed, 26 Oct 2011 08:56:32 +0000 (10:56 +0200)]
s3-ctdb: Don't hand out 0 as reqid
0 will be used as a wildcard reqid in ctdb_read_req
Volker Lendecke [Wed, 26 Oct 2011 11:54:55 +0000 (13:54 +0200)]
s3: Use talloc_tos() in parse_share_modes()
Volker Lendecke [Sun, 23 Oct 2011 18:56:08 +0000 (20:56 +0200)]
s3: Fix some nonempty blank lines
Volker Lendecke [Fri, 21 Oct 2011 10:04:59 +0000 (12:04 +0200)]
s3: Fix some type-punned warnings
Geza Gemes [Tue, 25 Oct 2011 19:47:24 +0000 (21:47 +0200)]
s4:wscript - install the two missing files "dlz_bind9.so" and "named.conf.dlz"
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 27 20:27:32 CEST 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 13:57:45 +0000 (15:57 +0200)]
s4:repl_meta_data LDB module - don't intercept the partition LDB module referrals
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Fri, 14 Oct 2011 07:51:04 +0000 (09:51 +0200)]
s4:repl_meta_data LDB module - rename operation - do not overwrite error messages
"ldb_error" could overwrite possibly useful error messages.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 14:02:10 +0000 (16:02 +0200)]
s4:repl_meta_data LDB module - remove pointless debug messages
These are displayed when an object just doesn't exist!
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Fri, 14 Oct 2011 07:27:56 +0000 (09:27 +0200)]
s4:repl_meta_data LDB module - always return the original LDB result codes on failure
And add "ldb_operr()" before the "return ret" to point out the position
where it failed (for "add_time_element" and "add_uint64_element")
Reworked after a suggestion by abartlet.
Matthias Dieter Wallnöfer [Fri, 14 Oct 2011 07:25:56 +0000 (09:25 +0200)]
s4:repl_meta_data LDB module - "dsdb_search_module_dn" already checks if len(res) == 1
No need to perform an additional check here. As a return value we should
always give back the original error code and not generate a new one (to
let the caller know what is going on).
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 07:51:18 +0000 (09:51 +0200)]
s4:ldap.py - fix up the dSHeuristics test to check for the right behaviour
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 06:48:08 +0000 (08:48 +0200)]
s4:objectclass_attrs LDB module - implement the dSHeuristics length checks correctly
Consider bug #8489
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 06:21:31 +0000 (08:21 +0200)]
s4:ldap.py - we test the creation of secrets already in the "systemOnly" testcase
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 06:53:17 +0000 (08:53 +0200)]
s4:ldap.py - enhance and fix up the object class test
Also address the problem described in bug #8486.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:17:33 +0000 (20:17 +0200)]
s4:objectclass LDB module - objectclass modify op. - remove superflous "talloc_strdup"
We are adding strings embedded in the schema structure which is basically
global and lives longer than the request - hence no duplication needed.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 15:58:37 +0000 (17:58 +0200)]
s4:objectclass LDB module - objectclass modify operations
According to bug #8486 the modification to direct related structural
object classes is possible (equal, child, parent).
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:33:53 +0000 (20:33 +0200)]
s4:objectclass LDB module - forbid to add unrelated objectclasses
E.g. unsatisfied abstract objectclasses, additional top-most structural
classes
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 07:29:08 +0000 (09:29 +0200)]
s4:objectclass LDB module - "objectclass_add" - small optimisation
This saves us from doing one "ldb_msg_find_element".
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:34:17 +0000 (20:34 +0200)]
s4:objectclass LDB module - "check_rodc_ntdsdsa_add"
For convention use "ldb_attr_cmp()".
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 17:49:31 +0000 (19:49 +0200)]
s4:objectclass LDB module - update copyright
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 26 Oct 2011 08:04:11 +0000 (10:04 +0200)]
s4:password_hash LDB module - fix compiler warning due to unsatisfied "switch"
Bail out on other LDB request types (only add and modify allowed).
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 11:03:44 +0000 (13:03 +0200)]
s4:ldap.py - fix up the UTF8 tests
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:54:23 +0000 (12:54 +0200)]
s4:ldap.py - reactivate some assertions in "test_all"
There should always be one result on both s4 and Windows.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:34:42 +0000 (12:34 +0200)]
s4:torture/ldap/basic.c - fix a typo
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Thu, 20 Oct 2011 20:29:43 +0000 (22:29 +0200)]
ldb:common/ldb_modules.c - fix a typo in comment
Reviewed-by: abartlet
Andreas Schneider [Mon, 26 Sep 2011 15:48:01 +0000 (17:48 +0200)]
s4-torture: Add a user creation check.
This adds a patch which creates a non-privileged user and then tries to
create a new user as the non-privileged user.
Pretty simple test but it found #8509.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Oct 27 18:51:14 CEST 2011 on sn-devel-104
Andreas Schneider [Thu, 15 Sep 2011 06:54:44 +0000 (08:54 +0200)]
s4-torture: Add a samr privilege check.
This is the first part which checks if a deleted user is propagated
correctly to all daemons and caches with user information are emtpy.
Andreas Schneider [Fri, 23 Sep 2011 14:57:25 +0000 (16:57 +0200)]
s4-torture: Add torture_delete_testuser().
Andreas Schneider [Fri, 23 Sep 2011 14:56:59 +0000 (16:56 +0200)]
s4-torture: Add domain_handle to test_join struct.
Andreas Schneider [Thu, 15 Sep 2011 15:26:18 +0000 (17:26 +0200)]
s3-build: Add .clang_complete.
Stefan Metzmacher [Thu, 27 Oct 2011 12:50:37 +0000 (14:50 +0200)]
s3:rpc_client: remove references to auth_ntlmssp_state
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct 27 16:40:15 CEST 2011 on sn-devel-104
Andreas Schneider [Thu, 27 Oct 2011 10:01:09 +0000 (12:01 +0200)]
s3: Enable uid wrapper.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Oct 27 15:06:58 CEST 2011 on sn-devel-104
Andreas Schneider [Sat, 8 Oct 2011 10:10:20 +0000 (12:10 +0200)]
replace: Add don't include unistd.h directly and add uid_wrapper.
Andreas Schneider [Fri, 7 Oct 2011 17:00:29 +0000 (19:00 +0200)]
s3: Include uid_wrapper where it is missing.
Andreas Schneider [Thu, 27 Oct 2011 10:00:53 +0000 (12:00 +0200)]
Include uid_wrapper correctly.
Andreas Schneider [Fri, 7 Oct 2011 14:01:13 +0000 (16:01 +0200)]
s3-waf: Don't link uid_wrapper more than once.
The uid_wrapper is linked in globally by default if enabled.
Andreas Schneider [Fri, 7 Oct 2011 19:06:57 +0000 (21:06 +0200)]
nsswitch: Disable uid_wrapper in libwbclient.
This way we don't have to link against it in the autoconf build.
Andreas Schneider [Sat, 8 Oct 2011 08:52:02 +0000 (10:52 +0200)]
uid_wrapper: Add uwrap_setresgid().
Andreas Schneider [Sat, 8 Oct 2011 08:08:37 +0000 (10:08 +0200)]
uid_wrapper: Fix build on UNIX platforms.
Andreas Schneider [Fri, 7 Oct 2011 16:58:58 +0000 (18:58 +0200)]
uid_wrapper: Handle euid and egid 0.
Andreas Schneider [Fri, 7 Oct 2011 16:02:33 +0000 (18:02 +0200)]
uid_wrapper: Make sure we have initialized the wrapper.
Andreas Schneider [Fri, 7 Oct 2011 16:06:53 +0000 (18:06 +0200)]
uid_wrapper: Fix prototypes.
Andreas Schneider [Sat, 8 Oct 2011 08:47:57 +0000 (10:47 +0200)]
replace: Add checks for setreuid and setregid.
Andreas Schneider [Fri, 7 Oct 2011 16:05:43 +0000 (18:05 +0200)]
replace: Make sure we compile without uid_wrapper.
Andreas Schneider [Thu, 27 Oct 2011 09:21:08 +0000 (11:21 +0200)]
s3-netlogon: Fix setting the machinge account password.
This bug has been found with uid wrapper.
Jeremy Allison [Wed, 26 Oct 2011 19:41:18 +0000 (12:41 -0700)]
Factor out the code checking if a parent should override DELETE_ACCESS into a function.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 23:15:05 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 26 Oct 2011 18:00:11 +0000 (11:00 -0700)]
Remove another level of indentation - deal with !NT_STATUS_OK individually.
Jeremy Allison [Wed, 26 Oct 2011 19:08:51 +0000 (12:08 -0700)]
Add early return on stat open without O_CREAT if file doesn't exist.
Reduces one level of indentation.
Stefan Metzmacher [Wed, 26 Oct 2011 13:47:21 +0000 (15:47 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in clitrans.c
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 17:53:15 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 13:46:33 +0000 (15:46 +0200)]
s3:libsmb: avoid using smb_flg2 in cli_trans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:44:52 +0000 (15:44 +0200)]
s3:libsmb: replace smb_size - 4 with MIN_SMB_SIZE in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:43:08 +0000 (15:43 +0200)]
s3:libsmb: use 'tevent_' instead of 'event_' in clitrans.c
metze