Stefan Metzmacher [Wed, 18 Feb 2009 09:00:50 +0000 (10:00 +0100)]
lib/tsocket: add tsocket_sendto_queue_send/recv()
metze
Stefan Metzmacher [Tue, 10 Mar 2009 20:12:31 +0000 (21:12 +0100)]
lib/tsocket: add tsocket_sendto_send/recv()
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:23:32 +0000 (09:23 +0100)]
lib/tsocket: add tsocket_recvfrom_send/recv()
metze
Stefan Metzmacher [Thu, 26 Feb 2009 14:37:44 +0000 (15:37 +0100)]
lib/tsocket: add an implementation for bsd style sockets.
metze
Stefan Metzmacher [Wed, 11 Mar 2009 09:25:07 +0000 (10:25 +0100)]
lib/tsocket: add a tsocket_guide.txt with a description of the design
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:14:26 +0000 (09:14 +0100)]
lib/tsocket: add some useful helper functions
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:10:54 +0000 (09:10 +0100)]
lib/tsocket: add generic socket abstraction layer
This will replace source4/lib/socket/.
metze
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Thu, 19 Mar 2009 13:31:43 +0000 (14:31 +0100)]
tevent: fix the nesting logic
Only tevent_loop_once and tevent_loop_until() should care
about the nesting level.
This fixes the samba3 printing code where we use tevent_loop_wait()
and don't allow nested events.
We still call the nesting hook for all levels, we need to decide
if we really want this...
metze
Stefan Metzmacher [Wed, 18 Mar 2009 07:46:38 +0000 (08:46 +0100)]
s3:libsmb: always create bytes array in cli_trans code
Otherwise we return NO_MEMORY without a reason for fragmented trans
requests, as talloc_append_blob() returns buf if we append a 0 length
blob. When we pass buf = NULL we'll get back NULL and then assume
NO_MEMORY...
metze
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
Stefan Metzmacher [Thu, 19 Mar 2009 08:06:38 +0000 (09:06 +0100)]
s3:lib/util_sock: use sys_recv() instead of sys_read() on sockets
This ways the pcap support in socket wrapper sees the received data.
metze
Björn Jacke [Wed, 18 Mar 2009 18:05:52 +0000 (19:05 +0100)]
fix some typos
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Thu, 19 Mar 2009 04:49:32 +0000 (21:49 -0700)]
Modify simple POSIX open test to use filenames containing a ':'
character. Should stop regressions of bug #6196.
Jeremy.
Jeremy Allison [Thu, 19 Mar 2009 03:56:48 +0000 (20:56 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
Jeremy Allison [Thu, 19 Mar 2009 03:02:26 +0000 (20:02 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Thu, 19 Mar 2009 03:00:28 +0000 (20:00 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
Andrew Tridgell [Thu, 19 Mar 2009 00:23:49 +0000 (11:23 +1100)]
use the tevent nesting code to avoid the uid problem in the VFS
backend
The vfs_unixuid module changes the uid of the process when executing
operations on behalf of the user. Within the VFS backend we may rely
on semi-async calls, such as winbind calls, which will call the event
loop again. To cope with this we need to ensure that while inside
those calls we revert the uid to root, then revert back to the
connected user when we have finished with the semi-async calls.
Andrew Tridgell [Thu, 19 Mar 2009 00:21:36 +0000 (11:21 +1100)]
fixed a logic bug in the tevent nesting code
The event nesting code never triggered as nesting.level was never
greater than 1. The main event loop needs to increase the nesting
level by 1.
I also added a paranoia check to the nesting setup call. The API as
currently written cannot support multiple nesting hooks, so we need to
abort if multiple hooks are tried.
Tim Prouty [Wed, 18 Mar 2009 21:49:50 +0000 (21:49 +0000)]
s3 onefs: Correctly error out when the read returns EOF
Also add some more debugging.
Jeremy Allison [Wed, 18 Mar 2009 22:44:13 +0000 (15:44 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
Günther Deschner [Wed, 18 Mar 2009 21:49:41 +0000 (22:49 +0100)]
s3: remove POLICY_HND.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:09:57 +0000 (15:09 +0100)]
s3-rpc_parse: remove some unused parsing code.
Guenther
Günther Deschner [Wed, 18 Mar 2009 20:54:26 +0000 (21:54 +0100)]
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.
Guenther
Günther Deschner [Wed, 18 Mar 2009 20:36:40 +0000 (21:36 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.
Guenther
Günther Deschner [Wed, 18 Mar 2009 11:22:22 +0000 (12:22 +0100)]
s3-rpc_parse: remove unused BUFFER5 and UNISTR3.
Guenther
Günther Deschner [Wed, 18 Mar 2009 17:10:01 +0000 (18:10 +0100)]
s3-rpc_client: remove unused CLI_DO_RPC_WERR macro.
Guenther
Zach Loafman [Wed, 18 Mar 2009 17:36:59 +0000 (10:36 -0700)]
s4 libcli: Add back Longhorn beta dialect as a constant
Also tweak how the dialect array and count is initialized.
Günther Deschner [Wed, 18 Mar 2009 16:45:30 +0000 (17:45 +0100)]
s3-smbcontrol: use correct PRINTER_NOTIFY flags.
Guenther
Günther Deschner [Wed, 25 Feb 2009 13:33:59 +0000 (14:33 +0100)]
spoolss: add my copyright.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:38:36 +0000 (16:38 +0100)]
s3-spoolss: remove include/rpc_spoolss.h.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:45:35 +0000 (00:45 +0100)]
s3-spoolss: remove rpc_server/srv_spoolss.c alltogether.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:43:31 +0000 (00:43 +0100)]
s3-spoolss: remove rpc_parse/parse_spoolss.c alltogether.
Good-Bye, last hand-marshalled rpc functions, rest in peace.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:41:47 +0000 (00:41 +0100)]
s3-spoolss: remove old spoolss_EnumPrinterDataEx.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:38:40 +0000 (00:38 +0100)]
s3-spoolss: use pidl for _spoolss_EnumPrinterDataEx.
Please note that this has been the last call in samba3 that was
using hand-marshalled rpc. With this commit all named pipe rpc services
in samba3 have now fully moved to pidl generated code :-)
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:37:33 +0000 (16:37 +0100)]
s3-spoolss: use printer and job notify enums provided by idl.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:16:25 +0000 (16:16 +0100)]
s3-spoolss: fix spoolss server after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:10:52 +0000 (16:10 +0100)]
s3-rpcclient: fix spoolss notify test after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:10:11 +0000 (16:10 +0100)]
s4-smbtorture: fix spoolss notify test after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:06:40 +0000 (16:06 +0100)]
spoolss: add custom ndr_print_spoolss_Field.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:48:48 +0000 (15:48 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:48:06 +0000 (15:48 +0100)]
spoolss: make spoolss_Field a nodiscriminant union of 2 sets of notify flag enums.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:05:44 +0000 (15:05 +0100)]
s3-rpc_parse: move prs_uint64 to rpc_parse/parse_prs.c.
Guenther
Günther Deschner [Wed, 18 Mar 2009 12:22:51 +0000 (13:22 +0100)]
s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL.
Guenther
Günther Deschner [Wed, 18 Mar 2009 11:46:40 +0000 (12:46 +0100)]
s3-printing: use marshall/unmarshall_sec_desc_buf in sec_desc_upg_fn().
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:25:15 +0000 (11:25 +0100)]
s3-spoolss: add registry_value_to_printer_enum_value.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:22:11 +0000 (11:22 +0100)]
s3-spoolss: add SPOOLSS_BUFFER_ARRAY macro.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:11:05 +0000 (11:11 +0100)]
spoolss: add ndr_size_spoolss_EnumPrinterDataEx_info in spoolss helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:10:25 +0000 (11:10 +0100)]
spoolss: rename NDR_SPOOLSS_SIZE_ENUM macro to NDR_SPOOLSS_SIZE_ENUM_LEVEL in
spoolss helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 02:00:37 +0000 (03:00 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterKey callers in RPC-SPOOLSS-WIN test.
Kai, please check.
Guenther
Günther Deschner [Wed, 18 Mar 2009 02:11:37 +0000 (03:11 +0100)]
spoolss: fix ndr_push_spoolss_EnumPrinterDataEx.
Guenther
Stefan Metzmacher [Mon, 16 Mar 2009 16:27:30 +0000 (17:27 +0100)]
s3:winbindd: accept new connections via fd events
metze
Stefan Metzmacher [Mon, 16 Mar 2009 15:14:20 +0000 (16:14 +0100)]
s3:winbindd: move non event related code out of process_loop() in the the caller
metze
Stefan Metzmacher [Mon, 16 Mar 2009 15:06:12 +0000 (16:06 +0100)]
s3:winbindd: remove unused close_winbindd_socket() function
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:55:39 +0000 (15:55 +0100)]
s3:smbd: use tevent_loop_once() in the parent event loop
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:47:57 +0000 (15:47 +0100)]
s3:printing: use tevent_loop_wait() instead of manual looping
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:56:11 +0000 (14:56 +0100)]
s3:printing: use a fd event to monitor the pipe to the parent
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:48:40 +0000 (14:48 +0100)]
s3:smbd: don't exit the parent when we have no connections
This code path can't really happen anymore, because
launchd support was removed with commit
e5a951325a6cac8567af3a66de6d2df577508ae4.
But it's confusing to have that code there...
metze
Günther Deschner [Wed, 18 Mar 2009 01:33:18 +0000 (02:33 +0100)]
s3-spoolss: use rpccli_spoolss_enumprinterdataex in ldap_printer.c.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:39:49 +0000 (01:39 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterDataEx tests.
sorry, I could swear this did compile...
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:38:01 +0000 (00:38 +0100)]
s3-spoolss: remove old rpccli_spoolss_enumprinterdataex.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:06:22 +0000 (01:06 +0100)]
s3-net: use rpccli_spoolss_enumprinterdataex.
Guenther
Günther Deschner [Tue, 17 Mar 2009 22:45:16 +0000 (23:45 +0100)]
s3-rpcclient: use rpccli_spoolss_enumprinterdataex wrapper.
Guenther
Günther Deschner [Tue, 17 Mar 2009 22:39:00 +0000 (23:39 +0100)]
s3-spoolss: add rpccli_spoolss_enumprinterdataex convenience wrapper.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:35:44 +0000 (00:35 +0100)]
spoolss: add ndr_push/pull_spoolss_EnumPrinterDataEx helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:08:38 +0000 (01:08 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:36:31 +0000 (00:36 +0100)]
spoolss: add spoolss_EnumPrinterDataEx triple call.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:07:49 +0000 (01:07 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:36:54 +0000 (00:36 +0100)]
spoolss: fix spoolss_PrinterEnumValues w.r.t. size calculation of PrinterData.
Guenther
Alexander Zagrebin [Tue, 17 Mar 2009 22:38:33 +0000 (15:38 -0700)]
Missing break in conversion function prevents tdb password database update.
Timur [Tue, 17 Mar 2009 21:46:53 +0000 (22:46 +0100)]
build: fix detection of netinet/ip.h on FreeBSD
Signed-off-by: Michael Adam <obnox@samba.org>
Timur [Tue, 17 Mar 2009 21:45:28 +0000 (22:45 +0100)]
build: format the header check for netinet/ip.h more nicely
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Tue, 17 Mar 2009 21:53:06 +0000 (14:53 -0700)]
Remove the global "struct cm_cred_struct" and associated calls, make
callers pass in a struct user_auth_info * instead. This commit causes
smbc_set_credentials() to print out a message telling callers to use
smbc_set_credentials_with_fallback() instead, as smbc_set_credentials()
has a broken API (no SMBCCTX * pointer). No more global variables used
in the connection manager API for client dfs calls.
Jeremy.
Günther Deschner [Tue, 17 Mar 2009 19:50:59 +0000 (20:50 +0100)]
s3-rpcclient: say that we are displaying a REG_MULTI_SZ in display_reg_value().
Guenther
Günther Deschner [Tue, 17 Mar 2009 19:52:58 +0000 (20:52 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 16 Mar 2009 20:09:36 +0000 (21:09 +0100)]
spoolss: add spoolss_PrinterEnumValues.
Guenther
Steve Langasek [Tue, 17 Mar 2009 21:08:28 +0000 (22:08 +0100)]
s3: Fix bugs in the detection of the GNU ld version (Bug #6147)
This bug results in a failure to use linker scripts to limit the set of symbols
exported by our shared libraries.
Signed-off-by: Michael Adam <obnox@samba.org>
Zach Loafman [Mon, 16 Mar 2009 16:24:06 +0000 (09:24 -0700)]
s4 torture: Win7 has a slightly different allowed access mask
Still investigating.
Zach Loafman [Fri, 13 Mar 2009 16:04:33 +0000 (09:04 -0700)]
s4 torture: Add a string version for NT_STATUS_WIN7_INVALID_RANGE
Also submitted a request to cifs-protocol for a real name for this
thing. Use win7 target logic in smb2 lock test, SMB2-LOCK now passes
against Win7.
Zach Loafman [Thu, 12 Mar 2009 15:32:58 +0000 (08:32 -0700)]
s4 libcli: Add SMB2.1 dialect to libcli
Negotiate 2.1 if possible, leave negotiate results in
transport->negotiate.dialect_revision.
Volker Lendecke [Mon, 16 Mar 2009 12:17:04 +0000 (13:17 +0100)]
Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
Stefan Metzmacher [Tue, 17 Mar 2009 19:18:31 +0000 (20:18 +0100)]
s4:build: require tevent 0.9.5
metze
Stefan Metzmacher [Tue, 17 Mar 2009 19:18:01 +0000 (20:18 +0100)]
tevent: change version to 0.9.5 after the ABI has changed
metze
Stefan Metzmacher [Tue, 17 Mar 2009 19:13:34 +0000 (20:13 +0100)]
tevent: store the location where a request was finished
This is very useful to find bugs.
You can use 'p *req' in gdb to show where
tevent_req_done(), tevent_req_error() or tevent_req_nomem()
was called.
metze
Stefan Metzmacher [Tue, 17 Mar 2009 09:42:55 +0000 (10:42 +0100)]
tevent: use an immediate event as trigger for tevent_queue
metze
Stefan Metzmacher [Tue, 17 Mar 2009 09:18:34 +0000 (10:18 +0100)]
tevent: use an immediate event fot tevent_req_post()
Now tevent_req_post() never fails
metze
Stefan Metzmacher [Tue, 17 Mar 2009 09:17:50 +0000 (10:17 +0100)]
tevent: use TALLOC_FREE() in tevent_req.c
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:06:52 +0000 (15:06 +0100)]
s3:events: add support for immediate events
metze
Stefan Metzmacher [Fri, 13 Mar 2009 14:47:33 +0000 (15:47 +0100)]
tevent: add support for immediate events
They're like directly triggered timed events,
but you can preallocated them and scheduling them
will not fail.
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:45:42 +0000 (14:45 +0100)]
s3:events: make use of tevent_common_loop_wait()
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:15:07 +0000 (14:15 +0100)]
tevent: add tevent_common_loop_wait() helper function and use it
tevent_loop_wait should do the same for all backends.
It should loop as long as we have pending events.
metze
Stefan Metzmacher [Mon, 16 Mar 2009 11:45:48 +0000 (12:45 +0100)]
tevent: check signal events first in event_loop_once
We also check for signal events directly before and after
the select/epoll calls.
metze
Stefan Metzmacher [Mon, 16 Mar 2009 11:34:23 +0000 (12:34 +0100)]
tevent: let tevent_loop_once() just run one fd event
This makes the logic much simpler for the callers,
and matches the samba3 behavior.
If needed we can add performance tunning for tevent_loop_wait()
later.
metze
Günther Deschner [Tue, 17 Mar 2009 17:36:43 +0000 (18:36 +0100)]
s3-spoolss: remove unused RPC_BUFFER definition.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:34:45 +0000 (18:34 +0100)]
s3-spoolss: remove (disabled) enum_all_printers_info_1_remote.
Jerry, please check. I do not understand how this could work and in
it's current form, we cannot make this even compile anymore, I'm afraid :)
I think it is safe to remove.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:03:36 +0000 (18:03 +0100)]
s4-smbtorture: fix spoolss notify test for notify type changes.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:03:10 +0000 (18:03 +0100)]
s3-spoolss: remove PRINTER_NOTIFY_TYPE and JOB_NOTIFY_TYPE now defined in IDL.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:31:18 +0000 (17:31 +0100)]
s3-spoolss: remove SPL Port definitions now in IDL.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:25:07 +0000 (17:25 +0100)]
s3-spoolss: remove PRIORITY defines, that were never used.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:24:47 +0000 (17:24 +0100)]
s3: re-run make samba3-idl.
Guenther