ddiss/samba.git
13 years agos3-epmapper: Make sure we work on a description duplicate.
Andreas Schneider [Thu, 24 Mar 2011 13:39:56 +0000 (14:39 +0100)]
s3-epmapper: Make sure we work on a description duplicate.

13 years agolibrpc: Added a dcerpc_binding_dup() function.
Andreas Schneider [Thu, 24 Mar 2011 13:39:37 +0000 (14:39 +0100)]
librpc: Added a dcerpc_binding_dup() function.

13 years agos3-epmapper: Refactor the cleanup of endpoints.
Andreas Schneider [Thu, 24 Mar 2011 12:07:54 +0000 (13:07 +0100)]
s3-epmapper: Refactor the cleanup of endpoints.

13 years agos3-epmapper: Use strcmp instead of strequal and check IPv6.
Andreas Schneider [Thu, 24 Mar 2011 12:07:05 +0000 (13:07 +0100)]
s3-epmapper: Use strcmp instead of strequal and check IPv6.

13 years agos3: Fix some errno assignments in SMBC_opendir_ctx
Volker Lendecke [Thu, 24 Mar 2011 15:03:13 +0000 (16:03 +0100)]
s3: Fix some errno assignments in SMBC_opendir_ctx

Do the assignment as the last action to make sure it's not overwritten

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 24 17:31:57 CET 2011 on sn-devel-104
(cherry picked from commit 155c4fbc10ce3f47428402efd30eec732ab7a803)

13 years agos3: Fix Coverity ID 2325: RESOURCE_LEAK
Volker Lendecke [Thu, 24 Mar 2011 14:59:55 +0000 (15:59 +0100)]
s3: Fix Coverity ID 2325: RESOURCE_LEAK
(cherry picked from commit 9db92bb7f9ab9461019ebbf5839c588e2d16f229)

13 years agos3-epmapper: Log error if we can't register the endpoint.
Andreas Schneider [Mon, 21 Mar 2011 15:14:19 +0000 (16:14 +0100)]
s3-epmapper: Log error if we can't register the endpoint.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Mar 23 18:06:54 CET 2011 on sn-devel-104
(cherry picked from commit 7f1fd07fbe99fc167eb529d482b084142c39ea8a)

13 years agos3-epmapper: Setup epm in smbd to forward np requests.
Andreas Schneider [Thu, 17 Mar 2011 16:56:37 +0000 (17:56 +0100)]
s3-epmapper: Setup epm in smbd to forward np requests.
(cherry picked from commit b38517bbdc746fe53e0bd804623b2ea7b0e98cbc)

13 years agos3-epmapper: Remove unregister on shutdown.
Andreas Schneider [Thu, 17 Mar 2011 15:59:10 +0000 (16:59 +0100)]
s3-epmapper: Remove unregister on shutdown.

This is done automatically now.
(cherry picked from commit 73e985fe4b1b4c3e879f4d7fe7bc2f98851aee6e)

13 years agos3-epmd: Cleanup endpoints on service pipe disconnect.
Andreas Schneider [Thu, 17 Mar 2011 10:14:12 +0000 (11:14 +0100)]
s3-epmd: Cleanup endpoints on service pipe disconnect.
(cherry picked from commit da1a18cd032760c33cf4573124c5b88507b84425)

13 years agos3-epmapper: Added function to delete endpoint entries.
Andreas Schneider [Wed, 16 Mar 2011 12:42:26 +0000 (13:42 +0100)]
s3-epmapper: Added function to delete endpoint entries.
(cherry picked from commit 0d97741b9b825350e3e04b5dc49b4e039bd744dc)

13 years agos3-rpc_server: Added disconnect callback function.
Andreas Schneider [Mon, 14 Mar 2011 11:29:49 +0000 (12:29 +0100)]
s3-rpc_server: Added disconnect callback function.
(cherry picked from commit e69d92236744bb06d60faa4f21f3cd748ec5629d)

13 years agos3-rpc_server: Rename req to subreq.
Andreas Schneider [Thu, 10 Mar 2011 12:02:31 +0000 (13:02 +0100)]
s3-rpc_server: Rename req to subreq.
(cherry picked from commit 044eabe425f9ae6e2fcea5ec1481b33c35b173f7)

13 years agos3-rpc_server: Implement an endpoint monitor loop.
Andreas Schneider [Thu, 10 Mar 2011 09:17:51 +0000 (10:17 +0100)]
s3-rpc_server: Implement an endpoint monitor loop.
(cherry picked from commit 73faa82bf9ebebdff9662e60715e9fd4f1614b9f)

13 years agos3-rpc_server: Added a memory context to the ep regsiter state.
Andreas Schneider [Wed, 9 Mar 2011 09:38:00 +0000 (10:38 +0100)]
s3-rpc_server: Added a memory context to the ep regsiter state.
(cherry picked from commit b2bdc20f65f0d5fda5b9fdb9dc6222e2f219bbea)

13 years agos3-librpc: Leave the epm registration connection open.
Andreas Schneider [Wed, 9 Mar 2011 09:17:06 +0000 (10:17 +0100)]
s3-librpc: Leave the epm registration connection open.
(cherry picked from commit 81a2046879299a051e69fd4d78b3a8e49b690f1b)

13 years agos3-epmd: Cleanup endpoint mapper correctly.
Andreas Schneider [Mon, 14 Mar 2011 13:50:09 +0000 (14:50 +0100)]
s3-epmd: Cleanup endpoint mapper correctly.
(cherry picked from commit d6a1469f4350fa24204e11bb9aee0e33f8d21c34)

13 years agos3-epmapper: Shutdown the embedded epmapper cleanly.
Andreas Schneider [Mon, 14 Mar 2011 16:14:19 +0000 (17:14 +0100)]
s3-epmapper: Shutdown the embedded epmapper cleanly.
(cherry picked from commit de775244a97b011fa34e52987a76ff81a5d36fb0)

13 years agos3-epmapper: Added a cleanup function.
Andreas Schneider [Mon, 14 Mar 2011 13:49:51 +0000 (14:49 +0100)]
s3-epmapper: Added a cleanup function.
(cherry picked from commit 661ac49794a0594003463e1cf3ae1bf806f24213)

13 years agos3-epmapper: Use DCERPC_AUTH_LEVEL_CONNECT for ep ncalrpc.
Andreas Schneider [Mon, 21 Mar 2011 08:29:14 +0000 (09:29 +0100)]
s3-epmapper: Use DCERPC_AUTH_LEVEL_CONNECT for ep ncalrpc.
(cherry picked from commit da718a5961c3404435f9bc64bebabb71b53455eb)

13 years agos3-rpc_server: Rename system_user to ncalrpc_as_system.
Andreas Schneider [Mon, 14 Mar 2011 09:47:41 +0000 (10:47 +0100)]
s3-rpc_server: Rename system_user to ncalrpc_as_system.
(cherry picked from commit 3766f3ec0e495277c79df8eb8918cb739bc14358)

13 years agos3-prototypes: remove protos of some dead functions.
Günther Deschner [Wed, 23 Mar 2011 23:00:22 +0000 (00:00 +0100)]
s3-prototypes: remove protos of some dead functions.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 24 00:52:01 CET 2011 on sn-devel-104
(cherry picked from commit 2639f0b3ab23f0ae369e3cbae5dfb433cbb2a583)

13 years agolibrpc: bring more librpc prototypes in common.
Günther Deschner [Wed, 23 Mar 2011 22:59:11 +0000 (23:59 +0100)]
librpc: bring more librpc prototypes in common.

Guenther
(cherry picked from commit b903c289390741e423c7457e7ee82c8c5cb8b74b)

13 years agos3-rpc_client: actually call lsa_open_policy2() in rpccli_lsa_open_policy2().
Günther Deschner [Wed, 23 Mar 2011 15:47:26 +0000 (16:47 +0100)]
s3-rpc_client: actually call lsa_open_policy2() in rpccli_lsa_open_policy2().

Found by Sumit Bose <sbose@redhat.com>, thanks!

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 23 20:12:38 CET 2011 on sn-devel-104
(cherry picked from commit d2d3ac66eccbd5d1141f90b791704acf26f0227e)

13 years agos3-smbta-util: fix some buildwarnings.
Günther Deschner [Tue, 22 Mar 2011 21:02:13 +0000 (22:02 +0100)]
s3-smbta-util: fix some buildwarnings.

Guenther
(cherry picked from commit 48c604a3b72caa79069d3d32b47e0a03090e3687)

13 years agos3-globals: silence build warning in smbd_messaging_context().
Günther Deschner [Wed, 23 Mar 2011 12:00:32 +0000 (13:00 +0100)]
s3-globals: silence build warning in smbd_messaging_context().

Guenther
(cherry picked from commit 6c8b820b9bf6d50330f23d9da76a143866afbdbd)

13 years agos3-proto: remove some duplicate prototypes.
Günther Deschner [Tue, 22 Mar 2011 23:08:13 +0000 (00:08 +0100)]
s3-proto: remove some duplicate prototypes.

Guenther
(cherry picked from commit d53aac5baa045fe5875d7d32261dde83fec63ac8)

13 years agos3-includes: remove unused cmdline_lp_ctx.
Günther Deschner [Tue, 22 Mar 2011 22:50:26 +0000 (23:50 +0100)]
s3-includes: remove unused cmdline_lp_ctx.

Guenther
(cherry picked from commit 8fe4a68da73f69cb491aa2d79a1d263a8c3069a9)

13 years agowafsamba: add -Wcast-qual only to the toplevel (s4) build.
Günther Deschner [Fri, 18 Mar 2011 23:10:08 +0000 (00:10 +0100)]
wafsamba: add -Wcast-qual only to the toplevel (s4) build.

In samba3 there are a lot of warnings generated that make it a bit hard to track
and monitor other build warnings.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Sat Mar 19 00:58:25 CET 2011 on sn-devel-104
(cherry picked from commit a252ded937db2e8e4c81b608fbbf18714a900032)

13 years agos3-waf: use HAVE_ADS env to decide whether to build libads.so
Günther Deschner [Fri, 18 Mar 2011 14:19:25 +0000 (15:19 +0100)]
s3-waf: use HAVE_ADS env to decide whether to build libads.so

Guenther
(cherry picked from commit 33b8d0a6ff51800bfadf47286584b0895b6b3e65)

13 years agos3-build: use HAVE_ADS define in some more places.
Günther Deschner [Fri, 18 Mar 2011 14:18:29 +0000 (15:18 +0100)]
s3-build: use HAVE_ADS define in some more places.

Guenther
(cherry picked from commit c53e7f8d58c9a38aad3890df7f54da8996a95ce4)

13 years agos3: Fix Coverity ID 2201, NULL_RETURNS
Volker Lendecke [Wed, 23 Mar 2011 12:11:26 +0000 (13:11 +0100)]
s3: Fix Coverity ID 2201, NULL_RETURNS

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 23 13:06:20 CET 2011 on sn-devel-104
(cherry picked from commit cfa8b3663266521c8583168b8f71535c43297481)

13 years agos3: Fix Coverity ID 2202, NULL_RETURNS
Volker Lendecke [Wed, 23 Mar 2011 12:11:26 +0000 (13:11 +0100)]
s3: Fix Coverity ID 2202, NULL_RETURNS
(cherry picked from commit e88b9df78bc00985974e68e46f7218d0828ed6f0)

13 years agos3: Fix Coverity ID 2203, NULL_RETURNS
Volker Lendecke [Wed, 23 Mar 2011 12:11:26 +0000 (13:11 +0100)]
s3: Fix Coverity ID 2203, NULL_RETURNS
(cherry picked from commit e6d76ba832d87e59a50a5c044ecba5a6dc611958)

13 years agos3: Fix a (invalid) uninitialized variable warning
Volker Lendecke [Wed, 23 Mar 2011 10:08:46 +0000 (11:08 +0100)]
s3: Fix a (invalid) uninitialized variable warning

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 23 11:13:14 CET 2011 on sn-devel-104
(cherry picked from commit 429e84f0d48f6e711b2067f422b9a3ac596ba0a4)

13 years agos3:WHATSNEW: document changes of the id mapping system
Michael Adam [Tue, 1 Feb 2011 10:58:14 +0000 (11:58 +0100)]
s3:WHATSNEW: document changes of the id mapping system

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 22 23:57:29 CET 2011 on sn-devel-104

13 years agos3:selftest: fix Samba3.pm deprecated idmap config
Björn Baumbach [Thu, 10 Mar 2011 14:58:05 +0000 (15:58 +0100)]
s3:selftest: fix Samba3.pm deprecated idmap config

Replace deprecated idmap uid and gid option with new
idmap config * : range

13 years agos3:idmap: make sure that the id mapping system is initialized for first access
Michael Adam [Thu, 10 Mar 2011 22:41:17 +0000 (23:41 +0100)]
s3:idmap: make sure that the id mapping system is initialized for first access

13 years agos3:loadparm: set the default "idmap config * : backend" in initialize_globals().
Michael Adam [Thu, 10 Mar 2011 22:40:19 +0000 (23:40 +0100)]
s3:loadparm: set the default "idmap config * : backend" in initialize_globals().

13 years agos3:loadparm: deprecate "idmap uid/gid/backend" and have them set "idmap config *...
Michael Adam [Tue, 8 Mar 2011 06:15:36 +0000 (07:15 +0100)]
s3:loadparm: deprecate "idmap uid/gid/backend" and have them set "idmap config * : range/backend"

13 years agos3:WHATSNEW: remove mention of "idmap read only" as new parameter
Michael Adam [Tue, 22 Mar 2011 16:09:47 +0000 (17:09 +0100)]
s3:WHATSNEW: remove mention of "idmap read only" as new parameter

13 years agos3:docs: remove documentation of "idmap read only" which was removed.
Michael Adam [Tue, 22 Mar 2011 16:08:42 +0000 (17:08 +0100)]
s3:docs: remove documentation of "idmap read only" which was removed.

13 years agos3:loadparm: remove unused parameter "idmap read only".
Michael Adam [Fri, 4 Mar 2011 13:25:58 +0000 (14:25 +0100)]
s3:loadparm: remove unused parameter "idmap read only".

This has not been released yet and is now useless since we
use the "idmap config * : read only = ..." syntax.

13 years agos3:idmap: remove (now) unneeded function parse_idmap_module()
Michael Adam [Thu, 3 Mar 2011 16:50:28 +0000 (17:50 +0100)]
s3:idmap: remove (now) unneeded function parse_idmap_module()

13 years agos3:idmap: simply call idmap_init_named_domain for "*" in idmap_init_default_domain
Michael Adam [Thu, 3 Mar 2011 16:48:43 +0000 (17:48 +0100)]
s3:idmap: simply call idmap_init_named_domain for "*" in idmap_init_default_domain

The default domain "*" is now treated exactly the same as other explicitly
configured domains.

13 years agos3:idmap: remove passdb argument from idmap_init_domain()
Michael Adam [Thu, 3 Mar 2011 16:40:36 +0000 (17:40 +0100)]
s3:idmap: remove passdb argument from idmap_init_domain()

13 years agos3:idmap: remove the params argument from the init function
Michael Adam [Wed, 2 Mar 2011 22:00:58 +0000 (23:00 +0100)]
s3:idmap: remove the params argument from the init function

13 years agos3:idmap: remove use of params from idmap_ldap_init - it is not used any more
Michael Adam [Wed, 2 Mar 2011 16:04:59 +0000 (17:04 +0100)]
s3:idmap: remove use of params from idmap_ldap_init - it is not used any more

13 years agos3:idmap: remove special treatment of domain "*" from idmap_ldap_init.
Michael Adam [Wed, 2 Mar 2011 16:08:01 +0000 (17:08 +0100)]
s3:idmap: remove special treatment of domain "*" from idmap_ldap_init.

The default config via domain "*" is now treated just as the explicit
domain configs.

13 years agos3:idmap: remove the special treatment of the default domain "*" from idmap_init_domain
Michael Adam [Wed, 2 Mar 2011 14:41:06 +0000 (15:41 +0100)]
s3:idmap: remove the special treatment of the default domain "*" from idmap_init_domain

13 years agos4:ntvfs/posix: name->dos.attrib isn't initialized in pvfs_access_check_create()
Stefan Metzmacher [Tue, 22 Mar 2011 15:34:36 +0000 (16:34 +0100)]
s4:ntvfs/posix: name->dos.attrib isn't initialized in pvfs_access_check_create()

That's why we have the 'container' parameter to indicate
the caller wants to create a directory.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Mar 22 17:39:11 CET 2011 on sn-devel-104
(cherry picked from commit b8d0994627ef237fdc92bebd9c9a26f9d62764bc)

13 years agos3:docs: fix xml of "printnotifybackchannel" parameter (missing closing tag)
Michael Adam [Tue, 22 Mar 2011 12:08:10 +0000 (13:08 +0100)]
s3:docs: fix xml of "printnotifybackchannel" parameter (missing closing tag)

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 22 13:57:25 CET 2011 on sn-devel-104

13 years agolibcli/security: make sure that we don't grant SEC_STD_DELETE to the owner by default
Stefan Metzmacher [Mon, 21 Mar 2011 10:21:57 +0000 (11:21 +0100)]
libcli/security: make sure that we don't grant SEC_STD_DELETE to the owner by default

In the file server SEC_STD_DELETE is granted on the file/directory
or by FILE_DELETE_CHILD on the parent directory.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Mar 21 23:25:05 CET 2011 on sn-devel-104
(cherry picked from commit 4928d66fc2f469b75090c34f8d233026485e4a1e)

13 years agos3:smbd: access checks should not depend on share mode flags
Stefan Metzmacher [Fri, 18 Mar 2011 15:45:08 +0000 (16:45 +0100)]
s3:smbd: access checks should not depend on share mode flags

metze
(cherry picked from commit f0ec69b53544b7ff702f94d58b3d64c33eaabc7a)

13 years agos4:ntvfs/posix: grant SEC_STD_DELETE if the parent grants SEC_DIR_DELETE_CHILD
Stefan Metzmacher [Mon, 21 Mar 2011 12:59:27 +0000 (13:59 +0100)]
s4:ntvfs/posix: grant SEC_STD_DELETE if the parent grants SEC_DIR_DELETE_CHILD

metze
(cherry picked from commit 3dc999e38ba2605b702e60ac0b9e91a14542f458)

13 years agos3: Fix Coverity ID 1048, CHECKED_RETURN
Volker Lendecke [Mon, 21 Mar 2011 09:56:10 +0000 (10:56 +0100)]
s3: Fix Coverity ID 1048, CHECKED_RETURN

This is a real bug: tevent_req_set_endtime already calls tevent_req_nomem.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 21 16:29:22 CET 2011 on sn-devel-104
(cherry picked from commit 16155812e04cee6542746b8dbb4a9a7acb93de70)

13 years agos3: Fix Coverity ID 770, REVERSE_INULL
Volker Lendecke [Mon, 21 Mar 2011 09:46:53 +0000 (10:46 +0100)]
s3: Fix Coverity ID 770, REVERSE_INULL

We dereference "res" in various places, no point in checking. All current
callers send "res!=NULL".
(cherry picked from commit 8dc93bed09961ada9a25e8144cb761d1d7bd1ac5)

13 years agoselftest/Samba3: use 'debug pid=yes'
Stefan Metzmacher [Fri, 18 Mar 2011 09:03:05 +0000 (10:03 +0100)]
selftest/Samba3: use 'debug pid=yes'

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Mar 19 10:55:34 CET 2011 on sn-devel-104
(cherry picked from commit ce45027816d27e4493739b2f45821febb462ba02)

13 years agos3:smbd: remove uses of "./" in unlink_internals()
Stefan Metzmacher [Fri, 18 Mar 2011 15:01:26 +0000 (16:01 +0100)]
s3:smbd: remove uses of "./" in unlink_internals()

Commit 78b931ce6c840ade646c1c6030fa2d6acb77208b tried to do that,
but didn't have any effect.

metze
(cherry picked from commit daddccb5149fb0e7da120a163cd6739d0397ff86)

13 years agos3: use getgrset() when it is available
Christian Ambach [Mon, 14 Mar 2011 12:08:58 +0000 (08:08 -0400)]
s3: use getgrset() when it is available

When getgrouplist() is not defined, use getgrset() if it is defined
instead of using the initgroups() + getgroups() combo

Major contributions from Yannick Bergeron <yaberger@ca.ibm.com>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 19 10:09:38 CET 2011 on sn-devel-104
(cherry picked from commit ed46dfc4f16e230645fae5f3b3b21c462694c30a)

13 years agoSMB2 renames return SHARING_VIOLATION if there is any existing oplock on a file.
Jeremy Allison [Fri, 18 Mar 2011 21:57:05 +0000 (14:57 -0700)]
SMB2 renames return SHARING_VIOLATION if there is any existing oplock on a file.
(cherry picked from commit f555a0ea2b14ecb7d1037852b594e7e25ef2c4b5)

13 years agos3: Add "print notify backchannel" parameter to prevent us doing the reverse print...
Volker Lendecke [Fri, 18 Mar 2011 19:07:43 +0000 (12:07 -0700)]
s3: Add "print notify backchannel" parameter to prevent us doing the reverse print notify connection.
(cherry picked from commit e8a8c65f2309cfa4b5a366ae4102d727cc86b5cf)

13 years agos3:autorid make sure we set the mapping status correct on early exit
Christian Ambach [Fri, 18 Mar 2011 13:46:47 +0000 (14:46 +0100)]
s3:autorid make sure we set the mapping status correct on early exit

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 18 16:30:36 CET 2011 on sn-devel-104

13 years agoidmap-autorid: Slightly simplify idmap_autorid_get_domainrange
Volker Lendecke [Tue, 8 Mar 2011 20:55:58 +0000 (21:55 +0100)]
idmap-autorid: Slightly simplify idmap_autorid_get_domainrange

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Slightly simplify idmap_autorid_get_domainrange
Volker Lendecke [Tue, 8 Mar 2011 20:53:22 +0000 (21:53 +0100)]
idmap-autorid: Slightly simplify idmap_autorid_get_domainrange

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Remove an unused variable
Volker Lendecke [Tue, 8 Mar 2011 20:48:44 +0000 (21:48 +0100)]
idmap-autorid: Remove an unused variable

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Use talloc_tos() in idmap_autorid_id_to_sid
Volker Lendecke [Tue, 8 Mar 2011 20:47:41 +0000 (21:47 +0100)]
idmap-autorid: Use talloc_tos() in idmap_autorid_id_to_sid

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Remove an else branch
Volker Lendecke [Tue, 8 Mar 2011 20:45:02 +0000 (21:45 +0100)]
idmap-autorid: Remove an else branch

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Remove an unused variable
Volker Lendecke [Tue, 8 Mar 2011 20:38:21 +0000 (21:38 +0100)]
idmap-autorid: Remove an unused variable

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Remove an unused parameter
Volker Lendecke [Tue, 8 Mar 2011 20:36:54 +0000 (21:36 +0100)]
idmap-autorid: Remove an unused parameter

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Use talloc_tos() in idmap_autorid_sids_to_unixids
Volker Lendecke [Tue, 8 Mar 2011 20:33:58 +0000 (21:33 +0100)]
idmap-autorid: Use talloc_tos() in idmap_autorid_sids_to_unixids

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Not necessary to talloc domaincfg
Volker Lendecke [Tue, 8 Mar 2011 20:25:40 +0000 (21:25 +0100)]
idmap-autorid: Not necessary to talloc domaincfg

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agoidmap-autorid: Not necessary to talloc domainsid
Volker Lendecke [Tue, 8 Mar 2011 20:17:37 +0000 (21:17 +0100)]
idmap-autorid: Not necessary to talloc domainsid

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agos3: Cope with 192.168.1.1/24 in smbcontrol ip-dropped
Volker Lendecke [Wed, 9 Feb 2011 10:00:00 +0000 (11:00 +0100)]
s3: Cope with 192.168.1.1/24 in smbcontrol ip-dropped

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 18 14:56:38 CET 2011 on sn-devel-104
(cherry picked from commit 3e4879f3bddd9c9934bddeccfca65b3e8f678c26)

13 years agos4-libcli/rap: add NDR_RAP dependency to LIBCLI_RAP.
Günther Deschner [Fri, 18 Mar 2011 12:24:58 +0000 (13:24 +0100)]
s4-libcli/rap: add NDR_RAP dependency to LIBCLI_RAP.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 14:10:57 CET 2011 on sn-devel-104
(cherry picked from commit 9d813406e6c09f77164628102e66de1cf92f93c5)

13 years agos3-waf: enable nss_winbind in make test for nss_wrapper.
Günther Deschner [Fri, 18 Mar 2011 12:00:55 +0000 (13:00 +0100)]
s3-waf: enable nss_winbind in make test for nss_wrapper.

Guenther
(cherry picked from commit 4e0521300f5620d4f3833dbdd1d2526dac0e86ab)

13 years agos3-registry: remove some unused headers.
Günther Deschner [Thu, 17 Mar 2011 14:03:24 +0000 (15:03 +0100)]
s3-registry: remove some unused headers.

Guenther
(cherry picked from commit fa8471a616ae72667e7b3705f58275f419212fdf)

13 years agos3:locking: simplify the non cluster case of brl_get_locks_readonly()
Stefan Metzmacher [Thu, 17 Mar 2011 09:08:56 +0000 (10:08 +0100)]
s3:locking: simplify the non cluster case of brl_get_locks_readonly()

Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 18 13:00:51 CET 2011 on sn-devel-104
(cherry picked from commit 2f048e458bbd47307949293cf8436c2d8f879439)

13 years agos3:locking: brl_get_locks_internal() should not expose a write lock if the caller...
Stefan Metzmacher [Thu, 17 Mar 2011 09:04:12 +0000 (10:04 +0100)]
s3:locking: brl_get_locks_internal() should not expose a write lock if the caller wants read_only

This triggered deadlocks in the cluster case of brl_get_locks_readonly().

Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze
(cherry picked from commit e8411d6f9f1827ea88754fa97a2671cdf27a5554)

13 years agos4-smbtorture: add netsessiongetinfo() test.
Günther Deschner [Fri, 18 Mar 2011 00:23:53 +0000 (01:23 +0100)]
s4-smbtorture: add netsessiongetinfo() test.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 02:11:38 CET 2011 on sn-devel-104
(cherry picked from commit de5cec48a4660eb6b4dd4138e3aff11a4ed57cdc)

13 years agos4-smbtorture: add missing error code check in test_netsessionenum().
Günther Deschner [Fri, 18 Mar 2011 00:23:29 +0000 (01:23 +0100)]
s4-smbtorture: add missing error code check in test_netsessionenum().

Guenther
(cherry picked from commit 26ddcd3da1aa7903a08accea4e9d1ffaac1cae0a)

13 years agos4-libcli/rap: add smbcli_rap_netsessiongetinfo().
Günther Deschner [Fri, 18 Mar 2011 00:22:59 +0000 (01:22 +0100)]
s4-libcli/rap: add smbcli_rap_netsessiongetinfo().

Guenther
(cherry picked from commit 436b49771460139f1227b15445f68b80b5fbf6e6)

13 years agorap: add rap_NetSessionGetInfo to IDL.
Günther Deschner [Fri, 18 Mar 2011 00:22:35 +0000 (01:22 +0100)]
rap: add rap_NetSessionGetInfo to IDL.

Guenther
(cherry picked from commit f87a072b95e0eabffedb975d4fd4784300f7ad18)

13 years agos4-smbtorture: add test for rap_NetUserDelete().
Günther Deschner [Thu, 17 Mar 2011 23:12:11 +0000 (00:12 +0100)]
s4-smbtorture: add test for rap_NetUserDelete().

Guenther
(cherry picked from commit 9ef1a8cf4cc08a9e8e5bda6123ca34edf4f40f4c)

13 years agos3-net: make sure we set correct default user flags in rap_user_add().
Günther Deschner [Thu, 17 Mar 2011 22:51:12 +0000 (23:51 +0100)]
s3-net: make sure we set correct default user flags in rap_user_add().

Guenther
(cherry picked from commit 5def6f0ecad18c5a3896dc27c1972299594188cd)

13 years agos4-smbtorture: add test for rap_NetUserAdd().
Günther Deschner [Thu, 17 Mar 2011 21:18:43 +0000 (22:18 +0100)]
s4-smbtorture: add test for rap_NetUserAdd().

Guenther
(cherry picked from commit 249340c9c8f515a9d06d52d67f4d42e6751d1cf9)

13 years agos4-libcli/rap: add smbcli_rap_netuserdelete().
Günther Deschner [Thu, 17 Mar 2011 21:39:22 +0000 (22:39 +0100)]
s4-libcli/rap: add smbcli_rap_netuserdelete().

Guenther
(cherry picked from commit 980ceb2f708d00c13dd3f50cb00df17f1c593965)

13 years agorap: add rap_NetUserDelete IDL.
Günther Deschner [Thu, 17 Mar 2011 21:38:47 +0000 (22:38 +0100)]
rap: add rap_NetUserDelete IDL.

Guenther
(cherry picked from commit 9b1f2df3b1528525c8e895cb1d413d019bbb71d4)

13 years agos4-libcli/rap: add smbcli_rap_netuseradd().
Günther Deschner [Thu, 17 Mar 2011 20:53:19 +0000 (21:53 +0100)]
s4-libcli/rap: add smbcli_rap_netuseradd().

Guenther
(cherry picked from commit f91bc89a52ea9c21dab4f6f93ac04260874a1622)

13 years agorap: add rap_NetUserAdd IDL.
Günther Deschner [Thu, 17 Mar 2011 20:52:20 +0000 (21:52 +0100)]
rap: add rap_NetUserAdd IDL.

Guenther
(cherry picked from commit dd5460c2e5f8c074bffdd45314fea506d7dbbc8a)

13 years agos4-smbtorture: use torture_assert_ and comment functions in raw.eas test.
Günther Deschner [Thu, 17 Mar 2011 20:49:23 +0000 (21:49 +0100)]
s4-smbtorture: use torture_assert_ and comment functions in raw.eas test.

Guenther
(cherry picked from commit 40398acf75d5de3c69aaed56eddc1c1cbde5b3ca)

13 years agos4-smbtorture: use torture_context in raw.eas test.
Günther Deschner [Thu, 17 Mar 2011 20:08:03 +0000 (21:08 +0100)]
s4-smbtorture: use torture_context in raw.eas test.

Guenther
(cherry picked from commit 4a48c9d4ac20eefd8bd73525fa29deacece0873b)

13 years agos4-smbtorture: remove trailing whitespace from raw.eas test.
Günther Deschner [Thu, 17 Mar 2011 23:36:39 +0000 (00:36 +0100)]
s4-smbtorture: remove trailing whitespace from raw.eas test.

Guenther
(cherry picked from commit ac851935e2ca7c7cc27f3202b9104ce1070240f3)

13 years agos3-utils: run minimal_includes.pl over utils/*.c
Günther Deschner [Thu, 17 Mar 2011 13:40:38 +0000 (14:40 +0100)]
s3-utils: run minimal_includes.pl over utils/*.c

Guenther
(cherry picked from commit faf8becf22c44c8e4c70bfc4ae84b6081a633641)

13 years agoThe searches struct is still being used and idled in SMB2 - move it to the global
Jeremy Allison [Thu, 17 Mar 2011 23:16:54 +0000 (16:16 -0700)]
The searches struct is still being used and idled in SMB2 - move it to the global
section until we decide if we want to idle SMB2 directory handles.

Jeremy.
(cherry picked from commit 70dddd8d89351b8697825dcbb9551cfe0aa2d36c)

13 years agoFix compiler warning in debug message.
Jeremy Allison [Thu, 17 Mar 2011 17:35:10 +0000 (10:35 -0700)]
Fix compiler warning in debug message.
(cherry picked from commit 3d6a92a37bead8df3c7704a2f33614cac0201748)

13 years agoFix crash bug on smbd shutdown when using FOPENDIR() found by Volker.
Jeremy Allison [Thu, 17 Mar 2011 22:55:15 +0000 (15:55 -0700)]
Fix crash bug on smbd shutdown when using FOPENDIR() found by Volker.

The key was allowing the dptr_idle code to be triggered. We were
closing the dirp->dir handle without updating the underlying fd
in the open fsp.

Jeremy.
(cherry picked from commit 4c77d620e6cc5ea31f4a8f0bf9c8dab81f5f1002)

13 years agos3: Expose num_opens via api_RNetSessionEnum
Volker Lendecke [Thu, 17 Mar 2011 20:13:32 +0000 (21:13 +0100)]
s3: Expose num_opens via api_RNetSessionEnum

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 17 22:05:10 CET 2011 on sn-devel-104
(cherry picked from commit 9bc10bde1416655293ad486384f8044fb79006ce)

13 years agoNulling out the op_mid is never the right thing to do. We depend on
Jeremy Allison [Thu, 17 Mar 2011 17:35:51 +0000 (10:35 -0700)]
Nulling out the op_mid is never the right thing to do. We depend on
this value when searching for specific share mode entries.

Jeremy.
(cherry picked from commit 4ebde15741c21f1872a7b312abffc4431d08d51c)

13 years agos3: Fix Coverity ID 1013, CHECKED_RETURN
Volker Lendecke [Wed, 16 Mar 2011 17:50:02 +0000 (18:50 +0100)]
s3: Fix Coverity ID 1013, CHECKED_RETURN

This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
(cherry picked from commit 9c9ed33cb7264db4ec486ead7d2cf1b414e79500)