Günther Deschner [Tue, 11 Dec 2007 20:32:16 +0000 (21:32 +0100)]
Fill in NetJoinDomainLocal().
Guenther
Günther Deschner [Tue, 11 Dec 2007 20:31:44 +0000 (21:31 +0100)]
Add libnet_Join().
Heavily based on existing code in net_ads_join().
Guenther
Günther Deschner [Tue, 11 Dec 2007 20:25:41 +0000 (21:25 +0100)]
Add libnet_JoinCtx structure.
Guenther
Günther Deschner [Tue, 11 Dec 2007 20:23:40 +0000 (21:23 +0100)]
Split NetJoinDomain() into NetJoinDomainRemote() and the unsupported
NetJoinDomainLocal().
Guenther
Günther Deschner [Tue, 11 Dec 2007 20:21:17 +0000 (21:21 +0100)]
Very quick conversion of net_conf functions into the libnet_conf layer.
Certainly needs cleanup later.
Guenther
Günther Deschner [Thu, 6 Dec 2007 18:15:30 +0000 (19:15 +0100)]
For the fun of it, build netapi.so|.a.
Guenther
Günther Deschner [Thu, 6 Dec 2007 18:04:49 +0000 (19:04 +0100)]
Add NetGetJoinInformation().
Guenther
Günther Deschner [Fri, 21 Dec 2007 14:28:01 +0000 (15:28 +0100)]
Add get_friendly_werror_msg().
Guenther
Günther Deschner [Fri, 21 Dec 2007 14:12:40 +0000 (15:12 +0100)]
Kill fstring in getdcname & getanydcname return.
Guenther
Günther Deschner [Fri, 21 Dec 2007 12:40:11 +0000 (13:40 +0100)]
Use ADS_IGNORE_PRINCIPAL define.
Guenther
Volker Lendecke [Fri, 21 Dec 2007 11:53:12 +0000 (12:53 +0100)]
Fix the build on Solaris
Volker Lendecke [Thu, 20 Dec 2007 21:27:01 +0000 (22:27 +0100)]
Some C++ fixes
Volker Lendecke [Thu, 20 Dec 2007 21:17:16 +0000 (22:17 +0100)]
Some C++ warnings
Volker Lendecke [Thu, 20 Dec 2007 20:25:00 +0000 (21:25 +0100)]
Fix a C++ warning
Volker Lendecke [Thu, 20 Dec 2007 19:59:44 +0000 (20:59 +0100)]
Fix a C++ warning
Volker Lendecke [Thu, 20 Dec 2007 19:59:27 +0000 (20:59 +0100)]
Fix a missing prototype warning
Volker Lendecke [Sun, 9 Dec 2007 17:25:34 +0000 (18:25 +0100)]
Remove some statics from md4.c
Volker Lendecke [Thu, 20 Dec 2007 15:05:57 +0000 (16:05 +0100)]
Add a singleton cache
First user is yp_default_domain
Volker Lendecke [Thu, 20 Dec 2007 14:16:25 +0000 (15:16 +0100)]
Make data_blob_string_const return null terminated strings
... nobody was using it, so we're free to change it now :-)
Volker Lendecke [Wed, 19 Dec 2007 20:59:28 +0000 (21:59 +0100)]
Remove next_token_nr_talloc and its associated global
Only client.c and clitar.c used this, I think they should carry the static
themselves. Also move the a bit funny routine toktocliplist to clitar.c, the
only place where it is used.
Volker Lendecke [Thu, 20 Dec 2007 13:54:33 +0000 (14:54 +0100)]
Convert the pwnam cache to memcache
Volker Lendecke [Thu, 20 Dec 2007 13:41:58 +0000 (14:41 +0100)]
Add memcache_add_talloc
The first memcache API only had blobs, but we have quite a few objects that are
more complex talloc'ed structues. The current one I'm looking at is the
getpwnam cache, but there are others around.
Volker Lendecke [Thu, 20 Dec 2007 09:55:45 +0000 (10:55 +0100)]
Add a global cache
It hurts, but I think this global variable is necessary for transition, and it
has the potential to remove quite a few other global variables without messing
with APIs too much.
Herb Lewis [Thu, 20 Dec 2007 22:57:29 +0000 (14:57 -0800)]
fix dump printout when byte >= 0x80
James Peach [Thu, 20 Dec 2007 16:31:27 +0000 (08:31 -0800)]
Fix typo in filesystem capabilities bits.
Volker Lendecke [Thu, 20 Dec 2007 09:33:13 +0000 (10:33 +0100)]
Attempt to fix the build
James, at least on my Linux system neither FILE_CASE_SENSITIVE_SEARCH nor
FILE_CASE_PRESERVING_NAMES seem to be defined anywhere. Is it possible that
this is a MacOS/X specific thing? If so, could you add configure tests for
this?
Thanks,
Volker
James Peach [Thu, 20 Dec 2007 06:39:40 +0000 (22:39 -0800)]
Remove unused variable 'didmsg'.
James Peach [Thu, 20 Dec 2007 06:33:43 +0000 (22:33 -0800)]
Fix a couple of warnings in mDNS registration. One of these is an
actual bug where we pass a pointer instead of a pointer to a pointer.
James Peach [Mon, 15 Oct 2007 21:03:40 +0000 (14:03 -0700)]
Add filesystem capabilities bitmask to statfs info.
This patch adds Darwin support for the Samba statfs VFS call. It
also adds a filesystem capabilities bitmask to the information
returned by the call.
James Peach [Mon, 15 Oct 2007 21:01:12 +0000 (14:01 -0700)]
Expose per-fsp extension talloc context.
This patch supplements the fsp extension API with an operation to
retrieve the malloc zone pointer for that fsp.
James Peach [Mon, 15 Oct 2007 20:59:37 +0000 (13:59 -0700)]
Release per-fsp data on file closure.
Michael Adam [Wed, 19 Dec 2007 16:53:14 +0000 (17:53 +0100)]
Only retrieve password policies in pam_auth when WBFLAG_PAM_GET_PWD_POLICY is set.
This essentially re-establishes r14496 (
2155bb0535656f294bd054d6a0a7d16a9a71c31b)
which was undone in r17723 (
43bd8c00abb38eb23a1497a255d194fb1bbffffb) for
reasons that are unclear to me. Maybe I am being too naive.
Now we do again only retrieve the password policy when called from
the pam_winbind module. This fixes logons delegated to AD trusted
domain controllers: We need to connect to the sam to retrieve the
password policy. But auhtenticated session setup is not possible
when contacting the trusted domain dc and afterwards, SamrConnect
also fails with whatever credentials and method used.
Michael
Michael Adam [Wed, 5 Dec 2007 08:53:10 +0000 (09:53 +0100)]
Change the prototype of the vfs function get_nt_acl().
Up to now, get_nt_acl() took a files_struct pointer (fsp) and
a file name. All the underlying functions should need and now
do need (after the previous preparatory work), is a connection_struct
and a file name. The connection_struct is already there in the
vfs_handle passed to the vfs functions. So the files_struct
argument can be eliminated.
This eliminates the need of calling open_file_stat in a couple
of places to produce the fsp needed.
Michael
Michael Adam [Tue, 4 Dec 2007 08:45:14 +0000 (09:45 +0100)]
Prepare the afs acl module for the api change in get_nt_acl().
This makes both of afsacl_[f]get_nt_acl() more specific,
eliminating the need for afs_get_nt_acl(). Instead, split
afs_to_nt_acl.
Michael
Michael Adam [Mon, 3 Dec 2007 17:31:03 +0000 (18:31 +0100)]
Prepare the aix2 acl module for the api change in get_nt_acl().
This makes both of aixjfs2_[f]get_nt_acl() more specific,
eliminating the need for aixjfs2_get_nt_acl_common().
Michael
Michael Adam [Mon, 3 Dec 2007 17:24:56 +0000 (18:24 +0100)]
Change aixjfs2_get_nfs4_acl() to take file name instead of fsp.
In preparation of the api change in api change in get_nt_acl().
Michael
Michael Adam [Tue, 4 Dec 2007 07:25:21 +0000 (08:25 +0100)]
Fix two debug statements: Add missing printf parameter.
Michael
Michael Adam [Tue, 4 Dec 2007 07:19:40 +0000 (08:19 +0100)]
Reformatting: wrap long lines and remove trailing spaces.
Michael
Michael Adam [Fri, 16 Nov 2007 17:33:39 +0000 (18:33 +0100)]
Prepare the zfs acl module for the api change in get_nt_acl().
Michael
Michael Adam [Fri, 16 Nov 2007 17:33:39 +0000 (18:33 +0100)]
Prepare the gpfs acl module for the api change in get_nt_acl().
This moves functionality from gpfsacl_get_nt_acl_common()
back to gpfsacl_get_nt_acl() and gpfsacl_fget_nt_acl(),
making both these functions more specific (calling the
corresponding fsp- and non-fsp functions).
gpfsacl_get_nt_acl_common(). is removed.
Michael
Michael Adam [Wed, 14 Nov 2007 23:46:20 +0000 (00:46 +0100)]
Split smb_get_nt_acl_nfs4 into two (f- and non-f-variant).
This is the next step in preparation of a get_nt_acl prototype change.
Michael
Michael Adam [Fri, 9 Nov 2007 00:01:55 +0000 (01:01 +0100)]
Split smbacl4_GetFileOwner into two (f- and non-f-variant).
This is in preparation of a get_nt_acl prototype change.
Michael Adam [Tue, 6 Nov 2007 07:01:31 +0000 (08:01 +0100)]
Split get_nt_acl() into two functions: fsp- and non-fsp variant.
Replace smbd/posix_acls.c:get_nt_acl() by two funcions:
posix_get_nt_acl() and posix_fget_nt_acl(). The first
takes a connection struct and a file name instead of a
files_struct pointer. This is in preparation of changing
the vfs api for SMB_VFS_GET_NT_ACL.
Michael
Michael Adam [Tue, 6 Nov 2007 05:20:51 +0000 (06:20 +0100)]
Remove the "is_directory" parameter from canonicalise_acl():
It can be retrieved from the stat buffer.
Michael
Michael Adam [Sat, 27 Oct 2007 23:38:59 +0000 (01:38 +0200)]
Change canonicalise_acl() to not take an fsp.
Convert canonicalise_acl() to take connection_struct, is_directory
and file name instead of files_struct pointer.
Michael
Michael Adam [Sat, 27 Oct 2007 23:24:41 +0000 (01:24 +0200)]
Change ensure_canon_entry_valid() to not take and fsp.
Convert ensure_canon_entry_valid() to take share_params and an is_directory
flag instead of an files_struct pointer.
Michael
Michael Adam [Sat, 27 Oct 2007 23:14:51 +0000 (01:14 +0200)]
Change apply_default_perms() to not take an fsp.
This is a first change in a series: Pass what is needed instead of files_struct
pointers to some functions. This is in preparation of introducing two variants
of get_nt_acl - one for fname (which does not need an fsp), one for file
descriptor.
This changes apply_default_perms to take share_params (rather thatn snum)
and an is_directory flag instead of an fsp.
Michael
Volker Lendecke [Wed, 19 Dec 2007 14:02:59 +0000 (15:02 +0100)]
Remove Get_Pwnam and its associated static variable
All callers are replaced by Get_Pwnam_alloc
Volker Lendecke [Wed, 19 Dec 2007 19:27:47 +0000 (20:27 +0100)]
Fix a "no prototype" warning
Volker Lendecke [Wed, 19 Dec 2007 19:24:33 +0000 (20:24 +0100)]
Fix debug messages
When warning that "client plaintext auth" is not enabled where the server
requested them we should not talk about "client use plaintext auth"
Volker Lendecke [Wed, 19 Dec 2007 12:48:49 +0000 (13:48 +0100)]
Samba Shared Repository - branch v3-2-test updated -
initial-v3-2-unstable-716-g12cce3b
On Tue, Dec 18, 2007 at 06:04:32PM -0600, Jeremy Allison wrote:
> Fix valgrind error in dbwrap_rbt where rec_priv->node was
> being accessed after free. VALOKER PLEASE CHECK THIS VERY
> CAREFULLY !!!! This is a correct fix in that it fixes the
> valgrind error, but it looks inelegant to me. I think if
> I understood this code better I could craft a more subtle
> fix. Still looking at it....
Thanks a lot. Fully correct. What about the attached little
simplification?
Volker
Volker Lendecke [Wed, 19 Dec 2007 16:05:26 +0000 (17:05 +0100)]
packet_struct is used in several places as raw memory
-> Fix more uninitialized variable warnings
Volker Lendecke [Wed, 19 Dec 2007 15:48:18 +0000 (16:48 +0100)]
Some paranoia checks
Volker Lendecke [Wed, 19 Dec 2007 15:48:04 +0000 (16:48 +0100)]
Zero the tdb key, there might be padding
This leads to uninitialized variable warnings if nmbd is run under valgrind.
Volker Lendecke [Wed, 19 Dec 2007 15:30:01 +0000 (16:30 +0100)]
Today is not my day...
dmapi.c certainly did compile now...
Volker Lendecke [Wed, 19 Dec 2007 14:45:22 +0000 (15:45 +0100)]
Rename cache.[ch] to memcache.[ch]
cache.h conflicts with an XFS DMAPI include on "opi" :-(
Günther Deschner [Tue, 18 Dec 2007 12:38:14 +0000 (13:38 +0100)]
Merge WERR_NO_SUCH_LOGON_SESSION from Samba4.
Guenther
Günther Deschner [Wed, 19 Dec 2007 09:58:58 +0000 (10:58 +0100)]
Add and use some keystr functions using talloc_tos() in secrets api.
Guenther
Günther Deschner [Wed, 19 Dec 2007 10:08:27 +0000 (11:08 +0100)]
Add cmd_wkssvc_enumeratecomputernames to rpcclient.
Guenther
Jeremy Allison [Wed, 19 Dec 2007 02:16:40 +0000 (18:16 -0800)]
Two more static fstrings gone.
Jeremy.
Jeremy Allison [Wed, 19 Dec 2007 02:10:09 +0000 (18:10 -0800)]
Remove last_message completely as it's no longer used.
Jeremy.
Jeremy Allison [Wed, 19 Dec 2007 02:01:34 +0000 (18:01 -0800)]
Remove another static fstring.
Jeremy.
Jeremy Allison [Wed, 19 Dec 2007 01:30:02 +0000 (17:30 -0800)]
We've finished with the old node once we've copied the
keyval.
Jeremy.
Jeremy Allison [Wed, 19 Dec 2007 00:03:57 +0000 (16:03 -0800)]
Fix valgrind error in dbwrap_rbt where rec_priv->node was
being accessed after free. VALOKER PLEASE CHECK THIS VERY
CAREFULLY !!!! This is a correct fix in that it fixes the
valgrind error, but it looks inelegant to me. I think if
I understood this code better I could craft a more subtle
fix. Still looking at it....
Jeremy.
Michael Adam [Tue, 18 Dec 2007 15:32:57 +0000 (16:32 +0100)]
Fix an error when accessing unallocated sid in error path.
Michael
Volker Lendecke [Tue, 18 Dec 2007 09:07:08 +0000 (10:07 +0100)]
Add forgotten cache.h
Volker Lendecke [Tue, 18 Dec 2007 08:41:03 +0000 (09:41 +0100)]
Add a in-memory cache
This is a more general API that caches data with a LRU scheme. See
include/cache.h. No comments yet, I'm still working on it. But Jeremy has given
me a hint in one of his checkins that he would like to make use of this now.
The idea is that we get rid of all our silly little caches and merge them all
into one cache that we can then very easily trim, for example even with a
smbcontrol message if someone decides memory is tight. The main user is the
stat cache, this patch also converts the getwd cache. More caches to come.
Michael Adam [Tue, 18 Dec 2007 06:58:22 +0000 (07:58 +0100)]
Fix a debug message: add missing space.
Michael
Rishi Srivatsavai [Tue, 18 Dec 2007 06:09:09 +0000 (22:09 -0800)]
Add smbclient support for basic mDNS browsing.
Patch from Rishi Srivatsavai (bugzilla #4150), with tallocification
and minor syle changes by me.
Jeremy Allison [Tue, 18 Dec 2007 02:32:27 +0000 (18:32 -0800)]
More static pstring elimination.
Jeremy.
Jeremy Allison [Tue, 18 Dec 2007 02:00:43 +0000 (18:00 -0800)]
More static fstring elimination.
Jeremy.
Jeremy Allison [Tue, 18 Dec 2007 01:27:29 +0000 (17:27 -0800)]
Remove more static fstrings (yes this little cache should be
in the rbtree....).
Jeremy.
Jeremy Allison [Tue, 18 Dec 2007 01:13:31 +0000 (17:13 -0800)]
Correctly define prototypes for accessor functions.
Jeremy.
Jeremy Allison [Tue, 18 Dec 2007 01:03:07 +0000 (17:03 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 18 Dec 2007 01:02:48 +0000 (17:02 -0800)]
More static fstring removal.
Jeremy.
Michael Adam [Tue, 18 Dec 2007 00:55:48 +0000 (01:55 +0100)]
Fix logic error in cm_connect_sam().
Don't fall back to schannel when trust creds could be obtained.
This is still not complete, but I am getting closer.
Michael
Michael Adam [Tue, 18 Dec 2007 00:30:52 +0000 (01:30 +0100)]
Prevent another segfault.
Michael
Jeremy Allison [Tue, 18 Dec 2007 00:20:44 +0000 (16:20 -0800)]
Use the %*s feature of snprintf to remove anothe static fstring.
Jeremy.
Gerald (Jerry) Carter [Mon, 17 Dec 2007 23:33:48 +0000 (17:33 -0600)]
Fix a segv in winbindd caused by trying to free an fstring.
Make a copy of the machine_password and machine_account strings
in all conditional paths so that SAFE_FREE() will always be valid.
Michael Adam [Mon, 17 Dec 2007 22:02:39 +0000 (23:02 +0100)]
Do not close netlogon pipe in get_schannel_session_key_common().
This removes one forgotten call of cli_rpc_pipe_close(netlogon_pipe).
Correction of
e77c4022cfbb868e608edcb06b676658b0e201ad.
Michael
Simo Sorce [Mon, 17 Dec 2007 20:26:16 +0000 (15:26 -0500)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-simo
Simo Sorce [Mon, 17 Dec 2007 20:21:38 +0000 (15:21 -0500)]
While 'data' is usually 0 terminated, nothing in the spec requires that. The correct way is to copy only 'length' bytes.
Simo.
Jeremy Allison [Mon, 17 Dec 2007 18:44:09 +0000 (10:44 -0800)]
Fix bug #5121 (unix passwd sync not working on a streams based
system).
Jeremy.
Simo Sorce [Mon, 17 Dec 2007 14:43:18 +0000 (09:43 -0500)]
Merge in J.Layton patch and resolve conflict.
Michael Adam [Mon, 17 Dec 2007 13:51:37 +0000 (14:51 +0100)]
Remove direct caller of secrets_fetch_trusted_domain_password().
This is a regession introduced by
f7efc0eca9426e63b751c07a90265a12bb39cf95.
This calls pdb_get_trusteddom_pw() instead, again.
Michael
Michael Adam [Mon, 17 Dec 2007 09:34:29 +0000 (10:34 +0100)]
Reformat: Remove trailing spaces.
Michael
Michael Adam [Mon, 17 Dec 2007 10:57:14 +0000 (11:57 +0100)]
Make usage message for net sam rights list a little more precise.
Michael
Michael Adam [Wed, 12 Dec 2007 17:03:20 +0000 (18:03 +0100)]
Fix for bug #4801: Correctly implement lsa lookup levels for lookupnames.
This patch is still incomplete in that winbindd does not walk
the the trusted domains to lookup unqualified names here.
Apart from that this fix should be pretty much complete.
Michael
Michael Adam [Mon, 17 Dec 2007 09:54:05 +0000 (10:54 +0100)]
Fix flags in caller of lookup_name() in create_builtin_administrators().
Michael
Michael Adam [Mon, 17 Dec 2007 10:55:05 +0000 (11:55 +0100)]
Fix flags in all callers of lookup_name() in net_sam.c.
Michael
Michael Adam [Mon, 17 Dec 2007 10:32:21 +0000 (11:32 +0100)]
Fix flags in call of lookup_name() in srv_samr_nt.c: can_create().
Use LOOKUP_NAME_LOCAL instead of LOOKUP_NAME_ISOLATED.
Michael
Michael Adam [Mon, 17 Dec 2007 09:55:37 +0000 (10:55 +0100)]
Fix flags in call of lookup_name() in pdb_default_create_alias().
Use new flag LOOKUP_NAME_LOCAL.
Michael
Michael Adam [Mon, 17 Dec 2007 10:28:56 +0000 (11:28 +0100)]
Add combined flag LOOKUP_NAME_LOCAL.
Presence of LOOKUP_NAME_ISOLATED as the only flag is not the sign
for doing local lookups only but the sign for allowing lookups
of unqualified names. The correct sign is absence of the flag
LOOKUP_NAME_REMOTE.
Michael
Volker Lendecke [Mon, 17 Dec 2007 06:18:30 +0000 (07:18 +0100)]
Remove t_doschar.c
Jeremy Allison [Mon, 17 Dec 2007 02:32:03 +0000 (18:32 -0800)]
Remove another static string and static passwd.
Jeremy.
Jeremy Allison [Mon, 17 Dec 2007 02:02:32 +0000 (18:02 -0800)]
Remove a static fstring.
Jeremy.
Volker Lendecke [Sat, 15 Dec 2007 23:25:49 +0000 (00:25 +0100)]
get rid of doschar_table[]
If I'm not completely blind, then check_dos_char is *only* used in the case
when we can't mmap() valid.dat. To me this looks as if we initialize the 65536
bits in doschar_table[] with check_dos_char_slowly, use it once to initialize
valid_table[] and *never* use them again. I think there's no point in keeping
these 8k of modified memory around for an unlikely case (no "valid.dat") and
even that only to use it exactly once.
Volker Lendecke [Sat, 15 Dec 2007 23:19:42 +0000 (00:19 +0100)]
Tiny fixes to init_valid_table()
Volker Lendecke [Sat, 15 Dec 2007 23:17:41 +0000 (00:17 +0100)]
Make init_doschar_table() static
It's only called directly before init_valid_table() anyway, so move it there.
Volker Lendecke [Sat, 15 Dec 2007 23:15:34 +0000 (00:15 +0100)]
Make check_dos_char static
It's only called in t_doschar, a pretty bogus test program that is not compiled
by default