abartlet/samba.git/.git
13 years agos3: Remove unused cli_connect
Volker Lendecke [Sun, 29 May 2011 18:51:43 +0000 (20:51 +0200)]
s3: Remove unused cli_connect

13 years agos3: Use cli_connect_nb in SMBC_server_internal
Volker Lendecke [Sun, 29 May 2011 18:22:38 +0000 (20:22 +0200)]
s3: Use cli_connect_nb in SMBC_server_internal

13 years agos3: Run BAD-NBT-SESSION in make test
Volker Lendecke [Sun, 29 May 2011 17:14:48 +0000 (19:14 +0200)]
s3: Run BAD-NBT-SESSION in make test

13 years agos3: Reply correctly to a bad nbt session request
Volker Lendecke [Sun, 29 May 2011 17:13:11 +0000 (19:13 +0200)]
s3: Reply correctly to a bad nbt session request

13 years agos3: Fix cli_bad_session_request
Volker Lendecke [Sun, 29 May 2011 16:49:14 +0000 (18:49 +0200)]
s3: Fix cli_bad_session_request

We expect a negative session response with a 0x82 error (called name not
present), not a 0x82 message

13 years agos3: Simplify run_bad_nbt_session
Volker Lendecke [Sun, 29 May 2011 16:43:31 +0000 (18:43 +0200)]
s3: Simplify run_bad_nbt_session

13 years agos3: Simplify cli_bad_session_request
Volker Lendecke [Sun, 29 May 2011 16:17:18 +0000 (18:17 +0200)]
s3: Simplify cli_bad_session_request

For this purpose we don't need the full cli_state

13 years agos3: Add set_socket_options to cli_connect_sock()
Volker Lendecke [Sun, 29 May 2011 11:40:03 +0000 (13:40 +0200)]
s3: Add set_socket_options to cli_connect_sock()

A leftover of stuff that cli_connect() does

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 15:47:17 CEST 2011 on sn-devel-104

13 years agos3: Use cli_connect_nb in nmbd sync_child
Volker Lendecke [Sun, 29 May 2011 11:38:20 +0000 (13:38 +0200)]
s3: Use cli_connect_nb in nmbd sync_child

13 years agos3: Remove unused attempt_netbios_session_request
Volker Lendecke [Sun, 29 May 2011 11:33:49 +0000 (13:33 +0200)]
s3: Remove unused attempt_netbios_session_request

13 years agos3: Use cli_connect_nb in do_connect
Volker Lendecke [Sun, 29 May 2011 11:17:23 +0000 (13:17 +0200)]
s3: Use cli_connect_nb in do_connect

13 years agos3: Use the correct guest_login field in auth_server
Volker Lendecke [Sun, 29 May 2011 08:58:46 +0000 (10:58 +0200)]
s3: Use the correct guest_login field in auth_server

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 13:57:21 CEST 2011 on sn-devel-104

13 years agos3: Extract the guest_login field in sesssetup
Volker Lendecke [Sun, 29 May 2011 08:58:05 +0000 (10:58 +0200)]
s3: Extract the guest_login field in sesssetup

13 years agos3: Fix wct check in cli_sesssetup_blob_done
Volker Lendecke [Sun, 29 May 2011 08:56:39 +0000 (10:56 +0200)]
s3: Fix wct check in cli_sesssetup_blob_done

13 years agos3: Use cli_connect_nb in auth_server
Volker Lendecke [Sun, 29 May 2011 07:21:03 +0000 (09:21 +0200)]
s3: Use cli_connect_nb in auth_server

13 years agos3: Fix a type-punned warning
Volker Lendecke [Sun, 29 May 2011 07:20:49 +0000 (09:20 +0200)]
s3: Fix a type-punned warning

13 years agos3: Check password server loop earlier
Volker Lendecke [Sun, 29 May 2011 07:16:32 +0000 (09:16 +0200)]
s3: Check password server loop earlier

We do that in the loop for the ip address anyway

13 years agos3: Use cli_connect_nb in do_message_op
Volker Lendecke [Sat, 28 May 2011 22:59:12 +0000 (00:59 +0200)]
s3: Use cli_connect_nb in do_message_op

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 10:11:54 CEST 2011 on sn-devel-104

13 years agos3: Use cli_connect_nb in smbtorture open_nbt_connection
Volker Lendecke [Sat, 28 May 2011 21:34:26 +0000 (23:34 +0200)]
s3: Use cli_connect_nb in smbtorture open_nbt_connection

13 years agos3: Use cli_connect_nb in net_rpc_check
Volker Lendecke [Sat, 28 May 2011 19:01:59 +0000 (21:01 +0200)]
s3: Use cli_connect_nb in net_rpc_check

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 21:57:04 CEST 2011 on sn-devel-104

13 years agos3: Use cli_connect_nb in smbd_running()
Volker Lendecke [Sat, 28 May 2011 18:54:33 +0000 (20:54 +0200)]
s3: Use cli_connect_nb in smbd_running()

13 years agos3: Use cli_connect_nb in cli_servertime
Volker Lendecke [Sat, 28 May 2011 18:52:06 +0000 (20:52 +0200)]
s3: Use cli_connect_nb in cli_servertime

13 years agos3: Use cli_connect_nb in remote_password_change
Volker Lendecke [Sat, 28 May 2011 18:45:11 +0000 (20:45 +0200)]
s3: Use cli_connect_nb in remote_password_change

13 years agos3: Add called name_type param to cli_connect_nb
Volker Lendecke [Sat, 28 May 2011 18:39:54 +0000 (20:39 +0200)]
s3: Add called name_type param to cli_connect_nb

13 years agos3: Fix a type-punned warning
Volker Lendecke [Sat, 28 May 2011 18:38:13 +0000 (20:38 +0200)]
s3: Fix a type-punned warning

13 years agos3: Use cli_connect_nb in masktest
Volker Lendecke [Sat, 28 May 2011 18:26:49 +0000 (20:26 +0200)]
s3: Use cli_connect_nb in masktest

13 years agos3: Fix some nonemtpy blank lines
Volker Lendecke [Sat, 28 May 2011 18:24:01 +0000 (20:24 +0200)]
s3: Fix some nonemtpy blank lines

13 years agos3: Use cli_connect_nb in locktest
Volker Lendecke [Sat, 28 May 2011 16:57:03 +0000 (18:57 +0200)]
s3: Use cli_connect_nb in locktest

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 18:06:49 CEST 2011 on sn-devel-104

13 years agos3: Fix smbsock_connect
Volker Lendecke [Sat, 28 May 2011 16:55:47 +0000 (18:55 +0200)]
s3: Fix smbsock_connect

If all connection attempts fail, return immediately. Plain bug.

13 years agos3: Fix a tiny memleak in copy_unix_token
Volker Lendecke [Sat, 28 May 2011 08:39:25 +0000 (10:39 +0200)]
s3: Fix a tiny memleak in copy_unix_token

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 11:47:11 CEST 2011 on sn-devel-104

13 years agos3: Use talloc_memdup in copy_unix_token
Volker Lendecke [Sat, 28 May 2011 08:38:52 +0000 (10:38 +0200)]
s3: Use talloc_memdup in copy_unix_token

13 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 28 May 2011 08:24:20 +0000 (10:24 +0200)]
s3: Fix some nonempty blank lines

13 years agos3: Use cli_connect_nb in cli_start_connection
Volker Lendecke [Thu, 26 May 2011 20:02:28 +0000 (22:02 +0200)]
s3: Use cli_connect_nb in cli_start_connection

13 years agos3: Add cli_connect_nb
Volker Lendecke [Thu, 26 May 2011 20:00:07 +0000 (22:00 +0200)]
s3: Add cli_connect_nb

This builds up a cli_state until after the netbios session setup. It makes use
of smbsock_connect, so it connects to 139 and 445 simultaneously. This improves
the connection to Windows 2008 which does not listen on *SMBSERVER anymore.

13 years agopackaging(RHEL-CTDB): align configure.rpm to the spec file
Christian Ambach [Thu, 19 May 2011 16:58:25 +0000 (18:58 +0200)]
packaging(RHEL-CTDB): align configure.rpm to the spec file

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri May 27 13:27:03 CEST 2011 on sn-devel-104

13 years agos3: Fix a typo
Volker Lendecke [Fri, 27 May 2011 06:42:30 +0000 (08:42 +0200)]
s3: Fix a typo

Thanks to Samba-JP oota <ribbon@samba.gr.jp>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri May 27 10:12:12 CEST 2011 on sn-devel-104

13 years agos3: Fix a typo
Volker Lendecke [Fri, 27 May 2011 06:42:30 +0000 (08:42 +0200)]
s3: Fix a typo

Thanks to Samba-JP oota <ribbon@samba.gr.jp>

13 years agoFix bug #6911 - Kerberos authentication from vista to samba fails when security blob...
Jeremy Allison [Thu, 26 May 2011 23:48:42 +0000 (16:48 -0700)]
Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB

We were not correctly checking the output of asn1_start_tag().
asn1_start_tag() returns -1 and sets data->has_error if the
remaining blob size is too short to contain the tag length.
We were checking data->has_error and returning NT_STATUS_OK
(to allow the second asn.1 parse to fail in that case). We
should not be checking data->has_error in this case, but
falling through to the code that already checks the length.

Thanks to Jim for reproducing this for me. We don't get bitten
by this as we announce a max buffer size of 16k, greater than
Windows's 4k, which means that most krb5 spnego packets already
fit.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 27 02:57:27 CEST 2011 on sn-devel-104

13 years agos3: Document "async smb echo handler"
Volker Lendecke [Thu, 26 May 2011 09:40:21 +0000 (11:40 +0200)]
s3: Document "async smb echo handler"

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 26 12:50:55 CEST 2011 on sn-devel-104

13 years agoFix bug #8165 - Inverted WITH_SYSLOG condition in vfs_full_audit.c.
Jeremy Allison [Wed, 25 May 2011 19:28:39 +0000 (12:28 -0700)]
Fix bug #8165 - Inverted WITH_SYSLOG condition in vfs_full_audit.c.

Found by freeserif@yahoo.com.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 25 22:37:23 CEST 2011 on sn-devel-104

13 years agoFix numerous missing dependencies in WAF build scripts
Sean Finney [Fri, 20 May 2011 08:12:08 +0000 (08:12 +0000)]
Fix numerous missing dependencies in WAF build scripts

With the recent consolidation of code between s3 and s4, a number of new
dependencies have been implicitly introduced.  For example, previous s3
code gained an implicit dependency on talloc after the charset related
consolidation (lib/util/charset/charset.h now includes talloc.h).  When
building against the embedded version of talloc this isn't a problem
since the paths are automatically added to the search path, but when
building against the external libraries build failures will occur for
all components that don't directly or indirectly include talloc as
a dependency.

Since charset.h is included from util.h, which in turn is included from
includes.h, this means most of the codebase (s3 and s4) has such an
undeclared dependency.

Therefore, samba-util-common and samba-util have been added as
dependencies to the s3 and s4 code respectively, for all cases where
the source would otherwise fail to build.  Additionally, a few other
dependencies are added in specific wscript_build files to address
similar dependency-related problems.

https://bugzilla.samba.org/show_bug.cgi?id=8128

Signed-off-by: Sean Finney <seanius@seanius.net>
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed May 25 19:22:13 CEST 2011 on sn-devel-104

13 years agos3-winbind: BUG 8166 - Don't lockout users when offline.
Jim McDonough [Wed, 25 May 2011 14:49:41 +0000 (10:49 -0400)]
s3-winbind: BUG 8166 - Don't lockout users when offline.

Windows does not track bad password attempts when offline.  We were locking users out but not honoring the lockout duration.

Autobuild-User: Jim McDonough <jmcd@samba.org>
Autobuild-Date: Wed May 25 18:11:10 CEST 2011 on sn-devel-104

13 years agos4:samldb LDB module - check if the RODC group exists if creating an RODC
Matthias Dieter Wallnöfer [Tue, 24 May 2011 20:05:46 +0000 (22:05 +0200)]
s4:samldb LDB module - check if the RODC group exists if creating an RODC

Older AD deployments simply don't have it and hence there is no RODC
support.

Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed May 25 10:26:37 CEST 2011 on sn-devel-104

13 years agos4:samldb LDB module - better to call "samldb_prim_group_trigger"
Matthias Dieter Wallnöfer [Tue, 24 May 2011 19:21:19 +0000 (21:21 +0200)]
s4:samldb LDB module - better to call "samldb_prim_group_trigger"

"samldb_prim_group_trigger" which as a wrapper calls "samldb_prim_group_change"
for a LDB modify operation.

Reviewed-by: abartlet
13 years agos4:samldb LDB module - convert a "dsdb_module_search" into "dsdb_module_search_dn"
Matthias Dieter Wallnöfer [Mon, 23 May 2011 10:59:58 +0000 (12:59 +0200)]
s4:samldb LDB module - convert a "dsdb_module_search" into "dsdb_module_search_dn"

It saves us from checking the number of returned entries.

Reviewed-by: abartlet
13 years agos4:sam.py - uncomment/enhance some account type tests
Matthias Dieter Wallnöfer [Mon, 23 May 2011 10:52:35 +0000 (12:52 +0200)]
s4:sam.py - uncomment/enhance some account type tests

Reviewed-by: abartlet
13 years agos4:samldb LDB modules - only objectClass "computer" is allowed to embed all types...
Matthias Dieter Wallnöfer [Mon, 23 May 2011 10:51:06 +0000 (12:51 +0200)]
s4:samldb LDB modules - only objectClass "computer" is allowed to embed all types of account

Reviewed-by: abartlet
13 years agos4:sam.py - tests for "isCriticalSystemObject" attribute
Matthias Dieter Wallnöfer [Mon, 23 May 2011 10:05:57 +0000 (12:05 +0200)]
s4:sam.py - tests for "isCriticalSystemObject" attribute

Reviewed-by: abartlet
13 years agos4:samldb LDB module - fix "isCriticalSystemObject" behaviour
Matthias Dieter Wallnöfer [Mon, 23 May 2011 09:46:39 +0000 (11:46 +0200)]
s4:samldb LDB module - fix "isCriticalSystemObject" behaviour

Tests against Windows Server show that it gets set to "FALSE" (not
deleted) if we change the account type to a domain member.

Reviewed-by: abartlet
13 years agos4:sam.py - unchanged "primaryGroupID" when account type remains the same
Matthias Dieter Wallnöfer [Mon, 23 May 2011 08:48:16 +0000 (10:48 +0200)]
s4:sam.py - unchanged "primaryGroupID" when account type remains the same

Enhance the testcase with a workstation example.

Reviewed-by: abartlet
13 years agos4:samldb LDB module - fix the behaviour when changing the "userAccountControl"
Matthias Dieter Wallnöfer [Mon, 23 May 2011 08:29:17 +0000 (10:29 +0200)]
s4:samldb LDB module - fix the behaviour when changing the "userAccountControl"

Ekacnet was not quite right yet but his patch made me think further.
This primary group changing is only needed if the account type changes.
With this patch we do one more search if the "userAccountControl"
changes but we save us from doing these unneeded and wrong modify replace
operations most of the time.

Reviewed-by: abartlet
13 years agos3-testparm Warn about incorrect use of 'password server'
Andrew Bartlett [Tue, 24 May 2011 23:19:50 +0000 (09:19 +1000)]
s3-testparm Warn about incorrect use of 'password server'

This merges master with v3-6-test

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 25 05:20:57 CEST 2011 on sn-devel-104

13 years agos3-param Depricate 'password server = foo:12389' syntax
Andrew Bartlett [Mon, 23 May 2011 00:42:57 +0000 (10:42 +1000)]
s3-param Depricate 'password server = foo:12389' syntax

This was originally intended to allow the LDAP port on a DC to be
varied, but makes little sense to change one port when in an
environment where krb5, ldap, smb and potentially DCE/RPC over TCP are
involved.

Andrew Bartlett

13 years agodocs: Rewrite 'password server' documentation
Andrew Bartlett [Mon, 23 May 2011 00:20:47 +0000 (10:20 +1000)]
docs: Rewrite 'password server' documentation

I think this new version is more clear.

Andrew Bartlett

13 years agos4-provision Use correct tkey-gssapi-credential
Andrew Bartlett [Mon, 23 May 2011 05:27:50 +0000 (15:27 +1000)]
s4-provision Use correct tkey-gssapi-credential

We changed to ${DNSNAME} (the fully qualified domain name) a while
back, and while it's usually functionally idential to the previous
setting, this breaks down if there is more than one DNS server.

Andrew Bartlett

13 years agodocs: Clarify the 'security=server' fails for NTLMv2
Andrew Bartlett [Mon, 23 May 2011 00:42:40 +0000 (10:42 +1000)]
docs: Clarify the 'security=server' fails for NTLMv2

13 years agoselftest: Make knowfail/skip files consistent, always use ^prefix
Andrew Bartlett [Sun, 22 May 2011 23:22:07 +0000 (09:22 +1000)]
selftest: Make knowfail/skip files consistent, always use ^prefix

Except in one case (where we mark printing tests as knownfail), this
has all our regular expressions start with ^, which ensures we don't
accidentially mix up the samba3/samba4 prefix here.

Because of the particular values in these files at the moment, this
should not change the set of tests, but it will help to ensure that
future edits follow the correct pattern.

Andrew Bartlett

13 years agoFix our asn.1 parser to handle negative numbers.
Jeremy Allison [Tue, 24 May 2011 19:47:31 +0000 (12:47 -0700)]
Fix our asn.1 parser to handle negative numbers.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 22:57:16 CEST 2011 on sn-devel-104

13 years agolib/util Add Volker's asn1_Integer test into code that runs in 'make test'
Andrew Bartlett [Sat, 14 May 2011 17:49:36 +0000 (19:49 +0200)]
lib/util Add Volker's asn1_Integer test into code that runs in 'make test'

The comfychair test harness isn't hooked up, and with the current
infrustructure C code is better tested directly here.

Andrew Bartlett

13 years agoActually make use of the SMBTA_SUBRELEASE define in smb_traffic_analyzer.h. This...
Holger Hetterich [Sun, 20 Feb 2011 10:32:39 +0000 (11:32 +0100)]
Actually make use of the SMBTA_SUBRELEASE define in smb_traffic_analyzer.h. This will allow to introduce new features or fixes into the protocol after the 3.6.0 release. The client software is designed to take care for the subrelease number.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 21:23:22 CEST 2011 on sn-devel-104

13 years agoFix bug #7054 - X account flag does not work when pwdlastset is 0.
Jeremy Allison [Tue, 24 May 2011 00:14:47 +0000 (17:14 -0700)]
Fix bug #7054 - X account flag does not work when pwdlastset is 0.

Don't allow pass_last_set_time to be set to zero (which means
"user must change password on next logon") if user object doesn't
allow password change.

Don't automatically allow user object password change if
"user must change password on next logon" is set.

Jim please check.

Jeremy.

13 years agos3:modules properly terminate enums in nfs4 acl code
Christian Ambach [Tue, 24 May 2011 17:01:22 +0000 (19:01 +0200)]
s3:modules properly terminate enums in nfs4 acl code

same issue as with the audit modules:
using a wrong parameter leads to smbd crash as lp_enum()
will not terminate on last entry of the array

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue May 24 20:13:39 CEST 2011 on sn-devel-104

13 years agos3:vfs properly terminate enums in audit modules
Christian Ambach [Tue, 24 May 2011 15:19:52 +0000 (17:19 +0200)]
s3:vfs properly terminate enums in audit modules

without the proper terminations of the enums, invalid arguments
for the audit modules will lead to a smbd crash as the loop in
lp_enum() will attempt to access memory behind the array

13 years agoFix bug #8150 - Ban 'dos charset = utf8'
Jeremy Allison [Mon, 23 May 2011 17:57:56 +0000 (10:57 -0700)]
Fix bug #8150 - Ban 'dos charset = utf8'

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 03:52:50 CEST 2011 on sn-devel-104

13 years agos3: Remove unused cli_get_nt_error
Volker Lendecke [Mon, 23 May 2011 10:26:03 +0000 (12:26 +0200)]
s3: Remove unused cli_get_nt_error

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 16:54:21 CEST 2011 on sn-devel-104

13 years agos3: Remove unused cli_set_nt_error
Volker Lendecke [Mon, 23 May 2011 10:25:32 +0000 (12:25 +0200)]
s3: Remove unused cli_set_nt_error

13 years agos3: Remove unused cli_reset_error
Volker Lendecke [Mon, 23 May 2011 10:24:52 +0000 (12:24 +0200)]
s3: Remove unused cli_reset_error

13 years agos3: Remove a reference to cli->inbuf
Volker Lendecke [Mon, 23 May 2011 10:22:41 +0000 (12:22 +0200)]
s3: Remove a reference to cli->inbuf

This is only used for utf16 alignment calculations, "rdata" is aligned the
same way as cli->inbuf is.

13 years agos3: Remove two false references to cli->inbuf
Volker Lendecke [Mon, 23 May 2011 10:21:17 +0000 (12:21 +0200)]
s3: Remove two false references to cli->inbuf

13 years agos3: Fix a leftover from fstring removal in cli_state
Volker Lendecke [Mon, 23 May 2011 13:36:20 +0000 (15:36 +0200)]
s3: Fix a leftover from fstring removal in cli_state

Jeremy, please check!

13 years agoselftest: create ncalrpcdir with 0755 permissions
Stefan Metzmacher [Sun, 22 May 2011 17:40:19 +0000 (19:40 +0200)]
selftest: create ncalrpcdir with 0755 permissions

We need to reset the umask in order to set to the desired permissions.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 23 13:26:33 CEST 2011 on sn-devel-104

13 years agos3: Remove unused cli_[en|de]crypt_message
Volker Lendecke [Sun, 22 May 2011 17:14:44 +0000 (19:14 +0200)]
s3: Remove unused cli_[en|de]crypt_message

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 12:15:33 CEST 2011 on sn-devel-104

13 years agos3: Directly call common_encrypt_buffer in cli_smb_req_iov_send
Volker Lendecke [Sun, 22 May 2011 17:13:19 +0000 (19:13 +0200)]
s3: Directly call common_encrypt_buffer in cli_smb_req_iov_send

13 years agos3: Remove cli_send/receive_smb
Volker Lendecke [Sun, 22 May 2011 17:00:50 +0000 (19:00 +0200)]
s3: Remove cli_send/receive_smb

A moment of silence is due here, R.I.P.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 22 22:17:12 CEST 2011 on sn-devel-104

13 years agos3: Remove the smbtorture3 OPLOCK3 test
Volker Lendecke [Sun, 22 May 2011 12:16:46 +0000 (14:16 +0200)]
s3: Remove the smbtorture3 OPLOCK3 test

This is the last user of cli_receive_smb. Oplocks are nowadays tested
in smbtorture4, this mainly has historic value

13 years agos3: Convert the OPEN4 test to async oplock handling
Volker Lendecke [Sun, 22 May 2011 16:50:16 +0000 (18:50 +0200)]
s3: Convert the OPEN4 test to async oplock handling

This removes a caller of cli_receive_smb

13 years agos3: Remove clistr_align_out
Volker Lendecke [Sat, 21 May 2011 20:20:18 +0000 (22:20 +0200)]
s3: Remove clistr_align_out

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 23:31:12 CEST 2011 on sn-devel-104

13 years agos3: Remove unused cli_setup_bcc
Volker Lendecke [Sat, 21 May 2011 18:14:30 +0000 (20:14 +0200)]
s3: Remove unused cli_setup_bcc

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 21:24:13 CEST 2011 on sn-devel-104

13 years agos4:sam.py - add tests to check that setting "userAccountValue" on usersdon't impact...
Matthieu Patou [Sat, 21 May 2011 10:35:58 +0000 (14:35 +0400)]
s4:sam.py - add tests to check that setting "userAccountValue" on usersdon't impact the "primaryGroupID" attribute

Notice: The domain administrators groups isn't referenced as "Domain Admins"
since this name could differ.

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat May 21 19:19:57 CEST 2011 on sn-devel-104

13 years agos4:samldb LDB module - don't change the "primaryGroupId" on LDB modifications unless...
Matthieu Patou [Sat, 21 May 2011 07:56:45 +0000 (11:56 +0400)]
s4:samldb LDB module - don't change the "primaryGroupId" on LDB modifications unless we are a computer/dc/rodc

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
13 years agos4:lsa RPC server - handle LDB flags as "unsigned"
Matthias Dieter Wallnöfer [Wed, 13 Apr 2011 07:01:42 +0000 (09:01 +0200)]
s4:lsa RPC server - handle LDB flags as "unsigned"

Signed-off-by: Metze
13 years agos4:ldb-samba/ldb_wrap.*-dsdb/samdb/samdb.c - handle LDB connection flags as unsigned
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 17:54:31 +0000 (19:54 +0200)]
s4:ldb-samba/ldb_wrap.*-dsdb/samdb/samdb.c - handle LDB connection flags as unsigned

The LDB API ("ldb_connect") prescribes that they should be "unsigned".

Signed-off-by: Metze
13 years agoldb:pyldb.c - all flags should be unsigned
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 17:48:07 +0000 (19:48 +0200)]
ldb:pyldb.c - all flags should be unsigned

Adapt it to the previous commits

Reviewed-by: Jelmer + Metze
13 years agoldb:ldb_sqlite3.c - all LDB flags should be handled as "unsigned"
Matthias Dieter Wallnöfer [Wed, 13 Apr 2011 07:05:34 +0000 (09:05 +0200)]
ldb:ldb_sqlite3.c - all LDB flags should be handled as "unsigned"

Signed-off-by: Metze
13 years agoldb:tools/cmdline.c + tools/ldbtest.c - the connection flags are typed as "unsigned"
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 17:44:53 +0000 (19:44 +0200)]
ldb:tools/cmdline.c + tools/ldbtest.c - the connection flags are typed as "unsigned"

Signed-off-by: Metze
13 years agoldb:ldbtest.c - make more use of LDB constants
Matthias Dieter Wallnöfer [Wed, 11 May 2011 12:25:11 +0000 (14:25 +0200)]
ldb:ldbtest.c - make more use of LDB constants

Signed-off-by: Metze
13 years agos4:torture - always cast correctly when using the "%x" format string argument
Matthias Dieter Wallnöfer [Sat, 7 May 2011 09:06:38 +0000 (11:06 +0200)]
s4:torture - always cast correctly when using the "%x" format string argument

Signed-off-by: Metze
13 years agos4:auth/ntlmssp/ntlmssp_server.c - add "const" in front of "dnsdomain"
Matthias Dieter Wallnöfer [Sat, 7 May 2011 08:37:24 +0000 (10:37 +0200)]
s4:auth/ntlmssp/ntlmssp_server.c - add "const" in front of "dnsdomain"

Signed-off-by: Metze
13 years agoadd a demo script for dirsync
Matthieu Patou [Mon, 7 Feb 2011 06:55:26 +0000 (09:55 +0300)]
add a demo script for dirsync

Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat May 21 15:40:26 CEST 2011 on sn-devel-104

13 years agos4-dsdb: add unit tests for dirsync control
Matthieu Patou [Sun, 27 Feb 2011 09:24:45 +0000 (12:24 +0300)]
s4-dsdb: add unit tests for dirsync control

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agos4-dsdb: implementation of the dirsync control
Matthieu Patou [Thu, 13 Jan 2011 18:55:11 +0000 (21:55 +0300)]
s4-dsdb: implementation of the dirsync control

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agos4-dsdb: introduce dsdb_module_search_tree
Matthieu Patou [Sat, 19 Mar 2011 22:20:22 +0000 (01:20 +0300)]
s4-dsdb: introduce dsdb_module_search_tree

With this function your own search tree can be specified

This function is similar to ldb_build_search_req_ex as it allows to
pass a parse tree structure.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agos4-dsdb: relax a bit the checks on read acl when dirsync control is specified
Matthieu Patou [Mon, 7 Mar 2011 22:02:32 +0000 (01:02 +0300)]
s4-dsdb: relax a bit the checks on read acl when dirsync control is specified

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agos4-dsdb: create flag for requesting ACL relax in case of DIRSYNC request
Matthieu Patou [Sat, 16 Apr 2011 07:46:40 +0000 (11:46 +0400)]
s4-dsdb: create flag for requesting ACL relax in case of DIRSYNC request

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agos4: do not change the critical flag when it's on a dirsync control
Matthieu Patou [Mon, 7 Feb 2011 06:58:17 +0000 (09:58 +0300)]
s4: do not change the critical flag when it's on a dirsync control

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agoselftest: Allow to test samba4 with ACL on read set
Matthieu Patou [Thu, 14 Apr 2011 05:48:14 +0000 (09:48 +0400)]
selftest: Allow to test samba4 with ACL on read set

Signed-off-by: Andrew Tridgell <tridge@samba.org>
13 years agos4: add blackbox test for rename
Matthieu Patou [Fri, 20 May 2011 19:50:55 +0000 (23:50 +0400)]
s4: add blackbox test for rename

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat May 21 09:50:34 CEST 2011 on sn-devel-104

13 years agoupgradeprovision: add hostname in the blackbox tests
Matthieu Patou [Fri, 20 May 2011 19:50:11 +0000 (23:50 +0400)]
upgradeprovision: add hostname in the blackbox tests

13 years agoMake the purge first so that the provision can reused during tests
Matthieu Patou [Fri, 20 May 2011 16:45:43 +0000 (20:45 +0400)]
Make the purge first so that the provision can reused during tests

13 years agoAdd a script for renaming a DC
Matthieu Patou [Mon, 25 Apr 2011 20:04:32 +0000 (00:04 +0400)]
Add a script for renaming a DC