Michael Adam [Wed, 24 Aug 2011 23:35:16 +0000 (01:35 +0200)]
s3:smbd: convert notify db to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:46:42 +0000 (00:46 +0200)]
s3:smbd: convert session.c to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:42:10 +0000 (00:42 +0200)]
s3:smbd: convert connections.c to use only dbrwap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:01:44 +0000 (00:01 +0200)]
s3:conn_tdb: convert connections tdb to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:40:09 +0000 (15:40 +0200)]
s3:vfs: convert the acl_tdb module to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:36:31 +0000 (15:36 +0200)]
s3:vfs: convert nfs4_acls sidmap db code to use dbwrap_wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:32:59 +0000 (15:32 +0200)]
s3:vfs: change the xattr_tdb module to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:49:59 +0000 (11:49 +0200)]
s3:printing: convert printer_list to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:30:15 +0000 (00:30 +0200)]
s3:secrets: convert to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:38:51 +0000 (00:38 +0200)]
s3:passdb: convert account_pol to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:36:05 +0000 (00:36 +0200)]
s3:passdb: convert machine_sid to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:58:15 +0000 (10:58 +0200)]
s3:passdb: convert pdb_tdb to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs
Michael Adam [Wed, 24 Aug 2011 13:27:00 +0000 (15:27 +0200)]
s3:net: convert net idmap check to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:47:48 +0000 (11:47 +0200)]
s3:net: convert net idmap to use only dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:45:31 +0000 (11:45 +0200)]
s3:idmap: convert idmap_tdb to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Thu, 25 Aug 2011 08:50:01 +0000 (10:50 +0200)]
s3:libnet: convert libnet_dssync_passdb to only use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:24:09 +0000 (11:24 +0200)]
s3:privileges: convert privileges.c to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:21:31 +0000 (11:21 +0200)]
s3:g_lock: convert to use only dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:40:50 +0000 (11:40 +0200)]
s3:registry: convert reg_backend_db to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs
Michael Adam [Wed, 17 Aug 2011 08:50:31 +0000 (10:50 +0200)]
s3:talloc_dict: change to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:46:22 +0000 (10:46 +0200)]
s3:sharesec: convert sharesec.c to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs
Michael Adam [Wed, 24 Aug 2011 22:08:36 +0000 (00:08 +0200)]
s3:sessionid: convert to using dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:33:58 +0000 (10:33 +0200)]
s3:sessionid: use dbwrap_travers_read() in sessionid_travers_read()
This also changes the return code of sessionid_traverse_read() to NTSTATUS.
It also uses traverse_read instead of traverse.
Michael Adam [Wed, 17 Aug 2011 08:20:46 +0000 (10:20 +0200)]
s3:sessionid: use dbwrap_travers() in sessionid_traverse()
This also changes sessionid_traverse to NTSTATUS return type.
Michael Adam [Thu, 25 Aug 2011 08:39:53 +0000 (10:39 +0200)]
s3:net: convert net serverid to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 20:28:40 +0000 (22:28 +0200)]
s3:serverid: convert to using dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:10:45 +0000 (10:10 +0200)]
s3:net: fix the exit code of net serverid wipe
Michael Adam [Wed, 17 Aug 2011 08:09:57 +0000 (10:09 +0200)]
s3:net: fix the exit code of net serverid list
Michael Adam [Wed, 17 Aug 2011 08:08:31 +0000 (10:08 +0200)]
s3:serverid: use dbwrap_traverse_read() in serverid_traverse_read()
This also fixes the return value: originally the int return value
of traverse_read which is a count of the records traversed or negative
upon failure, was simply casted into a bool return value.
Michael Adam [Wed, 17 Aug 2011 08:06:07 +0000 (10:06 +0200)]
s3:serverid: use dbwrap_traverse() in serverid_traverse()
This also fixes the return value: Originally, the int returned
by the traverse method, which is the count of the traverse was
casted into a bool return value.
Michael Adam [Fri, 19 Aug 2011 08:55:22 +0000 (10:55 +0200)]
s3:dbwrap_torture: convert to using wrapper functions only
Michael Adam [Wed, 17 Aug 2011 09:42:45 +0000 (11:42 +0200)]
s3:dbwrap_tool: convert to using wrapper functions only
Michael Adam [Tue, 23 Aug 2011 23:01:38 +0000 (01:01 +0200)]
s3:dbwrap: convert dbwrap_util.c to use dbwrap wrapper functions
Michael Adam [Wed, 24 Aug 2011 11:15:48 +0000 (13:15 +0200)]
s3:dbwrap: use dbwrap_fetch_bystring() in dbwrap_fetch_[u]int32()
Michael Adam [Wed, 24 Aug 2011 11:08:13 +0000 (13:08 +0200)]
s3:dbwrap: convert dbwrap_fetch(), dbwrap_fetch_bystring() and dbwrap_fetch_bystring_upper() to NTSTATUS
Michael Adam [Fri, 19 Aug 2011 08:53:29 +0000 (10:53 +0200)]
s3:dbwrap: add dbwrap_fetch_locked(), a wrapper for db->fetch_locked
Michael Adam [Fri, 19 Aug 2011 08:52:57 +0000 (10:52 +0200)]
s3:dbwrap: add dbwrap_record_delete(), a wrapper for record->delete_rec
Michael Adam [Fri, 19 Aug 2011 08:51:27 +0000 (10:51 +0200)]
s3:dbwrap: add dbwrap_record_store(), a wrapper for record->store
Michael Adam [Fri, 19 Aug 2011 08:50:20 +0000 (10:50 +0200)]
s3:dbwrap: add get-functions for db_record key, value and private_data
Michael Adam [Thu, 18 Aug 2011 12:09:56 +0000 (14:09 +0200)]
s3:dbwrap: add wrapper function dbwrap_get_seqnum()
Michael Adam [Wed, 17 Aug 2011 20:51:12 +0000 (22:51 +0200)]
s3:dbwrap: add wrappers for transactions start/cancel/commit
Michael Adam [Wed, 17 Aug 2011 20:43:01 +0000 (22:43 +0200)]
s3:dbwrap: add wrapper dbwrap_get_flags()
Gregor Beck [Wed, 17 Aug 2011 09:44:12 +0000 (11:44 +0200)]
s3:dbwrap: fix db_rbt_traverse() to return the record count on success
this makes it consistent with documented behaviour of tdb_traverse()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 16 Aug 2011 12:55:30 +0000 (14:55 +0200)]
s3:dbwrap: add specific dbwrap_wipe() implementation to dbwrap_rbt
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 16 Aug 2011 12:43:29 +0000 (14:43 +0200)]
s3:dbwrap: add specific dbwrap_wipe() implementation to dbwrap_tdb
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 17 Aug 2011 12:42:50 +0000 (14:42 +0200)]
s3:dbwrap: add a comment
Gregor Beck [Tue, 16 Aug 2011 12:39:19 +0000 (14:39 +0200)]
s3:dbwrap: add function dbwrap_wipe()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 13:06:05 +0000 (15:06 +0200)]
s3:dbwrap: add specific dbwrap_parse_record() implementation to dbwrap_rbt
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:43:59 +0000 (13:43 +0200)]
s3:dbwrap: implement dbwrap_fallback_exists() with dbwrap_parse_record()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:42:39 +0000 (13:42 +0200)]
s3:dbwrap: allow NULL parser for dbwrap_parse_record()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:41:12 +0000 (13:41 +0200)]
s3:dbwrap: dbwrap_parse_record() should always return -1 on "not found"
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:10:30 +0000 (13:10 +0200)]
s3:dbwrap: add function dbwrap_parse_record()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 4 Jul 2011 08:22:46 +0000 (10:22 +0200)]
s3:dbwrap: add specific dbwrap_exists() implementation to dbwrap_rbt
Gregor Beck [Mon, 4 Jul 2011 07:54:31 +0000 (09:54 +0200)]
s3:dbwrap: factor out db_rpt_search_internal()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 4 Jul 2011 08:27:17 +0000 (10:27 +0200)]
s3:dbwrap: add specific dbwrap_exists() implementation to dbwrap_tdb
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 4 Jul 2011 08:15:44 +0000 (10:15 +0200)]
s3:dbwrap: add function dbwrap_exists()
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 17 Aug 2011 07:59:25 +0000 (09:59 +0200)]
s3:dbwrap: add a wrapper dbwrap_traverse_read()
Michael Adam [Wed, 17 Aug 2011 07:51:12 +0000 (09:51 +0200)]
s3:dbwrap: change the dbwrap_traverse() wrapper to return the count in an additional parameter
Michael Adam [Wed, 17 Aug 2011 06:45:09 +0000 (08:45 +0200)]
s3:dbwrap: reorganize dbwrap.h some
Michael Adam [Wed, 17 Aug 2011 06:40:53 +0000 (08:40 +0200)]
s3:dbwrap: move dbwrap_traverse() to dbwrap.c, the core of the dbrwap subsystem
Michael Adam [Wed, 17 Aug 2011 06:38:39 +0000 (08:38 +0200)]
s3:dbwrap: move dbwrap_store() back to dbwrap.c, the core of the dbwrap subsystem
Michael Adam [Wed, 17 Aug 2011 06:36:52 +0000 (08:36 +0200)]
s3:dbwrap: move dbwrap_delete() back to dbwrap.c, the core of the dbwrap subsystem
Michael Adam [Wed, 17 Aug 2011 06:35:21 +0000 (08:35 +0200)]
s3:dbwrap: move dbwrap_fetch() back to dbwrap.c, the core of the dbwrap subsystem
Michael Adam [Tue, 16 Aug 2011 14:20:14 +0000 (16:20 +0200)]
s3:dbwrap: move the db_open_rbt() prototype to a new header dbwrap_rbt.h
Michael Adam [Tue, 16 Aug 2011 14:02:19 +0000 (16:02 +0200)]
s3:dbwrap: move the db_open_file() prototype to a new header dbwrap_file.h
Michael Adam [Tue, 16 Aug 2011 13:58:27 +0000 (15:58 +0200)]
s3:dbwrap: move the db_open_tdb() prototype to a new header dbwrap_tdb.h
Michael Adam [Tue, 16 Aug 2011 13:51:58 +0000 (15:51 +0200)]
s3:dbwrap: move the db_open_ctdb() prototype to a new header dbwrap_ctdb.h
Stefan Metzmacher [Tue, 11 Oct 2011 10:37:56 +0000 (12:37 +0200)]
s3:vfs_acl_common: also parse xattr.NTACL version 1
This is what the source4/ntvfs/posix code uses.
It's also used at provision time to setup the sysvol permissions.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 11 14:16:25 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 11 Oct 2011 09:12:03 +0000 (11:12 +0200)]
s3:wscript: add 'gssapi' dependecy to 'errors3'
metze
Günther Deschner [Mon, 10 Oct 2011 19:53:15 +0000 (21:53 +0200)]
s3-passdb: split out passdb/pdb_ipa.h.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct 11 12:15:36 CEST 2011 on sn-devel-104
Günther Deschner [Mon, 10 Oct 2011 19:48:35 +0000 (21:48 +0200)]
s3-passdb: split out passdb/pdb_nds.h.
Guenther
Günther Deschner [Mon, 10 Oct 2011 19:45:42 +0000 (21:45 +0200)]
s3-passdb: split out passdb/pdb_ldap.h.
Guenther
Günther Deschner [Mon, 10 Oct 2011 16:46:53 +0000 (18:46 +0200)]
s3-smbldap: rearrange prototypes a bit.
Guenther
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 09:45:32 +0000 (11:45 +0200)]
ldb:ldb_autotransaction_request - error string shouldn't be set here
A generic error string should be set independently of the access
mechanism to an LDB operation. Hence it should be handled in "ldb_wait"
and "ldb_request"
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 11 10:15:18 CEST 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Tue, 20 Sep 2011 15:41:10 +0000 (17:41 +0200)]
ldb:pyldb.c - py_ldb_* modification calls - error string shouldn't be set here
As discussed with Jelmer, we shouldn't be setting a generic LDB error string
only for the Python bindings alone. This should be done in "ldb_request"
and "ldb_wait" - the common place for all possible LDB access mechanisms.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 09:59:06 +0000 (11:59 +0200)]
s4:ldap_backend.c/"map_ldb_error" - handle errors similar to "PyErr_SetLdbError"
If the call was done using an error string ("add_err_string"), then use that one
without an additional "ldb_strerror()" for the definitive LDAP output.
Otherwise generate one using "ldb_strerror()".
This omits redundancies in the error string generation (twice the same
information by "ldb_strerror()").
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 10:54:08 +0000 (12:54 +0200)]
ldb:ldb.c/"ldb_wait" - make "ldb_wait" always return an error string
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 10:38:46 +0000 (12:38 +0200)]
ldb:ldb.c/"ldb_wait" - change "ldb_wait" slightly in order to introduce error messages
In this occasion remove a redundant check for "LDB_ASYNC_DONE":
if (handle->state == LDB_ASYNC_DONE || if (handle->state == LDB_ASYNC_DONE)
handle->status != LDB_SUCCESS) { return handle->status;
return handle->status; == if (handle->status != LDB_SUCCESS)
} return handle->status;
... ...
return LDB_SUCCESS; return LDB_SUCCESS;
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 10:35:20 +0000 (12:35 +0200)]
ldb:ldb.c/"ldb_request" - make "ldb_request" always return an error string
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 11:43:29 +0000 (13:43 +0200)]
ldb:ldb.c - "ldb_set_errstring" can be implemented by using "ldb_asprintf_errstring"
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Sep 2011 09:38:59 +0000 (11:38 +0200)]
ldb:ldb_autotransaction_request - fix a typo in a comment
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Sun, 9 Oct 2011 12:28:15 +0000 (23:28 +1100)]
gensec: trim header includes back to what is actually required
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 11 06:13:08 CEST 2011 on sn-devel-104
Andrew Bartlett [Sun, 9 Oct 2011 12:27:44 +0000 (23:27 +1100)]
auth/credentials Declare remaining functions are public interfaces and put into credentials.h
This is in preperation for this file being used by s3, and recognises that these are all
reasonable, public interfaces but were not declared as such in the past.
Andrew Bartlett
Andrew Bartlett [Fri, 7 Oct 2011 06:24:12 +0000 (17:24 +1100)]
auth: move gensec_start.c to the top level
This does not change who uses gensec for now, but makes it possible to
write new gensec modules outside source4/
Andrew Bartlett
Andrew Bartlett [Fri, 7 Oct 2011 06:20:33 +0000 (17:20 +1100)]
auth: move credentials layer to the top level
This will allow gensec_start.c to move to the top level. This does not change
what code uses the cli_credentials code, but allows the gensec code to be
more broadly.
Andrew Bartlett
Andrew Bartlett [Mon, 10 Oct 2011 02:09:30 +0000 (13:09 +1100)]
s4-s3-upgrade: Allow import (just without a uid mapping) where getpwnam fails
This allows the tests to pass on systems without a jelmer user :-)
Andrew Bartlett
Andrew Bartlett [Sun, 9 Oct 2011 12:25:11 +0000 (23:25 +1100)]
lib/param Avoid dyn_ defines that are not provided by the autoconf build
The autoconf build will never use these parameters or load the
smb.conf with these defaults, so the defaults are not important.
Andrew Bartlett
Andrew Bartlett [Sun, 9 Oct 2011 12:24:32 +0000 (23:24 +1100)]
lib/param Use strcasecmp_m rather than strcasecmp as this is banned in the s3 includes.h
Andrew Bartlett [Sun, 9 Oct 2011 12:23:45 +0000 (23:23 +1100)]
lib/param Use talloc_strdup rather than strdup as strdup is banned in the s3 includes.h
Andrew Bartlett [Sun, 9 Oct 2011 12:23:05 +0000 (23:23 +1100)]
lib/param Avoid the name string_set as this is already used in the s3 param code
Andrew Bartlett [Sun, 9 Oct 2011 12:22:11 +0000 (23:22 +1100)]
lib/param Avoid the use of the name service_ok() which is used in the s3 param code
Andrew Bartlett [Sun, 9 Oct 2011 12:17:45 +0000 (23:17 +1100)]
lib/param: Remove unused #include of lib/socket/socket.h
Andrew Bartlett [Sun, 9 Oct 2011 12:16:55 +0000 (23:16 +1100)]
libcli/smb Move CSC_POLICY_* definition to smb_constants.h
This removes the duplicate definition between smb.h and lib/param/loadparm.c
which in turn allows this file to be compiled with the s3 includes.h
Andrew Bartlett
Andrew Bartlett [Thu, 6 Oct 2011 08:34:50 +0000 (19:34 +1100)]
lib/param move source4 param code to the top level
This is done so that the lpcfg_ functions are available across the whole
build, either with the struct loadparm_context loaded from an smb.conf directly
or as a wrapper around the source3 param code.
This is not the final, merged loadparm, but simply one step to make
it easier to solve other problems while we make our slow progress
on this difficult problem.
Andrew Bartlett
Simo Sorce [Mon, 10 Oct 2011 21:48:02 +0000 (17:48 -0400)]
pac: Fix wrong memory allocation check
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Tue Oct 11 01:18:22 CEST 2011 on sn-devel-104
Simo Sorce [Mon, 10 Oct 2011 19:52:38 +0000 (15:52 -0400)]
ndr.pc: needs samba-util not samba-hostconfig
Stefan Metzmacher [Mon, 10 Oct 2011 13:58:24 +0000 (15:58 +0200)]
libcli/cldap: don't pass tevent_context to cldap_socket_init()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 10 23:23:07 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 10 Oct 2011 13:48:11 +0000 (15:48 +0200)]
libcli/cldap: make use of explicit tevent_contexts
metze
Stefan Metzmacher [Mon, 10 Oct 2011 13:46:17 +0000 (15:46 +0200)]
libcli/cldap: pass tevent_context to cldap_search_send()
metze
Stefan Metzmacher [Mon, 10 Oct 2011 13:42:57 +0000 (15:42 +0200)]
libcli/cldap: pass tevent_context to cldap_netlogon_send()
metze