samba.git
15 years agoFix a bad memleak in vfs_full_audit
Volker Lendecke [Mon, 5 Jan 2009 12:36:34 +0000 (13:36 +0100)]
Fix a bad memleak in vfs_full_audit
(cherry picked from commit cc70e0f88328e36410089a81f41c5b33fef24a10)

15 years agoFix bug #6009 - Setting "min receivefile size = 1" breaks writes.
Jeremy Allison [Sun, 4 Jan 2009 19:47:44 +0000 (11:47 -0800)]
Fix bug #6009 - Setting "min receivefile size = 1" breaks writes.
Jeremy.
(cherry picked from commit 8275c3e7b1064dbf7b0922e0285dee28ff2eac3d)

15 years agoRevert "packaging(RHEL): fix build of [u]mount.cifs"
Karolin Seeger [Fri, 2 Jan 2009 13:51:23 +0000 (14:51 +0100)]
Revert "packaging(RHEL): fix build of [u]mount.cifs"

This reverts commit cd796359ec0c30a0204fe744805bfbea3550f57d.

Applies only for 3.3 series.

Karolin
(cherry picked from commit b17132c61c22962fc30747f4619d32d0be608272)

15 years agoRevert "packaging(RHEL): fix typo in [u]mount.cifs installation"
Karolin Seeger [Fri, 2 Jan 2009 13:50:14 +0000 (14:50 +0100)]
Revert "packaging(RHEL): fix typo in [u]mount.cifs installation"

This reverts commit b2ef64515d4a4876276d152ff2075546d2030d23.

This issue does apply for 3.3 series only.

Karolin
(cherry picked from commit 6dbaf86ba4119a4fe2b2aea56994c3d3ea5d8428)

15 years agopackaging(RHEL): fix typo in [u]mount.cifs installation
Michael Adam [Wed, 17 Dec 2008 21:27:39 +0000 (22:27 +0100)]
packaging(RHEL): fix typo in [u]mount.cifs installation

Michael
(cherry picked from commit 835108bcf84a5f47f46d237c7a93c572348125a1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 71c74725bce403e36e4dc38287802c95b8d4de66)
(cherry picked from commit cfc140d3924dd6be893d242ce5df22e2128f09f8)
(cherry picked from commit 8b4c199deffd724a4a2219ccb8ffb91524101cd9)
(cherry picked from commit b2ef64515d4a4876276d152ff2075546d2030d23)

15 years agopackaging(RHEL): fix build of [u]mount.cifs
Michael Adam [Wed, 17 Dec 2008 17:56:34 +0000 (18:56 +0100)]
packaging(RHEL): fix build of [u]mount.cifs

mount.cifs is now built by make everything.
And it needs extra objects anyways (mtab.o),
which is why the build of mount.cifs failed.

Michael
(cherry picked from commit 96c811cf222be5463a6705feae73d6215685c5f1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 308dbca653ce1d689b75f9b781237c67df4233a8)
(cherry picked from commit 9745e36c011a76669aad7a0a861ba1520ef8cec3)
(cherry picked from commit 1c1e196b648ae3ef241401f859842450c5153181)
(cherry picked from commit cd796359ec0c30a0204fe744805bfbea3550f57d)

15 years agoHappy New Year!
Stefan Metzmacher [Fri, 2 Jan 2009 08:46:17 +0000 (09:46 +0100)]
Happy New Year!

metze
(cherry picked from commit 347f1b6dcc88e04307397ea965ca8d0412b7a8c8)

15 years agoFix bug 5913.
Volker Lendecke [Thu, 1 Jan 2009 21:05:03 +0000 (22:05 +0100)]
Fix bug 5913.

Never seen this to be a problem, but it doesn't hurt either :-)
(cherry picked from commit 3577e583eeabb0555dc1ec1dd231ca835d90d307)

15 years agorecvfile can't be used for printing so far
Volker Lendecke [Wed, 31 Dec 2008 17:37:39 +0000 (18:37 +0100)]
recvfile can't be used for printing so far
(cherry picked from commit ce0a7974c5e5032893fa80fbc710edfc29353413)

15 years agoFix an ancient uninitialized variable read
Volker Lendecke [Tue, 30 Dec 2008 21:24:04 +0000 (22:24 +0100)]
Fix an ancient uninitialized variable read

The callers of open_file_ntcreate expect *psbuf to be filled correctly
(cherry picked from commit f9f6bffc3763ddd8e19400616b6e5da962142e5e)

15 years agoFix a memory leak in cups_pull_comment_location
Volker Lendecke [Tue, 30 Dec 2008 14:47:06 +0000 (15:47 +0100)]
Fix a memory leak in cups_pull_comment_location

We allocated "request" with ippNew, so we also should ippDelete it.
(cherry picked from commit 783247bdce9268d44b14005ec3eb84c35e0cd71a)

15 years agoDon't increment twice
Volker Lendecke [Mon, 29 Dec 2008 22:24:43 +0000 (23:24 +0100)]
Don't increment twice

Thanks metze :-)
(cherry picked from commit 69e7a69c781a10fc64f8e4d40c6ad07cdc23e645)

15 years agoSecond part of the bugfix for #5933
Volker Lendecke [Mon, 29 Dec 2008 21:06:08 +0000 (22:06 +0100)]
Second part of the bugfix for #5933

Incrementing the next vuid did not correctly overflow

Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-)

Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
(cherry picked from commit f03e6b8faf8f3222e3dcdaae906f48e2aa3eeba8)

15 years agoFirst part of bugfix for #5933
Volker Lendecke [Mon, 29 Dec 2008 21:01:57 +0000 (22:01 +0100)]
First part of bugfix for #5933

Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().

Jeremy, please check!
(cherry picked from commit 228d0c9459e9187d671875eda03aaa1435ab8401)

15 years agos3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()
Stefan Metzmacher [Mon, 29 Dec 2008 11:28:16 +0000 (12:28 +0100)]
s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()

All callers expect 0 an success and -1 on error.

metze
(cherry picked from commit a255f9ce713b29552722ec73e4038226959e1c8e)
(cherry picked from commit 9aa543fee7ebcc95125d18868bdec7e4bf577d8a)
(cherry picked from commit c0fc381ac7ad09fd454fd6802149c46b607069ee)

15 years agoAdd code to test write_data_iov a bit
Volker Lendecke [Mon, 22 Dec 2008 21:42:44 +0000 (22:42 +0100)]
Add code to test write_data_iov a bit
(cherry picked from commit c364d44de2285cabb83a0c105f061b8640a3a431)

15 years agoAttempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev
Volker Lendecke [Mon, 22 Dec 2008 21:32:12 +0000 (22:32 +0100)]
Attempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev

It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
(cherry picked from commit 75b5b7b2664e4d55aa97418f42a415fd88d3d4bd)

15 years agoMake write_data use write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:59 +0000 (22:17 +0100)]
Make write_data use write_data_iov
(cherry picked from commit 6bfcf1904ef50b74656d1cfb7f11b730481d2c6c)

15 years agoAdd write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:28 +0000 (22:17 +0100)]
Add write_data_iov
(cherry picked from commit 2d05db409e11443480c8cdc52e205f57aa512fba)

15 years agoAdd sys_writev
Volker Lendecke [Sun, 21 Dec 2008 22:22:30 +0000 (23:22 +0100)]
Add sys_writev
(cherry picked from commit 9f6710abfaafa4b918b0c55547d5cd0823a26a56)

15 years agoFix bug #5990 - strict allocate should be checked before ftruncate
Jeremy Allison [Thu, 25 Dec 2008 20:14:44 +0000 (12:14 -0800)]
Fix bug #5990 - strict allocate should be checked before ftruncate
reported by and based on a patch by Yasuma Takeda <yasuma@osstech.co.jp>.
Jeremy.
(cherry picked from commit b995677f9895ba7fa9744b079ebc905713e59d40)

15 years agos3: Fix stream marshalling to return the correct streaminfo status
Tim Prouty [Tue, 23 Dec 2008 17:19:25 +0000 (09:19 -0800)]
s3: Fix stream marshalling to return the correct streaminfo status

When there are enough streams on a file to fill up the max_data_count
when responding to a trans2 streaminfo, samba is returning
NT_STATUS_BUFFER_TOO_SMALL.  Windows handles this by returning
NT_STATUS_BUFFER_OVERFLOW while still sending as much of the data that
it can fit into the buffer.  When the windows client sees
BUFFER_OVERFLOW, it retries the streaminfo with a larger buffer (2x).
The windows client starts at 2K and will continue increasing the
buffer size by two until it reaches 64K.  If the streams don't fit in
64K the windows client seems to give up.

This patch fixes marshall_stream_info to overfill the buffer by 1
stream so that send_trans2_replies can properly detect the overflow
and return the correct status.
(cherry picked from commit 7adf6961bfbbb3de07d40f397db5b5520d5f9d9f)

15 years agoFix "allow trusted domain" so it disables trusted domains.
Gerald (Jerry) Carter [Mon, 22 Dec 2008 19:07:08 +0000 (11:07 -0800)]
Fix "allow trusted domain" so it disables trusted domains.
(cherry picked from commit ccd63a202b7978af3d6fdb46d1c17f0e9ac0fef6)

15 years agoFix bug #5986 - Editing a stream is broken (rename problems).
Jeremy Allison [Fri, 19 Dec 2008 21:58:55 +0000 (13:58 -0800)]
Fix bug #5986 - Editing a stream is broken (rename problems).
Jeremy.
(cherry picked from commit 5122f064d8d05b24c755506f4d7043c693670e80)

15 years agoFix a "ignoring function call result" warning
Volker Lendecke [Fri, 19 Dec 2008 20:04:59 +0000 (12:04 -0800)]
Fix a "ignoring function call result" warning
(cherry picked from commit fc86d348a41bf276c1863a0012bad3d3774bc12b)

15 years agocorrect the description of the "ldap timeout" parameter
Björn Jacke [Fri, 19 Dec 2008 11:12:59 +0000 (12:12 +0100)]
correct the description of the "ldap timeout" parameter
(cherry picked from commit 1aff97bc48844afba5de48447fdcdcc02d163a97)
(cherry picked from commit 40c510097a43edd10f6b5cd376a2cf6eca1f7e8b)

15 years agoFix bug #5980 - Race condition when granting level2 oplocks can cause break notify...
Jeremy Allison [Thu, 18 Dec 2008 21:28:18 +0000 (13:28 -0800)]
Fix bug #5980 - Race condition when granting level2 oplocks can cause break notify to be missed.
Jeremy.
(cherry picked from commit 3a8ca8406e72c2029ccbe050069da010642baf14)

15 years agoFix bug #5979 - Level 2 oplocks being granted improperly,
Jeremy Allison [Thu, 18 Dec 2008 01:23:35 +0000 (17:23 -0800)]
Fix bug #5979 - Level 2 oplocks being granted improperly,
Jeremy.
(cherry picked from commit c5d9ba5a377174e3a5b61eb17e2bbda1c9f31f84)

15 years agoFix a valgrind error
Volker Lendecke [Wed, 17 Dec 2008 17:14:09 +0000 (18:14 +0100)]
Fix a valgrind error

Reported by naga_kishore_kommuri@yahoo.com

Derrel, please check!

Thanks,

Volker
(cherry picked from commit 3356b95f72e26ede4ab16a12c334be90b8b1a639)

15 years agos3/smb.h: Remove unused LDAP_SSL_ON.
Karolin Seeger [Wed, 17 Dec 2008 15:26:43 +0000 (16:26 +0100)]
s3/smb.h: Remove unused LDAP_SSL_ON.

LDAP_SSL_ON is not defined at all.
Ldaps can be used by specifying an ldaps URL using the "passdb backend"
parameter.

Karolin
(cherry picked from commit 0c6cf1f8793edfde924289aafbd174ce4a4fae0c)
(cherry picked from commit 7f36de6906811d4f0428b75c79c72b17b8ccfcef)

15 years agos3/loadparm.c: Change default value for "ldap ssl".
Karolin Seeger [Wed, 17 Dec 2008 14:53:51 +0000 (15:53 +0100)]
s3/loadparm.c: Change default value for "ldap ssl".

LDAP_SSL_ON is not defined at all. That's why the actual default value
was "" for a long time. Set a more sensible default value without chnging the
default behaviour.

-----8<------------------snip--------------8<--------------
user@host:/data/git/samba/v3-0-test/source> git grep LDAP_SSL_ON | cat
include/smb.h:enum ldap_ssl_types {LDAP_SSL_ON, LDAP_SSL_OFF,
LDAP_SSL_START_TLS};
param/loadparm.c:       Globals.ldap_ssl = LDAP_SSL_ON;
----->8------------------snap-------------->8--------------

It's the same in 3.2 and 3.3 series.

Karolin
(cherry picked from commit e6d883e003d4560c55259ae1cfdf7319602f76e3)
(cherry picked from commit 5c686419096362176d80f3d05339b8836d0178a4)

15 years agodocs: Update section "ldap ssl" in man smb.conf.
Karolin Seeger [Wed, 17 Dec 2008 15:18:38 +0000 (16:18 +0100)]
docs: Update section "ldap ssl" in man smb.conf.

Remove non-existent value "on".
Change default value to "no".
Add hint about ldaps.

Karolin
(cherry picked from commit 580461629bb88ce3b61770e7abfe2c942a121877)
(cherry picked from commit d74356627579fe7b9961844a77c4e6daa978d62b)
(cherry picked from commit 882ac5e5a79646754dfd1669ea6720ab52c9b6ee)

15 years agodocs: Fix some formatting issues in the "ldap ssl" section of man smb.conf.
Karolin Seeger [Wed, 17 Dec 2008 14:42:12 +0000 (15:42 +0100)]
docs: Fix some formatting issues in the "ldap ssl" section of man smb.conf.

Karolin
(cherry picked from commit 6ac36698e975649d26e3f2975c2101129c3ffe97)
(cherry picked from commit 655a1c7b05d56326d6cfffbc8e46e1d64565717a)
(cherry picked from commit 2534619eedc3e9528d589cfee793a55b3cc62bed)

15 years agoTweak with pam defines of older Linux versions
Lars Müller [Wed, 17 Dec 2008 14:39:35 +0000 (15:39 +0100)]
Tweak with pam defines of older Linux versions

PAM_AUTHTOK_RECOVERY_ERR is not defined by older Linux versions (SUSE
Linux Enterprise 9 and RedHat Enterprise 4).

Patch suggested by Philipp Thomas <pth at suse dot de>.
(cherry picked from commit 9b5359f992e5ffac2cedc1360098c21f9c1d2f02)

15 years agodocs: Fix TOC of generated HTML docs.
Karolin Seeger [Wed, 17 Dec 2008 08:17:26 +0000 (09:17 +0100)]
docs: Fix TOC of generated HTML docs.

This fixes bug #5968.
Thanks to Christian Perrier <bubulle@debian.org> for reporting!

Karolin
(cherry picked from commit 675b363b712e0b91b9b7d1189a819a36853db539)
(cherry picked from commit 3566615292f9cb2d00b03156e515274751e05969)
(cherry picked from commit 0d6b3df8d9c8b5e777ac6717168a11455b2ad2ce)

15 years ago(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentatio...
Kai Blin [Tue, 16 Dec 2008 21:43:28 +0000 (13:43 -0800)]
(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NAS-BASIC server).
(cherry picked from commit b1727bbc7416f1a752cb1aadaff718e66f4a4381)

15 years agoRevert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentatio...
Jeremy Allison [Tue, 16 Dec 2008 21:34:11 +0000 (13:34 -0800)]
Revert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NASBASIC server)."
Error in commit !

This reverts commit 10e7d6b428c6e44f8b95c2794154dc1bfe4bde2d.
(cherry picked from commit bfc4c75c340e3182b5a9572763fcf8c004ec2eed)

15 years agoFinal part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault...
Kai Blin [Tue, 16 Dec 2008 21:14:25 +0000 (13:14 -0800)]
Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NASBASIC server).
(cherry picked from commit 10e7d6b428c6e44f8b95c2794154dc1bfe4bde2d)

15 years agocommit b520befe6f51644d20434add9864d7a2fa30aa2e
SATOH Fumiyasu [Tue, 16 Dec 2008 15:54:30 +0000 (00:54 +0900)]
commit b520befe6f51644d20434add9864d7a2fa30aa2e
Author: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Date:   Wed Dec 17 00:42:25 2008 +0900

    libsmbclient: Fix SIGBUS on non-x86 CPUs

    We must align the struct smbc_dirent in the struct
    SMBC_internal_data because the struct smbc_dirent
    has numeric values that require alignment.

Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit 3f47eb787f5b8499e5580407dc84c904db70b725)

15 years agonss_winbind: Solaris 64-bit fix and...
SATOH Fumiyasu [Tue, 16 Dec 2008 15:59:07 +0000 (16:59 +0100)]
nss_winbind: Solaris 64-bit fix and...

PATCH 1:
Fix gmem->numgids and gmem->maxgids breakage on Solaris 64-bit
because sizeof(int) != sizeof(long int).

PATCH 2:
This patch fixes a compile-time warning
"warning: implicit function declaration: _nss_winbind_initgroups_dyn".
(cherry picked from commit cb036772d09227f870c2fec3ecd8c3f53787dfbc)

15 years agodocs: "acl compatibility" is a global parameter.
Karolin Seeger [Tue, 16 Dec 2008 14:10:29 +0000 (15:10 +0100)]
docs: "acl compatibility" is a global parameter.

This fixes bug #5866.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!

Karolin
(cherry picked from commit 9e64ed018e5aa84d802b01953b481fbb07eb00aa)
(cherry picked from commit 386b0fc4bdc0822ffbc51cfee536bea23df0a755)
(cherry picked from commit 877951eea6e67273748aa9f56a56e41cf2dca00a)

15 years agodocs: Fix typo in the idmap_ad manpage.
Karolin Seeger [Tue, 16 Dec 2008 08:04:32 +0000 (09:04 +0100)]
docs: Fix typo in the idmap_ad manpage.

Karolin
(cherry picked from commit b876e1336bed52e0823e0e88381d223bd6aa95e4)
(cherry picked from commit 611ac35a694930693d2f773d15e59be138261a8e)
(cherry picked from commit d54a1e49d5fe567bcda7c4c02f6ace2d03e189e9)

15 years agos3:net_status: use dbwrap to open sessionid.tdb
Stefan Metzmacher [Tue, 16 Dec 2008 09:40:32 +0000 (10:40 +0100)]
s3:net_status: use dbwrap to open sessionid.tdb

metze
(cherry picked from commit 8891b2b0215a3609fcc8c5f9aa3e2fbcf05c6290)
(cherry picked from commit 598bf8fbe38d76adca2e067c90987d9cd31e8a3e)
(cherry picked from commit 776c7ce0c1e73efc4f3d24a297bb3b2f3dd3892a)

15 years agoFix bug 5969: Optimize smbclient put command
Volker Lendecke [Mon, 15 Dec 2008 11:46:04 +0000 (12:46 +0100)]
Fix bug 5969: Optimize smbclient put command

This used to be checkin 3f0406f6 to master
(cherry picked from commit e504256f84927c9b22df3945a3e95baaa9bf7063)

15 years agoFix error code when smbclient puts a file over an existing directory
Volker Lendecke [Sat, 13 Dec 2008 21:14:58 +0000 (13:14 -0800)]
Fix error code when smbclient puts a file over an existing directory

Windows returns NT_STATUS_FILE_IS_A_DIRECTORY, as does Samba 3.0. 3.2 and
following returned NT_STATUS_INVALID_PARAMETER which is wrong.

Before I converted reply_open_and_X to create_file() we called
open_file_ntcreate directly. Passing through open&X for a filename that exists
as a directory ends up in open_directory after having tried open_file_ntcreate.
Some check in there returns NT_STATUS_INVALID_PARAMETER. With this additional
FILE_NON_DIRECTORY_FILE flag we get the correct error message back from
create_file_unixpath before trying open_directory().

Survives make test, but as this also touches the other open variants I would
like others to review this.

Volker
(cherry picked from commit 73039cd49521e724a8351a353e9ae1d342be1352)

15 years agos3:dsgetdcname: retry with the clients site
Stefan Metzmacher [Fri, 21 Nov 2008 07:28:13 +0000 (08:28 +0100)]
s3:dsgetdcname: retry with the clients site

metze
(cherry picked from commit 1b7b0e924f3064a9774fd5d46bedc3d342b39ddb)
(cherry picked from commit f7a811f2ae3572791035014b6e20410b07ea011e)
(cherry picked from commit 3d2fe303830c0c1e425f6279a1625a56a27abd07)

15 years agos3:libnet_join: use DS_FORCE_REDISCOVERY
Stefan Metzmacher [Fri, 21 Nov 2008 07:22:38 +0000 (08:22 +0100)]
s3:libnet_join: use DS_FORCE_REDISCOVERY

metze
(cherry picked from commit 2bb91392b46e347fe3b6803d10b10d8b40e4a4a6)
(cherry picked from commit 134893ef2b12b4b039c717588a8172613f6d1955)
(cherry picked from commit 9838de125505fdff18014d72ebe9816176a610f9)

15 years agos3:libnet_join: call saf_join_store() after a the join.
Stefan Metzmacher [Mon, 27 Oct 2008 18:40:23 +0000 (19:40 +0100)]
s3:libnet_join: call saf_join_store() after a the join.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(similar to commit feef594d275881466e2c3f59c0ff54609a9cc53b)
(cherry picked from commit 6a993cb333675f4079d439fa334edee2df604933)
(cherry picked from commit 8314ce63ff77f0472d4249adcea87123b3b3f5c2)
(cherry picked from commit d47dda115e1a3df50357a7a82694522df884c374)

15 years agos3:libads/ldap.c: store the dc name in the saf cache as in all other places
Stefan Metzmacher [Mon, 27 Oct 2008 18:39:30 +0000 (19:39 +0100)]
s3:libads/ldap.c: store the dc name in the saf cache as in all other places

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 543fa85a711337e979c7b631bda5db95d109ef59)
(cherry picked from commit 17efebde11eafd065c2cac39cdbe55b8d40d40be)
(cherry picked from commit 9e78bfdbe107519f2ddfa4d532771945a7691b46)
(cherry picked from commit 6359df973fa24a3babd0e10e9e131ace47e2b2e8)

15 years agos3:libads/ldap.c: if the client belongs to no site at all any dc is the closest
Stefan Metzmacher [Mon, 27 Oct 2008 18:38:15 +0000 (19:38 +0100)]
s3:libads/ldap.c: if the client belongs to no site at all any dc is the closest

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit f86ef9b53a903485deba94febf90dd4e657cc02b)
(cherry picked from commit a8040d59659e58c5cb92c1107a7ff012eff12729)
(cherry picked from commit 7baceea20252dec6b64e86ec8b5a73b62b373758)
(cherry picked from commit 60c0166fd492bb6cff41811973c8da026c5109d7)

15 years agos3:libads/ldap.c: pass the real workgroup name to get_dc_name()
Stefan Metzmacher [Mon, 27 Oct 2008 18:36:25 +0000 (19:36 +0100)]
s3:libads/ldap.c: pass the real workgroup name to get_dc_name()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit c2d4a84abe1b6cbf68d6e9f1bb1f8974d0b628fc)
(cherry picked from commit 2f27ffc4a2ba745341a5961b8f04e62da3fb089a)
(cherry picked from commit 132911954715bfa6df8566c0fb382ef07a7da96e)
(cherry picked from commit f771eee7878fd4d5e670000256032ed56f537d8e)

15 years agos3:libsmb/namequery.c: add saf_join_store() function
Stefan Metzmacher [Sat, 13 Dec 2008 11:18:32 +0000 (12:18 +0100)]
s3:libsmb/namequery.c: add saf_join_store() function

saf_join_store() should be called after a successful
domain join, the affinity to the dc used at join time
has a larger ttl, to avoid problems with delayed replication.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 80e74a27c55c01221091e3eec930c2ac4433c22c)
(cherry picked from commit 895c40d03a07182c054a6fd857e7dd6838e698f4)
(cherry picked from commit 7b56268b3c9652e3089bd75e4e51dd626fa742a6)
(cherry picked from commit 6ee994e2d25d14b31dc9de75264e94a9ac6a09d4)

15 years agos3: libsmb/namequery: fallback to returning all dcs, when none is available in the...
Stefan Metzmacher [Mon, 27 Oct 2008 08:40:25 +0000 (09:40 +0100)]
s3: libsmb/namequery: fallback to returning all dcs, when none is available in the requested site

It could happen that all dcs in a site are unavailable
(some sites have only one dc) and then we need to fallback
to get all dcs.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit c127367b1dd622eeceb1f47de0a047c297dda222)
(cherry picked from commit 0c43f96330f2935805ba4f0f8f858a027a90bc4c)
(cherry picked from commit caaf59383ceabdc555f7db098dae0455dea65023)
(cherry picked from commit 8321caf35736401d2a0d53cefc5c432d5b9e2bc7)

15 years agos3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP case
Stefan Metzmacher [Wed, 22 Oct 2008 09:14:10 +0000 (11:14 +0200)]
s3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP case

We use get_dc_name() for LDAP because it generates the selfwritten
krb5.conf with the correct kdc addresses and sets KRB5_CONFIG.

For CLDAP we need to use get_sorted_dc_list() to avoid recursion.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit d2f7f81f4d61bae9c4be65cbc1bf962b6c24a31f)
(cherry picked from commit 7f779450cb0b0d9f36665c56c4acd0950daaeab2)
(cherry picked from commit 95c9a0272a72c029d75c3ffd1b5fad360b30f139)
(cherry picked from commit 5e47b314550d1165b86bd556330d36e0787e5109)

15 years agos3: correctly detect if the current dc is the closest one
Stefan Metzmacher [Wed, 22 Oct 2008 08:36:21 +0000 (10:36 +0200)]
s3: correctly detect if the current dc is the closest one

ads->config.tried_closest_dc was never set.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit dfe5b00db35e1e7c7bb3ba36729fc3f97eb48db3)
(cherry picked from commit 588f5aae669910fee6da7f807f330163496b4170)
(cherry picked from commit b609f41baa035a15dafb18b2ec569a2b96968b17)
(cherry picked from commit 46d5eef85477d621c27e72910bffe6d15f83d6a6)

15 years agolibnet_join: streamline logic of libnet_join_post_processing()
Michael Adam [Fri, 29 Aug 2008 15:55:28 +0000 (17:55 +0200)]
libnet_join: streamline logic of libnet_join_post_processing()

Michael
(cherry picked from commit 81cc1af1e699e454fbb1d12636d002f845231006)
(cherry picked from commit 3ea63ec10c37460253fbe68d63576e0cd8783c11)
(cherry picked from commit e79ce10550e18a59e9aa2edb377e9b7130e60789)

15 years agolibnet: fix join by creating keytab after changing the config.
Michael Adam [Fri, 29 Aug 2008 15:43:12 +0000 (17:43 +0200)]
libnet: fix join by creating keytab after changing the config.

Michael
(cherry picked from commit 96d1c780bf9524b929e6026776602a5288aea73d)
(cherry picked from commit 298e5b663b1d6b469d130041dbed151801a45d1e)
(cherry picked from commit d5f1a3b9196933f86f46a6664a044fd027a8f417)

15 years agodon't return 0 on error - bad for scripts
Herb Lewis [Fri, 12 Dec 2008 21:47:10 +0000 (13:47 -0800)]
don't return 0 on error - bad for scripts
(cherry picked from commit dc3c9fd570850e69ad5166184726f9abb7d8a9c7)

15 years agowinbindd: vars for signals must be volatile sig_atomic_t
SATOH Fumiyasu [Fri, 12 Dec 2008 16:43:51 +0000 (17:43 +0100)]
winbindd: vars for signals must be volatile sig_atomic_t
(cherry picked from commit c48a4e52b707a860c2956b3eb9d1d631ffffb1f1)

15 years agodocs: Add hint that "socket address" usually don't need to be set.
Karolin Seeger [Fri, 12 Dec 2008 13:30:01 +0000 (14:30 +0100)]
docs: Add hint that "socket address" usually don't need to be set.

This fixes bug #5950.
Thanks to the Debian Samba package maintainers for reporting!

Karolin
(cherry picked from commit 19beef0dd9354296ae79d32077c58fbacf570c85)
(cherry picked from commit 0d035d36bd3707ccb9f77f0b2730869dc78719d4)
(cherry picked from commit 6be19f94802d545cc43286aa242b0ca2e5b79721)
(cherry picked from commit 879a4fbe99739b67d877caac2d7a2f763c69d41f)

15 years agomount.cifs: allow mounts to ipv6 capable servers
Jeff Layton [Fri, 12 Dec 2008 12:08:30 +0000 (07:08 -0500)]
mount.cifs: allow mounts to ipv6 capable servers

The current name resolution scheme in mount.cifs is IPv4 only. Expand
it to be protocol-independent. Also take advantage of the fact that
getaddrinfo() returns a list of addresses and have mount.cifs try each
in turn until it hits one that's reachable and allows the socket to
connect.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit 9af716f5fb144a047f1fc9fe02f24bcc59a0bc97)

15 years agoWHATSNEW: Prepare WHATSNEW for 3.2.7. samba-3.2.7
Karolin Seeger [Fri, 19 Dec 2008 13:57:33 +0000 (14:57 +0100)]
WHATSNEW: Prepare WHATSNEW for 3.2.7.

Karolin

15 years agoVERSION: Raise version number up to 3.2.7.
Karolin Seeger [Fri, 19 Dec 2008 13:45:36 +0000 (14:45 +0100)]
VERSION: Raise version number up to 3.2.7.

Karolin

15 years agosmbd: prevent access to root filesystem when connecting with empty service name
Michael Adam [Thu, 18 Dec 2008 17:01:55 +0000 (18:01 +0100)]
smbd: prevent access to root filesystem when connecting with empty service name

This only applies to a setup with "registry shares = yes"

Michael

15 years agoRevert "Samba3-HOWTO: Fix usage of 'net idmap restore'."
Karolin Seeger [Fri, 19 Dec 2008 07:29:03 +0000 (08:29 +0100)]
Revert "Samba3-HOWTO: Fix usage of 'net idmap restore'."

This reverts commit e4ae4becbe5ea1454d15f0fb2d6cd4fe7e8edfd7.

15 years agoSamba3-HOWTO: Fix usage of 'net idmap restore'.
Karolin Seeger [Thu, 11 Dec 2008 17:08:29 +0000 (18:08 +0100)]
Samba3-HOWTO: Fix usage of 'net idmap restore'.

This fixes bug #5883.

Karolin
(cherry picked from commit b4a4e635246b88277b235fa343eda48bd4bb4ce3)
(cherry picked from commit 5744177740120524740db884564142df19358ae7)
(cherry picked from commit 7584fe4e8bcbaf73f509d6981a70ff9dde92db1c)
(cherry picked from commit fda3f00246c3ecb664d2bf387ecd0e28dec16e34)

15 years agos3-libnetjoin: Fix bug #5749. Re-set acctflags while joining. fix from metze. samba-3.2.6
Günther Deschner [Fri, 28 Nov 2008 23:12:26 +0000 (00:12 +0100)]
s3-libnetjoin: Fix bug #5749. Re-set acctflags while joining. fix from metze.

Guenther
(cherry picked from commit bc3a277455dd4557e796ddc0bef0f52a11f889e7)
(cherry picked from commit a6a8025d48e63a8bcb1fb03efa8ab85e415f8a38)

15 years agos3-libnetjoin: remove unused md4_trust_password, found by metze.
Günther Deschner [Fri, 28 Nov 2008 23:10:18 +0000 (00:10 +0100)]
s3-libnetjoin: remove unused md4_trust_password, found by metze.

Guenther
(cherry picked from commit f479fdc29813c3452fd22c4a2780f0bc5066e664)
(cherry picked from commit a4164a55b5b20ae347a22810405c738f868d8493)

15 years agos3-samr: add init_samr_user_info25 and init_samr_user_info26.
Günther Deschner [Fri, 28 Nov 2008 10:15:29 +0000 (11:15 +0100)]
s3-samr: add init_samr_user_info25 and init_samr_user_info26.

Guenther
(cherry picked from commit b51eaa4a4da0dfc46919e9a544b3d26569a1495c)

15 years agos3-samr: fix init_samr_user_info{23,24} callers.
Günther Deschner [Mon, 24 Nov 2008 17:49:37 +0000 (18:49 +0100)]
s3-samr: fix init_samr_user_info{23,24} callers.

Guenther
(cherry picked from commit 948a2e5d38b5d69e3c65e81d0b0fd750410bc066)

15 years agorpc_client: use init_samr_CryptPassword(Ex) in client tools.
Günther Deschner [Wed, 30 Jul 2008 17:52:56 +0000 (19:52 +0200)]
rpc_client: use init_samr_CryptPassword(Ex) in client tools.

Guenther
(cherry picked from commit 97f7f9f21f17e8414de15953cf4eaa9959dc6f75)
(cherry picked from commit 458e85603673e04577fc493528c870c3d5ec6b54)

15 years agorpc_client: add init_samr_CryptPasswordEx and init_samr_CryptPassword.
Günther Deschner [Fri, 18 Jul 2008 18:42:55 +0000 (20:42 +0200)]
rpc_client: add init_samr_CryptPasswordEx and init_samr_CryptPassword.

Guenther
(cherry picked from commit 599155842583781736933ef340e37fd5c87f88ca)

15 years agos3: merge german pam_winbind message translations from master.
Günther Deschner [Tue, 18 Nov 2008 16:06:53 +0000 (17:06 +0100)]
s3: merge german pam_winbind message translations from 

Guenther
(cherry picked from commit aa0ef2f97d98e7ca80636a4dc8093d2034d0dbf1)
(cherry picked from commit 1ac0175bb13ce34fbb2deaa880a4021625b259be)

15 years agos3-build: re-run make samba3-idl.
Günther Deschner [Mon, 24 Nov 2008 15:32:18 +0000 (16:32 +0100)]
s3-build: re-run make samba3-idl.

Guenther
(cherry picked from commit c28e83417dc67083b06fb060f5382ceb082bbdcd)
(cherry picked from commit bfd02c2d2391a5c4faea4f7c1c1fb22d527218a3)

15 years agosamr: fix samr_UserInfo24 and samr_UserInfo26.
Günther Deschner [Mon, 24 Nov 2008 15:31:49 +0000 (16:31 +0100)]
samr: fix samr_UserInfo24 and samr_UserInfo26.

Guenther
(cherry picked from commit 0315308cbc724bbf54b7767b4af307217833f541)
(cherry picked from commit 16a4f8f7dc59c6b586259b2d5daf1b23d25b2d7f)

15 years agoWHATSNEW: Update changes.
Karolin Seeger [Wed, 10 Dec 2008 08:28:49 +0000 (09:28 +0100)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit 760de2d48940ed88aca1fa459e4af455b541940c)

15 years agoFix bug #5688 LPQ process is orphaned if socket address parameter is invalid
SATOH Fumiyasu [Tue, 9 Dec 2008 22:26:39 +0000 (14:26 -0800)]
Fix bug #5688 LPQ process is orphaned if socket address parameter is invalid
Karolin please pull for 3-2-stable.
Jeremy
(cherry picked from commit 5dfccee083490eea8230a5965cb52b01ddf5041e)

15 years agobuild-docs: Change to the right directory before calling 'make clean'.
Karolin Seeger [Tue, 9 Dec 2008 21:08:13 +0000 (22:08 +0100)]
build-docs: Change to the right directory before calling 'make clean'.
This fixes build-docs if it's called from the create-tarball script.

Karolin
(cherry picked from commit dd3ef73c8c184eaec7ee515ef2130f30f9e481b3)

15 years agobuild-docs: Use 'git clean' instead of 'git-clean'.
Karolin Seeger [Wed, 19 Nov 2008 12:16:38 +0000 (13:16 +0100)]
build-docs: Use 'git clean' instead of 'git-clean'.

Karolin
(cherry picked from commit 12e72140b944f844e7f44f21a087ab4a4ecc51a7)
(cherry picked from commit ab02316ced8b0dc0d577960d1bab02d239313ef5)

15 years agoWHATSNEW: Update changes.
Karolin Seeger [Tue, 9 Dec 2008 16:39:03 +0000 (17:39 +0100)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit f73ecfaa7942bf01720f330b99cce3305ea6859c)

15 years agoWHATSNEW: Fix entry.
Karolin Seeger [Tue, 9 Dec 2008 16:35:49 +0000 (17:35 +0100)]
WHATSNEW: Fix entry.

Karolin
(cherry picked from commit d700767e11f413c9386876e73462f701cf7e447f)

15 years agos3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.
Günther Deschner [Tue, 9 Dec 2008 16:28:15 +0000 (17:28 +0100)]
s3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.

Guenther
(cherry picked from commit 26139344fd0fac4fdd2a6752628b252fbd9b7450)

15 years agoVERSION: Raise version number up to 3.2.6.
Karolin Seeger [Tue, 9 Dec 2008 16:18:35 +0000 (17:18 +0100)]
VERSION: Raise version number up to 3.2.6.

Karolin
(cherry picked from commit fc4819ab176552f1ca0d78ddc91a62666c1fdf71)

15 years agoWHATSNEW: Update changes for 3.2.6.
Karolin Seeger [Tue, 9 Dec 2008 16:17:50 +0000 (17:17 +0100)]
WHATSNEW: Update changes for 3.2.6.

Karolin
(cherry picked from commit c13ffd858ab873771f073a36c4d7e3159e71cc93)

15 years agoFix bug #5953 - smbclient crashes: cli_list_new segmentation fault.
Jeremy Allison [Mon, 8 Dec 2008 22:02:59 +0000 (14:02 -0800)]
Fix bug #5953 - smbclient crashes: cli_list_new segmentation fault.
Karolin: must be in 3.2-stable. Thanks,
Jeremy.
(cherry picked from commit 00af69227dbdd6dfd3776b5cb52f479c9c85b697)

15 years agoFix logging to syslog
Dan Sledz [Sat, 6 Dec 2008 01:29:38 +0000 (17:29 -0800)]
Fix logging to syslog
(cherry picked from commit 66c08857fbf78a24e7770e1d1bf8938bb938b271)

15 years agoFix bug #5928 - Option --version in testparm does not work.
Tomasz Krasuski [Sat, 6 Dec 2008 00:30:55 +0000 (16:30 -0800)]
Fix bug #5928 - Option --version in testparm does not work.
(cherry picked from commit 635373512634a05d65b009e4ec3669a227b2b94d)

15 years agoFix bug #5944 - nmbd does not boot if socket adress = "" is defined in smb.conf
Yasuma Takeda [Fri, 5 Dec 2008 21:38:06 +0000 (13:38 -0800)]
Fix bug #5944 - nmbd does not boot if socket adress = "" is defined in smb.conf
(cherry picked from commit 0e3d643712ed315bacc91db56985358e20ce9913)

15 years agoFix for crash bug freeing a non-malloc'ed buffer if the client sends a non-encrypted...
Volker Lendecke [Fri, 5 Dec 2008 21:21:19 +0000 (13:21 -0800)]
Fix for crash bug freeing a non-malloc'ed buffer if the client sends a non-encrypted packet with the crypto state set.
(cherry picked from commit c2012ac787c05361c7fa9589bec4f7e5c6482a28)

15 years agoFix bug #5937 - filenames with "*" char hide other files
Jeremy Allison [Thu, 4 Dec 2008 23:33:27 +0000 (15:33 -0800)]
Fix bug #5937 - filenames with "*" char hide other files
Jeremy.
(cherry picked from commit 601c7eabfdb3d2725849669dda58de6db22d9b8f)

15 years agoFix bug #5929 - vfs_prealloc does not build with option --with-cluster-support and...
Henning Henkel [Thu, 4 Dec 2008 21:43:59 +0000 (13:43 -0800)]
Fix bug #5929 - vfs_prealloc does not build with option --with-cluster-support and GPFS
(cherry picked from commit a1e4637922a565278cceac7b2fe95f82ad049f4a)

15 years agoFix bug #1254 - write list not working under share-level security
Jeremy Allison [Thu, 4 Dec 2008 18:23:06 +0000 (10:23 -0800)]
Fix bug #1254 - write list not working under share-level security
Jeremy.
(cherry picked from commit d2b7d9d29feab263bf736a88e5819203cbc8a165)

15 years agowinbindd: fix more horrible brace mis-indentations in winbindd_group
Michael Adam [Thu, 4 Dec 2008 14:01:46 +0000 (15:01 +0100)]
winbindd: fix more horrible brace mis-indentations in winbindd_group

Sorry, but I can't bear this.

And while my vim is smart enough to cope with this,
it confuses _me_, and I have seen an emacs confused as well.
(Which comes as no surprise, almost human as it is...)

Michael
(cherry picked from commit addbddf90a4935f7fda8ed4acbf5a4574d7fc92b)

15 years agowinbindd: fix more misindentations of top level braces in winbindd_group
Michael Adam [Thu, 4 Dec 2008 13:30:52 +0000 (14:30 +0100)]
winbindd: fix more misindentations of top level braces in winbindd_group

Michael
(cherry picked from commit 21dedb62d866bb0a2ae808c8d5a411c7f0fb8604)

15 years agowinbindd: fix horrible mis-indentation of toplvl braces in getgrsid_sid2gid_recv
Michael Adam [Thu, 4 Dec 2008 13:29:01 +0000 (14:29 +0100)]
winbindd: fix horrible mis-indentation of toplvl braces in getgrsid_sid2gid_recv

to make code more readable

Michael
(cherry picked from commit 2deb1272ef7d3edd910988e696f5556bcfcdbe1f)

15 years agowinbindd: don't open a new dc connection in winbindd_getpwnam (main winbindd)
Michael Adam [Wed, 3 Dec 2008 15:38:55 +0000 (16:38 +0100)]
winbindd: don't open a new dc connection in winbindd_getpwnam (main winbindd)

This is just to find the corresponding domain struct.
Actual connection is handled by the domain child.

Michael
(cherry picked from commit 284b3e50435d4450008031e00b7290a1970a0cc4)

15 years agowinbindd: don't open a new dc connection in winbindd_getgrnam (main winbindd)
Michael Adam [Wed, 3 Dec 2008 14:59:17 +0000 (15:59 +0100)]
winbindd: don't open a new dc connection in winbindd_getgrnam (main winbindd)

This is just to find the corresponding domain struct.
Actual connection is handled by the domain child.

Michael
(cherry picked from commit b8e94c56a68cb3525682e24de6078608a1146240)

15 years agos3:net: fix password set of 'net rpc trustdom add'
Stefan Metzmacher [Thu, 4 Dec 2008 11:26:03 +0000 (12:26 +0100)]
s3:net: fix password set of 'net rpc trustdom add'

metze
(cherry-picked from commit 2b8f3e253d3a56aac996287f5ce265d0c915b3c8)
(cherry picked from commit e1e76f19cf9c72abe4086965846b2d438cfbdd00)
(cherry picked from commit 05fbd5f87cb39cffe0acc5c3132e13f2d471edf2)

15 years agoChange sockaddr util function names for consistency and to eliminate name conflicts
Tim Prouty [Wed, 3 Dec 2008 18:37:03 +0000 (10:37 -0800)]
Change sockaddr util function names for consistency and to eliminate name conflicts
(cherry picked from commit 10dd8a54ea7ea2cf86de5e20a62912298e0c4acc)

15 years agolibwbclient: avoid usage talloc_init() in library code
Stefan Metzmacher [Wed, 3 Dec 2008 08:07:00 +0000 (09:07 +0100)]
libwbclient: avoid usage talloc_init() in library code

talloc_init() is a compat function for the old samba3
non-hierachical talloc implementation. It enables
the talloc null tracking which should never be done
by library code.

metze
(cherry picked from commit afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b)
(cherry picked from commit 37a92ed0eb2c8cf7f3eac1d90ba5300cbce45186)
(cherry picked from commit f84cbb18a018d4c28fb98f00a38a7b7df48768c0)