Jeremy Allison [Tue, 19 Jul 2011 19:21:23 +0000 (12:21 -0700)]
First part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems
Remove
int toupper_ascii(int c);
int tolower_ascii(int c);
int isupper_ascii(int c);
int islower_ascii(int c);
and replace with their _m equivalents, as they are identical.
Jeremy Allison [Sat, 16 Jul 2011 04:36:13 +0000 (21:36 -0700)]
Fix bug #8307 - brl_close_fnum does not call SMB_VFS_BRL_UNLOCK_WINDOWS on all locks
Reported by herb@samba.org. Remove the (premature) optimization
on file close.
Karolin Seeger [Wed, 13 Jul 2011 19:52:32 +0000 (21:52 +0200)]
WHATSNEW: Update changes since rc2.
Karolin
Stefan Metzmacher [Sun, 10 Jul 2011 11:09:06 +0000 (13:09 +0200)]
s3:smb2_create: use smbd_calculate_access_mask() instead of smbd_check_open_rights()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul 11 22:45:01 CEST 2011 on sn-devel-104
(cherry picked from commit
f5d320ac0fb74d4ad95a03969366096e9b074379)
The last 10 patches address bug #8102 (domuser can change ACL from his files
over the network).
Stefan Metzmacher [Sun, 10 Jul 2011 11:02:11 +0000 (13:02 +0200)]
s3:smb2_tcon: return the correct maximal_access on the share
metze
(cherry picked from commit
a1046389ffcc476456ac76cb701a4325d1c42ef9)
Stefan Metzmacher [Mon, 11 Jul 2011 14:12:57 +0000 (16:12 +0200)]
s3:smbd: return the real share access mask in the SMBtconX response
metze
(cherry picked from commit
58eed1b295afeff6acfb8c1f10b0bb02280fd491)
Stefan Metzmacher [Sun, 10 Jul 2011 11:59:40 +0000 (13:59 +0200)]
s3:smbd: use smbd_calculate_access_mask() also for fake_files
metze
(cherry picked from commit
581d8fa36b73abab030168dc35fb631ccd42a388)
Stefan Metzmacher [Sun, 10 Jul 2011 11:03:51 +0000 (13:03 +0200)]
s3:smbd: check the share level access mask in smbd_calculate_access_mask()
I think we should reject invalid access early,
before we might create new files.
Also smbd_check_open_rights() is only called if the file existed.
metze
(cherry picked from commit
896f105ed40dc04f83bcbfac367b309c8d957f86)
Stefan Metzmacher [Sun, 10 Jul 2011 11:00:25 +0000 (13:00 +0200)]
s3:smbd: make smbd_calculate_access_mask() non-static
metze
(cherry picked from commit
ce66d4e4a885add09edfa8e6d5eab0f3b5d63081)
Stefan Metzmacher [Tue, 12 Jul 2011 15:31:13 +0000 (17:31 +0200)]
s3:smbd/msdfs: let create_conn_struct() check the share security descriptor
metze
(cherry picked from commit
18f967a24881aa899b39f7676fc70a7f7aaca07b)
Volker Lendecke [Tue, 5 Jul 2011 09:13:07 +0000 (11:13 +0200)]
s3: Fix bug 8102
We can't allow open with access that has been denied via the share
security descriptor
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jul 5 16:21:54 CEST 2011 on sn-devel-104
(cherry picked from commit
4deca5d72804a40e68158a1183f5633dabf24761)
Volker Lendecke [Mon, 4 Jul 2011 16:35:21 +0000 (18:35 +0200)]
s3: Calculate&store the maximum share access mask
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
720fa46f9443ccbe471b265f1c2b9cb9782a3c26)
Volker Lendecke [Mon, 4 Jul 2011 15:02:34 +0000 (17:02 +0200)]
s3: Return "granted" from share_access_check
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
1c022d2e414607633323e65abbc63bb3aeaaa6a4)
Stefan Metzmacher [Fri, 8 Jul 2011 07:08:39 +0000 (09:08 +0200)]
s3:smb2_server: add some comments about change_to_user() and change_to_root_user()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul 8 13:45:46 CEST 2011 on sn-devel-104
(cherry picked from commit
dbfb88aef30a755c29015bff4699eb17925a4988)
The last 3 patches address bug #8292 (Disable SMB2 for 3.6).
Stefan Metzmacher [Thu, 7 Jul 2011 14:38:33 +0000 (16:38 +0200)]
s3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()
For all requests which don't operate on a tcon, we should call
change_to_root_user(), to match the SMB1 behavior.
For SMB1 we do the following operations without AS_USER:
/* 0x70 */ { "SMBtcon",reply_tcon,0},
/* 0x71 */ { "SMBtdis",reply_tdis,DO_CHDIR},
/* 0x72 */ { "SMBnegprot",reply_negprot,0},
/* 0x73 */ { "SMBsesssetupX",reply_sesssetup_and_X,0},
/* 0x74 */ { "SMBulogoffX",reply_ulogoffX, 0}, /* ulogoff doesn't give a valid TID */
/* 0x75 */ { "SMBtconX",reply_tcon_and_X,0},
...
/* 0x2b */ { "SMBecho",reply_echo,0},
...
/* 0xa4 */ { "SMBntcancel",reply_ntcancel, 0 },
For SMB2tdis we still call smbd_smb2_request_check_tcon()
as close_cnum() calls change_to_root_user() when needed.
metze
Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
eea210eba7c20e6d04b13cf8ccd3011ee7c99157)
Stefan Metzmacher [Mon, 4 Jul 2011 13:57:20 +0000 (15:57 +0200)]
s3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul 4 17:34:13 CEST 2011 on sn-devel-104
(cherry picked from commit
7c96e96e9881ec1ad7b41f0ab241a5b0ac17b93f)
Karolin Seeger [Wed, 13 Jul 2011 19:21:23 +0000 (21:21 +0200)]
WHATSNEW: Update changes since rc2.
Karolin
Karolin Seeger [Wed, 13 Jul 2011 19:20:56 +0000 (21:20 +0200)]
VERSION: Set version to 3.6.0rc3.
Karolin
Jeremy Allison [Tue, 12 Jul 2011 20:06:13 +0000 (13:06 -0700)]
Fix bug #Bug 8304 - Uninitialized variable referenced in error path.
princ must not be used uninitialized. auth_data is not used at all.
Günter Kukkukk [Wed, 13 Jul 2011 13:10:13 +0000 (06:10 -0700)]
Fix bug 8305 - nmbd segfaults - when using "smbtree ..." (cherry picked from commit
102a931c8081559423fb25b3a4d445b6f2e790ac)
Karolin Seeger [Tue, 12 Jul 2011 19:11:34 +0000 (21:11 +0200)]
s3-docs: Remove manpages for ldb tools.
Fix bug #8297 (ldb tools man pages should be removed from the release tar
ball).
Thanks to Björn for reporting!
Karolin
Jeremy Allison [Thu, 7 Jul 2011 21:59:41 +0000 (14:59 -0700)]
Fix bug #8293 - SMB2 doesn't rotate the log files often enough.
Move the num_requests field out of the smb1 struct into the generic
struct smbd_server_connection struct. Use it to count SMB2 requests
as well as SMB1 and ensure that check_log_size() is called every 50
SMB2 requests.
Günther Deschner [Fri, 8 Jul 2011 15:17:17 +0000 (17:17 +0200)]
s3-waf: split out LIBCLI_WINREG_INTERNAL as LIBCLI_WINREG was pulling in rpc server code in undesired places.
Andreas, please check.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jul 8 18:34:44 CEST 2011 on sn-devel-104
(cherry picked from commit
f4add4fbf545313f5d24e0d9e5c9eb0f8fac630a)
Conflicts:
source3/rpc_server/wscript_build
source3/wscript_build
The last 21 patches address bug #8214 (printer driver upgrade fails, causing
smbd to exit on startup).
David Disseldorp [Tue, 5 Jul 2011 13:04:02 +0000 (15:04 +0200)]
s3-printing: remove tdb migration invalid printer name checks
WERR_INVALID_PRINTER_NAME only needed to be handled when printing tdb
migration used spoolss, with winreg such errors are no longer possible.
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jul 7 19:15:34 CEST 2011 on sn-devel-104
(cherry picked from commit
e5955903fdc5ed6f8660b72db0716d4da25c711c)
David Disseldorp [Tue, 5 Jul 2011 09:34:47 +0000 (11:34 +0200)]
s3-printing: fill info2_mask in printer migration
Also fix possibly uninitialised status return from
printing_tdb_migrate_printer().
(cherry picked from commit
5dd8185d852afc3843253c9471326677f8816a77)
Günther Deschner [Tue, 5 Jul 2011 12:01:40 +0000 (14:01 +0200)]
s3-printing: make sure to first migrate the printers then the security descriptor.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
cfc3b6e5f79f253e83dfbd13d47b671deb5801b3)
Günther Deschner [Tue, 5 Jul 2011 00:33:23 +0000 (02:33 +0200)]
s3-printing: remove spoolss pipe from migration library, only using winreg finally.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
57bbb32c64db1027e2b9ae1aef7f5f3b33ae3882)
Günther Deschner [Mon, 4 Jul 2011 17:47:07 +0000 (19:47 +0200)]
s3-printing: use winreg interface for migration, instead of spoolss.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
8f3d5f5333a61922c4ea7ff1e1d244978958e857)
Conflicts:
source3/printing/nt_printing_migrate.c
Günther Deschner [Mon, 4 Jul 2011 22:55:35 +0000 (00:55 +0200)]
s3-printing: safe a ton of roundtrips by reusing existing winreg binding_handles.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
72b1f8be5619ed778c4aa0b967f6a4f34d7e9de8)
Conflicts:
source3/rpc_server/spoolss/srv_spoolss_nt.c
Günther Deschner [Mon, 4 Jul 2011 22:16:03 +0000 (00:16 +0200)]
s3-printing: use winreg_internal functions.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
0a1ec73b965f66977a90fb7febb3b56b52ebab20)
Conflicts:
source3/rpc_server/spoolss/srv_spoolss_nt.c
Günther Deschner [Mon, 4 Jul 2011 22:16:47 +0000 (00:16 +0200)]
s3-printing: add winreg_internal functions.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
ada5380d2090179fc57eee66e2b46788f4944db0)
Conflicts:
source3/rpc_server/spoolss/srv_spoolss_nt.c
source3/rpc_server/spoolss/srv_spoolss_util.c
Günther Deschner [Mon, 4 Jul 2011 18:09:54 +0000 (20:09 +0200)]
s3-printing: add winreg_printer_binding_handle and remove most of srv_spoolss_util.c.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
a762eda519c995214c041170e2615c5c51b2a2b1)
Conflicts:
source3/rpc_server/spoolss/srv_spoolss_util.c
Günther Deschner [Mon, 4 Jul 2011 17:47:29 +0000 (19:47 +0200)]
s3-printing: add rpc_client/cli_winreg_spoolss.c
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
f2be8378b92669092f8444df038f769fc9312ff4)
Günther Deschner [Tue, 5 Jul 2011 09:29:37 +0000 (11:29 +0200)]
s3-waf: make LIBCLI_SPOOLSS a shared library
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
a0fc64a88ee6f1f45d4c2b95d6773eccab50ebb4)
Günther Deschner [Tue, 5 Jul 2011 00:15:35 +0000 (02:15 +0200)]
s3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
43cf3a28dc539351da8a316e0e52a8292ec40cc7)
Günther Deschner [Tue, 5 Jul 2011 00:12:24 +0000 (02:12 +0200)]
s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
74e416031b2fc5d9c6af30f692d5b73cb1942cf4)
Günther Deschner [Mon, 4 Jul 2011 23:24:48 +0000 (01:24 +0200)]
s3-printing: move os2 related functions to printing/nt_printing_os2.c.
Guenther
Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit
dd5375b4a1798c856fa9c104baa36c137d664b9d)
Conflicts:
source3/rpc_server/spoolss/srv_spoolss_util.c
Günther Deschner [Fri, 1 Jul 2011 13:39:11 +0000 (15:39 +0200)]
s3-printing: open up a winreg pipe handle for the migration code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jul 4 15:06:41 CEST 2011 on sn-devel-104
(cherry picked from commit
ff94539f276bdef73bd12c67bff1f34e697ccbfc)
Günther Deschner [Fri, 1 Jul 2011 13:02:26 +0000 (15:02 +0200)]
s3-net: use printing_migrate library, and eliminate duplicate code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jul 1 17:57:09 CEST 2011 on sn-devel-104
(cherry picked from commit
bafd7212eb4c82e86874b2f80ddf5c04b2d180b9)
Conflicts:
source3/utils/net_printing.c
Günther Deschner [Fri, 1 Jul 2011 12:57:32 +0000 (14:57 +0200)]
s3-printing: split out printing migration code into a smaller library.
Guenther
(cherry picked from commit
e02abd6c83708f297b1985bb1bdc7d5dfbc924b2)
Conflicts:
source3/printing/nt_printing_migrate.c
source3/wscript_build
David Disseldorp [Wed, 15 Jun 2011 12:59:49 +0000 (14:59 +0200)]
s3-printing: skip migration of non-existent printers
Skip tdb migration of printer and security descriptor entries which
refer to non-existent printers.
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 10:54:23 CEST 2011 on sn-devel-104
(cherry picked from commit
c9e3f6ab02bdc354a9b656f62744ee66fe9e9e67)
David Disseldorp [Wed, 15 Jun 2011 10:46:55 +0000 (12:46 +0200)]
s3-printing: fill devicemode size in migrate_printer()
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
a36ce0735ff6cad8124bd63a056a71d9495b238c)
Günther Deschner [Thu, 12 May 2011 12:33:15 +0000 (14:33 +0200)]
s3-waf: stop building smbtortre4.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 15:35:02 CEST 2011 on sn-devel-104
(cherry picked from commit
c1ac023b588e1ca676cbbf542ca6f93aa199ad32)
Karolin Seeger [Tue, 5 Jul 2011 18:39:53 +0000 (20:39 +0200)]
WHATSNEW: Add changes since rc2.
Karolin
Christian Ambach [Mon, 4 Jul 2011 15:55:54 +0000 (17:55 +0200)]
s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)
when smbd tries to clean up locks after a premature end of a smb2
connection, lock_db has already been freed and so it crashes
this patch changes the order in which items are freed so that
lock_db is still around when it is needed
Stefan Metzmacher [Thu, 30 Jun 2011 08:09:56 +0000 (10:09 +0200)]
s3:nmbd_subnetdb: close all sockets attached to a subnet in close_subnet() (bug #8276)
metze
(cherry picked from commit
75e9f2110876137a57632d223248ac51dbfc4569)
Gregor Beck [Tue, 21 Jun 2011 06:16:56 +0000 (08:16 +0200)]
s3:smbldap: make smbldap_connect_system self contained
The last patches address bug #8253 (winbindd panics if verify_idpool() fails).
Gregor Beck [Tue, 21 Jun 2011 06:06:28 +0000 (08:06 +0200)]
s3:smbldap: add a destructor to smbldap_state, just in case
Gregor Beck [Tue, 21 Jun 2011 06:02:53 +0000 (08:02 +0200)]
s3:smbldap: let smbldap_free_struct do what it claims to
Gregor Beck [Tue, 21 Jun 2011 06:00:59 +0000 (08:00 +0200)]
s3:smbldap: free the idle event scheduled in smbldap_open in smbldap_close
Gregor Beck [Tue, 21 Jun 2011 05:51:41 +0000 (07:51 +0200)]
s3:smbldap: use smbldap_state as memory context for idle event
ensure the event is canceled if the smbldap_state gets freed
this fixes a panic of winbindd if verify_idpool fails
Christian Ambach [Wed, 29 Jun 2011 13:01:16 +0000 (15:01 +0200)]
s3:smbd do not panic when CTDB is unhealthy (Bug #8278)
when CTDB is unhealthy, log a message and exit cleanly
instead of creating a core file
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Jun 30 13:18:12 CEST 2011 on sn-devel-104
(cherry picked from commit
847ca0a5d791d881be8d9a0721bf30399c80013b)
Michael Adam [Thu, 30 Jun 2011 13:15:22 +0000 (15:15 +0200)]
s3:build: add vfs_examples to the everything target
So that one can not pass autobuild without keeping the vfs examples intact.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Jun 30 16:52:48 CEST 2011 on sn-devel-104
The last 5 patches address bug #8281 (examples/VFS/* does not build).
Michael Adam [Thu, 30 Jun 2011 11:54:52 +0000 (13:54 +0200)]
s3:build: add a vfs_examples target.
Björn Baumbach [Wed, 29 Jun 2011 14:57:27 +0000 (16:57 +0200)]
examples/VFS: fix skel_transparent.c in reference to shadow_copy changes
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Wed, 29 Jun 2011 14:56:45 +0000 (16:56 +0200)]
examples/VFS: fix skel_opaque.c in reference to shadow_copy changes
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Wed, 29 Jun 2011 14:53:57 +0000 (16:53 +0200)]
examples/VFS: fix shadow_copy_test.c in reference to shadow_copy changes
Signed-off-by: Michael Adam <obnox@samba.org>
Günther Deschner [Tue, 28 Jun 2011 21:59:11 +0000 (23:59 +0200)]
s3-winbind: Fix bug 7888 -- deal with buggy 3.0 based PDCs
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 00:42:23 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 29 Jun 2011 16:56:47 +0000 (09:56 -0700)]
Second part of fix for bug #8219 - SMB Panic from Windows 7 Client.
Pass in the correct vector to the signing algorithm in an async
response - we must start with vector[1] which has the SMB2_HDR_BODY
length, not vector[0] which is the 4 byte packet length. Also
note we're passing in 2 vectors not 3.
Metze please review.
Jeremy Allison [Wed, 29 Jun 2011 00:45:49 +0000 (17:45 -0700)]
Fix bug #8219 - SMB Panic from Windows 7 Client
Caused by referencing an uninitialized variable in the
duplicated struct smbd_smb2_request when sending a signed
intermediate reply.
Volker Lendecke [Mon, 27 Jun 2011 12:34:39 +0000 (14:34 +0200)]
s3: explicitly pass domain_sid to wbint_LookupRids() (bug #7841)
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jun 27 18:21:30 CEST 2011 on sn-devel-104
(cherry picked from commit
0a74caa473f491050bc5f64b6d6956c00088c5cd)
Stefan Metzmacher [Thu, 16 Jun 2011 10:47:22 +0000 (12:47 +0200)]
s3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()
r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it, even if it's smaller than the offered buffer size.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 14:15:47 CEST 2011 on sn-devel-104
(cherry picked from commit
67512152c007bb186e4fd8dac5d1aab89bce0689)
The last 3 patches address bug #8264 (svcctl valgrind fixes).
Stefan Metzmacher [Thu, 16 Jun 2011 10:34:42 +0000 (12:34 +0200)]
s3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()
r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it.
If we always marshall the return buffer, we already have the needed
buffer size and don't need to call ndr_size_* functions.
metze
(cherry picked from commit
11683ccf3e68606ecb1cdfa455f7921b119803c6)
Stefan Metzmacher [Thu, 16 Jun 2011 06:33:09 +0000 (08:33 +0200)]
s3:rpc_server/svcctl: don't allocate return values on a temporary stackframe
And always initialize the whole return structure.
This caused samba3.posix_s3.rpc.svcctl to be flakey.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104
(cherry picked from commit
48de3e51eacbd1051f79dc99aaac8a4ec988fde5)
Jeremy Allison [Thu, 23 Jun 2011 22:06:16 +0000 (15:06 -0700)]
Fix bug #8254 - "acl check permissions = no" does not work in all cases
Move lp_acl_check_permissions() into can_delete_file_in_directory()
where it makes sense. Remove ACL check when requesting DELETE_ACCESS
when lp_acl_check_permissions is false.
Thanks to John Janosik @ IBM for noticing this.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jun 24 01:18:11 CEST 2011 on sn-devel-104
Michael Adam [Fri, 24 Jun 2011 14:40:17 +0000 (16:40 +0200)]
s3:test: don't rely on pyhton being in /usr/bin/python in the sids2xids test
"/usr/bin/env pyhton" should always work as long as pyhton is in the path.
Michael Adam [Fri, 24 Jun 2011 14:38:07 +0000 (16:38 +0200)]
s3:test: fix the smbclient_s3 test on older systems
mktemp requires precisely six Xs at the end of the template name
Michael Adam [Fri, 24 Jun 2011 14:37:20 +0000 (16:37 +0200)]
s3:test: fix the net registry roundtrip test on older systems
mktemp requires exactly Xs at the end of the template name on SLES8
Andrew Bartlett [Tue, 14 Jun 2011 05:00:32 +0000 (15:00 +1000)]
s3-autconf Move nmbd socket directory to PREFIX/var/nmbd
This is consistent with the new ncalrpc socket directory, also added
in this release.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
The last 2 patches address bug #8230 (Move .nmbd socket directory to non-hidden
name PREFIX/var/nmbd).
Andrew Bartlett [Tue, 14 Jun 2011 04:56:30 +0000 (14:56 +1000)]
s3-buildoptions Show compiled-in location of the new ncaclrpc and nmbd sockets
Michael Adam [Tue, 7 Jun 2011 13:21:34 +0000 (15:21 +0200)]
s3:docs: fix the example in the idmap_autorid manpage to use "idmap config * : rangesize"
Björn Jacke [Fri, 24 Jun 2011 11:37:16 +0000 (13:37 +0200)]
s3:vfs_commit: fix build
fix build
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Fri Jun 24 14:51:31 CEST 2011 on sn-devel-104
(cherry picked from commit
d4ea319e7ad9ee2fc2fad0c016845f820681569a)
Fix bug #8262 (vfs_commit doesn't compile).
Stefan Metzmacher [Fri, 24 Jun 2011 06:54:02 +0000 (08:54 +0200)]
s3:smb2_ioctl/FSCTL_PIPE_TRANSCEIVE: generate STATUS_BUFFER_OVERFLOW if needed (bug #8260)
This should fix DCERPC responses with fragments larger than 1024 bytes.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jun 24 11:25:36 CEST 2011 on sn-devel-104
(cherry picked from commit
2bb325ad913c1cff88faab55102cef75d14c04a6)
Christian Ambach [Fri, 17 Jun 2011 19:54:30 +0000 (21:54 +0200)]
s3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share
the time_audit module uses int instead of uint64 as return value
in get_alloc_size so that sizes of files larger than 2 GB are
cut of leading to wrong replies to NtCreateAndX and Windows
clients giving up
While checking the types of all functions, I found two more wrong
return value types that needed correction
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Jun 17 23:11:10 CEST 2011 on sn-devel-104
(cherry picked from commit
bb66504dadf56366ea30697ae73673de3df08132)
Volker Lendecke [Sun, 19 Jun 2011 17:23:47 +0000 (19:23 +0200)]
s3: Fix Coverity ID 2582: FORWARD_NULL
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 20:46:43 CEST 2011 on sn-devel-104
(cherry picked from commit
5290faca7a5ae5f3f0309a42586768a5c93bfb9d)
Fix bug #8247 (SMB2 shadow copy can be crashed remotely).
Andreas Schneider [Mon, 20 Jun 2011 17:27:01 +0000 (19:27 +0200)]
s3-spoolss: Fix some valgrind warnings.
These are in/out values and need to be initialized.
The last 2 patches address bug #8240 (valgrind warnings in winreg/spoolss
code).
Andreas Schneider [Mon, 20 Jun 2011 13:39:36 +0000 (15:39 +0200)]
s3-rpc_client: Fix some valgrind warnings.
These are in/out values and need to be initialized.
Michael Adam [Thu, 9 Jun 2011 22:50:42 +0000 (00:50 +0200)]
s3:idmap_autorid: remove redundant code
The last 4 patches address bug #8213 (Fixes in idmap_autorid).
Michael Adam [Thu, 9 Jun 2011 22:49:37 +0000 (00:49 +0200)]
s3:idmap_autorid: in initialize, don't leak storedconfig to talloc_tos() in the success case
Michael Adam [Thu, 9 Jun 2011 22:46:19 +0000 (00:46 +0200)]
s3:idmap_autorid: use "idmap config * : rangesize" instead of "autorid : rangesize"
Michael Adam [Tue, 7 Jun 2011 13:53:49 +0000 (15:53 +0200)]
s3:idmap_autorid: fail initialization if the domain is not "*"
autorid can only be used as a backend for the default idmap configuration.
Gregor Beck [Tue, 31 May 2011 16:26:12 +0000 (18:26 +0200)]
s3:net-man: registry enumerate_recursive
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jun 1 17:16:05 CEST 2011 on sn-devel-104
Gregor Beck [Tue, 31 May 2011 16:25:53 +0000 (18:25 +0200)]
s3:net-man: registry deletekey & deletekey_recursive
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 31 May 2011 16:15:38 +0000 (18:15 +0200)]
s3:net-man: missing dot
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Mon, 30 May 2011 14:54:47 +0000 (16:54 +0200)]
s3:net registry: polish output of net registry enumerate[_recursive]
so that net registry enumerate output is as before, and
net registry enumerate_recursive is formatted more nicely
(cherry picked from commit
0d746f653e76de52985d543a15fd6ee3bf2f4823)
Fix bug: #8193
Gregor Beck [Mon, 30 May 2011 08:24:16 +0000 (10:24 +0200)]
s3:net: registry: use recursive implementation for enumerate
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
5ec479fa0c9db4072541d46345164542d037cfc9)
Fix bug: #8193
Gregor Beck [Mon, 30 May 2011 06:58:34 +0000 (08:58 +0200)]
s3:net: registry: add new command enumerate_recursive
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
22011ddc9e72c8a201e3ca6e01745a68738d5916)
Fix bug: #8193
Andrew Bartlett [Tue, 14 Jun 2011 11:51:36 +0000 (21:51 +1000)]
s3: improve WHATSNEW around kerberos changes
Stefan Metzmacher [Thu, 16 Jun 2011 16:25:15 +0000 (18:25 +0200)]
s3:wb_lookupsids: add some paranoia checks to wb_lookupsids_recv()
This hopefully catches future bugs.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 19:50:16 CEST 2011 on sn-devel-104
(cherry picked from commit
5961852d9c0e5cf64cea988586d610af9d63d487)
Stefan Metzmacher [Thu, 16 Jun 2011 16:16:15 +0000 (18:16 +0200)]
s3:wb_lookupsids: don't ignore 'result' and check if we got useable values
The wrong fix for bug #8215 discovered this bug, as it caused
sam_rids_to_names() to always return NT_STATUS_NONE_MAPPED.
metze
(cherry picked from commit
85809ccbe3a79f307af1fdd227f33b899d8db1b4)
Stefan Metzmacher [Thu, 16 Jun 2011 16:40:04 +0000 (18:40 +0200)]
Revert "s3-winbind: Fix paranoia checks in winbindd_samr.c."
This reverts commit
207a84d725b905c2b119d2ef0f4f4d4eb391140d.
This is the wrong fix for the problem, see bug #8215.
metze
(cherry picked from commit
283f8a7fb5089a7126f07e26315fd06ab59997d8)
Stefan Metzmacher [Wed, 15 Jun 2011 00:34:53 +0000 (02:34 +0200)]
s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226)
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jun 15 03:48:41 CEST 2011 on sn-devel-104
(cherry picked from commit
5d736d87778754de7043d902c7d1d5db1c46cb02)
Stefan Metzmacher [Wed, 8 Jun 2011 17:01:13 +0000 (19:01 +0200)]
s3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit
This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.
metze
(cherry picked from commit
f0ba1afe5f7dbafaf22c3028864de0f3910f675f)
The last 14 patches address the generic part of bug #8195
(rpc client code doesn't work against NT4, when we need to fragment requests).
Stefan Metzmacher [Wed, 8 Jun 2011 16:59:39 +0000 (18:59 +0200)]
s3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit
This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.
metze
(cherry picked from commit
73128b7cc7f536f80072a19cb69527c53d9a6c2f)
Stefan Metzmacher [Thu, 9 Jun 2011 09:57:55 +0000 (11:57 +0200)]
s3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests
This is needed to implement SMB signing correct.
metze
(cherry picked from commit
5d06b2197b5fd95aaf0394d1bdba957bac6c3570)
Stefan Metzmacher [Wed, 8 Jun 2011 08:31:23 +0000 (10:31 +0200)]
s3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls
We now keep the primary request open for the whole logical request.
The primary request is the one that gets all incoming replies.
While secondary requests are handled as separate one-way requests.
metze
(cherry picked from commit
1dd24ac06a7472f53b06bc0aaa54cb22c8da0f78)
Stefan Metzmacher [Wed, 8 Jun 2011 14:41:11 +0000 (16:41 +0200)]
s3:libsmb/clitrans: use subreq2 as variable for the secondary requests
metze
(cherry picked from commit
10bb088cf1e005fd047c09afcf6b5b8999d416fe)
Stefan Metzmacher [Wed, 8 Jun 2011 14:11:00 +0000 (16:11 +0200)]
s3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment
metze
(cherry picked from commit
5146c9ba9df063d6611abe356f9262adb027b091)
Stefan Metzmacher [Tue, 7 Jun 2011 22:44:34 +0000 (00:44 +0200)]
s3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests
We need to align params and data to 4 byte offsets.
This also correctly recalculates the useable space after each step.
metze
(cherry picked from commit
0a8fd50bd806e925a915c74cb86733481b2144f6)
Stefan Metzmacher [Thu, 9 Jun 2011 10:22:59 +0000 (12:22 +0200)]
s3:libsmb/clitrans: marshall SMBnttrans[2] as the others
This is just to make the code more readable
and easier to notice how many words we're using in vwv.
metze
(cherry picked from commit
6f7af1b0388d30c8a06c495713066b90ded00780)