Björn Jacke [Wed, 26 May 2010 15:18:59 +0000 (17:18 +0200)]
s3:Makefile: fix a typo in flag variable name
Günther Deschner [Wed, 26 May 2010 13:14:20 +0000 (15:14 +0200)]
s3-printing: fix buildwarning in publishing code after registry changes.
Guenther
Simo Sorce [Wed, 28 Apr 2010 14:23:48 +0000 (10:23 -0400)]
s3-lanman: Migrated to rpc_connect_spoolss_pipe().
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 28 Apr 2010 13:51:12 +0000 (09:51 -0400)]
s3-rpc_server: Created a per connection spoolss pipe.
This way all code can reuse the same connection to spoolss
and not have to deal with the creation of a new pipe all over the
code every time we need to ask a service off spoolss.
Signed-off-by: Günther Deschner <gd@samba.org>
Kai Blin [Wed, 26 May 2010 12:09:39 +0000 (14:09 +0200)]
s3-waf: Build smbclient binary
Kai Blin [Wed, 26 May 2010 12:09:06 +0000 (14:09 +0200)]
s3-waf: Fix the naming of some variables introduced recently
Kamen Mazdrashki [Wed, 26 May 2010 01:22:34 +0000 (04:22 +0300)]
s4/test: Connect SAMR and LDARPC pipes before calling libnet_ functions
In multi-DC environment, NBT name resolution may resolv
domain name to any of DCs.
This make this test to fail, as we are modifying the user account
on one DC and query user info immediately after that on another DC.
Kamen Mazdrashki [Wed, 26 May 2010 10:32:13 +0000 (13:32 +0300)]
s4/test: remove unused code
There is no need anymore to modify samAccountName
of the testing user to original value as test_cleanup()
will spot the right samAccountName to delete
Kamen Mazdrashki [Wed, 26 May 2010 10:27:07 +0000 (13:27 +0300)]
s4/test: make test_cleanup() in libnet_user library more robust
test_cleanup() is called always with RDN name of the user to be deleted.
When modify-user test fails however, we end up with a user
with RDN = libnetusertest and samAccountName = random_name.
This way we can not delete the user and the error message is
quite misleading (I've spent a *lot* of time trying to figure out
if the database is corrupted because of this error).
Kamen Mazdrashki [Tue, 25 May 2010 14:24:45 +0000 (17:24 +0300)]
s4/test: rename enum test_fields{} member names to be more descriptive
Kamen Mazdrashki [Sat, 22 May 2010 02:03:16 +0000 (05:03 +0300)]
s4/test: Replace hand-made field count to test
This patch replaces hand-make count of fields to be tested
with defines for FIRST-LAST value for corresponding fields
to test with.
As a side-effect, 'acct_flags' is now included in tests.
Björn Jacke [Wed, 26 May 2010 08:18:03 +0000 (10:18 +0200)]
s3:configure: use the right AC_CACHE_CHECK variable
Simo Sorce [Fri, 21 May 2010 16:29:22 +0000 (12:29 -0400)]
s4:smbd: Use tstream_npa_accept_existing to accept named pipe connections
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Simo Sorce [Fri, 21 May 2010 14:34:58 +0000 (10:34 -0400)]
s4:smbd: Add tstream to the stream_connection structure
Simo Sorce [Wed, 19 May 2010 21:02:52 +0000 (17:02 -0400)]
named_pipe_auth: implement tstream_npa_accept_existing_send/recv
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Kai Blin [Tue, 25 May 2010 22:16:10 +0000 (00:16 +0200)]
s3-waf: Check for additional options on *xattr
Kai Blin [Tue, 25 May 2010 21:57:41 +0000 (23:57 +0200)]
s3-waf: Add darwin to the host_os-specific checks
Kai Blin [Tue, 25 May 2010 21:53:04 +0000 (23:53 +0200)]
s3-waf: Don't hardcode the name of the awk executable in wscript_build
Jeremy Allison [Tue, 25 May 2010 18:39:46 +0000 (11:39 -0700)]
Standardize debug messages for read and write.
Jeremy.
Michael Adam [Tue, 25 May 2010 15:28:05 +0000 (17:28 +0200)]
s3:fix the waf build after registry changes.
Günther Deschner [Tue, 25 May 2010 10:43:00 +0000 (12:43 +0200)]
s3-net: fix a "dereferencing type-punned pointer will break strict-aliasing rules" warning.
Guenther
Günther Deschner [Tue, 25 May 2010 10:27:02 +0000 (12:27 +0200)]
s3-waf: very simple start on getting krb5 build to work.
Guenther
Matthias Dieter Wallnöfer [Tue, 25 May 2010 09:21:46 +0000 (11:21 +0200)]
s4:torture/rpc/samr.c: Fix the "ValidatePassword" test
It was failing randomly due to an uninitialised "status" variable.
Michael Adam [Tue, 25 May 2010 08:53:17 +0000 (10:53 +0200)]
s3:registry: add C for substantial changes to reg_objects
Michael Adam [Tue, 25 May 2010 08:32:51 +0000 (10:32 +0200)]
s3:registry:reg_objects: Remove use of uint{8,16,32} in favour of C99 types
Michael Adam [Tue, 25 May 2010 06:54:29 +0000 (08:54 +0200)]
s3:registry: add comment header block to registry.h
Michael Adam [Mon, 24 May 2010 23:00:37 +0000 (01:00 +0200)]
s3:registry: move reg_objects.h to registry/ and use it only where needed
Every place outside of registry/ where this is used, should probably
be changed to use pure reg_api.c code.
Michael Adam [Mon, 24 May 2010 22:42:50 +0000 (00:42 +0200)]
s3:registry: move non-reg_objects definitions from reg_objects.h to registry.h
Michael Adam [Sun, 23 May 2010 22:05:26 +0000 (00:05 +0200)]
s3:registry: hide definition of regval_ctr and regval_blob in reg_objects.c
Michael Adam [Mon, 24 May 2010 13:10:48 +0000 (15:10 +0200)]
s3:net rpc registry: use regval_ctr_init() instead of direct allocation
Michael Adam [Mon, 24 May 2010 13:08:58 +0000 (15:08 +0200)]
s3:profiles: use regval_ctr_init() instead of direct allocation
Michael Adam [Mon, 24 May 2010 13:07:47 +0000 (15:07 +0200)]
s3:rpcclient:spoolss: use regval_ctr/blob accessor functions.
Michael Adam [Mon, 24 May 2010 12:48:31 +0000 (14:48 +0200)]
s3:net_rpc_printer: use regval_blob/ctr accessor functions
Michael Adam [Mon, 24 May 2010 12:18:21 +0000 (14:18 +0200)]
s3:net rpc printer: fix use of a possibly uninitialized variable
Michael Adam [Mon, 24 May 2010 12:08:01 +0000 (14:08 +0200)]
s3:nt_printing: use regval_ctr_init().
Michael Adam [Mon, 24 May 2010 12:06:20 +0000 (14:06 +0200)]
s3:srv_ntsvcs: use regval_ctr/blob accessor functions
Michael Adam [Mon, 24 May 2010 12:03:46 +0000 (14:03 +0200)]
s3:services_db: use regval_ctr_init() instead of direct allocation
Michael Adam [Mon, 24 May 2010 11:57:35 +0000 (13:57 +0200)]
s3:libads:use regval_ctr/blob accessor functions in ldap_printer.c
Michael Adam [Sun, 23 May 2010 21:59:34 +0000 (23:59 +0200)]
s3:registry: use regval_ctr/blob accessor functoin in reg_eventlog.c
Michael Adam [Sun, 23 May 2010 21:58:28 +0000 (23:58 +0200)]
s3:registry: user regval_ctr/blob accessor functions in reg_backend_db.c
Michael Adam [Sun, 23 May 2010 21:56:40 +0000 (23:56 +0200)]
s3:registry: use regval_ctr/blob accessor functions in reg_api.c
Michael Adam [Sun, 23 May 2010 20:55:12 +0000 (22:55 +0200)]
s3:registry:reg_objects: add regval_ctr_set_seqnum()
Michael Adam [Sun, 23 May 2010 20:53:44 +0000 (22:53 +0200)]
s3:registry:reg_objects: add regval_ctr_get_seqnum()
Michael Adam [Sun, 23 May 2010 20:47:53 +0000 (22:47 +0200)]
s3:registry:reg_objects: add regval_ctr_init()
Michael Adam [Mon, 24 May 2010 22:31:01 +0000 (00:31 +0200)]
s3:registry: move definition of registry_hook to reg_init_full.c - it's only user
Michael Adam [Mon, 24 May 2010 22:15:52 +0000 (00:15 +0200)]
s3:registry: extract registry_pull/push_value prototypes into own header
reg_util_marshalling.h and use them only where needed.
Michael Adam [Mon, 24 May 2010 22:08:15 +0000 (00:08 +0200)]
s3:registry: rename lib/util_reg_api.c to registry/reg_util_marshalling.c
Michael Adam [Mon, 24 May 2010 22:04:13 +0000 (00:04 +0200)]
s3:registry: rename reg_util.{c,h} to reg_util_internal.{c,h}
Michael Adam [Mon, 24 May 2010 21:37:09 +0000 (23:37 +0200)]
s3:registry: move prototype registry_create_admin_token() to new header reg_util_token.h
and use it only where necessary.
Michael Adam [Mon, 24 May 2010 21:27:57 +0000 (23:27 +0200)]
s3:registry: move registry_create_admin_token() to new reg_util_token.c
Michael Adam [Mon, 24 May 2010 21:06:27 +0000 (23:06 +0200)]
s3:registry: extract reg_eventlog prototypes to header of their own
and use them only where needed.
Michael Adam [Mon, 24 May 2010 20:59:04 +0000 (22:59 +0200)]
s3:registry: extract reg_perfcount prototypes into header of their own.
And use them only when necessary.
Michael Adam [Mon, 24 May 2010 20:49:42 +0000 (22:49 +0200)]
s3:registry: extraxt the reg_dispatcher prototypes into their own header.
And use them only where needed.
Michael Adam [Mon, 24 May 2010 20:42:00 +0000 (22:42 +0200)]
s3:registry: extract the reg_backend_db prototypes into their own header.
And use them only where needed.
Michael Adam [Mon, 24 May 2010 20:19:17 +0000 (22:19 +0200)]
s3:registry: adapt callers of regval_ctr_addvalue to uint8 * instead of char *
Michael Adam [Mon, 24 May 2010 13:15:33 +0000 (15:15 +0200)]
s3:registry: fix regval_ctr_addvalue() to take data as uint8 *, not char *.
Michael Adam [Mon, 24 May 2010 13:00:29 +0000 (15:00 +0200)]
s3:registry: fix data_p arg of regval_compose to be uint8 * instead of char *
Michael Adam [Sun, 23 May 2010 14:11:13 +0000 (16:11 +0200)]
s3:registry: extract the reg_util prototypes into their own header.
And use them only where needed.
Michael Adam [Sun, 23 May 2010 14:00:35 +0000 (16:00 +0200)]
s3:registry: remove superfluous comments from registry.h
Michael Adam [Sun, 23 May 2010 13:57:27 +0000 (15:57 +0200)]
s3:registry: extract the reg_util_legacy prototypes into their own header.
And use them only where necessary.
Michael Adam [Sun, 23 May 2010 13:25:00 +0000 (15:25 +0200)]
s3:registry: extract the reg_cachehook prototypes into their own header.
And use them only where necessary.
Michael Adam [Sun, 23 May 2010 11:32:08 +0000 (13:32 +0200)]
s3:registry: protect registry.h from multiple inclusion
Michael Adam [Sun, 23 May 2010 11:28:05 +0000 (13:28 +0200)]
s3:registry: add C to reg_cachehook, confessing considerable changes in 2008
Michael Adam [Tue, 25 May 2010 07:49:04 +0000 (09:49 +0200)]
s3:fix configure after change "add Werror_FLAGS for IBM's xlc"
For me,
24b3725407f1a67e13a7646d2e3f26ed1e4735ff broke configure.
The fix in
f634450b67d2a084c41a63c0e94eb47adb90e101 is not complete yet.
After staring at the change a bit, tt seems to me that the
code inserted was just misplaced by one line.
Michael
Björn Jacke [Tue, 25 May 2010 07:43:57 +0000 (09:43 +0200)]
s3: fix the configure run
Björn Jacke [Mon, 24 May 2010 21:34:00 +0000 (23:34 +0200)]
s3:configure: turn "error warnings" into errors
By default "Missing argument(s)" is just an "error warning" for xlc :-)
The change to turn "error warnings" into errors should fix bug #7427.
Björn Jacke [Mon, 24 May 2010 21:28:44 +0000 (23:28 +0200)]
s3:configure: add Werror_FLAGS for IBM's xlc
Matthias Dieter Wallnöfer [Mon, 24 May 2010 20:01:36 +0000 (22:01 +0200)]
s4:dsdb_enum_group_mem - use "unsigned" counters
"size_t" counters aren't really needed here (we don't check data lengths).
And we save the result in a certain "num_sids" variable which is of type
"unsigned".
Matthias Dieter Wallnöfer [Mon, 24 May 2010 20:00:54 +0000 (22:00 +0200)]
s4:dsdb_lookup_rids - "unsigned" counters fit better than "signed" in this case
Matthias Dieter Wallnöfer [Mon, 24 May 2010 19:53:34 +0000 (21:53 +0200)]
s4:dsdb_add_user - check the "cn"/"account_name" length (should be >= 1)
This needed by the "cn_name_len"-1 accesses.
And use a "size_t"-typed variable for storing it (length specificators should
always be stored using "size_t" variables).
Jeremy Allison [Mon, 24 May 2010 18:03:42 +0000 (11:03 -0700)]
Add in support for the NTLMSSP version reply.
Jeremy.
Volker Lendecke [Sun, 23 May 2010 13:39:29 +0000 (15:39 +0200)]
fix a typo
Jelmer Vernooij [Mon, 24 May 2010 15:25:34 +0000 (17:25 +0200)]
ldb-waf: Install manual pages for ldb in standalone build, install
python module.
Andrew Bartlett [Mon, 24 May 2010 05:03:17 +0000 (15:03 +1000)]
s4:winbind Give more detail on the parameters when reporting idmap failure
Andrew Bartlett [Mon, 24 May 2010 04:58:07 +0000 (14:58 +1000)]
s4:winbind Change idmap API to match that used by the source3/ idmap subsystem
This makes it much easier to write an idmap module that bridges the gap.
We should finish the change to the new API, but for the moment this
choke point works for the conversion.
Andrew Bartlett
Andrew Bartlett [Mon, 24 May 2010 01:21:29 +0000 (11:21 +1000)]
s4:winbind Change include guard so as not to conflict with idmap.h in source3
Andrew Bartlett [Mon, 24 May 2010 00:52:18 +0000 (10:52 +1000)]
s4:winbind Fix up includes after seperation of idmap.idl from winbind.idl
Andrew Bartlett [Mon, 24 May 2010 00:16:34 +0000 (10:16 +1000)]
s4:idmap Adjust code to new idmap structure names and layout.
Andrew Bartlett
Andrew Bartlett [Mon, 24 May 2010 00:15:04 +0000 (10:15 +1000)]
s4:idmap Seperate idmap structures from winbind.idl and match to source3/ idmap
These structures now match those in use in the source3 code. I'm not
sure if this is the better API or not, but it is far, far safer to
remove a pointer than to add one.
Andrew Bartlett
Andrew Bartlett [Sun, 23 May 2010 14:57:32 +0000 (00:57 +1000)]
s4:samr Push most of samr_LookupRids into a helper function
This is a rewrite of the lookup_rids code, using a query based on the
extended DN for a clearer interface.
By splitting this out, the logic is able to be shared, rather than
copied, into a passdb wrapper.
Andrew Bartlett
Andrew Bartlett [Thu, 20 May 2010 22:42:21 +0000 (08:42 +1000)]
s4:samr Push most of samr_QueryGroupMember into a helper function
This is a rewrite of the group membership lookup code, using the
stored extended DNs to avoid doing the lookup into each member to find
the SID
By splitting this out, the logic is able to be shared, rather than
copied, into a passdb wrapper.
Andrew Bartlett
Andrew Bartlett [Thu, 20 May 2010 22:21:37 +0000 (08:21 +1000)]
s4:samr Move most of samr_CreateDomAlias into a helper function
This allows this logic to be shared, rather than copied, into a passdb
wrapper.
Andrew Bartlett
Andrew Bartlett [Thu, 20 May 2010 22:17:44 +0000 (08:17 +1000)]
s4:samr Split most of samr_CreateDomainGroup into a helper function
This allows this logic to be shared, rather than copied, into a passdb
wrapper.
Andrew Bartlett
Andrew Bartlett [Thu, 20 May 2010 22:14:53 +0000 (08:14 +1000)]
s4:samr Split the guts of samr_CreateUser2 into a helper function
This allows this logic to be shared, rather than copied, into a passdb
wrapper.
Andrew Bartlett
Andrew Bartlett [Thu, 20 May 2010 22:11:13 +0000 (08:11 +1000)]
s4:dsdb Allow a NULL search expression in dsdb_search()
The NULL search expression expands to (objectClass=*), but %s expands
NULL to (NULL) which doesn't parse...
Andrew Bartlett
Andrew Bartlett [Tue, 18 May 2010 10:34:20 +0000 (20:34 +1000)]
s4:ntvfs rename notify.idl to s4_notify.idl until we can merge this IDL
This IDL is almost common, but the source3 version has a
hand-marshalled server_id. The s3compat build has problems with two
different idl files of the same name.
Andrew Bartlett
Matthias Dieter Wallnöfer [Mon, 24 May 2010 10:42:32 +0000 (12:42 +0200)]
s4:LogonGetDomainInfo - allow to set DNS hostname for the first time
Otherwise it obviously can never be set.
Matthias Dieter Wallnöfer [Mon, 24 May 2010 09:06:29 +0000 (11:06 +0200)]
s4:"rdn_name" LDB module - fix the creation of the RDN attribute (try to normalise it)
And return always the correct error codes on the failed add operations (should
anyway be ERR_OPERATIONS_ERROR - therefore no behaviour change).
Matthias Dieter Wallnöfer [Mon, 24 May 2010 08:38:16 +0000 (10:38 +0200)]
s4:setup/*.ldif - remove unneeded "cn" attributes
Should be generated automatically
Björn Jacke [Wed, 12 May 2010 16:17:30 +0000 (18:17 +0200)]
s3: major overhaul of compiler and linker flags for HP-UX builds
this will fix a number of things like shared library builds. That in turn will
probably trigger some other build bugs...
Björn Jacke [Mon, 24 May 2010 11:41:12 +0000 (13:41 +0200)]
s3:Makefile: set PIE flags also for nss_winbind
Björn Jacke [Wed, 12 May 2010 17:05:37 +0000 (19:05 +0200)]
s3:build: remove CFLAGS from LDSHFLAGS, SHLD has them already
Björn Jacke [Mon, 24 May 2010 10:21:40 +0000 (12:21 +0200)]
s3:Makefile: position independency is also needed for shared libs
Björn Jacke [Sat, 22 May 2010 14:48:16 +0000 (16:48 +0200)]
s3:build: don't use pieflags twice - ldflags already have them
Volker Lendecke [Mon, 24 May 2010 09:23:42 +0000 (11:23 +0200)]
s3: Fix a typo found by ITPFS oota <t-oota@dh.jp.nec.com>
Thanks!
Thomas Nagy [Sun, 23 May 2010 19:31:53 +0000 (21:31 +0200)]
solve the error "ldb.inst.h does not exist"
The error happens when headermap.txt is not available
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Tridgell [Sun, 23 May 2010 15:55:48 +0000 (17:55 +0200)]
build: get the SONAME right for installed libraries
Thomas Nagy [Sat, 22 May 2010 12:35:50 +0000 (14:35 +0200)]
Substitute the pidl files without using 'headermap.txt'
The headers generated by pidl contain references to bin/default. Those paths
may be replaced automatically.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Volker Lendecke [Sun, 23 May 2010 09:44:30 +0000 (11:44 +0200)]
s3: Another non-gnumake fix
AC_OUTPUT_COMMANDS must be called before AC_OUTPUT and
$MAKEFILE is not defined in ./config.status
Volker Lendecke [Sat, 22 May 2010 22:16:52 +0000 (00:16 +0200)]
s3: Factor out compiler-independent defines