samba.git
15 years agoFix SAMR server for winbindd access. Ensure we allow
Jeremy Allison [Mon, 18 May 2009 21:26:37 +0000 (14:26 -0700)]
Fix SAMR server for winbindd access. Ensure we allow
MAX_ACCESS to be mapped to what we're giving Everyone.
Jeremy.
(cherry picked from commit cb49ceb25d8be05148e3081a73f8db10915963f0)

15 years agos3-samr: Fix samr access checks in _samr_SetUserInfo().
Guenther Deschner [Sat, 16 May 2009 01:11:30 +0000 (18:11 -0700)]
s3-samr: Fix samr access checks in _samr_SetUserInfo().

Guenther
(cherry picked from commit c79ceb3345c56cff28b5e828188611c5fc80b1a7)

15 years agos3-samr: Fix samr access checks in _samr_QueryUserInfo().
Guenther Deschner [Sat, 16 May 2009 01:03:34 +0000 (18:03 -0700)]
s3-samr: Fix samr access checks in _samr_QueryUserInfo().

Guenther
(cherry picked from commit 5c3c7f6921c9cff58cf4f85c0b691566bf4cd02e)

15 years agoEnsure users with SeAddUser privs get full access to
Jeremy Allison [Sat, 16 May 2009 00:55:41 +0000 (17:55 -0700)]
Ensure users with SeAddUser privs get full access to
groups/aliases when opening.
Jeremy.
(cherry picked from commit 72f90581a78443efd6cf24bac635fe9032df18fd)

15 years agoAdd extra abilities for a user with SeAddUsers, so they
Jeremy Allison [Sat, 16 May 2009 00:54:27 +0000 (17:54 -0700)]
Add extra abilities for a user with SeAddUsers, so they
can manipulate groups and aliases.
Jeremy.
(cherry picked from commit 361caafeebb37f6247f7ede38a50a70323fdd107)

15 years agoDeleteUser doesn't need the priv checks, this is done at OpenUser time.
Jeremy Allison [Sat, 16 May 2009 00:52:40 +0000 (17:52 -0700)]
DeleteUser doesn't need the priv checks, this is done at OpenUser time.
Jeremy.
(cherry picked from commit c0ff7e5459bdf1351f6cb69e58a1f8105bcfd3dc)

15 years agos3-samr: Fix samr access checks in _samr_RemoveMemberFromForeignDomain().
Guenther Deschner [Sat, 16 May 2009 00:50:49 +0000 (17:50 -0700)]
s3-samr: Fix samr access checks in _samr_RemoveMemberFromForeignDomain().

Guenther
(cherry picked from commit 6d0981845ec005a48a82280e2ebfe85ac9b72537)

15 years agos3-samr: Fix samr access checks in _samr_SetDomainInfo().
Guenther Deschner [Sat, 16 May 2009 00:49:02 +0000 (17:49 -0700)]
s3-samr: Fix samr access checks in _samr_SetDomainInfo().

Guenther
(cherry picked from commit c7e6db566ad2bd5ea6473753a720a9ccc9772b59)

15 years agos3-samr: Fix samr access checks in _samr_QueryDomainInfo().
Guenther Deschner [Sat, 16 May 2009 00:47:16 +0000 (17:47 -0700)]
s3-samr: Fix samr access checks in _samr_QueryDomainInfo().

Guenther
(cherry picked from commit 42ad75c9d31f6101103870e1055a7cd4b7f149fd)

15 years agoFix the core of the SAMR access functions. This passes make test, but
Jeremy Allison [Sat, 16 May 2009 00:43:41 +0000 (17:43 -0700)]
Fix the core of the SAMR access functions. This passes make test, but
usrmgr fails against it. The core of this patch is to move all the
access mask setup into the _samr_OpenXXX functions, and then have
each specific function check the attached access_mask against the
required bits. We can then go through the MS-SAMR doc and match
things up. Signed off by Guenther, and writespace cleanup removal
by Volker.
Jeremy.
(cherry picked from commit bdc797135151d4f85e6368d016bfb26389c6f055)

15 years agos3-netdomjoin-gui: allow to switch between workgroups/domains with the same name.
Günther Deschner [Fri, 15 May 2009 17:43:19 +0000 (19:43 +0200)]
s3-netdomjoin-gui: allow to switch between workgroups/domains with the same name.

Guenther
(cherry picked from commit d800ee50335ecbd2dbd3b451a18a00780ac28f04)
(cherry picked from commit 9db1fc45786872d938939bd33b3b867ee599c9a2)

15 years agos3-netdomjoin-gui: cosmetic fix for empty hostnames.
Günther Deschner [Fri, 15 May 2009 17:42:05 +0000 (19:42 +0200)]
s3-netdomjoin-gui: cosmetic fix for empty hostnames.

Guenther
(cherry picked from commit 8c74d31962eb82f7dcc07000aeb27a84a633a225)
(cherry picked from commit c03287c2f8d03363a26b0518b6370ddfaa7b5915)

15 years agos3-netdomjoin-gui: only gray out labels when not root and not connecting to
Günther Deschner [Fri, 15 May 2009 15:06:54 +0000 (17:06 +0200)]
s3-netdomjoin-gui: only gray out labels when not root and not connecting to
remote machines.

Guenther
(cherry picked from commit 473bf41d20b25bd7d98ea6647e6295b3fb6f34e1)
(cherry picked from commit 7115126d0f7d97c3633b62e76e2fdc681dedb36d)

15 years agoFix bug 5681: Do not limit the number of network interfaces
Volker Lendecke [Mon, 18 May 2009 08:32:27 +0000 (10:32 +0200)]
Fix bug 5681: Do not limit the number of network interfaces

Jeremy as far as I can see there is no real technical reason to limit the
number of interfaces. If you like this patch, can you please merge it to 3.4?
If you don't please tell me :-)

Thanks,

Volker
(cherry picked from commit 71e835942522992c08267da74d480ad6552c6508)

15 years agoMove down the become_root()/unbecome_root() calls into the VFS modules
Volker Lendecke [Mon, 18 May 2009 11:30:16 +0000 (13:30 +0200)]
Move down the become_root()/unbecome_root() calls into the VFS modules

The aio_fork module does not need this, as it does not communicate via signals
but with pipes. Watching a strace log with those become_root() calls in aio.c
is absolutely awful, and it does affect performance.
(cherry picked from commit b8d12d3ffce304b4086488d999f85d80667e196e)

15 years agoIn aio_fork, we have to close all fd's, we might hold a gpfs share mode
Volker Lendecke [Mon, 18 May 2009 07:49:23 +0000 (09:49 +0200)]
In aio_fork, we have to close all fd's, we might hold a gpfs share mode

Keeping such an fd open prohibits another open of that same file.
(cherry picked from commit f22343874833397afb2010a43ee0057fa5d8471e)

15 years agoAdd "file_walk_table" to do stuff with all open files
Volker Lendecke [Mon, 18 May 2009 07:46:05 +0000 (09:46 +0200)]
Add "file_walk_table" to do stuff with all open files
(cherry picked from commit 413a76cef78de56087574a875a1c478603d5d090)

15 years agoFix a race condition in vfs_aio_fork with gpfs share modes
Volker Lendecke [Mon, 18 May 2009 07:36:16 +0000 (09:36 +0200)]
Fix a race condition in vfs_aio_fork with gpfs share modes
(cherry picked from commit f64959ee16214b224225d5b43dfb822ecd772d99)

15 years agos3:fix bug #6371, unsuccessful net conf setparm leaves empty share
Michael Adam [Sun, 17 May 2009 20:15:02 +0000 (22:15 +0200)]
s3:fix bug #6371, unsuccessful net conf setparm leaves empty share

Wrap creation of share and setting of parameter into a transaction.

Michael
(cherry picked from commit 2722dd357cedcd3fad1e3739a4a64f924d53eccb)
(cherry picked from commit 7d791d813e9ca9cb1733d312dc040737b67f4bf4)

15 years agoOops. Forgot to delete now unused local from the previous patch.
Jeremy Allison [Fri, 15 May 2009 23:16:47 +0000 (16:16 -0700)]
Oops. Forgot to delete now unused local from the previous patch.
Jeremy.
(cherry picked from commit 85719213666c1a863f95a9762c1b9c5feea3c440)

15 years agoFix bug #6359 - smbclient -L does not list workgroup for hosts with both IPv4 and...
Ole Hansen [Fri, 15 May 2009 23:13:59 +0000 (16:13 -0700)]
Fix bug #6359 - smbclient -L does not list workgroup for hosts with both IPv4 and IPv6 addresses
(cherry picked from commit fb0f49ce0d10a8c84730156f3f04fe48ee65e8e7)

15 years agos3:build: fix linking with --disable-shared-libs
Michael Adam [Fri, 15 May 2009 21:35:55 +0000 (23:35 +0200)]
s3:build: fix linking with --disable-shared-libs

Michael
(cherry picked from commit f5c96e54c633717ffe1a967f4ab9fdede31fa749)
(cherry picked from commit 74f805fbb654b58372b0c86f3314abfd9c76dbbe)

15 years agoFix bug 6361: Make --rcfile work in smbget
Volker Lendecke [Fri, 15 May 2009 19:02:08 +0000 (21:02 +0200)]
Fix bug 6361: Make --rcfile work in smbget

Thanks to j scott <gl@arlut.utexas.edu> for reporting!
(cherry picked from commit 65e81e93122014a528a096cea9158cf2aceb0bbb)

15 years agos3:swat: hide "config backend" from swat
Michael Adam [Fri, 15 May 2009 16:00:59 +0000 (18:00 +0200)]
s3:swat: hide "config backend" from swat

Michael
(cherry picked from commit c085c8311dfadcb05594714149632e9523a27c14)
(cherry picked from commit ab107e8bb85131d5a7430b7fe58904b488240279)

15 years agos3:param: prevent includes from being dumped in dump_*() functions.
Michael Adam [Thu, 14 May 2009 23:46:09 +0000 (01:46 +0200)]
s3:param: prevent includes from being dumped in dump_*() functions.

This fixes bug #4271: testparm should not print includes.

Michael
(cherry picked from commit 00297b74ac6320a23ba444647718680ddee37453)
(cherry picked from commit 44746461dcead5b42cc2177346c26aee79151c86)

15 years agos3:build: add install-dbwrap_tool target
Michael Adam [Fri, 15 May 2009 13:41:41 +0000 (15:41 +0200)]
s3:build: add install-dbwrap_tool target

Michael
(cherry picked from commit a62e72b825117dc45d434fd1b3645633b5d063d6)
(cherry picked from commit 85e38ebde54fb403dcdcb9da39880c7d776034c6)

15 years agos3:build dbwrap_tool with make everything
Michael Adam [Fri, 15 May 2009 13:41:26 +0000 (15:41 +0200)]
s3:build dbwrap_tool with make everything

Michael
(cherry picked from commit b4131ecf811e6f42ebec4154a911a3dfa8416a56)
(cherry picked from commit bf0c69834671a6dd6a43a89d6a8abd98f6afaf5f)

15 years agos3:build: rename OBJ collection for dbwrap_tool consistently
Michael Adam [Fri, 15 May 2009 09:58:17 +0000 (11:58 +0200)]
s3:build: rename OBJ collection for dbwrap_tool consistently

Michael
(cherry picked from commit ad240e199893a5e89cdd5161134171cc600266b8)
(cherry picked from commit c118d03a2b15b75a5025158956a8d8f99682d55c)

15 years agos3:first cut at dbwrap_tool - a tdb tool that is CTDB-aware.
Michael Adam [Thu, 14 May 2009 23:48:55 +0000 (01:48 +0200)]
s3:first cut at dbwrap_tool - a tdb tool that is CTDB-aware.

This tool (in contrast to tdbtool) reads Samba's configuration
and if clustering = yes, it talks to CTDB instead of accessing
the TDB data bases directly. This is done by simply using
the dbwrap mechanim, just like the Samba daemons.

This first version can read and write int32 and uint32 values
and delete records from a (c)tdb database.
More operations will follow.

This tool can already be useful in CTDB environments, e.g. when
"net idmap restore" fails to set the USER and GROUP HWM keys,
because the methods are deliberately not implemented in
idmap_tdb2.c. You can manually set the high water marks
with
"dbwrap_tool store idmap_tdb2.tdb 'USER HWM' int32 12345"
and
"dbwrap_tool store idmap_tdb2.tdb 'GROUP HWM' int32 67890"

Michael
(cherry picked from commit 6d82b5975598f1742c53ebdaa2fa89f7cf148b85)
(cherry picked from commit 5085c853e87cc5875b1a38e6558a5412a69e1d08)

15 years agos3-samr: in _samr_QueryUserInfo() make sure to not return any info in error case.
Günther Deschner [Fri, 15 May 2009 12:34:50 +0000 (14:34 +0200)]
s3-samr: in _samr_QueryUserInfo() make sure to not return any info in error case.

Guenther
(cherry picked from commit 59192bf03f3781fe6a21be66a7374ea72cac71f4)
(cherry picked from commit b5b5718552f44ac4fc961c38eb3a8ff02eab18f9)

15 years agos3-samr: use normal integer in r->in.level switch statements.
Günther Deschner [Thu, 14 May 2009 22:31:16 +0000 (00:31 +0200)]
s3-samr: use normal integer in r->in.level switch statements.

Guenther
(cherry picked from commit 51271ab739e5a239faf2367cc0e25e34a9cd9170)

15 years agos3-netapi: implement NetShutdownInit_r and NetShutdownAbort_r.
Günther Deschner [Wed, 13 May 2009 14:38:26 +0000 (16:38 +0200)]
s3-netapi: implement NetShutdownInit_r and NetShutdownAbort_r.

Guenther
(cherry picked from commit 8fdb499497f8d4f4a1ca93ffc94de8b57c2c1568)
(cherry picked from commit efaf83fadea2e7b13441d08d82a3a1d27571d16d)

15 years agos3-netapi: add example code for NetShutdownInit and NetShutdownAbort.
Günther Deschner [Wed, 13 May 2009 14:38:00 +0000 (16:38 +0200)]
s3-netapi: add example code for NetShutdownInit and NetShutdownAbort.

Guenther
(cherry picked from commit 80f0d819fb85bdfbd85e910fccc62e778bea3a83)
(cherry picked from commit de33ca38880aa10fbd57ce45f2defdf83c379879)

15 years agos3-netapi: add NetShutdownInit and NetShutdownAbort to public API.
Günther Deschner [Wed, 13 May 2009 14:35:45 +0000 (16:35 +0200)]
s3-netapi: add NetShutdownInit and NetShutdownAbort to public API.

Guenther
(cherry picked from commit 1ddc4829aec61d952aaf3185cc56d53d4a9b5c3c)
(cherry picked from commit afca1d6cd2a184d7b8f70847db143761d5497ac6)

15 years agos3-netapi: add NetShutdownInit and NetShutdownAbort skeletons.
Günther Deschner [Wed, 13 May 2009 14:27:58 +0000 (16:27 +0200)]
s3-netapi: add NetShutdownInit and NetShutdownAbort skeletons.

Guenther
(cherry picked from commit 8fd3c8902c5e953a0ddf184b08f9e37f954ee12e)
(cherry picked from commit fb8cbd7f7e078754faf7fb0b9f071aecbb19d401)

15 years agos3-build: re-run make samba3-idl.
Günther Deschner [Wed, 13 May 2009 14:17:36 +0000 (16:17 +0200)]
s3-build: re-run make samba3-idl.

Guenther
(cherry picked from commit 3a2c748cf4626266899103aa719ea6ac2eae3a9f)
(cherry picked from commit e1c76e41b9f517fea6aa79ba9c0f21b76ab31258)

15 years agos3-netapi: add NetShutdownInit and NetShutdownAbort.
Günther Deschner [Wed, 13 May 2009 14:16:33 +0000 (16:16 +0200)]
s3-netapi: add NetShutdownInit and NetShutdownAbort.

I know, they don't exist as such calls on windows but having them in
libnetapi.so would be very handy.

Guenther
(cherry picked from commit e272acf4848b6c5944acc685b0738e520b3039fb)
(cherry picked from commit 7f904f0b50dc59282f8804fcd87407d0ee3af918)

15 years agoTurn on SHORTNAME-TEST in torture.
Jeremy Allison [Thu, 14 May 2009 23:50:50 +0000 (16:50 -0700)]
Turn on SHORTNAME-TEST in torture.
Jeremy.
(cherry picked from commit 99771d2e23b476d1a7becd9f394421363dd0dffe)

15 years agoMake us pass SHORTNAME-TEST.
Jeremy Allison [Thu, 14 May 2009 23:49:18 +0000 (16:49 -0700)]
Make us pass SHORTNAME-TEST.
Jeremy
(cherry picked from commit 82d9d7b2136a236d3f2b7b1255a920a1ef394ffe)

15 years agoMake error message clearer on fail.
Jeremy Allison [Thu, 14 May 2009 23:30:11 +0000 (16:30 -0700)]
Make error message clearer on fail.
Jeremy.
(cherry picked from commit f81698c70e2513c4699048263c0d6d57a5a9bc64)

15 years agoAdd a test showing what ascii values cause an NTFS volume to
Jeremy Allison [Thu, 14 May 2009 22:56:13 +0000 (15:56 -0700)]
Add a test showing what ascii values cause an NTFS volume to
create a mangled name. We don't pass this yet, but it's not
run by default.
Jeremy.
(cherry picked from commit 18d9e7074635c80052e8bb8d85ad5605663e2695)

15 years agoRemove one use of mangle_is_8_3(), not needed.
Jeremy Allison [Thu, 14 May 2009 19:34:28 +0000 (12:34 -0700)]
Remove one use of mangle_is_8_3(), not needed.
Jeremy.
(cherry picked from commit 0e7f37336ec2d7e1158342fb855af3dff84a7d1e)

15 years agos3-printing: no need to define struct table_node 4 times.
Günther Deschner [Tue, 12 May 2009 12:15:01 +0000 (14:15 +0200)]
s3-printing: no need to define struct table_node 4 times.

Guenther
(cherry picked from commit 652251701df7dec1401eab9b1dbc7e3ac5c7e7ad)
(cherry picked from commit e6b6027218b96bf3357837d051ca5d2df0d88561)

15 years agos3-net: Fix bug 6340: don't segfault when cleartext trustdom pwd could not be retrieved.
Günther Deschner [Wed, 13 May 2009 13:17:46 +0000 (15:17 +0200)]
s3-net: Fix bug 6340: don't segfault when cleartext trustdom pwd could not be retrieved.

Guenther
(cherry picked from commit e88de848c0228cd515b4e356aafe5d7207e49d75)

15 years agos4-selftest: match new name of RPC-SAMR-ACCESSMASK.
Günther Deschner [Wed, 13 May 2009 13:15:30 +0000 (15:15 +0200)]
s4-selftest: match new name of RPC-SAMR-ACCESSMASK.

Guenther
(cherry picked from commit c3e61b54606175858d2221e5f4a75f2fcf149631)
(cherry picked from commit 198fd3f89c2ce60523c755c1917b7bca25436bf1)

15 years agos4-smbtorture: split RPC-SAMR-ACCESSMASK into several tests.
Günther Deschner [Wed, 13 May 2009 13:14:20 +0000 (15:14 +0200)]
s4-smbtorture: split RPC-SAMR-ACCESSMASK into several tests.

Guenther
(cherry picked from commit 675e52cde78906a63fe96e6d34aab92eb710c6b2)
(cherry picked from commit 7c44471f567dc1775f5b4ebf216475b1f348c42a)

15 years agos4-smbtorture: cosmetic cleanup for RPC-SAMR-ACCESSMASK.
Günther Deschner [Wed, 13 May 2009 01:18:07 +0000 (03:18 +0200)]
s4-smbtorture: cosmetic cleanup for RPC-SAMR-ACCESSMASK.

Guenther
(cherry picked from commit 2abdfab613b9487138612bf4ad0422ce4771d7cc)
(cherry picked from commit 737ac891e0be2fafbbc1e2c60f081268b7c0c3a1)

15 years agoRevert "s3: checkin .po for pam_winbind" because of license issue.
Bo Yang [Wed, 13 May 2009 13:54:06 +0000 (21:54 +0800)]
Revert "s3: checkin .po for pam_winbind" because of license issue.

This reverts commit 43388521b8f31757309fb8bec71ad9ee0f3b21de.
(cherry picked from commit 0c54e8b3e4f9d7efe1974fa39a039997196b6309)

15 years agos3: checkin .po for pam_winbind
Bo Yang [Wed, 13 May 2009 10:59:55 +0000 (18:59 +0800)]
s3: checkin .po for pam_winbind

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit 8611f03dbb0c45d8755725232508cff258b426d5)
(cherry picked from commit 43388521b8f31757309fb8bec71ad9ee0f3b21de)

15 years agos3 onefs: Self-contend level2 oplocks on BRL
Zack Kirsch [Mon, 11 May 2009 17:10:43 +0000 (17:10 +0000)]
s3 onefs: Self-contend level2 oplocks on BRL
(cherry picked from commit 3627ceb5e25cdecd1a8113a5028cc898a1424349)
(cherry picked from commit de68d52c8b7b101ad37d3eb09456bcb31e687906)

15 years agos3 onefs: Fix ignore sacl parameter
Tim Prouty [Wed, 13 May 2009 00:38:10 +0000 (17:38 -0700)]
s3 onefs: Fix ignore sacl parameter
(cherry picked from commit c2482d6b23f769d8a5fa4141f9540a25c985d7cc)
(cherry picked from commit b2ba00adc91d18e7356dd0375cf7c24cefe21ed0)

15 years agos3: Fix strict locking with chained reads
Tim Prouty [Tue, 12 May 2009 23:32:32 +0000 (16:32 -0700)]
s3: Fix strict locking with chained reads

Move the strict lock/unlock code down a level for reads to avoid
calling chain_reply before the unlock.
(cherry picked from commit c60bb39df355c2ef36e4cfdff69cc348adc6dae1)
(cherry picked from commit 4fe9f5e1204fd5578a6043ad314614dc541decda)

15 years agos3: Fallback to the legacy sid_to_(uid|gid) instead of returning NULL.
Aravind Srinivasan [Thu, 16 Apr 2009 20:42:40 +0000 (20:42 +0000)]
s3: Fallback to the legacy sid_to_(uid|gid) instead of returning NULL.

This is very similar to be1dfff02d562e42a7847bd02fed8538630d3f41
(cherry picked from commit 5aefb44bf04becc6b80e7c3bf038d79851c5b0f9)
(cherry picked from commit d07c3437aa9f6262abab87bc298c74fd953ebcfc)

15 years agos3-spoolss: move SPL_ARCH_X defines to IDL.
Günther Deschner [Tue, 12 May 2009 12:12:31 +0000 (14:12 +0200)]
s3-spoolss: move SPL_ARCH_X defines to IDL.

Guenther
(cherry picked from commit 7403dd39d608e07f107530819277738ebd20a320)
(cherry picked from commit 37d0afc095e43d707ff3b86c9ebda22e8a10f77f)

15 years agospoolss: add SPOOLSS_ARCHITECTURE_ALL to IDL.
Günther Deschner [Tue, 12 May 2009 12:11:03 +0000 (14:11 +0200)]
spoolss: add SPOOLSS_ARCHITECTURE_ALL to IDL.

Guenther
(cherry picked from commit a4f558da79e5746124b79583ca608b394e635ad3)
(cherry picked from commit 295035c7cf353a4e1ba5e6e8737ef78329acee8b)

15 years agos3-build: re-run make samba3-idl.
Günther Deschner [Tue, 12 May 2009 23:38:06 +0000 (01:38 +0200)]
s3-build: re-run make samba3-idl.

Guenther
(cherry picked from commit b716e57bef3b42c4be24b5d41c05dbc0665f5191)
(cherry picked from commit 6c06db0bfb0a88c1a85f559bdda16156e1722cbc)

15 years agoinitshutdown: add shutdown reason codes.
Günther Deschner [Tue, 12 May 2009 23:37:30 +0000 (01:37 +0200)]
initshutdown: add shutdown reason codes.

Guenther
(cherry picked from commit c07f4a1299700cf6d530aee390972d3324ba0566)
(cherry picked from commit ce9dcd96497aec1c66ce3df9bb4e83e3346b724a)

15 years agos3-netdomjoin-gui: prepare to call out for NetRenameMachineInDomain() to rename computers
Günther Deschner [Tue, 12 May 2009 20:46:36 +0000 (22:46 +0200)]
s3-netdomjoin-gui: prepare to call out for NetRenameMachineInDomain() to rename computers
in domains.

Guenther
(cherry picked from commit 6154b031f4521fad4b5c460643da59dd918b240a)
(cherry picked from commit a53f9e695bd09b166085d8c714f323ff1d0ce1c6)

15 years agoerror-codes: add some more WERRORs to table.
Günther Deschner [Tue, 12 May 2009 21:50:37 +0000 (23:50 +0200)]
error-codes: add some more WERRORs to table.

These tables really should be auto-generated at some point...

Guenther
(cherry picked from commit aa84ca6e6ba66536ca32dc5792d27e2169589a14)
(cherry picked from commit 35d03a151606f2971b171370af19fd227748213f)

15 years agos3-netdomjoin-gui: Fix join prompt dialog test.
Günther Deschner [Tue, 12 May 2009 21:47:21 +0000 (23:47 +0200)]
s3-netdomjoin-gui: Fix join prompt dialog test.

Guenther
(cherry picked from commit d3a9ee689d636f13f7935d1ddfccfdd4f4e8527a)
(cherry picked from commit 7533e32075ac8b162c230ed112974f421e0d1569)

15 years agos3-netdomjoin-gui: use NetServerGetInfo() level 101 to get hostname.
Günther Deschner [Tue, 12 May 2009 20:15:04 +0000 (22:15 +0200)]
s3-netdomjoin-gui: use NetServerGetInfo() level 101 to get hostname.

Guenther
(cherry picked from commit 3e2975b3bdd247d1e3e7c74bada2f85a1936acaf)
(cherry picked from commit 4298e296f02a4df182d5d2ee2623bc869b321c53)

15 years agos3-netdomjoin-gui: inspect the correct computername string before
Günther Deschner [Tue, 12 May 2009 20:12:47 +0000 (22:12 +0200)]
s3-netdomjoin-gui: inspect the correct computername string before
enabling/disabling the change button.

Guenther
(cherry picked from commit 20b5fc02d2e97dbd51d84cc05ac887e274b14866)
(cherry picked from commit c7ca84fd4a4c58771b47252248b00e6bb5c411a1)

15 years agos3:loadparm: free the file_list at the start of loadparm
Michael Adam [Wed, 6 May 2009 00:25:08 +0000 (02:25 +0200)]
s3:loadparm: free the file_list at the start of loadparm

This should reduce the waste of memory when using "config file"
or "config backend". It also reduces the risk of triggering
reloads due to some old unused files being checked.

Michael
(cherry picked from commit 6708b926a47b53a2984de6af9bb9d319ed6efe58)
(cherry picked from commit 25b0c51c8db62b5e7b12cab19b4dd2fa699ed67e)

15 years agos3:loadparm: refactor freeing of file_list out into free_file_lists()
Michael Adam [Wed, 6 May 2009 00:09:56 +0000 (02:09 +0200)]
s3:loadparm: refactor freeing of file_list out into free_file_lists()

Michael
(cherry picked from commit 6aef9bbbf7160cf9e79c50e13632bf29efaedb65)
(cherry picked from commit 2f63ee84f29f15b6173ffc20b7debad2b91eafe6)

15 years agos3:build: extend the support fo Debian GNU/kFooBar to kOpenSolaris
Michael Adam [Fri, 8 May 2009 22:10:51 +0000 (00:10 +0200)]
s3:build: extend the support fo Debian GNU/kFooBar to kOpenSolaris

As suggested by Robert Millan.

Michael
(cherry picked from commit 66dff4073d0013bfd11ac29e341765141393ea23)
(cherry picked from commit aca044014a7c20b1e4d9babc8710865b9b7610ce)

15 years agos3:build: support non-linux gnu ports
Michael Adam [Thu, 30 Apr 2009 19:59:07 +0000 (21:59 +0200)]
s3:build: support non-linux gnu ports

This is based on a patch by the debian package maintainers,
adapted for the merged branch.

Michael
(cherry picked from commit 5fba1e938c59492872d026c452cbbf8d2239c95f)
(cherry picked from commit dd699425f80a1b1fa158b2386c2b10338b656298)

15 years agos3:proto.h: remove old param/params.c prototype
Michael Adam [Mon, 11 May 2009 05:43:07 +0000 (07:43 +0200)]
s3:proto.h: remove old param/params.c prototype

Michael
(cherry picked from commit a04bac71356139c62d786f6254d33bd247fb7692)
(cherry picked from commit b0a46b6abd265e484e89912eb7b9e1feb1b917c2)

15 years agos3:smbd: fix the fix for mapped IPv4 address handling in release_ip().
Michael Adam [Fri, 8 May 2009 13:13:21 +0000 (15:13 +0200)]
s3:smbd: fix the fix for mapped IPv4 address handling in release_ip().

It was too late... Thanks Metze for noticing.

Michael
(cherry picked from commit 7d6e4c7e950592112d09f7d98393c41e8097bba8)
(cherry picked from commit af5adfbd402a8d4fe31b7de5d13aa82287e88e57)

15 years agos3: make release_ip() call (ctdb) cope with IPv4 mapped addresses
Michael Adam [Thu, 7 May 2009 23:11:43 +0000 (01:11 +0200)]
s3: make release_ip() call (ctdb) cope with IPv4 mapped addresses

Michael
(cherry picked from commit e86a534fa707b44baec87060745dd8a557622721)
(cherry picked from commit acf13609039a0cd321fdfe7ce75e508036f91e5d)

15 years agoFix the last few format arg missmatches I missed.
Jeremy Allison [Tue, 12 May 2009 17:38:00 +0000 (10:38 -0700)]
Fix the last few format arg missmatches I missed.
Jeremy.
(cherry picked from commit d2ce16043ba7a0ee7368a611eacddc010d3935e0)

15 years agoFix bug 6157
Volker Lendecke [Thu, 12 Mar 2009 16:23:17 +0000 (17:23 +0100)]
Fix bug 6157

This patch picks the alphabetically smallest one of the multi-value attribute
"uid". This fixes a regression against 3.0 and also becomes deterministic.
(cherry picked from commit b1d864d1006aab53a1692175adf2c64897eeffd9)

15 years agos3-printing: Fix vlp testprinter application.
Günther Deschner [Tue, 12 May 2009 09:41:14 +0000 (11:41 +0200)]
s3-printing: Fix vlp testprinter application.

Jeremy, we cannot just access cache_path() here without calling lp_load and
friends as well as parsing configfile from the commandline in order to make
"make test/selftest" find the correct conffile with path, etc.

I just changed it to pass the target tdbfilename as an argument, ok ?

Guenther
(cherry picked from commit 94665adb484c25534b756012e9b55f01737b7713)
(cherry picked from commit 502d9ec5d1f37cd5d992324025b88756b6a475ec)

15 years agoFix warning about unused label with no sendfile.
Jeremy Allison [Tue, 12 May 2009 06:23:17 +0000 (23:23 -0700)]
Fix warning about unused label with no sendfile.
Jeremy.
(cherry picked from commit 6c5450d9010b83e4acdd359279102ceda9bf0318)

15 years agoFix a bunch of compiler warnings about wrong format types.
Jeremy Allison [Tue, 12 May 2009 04:56:57 +0000 (21:56 -0700)]
Fix a bunch of compiler warnings about wrong format types.
Should make Solaris 10 builds look cleaner.
Jeremy.
(cherry picked from commit b5947b876f3c777e075879d305b6672a6c8d8abd)

15 years agoHopefully fix the buildfarm. Add some debug level 10 messages
Jeremy Allison [Tue, 12 May 2009 00:29:48 +0000 (17:29 -0700)]
Hopefully fix the buildfarm. Add some debug level 10 messages
I used to track down the vlp problem, change the vlp test printer
not to use a static path of /tmp/vlp.tdb for the virtual print
database (as this will eventually fill up). Cause it to use
a virtual print database inside the cachepath.
Jeremy.
(cherry picked from commit dcf314874e90ec9debf1582fc3f6b07f2d4d30ca)

15 years agoEnsure documentation matches the tdb_util function usage.
Jeremy Allison [Tue, 12 May 2009 00:29:16 +0000 (17:29 -0700)]
Ensure documentation matches the tdb_util function usage.
Jeremy.
(cherry picked from commit a63e966ce64d262ae9a032c73915a398a5c174f8)

15 years agos3-samr: Fix rid2sid call, 3-4-test does not have policy_handle_find() yet.
Günther Deschner [Mon, 11 May 2009 23:16:52 +0000 (01:16 +0200)]
s3-samr: Fix rid2sid call, 3-4-test does not have policy_handle_find() yet.

Guenther
(cherry picked from commit 99ae1159fe885cf57ec5cd964febca2eca5def61)

15 years agos3-samr: implement _samr_RidToSid().
Günther Deschner [Fri, 8 May 2009 09:25:56 +0000 (11:25 +0200)]
s3-samr: implement _samr_RidToSid().

Guenther
(cherry picked from commit 0dc1b239eb48ac81797720a8ff23c810321ad5c3)
(cherry picked from commit a26ac9ce2708e8d959500da418daefcb3ca94bd6)

15 years agos3-samr: Let _samr_TestPrivateFunctionsDomain() return NT_STATUS_NOT_SUPPORTED to...
Günther Deschner [Mon, 11 May 2009 21:47:37 +0000 (23:47 +0200)]
s3-samr: Let _samr_TestPrivateFunctionsDomain() return NT_STATUS_NOT_SUPPORTED to make RPC-SAMR happy.

Guenther
(cherry picked from commit 4beb4395eb032a290bf0d29e0d50e4d823e5f20c)
(cherry picked from commit 93ba45468e1aaff625f1f8aad35ccaed598209ef)

15 years agos4-smbtorture: skip SetMemberAttributesOfGroup in RPC-SAMR for s3 as well.
Günther Deschner [Mon, 11 May 2009 22:19:56 +0000 (00:19 +0200)]
s4-smbtorture: skip SetMemberAttributesOfGroup in RPC-SAMR for s3 as well.

Guenther
(cherry picked from commit 54d925a30469f9318717b8e6da7b433efd4efd70)
(cherry picked from commit f70e7de8e1b015f790325c51cff9dc804c8b95ad)

15 years agos4-smbtorture: Skip secdesc set calls for non-user objects in RPC-SAMR for Samba3.
Günther Deschner [Mon, 11 May 2009 21:46:45 +0000 (23:46 +0200)]
s4-smbtorture: Skip secdesc set calls for non-user objects in RPC-SAMR for Samba3.

Note that they are skipped for all objects while testing Samba4.

Guenther
(cherry picked from commit 59cb8fd58d03953ea53eed70da35dd94fe10d9c4)
(cherry picked from commit 9d89c70a7dfb065e0246f251e410dc96e493b03f)

15 years agos4-smbtorture: Fix order of assert args in test_TestPrivateFunctionsDomain() in RPC...
Günther Deschner [Mon, 11 May 2009 21:46:11 +0000 (23:46 +0200)]
s4-smbtorture: Fix order of assert args in test_TestPrivateFunctionsDomain() in RPC-SAMR.

Guenther
(cherry picked from commit 1fb9b65921b617962dd72bf64c62fd95bfdcf326)
(cherry picked from commit 4f6b20feda1940af05840ce4a46a133e628a5f06)

15 years agos4-smbtorture: switch to use torture_context in RPC-SAMR.
Günther Deschner [Mon, 11 May 2009 21:13:26 +0000 (23:13 +0200)]
s4-smbtorture: switch to use torture_context in RPC-SAMR.

Guenther
(cherry picked from commit ff7ebdf317979f54fba257afb1dbfb589b33885f)
(cherry picked from commit 847b21133669fb618398611bbf6ac855ee41ea2e)

15 years agos4-smbtorture: remove trailing whitespace in RPC-SAMR.
Günther Deschner [Mon, 11 May 2009 20:44:58 +0000 (22:44 +0200)]
s4-smbtorture: remove trailing whitespace in RPC-SAMR.

Guenther
(cherry picked from commit 0f88b3cc94edd716894ce86c0e7125298b5b6338)
(cherry picked from commit 80541bd941ea52e9f97a30301c39736f53ea4a4f)

15 years agos3-samr: Fix Bug #5859, renaming of samr objects failed due to samr setuserinfo acces...
Günther Deschner [Mon, 11 May 2009 16:45:46 +0000 (18:45 +0200)]
s3-samr: Fix Bug #5859, renaming of samr objects failed due to samr setuserinfo access checks.

Torture test to follow...

Guenther
(cherry picked from commit 6d1e21bd1b38e8a3c7df3f7fdb8a17fcdd997d42)
(cherry picked from commit e89bc8dcfd15dd0deef587edf9aceb1073d78312)

15 years agoAdd checks for non_root mode to help buildfarm spoolss tests.
Jeremy Allison [Mon, 11 May 2009 16:42:08 +0000 (09:42 -0700)]
Add checks for non_root mode to help buildfarm spoolss tests.
Reviewed by Guenther.
Jeremy.
(cherry picked from commit 11041fe1c24575c25d3ac82e61d9fb2b651db3aa)

15 years agos3-lsa: Fix _lsa_LookupNames2() server implementation which always returned a NULL...
Günther Deschner [Mon, 11 May 2009 16:27:40 +0000 (18:27 +0200)]
s3-lsa: Fix _lsa_LookupNames2() server implementation which always returned a NULL sid_array since 3.2.0.

Found by torture test.

This makes it possible to search for users while adding them to groups via
windows usermanager.

Guenther
(cherry picked from commit a82bb4bd516e6a8e50c0272b79df8e506ea0cc91)
(cherry picked from commit 7d1e25a885637b65c75b4ddd78949c4a2091bb6d)

15 years agos3/ldap: also handle DirX return codes
Björn Jacke [Thu, 7 May 2009 15:50:34 +0000 (17:50 +0200)]
s3/ldap: also handle DirX return codes
(cherry picked from commit 5616abe2e8fb6a95fa82b80e8e97090e956b98ff)

15 years agos3-selftest: enable RPC-LSA-LOOKUPNAMES against Samba 3.
Günther Deschner [Mon, 11 May 2009 14:29:39 +0000 (16:29 +0200)]
s3-selftest: enable RPC-LSA-LOOKUPNAMES against Samba 3.

Guenther
(cherry picked from commit f5cab8913b77c37dc24188b9093b80a0b4d42749)
(cherry picked from commit 69551b562a575c300d14bd1691fe5213db71d6bc)

15 years agos4-smbtorture: add very basic RPC-LSA-LOOKUPNAMES test.
Günther Deschner [Mon, 11 May 2009 14:28:42 +0000 (16:28 +0200)]
s4-smbtorture: add very basic RPC-LSA-LOOKUPNAMES test.

Guenther
(cherry picked from commit 5f015920a80a22f5486e0679f017db3a5ff9d798)
(cherry picked from commit ac5adbc294eb96db658151a9d278cae0e63ff3a1)

15 years agos4-smbtorture: add optional very simple reply checks to lsa lookup name tests.
Günther Deschner [Mon, 11 May 2009 14:40:26 +0000 (16:40 +0200)]
s4-smbtorture: add optional very simple reply checks to lsa lookup name tests.

Guenther
(cherry picked from commit 7347373e7cb814d683c603ed958583ff70552a2b)
(cherry picked from commit 90aac31a2db75895a1b75b8c5e4a8259938ff74b)

15 years agos4-smbtorture: remove trailing whitespace in RPC-LSA test.
Günther Deschner [Mon, 11 May 2009 12:54:04 +0000 (14:54 +0200)]
s4-smbtorture: remove trailing whitespace in RPC-LSA test.

Guenther
(cherry picked from commit 7672a033eff9db1203c69de422fb906504a54f77)
(cherry picked from commit 983d92188dcc5ac4bc31365cea195532e40d1144)

15 years agos4-smbtorture: use struct torture_context in RPC-LSA.
Günther Deschner [Mon, 11 May 2009 12:51:41 +0000 (14:51 +0200)]
s4-smbtorture: use struct torture_context in RPC-LSA.

Guenther
(cherry picked from commit 410f17cdebab929c68cd6d68b6e1a29ffe64e8d4)
(cherry picked from commit bada15c31123c0a7c2716620c19f3a073e7c0067)

15 years agos3-docs: document "net dom renamecomputer".
Günther Deschner [Mon, 11 May 2009 08:30:05 +0000 (10:30 +0200)]
s3-docs: document "net dom renamecomputer".

Guenther
(cherry picked from commit fe474861f87dc02081acf34d756329c66cc5c805)
(cherry picked from commit 92117cd56692303b2018299cd43f229b0db59066)

15 years agos3-net: add "net dom renamecomputer" to rename machines in a domain.
Günther Deschner [Fri, 8 May 2009 19:56:17 +0000 (21:56 +0200)]
s3-net: add "net dom renamecomputer" to rename machines in a domain.

dmarkey, please test :)

Guenther
(cherry picked from commit b1a4649438e5f27722c8dae629037df2543871c7)
(cherry picked from commit 0f3c2e2e0c47d1f774f4265fb60498483c27840d)

15 years agoDo not call SMB_VFS_GET_REAL_FILENAME if the name is mangled
Volker Lendecke [Sat, 9 May 2009 09:12:52 +0000 (11:12 +0200)]
Do not call SMB_VFS_GET_REAL_FILENAME if the name is mangled

The GPFS get_real_file name does not know about mangled names. Tim, if onefs
does not either, you need this bugfix :-)

In case onefs does 8.3 names, we need to pass the mangled flag down to
SMB_VFS_GET_REAL_FILENAME to give GPFS a chance say ENOTSUPP and do the
fallback.
(cherry picked from commit 97c668276d24743065f16dccaf29704b6f3857f4)

15 years agos3: Fix chained sesssetupAndX/tconn messages
Tim Prouty [Wed, 25 Mar 2009 00:24:55 +0000 (00:24 +0000)]
s3: Fix chained sesssetupAndX/tconn messages

A sesssetupAndX chained with a tconn will not correctly set the TID in
the response header.  I'm seeing an XP client send this chained
sesssetup/tconn when samba has security = share.  Samba's current
behavior is to return a TID of 0 in the smb header rather than the
actual TID.  This patch also updates the UID in the header as well.
(cherry picked from commit b6c86e1ef28d9008eec1d39ad714a475dc735c38)

15 years agos4-smbtorture: avoid secdesc test on connect handle in RPC-SAMR-USERS for Samba3.
Günther Deschner [Fri, 8 May 2009 22:46:17 +0000 (00:46 +0200)]
s4-smbtorture: avoid secdesc test on connect handle in RPC-SAMR-USERS for Samba3.

With this, I think, we pass RPC-SAMR-USERS.

Guenther
(cherry picked from commit a3873bca516e0f89302409c89910561707360d14)
(cherry picked from commit 3f55201564afae5681b3530cb767da7f2b64794c)

15 years agos3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag.
Günther Deschner [Fri, 8 May 2009 22:03:50 +0000 (00:03 +0200)]
s3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag.

It is not allowed to *set* this flag remotely if it has been not set already.

Found by torture test.

Guenther
(cherry picked from commit a21bfc4daff9e67750021d96ffa0c1e6e4cd3472)
(cherry picked from commit d8b37fe08e9e833c466c82e07599356b746020fa)

15 years agos3-samr: Fix SetUserInfo level 7 when there has been no name change.
Günther Deschner [Fri, 8 May 2009 22:02:00 +0000 (00:02 +0200)]
s3-samr: Fix SetUserInfo level 7 when there has been no name change.

Found by torture test.

Guenther
(cherry picked from commit 705f36b804093f656498f7963768a418672cd422)
(cherry picked from commit 863b568624ef908c9454ed28d64a82e5afddd79a)