abartlet/samba.git/.git
14 years agos4:s3compat Don't include generated files via dependencies and name
Andrew Bartlett [Tue, 18 May 2010 11:52:24 +0000 (21:52 +1000)]
s4:s3compat Don't include generated files via dependencies and name

These generated files are part of NDR_STANDARD

Andrew Bartlett

14 years agos4:s3compat re-add idmap to s3compat winbindd
Andrew Bartlett [Tue, 18 May 2010 03:01:34 +0000 (13:01 +1000)]
s4:s3compat re-add idmap to s3compat winbindd

14 years agos4:s3compat push lp_server_role() into s3compat
Andrew Bartlett [Mon, 17 May 2010 11:02:32 +0000 (21:02 +1000)]
s4:s3compat push lp_server_role() into s3compat

14 years agos4:s3compat Provide make_auth_context_subsystem()
Andrew Bartlett [Mon, 17 May 2010 11:02:59 +0000 (21:02 +1000)]
s4:s3compat Provide make_auth_context_subsystem()

This avoids needing to specify an 'auth methods' in the smb.conf to
run s3compat

Andrew Bartlett

14 years agos4:s3compt provide get_winbind_pipe_dir and get_winbind_priv_pipe_dir
Andrew Bartlett [Mon, 17 May 2010 10:04:13 +0000 (20:04 +1000)]
s4:s3compt provide get_winbind_pipe_dir and get_winbind_priv_pipe_dir

14 years agos4:winbindd Return the wbsrv_service structure to help s3compat
Andrew Bartlett [Mon, 17 May 2010 09:54:45 +0000 (19:54 +1000)]
s4:winbindd Return the wbsrv_service structure to help s3compat

This allows it to be stashed in a static variable if required.

Andrew Bartlett

14 years agos4:s3compat provide hooks for lp_workgroup() etc in s3compat
Andrew Bartlett [Mon, 17 May 2010 09:11:24 +0000 (19:11 +1000)]
s4:s3compat provide hooks for lp_workgroup() etc in s3compat

These functions are key to maintaining a consistant view of the
binary, and it was practical to seperate them from the source3
loadparm.  This helps the s3compat winbind effort.

Andrew Bartlett

14 years agos4:s3compat Put the s3compat_get_conn() hook with the rest of the globals
Andrew Bartlett [Mon, 17 May 2010 09:09:37 +0000 (19:09 +1000)]
s4:s3compat Put the s3compat_get_conn() hook with the rest of the globals

14 years agos4:s3compat Avoid talloc_free() with references
Andrew Bartlett [Mon, 17 May 2010 09:08:19 +0000 (19:08 +1000)]
s4:s3compat Avoid talloc_free() with references

The ldb context is referenced, so free via a parent.

Andrew Bartlett

14 years agos4:s3compat provide new check_sam_security_info3 hook to Samba4's auth
Andrew Bartlett [Mon, 17 May 2010 09:07:14 +0000 (19:07 +1000)]
s4:s3compat provide new check_sam_security_info3 hook to Samba4's auth

This hook avoids a conversion to and from the 'server_info' structure
on the source3 side of the interface.

Andrew Bartlett

14 years agos4:s3compat Fix use-after-free of winbindd client state
Andrew Bartlett [Mon, 17 May 2010 06:19:51 +0000 (16:19 +1000)]
s4:s3compat Fix use-after-free of winbindd client state

We need to remove this from the global list when we talloc_free() it.

14 years agos4:s3compat Don't load or compile auth modules from source3
Andrew Bartlett [Mon, 17 May 2010 04:11:52 +0000 (14:11 +1000)]
s4:s3compat Don't load or compile auth modules from source3

The only auth module should be the wrapper that plugs into the source4
auth subsystem, and builtin, for compatability.

Andrew Bartlett

14 years agos4:s3compat Rationalise headers and _PUBLIC_ declarations
Andrew Bartlett [Mon, 17 May 2010 03:44:47 +0000 (13:44 +1000)]
s4:s3compat Rationalise headers and _PUBLIC_ declarations

These _PUBLIC_ declarations were not needed in the end.  Also just
tidy up the copyright on machine_sid.c (only the API was kept, the
contents are a rewrite).

Andrew Bartlett

14 years agos4:s3compat Add replacement for machine account functions in secrets.c
Andrew Bartlett [Mon, 17 May 2010 03:43:16 +0000 (13:43 +1000)]
s4:s3compat Add replacement for machine account functions in secrets.c

These replacements back onto the cli_credentials and secrets.ldb code,
and ensure that the machine password used is the one stored by 'net
join' from source4/.

Andrew Bartlett

14 years agos4:s3compat cope with rebase - new file print_standard.c
Andrew Bartlett [Fri, 14 May 2010 23:28:30 +0000 (09:28 +1000)]
s4:s3compat cope with rebase - new file print_standard.c

14 years agos4:s3compat Add prototypes for a safer s3compat
Andrew Bartlett [Fri, 14 May 2010 11:14:21 +0000 (21:14 +1000)]
s4:s3compat Add prototypes for a safer s3compat

Manual local prototypes are just trouble waiting to pounce...

Andrew Bartlett

14 years agos4:s3compat Change s3compat winbind interface and add prototypes
Andrew Bartlett [Fri, 14 May 2010 11:08:30 +0000 (21:08 +1000)]
s4:s3compat Change s3compat winbind interface and add prototypes

It's just asking for trouble to use manually created unsyncronised
prototypes.

The winbind change is to have the source3/winbind code engange after
the parsing of the packet, rather than before.  This is because
otherwise there was a conflict with the stream_connection code.

Andrew Bartlett

14 years agos4:s3compat cope with split of winbindd.c
Andrew Bartlett [Fri, 14 May 2010 07:30:55 +0000 (17:30 +1000)]
s4:s3compat cope with split of winbindd.c

14 years agos4:s3compat use more ugly but more portable xterm in for gdb
Andrew Bartlett [Thu, 13 May 2010 07:12:14 +0000 (17:12 +1000)]
s4:s3compat use more ugly but more portable xterm in for gdb

I have difficulty launching gnome-terminal for some reason.

Andrew Bartlett

14 years agos4:s3compat Don't mess with signals or reinit anything in s3compat
Andrew Bartlett [Thu, 13 May 2010 07:11:38 +0000 (17:11 +1000)]
s4:s3compat Don't mess with signals or reinit anything in s3compat

These event management functions should not be called at this layer.

Andrew Bartlett

14 years agos4:s3compat call the simpler s3compat_winbind_accept() routine
Andrew Bartlett [Thu, 13 May 2010 07:09:05 +0000 (17:09 +1000)]
s4:s3compat call the simpler s3compat_winbind_accept() routine

This is a cleaner way to enter into s3compat, and moves as much of the
glue out of source4/winbind as possible.

Andrew Bartlett

14 years agos4:s3compat Change when we start up s3compat
Andrew Bartlett [Thu, 13 May 2010 07:04:52 +0000 (17:04 +1000)]
s4:s3compat Change when we start up s3compat

This allows the s3compat code to run things that need an event
context, and also changes us to use a slightly safer way to cross into
s3compat from winbind.

Andrew Bartlett

14 years agos4:s3compat make smbd_server_fd() return -1 when not yet connected
Andrew Bartlett [Thu, 13 May 2010 01:30:03 +0000 (11:30 +1000)]
s4:s3compat make smbd_server_fd() return -1 when not yet connected

This matches the expectation of some callers in source3/smbd

Andrew Bartlett

14 years agos4:s3compat We can't use s3compat_get_conn() any more
Andrew Bartlett [Thu, 13 May 2010 01:29:10 +0000 (11:29 +1000)]
s4:s3compat We can't use s3compat_get_conn() any more

We have to use functions that don't assume a connection, as winbindd
does not have one.

Andrew Bartlett

14 years agos4:s3compat Add implementation of kerberos_return_pac()
Andrew Bartlett [Wed, 12 May 2010 21:50:10 +0000 (07:50 +1000)]
s4:s3compat Add implementation of kerberos_return_pac()

This allows the winbindd from source3 to link in s3comapt, while using
the source4/ Kerberos code to handle the PAC collection and extraction.

Andrew Bartlett

14 years agos4:s3compat don't include server.c, just server_reload.c and server_exit.c
Andrew Bartlett [Fri, 14 May 2010 06:31:51 +0000 (16:31 +1000)]
s4:s3compat don't include server.c, just server_reload.c and server_exit.c

This made possible by a split up of smbd/server.c

Andrew Bartlett

14 years agos4:s3compat Force no idmap backends for now
Andrew Bartlett [Tue, 11 May 2010 11:18:43 +0000 (21:18 +1000)]
s4:s3compat Force no idmap backends for now

This is needed to get idmap.c to compile.  I'll need to merge with
kai's waf work to get further.

Andrew Bartlett

14 years agos4:s3compat Add building of source3's winbindd in s3compat
Andrew Bartlett [Tue, 11 May 2010 11:14:09 +0000 (21:14 +1000)]
s4:s3compat Add building of source3's winbindd in s3compat

Andrew Bartlett

14 years agos4:s3compat cope with move of lib/account_pol.c -> passdb/account_pol.c
Andrew Bartlett [Tue, 11 May 2010 10:59:14 +0000 (20:59 +1000)]
s4:s3compat cope with move of lib/account_pol.c -> passdb/account_pol.c

14 years agos4:s3compat Remove call to now removed namecache_enable()
Andrew Bartlett [Tue, 11 May 2010 10:58:29 +0000 (20:58 +1000)]
s4:s3compat Remove call to now removed namecache_enable()

14 years agos4:s3compat Provide hooks to get and set 'samba3' and 'samba4' globals
Andrew Bartlett [Tue, 11 May 2010 10:55:30 +0000 (20:55 +1000)]
s4:s3compat Provide hooks to get and set 'samba3' and 'samba4' globals

This avoids the need to compile smbd/server.c and ensures closer
control over these important global variables.

Andrew Bartlett

14 years agos4:s3compat Provide check_sam_security to check local passwords from winbindd
Andrew Bartlett [Tue, 11 May 2010 10:25:59 +0000 (20:25 +1000)]
s4:s3compat Provide check_sam_security to check local passwords from winbindd

source3/winbindd in does not use the full auth subsystem, but instead short-cuts
to this function.

Andrew Bartlett

14 years agos4:s3compat Provide replacement machine_sid functions based on LDB
Andrew Bartlett [Thu, 6 May 2010 06:49:49 +0000 (16:49 +1000)]
s4:s3compat Provide replacement machine_sid functions based on LDB

This ensures that Samba3 has the right machine sid at all times.

Andrew Bartlett

14 years agos4:s3compat Provide a replacement for ads_verify_ticket() that uses GENSEC
Andrew Bartlett [Thu, 6 May 2010 06:45:53 +0000 (16:45 +1000)]
s4:s3compat Provide a replacement for ads_verify_ticket() that uses GENSEC

This should allow Samba3 to use Samba4's keytab when accepting
connections, while matching the behaviour (except for the time_t
time_offset and realm) of Samba3.

Andrew Bartlett

14 years agos4:s3compat Add an auth module that forwards authentication to Samba4
Andrew Bartlett [Wed, 5 May 2010 12:59:42 +0000 (22:59 +1000)]
s4:s3compat Add an auth module that forwards authentication to Samba4

To use, set 'auth methods = samba4' in the smb.conf file, and ensure
you have aready added the user you wish to use to /etc/passwd.
(Winbind does not yet work with s3compat).

Andrew Bartlett

14 years agos4:s3compat Provide a way to get at the Samba4 lp_ctx in Samba3.
Andrew Bartlett [Wed, 5 May 2010 02:45:39 +0000 (12:45 +1000)]
s4:s3compat Provide a way to get at the Samba4 lp_ctx in Samba3.

Andrew Bartlett

14 years agos4:s3compat Import Samba3 IDL files into the s3compat build.
Andrew Bartlett [Wed, 5 May 2010 02:44:47 +0000 (12:44 +1000)]
s4:s3compat Import Samba3 IDL files into the s3compat build.

We now need to build these, as Samba3 no longer has these checked into
the tree.

Andrew Bartlett

14 years agos4:param Add "state dir" and "cache dir" to Samba4's smb.conf parser
Andrew Bartlett [Tue, 4 May 2010 09:15:00 +0000 (19:15 +1000)]
s4:param Add "state dir" and "cache dir" to Samba4's smb.conf parser

These will somehow be passed into the Samba3 code.

Andrew Bartlett

14 years agos4:selftest Provide "state dir" and "cache dir" to selftest
Andrew Bartlett [Tue, 4 May 2010 09:14:16 +0000 (19:14 +1000)]
s4:selftest Provide "state dir" and "cache dir" to selftest

This helps when s3compat is built into the tree, as it needs these set.

Andrew Bartlett

14 years agos4:s3compat Provide a hook to get at the Samba4 loadparm from Samba3
Andrew Bartlett [Tue, 4 May 2010 09:13:08 +0000 (19:13 +1000)]
s4:s3compat Provide a hook to get at the Samba4 loadparm from Samba3

The idea here is that we can provide here functions to make it
possible to hook the Samba4 context-provided loadparm into Samba3's
loadparm callers.

Andrew Bartlett

14 years agos3compat: cleanup duplicate var declarations
Andrew Tridgell [Thu, 29 Apr 2010 01:05:59 +0000 (11:05 +1000)]
s3compat: cleanup duplicate var declarations

14 years agos3compat: fixed build
Andrew Tridgell [Wed, 28 Apr 2010 08:39:15 +0000 (18:39 +1000)]
s3compat: fixed build

s3dynconfig is not needed any more

14 years agos3compat: we always have krb5.h from the in-tree heimdal
Andrew Tridgell [Wed, 28 Apr 2010 08:32:17 +0000 (18:32 +1000)]
s3compat: we always have krb5.h from the in-tree heimdal

14 years agos3compat: don't propogate the _PUBLIC_ override to dependencies
Andrew Tridgell [Mon, 26 Apr 2010 02:53:54 +0000 (12:53 +1000)]
s3compat: don't propogate the _PUBLIC_ override to dependencies

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos3compat: use builtin heimdal for com_err, asn1 and related headers
Andrew Tridgell [Mon, 26 Apr 2010 02:36:57 +0000 (12:36 +1000)]
s3compat: use builtin heimdal for com_err, asn1 and related headers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos3compat: s3 code needs com_err.h
Andrew Tridgell [Mon, 26 Apr 2010 02:25:03 +0000 (12:25 +1000)]
s3compat: s3 code needs com_err.h

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos3compat: added option s3compat:gdb = true
Andrew Tridgell [Mon, 26 Apr 2010 02:17:41 +0000 (12:17 +1000)]
s3compat: added option s3compat:gdb = true

this starts a gdb on the s3 fileserver code in a gnome-terminal

14 years agos3compat: use internal heimdal from s4 for s3compat build
Andrew Tridgell [Mon, 26 Apr 2010 01:13:36 +0000 (11:13 +1000)]
s3compat: use internal heimdal from s4 for s3compat build

This brings us a step closer to auth integration

14 years agos3compat: pass interactive flag to s3compat_initialise()
Andrew Tridgell [Mon, 26 Apr 2010 01:12:55 +0000 (11:12 +1000)]
s3compat: pass interactive flag to s3compat_initialise()

14 years agos3compat: fixed the build on systems without a system tevent
Andrew Tridgell [Sun, 25 Apr 2010 12:13:04 +0000 (22:13 +1000)]
s3compat: fixed the build on systems without a system tevent

14 years agos3compat: use a config.h from the waf s3 build for now
Andrew Tridgell [Sun, 25 Apr 2010 12:04:26 +0000 (22:04 +1000)]
s3compat: use a config.h from the waf s3 build for now

We need all the configure options from s3 in the s4 build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos3compat: fixed dependency on build_options.c
Andrew Tridgell [Sun, 25 Apr 2010 11:40:08 +0000 (21:40 +1000)]
s3compat: fixed dependency on build_options.c

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos3compat: no s3replace.h for now
Andrew Tridgell [Sun, 25 Apr 2010 11:31:50 +0000 (21:31 +1000)]
s3compat: no s3replace.h for now

14 years agos3compat: change s3compatlib -> s3compatcore
Andrew Tridgell [Sun, 25 Apr 2010 11:27:05 +0000 (21:27 +1000)]
s3compat: change s3compatlib -> s3compatcore

libs3compatlib doesn't sound so nice :)

14 years agos3compat: it is now possible to connect to s3 shares in a s4 server
Andrew Tridgell [Sun, 25 Apr 2010 11:02:10 +0000 (21:02 +1000)]
s3compat: it is now possible to connect to s3 shares in a s4 server

Right now it needs a passdb.tdb from s3.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos3compat: first version of s3compat system
Andrew Tridgell [Sun, 25 Apr 2010 02:59:57 +0000 (12:59 +1000)]
s3compat: first version of s3compat system

This is a prototype of a system to allow Samba4 to call functions from
Samba3 via a shared library. We use hide_symbols=True to avoid symbol
conflicts.

14 years agos3:winbindd Add hooks for s3compat into source3/winbindd
Andrew Bartlett [Fri, 14 May 2010 14:10:56 +0000 (00:10 +1000)]
s3:winbindd Add hooks for s3compat into source3/winbindd

These extra pointers help the s3compat code do it's job

14 years agos3:auth Improve make_auth_context_text_list API - add const
Andrew Bartlett [Tue, 18 May 2010 03:00:53 +0000 (13:00 +1000)]
s3:auth Improve make_auth_context_text_list API - add const

14 years agos3:auth Enable make_auth_context_subsystem to be replaced in s3compat
Andrew Bartlett [Mon, 17 May 2010 10:47:59 +0000 (20:47 +1000)]
s3:auth Enable make_auth_context_subsystem to be replaced in s3compat

This allows s3compat to replace this with a function that only directs
authentication to the source4 auth subsystem.

Andrew Bartlett

14 years agos3compat-only s3:winbindd Split event handlers from winbindd.c
Andrew Bartlett [Wed, 26 May 2010 01:04:51 +0000 (11:04 +1000)]
s3compat-only s3:winbindd Split event handlers from winbindd.c

This allows the s3compat layer to register the handlers, without
having a conflicting main() function.

Andrew Bartlett

14 years agos3compat-only s3:winbind Split wb_process_request() into a new file
Andrew Bartlett [Fri, 14 May 2010 07:26:46 +0000 (17:26 +1000)]
s3compat-only s3:winbind Split wb_process_request() into a new file

This splits up winbindd.c, which was previously very long.

Andrew Bartlett

14 years agos3compat-only s3:winbindd Move more parts of winbindd.c into winbindd_event.c
Andrew Bartlett [Fri, 14 May 2010 06:21:32 +0000 (16:21 +1000)]
s3compat-only s3:winbindd Move more parts of winbindd.c into winbindd_event.c

This allows another attempt at where to attach s3compat into
source3/winbindd

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agos3:auth Add error paths for invalid password_state values
Andrew Bartlett [Tue, 4 May 2010 13:44:50 +0000 (23:44 +1000)]
s3:auth Add error paths for invalid password_state values

14 years agos3:auth Change winbindd -> auth interface to more standard structures
Andrew Bartlett [Mon, 17 May 2010 09:04:31 +0000 (19:04 +1000)]
s3:auth Change winbindd -> auth interface to more standard structures

This removes conversions to and from the source3 varient of the
server_info structure when replaced in s3compat, and presents a tidier
interface to winbindd in any case.

Andrew Bartlett

14 years agoauth/common_auth.h Add a few more 'common' functions
Andrew Bartlett [Mon, 17 May 2010 03:38:08 +0000 (13:38 +1000)]
auth/common_auth.h Add a few more 'common' functions

This helps ensure that we don't have different prototypes for the
different implementaitons of these functions.

Andrew Bartlett

14 years agoauth Add kerberos_return_pac() to common_auth.h
Andrew Bartlett [Tue, 18 May 2010 03:11:46 +0000 (13:11 +1000)]
auth Add kerberos_return_pac() to common_auth.h

14 years agoauth Add ads_verify_ticket() to common_auth.h
Andrew Bartlett [Tue, 18 May 2010 03:09:39 +0000 (13:09 +1000)]
auth Add ads_verify_ticket() to common_auth.h

14 years agos3:auth Change 'make_user_info' to be talloc based
Andrew Bartlett [Mon, 17 May 2010 08:10:13 +0000 (18:10 +1000)]
s3:auth Change 'make_user_info' to be talloc based

This is an ideal candidate, as it already uses a free function.  It
now uses talloc destructors to clear the passwords if required.

Andrew Bartlett

14 years agos3:auth Whitespace fixes after auth merge
Andrew Bartlett [Tue, 1 Jun 2010 11:53:42 +0000 (21:53 +1000)]
s3:auth Whitespace fixes after auth merge

14 years agos3:auth Make Samba3 use the new common struct auth_usersupplied_info
Andrew Bartlett [Tue, 1 Jun 2010 11:52:01 +0000 (21:52 +1000)]
s3:auth Make Samba3 use the new common struct auth_usersupplied_info

This common structure will make it much easier to produce an auth
module for s3compat that calls Samba4's auth subsystem.

In order the make the link work properly (and not map twice), we mark
both that we did try and map the user, as well as if we changed the
user during the mapping.

Andrew Bartlett

14 years agos4:auth Move struct auth_usersupplied_info to a common location
Andrew Bartlett [Tue, 4 May 2010 06:44:08 +0000 (16:44 +1000)]
s4:auth Move struct auth_usersupplied_info to a common location

This also changes the calling convention slightly - we should always
allocate this with talloc_zero() to allow some elements to be
optional.  Some elements may only make sense in Samba3, which I hope
will use this common structure.

Andrew Bartlett

14 years agos3:auth Rename user_info->domain -> user_info->mapped.domain_name
Andrew Bartlett [Tue, 1 Jun 2010 11:11:14 +0000 (21:11 +1000)]
s3:auth Rename user_info->domain -> user_info->mapped.domain_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

14 years agos3:auth Rename user_info->client_domain -> user_info->client.domain_name
Andrew Bartlett [Tue, 1 Jun 2010 11:08:38 +0000 (21:08 +1000)]
s3:auth Rename user_info->client_domain -> user_info->client.domain_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

14 years agos3:auth fix header comment for internal_username -> mapped.account_name
Andrew Bartlett [Tue, 1 Jun 2010 11:01:23 +0000 (21:01 +1000)]
s3:auth fix header comment for internal_username -> mapped.account_name

14 years agos3:auth Rename user_info->internal_username -> user_info->mapped.account_name
Andrew Bartlett [Tue, 1 Jun 2010 10:30:56 +0000 (20:30 +1000)]
s3:auth Rename user_info->internal_username -> user_info->mapped.account_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

14 years agos3:auth Rename user_info->smb_name -> user_info->client.account_name
Andrew Bartlett [Tue, 1 Jun 2010 10:27:03 +0000 (20:27 +1000)]
s3:auth Rename user_info->smb_name -> user_info->client.account_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

14 years agoEnsure we remove SMB2 cancel requests from the active queue
Jeremy Allison [Wed, 2 Jun 2010 23:57:08 +0000 (16:57 -0700)]
Ensure we remove SMB2 cancel requests from the active queue
now we don't remove them in the talloc destructor.

Jeremy.

14 years agoFix a crash bug found by Ira Cooper <samba@ira.wakeful.net>.
Jeremy Allison [Wed, 2 Jun 2010 23:43:31 +0000 (16:43 -0700)]
Fix a crash bug found by Ira Cooper <samba@ira.wakeful.net>.

A create call comes in, goes async (on the oplock request).
At a later time (just before a cancel request is received)
it completes, and goes through smbd_smb2_request_reply() to
send the reply to the create call.

However, the output socket queue is full, so when
tstream_writev_queue_send() is called from smbd_smb2_request_reply(),
the smb2req stays on the "being processed" queue on
sconn->smb2.requests, as only when tstream_writev_queue_send() completes
is smbd_smb2_request_writev_done() get called, which will TALLOC_FREE
the smb2req (and thus take if off the queue).

The cancel comes in, gets processed and looks through the
requests on the queue, and BANG - hits the smb2req that
has already been processed and is outgoing....

Remove the request from the queue once
tstream_writev_queue_send() is called and not in the talloc
destructor function.

Jeremy.

14 years agos3: remove unused librpc/ndr/sid.c.
Günther Deschner [Wed, 2 Jun 2010 22:09:26 +0000 (00:09 +0200)]
s3: remove unused librpc/ndr/sid.c.

Guenther

14 years agoMove to using a DATA_BLOB inside of struct aio_extra, not a char *.
Jeremy Allison [Wed, 2 Jun 2010 17:25:56 +0000 (10:25 -0700)]
Move to using a DATA_BLOB inside of struct aio_extra, not a char *.

Will make using AIO in SMB2 easier.

Jeremy.

14 years agos3-selftest: Fix blackbox smbclient s3 tests during make selftest.
Günther Deschner [Wed, 2 Jun 2010 13:35:33 +0000 (15:35 +0200)]
s3-selftest: Fix blackbox smbclient s3 tests during make selftest.

Guenther

14 years agos3: Allow previous password to be stored and use it to check tickets
Matthieu Patou [Fri, 21 May 2010 07:57:29 +0000 (11:57 +0400)]
s3: Allow previous password to be stored and use it to check tickets

This patch is to fix bug 7099. It stores the current password in the
 previous password key when the password is changed. It also check the
 user ticket against previous password.

Signed-off-by: Günther Deschner <gd@samba.org>
14 years agos3: Add vfs_linux_xfs_sgid
Volker Lendecke [Tue, 5 Jan 2010 09:42:38 +0000 (10:42 +0100)]
s3: Add vfs_linux_xfs_sgid

http://oss.sgi.com/bugzilla/show_bug.cgi?id=280 shows an old Linux XFS bug that
still exists: Under certain circumstances the SGID bit is not inherited.

14 years agos3-waf: Fix up smbclient dependencies
Kai Blin [Wed, 2 Jun 2010 09:28:54 +0000 (11:28 +0200)]
s3-waf: Fix up smbclient dependencies

14 years agos3-waf: Fixed dependencies of the the krbclient subsystem.
Kai Blin [Wed, 2 Jun 2010 09:21:18 +0000 (11:21 +0200)]
s3-waf: Fixed dependencies of the the krbclient subsystem.

14 years agos3-waf: Fixed dependencies of the the avahi subsystem.
Andreas Schneider [Wed, 2 Jun 2010 09:19:36 +0000 (11:19 +0200)]
s3-waf: Fixed dependencies of the the avahi subsystem.

14 years agos4:ldb_msg_element_compare - fix typo in comment
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 07:30:54 +0000 (09:30 +0200)]
s4:ldb_msg_element_compare - fix typo in comment

14 years agos4:lib/ldb/pyldb_util.c - add a cast to quiet a warning
Matthias Dieter Wallnöfer [Tue, 1 Jun 2010 17:59:56 +0000 (19:59 +0200)]
s4:lib/ldb/pyldb_util.c - add a cast to quiet a warning

Jelmer, please fix if it isn't correct.

14 years agoSMB2: Fix rename on Windows 7.
Ira Cooper [Wed, 2 Jun 2010 00:09:29 +0000 (17:09 -0700)]
SMB2: Fix rename on Windows 7.

This removes some code Jeremy (jra) suspected was bad.  It turns out that the
command window rename command will not work with the offending code in place.

With it removed the bug is gone, and rename works.

14 years agoDon't use sigev_value.sival_int to just store the mid, use sigev_value.sival_ptr...
Jeremy Allison [Tue, 1 Jun 2010 23:05:44 +0000 (16:05 -0700)]
Don't use sigev_value.sival_int to just store the mid, use sigev_value.sival_ptr to store the private data structure.

This allows easier use from SMB2. Ensure aio is initialized before the
aio_pending_size check else aio will never be used.

Jeremy.

14 years agos3-eventlog: try to pass RPC-EVENTLOG during make test as non-root.
Günther Deschner [Tue, 1 Jun 2010 21:02:13 +0000 (23:02 +0200)]
s3-eventlog: try to pass RPC-EVENTLOG during make test as non-root.

Guenther

14 years agos3-vfs: Send the share name instead of the path in smb_traffic_analyzer.
Holger Hetterich [Sun, 30 May 2010 16:52:17 +0000 (18:52 +0200)]
s3-vfs: Send the share name instead of the path in smb_traffic_analyzer.

In protocol v2, the name of the service should be sent instead of the
path.

Signed-off-by: Andreas Schneider <asn@samba.org>
14 years agos4-smbtorture: skip driverName and printerName DsSpooler tests for now.
Günther Deschner [Tue, 1 Jun 2010 14:48:51 +0000 (16:48 +0200)]
s4-smbtorture: skip driverName and printerName DsSpooler tests for now.

Guenther

14 years agos4-smbtorture: Make sure RPC-SPOOLSS and RPC-SPOOLSS-PRINTER pass against s3.
Günther Deschner [Tue, 1 Jun 2010 14:46:37 +0000 (16:46 +0200)]
s4-smbtorture: Make sure RPC-SPOOLSS and RPC-SPOOLSS-PRINTER pass against s3.

Printjobs are extremely fragile beasts on paused virtual printers within make
test. Very often the printq updater in the background is not fast enough, so
subsequent tests don't get to the updated information. Something to remember and
to work on later...

Guenther

14 years agolib/replace: fix some c++ build warnings in testsuite.
Günther Deschner [Tue, 1 Jun 2010 14:04:19 +0000 (16:04 +0200)]
lib/replace: fix some c++ build warnings in testsuite.

Guenther

14 years agos4: check the sacl and dacl pointers on the old sd
Anatoliy Atanasov [Tue, 1 Jun 2010 12:05:02 +0000 (15:05 +0300)]
s4: check the sacl and dacl pointers on the old sd

14 years agos3-waf: Fix the build
Kai Blin [Tue, 1 Jun 2010 13:37:40 +0000 (15:37 +0200)]
s3-waf: Fix the build

14 years agos3: remove unused prototype for lp_idmap_domains().
Michael Adam [Tue, 1 Jun 2010 13:31:17 +0000 (15:31 +0200)]
s3: remove unused prototype for lp_idmap_domains().

14 years agos3-waf: Add check for dirent.d_off member
Kai Blin [Tue, 1 Jun 2010 08:31:11 +0000 (10:31 +0200)]
s3-waf: Add check for dirent.d_off member

14 years agos3:winbindd: make sure we only call static_init_idmap once
Stefan Metzmacher [Mon, 31 May 2010 08:57:52 +0000 (10:57 +0200)]
s3:winbindd: make sure we only call static_init_idmap once

metze

Signed-off-by: Michael Adam <obnox@samba.org>