samba.git
15 years agoDo not crash in ctdbd_traverse if ctdbd is not around
Volker Lendecke [Mon, 4 May 2009 12:39:56 +0000 (14:39 +0200)]
Do not crash in ctdbd_traverse if ctdbd is not around

15 years agoIncrease debug level of "create_connection_server_info failed" message
Volker Lendecke [Mon, 4 May 2009 10:36:13 +0000 (12:36 +0200)]
Increase debug level of "create_connection_server_info failed" message

I don't think we should unconditionally send every refused connection attempt
to a share to syslog, that's where all debug level 0 messages end up.

15 years agoFix bug 6136: New AFS syscall conventions
Geza Gemes [Sun, 3 May 2009 20:13:36 +0000 (22:13 +0200)]
Fix bug 6136: New AFS syscall conventions

Haven't checked this myself, but as I've already got several reports that Samba
won't compile against current OpenAFS anymore, I just believe Geza Gemes. This
patch only affects AFS code, so it should not hurt anything else.

Volker

15 years agos3/docs: Fix typos.
Karolin Seeger [Sun, 3 May 2009 07:55:46 +0000 (09:55 +0200)]
s3/docs: Fix typos.

That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!

Karolin
(cherry picked from commit eaf949947c2eb03363c4b6f588f87b70110d6ff7)

15 years agos3/docs: Fix typo.
Karolin Seeger [Sun, 3 May 2009 07:35:55 +0000 (09:35 +0200)]
s3/docs: Fix typo.

This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!

Karolin
(cherry picked from commit 579c91581f5b6d5341a12923fe6cde377223caff)

15 years agoFix bug #6291 - force user stop working.
Jeremy Allison [Tue, 28 Apr 2009 18:07:51 +0000 (11:07 -0700)]
Fix bug #6291 - force user stop working.
A previous fix broke the invariant that *uid is always
initialized on return from create_token_from_username().
Restore it.
Jeremy.

15 years agos3:config.sub: clean some space/tab mixup that git complains about
Michael Adam [Thu, 30 Apr 2009 23:15:38 +0000 (01:15 +0200)]
s3:config.sub: clean some space/tab mixup that git complains about

Michael
(cherry picked from commit 384c1aaa8ee8879b6cc4bc34dfc4d3c9fa11667b)

15 years agos3:config.sub: replace old FSF address by the web site url.
Michael Adam [Thu, 30 Apr 2009 23:10:10 +0000 (01:10 +0200)]
s3:config.sub: replace old FSF address by the web site url.

Michael
(cherry picked from commit f3308b91d75356a83e99aade7e88d2cd1edc2042)

15 years agos3:config.sub: move to GPLv3
Michael Adam [Thu, 30 Apr 2009 23:09:13 +0000 (01:09 +0200)]
s3:config.sub: move to GPLv3

Michael
(cherry picked from commit 62a69994f252f7cc98ef12bc39a25a2ee25afb0a)

15 years agos3:update config.sub from gnu.org (2009-04-17)
Michael Adam [Thu, 30 Apr 2009 22:53:49 +0000 (00:53 +0200)]
s3:update config.sub from gnu.org (2009-04-17)

as requested in bug #6292.

This is taken from
http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD

Michael
(cherry picked from commit f81c02c3f31a4700d32aff884254fcd752797be7)

15 years agos3:config.guess: clean some whitespace/tab mixtures that git complains about
Michael Adam [Thu, 30 Apr 2009 23:13:30 +0000 (01:13 +0200)]
s3:config.guess: clean some whitespace/tab mixtures that git complains about

Michael
(cherry picked from commit faaa306c6ae7b00fa5e53321203f072776eefa0a)

15 years agos3:config.guess: replace old FSF address by the web site url.
Michael Adam [Thu, 30 Apr 2009 23:06:34 +0000 (01:06 +0200)]
s3:config.guess: replace old FSF address by the web site url.

Michael
(cherry picked from commit d230ac7b322827930de2e1b922cd4b6a597c933f)

15 years agos3:config.guess: move to GPLv3
Michael Adam [Thu, 30 Apr 2009 23:04:55 +0000 (01:04 +0200)]
s3:config.guess: move to GPLv3
(cherry picked from commit fee78294589a02090887233ad112c69d3a5bd383)

15 years agos3:update config.guess form gnu.org (version 2009-04-27)
Michael Adam [Thu, 30 Apr 2009 22:52:43 +0000 (00:52 +0200)]
s3:update config.guess form gnu.org (version 2009-04-27)

as requested in bug #6292.

This is taken from
http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD

Michael
(cherry picked from commit 1188c78f53fb7d56f4bf61c41fe635b639a311fd)

15 years agos3-netapi: Fix Bug #6309: support remote unjoining of Windows 2003 or greater.
Günther Deschner [Thu, 30 Apr 2009 21:37:26 +0000 (23:37 +0200)]
s3-netapi: Fix Bug #6309: support remote unjoining of Windows 2003 or greater.

Found by David Markey <admin@dmarkey.com>. Thanks!

Guenther
(cherry picked from commit ab4b8c9c0438bc5afca17e3ebf05dde6f98bc0aa)

15 years agowkssvcs: add WKSSVC_JOIN_FLAGS_IGNORE_UNSUPPORTED_FLAGS join flag.
Günther Deschner [Thu, 30 Apr 2009 21:36:24 +0000 (23:36 +0200)]
wkssvcs: add WKSSVC_JOIN_FLAGS_IGNORE_UNSUPPORTED_FLAGS join flag.

Guenther
(cherry picked from commit 26b9c9370ce047ecc732082b2b554ffc295ae406)

15 years agos3-printing: rework move_driver_file_to_download_area() a bit for clarity.
Günther Deschner [Thu, 30 Apr 2009 14:49:50 +0000 (16:49 +0200)]
s3-printing: rework move_driver_file_to_download_area() a bit for clarity.

Guenther
(cherry picked from commit baf78506895b8bd50433058ba0f18e1aaf8aeee5)

15 years agos3-lsa: use LSA_POLICY_MODE flags in _lsa_GetSystemAccessAccount().
Günther Deschner [Thu, 30 Apr 2009 10:30:10 +0000 (12:30 +0200)]
s3-lsa: use LSA_POLICY_MODE flags in _lsa_GetSystemAccessAccount().

Guenther
(cherry picked from commit af5a71d5280984a7d707e39fb522ecc7e1b71436)

15 years agos3-nss_wins: Fix unresolved ldb symbols in libnss_wins.so.
Günther Deschner [Thu, 30 Apr 2009 12:16:01 +0000 (14:16 +0200)]
s3-nss_wins: Fix unresolved ldb symbols in libnss_wins.so.

The objects for this module should probably be cleaned up once.

Guenther
(cherry picked from commit eee446a94841a5df97b3a47c7076ef52fb5ccdcf)

15 years agos3-spoolss: avoid referring to uid 0 in spoolss server (use sec_initial_uid() instead).
Günther Deschner [Thu, 30 Apr 2009 09:19:42 +0000 (11:19 +0200)]
s3-spoolss: avoid referring to uid 0 in spoolss server (use sec_initial_uid() instead).

Guenther
(cherry picked from commit d22965e2e596c8ad78f5330398d43d96bf564773)

15 years agos3-printing: use move_driver_file_to_download_area() to avoid code duplication.
Günther Deschner [Wed, 29 Apr 2009 23:25:23 +0000 (01:25 +0200)]
s3-printing: use move_driver_file_to_download_area() to avoid code duplication.

Guenther
(cherry picked from commit 233bfb25c9443688f74c506348b0a7b34489e1d1)

15 years agos3-printing: add move_driver_file_to_download_area().
Günther Deschner [Wed, 29 Apr 2009 23:07:31 +0000 (01:07 +0200)]
s3-printing: add move_driver_file_to_download_area().

Guenther
(cherry picked from commit a2a155bee59c7e849a492933d1ea5769e409bac5)

15 years agoRe-import the v3-3 version of str_list_make().
Volker Lendecke [Thu, 30 Apr 2009 11:37:19 +0000 (13:37 +0200)]
Re-import the v3-3 version of str_list_make().

The merged version behaves differently: "Domain Users" is parsed into two
values, as it does not look at quotes. Samba3 users depend on the ability do
say for example

valid users = "domain users"

which would not work anymore with the merged version.

Thanks to Björn Jacke for testing this!

Volker

15 years agoWHATSNEW: Add new net service subcommands to the WHATSNEW.
Karolin Seeger [Thu, 30 Apr 2009 07:33:43 +0000 (09:33 +0200)]
WHATSNEW: Add new net service subcommands to the WHATSNEW.

Karolin

15 years agoWHATSNEW: Add some WHATSNEW improvements.
Karolin Seeger [Thu, 30 Apr 2009 07:27:43 +0000 (09:27 +0200)]
WHATSNEW: Add some WHATSNEW improvements.

Karolin

15 years agoWHATSNEW: Correct WHATSNEW.
Karolin Seeger [Wed, 29 Apr 2009 12:44:59 +0000 (14:44 +0200)]
WHATSNEW: Correct WHATSNEW.

Karolin

15 years agos3-test: make it possible to find the built vlp in "make test".
Günther Deschner [Wed, 29 Apr 2009 12:29:25 +0000 (14:29 +0200)]
s3-test: make it possible to find the built vlp in "make test".

Guenther
(cherry picked from commit 3316ae9d75dfe6c7a960938c9503367880510079)

15 years agoSpecify explicit path to vlp, for those not having vlp in $PATH.
Jelmer Vernooij [Wed, 22 Apr 2009 21:54:10 +0000 (23:54 +0200)]
Specify explicit path to vlp, for those not having vlp in $PATH.
(cherry picked from commit 79177c1d36e125b08aa4d6e0e42e9a97f625b3c8)

15 years agos3/docs: Fix serveral typos.
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.

This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!

Karolin
(cherry picked from commit 3422b9c546cdd262bd747e1e737c2b6479b4d21e)

15 years agoWHATSNEW: Update WHATSNEW.
Karolin Seeger [Wed, 29 Apr 2009 10:45:39 +0000 (12:45 +0200)]
WHATSNEW: Update WHATSNEW.

Karolin

15 years agos3/docs: Remove documentation of "use kerberos keytab".
Karolin Seeger [Wed, 29 Apr 2009 10:38:28 +0000 (12:38 +0200)]
s3/docs: Remove documentation of "use kerberos keytab".

This parameter has been removed with d96248a9b4655.

Karolin
(cherry picked from commit b6eab68c20f0914cb946f05ebae2faba67f32806)

15 years agos3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
Günther Deschner [Mon, 13 Apr 2009 22:01:03 +0000 (00:01 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.

Guenther
(cherry picked from commit 6900d61d369961e0c11e590ccdc102169f21cef3)

15 years agos3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
Günther Deschner [Mon, 13 Apr 2009 22:00:37 +0000 (00:00 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.

Guenther
(cherry picked from commit 5e563ee508d0b3cc87d72ad52d777946ee0537b1)

15 years agos3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
Günther Deschner [Mon, 13 Apr 2009 21:58:59 +0000 (23:58 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.

Guenther
(cherry picked from commit d76837f6da2cf735d2b18c97f3b46ae2f04b750d)

15 years agos3-docs: document "net eventlog" in net manpage.
Günther Deschner [Wed, 29 Apr 2009 09:46:43 +0000 (11:46 +0200)]
s3-docs: document "net eventlog" in net manpage.

Guenther
(cherry picked from commit 664ff081cadd29a1e750b349ecb23e8402d977cb)

15 years agos3-net: make "net eventlog" help output a little more appropriate.
Günther Deschner [Wed, 29 Apr 2009 09:46:12 +0000 (11:46 +0200)]
s3-net: make "net eventlog" help output a little more appropriate.

Guenther
(cherry picked from commit e89cc775e660183e7126bcfa8fb37496074cf5a1)

15 years agos3:smbd/service: switch load_registry_service/shares to use loadparm routines
Michael Adam [Tue, 28 Apr 2009 23:49:53 +0000 (01:49 +0200)]
s3:smbd/service: switch load_registry_service/shares to use loadparm routines

instead of reading the registry directly with tdb and activating the
configure options by hand.

This eliminates the need for repeating checks done in loadparm.
For instance it disables registry shares without path in the server
as is the case with text based shares.

Michael
(cherry picked from commit 077bcc11257697b243916fbb02cd72b3a122b9ba)

15 years agos3:loadparm: refactor process_registry_service out or process_registry_globals
Michael Adam [Tue, 28 Apr 2009 23:31:03 +0000 (01:31 +0200)]
s3:loadparm: refactor process_registry_service out or process_registry_globals

Michael
(cherry picked from commit fb3b6576127ce837ac711e87c293d1f4cf97473c)

15 years agosamr: fix samr_ConnectVersion enum which is 32bit not 16bit.
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
samr: fix samr_ConnectVersion enum which is 32bit not 16bit.

Volker, please check.
Rafal, haven't we seen this in your tests at sambaxp as well ?

Guenther
(cherry picked from commit 67ca76c288eb095ae59e98927317d51c96c89551)

15 years agosvcctl: Fix IDL for svcctl_StartServiceW().
Günther Deschner [Tue, 28 Apr 2009 23:49:26 +0000 (01:49 +0200)]
svcctl: Fix IDL for svcctl_StartServiceW().

Guenther
(cherry picked from commit a23fb4663df11b237e94683510d282c286bbeed6)

15 years agopm_process():raise level of debug message
Michael Adam [Tue, 28 Apr 2009 10:18:23 +0000 (12:18 +0200)]
pm_process():raise level of debug message

Michael
(cherry picked from commit 664da577f931dfd47573d3d77a95afb573fba855)

15 years agos3:loadparm: prevent infinite include nesting.
Michael Adam [Mon, 27 Apr 2009 16:10:14 +0000 (18:10 +0200)]
s3:loadparm: prevent infinite include nesting.

This introduces a hard coded MAX_INCLUDE_DEPTH of 100.
When this is exceeded, handle_include (and hence lp_load) fails.

One could of course implement a more intelligent loop detection
in the include-tree, but this would require some restructuring
of the internal loadparm housekeeping. Maybe as a second improvement
step.

Michael
(cherry picked from commit d5f2bbdc489b751331e86afae58b0d80c5fedb9c)

15 years agos3-net: make sure to call libnetapi init functions at the top of "net rpc" command.
Günther Deschner [Mon, 27 Apr 2009 12:39:02 +0000 (14:39 +0200)]
s3-net: make sure to call libnetapi init functions at the top of "net rpc" command.

Without the initialization "net rpc password" will prompt twice for passwords
and will not allow to define the name of the connection admin user.

In the long run we should probably only have one place where to initialize
libnetapi.

Kai, please check.

Guenther
(cherry picked from commit 09ec85715b0e99740156ebb7213eddd1edfea631)

15 years agos3:mark registry shares without path unavailable just as with text config
Michael Adam [Mon, 27 Apr 2009 23:24:27 +0000 (01:24 +0200)]
s3:mark registry shares without path unavailable just as with text config

This prevents users from getting access to "/" in misconfigured setups.

Michael
(cherry picked from commit d16e40b5ef9add630d027ff92e440c44bfb88ef0)

15 years agoFix annoying debug messages when no snapshots are used
Volker Lendecke [Tue, 28 Apr 2009 09:16:19 +0000 (11:16 +0200)]
Fix annoying debug messages when no snapshots are used

Not being able to open the shadow copy directory is the same as having no
shadow copy support at all. The VFS module should in this case not log with
debug level 0 and set ENOSYS to indicate "no shadow copies used" to the higher
levels.

15 years agos3-svcctl: Fix crash in _svcctl_EnumServicesStatusW().
Günther Deschner [Mon, 27 Apr 2009 23:08:31 +0000 (01:08 +0200)]
s3-svcctl: Fix crash in _svcctl_EnumServicesStatusW().

The resume handle is a unique pointer, always check before dereference.

Guenther
(cherry picked from commit dd33abf649f4e1479365a2ccc2b41134270ff4ac)

15 years agos3-svcctl: indicate that the spooler is already running if it does.
Günther Deschner [Tue, 21 Apr 2009 14:18:51 +0000 (16:18 +0200)]
s3-svcctl: indicate that the spooler is already running if it does.

Guenther
(cherry picked from commit 16b2f4b55a80314aa733dd7f23543c1c3926223c)

15 years agos3-svcctl: fix _svcctl_ControlService.
Günther Deschner [Fri, 10 Apr 2009 19:39:45 +0000 (21:39 +0200)]
s3-svcctl: fix _svcctl_ControlService.

Guenther
(cherry picked from commit aa26bdd71969610a4b6a5bdfdd735a1dab31a12c)

15 years agos4-smbtorture: add test_ControlService() to RPC-SVCCTL.
Günther Deschner [Fri, 10 Apr 2009 19:10:07 +0000 (21:10 +0200)]
s4-smbtorture: add test_ControlService() to RPC-SVCCTL.

Guenther
(cherry picked from commit a263eaca499cf2b8a89c3ab04c6ef5e7e9aea396)

15 years agos4-smbtorture: add test_StartServiceW() to RPC-SVCCTL.
Günther Deschner [Fri, 10 Apr 2009 18:55:10 +0000 (20:55 +0200)]
s4-smbtorture: add test_StartServiceW() to RPC-SVCCTL.

Guenther
(cherry picked from commit f926a4e390e7108dad36ecfffaddb628b23436c0)

15 years agos4-smbtorture: change default service to spooler in RPC-SVCCTL.
Günther Deschner [Mon, 20 Apr 2009 14:49:01 +0000 (16:49 +0200)]
s4-smbtorture: change default service to spooler in RPC-SVCCTL.

Guenther
(cherry picked from commit ae5dd1219a14e939cb1e3674e6daba7885cc9d51)

15 years agoѕ3/configure: fix regexp for ld version recognition
Björn Jacke [Sat, 28 Mar 2009 00:21:25 +0000 (01:21 +0100)]
ѕ3/configure: fix regexp for ld version recognition

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
(cherry picked from commit 740c2c4366badc62d017881c9484ee5153b62f94)

15 years agos3-idmap: Fix bug #6286: Call init function for builtin idmap modules before probing...
Günther Deschner [Fri, 24 Apr 2009 08:02:06 +0000 (10:02 +0200)]
s3-idmap: Fix bug #6286: Call init function for builtin idmap modules before probing for them as shared modules.

idmap-gurus of the world, please check.

Guenther
(cherry picked from commit 67588ca80d654183b8b7b062b9660a506a825f94)

15 years agoRevert "Do not use the file system GET_REAL_FILENAME for mangled names"
Volker Lendecke [Thu, 23 Apr 2009 12:56:55 +0000 (14:56 +0200)]
Revert "Do not use the file system GET_REAL_FILENAME for mangled names"

This reverts commit c8cc6da0ab4441ce7b22cf00eed05290e91530c4.

15 years agoFix coverity #901 - uninitialized data.
Jeremy Allison [Thu, 23 Apr 2009 09:51:55 +0000 (02:51 -0700)]
Fix coverity #901 - uninitialized data.
Jeremy.

15 years agoFix Coverity ID 626: DEADCODE
Volker Lendecke [Thu, 23 Apr 2009 09:05:49 +0000 (11:05 +0200)]
Fix Coverity ID 626: DEADCODE

15 years agoFix Coverity ID 628, Andrew B., please check!
Volker Lendecke [Thu, 23 Apr 2009 08:49:41 +0000 (10:49 +0200)]
Fix Coverity ID 628, Andrew B., please check!

15 years agoFix coverity #908, #909, uninitialized variable.
Jeremy Allison [Thu, 23 Apr 2009 08:47:04 +0000 (01:47 -0700)]
Fix coverity #908, #909, uninitialized variable.
Jeremy.

15 years agoFix Coverity ID 884: DEADCODE
Volker Lendecke [Thu, 23 Apr 2009 08:42:43 +0000 (10:42 +0200)]
Fix Coverity ID 884: DEADCODE

15 years agoFix coverity #910, uninitialized variable.
Jeremy Allison [Thu, 23 Apr 2009 08:38:21 +0000 (01:38 -0700)]
Fix coverity #910, uninitialized variable.
Jeremy.

15 years agos3-selftest: test wbinfo --allocate-uid/gid.
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.

Guenther
(cherry picked from commit 59fe99027d0ac972d0d74a24842d6423119c0d21)

15 years agoFix profile acls in some corner cases
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases

Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.

15 years agoAvoid duplicate aces
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces

When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.

15 years agoAdd comment explaining the previous fix.
Jeremy Allison [Wed, 22 Apr 2009 10:03:04 +0000 (03:03 -0700)]
Add comment explaining the previous fix.
Jeremy.

15 years agoFix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but...
Jeremy Allison [Wed, 22 Apr 2009 09:54:11 +0000 (02:54 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy

15 years agos3-secdesc: remove SEC_RIGHT_MAXIMUM_ALLOWED and SEC_RIGHT_SYSTEM_SECURITY.
Günther Deschner [Tue, 21 Apr 2009 11:01:29 +0000 (13:01 +0200)]
s3-secdesc: remove SEC_RIGHT_MAXIMUM_ALLOWED and SEC_RIGHT_SYSTEM_SECURITY.

We had up to three incarnations of these flags in Samba3.

Guenther
(cherry picked from commit d94bbb3167f3a18d6b8a311557f228e2977249ea)

15 years agos3-secdesc: move all winreg access bits to IDL.
Günther Deschner [Tue, 14 Apr 2009 23:30:12 +0000 (01:30 +0200)]
s3-secdesc: move all winreg access bits to IDL.

Guenther
(cherry picked from commit 38264bb3b86a3c9da941070f29ec08227c471d2b)

15 years agos3-secdesc: use SEC_FLAG_SYSTEM_SECURITY instead of SEC_RIGHT_SYSTEM_SECURITY.
Günther Deschner [Tue, 14 Apr 2009 23:19:30 +0000 (01:19 +0200)]
s3-secdesc: use SEC_FLAG_SYSTEM_SECURITY instead of SEC_RIGHT_SYSTEM_SECURITY.

Guenther
(cherry picked from commit da92e54236293460e307edd52ca7f1e20c6f23ef)

15 years agos3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHT_MAXIMUM_ALLOWED.
Günther Deschner [Tue, 14 Apr 2009 23:16:41 +0000 (01:16 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHT_MAXIMUM_ALLOWED.

Guenther
(cherry picked from commit 1bb093aea9a4c5996514b10adc39a130cc6859ba)

15 years agos3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHTS_MAXIMUM_ALLOWED.
Günther Deschner [Tue, 14 Apr 2009 23:12:13 +0000 (01:12 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHTS_MAXIMUM_ALLOWED.

Guenther
(cherry picked from commit b5bec1a6d73f5939b306e157937d027a7286163c)

15 years agoAdded ability to revert to old modules for make revert.
John H Terpstra [Mon, 20 Apr 2009 15:10:20 +0000 (10:10 -0500)]
Added ability to revert to old modules for make revert.

15 years agoDo not use the file system GET_REAL_FILENAME for mangled names
Volker Lendecke [Wed, 15 Apr 2009 11:01:09 +0000 (13:01 +0200)]
Do not use the file system GET_REAL_FILENAME for mangled names

15 years agos3-printing: use ARRAY_SIZE() macro in forms functions.
Günther Deschner [Fri, 17 Apr 2009 22:58:12 +0000 (00:58 +0200)]
s3-printing: use ARRAY_SIZE() macro in forms functions.

Guenther
(cherry picked from commit 62480385c1e551448e40b01fff8e9dee318c29c1)

15 years agos3-printing: use sec_initial_uid() instead "0" in print_access_check().
Günther Deschner [Sun, 19 Apr 2009 22:57:53 +0000 (00:57 +0200)]
s3-printing: use sec_initial_uid() instead "0" in print_access_check().

Another babystep in order to make us pass RPC-SPOOLSS.

Guenther
(cherry picked from commit d9aaf3759ac7fd6ce07a347a0138bdfb27a6f929)

15 years agos4-smbtorture: test all levels in test_GetJob().
Günther Deschner [Mon, 13 Apr 2009 21:56:59 +0000 (23:56 +0200)]
s4-smbtorture: test all levels in test_GetJob().

Guenther
(cherry picked from commit 5f0c9c57f53f9b0026b4f58f68442a72103c0d7d)

15 years agos3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
Günther Deschner [Fri, 17 Apr 2009 21:18:24 +0000 (23:18 +0200)]
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.

Also add some become_root()/unbecome_root() pairs which were missing IMHO.

Guenther
(cherry picked from commit 81b18464be170528d5e1549868bcbddbbcd60e1e)

15 years agos3-selftest: enable RPC-SPOOLSS.
Günther Deschner [Mon, 13 Apr 2009 22:01:21 +0000 (00:01 +0200)]
s3-selftest: enable RPC-SPOOLSS.

Guenther
(cherry picked from commit 6f90cdaf63b5b584c96b9ffc388c9e8df172db67)

15 years agos4-smbtorture: Skip Job pause and resume on paused printers for Samba 3 for now.
Günther Deschner [Fri, 17 Apr 2009 15:21:19 +0000 (17:21 +0200)]
s4-smbtorture: Skip Job pause and resume on paused printers for Samba 3 for now.

Guenther
(cherry picked from commit fe2828c3536eac18902a059049dd12b9b103f731)

15 years agos4-smbtorture: rework test_EnumPrinterDrivers() a little to succeed with s3.
Günther Deschner [Fri, 17 Apr 2009 15:19:38 +0000 (17:19 +0200)]
s4-smbtorture: rework test_EnumPrinterDrivers() a little to succeed with s3.

Yes, I feel dirty for this but promise to come back and fix appropriately.

Guenther
(cherry picked from commit cb9c0cefaf61cf2c03f92a212dbf6673caa755dd)

15 years agos4-smbtorture: Fix RPC-SPOOLSS-WIN for printers with a lot of jobs in the queue.
Günther Deschner [Fri, 17 Apr 2009 15:14:20 +0000 (17:14 +0200)]
s4-smbtorture: Fix RPC-SPOOLSS-WIN for printers with a lot of jobs in the queue.

Guenther
(cherry picked from commit 81253ec14623ed480905433e5bf5df7982cfbfa4)

15 years agos3:docs: document the --request-timeout option of net
Stefan Metzmacher [Fri, 3 Apr 2009 10:21:17 +0000 (12:21 +0200)]
s3:docs: document the --request-timeout option of net

metze
(cherry picked from commit cdbbc81bad5d53397bf80898cf68d8867cf64cba)

15 years agos3:net: add --request-timeout option
Stefan Metzmacher [Thu, 26 Mar 2009 19:32:55 +0000 (20:32 +0100)]
s3:net: add --request-timeout option

metze
(cherry picked from commit 257809558bfab3e45703cf8be76357596392a3ea)

15 years agos3:net_rpc: don't shutdown a cli_state passed from the caller
Stefan Metzmacher [Thu, 26 Mar 2009 19:29:24 +0000 (20:29 +0100)]
s3:net_rpc: don't shutdown a cli_state passed from the caller

This fixes a crash bug if we timeout in net rpc trustdom list.

metze
(cherry picked from commit c0dfe0cf80ee50f395912b7d6aec0d87febd34c0)

15 years agos3: make installmo and uninstallmo scripts executable
Michael Adam [Fri, 17 Apr 2009 13:53:38 +0000 (15:53 +0200)]
s3: make installmo and uninstallmo scripts executable

Michael

15 years agos3: Fix uninstallmo
Michael Adam [Fri, 17 Apr 2009 13:29:10 +0000 (15:29 +0200)]
s3: Fix uninstallmo

Michael

15 years agos3-selftest: samba 3 also passes RPC-JOIN so enable it.
Günther Deschner [Fri, 17 Apr 2009 13:13:33 +0000 (15:13 +0200)]
s3-selftest: samba 3 also passes RPC-JOIN so enable it.

Guenther
(cherry picked from commit 4f9d3400e5aa310e8071c0bb5d62ddaed1d846ee)

15 years agos3:registry: Prevent creation of keys containing the '/' character.
Michael Adam [Fri, 17 Apr 2009 09:40:17 +0000 (11:40 +0200)]
s3:registry: Prevent creation of keys containing the '/' character.

This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.

This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.

Michael

15 years agos3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().
Günther Deschner [Fri, 17 Apr 2009 09:21:20 +0000 (11:21 +0200)]
s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().

Volker, please check.

Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with
this fix).

Guenther
(cherry picked from commit 0ba833f3eedff5dec272eb71f3b09becd8707156)

15 years agos3-selftest: enable RPC-SAMR-PASSWORDS-PWDLASTSET whilte testing Samba3.
Günther Deschner [Fri, 17 Apr 2009 09:14:14 +0000 (11:14 +0200)]
s3-selftest: enable RPC-SAMR-PASSWORDS-PWDLASTSET whilte testing Samba3.

Guenther
(cherry picked from commit 490f6c418d8b1280d0a3b85773a72b2047122c12)

15 years agos4-smbtorture: disable CreateUser2 tests when running RPC-SAMR-PASSWORDS-PWDLAST
Günther Deschner [Fri, 17 Apr 2009 09:04:44 +0000 (11:04 +0200)]
s4-smbtorture: disable CreateUser2 tests when running RPC-SAMR-PASSWORDS-PWDLAST
against Samba3.

Samba 3 does not (yet) get all the ACB_flag settings right upon creation.

Guenther
(cherry picked from commit 32add69632ed4a2b877043c8df1185008516c299)

15 years agoMerge branch 'v3-4-test' of /home/jmcd/samba/git.samba.org/samba-master into 34-test
Jim McDonough [Fri, 17 Apr 2009 07:25:06 +0000 (09:25 +0200)]
Merge branch 'v3-4-test' of /home/jmcd/samba/git.samba.org/samba-master into 34-test

15 years agos3-docs: fix typo in smb.conf.5.
Günther Deschner [Thu, 16 Apr 2009 23:30:54 +0000 (01:30 +0200)]
s3-docs: fix typo in smb.conf.5.

Guenther
(cherry picked from commit 05ea8daacabe62b6c20770a8518192c44e7eb763)

15 years agos3-selftest: enable RPC-LSA-LOOKUPSIDS against samba 3.
Günther Deschner [Thu, 16 Apr 2009 23:30:16 +0000 (01:30 +0200)]
s3-selftest: enable RPC-LSA-LOOKUPSIDS against samba 3.

Guenther
(cherry picked from commit deb719a62e0909d476b9817c45a32766dc9709d7)

15 years agos4-smbtorture: add LSA-LOOKUPSIDS to verify bug #6263.
Günther Deschner [Thu, 16 Apr 2009 23:28:41 +0000 (01:28 +0200)]
s4-smbtorture: add LSA-LOOKUPSIDS to verify bug #6263.

Guenther
(cherry picked from commit c794ba71b762676c1cfe1eba40b4a254f16ad06a)

15 years agos4-smbtorture: Fix crash in RPC-LSA-LOOKUP
Günther Deschner [Thu, 16 Apr 2009 23:26:40 +0000 (01:26 +0200)]
s4-smbtorture: Fix crash in RPC-LSA-LOOKUP

Guenther
(cherry picked from commit b0a0d2a0ae16929efa392705c3d7823da16f4d55)

15 years agos3-docs: document warn_pwd_expire pam_winbind option in manpage.
Günther Deschner [Thu, 16 Apr 2009 11:03:35 +0000 (13:03 +0200)]
s3-docs: document warn_pwd_expire pam_winbind option in manpage.

Andreas, please check.

Guenther
(cherry picked from commit 5517c0bcddfbd8c877fd1f909407824553a20e7f)

15 years agoAdd torture tester to ensure we don't regress the ulogoff bug.
Jeremy Allison [Thu, 16 Apr 2009 23:21:31 +0000 (16:21 -0700)]
Add torture tester to ensure we don't regress the ulogoff bug.
Jeremy.

15 years agoFix bug found by Tim Prouty, logging off and then re-using a vuid can cause smbd to
Jeremy Allison [Thu, 16 Apr 2009 23:19:10 +0000 (16:19 -0700)]
Fix bug found by Tim Prouty, logging off and then re-using a vuid can cause smbd to
access a freed structure.
Jeremy.

15 years agoWhen doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy Allison [Thu, 16 Apr 2009 22:15:10 +0000 (15:15 -0700)]
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy.

15 years agoDon't look up local user for remote changes, even when root.
Jim McDonough [Thu, 16 Apr 2009 15:14:20 +0000 (17:14 +0200)]
Don't look up local user for remote changes, even when root.