Jeremy Allison [Tue, 23 Apr 2002 18:34:52 +0000 (18:34 +0000)]
Fix my stupid compile bug in num_files_open.
Jeremy.
Andrew Bartlett [Tue, 23 Apr 2002 04:43:44 +0000 (04:43 +0000)]
Spelling fixes from vance
Jeremy Allison [Tue, 23 Apr 2002 02:16:48 +0000 (02:16 +0000)]
Fix for a bug Jerry found with printing where a smbd connection may
be idled even with an open pipe.
Jeremy.
Jeremy Allison [Mon, 22 Apr 2002 22:44:44 +0000 (22:44 +0000)]
Ensure auth requests from the same machine are completely serialized.
NT4.x DC's require this.
Jeremy.
Gerald Carter [Mon, 22 Apr 2002 18:47:36 +0000 (18:47 +0000)]
merge from SAMBA_2_2
Christopher R. Hertel [Mon, 22 Apr 2002 03:08:33 +0000 (03:08 +0000)]
My seven-year-old daughter calls me 'Captain Pedantic'. I don't know which
is freakier... the name or the fact that a seven-year-old knows what it
means.
Small change to correct the value we place in the DGM_LENGTH field of
NBT Datagram messages. We have been counting the full datagram, but it's
fairly clear in the RFCs that we should only count the source name,
destination name, and payload. We've been overcharging by 14 bytes
(the size of the NBT DGM header).
This fix brings us in line with what Windows does, and what the RFCs
say should be done. I'm a little surprised that this didn't cause any
bugs or error messages. I guess no one actually checks this field.
Andrew Tridgell [Sat, 20 Apr 2002 07:28:46 +0000 (07:28 +0000)]
try to cope better with the take ownership operation for foreign SIDs
what we do is map to the authenticated user when the sid is unmappable
and dos filemodes are enabled
Tim Potter [Sat, 20 Apr 2002 07:17:36 +0000 (07:17 +0000)]
Return exception text if getprinter level not [0..3]
Jeremy Allison [Fri, 19 Apr 2002 21:45:02 +0000 (21:45 +0000)]
We cannot set errno=0 in any of the wrapper calls as this breaks UNIX error
returns to the client.
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 17:59:13 +0000 (17:59 +0000)]
Added Martin's lpq parse fixes from 2.2.
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 17:30:27 +0000 (17:30 +0000)]
Fix different args to sys_fcntl without going varargs....
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 17:22:32 +0000 (17:22 +0000)]
Fixed one more sendto.
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 17:10:56 +0000 (17:10 +0000)]
When opening a tdb fails - don't expect to be able to do tdb_errstr ! (Doh!).
Jeremy.
Jean-François Micouleau [Fri, 19 Apr 2002 13:41:43 +0000 (13:41 +0000)]
add NetUserEnum and NetGroupEnum lanmap API calls, untested. I don't have
anymore a SNAP/DELL NAS to test.
from Kevin Stefanik.
J.F.
Jean-François Micouleau [Fri, 19 Apr 2002 13:39:52 +0000 (13:39 +0000)]
DEBUG cleanup.
J.F.
Jeremy Allison [Fri, 19 Apr 2002 03:05:38 +0000 (03:05 +0000)]
Added sys_fcntl (not to be used everywhere). Added sys_read/sys_write
for transfer_file.
Jeremy.
Andrew Tridgell [Fri, 19 Apr 2002 03:00:29 +0000 (03:00 +0000)]
fixed trust relationships in ADS winbindd after breaking them with my BDC changes ...
Jeremy Allison [Fri, 19 Apr 2002 02:20:04 +0000 (02:20 +0000)]
Fixed sendto in oplock code.
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 02:16:54 +0000 (02:16 +0000)]
Fix oplock recvfrom.
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 02:15:10 +0000 (02:15 +0000)]
Fix send and recvfrom.
Jeremy.
Jeremy Allison [Fri, 19 Apr 2002 02:08:52 +0000 (02:08 +0000)]
First cut at fix for the EINTR problem... More needs to be done I think.
Jeremy.
Andrew Tridgell [Fri, 19 Apr 2002 00:16:18 +0000 (00:16 +0000)]
fixed a namequery bug caused by my recent string length patches
Richard Sharpe [Thu, 18 Apr 2002 18:36:17 +0000 (18:36 +0000)]
Back out the wrong changes I made yesterday ...
Andrew Tridgell [Thu, 18 Apr 2002 06:56:44 +0000 (06:56 +0000)]
fixed the fallback to a BDC for ADS connections
Andrew Tridgell [Thu, 18 Apr 2002 03:59:02 +0000 (03:59 +0000)]
nicer strndup() function
Tim Potter [Thu, 18 Apr 2002 03:35:05 +0000 (03:35 +0000)]
Started working on setprinter code.
Tim Potter [Thu, 18 Apr 2002 03:24:02 +0000 (03:24 +0000)]
make proto
Andrew Tridgell [Thu, 18 Apr 2002 02:13:55 +0000 (02:13 +0000)]
- fixed the is_mangled() interface to handle multiple components
- fixed the no-extension case of reverse mangling
Jeremy Allison [Thu, 18 Apr 2002 01:48:45 +0000 (01:48 +0000)]
Fix found by Li Shao @ HP - XP clients don't bother to set the devmode_ptr
in the SetPrinter() call - they send it in the devmode_ctr instead.
Jeremy.
Richard Sharpe [Wed, 17 Apr 2002 22:50:02 +0000 (22:50 +0000)]
Fix smbtorture so it can handle collisions etc ...
Jeremy Allison [Wed, 17 Apr 2002 21:59:55 +0000 (21:59 +0000)]
Fixed the AFP_Resource:$DATA filename creation bug.
Jeremy.
Jeremy Allison [Wed, 17 Apr 2002 17:34:38 +0000 (17:34 +0000)]
libsmb/cli_netlogon.c: Fixed confusing debug messages.
param/loadparm.c: Added missing debugs that would have helped me find a misconfiguration
I lost a day on....
Jeremy.
Jeremy Allison [Wed, 17 Apr 2002 16:58:12 +0000 (16:58 +0000)]
Fix unused warnings with deleted code.
Jeremy.
Tim Potter [Wed, 17 Apr 2002 06:43:47 +0000 (06:43 +0000)]
Fixed command line argument parsing.
Andrew Tridgell [Wed, 17 Apr 2002 05:43:05 +0000 (05:43 +0000)]
disabled the traversal of the brlock database at startup and
shutdown. I have just helped debug a very large Solaris server where
the traversal was taking so long that the clients timed out, created a
new process which in turn did a traversal!
we will need to find some other way of doing a brlock.tdb cleanup (if
its even needed at all)
Andrew Tridgell [Wed, 17 Apr 2002 02:37:46 +0000 (02:37 +0000)]
make suure we get the return value from the pull_*() functions right
for both null terminated and buffer length terminated strings
Simo Sorce [Tue, 16 Apr 2002 22:56:08 +0000 (22:56 +0000)]
sync with 2.2
Andrew Tridgell [Tue, 16 Apr 2002 22:55:39 +0000 (22:55 +0000)]
stricter conditions on termination in strings
this was a very nasty bug with filename corruption and NT4 clients. The
exact termination conditions are quite critical ...
Simo Sorce [Tue, 16 Apr 2002 22:38:04 +0000 (22:38 +0000)]
Fix incorrect zpadlen handling in fmtfp.
Thanks to Ollie Oldham <ollie.oldham@metro-optix.com> for spotting it.
few mods to make it easier to compile the tests.
addedd the "Ollie" test to the floating point ones.
Gerald Carter [Tue, 16 Apr 2002 16:52:20 +0000 (16:52 +0000)]
few fixes and regenerate
Gerald Carter [Tue, 16 Apr 2002 16:49:08 +0000 (16:49 +0000)]
merges from SAMBA_2_2
Jean-François Micouleau [Tue, 16 Apr 2002 15:49:24 +0000 (15:49 +0000)]
we did not initialise global_myname and global_myworkgroup which lead to
duplicate entries in secrets.tdb and false SID generated.
took me *hours* to understand.
J.F.
Andrew Tridgell [Tue, 16 Apr 2002 13:10:54 +0000 (13:10 +0000)]
fixed a problem with the smb_buf() macro on some compilers
Andrew Tridgell [Tue, 16 Apr 2002 12:27:54 +0000 (12:27 +0000)]
ignore a few more files
Andrew Tridgell [Tue, 16 Apr 2002 12:24:42 +0000 (12:24 +0000)]
reran configure after adding a test for strnlen()
Andrew Tridgell [Tue, 16 Apr 2002 12:07:12 +0000 (12:07 +0000)]
fixed the handling of STR_TERMINATE
Andrew Tridgell [Tue, 16 Apr 2002 10:40:23 +0000 (10:40 +0000)]
i forgot to commit these parts of the string handling patch earlier. Sorry.
Andrew Tridgell [Tue, 16 Apr 2002 06:15:28 +0000 (06:15 +0000)]
make sure we don't walk past the end of the current SMB buffer when
pulling a string
this might explain a serious filename corruption bug that Quantum QA spotted
Andrew Tridgell [Mon, 15 Apr 2002 23:48:39 +0000 (23:48 +0000)]
make sure that we leave the tree unused after disconnecting
Tim Potter [Mon, 15 Apr 2002 23:33:09 +0000 (23:33 +0000)]
Stubs for connect, domain, user, group and alias policy objects.
Wrote samr connect fn.
Gerald Carter [Mon, 15 Apr 2002 13:35:18 +0000 (13:35 +0000)]
merge from SAMBA_2_2
Andrew Bartlett [Mon, 15 Apr 2002 08:50:36 +0000 (08:50 +0000)]
Another patch from jelmer:
Doco for pdbedit and (ugly, but the best we could come up with) fix
for compiling pdbedit on some non-gcc compilers.
Andrew Bartlett
Tim Potter [Mon, 15 Apr 2002 07:29:47 +0000 (07:29 +0000)]
Skeleton for SAMR module.
Andrew Tridgell [Mon, 15 Apr 2002 06:57:17 +0000 (06:57 +0000)]
this fixes the displaying of free disk space for DOS6 clients. Win2000
changes its behaviour based on the negotiated protocol for the
SMBdskattr SMB
Andrew Tridgell [Mon, 15 Apr 2002 06:56:01 +0000 (06:56 +0000)]
better handling of DOS LANMAN2.1 protocol
Andrew Tridgell [Mon, 15 Apr 2002 04:55:37 +0000 (04:55 +0000)]
by using a prompter function we can avoid the bug in the MIT kerberos
libraries with handling blank passwords.
Tim Potter [Mon, 15 Apr 2002 04:07:13 +0000 (04:07 +0000)]
Merge ... print server permission handling fixes from HEAD.
Unit tests rock!
Tim Potter [Mon, 15 Apr 2002 01:55:57 +0000 (01:55 +0000)]
Fixed incorrect debug.
Tim Potter [Mon, 15 Apr 2002 01:11:40 +0000 (01:11 +0000)]
Added hex values as comments for the standard access rights.
Tim Potter [Sun, 14 Apr 2002 23:42:54 +0000 (23:42 +0000)]
Rename new_policy_hnd_object() to new_spoolss_policy_hnd_object()
Tim Potter [Sun, 14 Apr 2002 23:39:02 +0000 (23:39 +0000)]
Explicitly return a list in py_ntstatus_tuple() and py_werror_typle(). Not
sure whether these should really be tuples or lists.
In open_pipe_creds() raise PyExc_RuntimeError exceptions if the pipe
connect function returns an error.
Tim Potter [Sun, 14 Apr 2002 23:36:01 +0000 (23:36 +0000)]
Call PyErr_SetString instead of fprintf to stderr.
Don't clean up talloc and cli_state on close printer. They will be
destroyed in the handle dealloc function.
Tim Potter [Sun, 14 Apr 2002 23:33:31 +0000 (23:33 +0000)]
Shutdown cli_state in the dealloc function. This happens automatically
when a handle object falls out of scope.
Tim Potter [Sun, 14 Apr 2002 12:26:09 +0000 (12:26 +0000)]
Added enumerate trusted domains.
Volker Lendecke [Sun, 14 Apr 2002 12:14:52 +0000 (12:14 +0000)]
Merge from 2_2.
Volker
Tim Potter [Sun, 14 Apr 2002 11:21:25 +0000 (11:21 +0000)]
The cli_lsa_lookup_{names,sids} functions were returning useless
information when one or more of the names/sids being queried were not
resolvable. We now return a list the same length as the parameters passed
instead of an array of just the resolvable names/sids.
Tim Potter [Sun, 14 Apr 2002 11:13:49 +0000 (11:13 +0000)]
Added error string for STATUS_SOME_UNMAPPED
Tim Potter [Sun, 14 Apr 2002 10:50:32 +0000 (10:50 +0000)]
Added a status code for lsa_lookup_{sids,names} returning the fact that
only some of the entries could be resolved.
Andrew Bartlett [Sun, 14 Apr 2002 09:45:09 +0000 (09:45 +0000)]
Extra file for the tdb search code (linked list definition).
Andrew Bartlett
Andrew Bartlett [Sun, 14 Apr 2002 09:44:16 +0000 (09:44 +0000)]
Partly based on the work by mimir (Rafal Szczesniak
<mimir@diament.ists.pwr.wroc.pl>) this patch allows samba to correctly
enumerate its trusted domains - by exaimining the keys in the secrets.tdb file.
This patch has been tested with both NT4 and rpcclient/wbinfo, and adds
some extra functionality to talloc and rpc_parse to allow it to deal with
already unicode strings.
Finally, this cleans up some const warnings that were in net_rpc.c by pushing
another dash of const into the rpc client code.
Andrew Bartlett
Tim Potter [Sun, 14 Apr 2002 09:04:45 +0000 (09:04 +0000)]
New file to hold common prototypes.
Tim Potter [Sun, 14 Apr 2002 09:04:12 +0000 (09:04 +0000)]
Moved security descriptor routines into their own file.
Tim Potter [Sun, 14 Apr 2002 09:03:05 +0000 (09:03 +0000)]
Moved function prototypes to py_common_proto.h
Tim Potter [Sun, 14 Apr 2002 09:00:13 +0000 (09:00 +0000)]
Added copyright.
Added lookup_names() and lookup_sids() functions.
Andrew Tridgell [Sun, 14 Apr 2002 09:00:05 +0000 (09:00 +0000)]
it looks like it is possible for a w2k client to send a spnego auth without sending the negotiate - try to cope
Andrew Tridgell [Sun, 14 Apr 2002 06:24:17 +0000 (06:24 +0000)]
win2000 does not check the permissions on the share directory on
tconx, so win2000 clients don't expect a permissions error in
tconx. We now match this behaviour, by only checking that the
directory exists during tconx and relying on the permissions on other
calls to protect directories
Andrew Tridgell [Sun, 14 Apr 2002 05:51:13 +0000 (05:51 +0000)]
pull_username() is a local function
Andrew Tridgell [Sun, 14 Apr 2002 05:46:23 +0000 (05:46 +0000)]
hanle the case where the win2000 username is completely different from
the pre-win2000 username
Andrew Tridgell [Sun, 14 Apr 2002 05:14:50 +0000 (05:14 +0000)]
modified the ADS backend to accept either the long or short versions
of long usernames (win2000 usernames can be longer than 20 characters)
Tim Potter [Sun, 14 Apr 2002 04:58:49 +0000 (04:58 +0000)]
Fixed debugs.
Tim Potter [Sun, 14 Apr 2002 04:57:02 +0000 (04:57 +0000)]
Fixed comment.
Tim Potter [Sun, 14 Apr 2002 04:55:18 +0000 (04:55 +0000)]
Made a comment clearer.
Tim Potter [Sun, 14 Apr 2002 01:01:39 +0000 (01:01 +0000)]
Generate proto for lsa.
Updated patch.
Tim Potter [Sun, 14 Apr 2002 01:00:49 +0000 (01:00 +0000)]
Starting work on lsa module.
Tim Potter [Sun, 14 Apr 2002 00:59:50 +0000 (00:59 +0000)]
More open_pipe_creds() refactoring.
Tim Potter [Sun, 14 Apr 2002 00:58:16 +0000 (00:58 +0000)]
Moved open_pipe_creds() function to common file.
Andrew Bartlett [Sat, 13 Apr 2002 22:52:28 +0000 (22:52 +0000)]
As always, vance looks after the grammer... :-)
Andrew Tridgell [Sat, 13 Apr 2002 13:30:06 +0000 (13:30 +0000)]
two time handling bugfixes
- the pending mtime overrides the current file time in setfileinfo
- a later wtime can override a mtime on setfileinfo
this fixes the date of file copies in win2000
Andrew Bartlett [Sat, 13 Apr 2002 11:45:33 +0000 (11:45 +0000)]
Fix the build on platforms that use our internal popt.
Andrew Bartlett [Sat, 13 Apr 2002 10:52:31 +0000 (10:52 +0000)]
Patch for arbitary smb.conf paramaters (to make the life of plugin maintainers
sane) from ab.
Attached is his e-mail to the samba-technical list, as it describes it rather
well:
Andrew Bartlett
Subject:
[PATCH] Parametrical options support for Samba 3.0
Date:
Fri, 12 Apr 2002 19:13:13 +0300
From:
Alexander Bokovoy <a.bokovoy@sam-solutions.net>
To:
samba-technical@samba.org
CC:
tridge@samba.org
Greetings!
Attached patch makes possible arbitrary options to be specified in
smb.conf and later queried from VFS modules (and other places)
without problems. Below such options are called 'parametrical options'.
Patch introduces new notation to smb.conf option's language, as discussed
today with Tridgell on @samba-technical:
TYPE: OPTION = VALUE
Colon sign is important here, it is what distinguishes parametrical
options from ones hardcoded in param/loadparm.c.
TYPE is 'option domain', OPTION is option name itself.
In order to access values of parametrical options, lp_parm_string()
function was implemented:
char *lp_parm_string(const char *servicename, const char *type, const char
*option);
This function accepts service name, type and option name, and returns
value of option or NULL if this option is underfined. Service name can be
NULL, resulting in search in 'global' section only.
If option does not exist in specified service, 'global' section is
scanned. This allows propagation of globally specified options to all
services and later overloading of the option in some services.
Caution: 'TYPE: OPTION' combination is case sensitive.
So far, testparm is able to handle parametrical options, while SWAT
can't. Thus, everyone familiar with SWAT internals is welcomed to add
parametrical options support.
Andrew Bartlett [Sat, 13 Apr 2002 10:48:25 +0000 (10:48 +0000)]
Fix the compile-bug in pdb_ldap from my last patch.
Andrew Bartlett
Andrew Bartlett [Sat, 13 Apr 2002 10:36:20 +0000 (10:36 +0000)]
Doco update from Hasch@t-online.de (Juergen Hasch)
Andrew Bartlett [Sat, 13 Apr 2002 10:32:09 +0000 (10:32 +0000)]
More updates from ctrlsoft. (Jelmer Vernooij <jelmer@nl.linux.org>)
Andrew Bartlett
Andrew Bartlett [Sat, 13 Apr 2002 09:35:52 +0000 (09:35 +0000)]
Better handling of uid/gid -> RID and RID -> uid/gid code.
All uids and gids must create valid RIDs, becouse other code expects this, and
can't handle the failure case. (ACL code in particular)
Allow admins to adjust the base of the RID algorithm, so avoid clashes with
users brought in from NT (for example).
Put all the algorithm code back in one place, so that this change is global.
Better coping with NULL sid pointers - but it still breaks a lot of stuff.
BONUS: manpage entry for new paramater :-)
counter based rids for normal users in tdbsam is disabled for the timebeing,
idra and I will work out some things here soon I hope.
Andrew Bartlett
Andrew Bartlett [Sat, 13 Apr 2002 08:16:41 +0000 (08:16 +0000)]
This is the 'multiple pdb backends' patch from ctrlsoft, aka Jelmer Vernooij
<jelmer@nl.linux.org>.
This patch also includes major rework of pdbedit to use popt, and the addition
of -i paramter (allowing the user to specify which PDBs is being
operated on) and -e to export a pdb - useful for backup and testing etc.
Use of -i and -e gets us pdb2pdb functionality for transition between backends,
much like the sam2sam in TNG.
Andrew Bartlett
Andrew Bartlett [Sat, 13 Apr 2002 03:23:08 +0000 (03:23 +0000)]
Make our atomic increment code actually do this during its first/second run.
The previous code would return the same value for both the initial and second
call, only incrementing on later calls.
Andrew Bartlett
Jeremy Allison [Sat, 13 Apr 2002 02:24:07 +0000 (02:24 +0000)]
Tidy up winbindd debug. Added Bill Moran's hide unreadable fix.
Jeremy.
Andrew Tridgell [Sat, 13 Apr 2002 00:58:04 +0000 (00:58 +0000)]
when background printing wasn't enabled printing was completely broken
as the pid was 0
Andrew Tridgell [Fri, 12 Apr 2002 12:52:18 +0000 (12:52 +0000)]
fixed the display of the 'size on disk' property of files from w2k.
Andrew Bartlett [Fri, 12 Apr 2002 08:22:50 +0000 (08:22 +0000)]
Remove : from the list seperators, as this is used to seperate out components
in the passdb module selection (after the : you have the options).
Andrew Bartlett