Volker Lendecke [Sun, 14 Mar 2004 10:24:19 +0000 (10:24 +0000)]
Add and delete aliases via srv_samr_nt. For that I added a RID allocation call
to winbindd. idmap_allocate_rid wants information about whether this will be a
user or a group, I did not export this to the winbind interface.
The reason for idmap to get that info is to keep consistent with the
algorithmic convention to alloc only even rids for users and odd rids for
groups. I'm not fully convinced that this really gains us anything. Any real
good arguments?
Volker
Volker Lendecke [Sun, 14 Mar 2004 07:16:05 +0000 (07:16 +0000)]
When trying to remove a user from a group, winbind should be informed
about the user and group...
Volker
Tim Potter [Sun, 14 Mar 2004 03:47:55 +0000 (03:47 +0000)]
Merge from 3.0
Volker Lendecke [Sat, 13 Mar 2004 17:57:24 +0000 (17:57 +0000)]
Make alias membership maintainable via net rpc group add/delmem. Alias
creation and deletion still has to be done as well as a 'net alias' command.
Volker
Volker Lendecke [Sat, 13 Mar 2004 17:38:07 +0000 (17:38 +0000)]
Rest of my winbindd_passdb alias support
Volker Lendecke [Sat, 13 Mar 2004 17:35:47 +0000 (17:35 +0000)]
Add alias support to winbindd_passdb. Sorry, Simo, this does not leave too
much of your winbindd_passdb, users are currently not provided by that, only
aliases. Currently the code to maintain that stuff is not yet in, this will be
next, see my next posting to samba-technical.
Volker
Volker Lendecke [Sat, 13 Mar 2004 16:43:25 +0000 (16:43 +0000)]
Remove the prototype for alias support in winbind again. This will be
replaced by a winbindd_passdb.c checkin soon.
Volker
Volker Lendecke [Sat, 13 Mar 2004 16:30:39 +0000 (16:30 +0000)]
Add find_alias, create_alias, delete_alias, get_aliasinfo, set_aliasinfo and
enum_aliases to passdb. create and delete are not yet filled, you have to do
this with net groupmap and net idmap restore.
Volker
Jeremy Allison [Sat, 13 Mar 2004 02:47:19 +0000 (02:47 +0000)]
Ensure we don't truncate strcmps to nstring anymore...
Jeremy.
Jeremy Allison [Sat, 13 Mar 2004 02:16:26 +0000 (02:16 +0000)]
Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
Jeremy Allison [Sat, 13 Mar 2004 00:28:55 +0000 (00:28 +0000)]
First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.
Christopher R. Hertel [Fri, 12 Mar 2004 20:27:23 +0000 (20:27 +0000)]
Bug report 1079 and fix both from Bert Driehuis.
This is an odd corner case having to do with <1C> group names (DC names).
<1C> group names are called (by MS) "Internet Special Groups", which means
that Microsoft's WINS servers will attempt to handle these names in
something approximating an RFC1001/1002 compliant manner.
The problem being reported here is this: If an initial registration sent
by one of the group members is lost (network error, whatever) then
subsequent refreshes from that particular machine will also fail. This
only happens if the name is already active (because of other group
members).
In most cases, we (and MS) handle refreshes as registrations if the name
is not in the database. In this situation, we missed the corner case.
Bert's fix adds an 'else if' that catches the situation in which a refresh
for an unlisted IP of an active <1C> group name is received. The refresh
is simply handled as a registration when this happens.
[Note: Committing in HEAD. I am writing some tools to do registrations
and refreshes so that I can test this. I don't have an NT Domain
for testing so I'm going to have to fudge. This fix is small (I
cleaned up some Debug messages and comments in addition to the fix)
and if you want to test it with 3.0.x you can just copy the HEAD
version into your 3.0.x tree and recompile.]
Jeremy Allison [Fri, 12 Mar 2004 20:24:07 +0000 (20:24 +0000)]
Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
when mangled names are turned off.
Jeremy.
Alexander Bokovoy [Fri, 12 Mar 2004 14:28:14 +0000 (14:28 +0000)]
Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
Alexander Bokovoy [Fri, 12 Mar 2004 12:58:49 +0000 (12:58 +0000)]
Fix build after Jeremy -- yet another place where convert_string() wasn't updated
Alexander Bokovoy [Fri, 12 Mar 2004 11:29:13 +0000 (11:29 +0000)]
Fix string overflow due to wrong size calculation
Jeremy Allison [Fri, 12 Mar 2004 01:43:23 +0000 (01:43 +0000)]
Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.
Jeremy Allison [Thu, 11 Mar 2004 23:02:52 +0000 (23:02 +0000)]
Fix bug introduced by Jim (touche :-) :-) - use new smbldap_get_single_pstring
call :-).
Jeremy.
Jeremy Allison [Thu, 11 Mar 2004 22:59:58 +0000 (22:59 +0000)]
Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.
Jim McDonough [Thu, 11 Mar 2004 18:10:08 +0000 (18:10 +0000)]
Merge from 3.0. Fix munged dial in pdb_ldap
Herb Lewis [Thu, 11 Mar 2004 15:14:48 +0000 (15:14 +0000)]
add missing #ifdef HAVE_BICONV stuff
Gerald Carter [Thu, 11 Mar 2004 14:52:35 +0000 (14:52 +0000)]
BUG 1088: patch from SATOH Fumiyasu <fumiya@miraclinux.com> -- use strchr_m() for query_host (smbclient -L)
Jeremy Allison [Thu, 11 Mar 2004 00:42:36 +0000 (00:42 +0000)]
Ensure we use check_path_syntax() to pull out DFS paths.
Jeremy
Jeremy Allison [Thu, 11 Mar 2004 00:31:50 +0000 (00:31 +0000)]
Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
Jeremy.
Volker Lendecke [Wed, 10 Mar 2004 17:06:13 +0000 (17:06 +0000)]
lsa_enumaccounts lists all SIDs that have been granted privileges. Simo,
you should look at this.
Change behaviour from listing all groups to listing only BUILTIN\Administrator
Volker
Volker Lendecke [Wed, 10 Mar 2004 16:40:41 +0000 (16:40 +0000)]
Remove expanding sids from smbd, this will be done in winbindd.
Volker
Volker Lendecke [Wed, 10 Mar 2004 16:32:58 +0000 (16:32 +0000)]
Apply some const
Volker Lendecke [Wed, 10 Mar 2004 16:17:46 +0000 (16:17 +0000)]
Don't pass DOM_SIDs around when pointers are enough.
Volker
Herb Lewis [Wed, 10 Mar 2004 03:09:28 +0000 (03:09 +0000)]
another type
Jeremy Allison [Wed, 10 Mar 2004 02:38:36 +0000 (02:38 +0000)]
Moving towards getting msdfs working again (this looks like it was broken
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).
Jeremy.
Jeremy Allison [Wed, 10 Mar 2004 01:32:24 +0000 (01:32 +0000)]
Formatting reformat before I start to change anything here.
Jeremy.
Herb Lewis [Wed, 10 Mar 2004 00:52:59 +0000 (00:52 +0000)]
fix type for tag in proto file
Jeremy Allison [Tue, 9 Mar 2004 23:26:56 +0000 (23:26 +0000)]
Fix dfs referrals - don't use check_path_syntax. Also use mb char calls in
dfs code.
Jeremy.
Rafal Szczesniak [Tue, 9 Mar 2004 21:48:46 +0000 (21:48 +0000)]
Yet another '\n' termination of debug message.
rafal
Rafal Szczesniak [Tue, 9 Mar 2004 20:44:39 +0000 (20:44 +0000)]
Forgot to put some more comments.
rafal
Rafal Szczesniak [Tue, 9 Mar 2004 20:30:35 +0000 (20:30 +0000)]
1) Two new functions to trust passwords interface in passdb:
settrustpwent, gettrustpwnam
2) Implementation of another couple of these functions in tdbsam:
settrustpwent, gettrustpwnam, gettrustpwsid
3) Testing (mostly for now) usage of the interface in pdbedit
which is soon to be offline tool back again.
This is quite a new code, so many changes will be put in soon.
rafal
Rafal Szczesniak [Tue, 9 Mar 2004 18:56:28 +0000 (18:56 +0000)]
Fix to debug message lacking termination with '\n'.
rafal
Gerald Carter [Tue, 9 Mar 2004 15:29:40 +0000 (15:29 +0000)]
fix build with gcc 2.96 and --with-developer
Andrew Bartlett [Tue, 9 Mar 2004 12:37:05 +0000 (12:37 +0000)]
Commit to HEAD the updates to smb signing code that I was propsing for 3.0.
This code implements 'opportunistic signing' in our client (when the
server supports it, we will use it), and correct downgrading on both
the client and server for the 'enabled' (rather than required) signing
level.
This means that we can actually set 'server signing = yes' and not
have the world fall apart. We had a number of bugs in that code, and
it certainly looks like most of the testing was with the 'requried'
setting.
While the changes are reasonable, I'm putting this into HEAD rather
than 3.0 for the timebeing. SMB signing, like NTLMSSP, tends to have
gotchas in it :-)
(I also need to give it a workout with more than smbclient before I
move it across).
Andrew Bartlett
Andrew Bartlett [Tue, 9 Mar 2004 11:42:58 +0000 (11:42 +0000)]
Merge fixes and tests for jra's broken strstr_m() function from 3.0
STF rules! (Pity we don't use it for more stuff)
Andrew Bartlett
Jeremy Allison [Tue, 9 Mar 2004 00:17:16 +0000 (00:17 +0000)]
Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
Jeremy Allison [Mon, 8 Mar 2004 21:54:56 +0000 (21:54 +0000)]
Fix assumption about following directory sep in check_path_syntax(). We
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.
Jeremy.
Simo Sorce [Mon, 8 Mar 2004 10:41:05 +0000 (10:41 +0000)]
Do some checks about data passed to this function
Simo Sorce [Mon, 8 Mar 2004 09:52:17 +0000 (09:52 +0000)]
2 fixes to enhance readability of source code and debug messages
1 fix for a memleak
Volker Lendecke [Sun, 7 Mar 2004 08:23:06 +0000 (08:23 +0000)]
Get us a little closer to Windows LSA semantics.
A windows DC does not reply to DCNAME\\Administrator, only to
DOMAIN\\Administrator. Fix that.
Without winbind we are wrong as domain members, we should forward the request
DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that
nicely.
Volker
Volker Lendecke [Sun, 7 Mar 2004 08:17:09 +0000 (08:17 +0000)]
This might not be used a lot and might not survive for long, but at least it
should work as expected :-)
Fix wb_delgrpmember.
Volker
Tim Potter [Sun, 7 Mar 2004 01:14:35 +0000 (01:14 +0000)]
Fix typo.
Tim Potter [Sun, 7 Mar 2004 00:34:49 +0000 (00:34 +0000)]
Enclose use of fchown() with guards. Bugzilla #1155.
Tim Potter [Sat, 6 Mar 2004 23:52:54 +0000 (23:52 +0000)]
tdbdump doesn't need to #include <sys/mman.h>
Bugzilla #1154.
Jeremy Allison [Fri, 5 Mar 2004 22:32:43 +0000 (22:32 +0000)]
Several mb tidyups - getting ready to address the XXX_sub function.
Jeremy.
Gerald Carter [Fri, 5 Mar 2004 18:37:32 +0000 (18:37 +0000)]
BUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections
Gerald Carter [Fri, 5 Mar 2004 17:39:59 +0000 (17:39 +0000)]
fix compiler warning
Jelmer Vernooij [Fri, 5 Mar 2004 17:21:45 +0000 (17:21 +0000)]
Add -O (write downloaded files to stdout), based on patch from
Bas van Sisseren <bas@dnd.utwente.nl>
Jeremy Allison [Fri, 5 Mar 2004 01:37:25 +0000 (01:37 +0000)]
all_string_sub() is broken as it doesn't handle mb chars correctly (and
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.
Jeremy.
Jeremy Allison [Thu, 4 Mar 2004 18:55:35 +0000 (18:55 +0000)]
Fix my breakage of NT pipes from the previous patch (sorry). Use the
original srvstr_pull_buf() function to get the pipename not srvstr_get_path().
Jeremy.
Gerald Carter [Thu, 4 Mar 2004 18:35:05 +0000 (18:35 +0000)]
BUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppc
Gerald Carter [Thu, 4 Mar 2004 18:17:54 +0000 (18:17 +0000)]
BUG 1080: fix declaration of SMB_BIG_UINT
Volker Lendecke [Thu, 4 Mar 2004 17:59:25 +0000 (17:59 +0000)]
There's a specific error message NT_STATUS_ALIAS_EXISTS.
Volker Lendecke [Thu, 4 Mar 2004 17:50:44 +0000 (17:50 +0000)]
Another typo, sorry for samba-cvs spam :-)
Volker Lendecke [Thu, 4 Mar 2004 17:47:44 +0000 (17:47 +0000)]
Fix typo.
Volker
Jim McDonough [Thu, 4 Mar 2004 16:24:15 +0000 (16:24 +0000)]
Fix build farm, older compilers won't let you declare variables
right in the middle of the code.
I just love catching jra on stuff like this, after all the crap
I've done. :-)
Gerald Carter [Thu, 4 Mar 2004 16:00:16 +0000 (16:00 +0000)]
BUG 848: don't create winbind local users/groups that already exist in the tdb
Gerald Carter [Thu, 4 Mar 2004 15:19:00 +0000 (15:19 +0000)]
another fix for bug 761; don't default to bsd printing on linux
Jeremy Allison [Wed, 3 Mar 2004 23:14:21 +0000 (23:14 +0000)]
Added client "hardlink" commant to test doing NT rename with hard links.
Added hardlink_internals() code - UNIX extensions now use this too.
Jeremy.
Jeremy Allison [Wed, 3 Mar 2004 20:55:40 +0000 (20:55 +0000)]
Use a common function to parse all pathnames from the wire. This allows
much closer emulation of Win2k3 error return codes.
Jeremy.
Jim McDonough [Wed, 3 Mar 2004 17:44:10 +0000 (17:44 +0000)]
more usrmgr fixes: display lockout timers in minutes, not seconds, for samr 2e
Jim McDonough [Wed, 3 Mar 2004 04:23:48 +0000 (04:23 +0000)]
quick for for usrmgr. unknown_6 is really max dimension of logon hours array. need to update passdb for this.
Gerald Carter [Tue, 2 Mar 2004 18:10:53 +0000 (18:10 +0000)]
BUG 1129: patch from shiro@miraclelinux.com (Shiro Yamada) to install image files for SWAT
Jim McDonough [Tue, 2 Mar 2004 18:04:21 +0000 (18:04 +0000)]
fix typo for callback bit
Simo Sorce [Tue, 2 Mar 2004 15:34:46 +0000 (15:34 +0000)]
Let's be polite with poorer backends ;-)
Volker Lendecke [Tue, 2 Mar 2004 14:49:06 +0000 (14:49 +0000)]
This adds winbind-generated groups showing up in 'getent group'. It is not
very efficient though, it only does one group at a time. Needs improving, but
the structures are not particularly easy to set up, so check in the basically
working part for others to review.
I'm close to saying that I would like to remove aliases from general group
mapping. These can not be reflected correctly in /etc/group, winbind could do
a better job here.
And having aliases only on machines with nss_winbind at least for me is not a
too severe limitation.
Comments?
Volker
Gerald Carter [Tue, 2 Mar 2004 14:29:01 +0000 (14:29 +0000)]
allow the 'printing' parameter to be set on a per share basis.
The problem was that the current_printif struct was set during
print_backend_init() based on the 'printcap name'. So you could
not use cups and then override the setting for a specific printer
by setting 'printing = bsd' (a common setup for pdf generation
print services.
There is a subtle change in behavior in that the print
interface functions are selecting on the basis of lp_printing()
and not lp_printcap_name(), but the new behavior seems more
intuitive IMHO.
Volker Lendecke [Tue, 2 Mar 2004 14:19:44 +0000 (14:19 +0000)]
Idra, your privileges patch allowed login only with tdbsam. The problem is
that pdb_default_get_privilege_set returns NOT_IMPLEMENTED and not a privilege
set that does not grant anything. I don't really understand privileges yet, so
work around that by not failing if pdb_get_privilege_set fails.
Volker
Simo Sorce [Tue, 2 Mar 2004 10:09:52 +0000 (10:09 +0000)]
Sorry, forgot to commit an essential piece.
Volker Lendecke [Tue, 2 Mar 2004 07:47:39 +0000 (07:47 +0000)]
Expand aliases for winbind-generated groups.
Do:
wbinfo -C alias
net groupmap set alias alias -L
net rpc group addmem alias DOMAIN\\group -S localhost -Uroot%secret
getent group alias
And hopefully the members of domain\\group show up :-)
Still have to get them to show up in 'getent group'.
Volker
Gerald Carter [Tue, 2 Mar 2004 04:19:47 +0000 (04:19 +0000)]
merging from 3.0
Gerald Carter [Mon, 1 Mar 2004 17:03:23 +0000 (17:03 +0000)]
BUG 1147; bad pointer case in get_stored_queue_info() causing seg fault
Simo Sorce [Mon, 1 Mar 2004 16:10:28 +0000 (16:10 +0000)]
Ok here it is my latest work on privileges
This patch add privilege support for samba
Currently it is implemented only for tdbsam backend but estending it to
other sam backends is straightforward.
I must make a big thank to JFM for his teachings on the matter and the
functions at the base of this work.
At thye moment only samr_create_user honours SeAddUsersPrivilege and
SeMachineAccountPrivilege to permit any user to add machines and/or users to
the server.
The command "net priv" has been provided to manipulate the privileges
database.
There are still many things to do (like support in "net rpc vampire") but
the working core is here.
Feel free to comment/extend on this work.
Of course I will deny that any bug may affect this code :-)
Simo.
This patch adds also my patch about add share command enhancements.
Volker Lendecke [Mon, 1 Mar 2004 14:59:32 +0000 (14:59 +0000)]
Fix Tim's fix for #1144. Tim, could you look at that again?
With only your fix in for example smb.conf was expected in /smb.conf...
Thanks,
Volker
Volker Lendecke [Mon, 1 Mar 2004 13:07:04 +0000 (13:07 +0000)]
When asked to delete an alias member, don't add it ...
Volker
Volker Lendecke [Mon, 1 Mar 2004 13:02:06 +0000 (13:02 +0000)]
Add aliases to winbindd_getgroups().
su - WINDOWS\\vl
now includes the locally defined aliases I'm member of.
Next will be getent group.
Volker
Tim Potter [Mon, 1 Mar 2004 01:09:13 +0000 (01:09 +0000)]
Fix bugzilla #1144 where running configure --with-fhs=anything would
turn on fhs compliant paths. Spotted by Timur Bakeyev.
Volker Lendecke [Sun, 29 Feb 2004 16:48:19 +0000 (16:48 +0000)]
Apply my experimental aliases support to HEAD. This will be a bit difficult to
merge to 3_0, as the pdb interfaces has changed a bit between the two.
This has not been tested too severly (which means it's completely broken ;-),
but I want it in for review. Feel free to revert it :-)
TODO:
make 'net groupmap' a bit more friendly for alias members.
Put that stuff into pdb_ldap.
Getting the information over to winbind. One plan without linking pdb into
winbind would be to fill group_mapping.tdb with the membership information and
have that as a cache (or use gencache.tdb?). smbd on a PDC or stand-alone
could trigger that itself, the problem is a BDC using LDAP. This needs to do
it on a regular basis. The BDC smbd needs to be informed about SAM changes
somehow...
Volker
Volker Lendecke [Sun, 29 Feb 2004 16:33:49 +0000 (16:33 +0000)]
net_rpc.c: Don't complain if [add|del]mem was successful.
srv_samr_nt.c: Correctly report that a user is not member of an alias.
Volker
Volker Lendecke [Sun, 29 Feb 2004 16:32:04 +0000 (16:32 +0000)]
Trivial commit to make 'smbdiff 3_0/source head/source' two files smaller.
Volker
Volker Lendecke [Sun, 29 Feb 2004 12:48:29 +0000 (12:48 +0000)]
Print an informative error message if trying to add/remove members from
something not a group.
Volker
Volker Lendecke [Sat, 28 Feb 2004 18:42:20 +0000 (18:42 +0000)]
Add 'net rpc group [add|del]mem' for domain groups and aliases.
Volker
Volker Lendecke [Sat, 28 Feb 2004 08:19:00 +0000 (08:19 +0000)]
Fix my fix to net rpc group list. We can certainly have more than a single
set of groups.
Volker
Jeremy Allison [Sat, 28 Feb 2004 01:53:19 +0000 (01:53 +0000)]
Can't set allocation size on directories, return correct error code on
fail if file exists and target is a directory. gentest.
Jeremy.
Jeremy Allison [Sat, 28 Feb 2004 00:56:39 +0000 (00:56 +0000)]
More gentest fixes. Fix up regression in IS_NAME_VALID and renames.
Jeremy.
Rafal Szczesniak [Fri, 27 Feb 2004 22:11:31 +0000 (22:11 +0000)]
Added copyrights I forgot about looong ago...
rafal
Rafal Szczesniak [Fri, 27 Feb 2004 21:02:00 +0000 (21:02 +0000)]
Adding ability to operate on trust passwords to pdbedit. This enables
new functionality and testing interface for new pdb functions.
Also, quite a bit of objects is being added to pdbedit in order to make
it able to find domain sid automatically (if not given explicitly).
If such amount of "wisdom" is not required to be in pdbedit, I'll move
it to 'net' which will have this new functionality, anyway.
rafal
Rafal Szczesniak [Fri, 27 Feb 2004 20:00:21 +0000 (20:00 +0000)]
Disabling GUMS (gums_tdbsam2) temporarily, to fix the build.
rafal
Tim Potter [Thu, 26 Feb 2004 22:58:18 +0000 (22:58 +0000)]
Fix for writable printerdata problem - bugzilla #1112.
Volker Lendecke [Thu, 26 Feb 2004 14:36:28 +0000 (14:36 +0000)]
That const was one too many
Volker Lendecke [Thu, 26 Feb 2004 11:34:33 +0000 (11:34 +0000)]
Implement 'net groupmap set' and 'net groupmap cleanup'.
I was rather annoyed by the net groupmap syntax, I could never get it
right.
net groupmap set "domain admins" domadm
creates a mapping,
net groupmap set "domain admins" -C "Comment" -N "newntname"
should also do what you expect.
net groupmap cleanup
solves a problem I've had two times now: Our SID changed, and a user's primary
group was mapped to a SID that is not ours. net groupmap cleanup removes all
mappings that are not from our domain sid.
Volker
Volker Lendecke [Thu, 26 Feb 2004 11:08:17 +0000 (11:08 +0000)]
And another little const
Volker Lendecke [Thu, 26 Feb 2004 10:56:41 +0000 (10:56 +0000)]
Apply some const
Volker
Jeremy Allison [Thu, 26 Feb 2004 01:30:56 +0000 (01:30 +0000)]
Interesting fact found by IFSTEST /t LockOverlappedTest...
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.
if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) && ERROR_WAS_LOCK_DENIED(status)) {
Jeremy.
Andrew Bartlett [Wed, 25 Feb 2004 23:19:17 +0000 (23:19 +0000)]
(merge from 3.0)
Fix bug in previous global_sam_sid() commit. I broke the 'read from
MACHINE.SID' file functionality.
Also, before we print out the results of 'net getlocalsid' and 'net
getdomainsid', ensure we have tried to read that file, or have
generated one.
Andrew Bartlett