metze/wireshark/wip.git
14 years ago- Add $Id: $ tags
jmayer [Wed, 23 Sep 2009 19:40:25 +0000 (19:40 +0000)]
- Add $Id: $ tags
- FindHtmlViewer.cmake: Try to add reading the name of the
  html viewer from the HTML_VIEWER environment variable (untested)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30104 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4046:
jake [Wed, 23 Sep 2009 19:14:35 +0000 (19:14 +0000)]
Fix for bug 4046:
Fix type of FIP dissector header field hf_fip_desc_map.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30103 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSmall indent fix.
stig [Wed, 23 Sep 2009 18:36:50 +0000 (18:36 +0000)]
Small indent fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30102 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDefine a global variable as static;
wmeier [Wed, 23 Sep 2009 18:20:06 +0000 (18:20 +0000)]
Define a global variable as static;
#include <stdio.h> & <stdlib.h>  not req'd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30101 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry finding gpg-error library, to improve building on OSX.
stig [Wed, 23 Sep 2009 18:15:31 +0000 (18:15 +0000)]
Try finding gpg-error library, to improve building on OSX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30100 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved setting GLIB2_LIBRARIES to GLIB_LIBRARY, to improve build on OSX.
stig [Wed, 23 Sep 2009 18:08:16 +0000 (18:08 +0000)]
Removed setting GLIB2_LIBRARIES to GLIB_LIBRARY, to improve build on OSX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30099 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry finding pixbuf and pango libraries to help building on OSX.
stig [Wed, 23 Sep 2009 18:02:15 +0000 (18:02 +0000)]
Try finding pixbuf and pango libraries to help building on OSX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30098 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange gchar foo[mm][nn] = {"xxx", "yyy", ...} to static const gchar *foo[mm] = ...
wmeier [Wed, 23 Sep 2009 17:55:37 +0000 (17:55 +0000)]
Change gchar foo[mm][nn] = {"xxx", "yyy", ...} to static const gchar *foo[mm] = {...}
Add a comment about a possible bug: some strings in array are never used ?
Do some minor reformatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30097 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBuild wiretap with cmake on OSX.
stig [Wed, 23 Sep 2009 17:53:55 +0000 (17:53 +0000)]
Build wiretap with cmake on OSX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30096 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago(Trivial) White space changes
krj [Wed, 23 Sep 2009 16:27:37 +0000 (16:27 +0000)]
(Trivial) White space changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30095 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoQuick fix for Bug #4040.
wmeier [Wed, 23 Sep 2009 16:06:39 +0000 (16:06 +0000)]
Quick fix for Bug #4040.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4040

ToDo: Fix usage of
 gchar xxx[..][..] = {"aaa", "bbb", ...};

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30094 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore fixes for OSX - might work now :-)
jmayer [Wed, 23 Sep 2009 15:56:44 +0000 (15:56 +0000)]
More fixes for OSX - might work now :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30093 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPropagate the changes to the .cnf file so they don't get lost when regenerating the...
etxrab [Wed, 23 Sep 2009 15:43:55 +0000 (15:43 +0000)]
Propagate the changes to the .cnf file so they don't get lost when regenerating the dissector.
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30092 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHopefully fix wsutil build on OSX.
jmayer [Wed, 23 Sep 2009 15:08:32 +0000 (15:08 +0000)]
Hopefully fix wsutil build on OSX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30091 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't col_clear(COL_PROTOCOL) followed by col_set_str(COL_PROTOCOL). A col_set_str...
krj [Wed, 23 Sep 2009 14:59:22 +0000 (14:59 +0000)]
Don't col_clear(COL_PROTOCOL) followed by col_set_str(COL_PROTOCOL). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30090 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse col_set_str instead of col_add_fstr/col_add_str when adding constant strings...
krj [Wed, 23 Sep 2009 14:52:01 +0000 (14:52 +0000)]
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30089 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse col_set_str instead of col_add_fstri/col_add_str when adding constant strings...
krj [Wed, 23 Sep 2009 14:43:23 +0000 (14:43 +0000)]
Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30088 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange option menu to combo box.
etxrab [Wed, 23 Sep 2009 14:30:56 +0000 (14:30 +0000)]
Change option menu to combo box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30087 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't col_clear() followed by col_set_str(). A col_set_str() will clear (replace...
krj [Wed, 23 Sep 2009 14:30:36 +0000 (14:30 +0000)]
Don't col_clear() followed by col_set_str(). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30086 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the debug code somewhat, we do not have a clist any more.
etxrab [Wed, 23 Sep 2009 13:54:43 +0000 (13:54 +0000)]
Fix the debug code somewhat, we do not have a clist any more.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30085 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBuild more plugins with cmake.
jmayer [Wed, 23 Sep 2009 04:41:14 +0000 (04:41 +0000)]
Build more plugins with cmake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30084 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago-P is no longer invalid. We use it for the 'two pass analysis'
krj [Tue, 22 Sep 2009 21:29:56 +0000 (21:29 +0000)]
-P is no longer invalid. We use it for the 'two pass analysis'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30083 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse col_set_str instead of col_add_fstr when adding constant strings to COL_INFO
krj [Tue, 22 Sep 2009 21:18:11 +0000 (21:18 +0000)]
Use col_set_str instead of col_add_fstr when adding constant strings to COL_INFO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30082 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago(Cosmetic) Reorder functions
krj [Tue, 22 Sep 2009 21:08:48 +0000 (21:08 +0000)]
(Cosmetic) Reorder functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30081 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago(Trivial) Rework a comment slightly.
wmeier [Tue, 22 Sep 2009 20:17:31 +0000 (20:17 +0000)]
(Trivial) Rework a comment slightly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30080 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix: jyoung SVN #30065; Sort order at start of new capture.
etxrab [Tue, 22 Sep 2009 20:09:04 +0000 (20:09 +0000)]
Fix: jyoung SVN #30065; Sort order at start of new capture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30079 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove unused 'offset' parameter
krj [Tue, 22 Sep 2009 20:02:51 +0000 (20:02 +0000)]
Remove unused 'offset' parameter

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30078 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- new_packet_list_resize_column() if we get an empty string from
etxrab [Tue, 22 Sep 2009 19:36:14 +0000 (19:36 +0000)]
- new_packet_list_resize_column() if we get an empty string from
 packet_list_get_widest_column_string() (no visible row) don't
change the colum width.
- packet_list_moveto_end() selection no longer needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30077 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd initial support for "two pass analysis" in tshark. This allows tshark to arrive...
krj [Tue, 22 Sep 2009 19:28:00 +0000 (19:28 +0000)]
Add initial support for "two pass analysis" in tshark. This allows tshark to arrive at the same protocol tree as the Wireshark GUI. Before this change tshark only supported a single scan over the file. This effectively means that packets cannot use data that are gathered from frames that appear after the current frame. By scanning twice we give the dissector the opportunity to make forward references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30076 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Vincent Helfre:
etxrab [Tue, 22 Sep 2009 19:15:30 +0000 (19:15 +0000)]
From Vincent Helfre:
MS network capability enhancement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4039

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30075 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSelect the first packet when doing a live capture. In the old packet list this is...
etxrab [Tue, 22 Sep 2009 18:51:33 +0000 (18:51 +0000)]
Select the first packet when doing a live capture. In the old packet list this is automatically done as the clist emits a selct-row signal.

Seting focus in new_packet_list_moveto_end() seems also to be needed to make it work properly I'm not 100% sure if it should be done differently.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30074 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename init_cap_file() to cap_file_init()
krj [Tue, 22 Sep 2009 16:53:11 +0000 (16:53 +0000)]
Rename init_cap_file() to cap_file_init()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30073 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodfilter_free() can handle a NULL pointer so don't guard against that before calling it
krj [Tue, 22 Sep 2009 16:49:26 +0000 (16:49 +0000)]
dfilter_free() can handle a NULL pointer so don't guard against that before calling it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30072 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIntroduce cap_file_add_fdata() and start using it
krj [Tue, 22 Sep 2009 16:39:48 +0000 (16:39 +0000)]
Introduce cap_file_add_fdata() and start using it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30071 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlways initialise fdata even when we don't dissect (we access some of fdatas variables)
krj [Tue, 22 Sep 2009 15:22:53 +0000 (15:22 +0000)]
Always initialise fdata even when we don't dissect (we access some of fdatas variables)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30070 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSimply some logic inside process_packet()
krj [Tue, 22 Sep 2009 15:06:52 +0000 (15:06 +0000)]
Simply some logic inside process_packet()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30069 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake frame_data_set_after_dissect() callers do the necessary checks instead
krj [Tue, 22 Sep 2009 14:50:43 +0000 (14:50 +0000)]
Make frame_data_set_after_dissect() callers do the necessary checks instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30068 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSwitch Wireshark GUI (file.c) over to using frame_data.c
krj [Tue, 22 Sep 2009 14:41:30 +0000 (14:41 +0000)]
Switch Wireshark GUI (file.c) over to using frame_data.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30067 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRefactor frame_data_init() into frame_data_set_before_dissect() and frame_data_set_af...
krj [Tue, 22 Sep 2009 14:23:20 +0000 (14:23 +0000)]
Refactor frame_data_init() into frame_data_set_before_dissect() and frame_data_set_after_dissect().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30066 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Add new_packet_list_set_sel_browse()
etxrab [Tue, 22 Sep 2009 12:39:16 +0000 (12:39 +0000)]
- Add new_packet_list_set_sel_browse()
- When scrolling to the end don't select the row.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30065 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Tue, 22 Sep 2009 06:42:10 +0000 (06:42 +0000)]
From Gerasimos Dimitriadis:
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30064 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix minor formating issues by hand(bug 4001).
etxrab [Tue, 22 Sep 2009 06:34:51 +0000 (06:34 +0000)]
Fix minor formating issues by hand(bug 4001).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30063 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix minor formating issues by hand(bug 4001).
etxrab [Tue, 22 Sep 2009 06:34:00 +0000 (06:34 +0000)]
Fix minor formating issues by hand(bug 4001).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30062 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Julian Fielding:
jake [Tue, 22 Sep 2009 05:49:15 +0000 (05:49 +0000)]
From Julian Fielding:
Function dissect_epath() expects path_length in bytes, but the value from the
packet is in words, so there's lots of *2 and /2 in those parts of the code.
In this invocation dissect_epath( tvbIOI, pi, 0, preq_info->IOILen, TRUE );
preq_info->IOILen is in words.

In six places proto_tree_add_item is used with tvb NULL and size 0 to add an
FT_UINT8/16/32 item. I think it should be replaced with proto_tree_add_uint().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30061 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure that the old packet list works with the changes introduced in r30047
krj [Tue, 22 Sep 2009 05:23:45 +0000 (05:23 +0000)]
Make sure that the old packet list works with the changes introduced in r30047

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30060 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoConstify colour source
krj [Tue, 22 Sep 2009 04:10:50 +0000 (04:10 +0000)]
Constify colour source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30059 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4034:
jake [Mon, 21 Sep 2009 21:28:11 +0000 (21:28 +0000)]
Fix for bug 4034:
Fix for missing register file and cleanup of code in register_all_py_protocols_func().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30058 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet svn properties and fix Id keyword.
jake [Mon, 21 Sep 2009 21:25:23 +0000 (21:25 +0000)]
Set svn properties and fix Id keyword.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30057 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMinor white space cleanup.
sfisher [Mon, 21 Sep 2009 20:20:02 +0000 (20:20 +0000)]
Minor white space cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30056 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBring frame_data_init() and add_packet_to_packet_list() more in sync by adding 'ref_t...
krj [Mon, 21 Sep 2009 20:17:59 +0000 (20:17 +0000)]
Bring frame_data_init() and add_packet_to_packet_list() more in sync by adding 'ref_time' handling to frame_data_init(). For tshark/rawshark this is unused because they only do a single pass through the capture file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30055 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoConstify (missed in r30051)
krj [Mon, 21 Sep 2009 20:00:29 +0000 (20:00 +0000)]
Constify (missed in r30051)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30054 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOnly set cumulative bytes after passing the display filter test
krj [Mon, 21 Sep 2009 19:48:53 +0000 (19:48 +0000)]
Only set cumulative bytes after passing the display filter test

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30053 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove 'Delta timestamp to previous captured frame' calculation inside add_packet_to_pa...
krj [Mon, 21 Sep 2009 19:30:06 +0000 (19:30 +0000)]
Move 'Delta timestamp to previous captured frame' calculation inside add_packet_to_packet_list(). This is done in order to streamline add_packet_to_packet_list() with frame_data_init(). Hopefully we can switch to frame_data_init() soon

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30052 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoStore 'color_filter' as const in 'frame_data'
krj [Mon, 21 Sep 2009 18:48:53 +0000 (18:48 +0000)]
Store 'color_filter' as const in 'frame_data'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30051 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't include header files that are not required
krj [Mon, 21 Sep 2009 18:31:58 +0000 (18:31 +0000)]
Don't include header files that are not required

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30050 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove unused 'vers' member in capture_file
krj [Mon, 21 Sep 2009 18:30:15 +0000 (18:30 +0000)]
Remove unused 'vers' member in capture_file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30049 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove unused 'pstats' member in capture_file
krj [Mon, 21 Sep 2009 18:20:01 +0000 (18:20 +0000)]
Remove unused 'pstats' member in capture_file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30048 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename capture_file.plist to capture_file.plist_start to make it consistent with...
krj [Mon, 21 Sep 2009 18:09:19 +0000 (18:09 +0000)]
Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30047 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove second (redundant) assignment to fdata->cum_bytes
krj [Mon, 21 Sep 2009 17:38:10 +0000 (17:38 +0000)]
Remove second (redundant) assignment to fdata->cum_bytes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30046 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReverse order of NEW_PACKET_LIST guard, i.e. #ifdef NEW_PACKET_LIST instead of #ifnde...
krj [Mon, 21 Sep 2009 17:32:35 +0000 (17:32 +0000)]
Reverse order of NEW_PACKET_LIST guard, i.e. #ifdef NEW_PACKET_LIST instead of #ifndef NEW_PACKET_LIST

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30045 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGuard fdata->col_text_len/fdata->col_text with NEW_PACKET_LIST
krj [Mon, 21 Sep 2009 17:12:46 +0000 (17:12 +0000)]
Guard fdata->col_text_len/fdata->col_text with NEW_PACKET_LIST

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30044 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix typo in comment
sfisher [Mon, 21 Sep 2009 17:09:15 +0000 (17:09 +0000)]
Fix typo in comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30043 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago(cosmetic change) - reset cumulative bytes together with 'first_ts' and 'prev_dis_ts'
krj [Mon, 21 Sep 2009 15:50:15 +0000 (15:50 +0000)]
(cosmetic change) - reset cumulative bytes together with 'first_ts' and 'prev_dis_ts'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30042 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocf->dfilter is only set if it's valid so assert if that's not the case
krj [Mon, 21 Sep 2009 15:38:40 +0000 (15:38 +0000)]
cf->dfilter is only set if it's valid so assert if that's not the case

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30041 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReset cumulative bytes when we open the file
krj [Mon, 21 Sep 2009 15:29:32 +0000 (15:29 +0000)]
Reset cumulative bytes when we open the file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30040 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet fdata->num up front and roll back if necessary
krj [Mon, 21 Sep 2009 15:23:33 +0000 (15:23 +0000)]
Set fdata->num up front and roll back if necessary

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30039 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoShuffle NEW_PACKET_LIST guard
krj [Mon, 21 Sep 2009 14:13:46 +0000 (14:13 +0000)]
Shuffle NEW_PACKET_LIST guard

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30038 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd unsigned int type cast
krj [Mon, 21 Sep 2009 14:01:30 +0000 (14:01 +0000)]
Add unsigned int type cast

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30037 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIntroduce a NEW_PACKET_LIST specialized version of add_packet_to_packet_list(). The...
krj [Mon, 21 Sep 2009 12:14:11 +0000 (12:14 +0000)]
Introduce a NEW_PACKET_LIST specialized version of add_packet_to_packet_list(). The old one contained too many #ifdef NEW_PACKET_LIST which reduced readability

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30036 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd initial support for DNS/SCTP.
tuexen [Mon, 21 Sep 2009 12:00:03 +0000 (12:00 +0000)]
Add initial support for DNS/SCTP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30035 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocf_change_time_formats() is not needed with new packet list.
etxrab [Mon, 21 Sep 2009 11:58:36 +0000 (11:58 +0000)]
cf_change_time_formats() is not needed with new packet list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30034 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove frame_data_init() declaration to frame_data.h
krj [Mon, 21 Sep 2009 11:26:23 +0000 (11:26 +0000)]
Move frame_data_init() declaration to frame_data.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30033 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure that we track the amount allocated when we're doling out memory from the...
krj [Mon, 21 Sep 2009 10:44:59 +0000 (10:44 +0000)]
Make sure that we track the amount allocated when we're doling out memory from the system pool. The verify pointer stuff should should now work with WIRESHARK_DEBUG_EP_NO_CHUNKS=1 and WIRESHARK_DEBUG_SE_NO_CHUNKS=1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30032 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a more verbose error printout.
etxrab [Mon, 21 Sep 2009 09:25:48 +0000 (09:25 +0000)]
Add a more verbose error printout.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30031 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd NEW_PACKET_LIST guard wrt fdata->col_text
krj [Mon, 21 Sep 2009 04:29:25 +0000 (04:29 +0000)]
Add NEW_PACKET_LIST guard wrt fdata->col_text

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30030 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCMake:
jmayer [Mon, 21 Sep 2009 00:19:07 +0000 (00:19 +0000)]
CMake:

- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30029 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Sun, 20 Sep 2009 21:54:39 +0000 (21:54 +0000)]
From Gerasimos Dimitriadis:
DTAP decoding of Notification Indicator IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4029

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30028 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix(take II):
etxrab [Sun, 20 Sep 2009 21:41:02 +0000 (21:41 +0000)]
Try to fix(take II):
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened:
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30027 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kjell Hultman:
jake [Sun, 20 Sep 2009 21:08:04 +0000 (21:08 +0000)]
From Kjell Hultman:
IEC104 Signal dissection added - not complete (only implemented what I needed for the moment).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30026 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jim Young via bug 4033:
krj [Sun, 20 Sep 2009 19:39:54 +0000 (19:39 +0000)]
From Jim Young via bug 4033:

With the "old" list if keyboard focus was initially in the details pane, the
use of the <F7>/<F8> keys will restore focus to details pane after the
prev/next move.   Without this patch "new" packet list prev/next moves simply
moves focus to summary pane.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30025 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix return type for frame_data_init()
krj [Sun, 20 Sep 2009 19:01:23 +0000 (19:01 +0000)]
Fix return type for frame_data_init()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30024 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIntroduce frame_data_cleanup() and start using it
krj [Sun, 20 Sep 2009 18:18:29 +0000 (18:18 +0000)]
Introduce frame_data_cleanup() and start using it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30023 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse frame_data_init() instead of the locally defined fill_in_fdata(), which will...
krj [Sun, 20 Sep 2009 18:02:22 +0000 (18:02 +0000)]
Use frame_data_init() instead of the locally defined fill_in_fdata(), which will be removed as part of this change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30022 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIntroduce frame_data_init() and get rid of fill_in_fdata() in tshark.c
krj [Sun, 20 Sep 2009 17:51:16 +0000 (17:51 +0000)]
Introduce frame_data_init() and get rid of fill_in_fdata() in tshark.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30021 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove verbose banner output to show_version() and tighten scope of some variables
krj [Sun, 20 Sep 2009 17:45:17 +0000 (17:45 +0000)]
Move verbose banner output to show_version() and tighten scope of some variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30020 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake cf_mark_frame() an empty stub in tshark.c. We only need it to satisfy a linker...
krj [Sun, 20 Sep 2009 16:48:52 +0000 (16:48 +0000)]
Make cf_mark_frame() an empty stub in tshark.c. We only need it to satisfy a linker dependency. Add a comment in tap-rtp-common.c indicating that is is wrong to refer to cf_mark_frame() which is only applicable for the GTK UI backend.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30019 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove unused cf_unmark_frame() function
krj [Sun, 20 Sep 2009 16:30:12 +0000 (16:30 +0000)]
Remove unused cf_unmark_frame() function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30018 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove verbose banner output to show_version() and tighten scope of some variables
krj [Sun, 20 Sep 2009 16:16:15 +0000 (16:16 +0000)]
Move verbose banner output to show_version() and tighten scope of some variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30017 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2009-09-20]
gerald [Sun, 20 Sep 2009 15:03:29 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-09-20]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30014 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOnly duplicate string the first time around, i.e. 'pinfo->fd->flags.visited == FALSE...
krj [Sun, 20 Sep 2009 13:36:16 +0000 (13:36 +0000)]
Only duplicate string the first time around, i.e. 'pinfo->fd->flags.visited == FALSE' or else we end up leaking memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30013 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse ep_verify_pointer() in col_set_str() to verify that the caller hasn't passed...
krj [Sun, 20 Sep 2009 12:09:25 +0000 (12:09 +0000)]
Use ep_verify_pointer() in col_set_str() to verify that the caller hasn't passed us something from the ephemeral pool

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30012 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd ep_verify_pointer()/se_verify_pointer() which checks whether the given pointer...
krj [Sun, 20 Sep 2009 12:02:40 +0000 (12:02 +0000)]
Add ep_verify_pointer()/se_verify_pointer() which checks whether the given pointer belongs in the seasonal/ephemeral pool.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30011 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAssert on null string in col_set_str(). This is reasonable behaviour since the caller...
krj [Sun, 20 Sep 2009 10:19:37 +0000 (10:19 +0000)]
Assert on null string in col_set_str(). This is reasonable behaviour since the caller is expeceted to pass in a constant string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30010 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove unused/dead code
krj [Sun, 20 Sep 2009 09:32:52 +0000 (09:32 +0000)]
Remove unused/dead code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30009 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake se_trees static in emem.c
krj [Sun, 20 Sep 2009 09:28:55 +0000 (09:28 +0000)]
Make se_trees static in emem.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30008 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBump version number after release of first development snapshot.
jake [Sun, 20 Sep 2009 09:19:59 +0000 (09:19 +0000)]
Bump version number after release of first development snapshot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30007 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd myself and Kovarththanan Rajaratnam as co authors.
etxrab [Sun, 20 Sep 2009 09:12:56 +0000 (09:12 +0000)]
Add myself and Kovarththanan Rajaratnam as co authors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30006 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse g_new()
krj [Sun, 20 Sep 2009 09:03:02 +0000 (09:03 +0000)]
Use g_new()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30005 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd NEW_PACKET_LIST guard
krj [Sun, 20 Sep 2009 08:51:30 +0000 (08:51 +0000)]
Add NEW_PACKET_LIST guard

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30004 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse tvb_get_ephemeral_string() to avoid memleak (should have been part of r29994.
krj [Sun, 20 Sep 2009 08:42:51 +0000 (08:42 +0000)]
Use tvb_get_ephemeral_string() to avoid memleak (should have been part of r29994.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30003 f5534014-38df-0310-8fa8-9805f1628bb7