Michael Adam [Thu, 12 Jul 2007 09:36:52 +0000 (09:36 +0000)]
r23850: Fix whitespacing in DEBUG output.
Jeremy Allison [Thu, 12 Jul 2007 00:42:09 +0000 (00:42 +0000)]
r23847: As Dr. Volker says, "A pstring a day....".
Jeremy.
Jeremy Allison [Wed, 11 Jul 2007 23:54:01 +0000 (23:54 +0000)]
r23846: Belt-and-braces on the msdfs bug. Ensure ELOOP maps
correctly.
Jeremy.
Jeremy Allison [Wed, 11 Jul 2007 23:40:14 +0000 (23:40 +0000)]
r23845: Second part of the fix for #4777. Looks like on AIX opendir
returns an errno of ELOOP for a symlink of msdfs:server\path\to\link.
Cope with this by mapping to a known error NT_STATUS_OBJECT_PATH_NOT_FOUND
that we know dfs_path_lookup should ignore.
Jeremy.
Jeremy Allison [Wed, 11 Jul 2007 22:39:11 +0000 (22:39 +0000)]
r23844: Add patch series from Volker (after review and consultation).
0001-Save-a-strdup-in-stat_cache_add.patch
0002-Use-ISDOT-and-ISDOTDOT.patch
0003-Move-fname_equal-around.patch
0004-unix_convert-pstring-dirpath-char.patch
0005-Ignore-.o-files.patch
0006-Get-rid-of-pstrings-inside-unix_convert.patch
0007-revert-pstring-unix_convert.patch
0008-Make-name-an-allocated-pstring-inside-unix_convert.patch
0009-Pass-explicit-pstring-to-mangle_check_cache.patch
0010-Don-t-overwrite-orig_path-unnecessarily.patch
0011-Defer-allocating-name.patch
0012-Make-sure-dirpath-is-always-correctly-allocated.patch
0013-Remove-one-pstring-dependency-in-unix_convert.patch
0014-Remove-more-name-pstring-dependencies.patch
0015-Hide-the-nasty-API-of-mangle_check_cache-in-mangle_c.patch
0016-name-does-not-need-to-be-pstring-size-anymore.patch
0017-Make-use-of-ISDOT-and-ISDOTDOT.patch
0018-Remove-pstring-from-stat_cache_lookup.patch
0019-Add-my-copyright.patch
To remove pstrings from statcache and unix_convert.
Jeremy.
Jeremy Allison [Wed, 11 Jul 2007 21:01:06 +0000 (21:01 +0000)]
r23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Doing a DFS traverse through a deep link could fail (not using
explorer).
Jeremy.
Günther Deschner [Wed, 11 Jul 2007 15:46:01 +0000 (15:46 +0000)]
r23842: Attempt to fix the build with LDAP.
Guenther
Günther Deschner [Wed, 11 Jul 2007 15:23:51 +0000 (15:23 +0000)]
r23841: Show all acl types when displaying a security descriptor.
Guenther
Günther Deschner [Wed, 11 Jul 2007 14:35:48 +0000 (14:35 +0000)]
r23840: Fix the build.
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:41:04 +0000 (13:41 +0000)]
r23839: Try to get the attribute name from schema GUIDs or the display name from
extended rights GUID from ad while dumping the security descriptors's aces.
This would perform much better with a guid cache, but for the rare cases where
it is used
net ads search cn=mymachine ntSecurityDescriptor -U user%pass
it should be ok for now.
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:32:57 +0000 (13:32 +0000)]
r23838: Allow to store schema and config path in ADS_STRUCT config.
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:30:38 +0000 (13:30 +0000)]
r23837: Pass ADS_STRUCT and TALLOC_CTX down to ads_disp_sd.
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:26:04 +0000 (13:26 +0000)]
r23836: Add ads_config_path() and ads_get_extended_right_name_by_guid().
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:23:56 +0000 (13:23 +0000)]
r23835: Pass down a struct GUID to ads_get_attrname_by_guid() directly.
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:21:32 +0000 (13:21 +0000)]
r23834: Allow to pass an ADS_STRUCT pointer down to the dump function callback in
libads.
Guenther
Günther Deschner [Wed, 11 Jul 2007 13:17:42 +0000 (13:17 +0000)]
r23833: Document ads_find_samaccount().
Guenther
Alexander Bokovoy [Wed, 11 Jul 2007 12:04:55 +0000 (12:04 +0000)]
r23831: Fix vfs_readahead: transparent modules should always pass through
Günther Deschner [Wed, 11 Jul 2007 10:26:02 +0000 (10:26 +0000)]
r23829: Add ads_get_attrname_by_guid().
Guenther
Michael Adam [Wed, 11 Jul 2007 10:08:17 +0000 (10:08 +0000)]
r23828: Add entry and exit debug statments to tdb_validate
at a lower debug level.
Michael
Günther Deschner [Wed, 11 Jul 2007 09:49:10 +0000 (09:49 +0000)]
r23827: Fix schema dump.
Guenther
Günther Deschner [Wed, 11 Jul 2007 09:39:08 +0000 (09:39 +0000)]
r23826: Fix gpo security filtering by matching the security descriptor ace's for the
extended apply group policy right.
Guenther
Günther Deschner [Wed, 11 Jul 2007 08:43:08 +0000 (08:43 +0000)]
r23825: Add ".." command as an alias to "cd ..".
Guenther
Günther Deschner [Wed, 11 Jul 2007 08:31:03 +0000 (08:31 +0000)]
r23824: Add ls alias for lazy typers like me.
Guenther
Volker Lendecke [Wed, 11 Jul 2007 06:18:32 +0000 (06:18 +0000)]
r23823: Memory leak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!
Volker
Michael Adam [Tue, 10 Jul 2007 23:00:04 +0000 (23:00 +0000)]
r23822: Clean some debugging output (as well in content and
amount as in source code formatting...)
Michael
Günther Deschner [Tue, 10 Jul 2007 21:04:57 +0000 (21:04 +0000)]
r23820: Display security_ace_object in LDAP security descriptors for debugging.
Guenther
Michael Adam [Tue, 10 Jul 2007 16:41:26 +0000 (16:41 +0000)]
r23819: It is currently unnecessary to pass the extended validation status
from the validating child process down to the parent though the
pipe. All the parent evaluates is the overall success, so the exit
status should do.
Michael
Günther Deschner [Tue, 10 Jul 2007 15:14:32 +0000 (15:14 +0000)]
r23818: support LDAP_SERVER_SEARCH_OPTIONS_OID in adssearch.
Guenther
Günther Deschner [Tue, 10 Jul 2007 15:13:13 +0000 (15:13 +0000)]
r23817: Dump some more guids in adssearch.pl.
Guenther
Michael Adam [Tue, 10 Jul 2007 12:34:12 +0000 (12:34 +0000)]
r23814: Fix a couple of comments and debug messages.
Volker Lendecke [Tue, 10 Jul 2007 12:22:44 +0000 (12:22 +0000)]
r23813: Remove unused global variable
Volker Lendecke [Tue, 10 Jul 2007 08:56:13 +0000 (08:56 +0000)]
r23808: Make us a bit more C++ friendly. Thanks to Constantine Vetoshev
<gepardcv@yahoo.com> for checking.
Andrew Tridgell [Tue, 10 Jul 2007 07:19:47 +0000 (07:19 +0000)]
r23804: here too
Andrew Tridgell [Tue, 10 Jul 2007 05:42:52 +0000 (05:42 +0000)]
r23802: fixed URL in XML
Andrew Tridgell [Tue, 10 Jul 2007 05:23:25 +0000 (05:23 +0000)]
r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
Andrew Tridgell [Tue, 10 Jul 2007 04:04:46 +0000 (04:04 +0000)]
r23800: LGPL is now called GNU Lesser General Public License
not GNU Library General Public License
Andrew Tridgell [Tue, 10 Jul 2007 03:52:17 +0000 (03:52 +0000)]
r23799: updated old Franklin Street FSF addresses to new URL
Andrew Tridgell [Tue, 10 Jul 2007 03:42:26 +0000 (03:42 +0000)]
r23798: updated old Temple Place FSF addresses to new URL
Andrew Tridgell [Tue, 10 Jul 2007 03:17:46 +0000 (03:17 +0000)]
r23797: started fixing old FSF addresses. Fixed pcap2nbench COPYING file
Andrew Tridgell [Tue, 10 Jul 2007 02:46:15 +0000 (02:46 +0000)]
r23795: more v2->v3 conversion
Andrew Tridgell [Tue, 10 Jul 2007 02:31:50 +0000 (02:31 +0000)]
r23794: convert more code from LGPLv2+ to LGPLv3+
Andrew Tridgell [Tue, 10 Jul 2007 02:13:59 +0000 (02:13 +0000)]
r23793: fixed incorrect v2-only licensing template for debian packaging files
Andrew Tridgell [Tue, 10 Jul 2007 01:52:05 +0000 (01:52 +0000)]
r23791: found some more v2->v3 conversions
Andrew Tridgell [Tue, 10 Jul 2007 01:44:42 +0000 (01:44 +0000)]
r23790: LGPLv3+ conversion for our LGPLv2+ library code
Andrew Tridgell [Tue, 10 Jul 2007 01:39:08 +0000 (01:39 +0000)]
r23789: more pcp files under v2-only
Andrew Tridgell [Tue, 10 Jul 2007 01:36:33 +0000 (01:36 +0000)]
r23788: the pcp Makefile is also GPLv2 only.
Andrew Tridgell [Tue, 10 Jul 2007 01:18:53 +0000 (01:18 +0000)]
r23787: Remove the pcp example code until SGI have given us approval to use it
under GPLv3
Andrew Tridgell [Tue, 10 Jul 2007 01:15:57 +0000 (01:15 +0000)]
r23786: Use linux/dqblk_xfs.h rather than a private copy of this header in the
Samba3 tree.
This is neater, plus it avoids the need to get legal approval from SGI
to use their GPLv2-only code under GPLv3.
If/when SGI legal sort things out, we could consider adding back this
header for very old systems where linux/dqblk_xfs.h is not available.
Andrew Tridgell [Tue, 10 Jul 2007 00:57:11 +0000 (00:57 +0000)]
r23785: use the GPLv3 boilerplate as recommended by the FSF and the license text
Andrew Tridgell [Tue, 10 Jul 2007 00:52:41 +0000 (00:52 +0000)]
r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
Andrew Tridgell [Tue, 10 Jul 2007 00:47:40 +0000 (00:47 +0000)]
r23783: Processing the UAS change message was causing problems on ppc64 Linux
systems. Rather than trying to fix this, it's much better just to
remove the code, as it serves no purpose at all (the message that is
generated is ignored by smbd).
This sort of parsing should really be done by PIDL generated code.
Simo Sorce [Mon, 9 Jul 2007 22:15:22 +0000 (22:15 +0000)]
r23782: I tested this against NT4 PDC, W2K Server, W2K3 Dc, and a Win XP std alone
client and they all work with this code.
Jeremy Allison [Mon, 9 Jul 2007 19:46:27 +0000 (19:46 +0000)]
r23780: Find and fix more GPL2 -> GPL3.
Jeremy.
Jeremy Allison [Mon, 9 Jul 2007 19:25:36 +0000 (19:25 +0000)]
r23779: Change from v2 or later to v3 or later.
Jeremy.
Jeremy Allison [Mon, 9 Jul 2007 18:59:33 +0000 (18:59 +0000)]
r23778: Change to GPLv3. Now to go through all internal source
and headers. Probably will be a long day.... :-).
Jeremy.
Gerald Carter [Mon, 9 Jul 2007 18:28:46 +0000 (18:28 +0000)]
r23777: Set template release note files
Gerald Carter [Mon, 9 Jul 2007 18:26:53 +0000 (18:26 +0000)]
r23776: Setting version in 3.2 branch to 3.2.1pre1-SVN
Setting version in 3.2.0 branch to 3.2.0pre1-SVN
Volker Lendecke [Mon, 9 Jul 2007 16:27:13 +0000 (16:27 +0000)]
r23773: One pstring a day...
Günther Deschner [Mon, 9 Jul 2007 16:03:00 +0000 (16:03 +0000)]
r23772: Add ads_find_samaccount() helper function.
Guenther
Günther Deschner [Mon, 9 Jul 2007 15:53:08 +0000 (15:53 +0000)]
r23771: Merge useful W_ERROR_NOT_OK_RETURN macro from samba4.
Guenther
Günther Deschner [Mon, 9 Jul 2007 15:48:17 +0000 (15:48 +0000)]
r23770: Some minor cleanups in libgpo
(including some valgrind errors, uninitialized vars, etc.)
Guenther
Michael Adam [Mon, 9 Jul 2007 15:34:46 +0000 (15:34 +0000)]
r23769: Move removal of the tdb from the generic tdb_validate function
to the caller (winbindd_validate_cache in this case).
Next, there will be a backup handling for the tdb files.
Michael
Volker Lendecke [Mon, 9 Jul 2007 14:43:36 +0000 (14:43 +0000)]
r23768: Get rid of the three global variables for the case semantics. I think
this is really not worth globals.
Jeremy, please check for 3.0.26.
Günther Deschner [Mon, 9 Jul 2007 13:31:32 +0000 (13:31 +0000)]
r23767: Add GTYPE_SECURITY_UNIVERSAL_GROUP to adsearch.pl as well.
Guenther
Günther Deschner [Mon, 9 Jul 2007 13:28:46 +0000 (13:28 +0000)]
r23766: Add GTYPE_SECURITY_UNIVERSAL_GROUP define.
Guenther
Volker Lendecke [Mon, 9 Jul 2007 13:24:31 +0000 (13:24 +0000)]
r23765: Another error-path restore_case_semantics().
Volker Lendecke [Mon, 9 Jul 2007 13:04:44 +0000 (13:04 +0000)]
r23764: Do restore_case_semantics in an error path. Jeremy, please check!
Michael Adam [Mon, 9 Jul 2007 12:59:17 +0000 (12:59 +0000)]
r23763: Fix a typo in DEBUG message.
Thanks to Karolin Seeger (ks@sernet.de)
Volker Lendecke [Mon, 9 Jul 2007 09:43:41 +0000 (09:43 +0000)]
r23761: Rename reduce_name to check_reduced_name
The function name reduce_name is misleading, making the user believe it
changes an argument.
Michael Adam [Mon, 9 Jul 2007 09:35:03 +0000 (09:35 +0000)]
r23760: Untangle use of strrchr_m and strequal and add some checks
for the validity of the given registry key name.
Michael
Volker Lendecke [Mon, 9 Jul 2007 08:45:14 +0000 (08:45 +0000)]
r23759: Fix make test -- sorry
Volker Lendecke [Mon, 9 Jul 2007 08:04:43 +0000 (08:04 +0000)]
r23758: Fix Coverity id 385
Volker Lendecke [Mon, 9 Jul 2007 08:00:50 +0000 (08:00 +0000)]
r23757: Fix Coverity id 386
Volker Lendecke [Mon, 9 Jul 2007 07:55:09 +0000 (07:55 +0000)]
r23756: Fix Coverity id 388
Volker Lendecke [Mon, 9 Jul 2007 07:51:39 +0000 (07:51 +0000)]
r23755: Fix Coverity id 384
Jeremy Allison [Mon, 9 Jul 2007 00:48:07 +0000 (00:48 +0000)]
r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>.
"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."
This isn't in shipping code.
Jeremy.
Michael Adam [Sun, 8 Jul 2007 22:01:43 +0000 (22:01 +0000)]
r23751: Call tdb_close even when validation was not successful.
Michael
Michael Adam [Sat, 7 Jul 2007 23:57:25 +0000 (23:57 +0000)]
r23750: Change the behaviour of net conf import when there is a global section
in the current registry and there is no global section in the input
file (or only global options with default values):
In that case the existing global section is now not touched. Before, it
would have been deleted and recreated empty. The new behaviour is how
other shares are treated too.
Note that since the input file is parsed by lp_load, there is currently
no way to distinguish between a section with only default parameters
and a non-existing section in net conf import.
Michael
PS: A couple of trailing white-spaces have been eliminated
and a line was broken to be not longer than 80 chars, too.
Michael Adam [Sat, 7 Jul 2007 22:33:45 +0000 (22:33 +0000)]
r23749: Simplify prototype of reg_setvalue_internal:
eliminate "type" parameter since we store only REG_SZ.
Michael
Michael Adam [Sat, 7 Jul 2007 22:29:34 +0000 (22:29 +0000)]
r23748: Clean use of talloc in import_process_service:
create a temporary talloc ctx for the function.
Michael
Michael Adam [Sat, 7 Jul 2007 22:18:54 +0000 (22:18 +0000)]
r23747: Move formatting of a parameter's value into a value string
to a function of its own. (for storing it in registry),
Eliminate the valtype variable : store everything as "sz".
Eliminate some trailing white spaces on the way.
Michael
Michael Adam [Sat, 7 Jul 2007 21:41:59 +0000 (21:41 +0000)]
r23746: Fix missing assignments to target string of asprintf in import function.
Michael
Michael Adam [Sat, 7 Jul 2007 21:33:48 +0000 (21:33 +0000)]
r23745: Fix: Check whether top subkeyname instead of whole registry key name
is equal to GLOBAL_NAME.
Michael
Michael Adam [Sat, 7 Jul 2007 20:40:59 +0000 (20:40 +0000)]
r23744: Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.
Michael
Volker Lendecke [Sat, 7 Jul 2007 09:57:27 +0000 (09:57 +0000)]
r23743: Simplify stat_cache_lookup() logic. For the history of this, see
http://article.gmane.org/gmane.network.samba.internals/32486.
Volker Lendecke [Sat, 7 Jul 2007 08:46:26 +0000 (08:46 +0000)]
r23738: Re-add commented out code snipped that got lost by accident
Jeremy Allison [Fri, 6 Jul 2007 23:07:40 +0000 (23:07 +0000)]
r23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy.
Jeremy Allison [Fri, 6 Jul 2007 21:46:43 +0000 (21:46 +0000)]
r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.
Lars Müller [Fri, 6 Jul 2007 18:49:49 +0000 (18:49 +0000)]
r23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.
Credits to Ralf Haferkamp for the discussion and help on this.
Herb Lewis [Fri, 6 Jul 2007 17:48:19 +0000 (17:48 +0000)]
r23732: removed reference to non-existent structure
Volker Lendecke [Fri, 6 Jul 2007 16:39:58 +0000 (16:39 +0000)]
r23731: Forgot one reference to inbuf
Gerald Carter [Thu, 5 Jul 2007 19:55:40 +0000 (19:55 +0000)]
r23730: Squashed commit of the following:
commit
3941269fa01038fca242a197e8d7c1f234d45ea7
Author: Gerald (Jerry) Carter <jerry@samba.org>
Date: Thu Jul 5 14:52:03 2007 -0500
Two fixes for "winbind expand groups".
(a) Update the counter for the number of new groups to resolve else
we'll only expand one group member per level and drop the rest.
(b) Don't reset the num_names counter in winbindd_ads.c:lookup_groupmem()
or we'll drop the SIDs resolved to names via cache from the resulting
list.
Jeremy Allison [Thu, 5 Jul 2007 18:28:18 +0000 (18:28 +0000)]
r23728: First part of bugfix for #4763. Limit notify responses
to client max buf size.
Jeremy.
Volker Lendecke [Thu, 5 Jul 2007 16:36:15 +0000 (16:36 +0000)]
r23727: Explicitly pass down FLAGS2 to srvstr_get_path.
Next step is to remove the bug that in the trans2 code we use the inbuf
as the base pointer to decide whether we need ucs2 alignment where we
need to use the beginning of the params buffer
Jeremy, last one for today to reviw :-)
Volker Lendecke [Thu, 5 Jul 2007 16:33:37 +0000 (16:33 +0000)]
r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
Volker Lendecke [Thu, 5 Jul 2007 16:27:47 +0000 (16:27 +0000)]
r23725: Remove get_current_mid()
Jeremy, next one to review :-)
Volker Lendecke [Thu, 5 Jul 2007 16:26:27 +0000 (16:26 +0000)]
r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.
Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.
Volker
Simo Sorce [Thu, 5 Jul 2007 13:46:47 +0000 (13:46 +0000)]
r23723: Alexander Larsson pointed me at a missing mapping in clierror.c
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.
Volker Lendecke [Thu, 5 Jul 2007 10:32:51 +0000 (10:32 +0000)]
r23722: Fix the build of the catia module
Michael Adam [Thu, 5 Jul 2007 00:12:24 +0000 (00:12 +0000)]
r23714: but now:
This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.
Michael