Karolin Seeger [Thu, 12 Mar 2009 07:31:33 +0000 (08:31 +0100)]
VERSION: Raise version number up to 3.3.2.
Karolin
Karolin Seeger [Wed, 11 Mar 2009 07:59:10 +0000 (08:59 +0100)]
WHATSNEW: Update changes.
Karolin
Jeremy Allison [Tue, 10 Mar 2009 23:53:47 +0000 (16:53 -0700)]
Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
Stefan Metzmacher [Tue, 10 Mar 2009 23:53:06 +0000 (16:53 -0700)]
s3:signing: the seqnum should only be decremented by 1 for ntcancel requests
[MS-SMB] 3.3.5.1 Receiving Any Message says that the seqnum
is incremented by only for ntcancel requests for any other
request it's by incremented by 2, even if it doesn't expect
a response.
metze
Volker Lendecke [Sun, 23 Nov 2008 07:01:33 +0000 (08:01 +0100)]
Add a vfs_preopen module to hide fs latencies
Volker Lendecke [Sat, 14 Feb 2009 12:18:28 +0000 (13:18 +0100)]
Don't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog
I think we eventually need to pass down the debuglevel here.
Volker Lendecke [Tue, 10 Mar 2009 15:08:38 +0000 (16:08 +0100)]
Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
This reverts commit
96c57d26ed790b3e94c935cc4faf5661ea43a80c.
It is REALLY, REALLY confusing that the 3_X_test build in the build farm
is 3.2 and NOT 3.3!
Volker Lendecke [Tue, 10 Mar 2009 14:39:42 +0000 (15:39 +0100)]
Revert "Fix a valgrind error / segfault in dns_register_smbd()"
This reverts commit
e47d2091136c4d870bb91b8a84eb9f6fd78eb971.
No idea why, but this causes timeouts in the build farm all over the place
Volker Lendecke [Tue, 10 Mar 2009 13:06:05 +0000 (14:06 +0100)]
Fix a valgrind error / segfault in dns_register_smbd()
Karolin Seeger [Tue, 10 Mar 2009 11:43:01 +0000 (12:43 +0100)]
WHATSNEW: Update changes.
Karolin
Andrew Tridgell [Tue, 10 Mar 2009 05:45:45 +0000 (16:45 +1100)]
fixed a bug in message handling for code the change notify code
The change notify code registered a separate message handler for each
tree connect. This registration uses the global messaging context.
The messaging code would consider a 2nd registration for the same
messaging type as being an 'update' of the handler, rather than a new
handler. It also would only call the first handler in the linked list
for a given message type when dispatching messages.
This patch changes the messaging code to allow for multiple
registrations of the same message type, and allow for multiple calls
to different messaging handler for one incoming message.
This fixes the problem with the test_notify_tcon() test that I
recently committed to the S4 smbtorture
Karolin Seeger [Tue, 10 Mar 2009 10:31:52 +0000 (11:31 +0100)]
WHATSNEW: Update changes since 3.3.1.
Karolin
Karolin Seeger [Mon, 9 Mar 2009 15:16:20 +0000 (16:16 +0100)]
s3/packaging: Fix typo in comment.
Karolin
(cherry picked from commit
c666aef471174ca5d95afcc48924325e7caded14)
Karolin Seeger [Mon, 9 Mar 2009 15:01:30 +0000 (16:01 +0100)]
s3/packaging: Package new files properly.
That is part of the fix for bug #6144.
Thanks to Diego Remolina dijuremo [at] gatech [dot] edu for reporting!
Karolin
(cherry picked from commit
a60aaf214cd94cbd793018a59da3b0ac5263e5bb)
Stefan Metzmacher [Mon, 9 Mar 2009 11:35:21 +0000 (12:35 +0100)]
s3:lib: interfaces.c isn't used in the configure tests anymore
libreplace always provides the getifaddr() function.
This fixes the build on sles8.
metze
(cherry picked from commit
1410490fe769bc79f98b4ab364685c7aed253e09)
Karolin Seeger [Fri, 6 Mar 2009 08:00:58 +0000 (09:00 +0100)]
s3/WHATSNEW: Update changes since 3.3.0.
Karolin
Jeremy Allison [Fri, 6 Mar 2009 05:51:00 +0000 (21:51 -0800)]
Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 05:04:52 +0000 (21:04 -0800)]
Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 01:17:52 +0000 (17:17 -0800)]
Fix bug #6161 - smbclient corrupts source path in tar mode
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
Jeremy Allison [Thu, 5 Mar 2009 23:16:53 +0000 (15:16 -0800)]
Last part of fix for #6154 - zfs does not honor admin users.
Jeremy.
Volker Lendecke [Thu, 5 Mar 2009 21:20:55 +0000 (22:20 +0100)]
Complete the fix for bug 6100
According to [MS-RPCE].pdf, section 2.2.2.11:
----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----
RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.
Thanks to Nick Meier <nmeier@microsoft.com>
Volker
Jeremy Allison [Thu, 5 Mar 2009 17:03:48 +0000 (09:03 -0800)]
Fix bug #6160 - Office 2007 fails saving files to a Samba mapped drive.
Confirmed by reporters.
Jeremy.
Jeremy Allison [Thu, 5 Mar 2009 01:18:12 +0000 (17:18 -0800)]
Second part of fix for #6154, ensure we return max access
if admin user.
Jeremy.
Jeremy Allison [Thu, 5 Mar 2009 00:56:45 +0000 (16:56 -0800)]
Fix bug #6154 - zfs does not honor admin users.
Jeremy.
Jeremy Allison [Wed, 4 Mar 2009 22:47:44 +0000 (14:47 -0800)]
Fix crashes when running RAW-ACLs against system with tdb ACL modules
(caused by the POSIX pathname fixes).
Jeremy.
Tim Prouty [Wed, 4 Mar 2009 00:47:48 +0000 (16:47 -0800)]
s3 passdb: Add back some useful debug statements
Originally removed in
be1dfff02d562e42a7847bd02fed8538630d3f41
Jeremy Allison [Wed, 4 Mar 2009 00:05:47 +0000 (16:05 -0800)]
Fix bug #6155 - "force group" is no longer working as expected.
We need to store the "force group" uid separately from the
conn->server_info token as we need to apply it separately also.
Volker PLEASE CHECK !
Jeremy.
Dan Sledz [Tue, 3 Mar 2009 00:42:37 +0000 (16:42 -0800)]
It appears that the first time we see a uid/gid that winbind can't map,
we end up returning the null sid instead of falling back to the legacy
code. Next time through the code we'll hit the negative cache and do
the right thing, but we still fail the first time.
If we fail the winbind id to sid mapping, call the legacy version. This
catches the case where we don't have a negative cache entry for the mapping.
This is better than returning the NULL sid to the caller.
Bo Yang [Tue, 3 Mar 2009 00:08:58 +0000 (16:08 -0800)]
More fix to initialize idmap statuses
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.
Karolin
(cherry picked from commit
2ab9d365cfceb28c1280566b6fe8ec3767e18149)
Jeremy Allison [Sat, 28 Feb 2009 21:14:54 +0000 (13:14 -0800)]
Fix bug #6082 - smbd_gpfs_getacl failed: Windows client can´t rename or
delete file (directory fix).
Jeremy.
Bo Yang [Fri, 27 Feb 2009 18:34:47 +0000 (10:34 -0800)]
Initialize the id_map status in idmap_ldap to avoid surprise
Steven Danneman [Fri, 27 Feb 2009 16:32:51 +0000 (08:32 -0800)]
s3: fix guest auth when winbindd is running
This fix is very subtle. If a server is configured with "security = share"
and "guest ok = yes" and winbindd is running authorization will fail during
tree connect.
This is due to our inability to map the guest sid S-1-5-21-X-501 to a uid
through sid_to_uid(). Winbindd is unaware of the hard coded mapping
between this sid and whatever uid the name in lp_guestaccount() is assigned.
So sid_to_uid() fails and we exit create_token_from_username() without
ever calling pdb_getsampwsid() which IS aware of the hard coded mapping.
This patch just reorganizes the code, moving sid_to_uid() down to the
block of code in which it is needed, avoiding this early failure.
Jeremy Allison [Thu, 26 Feb 2009 19:43:07 +0000 (11:43 -0800)]
Make us pass the RAW-RENAME torture test I just added.
Inside a directory, keep a file open and then renaming
the directory should fail with ACCESS_DENIED.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 22:56:49 +0000 (14:56 -0800)]
Fix more POSIX path lstat calls. Fix bug where close can return
failure if we have a pending modtime and the containing directory
of the file has been renamed (there is no POSIX "update time by
fd" call). This can't happen on Windows as the rename will fail
if there are open files beneath it. Will add a torture test
for this.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 22:50:43 +0000 (14:50 -0800)]
Use fsp->posix_open in preference if we have it.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 22:12:31 +0000 (14:12 -0800)]
Ensure ACL modules work with POSIX paths.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 21:46:46 +0000 (13:46 -0800)]
Fix use of streams modules with CIFSFS client.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 21:00:21 +0000 (13:00 -0800)]
Make test for open modes more robust against other bits.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 20:54:58 +0000 (12:54 -0800)]
Fix bug in processing of open modes in POSIX open.
Was missing case of "If file exists open. If file doesn't exist error."
Damn damn damn. CIFSFS client will have to have fallback cases
for this error for a long time.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 18:00:01 +0000 (10:00 -0800)]
Fix some NetBSD warnings.
Jeremy.
Volker Lendecke [Thu, 2 Oct 2008 01:37:52 +0000 (03:37 +0200)]
Fix bug 6124: Attempt to fix the build on IRIX
Under irix, "sa_family" is a #define to sa_union.sa_generic.sa_family2
Jeremy Allison [Wed, 25 Feb 2009 02:00:32 +0000 (18:00 -0800)]
Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
Jeremy Allison [Wed, 25 Feb 2009 01:58:14 +0000 (17:58 -0800)]
Allow set attributes on a stream fnum to be redirected to the base filename.
Fixes the new RAW-STREAMS torture test.
Jeremy.
Steve French [Tue, 24 Feb 2009 23:09:22 +0000 (17:09 -0600)]
Merge branch 'v3-3-test' of git://git.samba.org/samba into 3-3
Steve French [Tue, 24 Feb 2009 23:07:12 +0000 (17:07 -0600)]
Fix guest mounts
guest session setup, login (user id) as anonymous.
This patch is for samba bugzilla bug 4640.
Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
Tim Prouty [Tue, 24 Feb 2009 22:07:29 +0000 (14:07 -0800)]
Fix a bug that prevent core files from being created
Removed an erroneous free() that was causing the corepath to be NULL
during dump_core(). This prevented dump_core() from actually calling
abort() to create a core file. The bug was introduced in December by:
0994b094569474d47e7b98e39438829e962a27e1
Steve French [Tue, 24 Feb 2009 18:43:12 +0000 (12:43 -0600)]
cifs mount did not properly display version string when no other parameters passed in.
Acked-by: Jeff Layton <jlayton@redhat.com>
Steve French [Tue, 24 Feb 2009 17:26:56 +0000 (11:26 -0600)]
Merge branch 'v3-3-test' of git://git.samba.org/samba into 3-3
Derrell Lipman [Tue, 24 Feb 2009 14:49:21 +0000 (09:49 -0500)]
Make char* parameters const
- Use const in function signatures whenever appropriate, to help prevent
errant scribbling on users' buffers. smbc_set_credentials() always acted as
if its formal parameters were const char *, and changing the formal
declaration to specify that should not cause any change to the ABI. It is
still allowable to pass a writable buffer to a function which specifies that
it will not write to the buffer.
Derrell
Björn Jacke [Sun, 22 Feb 2009 18:46:40 +0000 (19:46 +0100)]
prefer gssapi header files from subdirectory
this fixes some compile time noise on FreeBSD 7
Karolin Seeger [Tue, 24 Feb 2009 07:37:27 +0000 (08:37 +0100)]
WHATSNEW: Update changes since 3.3.0.
Karolin
Jeremy Allison [Tue, 24 Feb 2009 00:23:42 +0000 (16:23 -0800)]
More warning fixes for Solaris.
Jeremy.
Jeremy Allison [Mon, 23 Feb 2009 23:42:52 +0000 (15:42 -0800)]
More warning fixes for Solaris.
Jeremy.
Jeremy Allison [Mon, 23 Feb 2009 23:02:52 +0000 (15:02 -0800)]
Quieten down a boatload of shadowed variable warnings on Solaris.
Makes real problems easier to spot.
Jeremy.
Karolin Seeger [Mon, 23 Feb 2009 08:46:52 +0000 (09:46 +0100)]
VERSION: Raise version number.
Karolin
Karolin Seeger [Mon, 23 Feb 2009 08:44:08 +0000 (09:44 +0100)]
WHATSNEW: Updates changes since 3.3.0.
Karolin
Björn Jacke [Sat, 21 Feb 2009 23:43:38 +0000 (00:43 +0100)]
all BSDs use this evironment variable
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
cd6ae0de52164dd6f50b3614f2511acb3eb15993)
Karolin Seeger [Mon, 23 Feb 2009 08:24:50 +0000 (09:24 +0100)]
s3/docs: Fix typo in man mount.cifs.
Thanks to Tobias Stoeckmann for reporting!
Karolin
(cherry picked from commit
09a7f93f6be66a8f2a124e49b4effe2b5863f01d)
Simo Sorce [Sun, 22 Feb 2009 06:06:28 +0000 (01:06 -0500)]
For some unknown reason ldbrename was not being built in samba3.
Jeremy Allison [Sat, 21 Feb 2009 00:40:00 +0000 (16:40 -0800)]
Change smbc_set_credentials_with_fallback() (unreleased) to use
const approptiately.
Jeremy.
Jeremy Allison [Fri, 20 Feb 2009 16:22:57 +0000 (08:22 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.
Derrell Lipman [Fri, 20 Feb 2009 15:03:55 +0000 (10:03 -0500)]
variable grouping: just my OCD desire to keep similar things together
Bo Yang [Fri, 20 Feb 2009 04:21:52 +0000 (12:21 +0800)]
Make libsmbclient work with DFS
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
Karolin Seeger [Fri, 20 Feb 2009 13:14:54 +0000 (14:14 +0100)]
s3/docs: Add hint about getfattr in man vfs_acl_xattr.
Karolin
(cherry picked from commit
27307be0f726c899c0e8a0edfdf200650037bb61)
Karolin Seeger [Fri, 20 Feb 2009 12:32:44 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_tdb.
Karolin
(cherry picked from commit
0fd1d4c0906158bab55871d53396bdc7ae533220)
Karolin Seeger [Fri, 20 Feb 2009 12:32:22 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_xattr.
Karolin
(cherry picked from commit
3b0114c0ba676dec2ece96983aff29257399f378)
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.
This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!
Karolin
(cherry picked from commit
54dbb030e2c6fed0abd0a3a89d08dad9b8a201a1)
Karolin Seeger [Fri, 20 Feb 2009 07:58:58 +0000 (08:58 +0100)]
WHATSNEW: Update changes since 3.3.0.
Karolin
Jeremy Allison [Thu, 19 Feb 2009 21:36:45 +0000 (13:36 -0800)]
Fix printf warnings found on systems where time_t <> long int.
Jeremy.
Jeremy Allison [Thu, 19 Feb 2009 21:09:45 +0000 (13:09 -0800)]
Fix printf type warning.
Jeremy.
Volker Lendecke [Thu, 19 Feb 2009 19:03:06 +0000 (20:03 +0100)]
Fix a O(n^2) algorithm in regdb_fetch_keys()
Jeremy Allison [Thu, 19 Feb 2009 19:19:10 +0000 (11:19 -0800)]
Backport the semantics of when to delete alternate data streams on a file truncate.
Needed to fully support stream semantics.
Jeremy.
Volker Lendecke [Thu, 19 Feb 2009 13:16:44 +0000 (14:16 +0100)]
Fix a buffer handling bug when adding lots of registry keys
This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)
(cherry picked from commit
36ae846d15027df5e3a02ffabb08183dad9f6517)
Günther Deschner [Thu, 19 Feb 2009 01:35:20 +0000 (02:35 +0100)]
s3-libnet: fix coverity #848 (UNINIT).
Guenther
(cherry picked from commit
e9d5405948e35a8eec0b49cc6c066278cb523397)
Karolin Seeger [Thu, 19 Feb 2009 11:27:50 +0000 (12:27 +0100)]
WHATSNEW: Jeremy fixed CID 602, not Volker.
Thanks Volker for reading the release notes! ;-)
Karolin
Karolin Seeger [Thu, 19 Feb 2009 09:07:40 +0000 (10:07 +0100)]
WHATSNEW: Update changes since 3.3.0.
Karolin
Jeremy Allison [Thu, 19 Feb 2009 00:00:34 +0000 (16:00 -0800)]
Gah, typo :-(. Sorry.
Jeremy Allison [Wed, 18 Feb 2009 23:43:03 +0000 (15:43 -0800)]
Fix coverity CID-602. Possible use of uninitialized var.
Jeremy.
Karolin Seeger [Wed, 18 Feb 2009 08:30:27 +0000 (09:30 +0100)]
WHATSNEW: Update changes since 3.3.0.
Karolin
Jeremy Allison [Tue, 17 Feb 2009 23:55:36 +0000 (15:55 -0800)]
Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin@sandia.gov>.
Jeremy.
Jeremy Allison [Tue, 17 Feb 2009 21:43:28 +0000 (13:43 -0800)]
Fix bug #6117 - Samba 3.3.0: pdbedit -a core dumps.
Jeremy.
Günther Deschner [Tue, 17 Feb 2009 14:42:06 +0000 (15:42 +0100)]
s3: remove duplicate prototypes for generated rpc server functions.
Guenther
Stefan Metzmacher [Tue, 17 Feb 2009 09:28:37 +0000 (10:28 +0100)]
s3:make: use pidl/pidl for 'make idl'
metze
Stefan Metzmacher [Tue, 17 Feb 2009 09:28:04 +0000 (10:28 +0100)]
fix proto.h after idl changes
metze
Stefan Metzmacher [Tue, 17 Feb 2009 08:04:58 +0000 (09:04 +0100)]
librpc: rerun 'PIDL=pidl/pidl make idl'
metze
Stefan Metzmacher [Mon, 16 Feb 2009 09:20:55 +0000 (10:20 +0100)]
s3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED
This hopefully fixes bug #6100.
metze
(cherry picked from commit
fe417b29bd23b7b935669993e0f01de4c7de2378)
Stefan Metzmacher [Mon, 16 Feb 2009 09:42:43 +0000 (10:42 +0100)]
netlogon.idl: add idl for netr_LogonGetCapabilities()
metze
(cherry picked from commit
8339969ed39e4cf3577971869ef2fd127f1c3ae3)
Günther Deschner [Fri, 31 Oct 2008 21:39:25 +0000 (22:39 +0100)]
s3-accessmask: re-run make samba3-idl and remove duplicate copies.
Guenther
Günther Deschner [Tue, 17 Feb 2009 01:43:12 +0000 (02:43 +0100)]
s3: re-run make idl.
No panic, this just removes the NDR_BUFFER flag from ndr functions when there is
no buffer to process.
Guenther
Günther Deschner [Tue, 17 Feb 2009 01:35:00 +0000 (02:35 +0100)]
pidl: add copy of pidl to 3-3-test in order to regenerate librpc code.
pidl's reference is
79190992b3820cd028c961c48bdea9b35baf13c9 here.
Guenther
Karolin Seeger [Mon, 16 Feb 2009 14:38:51 +0000 (15:38 +0100)]
s3-WHATSNEW: Update WHATSNEW.
Karolin
Steven Danneman [Fri, 26 Dec 2008 20:41:29 +0000 (12:41 -0800)]
Make sharesec utility part of the default binary install.
This used to be commit
8f84d42f7.
Yasuma Takeda [Mon, 16 Feb 2009 13:07:37 +0000 (14:07 +0100)]
Fix bug 5920
The length of the memcpy was calculated wrong, r->out.return_authenticator is
a pointer
(cherry picked from commit
cb9dd0f58d06a78b7724c3e0ec8f81512edc2d29)
Karolin Seeger [Mon, 16 Feb 2009 10:30:30 +0000 (11:30 +0100)]
s3-WHATSNEW: Start WHATSNEW for 3.3.1.
Karolin
Jeremy Allison [Mon, 16 Feb 2009 02:18:38 +0000 (18:18 -0800)]
Attempt to fix bug #6099. According to Microsoft
Windows 7 looks at the negotiate_flags
returned in this structure *even if the
call fails with access denied ! So in order
to allow Win7 to connect to a Samba NT style
PDC we set the flags before we know if it's
an error or not.
Jeremy.
Derrell Lipman [Sun, 15 Feb 2009 20:00:25 +0000 (15:00 -0500)]
Remove compiler warnings about unknown structure pointer
Tim Prouty [Sun, 15 Feb 2009 04:34:41 +0000 (20:34 -0800)]
s3 vfs: Fix SMB_VFS_RECVFILE/SENDFILE macros
Derrell Lipman [Sun, 15 Feb 2009 03:30:21 +0000 (22:30 -0500)]
remove accidental white space
Derrell Lipman [Sun, 15 Feb 2009 03:30:13 +0000 (22:30 -0500)]
enums are traditionally signed. Avoid use of high bit in bit flags.