Jim McDonough [Fri, 10 Mar 2006 14:28:51 +0000 (14:28 +0000)]
r14156: Fix coverity #114: free storage alloc'ed by sstring_sub()
(This used to be commit
655fb66b289bdd19c4432eea00fac935184f25c9)
Jim McDonough [Fri, 10 Mar 2006 14:20:09 +0000 (14:20 +0000)]
r14155: Fix coverity #115: free storage alloc'ed by sstring_sub()
(This used to be commit
a197b8c5cb02c8a5fac3882e7b76bcd7abb0279c)
Jim McDonough [Fri, 10 Mar 2006 14:17:44 +0000 (14:17 +0000)]
r14153: Fix coverity #116: free storage alloc'ed by sstring_sub()
(This used to be commit
dbc0ff5544f2d15b1d1bc41319c76274b79d92b4)
Jim McDonough [Fri, 10 Mar 2006 14:14:23 +0000 (14:14 +0000)]
r14152: Fix coverity #117: free storage alloc'ed by sstring_sub
(This used to be commit
cf36f5949f8ac5ea020fcaa796ad92852df25ae7)
Jim McDonough [Fri, 10 Mar 2006 14:09:34 +0000 (14:09 +0000)]
r14150: Fix coverity #118: not freeing alloc'ed storage returned from
sstring_sub().
(This used to be commit
6ff849f35ae3394d6557f79c73b0fe54fbb86d0f)
Günther Deschner [Fri, 10 Mar 2006 13:36:39 +0000 (13:36 +0000)]
r14148: Removing the not very well tested krb5 ticket refresh handling activated
over --with-kcm. No time to look after it for the moment.
Guenther
(This used to be commit
7ec2b31a8790db1466ffafeab533c11ab7ea801a)
Jim McDonough [Fri, 10 Mar 2006 13:33:02 +0000 (13:33 +0000)]
r14147: Fix coverity #119. alloc'ed memory returned not saved, so not freed.
Need to go back and correct the assumption that an "ldap xxx suffix"
parm must have an OU.
(This used to be commit
2d7ba11ffbe17af12257a91638be95d09c0c34c5)
Günther Deschner [Fri, 10 Mar 2006 13:14:01 +0000 (13:14 +0000)]
r14146: Just some typos.
Guenther
(This used to be commit
ade86cc787e266850fee982b008a9caf2c8ed7e7)
Günther Deschner [Fri, 10 Mar 2006 13:12:38 +0000 (13:12 +0000)]
r14145: Add missing WITH_KCM hunks from my local tree.
Guenther
(This used to be commit
977079a0583497255fbd4a48de52ebd404710b62)
Günther Deschner [Fri, 10 Mar 2006 13:01:08 +0000 (13:01 +0000)]
r14144: allow to set sec_info in rpcclients lsa_query_secobj.
Guenther
(This used to be commit
18ee669c604b344910308fef81c2544e208ef62c)
Jim McDonough [Fri, 10 Mar 2006 09:41:08 +0000 (09:41 +0000)]
r14135: Fix for Coverity #123: resource leak. Also rework much of the code to
make it cleaner. There's still more to do on this...
(This used to be commit
f75dad0325aec93cc604ddfbef40d29979d07275)
Volker Lendecke [Fri, 10 Mar 2006 09:07:03 +0000 (09:07 +0000)]
r14134: Fix Coverity bug # 137
(This used to be commit
62e58d939bf3abf71bb19aade57d406e07403bc8)
Volker Lendecke [Fri, 10 Mar 2006 08:56:13 +0000 (08:56 +0000)]
r14133: Fix Coverity bug # 140
(This used to be commit
5007f53eb54eddff3d13df929d78385d6b158057)
Volker Lendecke [Fri, 10 Mar 2006 08:53:15 +0000 (08:53 +0000)]
r14132: Fix Coverity bug # 150.
Jerry, you might want to check this.
Thanks
Volker
(This used to be commit
9ec671c2f8547482ed08eb17a0fb771ef8fd1e51)
Volker Lendecke [Fri, 10 Mar 2006 08:47:59 +0000 (08:47 +0000)]
r14131: Fix Coverity bug # 127
(This used to be commit
c105bfae2647752b31d8c3b59a0ee80c56f97138)
Günther Deschner [Fri, 10 Mar 2006 08:43:32 +0000 (08:43 +0000)]
r14130: Remove make_server_info_pac alltogether, make_server_info_info3 does
already do what we need.
Guenther
(This used to be commit
773e33c9717ae04f48983ddc49f7619a97523603)
Günther Deschner [Fri, 10 Mar 2006 08:26:40 +0000 (08:26 +0000)]
r14129: Add the group sids from the Kerberos PAC to the user token.
Guenther
(This used to be commit
1280d79111ae56c6a1b4daf7a1d6d413d1f4df64)
Steve French [Fri, 10 Mar 2006 04:18:29 +0000 (04:18 +0000)]
r14128: Remove warning generated by coverity scan tool (missing SAFE_FREE in error path)
(This used to be commit
33a1e26114d7dfdfb72e393efa399454a588e11e)
Steve French [Fri, 10 Mar 2006 04:05:49 +0000 (04:05 +0000)]
r14127: Remove coverity warning on mount.cifs.c
(This used to be commit
2ec51635ae7ba448f18c4c1342a5fd2adb1ec869)
Steve French [Fri, 10 Mar 2006 03:47:57 +0000 (03:47 +0000)]
r14126: resolve two warnings from the coverity scan
(This used to be commit
32c7243b80f1f06d37511fb87f7a5c715f4847c6)
Jeremy Allison [Thu, 9 Mar 2006 23:20:52 +0000 (23:20 +0000)]
r14121: We never pass NULL to the rpc_api_pipe fn so don't
trigger coverity checks by testing for NULL.
Jeremy.
(This used to be commit
6b4484159293d725613249adbfa01472dea1c722)
Jeremy Allison [Thu, 9 Mar 2006 22:49:38 +0000 (22:49 +0000)]
r14118: Fix coverity bug #24. Missing return statement meant
a possible NULL ptr deref.
Jeremy.
(This used to be commit
78ac3f9cbdabc1df9480f75fb3910a3a108a0e91)
Jeremy Allison [Thu, 9 Mar 2006 22:46:42 +0000 (22:46 +0000)]
r14115: Fix coverity bug #23. Don't deref a potentially null ptr.
Jeremy.
(This used to be commit
df32eb70a45150e459997c2ae92c865cd0e083f6)
Gerald Carter [Thu, 9 Mar 2006 22:31:37 +0000 (22:31 +0000)]
r14112: * fix checks on return code from register_vuid() which could actually
fail and we would still return success in the SMBsesssetup reply :-(
* Make sure to create the local token for the server_fino struct
in reply_spnego_kerberos() so that register_vuid() does not fail.
(how did this ever work?)
(This used to be commit
8dafa45b97020d1aceb027a85e18401c965bf402)
James Peach [Thu, 9 Mar 2006 22:31:05 +0000 (22:31 +0000)]
r14111: Work around additional typedefs in the gamin implementation
of the FAM API.
(This used to be commit
dc96ce90e50da9a82f941b0b534c0681c8477f5e)
Jeremy Allison [Thu, 9 Mar 2006 22:00:12 +0000 (22:00 +0000)]
r14106: Fix from William Jojo for AIX vfs builds. Thanks Bill !
Jeremy.
(This used to be commit
7d50966d7f783da41dc9303d7c535bc46564cf09)
Volker Lendecke [Thu, 9 Mar 2006 21:15:10 +0000 (21:15 +0000)]
r14103: Fix a memleak found by valgrind (!!)
(This used to be commit
b880602c4c1b13fbb5931b8e00c22209a722e0d5)
Volker Lendecke [Thu, 9 Mar 2006 21:13:54 +0000 (21:13 +0000)]
r14102: Fix Coverity bug # 70
(This used to be commit
56dc19879c6514cbdd0b1fd186c8bdeb61bf151a)
Volker Lendecke [Thu, 9 Mar 2006 21:07:15 +0000 (21:07 +0000)]
r14101: Fix a segfault in trustdom establish, cli is NULL here.
(This used to be commit
1df58c7a00b00242ee3eda09de92335d5dabe9c4)
Volker Lendecke [Thu, 9 Mar 2006 20:51:22 +0000 (20:51 +0000)]
r14099: Fix Coverity # 113
(This used to be commit
db00570535c03360bb2833f070878a33e94306b0)
Volker Lendecke [Thu, 9 Mar 2006 20:42:01 +0000 (20:42 +0000)]
r14098: Fix Coverity # 112
(This used to be commit
121a350b92dafec8f171a54f4b897c7f81757dd1)
Jeremy Allison [Thu, 9 Mar 2006 19:51:38 +0000 (19:51 +0000)]
r14092: Fix coverity bug #22. Ensure no possible null
deref.
Jeremy.
(This used to be commit
0026fb0b2843271c27e9dc02a32e88d580bebbc3)
Jeremy Allison [Thu, 9 Mar 2006 19:13:55 +0000 (19:13 +0000)]
r14090: Fix coverity bug #21, don't deref potential null.
Jeremy.
(This used to be commit
76c4d5212bcb5f54472c9ceac2368078ebad7a3b)
Jeremy Allison [Thu, 9 Mar 2006 19:03:31 +0000 (19:03 +0000)]
r14088: Fix Coverity bug #20. Don't deref possible null.
Jeremy.
(This used to be commit
7f3ace5481e55ef845da28b9c0613a2ea0de0de4)
Jeremy Allison [Thu, 9 Mar 2006 18:35:57 +0000 (18:35 +0000)]
r14087: Protect against domain being NULL. Finish Coverity #152.
Jeremy.
(This used to be commit
88dd4ab48127bb08fdeb0b5c236020e0b910f0d8)
Jim McDonough [Thu, 9 Mar 2006 18:03:54 +0000 (18:03 +0000)]
r14085: Fix coverity bg #152, uninit'ed var.
(This used to be commit
d8e69c18e0d34c99525080b3afaf2778be3a5ec2)
Jeremy Allison [Thu, 9 Mar 2006 18:01:42 +0000 (18:01 +0000)]
r14083: Fix coverity bug #19. Don't deref possible NULL.
Jeremy.
(This used to be commit
fc8e1e5c02dd950ed1f8656a5d7ab47fa7ec1ea7)
Jeremy Allison [Thu, 9 Mar 2006 17:56:16 +0000 (17:56 +0000)]
r14080: Fix Coverity bug #18. Ensure non-null before ref.
Jeremy.
(This used to be commit
617c5805e59dd601b8841251032e3db4d6a64621)
Gerald Carter [Thu, 9 Mar 2006 16:28:38 +0000 (16:28 +0000)]
r14077: fix build breakage
(This used to be commit
a40a7f5ea10cf8651cb4334a6623c07fb3dfc565)
Günther Deschner [Thu, 9 Mar 2006 16:08:15 +0000 (16:08 +0000)]
r14076: When the backends trusted_domains call comes back with no trusts the
NTSTATUS code will be NT_STATUS_NO_MORE_ENTRIES. In that case store
NT_STATUS_OK in the centry so that the entry does not automatically
deleted upon startup or invalidated upon next query.
Guenther
(This used to be commit
200d4566619c58951e22d9543420407b3baf878f)
Gerald Carter [Thu, 9 Mar 2006 15:51:55 +0000 (15:51 +0000)]
r14075: * add support for long variable names in smb.conf in the form of %(....)
* add support for %(DomainSID)
* replace standard_sub_XXX() functions with wrappers around their
alloc_sub_XXX() counterparts
* add support for using SIDs in read list, et. al. (anything that
is checked by nt_token_contains_name_in_list())
(This used to be commit
71d960250d2c6d01096a03e98884d3f9c395baa0)
Günther Deschner [Thu, 9 Mar 2006 14:51:40 +0000 (14:51 +0000)]
r14074: Some cleanup; there is no point in declaring and mapping
KRB5KRB_ERR_RESPONSE_TOO_BIG when the krb5 library does not know about
this.
Guenther
(This used to be commit
4a1a3c4808307e09fa8ff85da9a963a4a6f0e9ae)
Günther Deschner [Thu, 9 Mar 2006 11:01:43 +0000 (11:01 +0000)]
r14062: Forgot those in the uint16/32 acb_info switch.
Guenther
(This used to be commit
0167b6cca80492d8a076da0497d24089f78587dc)
Günther Deschner [Thu, 9 Mar 2006 10:57:39 +0000 (10:57 +0000)]
r14061: Some debugging for the new LOGON/ACB-flags.
Guenther
(This used to be commit
7616317f9f45dfbc453a7687e8b8b6ff57ddb0a3)
Günther Deschner [Thu, 9 Mar 2006 09:08:11 +0000 (09:08 +0000)]
r14060: Only set the last rebind timestamp when we did rebind after a non-read
LDAP operation. That way we avoid the replication sleep after a simple
redirected search operation
Guenther
(This used to be commit
d236caac211ff45a3e2da73a3b0316194740a722)
Lars Müller [Wed, 8 Mar 2006 21:46:16 +0000 (21:46 +0000)]
r14057: Remove generated script/gen-8bit-gap.sh while calling rule realclean.
Ignore script/gen-8bit-gap.sh in branches/SAMBA_3_0/source/script as we
already do in trunk.
(This used to be commit
b974b1879c1bded616becb77fa34f071a5f43ecc)
Lars Müller [Wed, 8 Mar 2006 21:42:12 +0000 (21:42 +0000)]
r14056: Also install the mount.smbfs sym link to rootsbindir. Therfore we have
to substitute rootsbindir in {,un}installbin.sh.in.
Pass $prefix as third arg to installbin/ uninstallbin as rootsbindir by
default is $prefix/sbin.
(This used to be commit
7773b8c9e0ad7bcff1312f28ca9cd17d7677e9bd)
Jim McDonough [Wed, 8 Mar 2006 21:29:49 +0000 (21:29 +0000)]
r14053: Implement Simo's suggestion: don't use /dev/null for a 'bad' path for
users/workstations
(This used to be commit
2690f015be1f7eb9802f652810e73ff5f5688304)
Lars Müller [Wed, 8 Mar 2006 21:20:43 +0000 (21:20 +0000)]
r14052: Remove BASEDIR use in the Makefile. BASEDIR=prefix=@prefix@ till now.
I suggest to stay with ^BASEDIR= @prefix@$ for at least the next release
to give external projects - like samba-vscan project - time to adopt
this change.
BASEDIR is non of the default autoconf variables. prefix is.
Jerry1: If possible please announce this with the next release. I'll
self reply to technical.
Jerry2: This does not break your makepkg stuff as you set BASEDIR
_not_ from the Makefile.
(This used to be commit
730d5ec22948c579a81137051134657043c34415)
Günther Deschner [Wed, 8 Mar 2006 21:10:20 +0000 (21:10 +0000)]
r14051: Add remaining (documented) userAccountControl bits, thanks to Luke
Howard for pointing this out.
Guenther
(This used to be commit
170038f4cdfa51ea31b2255a020740d28dfbfba2)
Günther Deschner [Wed, 8 Mar 2006 21:05:32 +0000 (21:05 +0000)]
r14050: Add the ACB_PWEXPIRED bit abartlet has found.
Guenther
(This used to be commit
5fa3f26b4c39d612243319fc0729078c50439d6b)
Günther Deschner [Wed, 8 Mar 2006 20:57:41 +0000 (20:57 +0000)]
r14049: Found some more MSV1_0 bits and their behaviour;
just for documentation purpose.
Guenther
(This used to be commit
0b00424e07f3f9c815664c619e2d7a670a838b93)
Jeremy Allison [Wed, 8 Mar 2006 20:07:24 +0000 (20:07 +0000)]
r14047: Coverity fix #17. Ensure srv_name and info cannot
be zero before deref.
Jeremy.
(This used to be commit
fbf9db6624d9584a26ae302df3c76555bbd2bb1e)
Jeremy Allison [Wed, 8 Mar 2006 20:02:50 +0000 (20:02 +0000)]
r14045: Coverity fix #14. Ensure if len is set buf != NULL.
Jeremy.
(This used to be commit
fb1a6073321840fecf22f3e0f7541f5ad87f5e49)
Jeremy Allison [Wed, 8 Mar 2006 17:50:44 +0000 (17:50 +0000)]
r14043: After discussion with Jerry revert part of the
Coverity null-ref patch - put prs_rpcbuffer_p
back to the way it was (with an additional
coverity paranoia check) - move the real test
into rpcbuf_alloc_size instead.
Jeremy.
(This used to be commit
f74993e65c01bc0ef73d3e8710bb2f840910161a)
Gerald Carter [Wed, 8 Mar 2006 15:18:14 +0000 (15:18 +0000)]
r14042: check that create_local_nt_token() succeeds before dereferncing the NT_USER_TOKEN*
(This used to be commit
4e5df4cb643886144d0fff4cac303e493c825955)
Volker Lendecke [Wed, 8 Mar 2006 08:51:19 +0000 (08:51 +0000)]
r14036: Ok, the last one generated a const warning. Also fix Coverity # 119.
net rpc vampire is ugly....
Volker
(This used to be commit
c1ea48949d2692c839f6ced68165cabd76b580ea)
Volker Lendecke [Wed, 8 Mar 2006 08:41:36 +0000 (08:41 +0000)]
r14035: Fix Coverity bug # 124
(This used to be commit
9fe21fd0326e67a4b1006d2b4a24e39e2d57d796)
Volker Lendecke [Wed, 8 Mar 2006 08:28:42 +0000 (08:28 +0000)]
r14034: Fix Coverity id # 125.
Jeremy, you might want to take a look here.
Volker
(This used to be commit
e6e29937e8ccfc84afca0ee440bd3f10a7d10e8a)
Volker Lendecke [Wed, 8 Mar 2006 08:22:42 +0000 (08:22 +0000)]
r14033: Fix Coverity bug # 126
(This used to be commit
bb6d678575faac050376607a5c778b8a10805061)
Jeremy Allison [Wed, 8 Mar 2006 07:30:37 +0000 (07:30 +0000)]
r14031: Coverity bug CID #110. Free all resources correctly
on pipe initialization failure.
Jeremy.
(This used to be commit
daa919a94b3d81401654004bc0f32c45451203c1)
Jeremy Allison [Wed, 8 Mar 2006 07:20:11 +0000 (07:20 +0000)]
r14030: Fix resource leak in error codepath. Coverity CID #64.
Jeremy.
(This used to be commit
b51edde4d63e9b2f241f41b6780b026487890a7f)
Jeremy Allison [Wed, 8 Mar 2006 07:13:23 +0000 (07:13 +0000)]
r14026: Fix resource leak on error exit. Coverity CID #65.
Jeremy.
(This used to be commit
3a1c4cb93dc262028ffbebd9ebeed69f4816cf09)
Volker Lendecke [Wed, 8 Mar 2006 06:51:38 +0000 (06:51 +0000)]
r14025: Remove unused code. When we want to export samsync, we better first port
pidl...
Fix Coverity # 15.
Volker
(This used to be commit
29b4b986cc225a98d263c883fd52e8b210099b9e)
Jeremy Allison [Wed, 8 Mar 2006 06:42:39 +0000 (06:42 +0000)]
r14023: My last bug fix still left a potential null deref.
C- "must try harder" :-).
Jeremy.
(This used to be commit
9c55bf74ca28530045c5cb3cbfffad242039ca75)
Volker Lendecke [Wed, 8 Mar 2006 06:39:33 +0000 (06:39 +0000)]
r14022: Fix Coverity bug # 92
(This used to be commit
b824245c4e04353f0d3fd0ccf6bc5776a601daed)
Jeremy Allison [Wed, 8 Mar 2006 06:36:40 +0000 (06:36 +0000)]
r14020: Coverity bug CID #66. Missing free on error exit.
Jeremy.
(This used to be commit
b9980bddf5ee74b2887196d6d1a0cf393720ba3a)
Jeremy Allison [Wed, 8 Mar 2006 06:32:26 +0000 (06:32 +0000)]
r14018: Coverity error CID #27. Missing return -1 on error condition.
Jeremy.
(This used to be commit
94e869d9c6d1a1c1df0d072530bf8d4452bd10bb)
Volker Lendecke [Wed, 8 Mar 2006 06:32:21 +0000 (06:32 +0000)]
r14017: Okay, okay, I have turned a double-free into dead code :-)
Fix Coverity # 214.
Volker
(This used to be commit
4a75edf9deca2be18670d7f9f2e383ed0898512c)
Jeremy Allison [Wed, 8 Mar 2006 06:16:54 +0000 (06:16 +0000)]
r14014: Coverity paranoia. Shut it up by making the guarentee
in the code explicit - but this was a false positive (CID #16).
Jeremy.
(This used to be commit
43a0e869f2aee9b4e22d0d7fc92051e82f7536ad)
Jeremy Allison [Wed, 8 Mar 2006 02:05:36 +0000 (02:05 +0000)]
r14009: Remove last const warning (have to use CONST_DISCARD).
Jeremy.
(This used to be commit
af0ade470f2fac3509a44207b4572e279ba30e34)
Jeremy Allison [Wed, 8 Mar 2006 01:43:23 +0000 (01:43 +0000)]
r14007: Coverity bug CID #197. Don't compare against 0, we
mean the ttl instead.
Jeremy.
(This used to be commit
ccb2a52e29de7e2847ccd93aa99236f63202a4af)
Jeremy Allison [Wed, 8 Mar 2006 01:40:15 +0000 (01:40 +0000)]
r14006: Fix a couple of irritating warnings.
Jeremy.
(This used to be commit
ead13ca522d7b8cbb47d660d3cb73c3582088985)
Jeremy Allison [Wed, 8 Mar 2006 01:18:18 +0000 (01:18 +0000)]
r14003: Clarify code that lead to Coverity report #13.
Not a bug, but better to remove false positives.
Jeremy.
(This used to be commit
f9a75d76546bc4618736f0d48646e77d7572db25)
Jeremy Allison [Wed, 8 Mar 2006 01:04:17 +0000 (01:04 +0000)]
r14002: Quick fix for Coverity CID #12.
Jeremy
(This used to be commit
7c6e274cd578521192a0b0c4e6a4fb5dc7d722ac)
Jeremy Allison [Wed, 8 Mar 2006 01:01:34 +0000 (01:01 +0000)]
r13999: Quick fix for Coverity bug #11.
Jeremy.
(This used to be commit
b9de6c926953b3321fa3850d501c807c6eabf230)
Lars Müller [Tue, 7 Mar 2006 23:04:08 +0000 (23:04 +0000)]
r13997: Prefix $prefix by default even to rootsbindir as we else run in trouble
if we use ./configure --prefix=dir && make install
Vendors might use ./configure --with-rootsbindir=/sbin && make
DESTDIR=/var/tmp/samba/ install if they use a buildroot.
Thanks to Björn Jacke for pointing me at the stderr output of the build
farm.
(This used to be commit
75c95d149a22eba4a5afedcec7ba5e2a28cccf01)
Jeremy Allison [Tue, 7 Mar 2006 21:13:19 +0000 (21:13 +0000)]
r13994: Belt and braces - ensure RPC_BUFFER is valid.
Jeremy.
(This used to be commit
d993797191865878ebfd2ff9028d341017605cd6)
Volker Lendecke [Tue, 7 Mar 2006 21:03:48 +0000 (21:03 +0000)]
r13991: Fix Coverity bug # 69
(This used to be commit
6dc79e6b12e221e9af85a1edf487b5fb5aae222b)
Jeremy Allison [Tue, 7 Mar 2006 20:52:43 +0000 (20:52 +0000)]
r13989: Fix for Coverity bug #45 and associated spoolss RPC_BUFFER
problems. Ensure that if the parse succeeds on UNMARSHALL
we have a valid (although possibly empty) RPC_BUFFER returned.
Jeremy.
(This used to be commit
d319cc9c08bfa865a6431a8631a9c609f589be1f)
Volker Lendecke [Tue, 7 Mar 2006 20:44:12 +0000 (20:44 +0000)]
r13987: Fix Coverity bug # 74. This tool is good...
Thanks,
Volker
(This used to be commit
86f62484dd7db43e036d9edf29e459b8bd0e5fbe)
Volker Lendecke [Tue, 7 Mar 2006 20:32:08 +0000 (20:32 +0000)]
r13984: Fix Coverity bug # 98
(This used to be commit
0a2aa3a48bd5fd7e5a9aa06068ddd621b19c1dbe)
Volker Lendecke [Tue, 7 Mar 2006 20:24:28 +0000 (20:24 +0000)]
r13983: Fix Coverity bug # 111
(This used to be commit
08d7fd31ab250bc6ba3922b36aa7b0cfef1e5bf1)
Volker Lendecke [Tue, 7 Mar 2006 20:14:47 +0000 (20:14 +0000)]
r13981: Fix Coverity bug # 138
(This used to be commit
303067ba3bdf34ab501f0d99e386cfdb6ab10233)
Volker Lendecke [Tue, 7 Mar 2006 19:52:26 +0000 (19:52 +0000)]
r13980: Fix Coverity bug # 63. Jeremy, could you take a look at this?
Thanks,
Volker
(This used to be commit
49043a756dfa6a973d5605f42068df351a4a9ab5)
Volker Lendecke [Tue, 7 Mar 2006 19:24:28 +0000 (19:24 +0000)]
r13979: We've dereferenced my_methods already, so there's no point in checking for
!= NULL. Coverity #149.
Volker
(This used to be commit
d38e05329a77650d8fbb8611ca148964f62c9ba4)
Jeremy Allison [Tue, 7 Mar 2006 19:18:56 +0000 (19:18 +0000)]
r13978: Here is why it's essential to use SAFE_FREE instead of free.
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162.
Jeremy.
(This used to be commit
053efc20981e0280c6af0ebb9e17cea07da85fe8)
Jeremy Allison [Tue, 7 Mar 2006 18:52:48 +0000 (18:52 +0000)]
r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistent
between Realloc and realloc_array.
Jeremy.
(This used to be commit
841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
Jeremy Allison [Tue, 7 Mar 2006 18:00:21 +0000 (18:00 +0000)]
r13971: Fix Coverity bugs #209 - #213 - it detected mistakes
in the pointer aliasing once realloc could change
a pointer. This was in the bugzilla.samba.org database
as #687 but we never figured out what it was !
Jeremy.
(This used to be commit
8d183441403524fe39e79af843d6cfe65898f7d3)
Jim McDonough [Tue, 7 Mar 2006 17:49:26 +0000 (17:49 +0000)]
r13968: fix typo, caught by Guenther
(This used to be commit
217d3fbe7923115ae610a39e586ceb93df7683f5)
Günther Deschner [Tue, 7 Mar 2006 16:56:31 +0000 (16:56 +0000)]
r13965: Make sure we always reset the userAccountControl bits when re-joining
with an existing account.
Guenther
(This used to be commit
e4c12ab167ee83772a2bdd1946b8d73613fc0d7e)
Volker Lendecke [Tue, 7 Mar 2006 16:33:36 +0000 (16:33 +0000)]
r13958: Fix Coverity Bug # 141
(This used to be commit
598513d1d3e23cc71ea0fd53230d393b6724b534)
Jim McDonough [Tue, 7 Mar 2006 16:29:25 +0000 (16:29 +0000)]
r13957: Based on patch from Richard Renard <richard.renard@idealx.com>:
Fix machine accounts (should not have valid shells) and users with no
home directory (were getting previous user's directory).
(This used to be commit
f629f8a7b972f09fe959c68843b9cd5a03abfc76)
Volker Lendecke [Tue, 7 Mar 2006 16:28:05 +0000 (16:28 +0000)]
r13955: Fix Coverity ID 139.
Not a bug in the strictest sense, more a clarification. This whole routine
assumes new_gid != NULL anyway, so there's no point in checking.
Volker
(This used to be commit
dfbf09c772b9588271e2d8e053c7494bb087c544)
Volker Lendecke [Tue, 7 Mar 2006 16:06:26 +0000 (16:06 +0000)]
r13951: Fix Coverity Bug #163.
This code was not used anyway :-)
Volker
(This used to be commit
bbfb20569380529d60e3c61cd0be63a09eecfd17)
Volker Lendecke [Tue, 7 Mar 2006 16:01:57 +0000 (16:01 +0000)]
r13950: Fix Coverity bug #168
(This used to be commit
cbf894c0e37964df57bd6a91ac10dfff571b1b3c)
Jim McDonough [Tue, 7 Mar 2006 15:32:18 +0000 (15:32 +0000)]
r13948: Fix the build. Remove rpcclient.h include.
(This used to be commit
6bf879bee3c59ba54b1b4c465c777e3dd0043f83)
Lars Müller [Tue, 7 Mar 2006 15:27:35 +0000 (15:27 +0000)]
r13947: Use tabs instead of spaces for indention.
(This used to be commit
fb76390c6ae5928a2a222d61cbadf825611999ef)
Lars Müller [Tue, 7 Mar 2006 15:25:10 +0000 (15:25 +0000)]
r13946: Link pam_smbpass with the required object files. Fix bug #3565.
(This used to be commit
426c8fe0bdacbf218d4cf4a10af789afbc0e53f2)
Günther Deschner [Tue, 7 Mar 2006 15:17:01 +0000 (15:17 +0000)]
r13945: Move display_sec.c to lib/ (as suggested by Volker).
Guenther
(This used to be commit
7e80d5358eb181c3515acb732a3594e80391261b)