Andrew Bartlett [Wed, 22 Aug 2001 19:11:55 +0000 (19:11 +0000)]
A few changes:
drop paramaters:
status
utmp hostname
change session code to always record each vuid current on the server. The sessionid struct is no longer packed, as I couldn't get that to work ;-)
change smbstatus to show this info and less of the connections.tdb info (its not actualy that accurate).
I'll get swat doing some of this shortly.
Simo Sorce [Wed, 22 Aug 2001 16:10:28 +0000 (16:10 +0000)]
some %things are not expanded properly in get share info levels
Jean-François Micouleau [Wed, 22 Aug 2001 13:08:01 +0000 (13:08 +0000)]
The DELL powervault 705 is sending a tcon&x with the service name being
"share" instead of "\\server\share".
Fix that. Still not able to get the user list but that's something else.
Jeremy I don't think I broke anything ;-)
J.F.
Herb Lewis [Wed, 22 Aug 2001 04:58:00 +0000 (04:58 +0000)]
force checking of log size after 200 smbd in a row or after 30 sec with no
smbds. This should fix one case of logs not getting rotated properly.
We may need to test this to make sure there is no big performance hit from
the extra stat call.
Volker Lendecke [Wed, 22 Aug 2001 04:45:05 +0000 (04:45 +0000)]
Mention 'delete veto files' in 'veto files' description
Volker
Jeremy Allison [Wed, 22 Aug 2001 04:39:37 +0000 (04:39 +0000)]
Remove unneeded lp_talloc_free().
Jeremy.
Andrew Tridgell [Wed, 22 Aug 2001 03:18:24 +0000 (03:18 +0000)]
added ERRbadmcb
Andrew Tridgell [Wed, 22 Aug 2001 03:15:33 +0000 (03:15 +0000)]
minor bug fixes to smbtorture
Tim Potter [Wed, 22 Aug 2001 03:10:58 +0000 (03:10 +0000)]
Link in smbdes routines for new wbinfo authentication stuff.
Tim Potter [Wed, 22 Aug 2001 02:48:16 +0000 (02:48 +0000)]
Added another authentication interface to winbindd. The Challenge Response
Authentication Protocol (CRAP) takes a tuple of (username, random
challenge, encrypted lm password, encrypted nt password) where the
passwords are encrypted with the random challenge ala ntlmssp.
Andrew Tridgell [Wed, 22 Aug 2001 02:47:38 +0000 (02:47 +0000)]
a fix for directory listing with the dave/thursby client
Volker Lendecke [Wed, 22 Aug 2001 02:27:59 +0000 (02:27 +0000)]
Fixed typo.
Volker
Gerald Carter [Wed, 22 Aug 2001 01:48:45 +0000 (01:48 +0000)]
merge from 2.2
Gerald Carter [Wed, 22 Aug 2001 01:18:48 +0000 (01:18 +0000)]
merge from 2.2
Jeremy Allison [Wed, 22 Aug 2001 01:06:27 +0000 (01:06 +0000)]
Missed '\' at eol...
Jeremy.
Jeremy Allison [Wed, 22 Aug 2001 01:01:37 +0000 (01:01 +0000)]
Tidyup fixes for fcntl spin problem.
Jeremy.
Jeremy Allison [Wed, 22 Aug 2001 00:29:40 +0000 (00:29 +0000)]
Fixed the (incorrect) paranioa fix I put in for the fcntl lock spin.
Don't delete a share mode that failed to remove the oplock (doh!),
just set the oplock entry to zero....
Jeremy.
Herb Lewis [Tue, 21 Aug 2001 23:56:04 +0000 (23:56 +0000)]
sync with 2.2 branch
Jeremy Allison [Tue, 21 Aug 2001 18:33:58 +0000 (18:33 +0000)]
Missed uninitialized variable return for del_share_mode().
Jeremy.
Andrew Tridgell [Tue, 21 Aug 2001 03:50:31 +0000 (03:50 +0000)]
string terminate in mkdir
Tim Potter [Tue, 21 Aug 2001 03:05:27 +0000 (03:05 +0000)]
Added cli_lsa_open_policy2()
Tim Potter [Tue, 21 Aug 2001 03:04:41 +0000 (03:04 +0000)]
Distinguish between NT informational and error codes.
Andrew Bartlett [Tue, 21 Aug 2001 02:58:07 +0000 (02:58 +0000)]
Add a new option to disable our paranoid server check.
Defaults to ON, ie checking
Volker Lendecke [Tue, 21 Aug 2001 02:11:41 +0000 (02:11 +0000)]
Fixed a little typo.
Volker
Volker Lendecke [Tue, 21 Aug 2001 01:25:45 +0000 (01:25 +0000)]
This is Jeremy pretending to be Volker, 'cos the
link from Seattle is having problems.
I've added 3 things here to work on the fcntl spin
problem.
1). Check *all* tdb return codes... :-).
2). If we're asking ourselves to break an oplock, and we can't
find a fsp pointer that matches the entry, this is a *logic bug*
and we should abort and panic so someone with gdb can pick up
the pieces.
3). After we've broken an oplock, ensure that the entry itself
has been removed, and if not remove it ourselves. This should
not be neccessary in a correctly working environmen,t, but will
provide an added layer of robustness in error situations.
4). I hate german keyboards :-) :-).
Jeremy.
Jeremy Allison [Mon, 20 Aug 2001 22:13:53 +0000 (22:13 +0000)]
Ensure we are very explicit about what we're comparing when
we're comparing structures (ie. don't just do a memcmp). I
don't think this will fix the fcntl spin issue, but it's a
"just in case" change.
Jeremy.
Andrew Bartlett [Mon, 20 Aug 2001 22:01:44 +0000 (22:01 +0000)]
Add comment to clarify why we call this twice.
Andrew Tridgell [Mon, 20 Aug 2001 21:11:55 +0000 (21:11 +0000)]
two fixes for NT clients -> share level Samba server
Andrew Tridgell [Mon, 20 Aug 2001 18:05:12 +0000 (18:05 +0000)]
allow for the NULL in make_nmb_name()
Andrew Tridgell [Mon, 20 Aug 2001 17:38:37 +0000 (17:38 +0000)]
added -b option
Andrew Tridgell [Mon, 20 Aug 2001 05:15:26 +0000 (05:15 +0000)]
a bunch of fixes from the s\7fflight to seattle
in particular:
- fixed NT status code for a bunch of ops
- fixed handling of protocol levels in ms_fnmatch
Jeremy Allison [Sun, 19 Aug 2001 18:25:14 +0000 (18:25 +0000)]
Realloc fix.
Jeremy.
Jeremy Allison [Sun, 19 Aug 2001 18:19:04 +0000 (18:19 +0000)]
Realloc fixes.
Jeremy.
Jeremy Allison [Sun, 19 Aug 2001 18:01:08 +0000 (18:01 +0000)]
Realloc fixes.
Jeremy.
Jeremy Allison [Sun, 19 Aug 2001 17:54:10 +0000 (17:54 +0000)]
Realloc fixes.
Jeremy.
Jeremy Allison [Sun, 19 Aug 2001 17:42:34 +0000 (17:42 +0000)]
More Realloc fixes.
Jeremy.
Jeremy Allison [Sun, 19 Aug 2001 17:34:37 +0000 (17:34 +0000)]
Realloc fix.
Jeremy.
Anton Blanchard [Sun, 19 Aug 2001 13:45:38 +0000 (13:45 +0000)]
Add missing gcc memory barriers, this bug showed up when doing a
heavy netbench run. :)
Rework ppc spinlocks to be faster.
Jeremy Allison [Sat, 18 Aug 2001 19:57:48 +0000 (19:57 +0000)]
More Realloc fixes.
Jeremy.
Jeremy Allison [Sat, 18 Aug 2001 19:43:28 +0000 (19:43 +0000)]
More Realloc fixes.
Jeremy.
Jeremy Allison [Fri, 17 Aug 2001 18:16:42 +0000 (18:16 +0000)]
Use tparam not tdata when reallocing params to make clearer.
Jeremy.
Jean-François Micouleau [Fri, 17 Aug 2001 17:07:40 +0000 (17:07 +0000)]
more useful debug messages and check if the size are non null.
that fix the notification backend channel for spoolss.
J.F.
Andrew Bartlett [Fri, 17 Aug 2001 08:57:58 +0000 (08:57 +0000)]
OK, so not freeing these was a mistake. I'll try to be less exuberent next
time :-)
Andrew Bartlett [Fri, 17 Aug 2001 08:44:04 +0000 (08:44 +0000)]
Move the claim_connection stuff till a little later in the process.
(You don't have to clean up somthing you haven't done yet...)
Andrew Bartlett [Fri, 17 Aug 2001 08:12:33 +0000 (08:12 +0000)]
Move admin user check into a helper function.
Formatting fixes.
Andrew Bartlett [Fri, 17 Aug 2001 07:48:25 +0000 (07:48 +0000)]
Move read only check into a helper funcion. Ensure conn->service is set
before we use it to find a share's details.
Andrew Bartlett [Fri, 17 Aug 2001 07:47:10 +0000 (07:47 +0000)]
Restore a debug I think I dropped earlier
Andrew Bartlett [Fri, 17 Aug 2001 07:03:27 +0000 (07:03 +0000)]
smbd/auth_server: Doco, we want to use cli_nt_error here soon
smbd/password.c: We don't use globals here anymore
smbd/reply.c: Tidyness, global_myworkgroup must die!
smbd/service.c: Move some of the make_connection code into a helper
function.
Andrew Bartlett [Fri, 17 Aug 2001 06:06:56 +0000 (06:06 +0000)]
Style cleanup for the last vuid change.
Style, doco and DEBUG() fixes for auth_smbpasswd.c
(In particular for the account control call).
Andrew Bartlett
Andrew Bartlett [Fri, 17 Aug 2001 05:38:44 +0000 (05:38 +0000)]
One less getpwnam() call...
Andrew Bartlett
Andrew Tridgell [Thu, 16 Aug 2001 07:22:47 +0000 (07:22 +0000)]
removed unused file
Andrew Tridgell [Thu, 16 Aug 2001 07:15:57 +0000 (07:15 +0000)]
removed unused file
Jeremy Allison [Mon, 13 Aug 2001 23:19:16 +0000 (23:19 +0000)]
Added Jim McDonough's Win9x take ownership fix.
Jeremy.
Gerald Carter [Mon, 13 Aug 2001 21:30:27 +0000 (21:30 +0000)]
merge from 2.2
Jeremy Allison [Mon, 13 Aug 2001 17:58:54 +0000 (17:58 +0000)]
Add printing of errno when POSIX lock requests fail.
Jeremy.
Tim Potter [Mon, 13 Aug 2001 05:26:33 +0000 (05:26 +0000)]
Moved across definition of dos error types from smb.h to doserr.h
Tim Potter [Mon, 13 Aug 2001 04:08:42 +0000 (04:08 +0000)]
Converted to new error API.
Now that we support NT errors from the client, appropriate values will need
to be filled in for the various invocations of check_error() within the
torture code.
Tim Potter [Mon, 13 Aug 2001 02:39:13 +0000 (02:39 +0000)]
Fixed typo in debug message.
Tim Potter [Mon, 13 Aug 2001 02:33:24 +0000 (02:33 +0000)]
Fixed up 'orrible formatting.
Tim Potter [Sun, 12 Aug 2001 23:53:26 +0000 (23:53 +0000)]
Fixed crash bug when attempting to list contents of non-existent
directory.
Simo Sorce [Sun, 12 Aug 2001 17:30:01 +0000 (17:30 +0000)]
this is a big global fix for the ptr = Realloc(ptr, size) bug.
many possible mem leaks, and segfaults fixed.
someone should port this fix to 2.2 also.
Andrew Bartlett [Sun, 12 Aug 2001 12:23:50 +0000 (12:23 +0000)]
Kill of idra's extra become_root()/unbecome_root() now I have fixed the actual
problem.
Andrew Bartlett
Andrew Bartlett [Sun, 12 Aug 2001 11:19:57 +0000 (11:19 +0000)]
This patch does a number of things, mostly smaller than they look :-)
In particuar, it moves the domain_client_validate stuff out of
auth_domain.c to somwhere where they (I hope) they can be shared
with winbind better. (This may need some work)
The main purpose of this patch was however to improve some of the
internal documentation and to correctly place become_root()/unbecome_root()
calls within the code.
Finally this patch moves some more of auth.c into other files, auth_unix.c
in this case.
Andrew Bartlett
Simo Sorce [Sun, 12 Aug 2001 09:18:31 +0000 (09:18 +0000)]
it was half committed last time,
thanks to Hasch@t-online.de (Juergen Hasch) for spotting that.
Simo Sorce [Sat, 11 Aug 2001 16:34:11 +0000 (16:34 +0000)]
Without this become_root()/unbecome_root() pair I was not able to login
when samba acting as a PDC.
I also removed a pdb_free_sam(sampass), because it sampass was never
initialized before...
Please abartlet can you check this patch is ok?
I feel like this was a bad check-in
Jeremy Allison [Fri, 10 Aug 2001 20:48:25 +0000 (20:48 +0000)]
Added Mike Davidsons Tru64 ACL patch.
Jeremy.
Jeremy Allison [Fri, 10 Aug 2001 19:38:53 +0000 (19:38 +0000)]
Merge in the NT drivers changes from 2.2.
Jeremy.
Simo Sorce [Fri, 10 Aug 2001 09:52:10 +0000 (09:52 +0000)]
- avoid possible mem leaks in rpcclient/cmd_*.c (talloc_destroy not performed)
- ported two rpc back from TNG (WINREG: shutdown and abort shutdown)
- some optimizations and changed some DEBUG statement in loadparm.c
- changed rpcclient a bit moved from non reentrant next_token_nr to next_token
- in cmd_reg.c not sure if getopt will work ok on all platforms only setting optind=0
Tim Potter [Fri, 10 Aug 2001 07:41:18 +0000 (07:41 +0000)]
Debug cleanups.
Tim Potter [Fri, 10 Aug 2001 06:46:11 +0000 (06:46 +0000)]
Had the test for cli_is_error() reversed. You idiot Stimpy!
Tim Potter [Fri, 10 Aug 2001 06:16:05 +0000 (06:16 +0000)]
Fixes for new client error api.
Tim Potter [Fri, 10 Aug 2001 06:11:31 +0000 (06:11 +0000)]
Use new client error api.
Tim Potter [Fri, 10 Aug 2001 06:01:11 +0000 (06:01 +0000)]
Use the new client error api.
Tim Potter [Fri, 10 Aug 2001 06:00:33 +0000 (06:00 +0000)]
A rewrite of the error handling in the libsmb client code. I've separated
out the error handling into a bunch of separate functions rather than all
being handled in one big function.
Fetch error codes from the last received packet:
void cli_dos_error(struct cli_state *cli, uint8 *eclass, uint32 *num);
uint32 cli_nt_error(struct cli_state *);
Convert errors to UNIX errno values:
int cli_errno_from_dos(uint8 eclass, uint32 num);
int cli_errno_from_nt(uint32 status);
int cli_errno(struct cli_state *cli);
Detect different kinds of errors:
BOOL cli_is_dos_error(struct cli_state *cli);
BOOL cli_is_nt_error(struct cli_state *cli);
BOOL cli_is_error(struct cli_state *cli);
This also means we now support CAP_STATUS32 as we can decode and understand
NT errors instead of just DOS errors. Yay!
Ported a whole bunch of files in libsmb to use this new API instead of the
just the DOS error.
Tim Potter [Fri, 10 Aug 2001 05:50:47 +0000 (05:50 +0000)]
More constant conversions.
Tim Potter [Fri, 10 Aug 2001 05:50:20 +0000 (05:50 +0000)]
Removed nt_error field from cli_state as it was not used anywhere.
Tim Potter [Fri, 10 Aug 2001 05:41:53 +0000 (05:41 +0000)]
Replaced the duplicate DOS constants with appropriate ones from doserr.h to
emphasise the fact that the spoolss pipe returns DOS error codes instead of
32-bit nt status codes.
Tim Potter [Fri, 10 Aug 2001 05:37:52 +0000 (05:37 +0000)]
Moved dos error codes from smb.h into new file doserr.h
Tim Potter [Fri, 10 Aug 2001 04:59:05 +0000 (04:59 +0000)]
Changed the order of arguments in make_oem_passwd_hash(). All the other
encryption functions have outputs as the last arguments.
Gerald Carter [Fri, 10 Aug 2001 04:27:26 +0000 (04:27 +0000)]
merge from 2.2
Jeremy Allison [Fri, 10 Aug 2001 03:17:58 +0000 (03:17 +0000)]
Fixed typo in patch.
Jeremy.
Jeremy Allison [Thu, 9 Aug 2001 20:01:35 +0000 (20:01 +0000)]
Fixed wrong placement of allocate code :-(.
Changed alignment offset to 1 to allow netmon to parse ok.
Jeremy.
Jeremy Allison [Thu, 9 Aug 2001 19:36:12 +0000 (19:36 +0000)]
Added fix from Dan Thibadeau @ HP for parsing problem.
Jeremy.
Jeremy Allison [Thu, 9 Aug 2001 19:22:51 +0000 (19:22 +0000)]
Fix inspired by Don @ HP. Close down password server connection if keepalive
fails.
Jeremy.
Jeremy Allison [Thu, 9 Aug 2001 18:20:43 +0000 (18:20 +0000)]
Merged John's fix.
Jeremy.
Gerald Carter [Thu, 9 Aug 2001 15:53:49 +0000 (15:53 +0000)]
a few cleanups while mergeing the passdb code into 2.2
Andrew Bartlett [Thu, 9 Aug 2001 12:52:05 +0000 (12:52 +0000)]
Try to set the socket options early for some OSs (like Sol 8) where they
can't be set after the listen().
Andrew Bartlett
Tim Potter [Thu, 9 Aug 2001 03:41:18 +0000 (03:41 +0000)]
Link fix for smbpasswd.
Simo Sorce [Wed, 8 Aug 2001 16:54:16 +0000 (16:54 +0000)]
Change all realloc() statements to Realloc() (ecxept for tdb.c)
changed some code to exploit the fact that Realloc(NULL, size) == malloc(size)
fixed some possible mem leaks, or seg faults.
thanks to andreas moroder (mallocs not checked in client/client.c, client/smbumount.c)
Andrew Bartlett [Wed, 8 Aug 2001 03:25:47 +0000 (03:25 +0000)]
Some better debugs for our security=server code. I want to track down why
we occasionally don't make the connection to the server.
Tim Potter [Wed, 8 Aug 2001 03:21:43 +0000 (03:21 +0000)]
Merge of modesty patch from 2.2 spec file.
Tim Potter [Wed, 8 Aug 2001 03:18:49 +0000 (03:18 +0000)]
Factored out common rpc pipe initialisation and shutdown code.
Tim Potter [Tue, 7 Aug 2001 23:21:45 +0000 (23:21 +0000)]
Patch for having spaces in tdb keys, NULL termination fixes and other
stuff. From Andrew Esh <AEsh@tricord.com>
Jeremy Allison [Tue, 7 Aug 2001 19:48:54 +0000 (19:48 +0000)]
Update to work with no crypt available, just like it will in Samba.
Jermey.
Gerald Carter [Tue, 7 Aug 2001 19:34:38 +0000 (19:34 +0000)]
merge from 2.2
Jeremy Allison [Tue, 7 Aug 2001 19:18:27 +0000 (19:18 +0000)]
Always return NT_STATUS_DISK_FULL, even for quota errors.
Jeremy.
Jeremy Allison [Tue, 7 Aug 2001 01:19:32 +0000 (01:19 +0000)]
Added fixes to return correct error codes on space allocation fail.
Jeremy.
Jeremy Allison [Tue, 7 Aug 2001 00:36:10 +0000 (00:36 +0000)]
Correctly report amount written in debug when allocation space.
Jeremy.
Tim Potter [Tue, 7 Aug 2001 00:01:41 +0000 (00:01 +0000)]
A collection of fixes/cleanups to the security descriptor code by
matt_zinkevicius@hp.com
Tim Potter [Mon, 6 Aug 2001 23:29:25 +0000 (23:29 +0000)]
Fixed another possible memleak in cli_initialise()