Michael Adam [Mon, 2 Nov 2009 23:51:27 +0000 (00:51 +0100)]
s3:registry: add an extra check for dsize==0 to regdb_fetch_keys_internal()
Don't only rely on dptr == NULL.
I stumbled over this one when rewriting some of the dbwrap_ctdb code.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Mon, 2 Nov 2009 23:47:37 +0000 (00:47 +0100)]
s3:registry: add safety check for return value of tdb_unpack to regdb_fetch_keys_internal()
Prevents segfaults in some situations.
(For a non existent or empty record, we sometimes rely on the fetch operation
to return dsize==0 and sometimes we rely on dptr==NULL.)
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Sat, 31 Oct 2009 12:16:34 +0000 (13:16 +0100)]
s3:dbwrap_ctdb: add debug message to transaction_fetch_start()
for the case that another local process has started a transaction
bewteen releasing the transaction_lock record and starting the
transaction.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Sat, 31 Oct 2009 12:13:04 +0000 (13:13 +0100)]
s3:dbwrap_ctdb: split combined check in two and add descriptive debug
in db_ctdb_transaction_fetch_start() for error conditions when re-fetching
the transaction_lock record inside the transaction
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Oct 2009 23:01:45 +0000 (00:01 +0100)]
s3:dbwrap_ctdb: fix race condition with concurrent transactions on the same node.
In ctdb_transaction_commit(), when the trans2_commit control fails, there
is a race condition in the 1 second sleep between the local transaction_cancel
and the call to ctdb_replay_transaction(): The database is not locked, and
neither is the transaction_lock record. So another client can start and possibly
complete a new transaction in this gap, but only on the same node: The locking
of the transaction_lock record on a different node which involves migration of
the record to the other node has been disabled by introduction of the
transaction_active flag on the db which closes precisely this gap from the start
of the commit until the call to TRANS2_FINISH or TRANS2_ERROR.
But this mechanism does not cover the case where a process on the same node
tries to start a transaction: There is no obstacle to locking the transaction_lock
record because the record does not need to be migrated.
This commit closes this race condition in ctdb_transaction_fetch_start()
by using the new ctdb_ctrl_transaction_active() call to ask the local
ctdb daemon whether it has a transaction running on the database.
If so, the check is repeated until the running transaction is done.
This does introduce an additional call to the local ctdbd when starting
transactions, but it does close the (hopefully) last race condition.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Oct 2009 22:56:59 +0000 (23:56 +0100)]
s3:configure: add a check for the new CTDB_CONTROL_TRANS2_ACTIVE
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Oct 2009 22:56:03 +0000 (23:56 +0100)]
s3:dbwrap_ctdb: add new db_ctdb_transaction_active() that calls CTDB_CONTROL_TRANS2_COMMIT
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Oct 2009 00:54:04 +0000 (01:54 +0100)]
s3:dbwrap_ctdb: fix a race in starting concurrent transactions on a single node
There are two races in concurrent transactions on a single node.
One in starting a transaction and one with replay during commit.
This commit closes the first race by storing the client pid in the
transaction-lock record and comparing the stored pid against its own
pid after releasing the lock and refetching the record inside the
transaction.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Oct 2009 00:50:15 +0000 (01:50 +0100)]
s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch_start
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Oct 2009 00:28:38 +0000 (01:28 +0100)]
s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch()
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Mon, 2 Nov 2009 23:55:41 +0000 (00:55 +0100)]
s3:dbwrap_ctdb: add a function db_ctdb_ltdb_fetch()
This fetches a record from the db and splits out the ctdb header.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Thu, 22 Oct 2009 14:27:45 +0000 (16:27 +0200)]
s3:dbrwap_ctdb: add a function db_ctdb_ltdb_store()
and use it in db_ctdb_store() and db_ctdb_transaction_store().
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Thu, 22 Oct 2009 12:37:51 +0000 (14:37 +0200)]
s3:dbwrap_ctdb: reformat a comment slightly to enhance clearness.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Matt Kraai [Mon, 10 Aug 2009 20:50:31 +0000 (13:50 -0700)]
README.Coding: Fix typos.
Jeremy Allison [Mon, 9 Nov 2009 20:44:47 +0000 (12:44 -0800)]
Fix bug 6880 - cannot list workgroup servers
reported by Alban Browaeys <prahal@yahoo.com> with fix.
Revert
2e989bab0764c298a2530a2d4c8690258eba210c
with extra comments - this broke workgroup enumeration.
Jeremy.
(cherry picked from commit
5d516181617419b9b078b4f375753afc3b785ced)
Günther Deschner [Mon, 9 Nov 2009 15:02:24 +0000 (16:02 +0100)]
s3-param: fix set_inherit_acls().
Jeremy, please check.
Guenther
(cherry picked from commit
8eac3075b604d5d0938e2a087a154bb6546d78b1)
Volker Lendecke [Mon, 9 Nov 2009 16:06:48 +0000 (17:06 +0100)]
s3: Try to avoid dns searches with an empty site
Karolin Seeger [Mon, 9 Nov 2009 08:44:35 +0000 (09:44 +0100)]
WHATSNEW: Mention the new "ctdb timeout" parameter.
Karolin
Volker Lendecke [Sun, 8 Nov 2009 18:38:09 +0000 (19:38 +0100)]
Revert "s3: Do not directly reference the ndr_table_* in rpcclient"
This reverts commit
70c698fd547c4bc19cf77693608bbb34acac40b5.
Volker Lendecke [Sun, 8 Nov 2009 18:38:01 +0000 (19:38 +0100)]
Revert "s3: Do not reference ndr_table_<pipe> in the cli_ routines directly"
This reverts commit
daa964013bc5d036f4da571ce22c0052ef40943a.
Volker Lendecke [Sun, 8 Nov 2009 18:37:53 +0000 (19:37 +0100)]
Revert "s3: Consolidate getting the name out of a pipes_struct"
This reverts commit
9621306351cdb469ef393a6d8cbeea456bc4bd9f.
Volker Lendecke [Sun, 8 Nov 2009 18:37:42 +0000 (19:37 +0100)]
Revert "s3: Do not reference the ndr_tables in the server calls directly"
This reverts commit
98fb71782e05ae72cd6abeb38b6e0b96a50c1761.
Volker Lendecke [Sun, 8 Nov 2009 18:37:33 +0000 (19:37 +0100)]
Revert "s3: Do not reference ndr_table when calling rpc_srv_register"
This reverts commit
494b2aff8826947e3bd556aecb175746163da485.
Volker Lendecke [Sun, 8 Nov 2009 18:37:26 +0000 (19:37 +0100)]
Revert "s3: Make run_rpc_command take strings instead of a ndr_interface_table"
This reverts commit
53f2a1595e76db9fe1b42db65b51895b73365993.
Volker Lendecke [Sun, 8 Nov 2009 18:37:13 +0000 (19:37 +0100)]
Revert "s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table"
This reverts commit
5fc9d93408effe75abcd231c45cbc14656692ebe.
Volker Lendecke [Sun, 8 Nov 2009 11:31:38 +0000 (12:31 +0100)]
s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table
Volker Lendecke [Sun, 8 Nov 2009 11:24:06 +0000 (12:24 +0100)]
s3: Make run_rpc_command take strings instead of a ndr_interface_table
Volker Lendecke [Sun, 8 Nov 2009 10:35:53 +0000 (11:35 +0100)]
s3: Do not reference ndr_table when calling rpc_srv_register
Volker Lendecke [Sun, 8 Nov 2009 09:51:34 +0000 (10:51 +0100)]
s3: Do not reference the ndr_tables in the server calls directly
This involves storing the interface table in the pipes_struct
Volker Lendecke [Sun, 8 Nov 2009 09:43:34 +0000 (10:43 +0100)]
s3: Consolidate getting the name out of a pipes_struct
Volker Lendecke [Sun, 8 Nov 2009 08:53:08 +0000 (09:53 +0100)]
s3: Do not reference ndr_table_<pipe> in the cli_ routines directly
Volker Lendecke [Sun, 1 Nov 2009 19:21:52 +0000 (20:21 +0100)]
s3: Do not directly reference the ndr_table_* in rpcclient
Volker Lendecke [Fri, 6 Nov 2009 13:04:49 +0000 (14:04 +0100)]
tdb: Fix a C++ warning
Volker Lendecke [Sat, 7 Nov 2009 09:28:40 +0000 (10:28 +0100)]
s3: Do the printing for DEBUGLEVEL>=10 centrally
12 insertions(+), 10651 deletions(-)
I think that says it all :-)
Volker Lendecke [Sun, 1 Nov 2009 11:05:14 +0000 (12:05 +0100)]
s3: Register the ndr_interfaces dynamically
Volker Lendecke [Sun, 1 Nov 2009 10:33:59 +0000 (11:33 +0100)]
s3: Get rid of a NULL terminator
Volker Lendecke [Sat, 31 Oct 2009 19:04:54 +0000 (20:04 +0100)]
s3: Get rid of explicit pipe names
Volker Lendecke [Sat, 31 Oct 2009 18:28:16 +0000 (19:28 +0100)]
s3: get_pipe_name_from_iface -> get_pipe_name_from_syntax
Jeremy Allison [Sat, 7 Nov 2009 05:53:07 +0000 (21:53 -0800)]
Fix bug 6865 - acl_xattr module: Has dependency that inherit acls = yes or xattrs are removed.
Jeremy.
(cherry picked from commit
bd2ffb1c7a70ef9063b99a9318b3e185ddda84fe)
Jeremy Allison [Sat, 7 Nov 2009 01:03:29 +0000 (17:03 -0800)]
Fix bug 6841 - "map acl inherit = yes" not working.
The code to read the new V2 SAMBA_PAI entries had
two errors.
Jeremy.
(cherry picked from commit
afc592402068da2a928dd9975a38a6b1ccf3919f)
Günther Deschner [Fri, 6 Nov 2009 13:46:35 +0000 (14:46 +0100)]
s3-kerberos: let smb_krb5_get_tkt_from_creds() compile with older heimdal libs.
Guenther
(cherry picked from commit
11687e84e39291e9a0309d5df6dd088f71491593)
Günther Deschner [Wed, 30 Sep 2009 11:40:17 +0000 (13:40 +0200)]
s3-netlogon: implement _netr_GetDcName and _netr_GetAnyDcName.
Guenther
(cherry picked from commit
53d49bb7284a2d7281ad0ede20c37a6bd6d1794d)
Günther Deschner [Fri, 6 Nov 2009 12:48:23 +0000 (13:48 +0100)]
Revert "s3-kerberos: add smb_krb5_parse_name_flags()."
This reverts commit
17ef153b68795fec681f9ce17c198236aba2b1c2.
(cherry picked from commit
440db5a94e0ade69c9c258a54fa4d66b808d965c)
Günther Deschner [Thu, 5 Nov 2009 18:10:55 +0000 (19:10 +0100)]
s3-kerberos: support S4U2SELF impersionation through cli_krb5_get_ticket().
Guenther
(cherry picked from commit
9e48dc2b78226bdacb8988509eaa93e5c9d92787)
Günther Deschner [Thu, 5 Nov 2009 16:49:00 +0000 (17:49 +0100)]
s3-kerberos: use smb_krb5_get_credentials in ads_krb5_mk_req.
Guenther
(cherry picked from commit
bb01aae1b9eb1bede98b7d9a9c4920082db128fe)
Günther Deschner [Mon, 13 Oct 2008 15:29:22 +0000 (17:29 +0200)]
s3-kerberos: modify cli_krb5_get_ticket to take a new impersonate_princ_s arg.
Guenther
(cherry picked from commit
60bf0eb60788a5d4dc5de24997c5efda64f2bd73)
Günther Deschner [Fri, 6 Nov 2009 11:51:29 +0000 (12:51 +0100)]
s3-net: better use memory credential cache in net_ads_kerberos_pac().
Guenther
(cherry picked from commit
6ca8a40976f86f66713ba9a7b957f97a1c271016)
Günther Deschner [Mon, 13 Oct 2008 15:28:39 +0000 (17:28 +0200)]
s3-net: allow to call "net ads kerberos pac <impersonation principal> -P".
Guenther
(cherry picked from commit
58184b5fd4e95bc7ad2179237808126411509eea)
Günther Deschner [Mon, 13 Oct 2008 15:27:21 +0000 (17:27 +0200)]
s3-kerberos: add impersonate_principal for kerberos_return_pac_X calls.
Guenther
(cherry picked from commit
5e266225108aa3335476cbe1214cc0f484c4fd02)
Günther Deschner [Mon, 13 Oct 2008 15:25:35 +0000 (17:25 +0200)]
s3-kerberos: add smb_krb5_get_tkt_from_creds().
Guenther
(cherry picked from commit
4ffbfc4475c92b9190811bd189802ff265aa6846)
Günther Deschner [Fri, 6 Nov 2009 09:25:53 +0000 (10:25 +0100)]
s3-kerberos: fix some build warnings when building against heimdal.
Guenther
(cherry picked from commit
bb75f713d628073c503b06a3d217195aa95d72b2)
Günther Deschner [Mon, 13 Oct 2008 15:22:37 +0000 (17:22 +0200)]
s3-kerberos: add smb_krb5_get_{creds,credentials} incl. support for S4U2SELF impersonation.
Guenther
(cherry picked from commit
35dcc133c9c26d10186fe59ea096a2a5c87958e6)
Günther Deschner [Mon, 13 Oct 2008 15:27:43 +0000 (17:27 +0200)]
s3-kerberos: remove duplicate prototype.
Guenther
(cherry picked from commit
0729df3661fefeffc5154c9b01ae027b3ede4b92)
Günther Deschner [Thu, 5 Nov 2009 18:02:55 +0000 (19:02 +0100)]
s3-kerberos: add smb_krb5_parse_name_flags().
Guenther
(cherry picked from commit
17ef153b68795fec681f9ce17c198236aba2b1c2)
Günther Deschner [Mon, 13 Oct 2008 15:21:22 +0000 (17:21 +0200)]
s3-kerberos: add configure checks for krb5_get_creds_X api.
Guenther
(cherry picked from commit
2cd507fe144c58a4c856c73ec56b80365dad9f23)
Günther Deschner [Tue, 3 Nov 2009 23:34:29 +0000 (00:34 +0100)]
s3-netlogon: make sure we protect some function codes in _netr_LogonControl2Ex().
Guenther
(cherry picked from commit
ccdd1462cc8d7e5e067b5f3d6122ee8765921b4f)
Günther Deschner [Mon, 19 Oct 2009 09:28:00 +0000 (11:28 +0200)]
s3-netlogon: let s3 pass against RPC-NETLOGON-S3 again.
Guenther
(cherry picked from commit
bb2e1ff6315f070b67d45600dd763011f8aba136)
Günther Deschner [Wed, 7 Oct 2009 22:58:02 +0000 (00:58 +0200)]
s3-netlogon: implement _netr_NETLOGON_INFO_4 in netr_LogonControl2Ex() and friends as well.
Guenther
(cherry picked from commit
40f3f456bcea3d37537e807dbcd3a09b08dbc870)
Günther Deschner [Wed, 7 Oct 2009 22:38:53 +0000 (00:38 +0200)]
s3-netlogon: implement remote trust account changing in netr_LogonControl2Ex() and friends.
Guenther
(cherry picked from commit
b3a21474971d3ffd6135011daa5f2fe521f535d1)
Jeremy Allison [Fri, 6 Nov 2009 06:58:12 +0000 (22:58 -0800)]
Got the logic simplification worked out so we still pass
BASE-DELAYWRITE and also RAW-CLOSE.
Jeremy.
(cherry picked from commit
c99dd5c23e25f4c1cc34f223f563915c0aa4bb6f)
Jeremy Allison [Fri, 6 Nov 2009 05:27:25 +0000 (21:27 -0800)]
Revert commit "
0551284dc08eb93ef7b2b2227a45e5ec21d482fb" - simplify
the logic. This was incorrect (I'll revisit this tomorrow).
Jeremy.
(cherry picked from commit
977fa4e37741d613df1583b7e0e83c1f0a6ce38c)
Jeremy Allison [Fri, 6 Nov 2009 01:43:33 +0000 (17:43 -0800)]
Remove the smbd:writetimeupdatedelay change Metze added. Metze please
explain why you added this. Change --maximum-runtime=900 for smbtorture4
with BASE-DELAYWRITE. Should allow it to successfully complete now.
Jeremy.
(cherry picked from commit
e434934526b23b34dd85b43495961260dc639e1f)
Jeremy Allison [Fri, 6 Nov 2009 01:40:01 +0000 (17:40 -0800)]
Simplify the logic - remove extraneous argument and calls to set_close_write_time().
We were treating a file time set on close as a sticky write time set, and I don't
think it is. I will add a torture test later to RAW-CLOSE to confirm this.
Jeremy.
(cherry picked from commit
0551284dc08eb93ef7b2b2227a45e5ec21d482fb)
Jeremy Allison [Fri, 6 Nov 2009 01:12:11 +0000 (17:12 -0800)]
Fix explicit set of write time on close.
Jeremy.
(cherry picked from commit
2f09516a6be67d3e51ffc611ae2daa3210f07cd8)
Jeremy Allison [Fri, 6 Nov 2009 00:20:11 +0000 (16:20 -0800)]
Get closer to an accurate model of Windows timestamp changes.
"Normal" non truncate writes always cause the timestamp to
be set on close. Once a close is done on a handle this can
reset the sticky write time to current time also.
Updated smbtorture4 confirms this.
Jeremy.
(cherry picked from commit
7f9fe127ba31e6dd064d090d5ffc8eeb377627ab)
Jeremy Allison [Thu, 5 Nov 2009 23:37:26 +0000 (15:37 -0800)]
Fix up some of the timing constants for DELAYWRITE. Add some extra tests up test_delayed_write_update6
to investigate what happens to a sticky write handle after a second handle close.
Jeremy.
(cherry picked from commit
c2df97f57ce205935c37cd5a90cfeddb129cd92b)
Volker Lendecke [Thu, 5 Nov 2009 14:06:21 +0000 (15:06 +0100)]
s3: Fix a crash in notify_remove_onelevel when "change notify = no"
Volker Lendecke [Thu, 5 Nov 2009 13:29:05 +0000 (14:29 +0100)]
s3: Fix the talloc hierarchy in notify_remove_onelevel
We want to free the record early, not when talloc_tos() is free'ed.
Volker Lendecke [Tue, 3 Nov 2009 04:41:02 +0000 (05:41 +0100)]
s3: Add parameter "ctdb timeout"
When something in the cluster blocks, it can happen that we wait indefinitely
long for ctdb, just adding to the blocking condition. In theory, nothing should
block, but as someone said "In practice the difference between theory and
practice is larger than in theory". This adds a timeout parameter in seconds,
after which we stop waiting for ctdb and panic.
Bo Yang [Fri, 6 Nov 2009 00:20:25 +0000 (08:20 +0800)]
s3: Fix kerberos refresh chain.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
dde1c420037bfea48741ba1f600c047cca788a21)
Jeremy Allison [Thu, 5 Nov 2009 00:04:41 +0000 (16:04 -0800)]
Fix debug comment (brain wasn't working...).
Jeremy.
(cherry picked from commit
170d6a3084dcf4a72d5bc7dca69b1036431e0022)
Jeremy Allison [Wed, 4 Nov 2009 23:25:15 +0000 (15:25 -0800)]
Filter the returned DOS attributes by 0xFF for clients
using older protocols (LANMAN2 or below).
Jeremy.
(cherry picked from commit
f44d3754eeefb1a0d0282a424ae9901d72301766)
Jeremy Allison [Wed, 4 Nov 2009 23:15:50 +0000 (15:15 -0800)]
Remove "Protocol" as an extern, and add accessor functions.
Jeremy.
(cherry picked from commit
cbafe17bb37acfb76acf9d9905be1029e274089e)
Björn Jacke [Wed, 4 Nov 2009 10:15:31 +0000 (11:15 +0100)]
s3: add support for full windows timestamps resolution on files
setting nanosecond timestamps using utimensat() was first supported by Linux
kernel 2.6.22 and glibc 2.6. It's specified in POSIX.1-2008.
This effectively makes us use Windows' full 100ns timestamp resolution -
actually just an improvement from 10^-6 to 10^-7.
For now Linux CIFS vfs will also just be able to make use of 100ns resolution,
not 1ns.
Björn Jacke [Tue, 3 Nov 2009 19:07:29 +0000 (20:07 +0100)]
WHATSNEW: Update release notes
Jeremy Allison [Tue, 3 Nov 2009 22:20:21 +0000 (14:20 -0800)]
Make samba3-idl to fix the build.
Jeremy.
Jeremy Allison [Tue, 3 Nov 2009 21:41:22 +0000 (13:41 -0800)]
Merge branch 'v3-5-test' of ssh://jra@git.samba.org/data/git/samba into v3-5-test
Günther Deschner [Tue, 3 Nov 2009 10:45:15 +0000 (11:45 +0100)]
s3-lsa: fill in some more info levels in _lsa_QueryInfoPolicy().
Add dummys (just like s4 does) and fill in some more appropriate error codes.
Guenther
(cherry picked from commit
97496bb3cafd8914a3a7c7b7d3a668ba3e533769)
Günther Deschner [Tue, 3 Nov 2009 10:46:07 +0000 (11:46 +0100)]
s4-smbtorture: skip three info levels while testing s3 with RPC-LSA.
These are only supported by s3 when running pdb_ads atm.
Guenther
(cherry picked from commit
a8de4f091ef10223e862b3cb6f0b9e5cef5cde2a)
Günther Deschner [Mon, 2 Nov 2009 19:11:14 +0000 (20:11 +0100)]
s4-smbtorture: skip QueryInfoPolicy2 while running RPC-LSA against s3.
This is only supported by s3 when running pdb_ads atm.
Guenther
(cherry picked from commit
58d401bb212b43d05213514f8bb2efa850d4e5c9)
Günther Deschner [Mon, 2 Nov 2009 15:51:00 +0000 (16:51 +0100)]
s4-smbtorture: skip QueryDomainInformationPolicy test against s3 in RPC-LSA.
Guenther
(cherry picked from commit
bff9819521255b3dcd0f04aa585c1ad0385896fd)
Günther Deschner [Mon, 2 Nov 2009 18:59:47 +0000 (19:59 +0100)]
s4-smbtorture: simplify some torture_comments in RPC-LSA.
Guenther
(cherry picked from commit
074ad24653e85c60b9af863ac526832229754a96)
Günther Deschner [Fri, 30 Oct 2009 01:15:45 +0000 (02:15 +0100)]
s3-passdb: cleanup some callers of pdb_get_trusteddom_pw().
Guenther
(cherry picked from commit
463b1eb2b55ae85cfc9539c936375a989cde1076)
Günther Deschner [Mon, 5 Oct 2009 13:10:35 +0000 (15:10 +0200)]
libndr: add int3264 ndr prototype.
Guenther
(cherry picked from commit
76feeb1b97b1d8f24650c5198e9c61c4f5b1357a)
Andrew Tridgell [Tue, 6 Oct 2009 19:39:03 +0000 (06:39 +1100)]
tdr: teach TDR about uint1632 enums
TDB doesn't have NDR64, but it needs to know how to map the new types
from pidl
(cherry picked from commit
1d0fb1e0fba3cf4d04d4602ed4e717912804e5de)
Andrew Tridgell [Tue, 6 Oct 2009 09:49:14 +0000 (20:49 +1100)]
pidl: update PIDL tests for uint1632 enums
(cherry picked from commit
7816f9d7abf5203537c3bb7afb9511b00d2d974f)
Andrew Tridgell [Tue, 6 Oct 2009 09:47:09 +0000 (20:47 +1100)]
pidl: get the alignment right for uint1632 enums (NDR64)
The default enum in NDR63 is 32 bits, not 16 bits. We need a uint1632
type to get the alignment right.
(cherry picked from commit
2bf8a7485cf0733c808bc97a399a1c73bb988414)
Stefan Metzmacher [Tue, 3 Nov 2009 17:06:17 +0000 (18:06 +0100)]
tsocket: rewrite tsocket_guide.txt to reflect the current APIs
metze
(cherry picked from commit
97a32035bec03b76b67cb7088a7be1b7b3b9ac48)
Stefan Metzmacher [Tue, 3 Nov 2009 16:23:07 +0000 (17:23 +0100)]
tsocket_bsd: return -1 and set errno to ENAMETOOLONG if the unix path is too long
metze
(cherry picked from commit
eb39f6694055267302580bbf6afa988c82c55fed)
Stefan Metzmacher [Tue, 3 Nov 2009 16:22:27 +0000 (17:22 +0100)]
tsocket: remove prototype of non-existing tsocket_address_inet_set_broadcast()
metze
(cherry picked from commit
9b5d1e9e355d3d04f03744e025c6685ca8ad12cd)
Jeremy Allison [Tue, 3 Nov 2009 19:22:19 +0000 (11:22 -0800)]
Fix debug statements to use correct function name.
Jeremy.
(cherry picked from commit
31ce8eeb44d5060cfe85f42dc6ef092121b84a68)
Jeremy Allison [Tue, 3 Nov 2009 19:21:02 +0000 (11:21 -0800)]
requires_resume_key is a bool not int.
Jeremy.
(cherry picked from commit
7ae10fb892084b821f29dd36287d6deeb360ea13)
Jeremy Allison [Tue, 3 Nov 2009 19:19:24 +0000 (11:19 -0800)]
Fix more of the RAW-SEARCH test. Older info levels are
not 4 byte aligned (levels 1 - 3).
Jeremy.
(cherry picked from commit
6a61befe3798ecf0996887164f7437c3f25c33f9)
Günther Deschner [Wed, 7 Oct 2009 08:34:15 +0000 (10:34 +0200)]
s3: re-run make samba3-idl.
Guenther
(cherry picked from commit
fea2a78beb1cb4a00f44a4b191f96602cdaa81b9)
Volker Lendecke [Tue, 3 Nov 2009 09:59:18 +0000 (10:59 +0100)]
s3: Remove debug_ctx()
smbd just crashed on me: In a debug message I called a routine preparing a
string that itself used debug_ctx. The outer routine also used it after the
inner routine had returned. It was still referencing the talloc context
that the outer debug_ctx() had given us, which the inner DEBUG had already
freed.
Jeremy Allison [Tue, 3 Nov 2009 00:17:36 +0000 (16:17 -0800)]
Convert from numbers to correct SMB_FIND_XX constant names.
Jeremy.
Jeremy Allison [Mon, 2 Nov 2009 20:15:25 +0000 (12:15 -0800)]
Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a directory with a lot of files.
Jeremy.
Andrew Tridgell [Thu, 1 Oct 2009 06:08:02 +0000 (16:08 +1000)]
ndr64: added support for trailing gap alignment
NDR64 has a 'trailing gap' alignment, which aligns the end of a
structure on the overall structure alignment.
This explains the discrepancy we had with the RPC-SAMR test and NDR64
Volker Lendecke [Mon, 2 Nov 2009 15:59:15 +0000 (16:59 +0100)]
s3: Fix a 100% CPU loop when ctdbd dies during a traverse
Günther Deschner [Mon, 2 Nov 2009 12:01:58 +0000 (13:01 +0100)]
s3-gencache: restore gencache_get behavior with NULL args (with torture test).
Without this, we panic in wins_srv_is_dead() and fail to start nmbd with
wins support.
Volker, please check.
Guenther
(cherry picked from commit
f35a1b95aa6f50cb1bc919f4ab502ef2c38f6bf5)