Karolin Seeger [Fri, 9 Jan 2009 10:22:00 +0000 (11:22 +0100)]
docs: Improve man mount.cifs.
Add hint about specifying the workgroup in the credentials file.
Whitespace cleanup.
This fixes bug #4541.
Patch based on proposed patch from Christian Perrier <bubulle@debian.org>.
Thanks for reporting and providing a patch!
Karolin
(cherry picked from commit
1f7e09ea542df3a2f5f553c0cb11a39c74712950)
Tim Prouty [Fri, 9 Jan 2009 01:21:08 +0000 (17:21 -0800)]
s3: Remove a few unnecessary checks from the streams depot module and fix to work with NTRENAME
Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.
The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
Tim Prouty [Fri, 9 Jan 2009 01:20:14 +0000 (17:20 -0800)]
s3: Remove a few unnecessary checks from the streams xattr module
Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.
The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
Tim Prouty [Fri, 9 Jan 2009 01:19:24 +0000 (17:19 -0800)]
s3: Allow renames of streams via NTRENAME and fix stream error codes on rename
The test_streams_rename2 test in RAW-STREAMS verifies these changes
Jeremy Allison [Thu, 8 Jan 2009 23:42:38 +0000 (15:42 -0800)]
Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
Jeremy Allison [Thu, 8 Jan 2009 18:34:23 +0000 (10:34 -0800)]
Fix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.
We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
Jeremy Allison [Wed, 7 Jan 2009 22:55:13 +0000 (14:55 -0800)]
Fix bug #6016 - Alternate Data Streams / Extended Attributes seem to conflict.
Jeremy.
boyang [Wed, 7 Jan 2009 19:01:48 +0000 (11:01 -0800)]
refresh sequence number as soon as possible when domain->sequence_number == -1 or domain->last_status is not ok.
Jeremy Allison [Wed, 7 Jan 2009 01:35:34 +0000 (17:35 -0800)]
Make winbindd_cm.c use winbindd_reinit_after_fork().
Jeremy.
Jeremy Allison [Wed, 7 Jan 2009 00:06:22 +0000 (16:06 -0800)]
Fix bug #6017, - magic script does not work. based on a patch from monyo@samba.gr.jp.
Jeremy.
Jeremy Allison [Tue, 6 Jan 2009 23:15:30 +0000 (15:15 -0800)]
Add winbindd_reinit_after_fork(), cleaning out all possible events
in a forked child.
Jeremy.
Jeremy Allison [Tue, 6 Jan 2009 21:16:25 +0000 (13:16 -0800)]
Factor out lots of common code into a function.
Jeremy.
Stefan Metzmacher [Tue, 6 Jan 2009 19:22:08 +0000 (11:22 -0800)]
s3:events: change event_add_timed() prototype to match samba4
metze
Volker Lendecke [Tue, 6 Jan 2009 14:13:43 +0000 (15:13 +0100)]
s3/swat: Fix creation of the first share using SWAT.
This fixes bug #5965.
Karolin Seeger [Tue, 6 Jan 2009 11:26:23 +0000 (12:26 +0100)]
docs: Improve description of the share commands in man smb.conf.
-Correct the parameter names.
-Fix typos.
-Fix related parameters.
This fixes bug #6008.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
Karolin
(cherry picked from commit
8b7f66c548ed170d2dab0c91ccff4aca00f4b52d)
Karolin Seeger [Tue, 6 Jan 2009 09:26:37 +0000 (10:26 +0100)]
docs: Fix example in man vfs_recycle.
This fixes bug #6001.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
Karolin
(cherry picked from commit
9f44a17c3bf36067d04cec036c3e529798932cd7)
Bo Yang [Tue, 6 Jan 2009 05:12:03 +0000 (21:12 -0800)]
set entry->refresh_time to make ccache_regain_all_now() work correctly.
Stefan Metzmacher [Tue, 6 Jan 2009 05:06:25 +0000 (21:06 -0800)]
s3:events: get rid of the stupid set_event_dispatch_time() function
metze
Stefan Metzmacher [Tue, 6 Jan 2009 05:05:48 +0000 (21:05 -0800)]
s3:events: get rid of the stupid cancel_named_event() function
metze
Stefan Metzmacher [Tue, 6 Jan 2009 05:05:20 +0000 (21:05 -0800)]
s3:events: move prototypes to event.h
metze
Stefan Metzmacher [Tue, 6 Jan 2009 04:55:24 +0000 (20:55 -0800)]
s3:events: remove unused stuff
metze
Stefan Metzmacher [Tue, 6 Jan 2009 04:54:03 +0000 (20:54 -0800)]
s3:winbindd: regain tickets for all ccache entries, when we go online
set_event_dispatch_time() is stupid by design and only handles
the first event with a given name.
metze
Stefan Metzmacher [Tue, 6 Jan 2009 04:40:19 +0000 (20:40 -0800)]
s3:winbindd: cancel all ccache entry events and not just one
cancel_named_event() is stupid by design and also only cancels
one single event.
metze
Stefan Metzmacher [Tue, 6 Jan 2009 04:35:03 +0000 (20:35 -0800)]
s3:winbindd: recreate the per domain check_online_event without relying on global state
set_event_dispatch_time() is stupid by design and just picks the first
event with the given name.
metze
Stefan Metzmacher [Tue, 6 Jan 2009 04:20:31 +0000 (20:20 -0800)]
s3:winbindd: rename fd_event => winbindd_fd_event
It's really confusing to have two versions of 'fd_event'
metze
Stefan Metzmacher [Tue, 6 Jan 2009 04:12:30 +0000 (20:12 -0800)]
s3:winbindd: move WINBINDD_CCACHE_ENTRY and WINBINDD_MEMORY_CREDS to winbindd.h
metze
Bo Yang [Tue, 6 Jan 2009 04:05:53 +0000 (20:05 -0800)]
Fix broken krb5 refresh chain
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Bo Yang [Tue, 6 Jan 2009 00:19:48 +0000 (16:19 -0800)]
clean event context after child is forked.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jeremy Allison [Mon, 5 Jan 2009 19:42:52 +0000 (11:42 -0800)]
Attempt to fix crash seen with new CUPS async printcap loading code.
Karolin please pull for 3.3.0.
Jeremy.
Karolin Seeger [Mon, 5 Jan 2009 15:33:00 +0000 (16:33 +0100)]
examples: Avoid bashism in perfcount.init.
This fixes bug #6000.
Thanks to the Debian Samba package maintainers for providing the patch!
Remove trailing whitespaces.
Karolin
(cherry picked from commit
2e09746a4db4186c9d648370b9004971bc18e5c9)
Karolin Seeger [Mon, 5 Jan 2009 15:35:11 +0000 (16:35 +0100)]
Revert "examples: Avoid bashism in perfcount.init."
This reverts commit
e273c07e94ee607bbf05b6fa66cf3cea13fe4502.
Karolin Seeger [Mon, 5 Jan 2009 15:16:18 +0000 (16:16 +0100)]
WHATSNEW: Update changes since 3.3.0rc2.
Karolin
Volker Lendecke [Mon, 5 Jan 2009 14:47:19 +0000 (15:47 +0100)]
Fix bug 6014 -- mget shouldn't segfault without arguments
Thanks to kevin.paulus@mtm.kuleuven.be for the bug report
Volker
Karolin Seeger [Mon, 5 Jan 2009 13:54:28 +0000 (14:54 +0100)]
examples: Avoid bashism in perfcount.init.
This fixes bug #6000.
Thanks to the Debian Samba package maintainers for providing the patch!
Remove trailing whitespaces.
Karolin
(cherry picked from commit
73875cd344608b591fa884ab99b5f3a10550c149)
Karolin Seeger [Mon, 5 Jan 2009 13:39:59 +0000 (14:39 +0100)]
docs: Document the -g option of smbclient.
This fixes bug #6013.
Thanks to the Debian Samba packages maintainers for reporting!
Karolin
(cherry picked from commit
6752d78e946b2c4278e2deba325c76fb7ffbc06a)
Volker Lendecke [Mon, 5 Jan 2009 12:41:39 +0000 (13:41 +0100)]
Fix a bad memleak in vfs_full_audit
Volker Lendecke [Mon, 5 Jan 2009 11:58:23 +0000 (12:58 +0100)]
Fix bug 6012: Add "get_real_filename" to full_audit
Thanks to Hodur <coil93@gmail.com> for testing!
Volker
Michael Adam [Thu, 18 Dec 2008 17:01:55 +0000 (18:01 +0100)]
smbd: prevent access to root filesystem when connecting with empty service name
This only applies to a setup with "registry shares = yes"
Michael
(cherry picked from commit
288fa94ac7cfdf7457b5098c33fc840bed3d5410)
(cherry picked from commit
e85526b184e66f86b7faa9d0a37288a09c12c19e)
Jeremy Allison [Sun, 4 Jan 2009 19:46:28 +0000 (11:46 -0800)]
Fix bug #6009 - Setting "min receivefile size = 1" breaks writes.
Karolin please pull for 3.3.0. Thanks !
Jeremy.
Volker Lendecke [Fri, 2 Jan 2009 13:53:26 +0000 (14:53 +0100)]
Alternative fix for
45db33e73 and
0d443ae7931
Simo is right, we need to ask passdb first. At least this fixes a nasty to find
NT_STATUS_ACCESS_DENIED problem in the build farm for the test run I just did
on host "opi".
Michael, can you re-check if this also fixes the error you found, leading to
the two fixes?
Thanks,
Volker
Volker Lendecke [Fri, 2 Jan 2009 14:02:03 +0000 (15:02 +0100)]
Revert "Fix uid_to_sid mapping when the idmap cache is empty."
This reverts commit
d4bc1f8d79929dc1a1d06e92eaf85923a1848e6f.
Volker Lendecke [Fri, 2 Jan 2009 14:01:47 +0000 (15:01 +0100)]
Revert "idmap: Remove passd check from idmap_backends_unixid_to_sid()."
This reverts commit
3d22b77f1ac5e8f83d1063d87c68e60655a3ed6b.
Michael Adam [Wed, 17 Dec 2008 21:27:39 +0000 (22:27 +0100)]
packaging(RHEL): fix typo in [u]mount.cifs installation
Michael
(cherry picked from commit
835108bcf84a5f47f46d237c7a93c572348125a1)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
71c74725bce403e36e4dc38287802c95b8d4de66)
Michael Adam [Wed, 17 Dec 2008 17:56:34 +0000 (18:56 +0100)]
packaging(RHEL): fix build of [u]mount.cifs
mount.cifs is now built by make everything.
And it needs extra objects anyways (mtab.o),
which is why the build of mount.cifs failed.
Michael
(cherry picked from commit
96c811cf222be5463a6705feae73d6215685c5f1)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
308dbca653ce1d689b75f9b781237c67df4233a8)
Karolin Seeger [Fri, 2 Jan 2009 12:48:48 +0000 (13:48 +0100)]
WHATSNEW: Update changes since 3.3.0rc2.
Karolin
Stefan Metzmacher [Fri, 2 Jan 2009 08:46:17 +0000 (09:46 +0100)]
Happy New Year!
metze
Volker Lendecke [Thu, 1 Jan 2009 21:05:03 +0000 (22:05 +0100)]
Fix bug 5913.
Never seen this to be a problem, but it doesn't hurt either :-)
Jeremy Allison [Thu, 1 Jan 2009 03:06:00 +0000 (19:06 -0800)]
Fix warnings in make test code.
Jeremy.
Jeremy Allison [Thu, 1 Jan 2009 01:27:52 +0000 (17:27 -0800)]
Fix all warnings with gcc4.3.
Jeremy.
Jeremy Allison [Thu, 1 Jan 2009 00:16:52 +0000 (16:16 -0800)]
Fix more asprintf and "ignoring return code" warnings from gcc 4.3.
Jeremy.
Volker Lendecke [Wed, 31 Dec 2008 17:37:39 +0000 (18:37 +0100)]
recvfile can't be used for printing so far
Stefan Metzmacher [Mon, 29 Dec 2008 15:31:57 +0000 (16:31 +0100)]
s3:winbindd: we don't need to call messaging_reinit() twice
reinit_after_fork() already calls messaging_reinit()
metze
(cherry picked from commit
429276556a4930fa1bc782904447120950073190)
Volker Lendecke [Tue, 30 Dec 2008 21:24:04 +0000 (22:24 +0100)]
Fix an ancient uninitialized variable read
The callers of open_file_ntcreate expect *psbuf to be filled correctly
Jeremy Allison [Wed, 31 Dec 2008 01:52:08 +0000 (17:52 -0800)]
Fix more "ignore return value" warnings from gcc 4.3.
Jeremy
Stefan Metzmacher [Thu, 18 Dec 2008 14:02:42 +0000 (15:02 +0100)]
s3:cluster: register the client connection via CTDB_CONTROL_TCP_ADD
This means we correctly pass IPv6 addresses too.
(CTDB_CONTROL_TCP_CLIENT was IPv4 only)
metze
(cherry picked from commit
465176b7e2fc1370dded850a80a8fe8519e79db8)
Stefan Metzmacher [Mon, 15 Dec 2008 18:28:27 +0000 (19:28 +0100)]
s3:pdb_tdb: store the next rid counter in passdb.tdb instead of winbind_idmap.tdb
This upgrades the TDBSAM_VERSION to 4 and SAMU_BUFFER_V4.
metze
(cherry picked from commit
7516ba860c160e8b971b6f5bc1036370169e6e8a)
Stefan Metzmacher [Tue, 16 Dec 2008 10:51:14 +0000 (11:51 +0100)]
s3:passdb: add SAMU_BUFFER_V4 with no changes
The upgrade is required because of the followin TDBSAM_VERSION
upgrade.
metze
(cherry picked from commit
671469ae7e3013809fe3995ec8f33dda9adda2ed)
Stefan Metzmacher [Mon, 15 Dec 2008 17:46:37 +0000 (18:46 +0100)]
s3:passdb: make marshalling struct samu from and to a buffer more generic
This marshalling isn't specific to tdbsam and it's
ugly to have the related functions in two different files.
metze
(cherry picked from commit
0544734309feea44e8d449737a9934231f63693d)
Volker Lendecke [Tue, 30 Dec 2008 14:47:06 +0000 (15:47 +0100)]
Fix a memory leak in cups_pull_comment_location
We allocated "request" with ippNew, so we also should ippDelete it.
Volker Lendecke [Tue, 30 Dec 2008 13:05:26 +0000 (14:05 +0100)]
Fix a spinning smbd when printing
Without this, we end up adding more than one timed event. In the event handler
print_notify_event_send_messages() only one event will be deleted, all others
will fire indefinitely.
Volker Lendecke [Mon, 29 Dec 2008 22:24:43 +0000 (23:24 +0100)]
Don't increment twice
Thanks metze :-)
Volker Lendecke [Mon, 29 Dec 2008 21:06:08 +0000 (22:06 +0100)]
Second part of the bugfix for #5933
Incrementing the next vuid did not correctly overflow
Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-)
Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
Volker Lendecke [Mon, 29 Dec 2008 21:01:57 +0000 (22:01 +0100)]
First part of bugfix for #5933
Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().
Jeremy, please check!
Stefan Metzmacher [Wed, 17 Dec 2008 16:16:50 +0000 (17:16 +0100)]
s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()
All callers expect 0 an success and -1 on error.
metze
(cherry picked from commit
a255f9ce713b29552722ec73e4038226959e1c8e)
Volker Lendecke [Mon, 22 Dec 2008 21:42:44 +0000 (22:42 +0100)]
Add code to test write_data_iov a bit
Volker Lendecke [Mon, 22 Dec 2008 21:32:12 +0000 (22:32 +0100)]
Attempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev
It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
Volker Lendecke [Mon, 22 Dec 2008 21:17:59 +0000 (22:17 +0100)]
Make write_data use write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:28 +0000 (22:17 +0100)]
Add write_data_iov
Volker Lendecke [Sun, 21 Dec 2008 22:22:30 +0000 (23:22 +0100)]
Add sys_writev
Volker Lendecke [Sun, 24 Aug 2008 10:46:26 +0000 (12:46 +0200)]
Fix some nonempty blank lines
(cherry picked from commit
010c7101e59477f0d5f3bf11c17f474ec6f79cc1)
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sun, 24 Aug 2008 10:43:36 +0000 (12:43 +0200)]
Fix some C++ warnings
(cherry picked from commit
dd9e4e6db04acf20f6ef7705955358c7ca442bbd)
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Thu, 25 Dec 2008 20:12:22 +0000 (12:12 -0800)]
Fix bug #5990 - strict allocate should be checked before ftruncate
reported by and based on a patch by Yasuma Takeda <yasuma@osstech.co.jp>.
Jeremy.
Michael Adam [Wed, 1 Oct 2008 06:53:15 +0000 (08:53 +0200)]
idmap: Remove passd check from idmap_backends_unixid_to_sid().
As noted by Metzy, it makes no sense here to check id->sid.
What is worse, this might even be passed in uninitialized.
This still fixes the bug for me (of course), but we might need
to check, if another special handling of passdb is needed
(possibly changing from constant return code NT_STATUS_OK...)
Michael
(cherry picked from commit
651b5d6deaab4fb3cb726fafd98171c79777631c)
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 1 Oct 2008 06:30:15 +0000 (08:30 +0200)]
Fix uid_to_sid mapping when the idmap cache is empty.
This failed for backends other than passed, since
idmap_backends_unixid_to_sid() always asked passdb first,
which returned Success no matter whether a mapping was
found or not.
One effect wast that getpwuid failed after "net cache flush".
Only after filling the cache with a getpwnam call it succeeded.
This fix makes the behaviour of idmap_backends_unixid_to_sid()
exactly the same as that of idmap_backends_sid_to_unixid()
Michael
(cherry picked from commit
da7eb5e22e56ea718e393375085cf66a90afafc8)
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Tue, 23 Dec 2008 20:10:47 +0000 (12:10 -0800)]
Fix more asprintf warnings and some error path errors.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:57:03 +0000 (11:57 -0800)]
More asprintf warning fixes.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:45:40 +0000 (11:45 -0800)]
More asprintf warning fixes.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:29:02 +0000 (11:29 -0800)]
Fix more asprintf errors and error code paths.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 18:42:38 +0000 (10:42 -0800)]
Fix more ‘asprintf’, declared with attribute warn_unused_result.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 18:27:37 +0000 (10:27 -0800)]
Fix more "warning: ignoring return value of ‘asprintf’, declared with
attribute warn_unused_result"
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 17:49:47 +0000 (09:49 -0800)]
Fix another "format not a string literal and no format arguments" warning.
Jeremy
Tim Prouty [Tue, 23 Dec 2008 17:20:06 +0000 (09:20 -0800)]
s3: Fix stream marshalling to return the correct streaminfo status
When there are enough streams on a file to fill up the max_data_count
when responding to a trans2 streaminfo, samba is returning
NT_STATUS_BUFFER_TOO_SMALL. Windows handles this by returning
NT_STATUS_BUFFER_OVERFLOW while still sending as much of the data that
it can fit into the buffer. When the windows client sees
BUFFER_OVERFLOW, it retries the streaminfo with a larger buffer (2x).
The windows client starts at 2K and will continue increasing the
buffer size by two until it reaches 64K. If the streams don't fit in
64K the windows client seems to give up.
This patch fixes marshall_stream_info to overfill the buffer by 1
stream so that send_trans2_replies can properly detect the overflow
and return the correct status.
Jeremy Allison [Tue, 23 Dec 2008 04:05:45 +0000 (20:05 -0800)]
In gcc version 4.3.2 we get warnings for functions declared with
attribute warn_unused_result. Start to fix these.
Jeremy.
Gerald (Jerry) Carter [Mon, 22 Dec 2008 19:06:29 +0000 (11:06 -0800)]
Fix "allow trusted domain" so it disables trusted domains.
Karolin Seeger [Sun, 21 Dec 2008 08:15:17 +0000 (09:15 +0100)]
WHATSNEW: Add "ldap ssl = start tls" to the release notes.
Karolin
root [Sun, 21 Dec 2008 07:55:30 +0000 (08:55 +0100)]
s3:loadparm/docs: Set default for "ldap ssl" to "start tls".
This has been discussed on samba-technical before.
3.3 and newer only!
Karolin
Karolin Seeger [Sun, 21 Dec 2008 07:23:39 +0000 (08:23 +0100)]
s3: loadparm: Clean-up list of parameters.
We don't need to list several combinations of lowercase and uppercase here.
Karolin
Jeremy Allison [Fri, 19 Dec 2008 21:58:22 +0000 (13:58 -0800)]
Fix bug #5986 - Editing a stream is broken (rename problems).
Jeremy.
Volker Lendecke [Fri, 19 Dec 2008 20:05:19 +0000 (12:05 -0800)]
Fix a "ignoring function call result" warning
Björn Jacke [Fri, 19 Dec 2008 11:12:59 +0000 (12:12 +0100)]
correct the description of the "ldap timeout" parameter
(cherry picked from commit
1aff97bc48844afba5de48447fdcdcc02d163a97)
Jeremy Allison [Thu, 18 Dec 2008 23:36:34 +0000 (15:36 -0800)]
Comment out the parent inheritance code (this is incorrect) as was
done for POSIX ACLs.
Jeremy.
Jeremy Allison [Thu, 18 Dec 2008 21:28:09 +0000 (13:28 -0800)]
Fix bug #5980 - Race condition when granting level2 oplocks can cause break notify to be missed.
Jeremy.
Jeremy Allison [Thu, 18 Dec 2008 01:22:34 +0000 (17:22 -0800)]
Fix bug #5979 - Level 2 oplocks being granted improperly,
Jeremy.
Michael Adam [Wed, 17 Dec 2008 21:27:39 +0000 (22:27 +0100)]
packaging(RHEL-CTDB): fix typo in [u]mount.cifs installation
Michael
(cherry picked from commit
835108bcf84a5f47f46d237c7a93c572348125a1)
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 17 Dec 2008 17:56:34 +0000 (18:56 +0100)]
packaging(RHEL-CTDB): fix build of [u]mount.cifs
mount.cifs is now built by make everything.
And it needs extra objects anyways (mtab.o),
which is why the build of mount.cifs failed.
Michael
(cherry picked from commit
96c811cf222be5463a6705feae73d6215685c5f1)
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 17 Dec 2008 15:59:24 +0000 (16:59 +0100)]
packaging(RHEL-CTDB): Fix accidential linebreak
Michael
(cherry picked from commit
5cd8ff8a2aba6b1d6821d4ebb986449b03d40542)
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 17 Dec 2008 17:14:09 +0000 (18:14 +0100)]
Fix a valgrind error
Reported by naga_kishore_kommuri@yahoo.com
Derrel, please check!
Thanks,
Volker
(cherry picked from commit
3356b95f72e26ede4ab16a12c334be90b8b1a639)
Karolin Seeger [Wed, 17 Dec 2008 15:26:43 +0000 (16:26 +0100)]
s3/smb.h: Remove unused LDAP_SSL_ON.
LDAP_SSL_ON is not defined at all.
Ldaps can be used by specifying an ldaps URL using the "passdb backend"
parameter.
Karolin
Karolin Seeger [Wed, 17 Dec 2008 14:53:51 +0000 (15:53 +0100)]
s3/loadparm.c: Change default value for "ldap ssl".
LDAP_SSL_ON is not defined at all. That's why the actual default value
was "" for a long time. Set a more sensible default value without chnging the
default behaviour.
-----8<------------------snip--------------8<--------------
user@host:/data/git/samba/v3-0-test/source> git grep LDAP_SSL_ON | cat
include/smb.h:enum ldap_ssl_types {LDAP_SSL_ON, LDAP_SSL_OFF,
LDAP_SSL_START_TLS};
param/loadparm.c: Globals.ldap_ssl = LDAP_SSL_ON;
----->8------------------snap-------------->8--------------
It's the same in 3.2 and 3.3 series.
Karolin
Karolin Seeger [Wed, 17 Dec 2008 15:28:59 +0000 (16:28 +0100)]
docs: Fix typo in man idmap_hash.
Karolin
(cherry picked from commit
994ef68164c12a3b0494f6491bc9f402c912600f)