Volker Lendecke [Mon, 30 Jul 2007 10:20:52 +0000 (10:20 +0000)]
r24077: Convert reply_tdis to the new API
Stefan Metzmacher [Mon, 30 Jul 2007 08:22:45 +0000 (08:22 +0000)]
r24072: Add "client ldap sasl wrapping" parameter.
Possible values are "plain" (default), "sign" or "seal".
metze
Volker Lendecke [Mon, 30 Jul 2007 07:50:24 +0000 (07:50 +0000)]
r24071: Fix a missing END_PROFILE call
Volker Lendecke [Sun, 29 Jul 2007 16:40:45 +0000 (16:40 +0000)]
r24070: Apply some const
Volker Lendecke [Sun, 29 Jul 2007 09:51:06 +0000 (09:51 +0000)]
r24069: Fix Coverity ID 368. We would segfault if 0 < data.dsize < 8
Volker Lendecke [Sun, 29 Jul 2007 09:23:55 +0000 (09:23 +0000)]
r24068: Fix Coverity id 366 (dead code). We have checked for argc >= 3 above.
Volker Lendecke [Sat, 28 Jul 2007 18:52:28 +0000 (18:52 +0000)]
r24067: Fix a type mismatch found by the IBM checker
Günther Deschner [Fri, 27 Jul 2007 09:22:43 +0000 (09:22 +0000)]
r24066: Fix memleak found by Volker. We don't leak keys now with MIT and Heimdal.
Guenther
Volker Lendecke [Fri, 27 Jul 2007 09:15:13 +0000 (09:15 +0000)]
r24065: According to gd, this breaks heimdal. Thanks for checking!
Stefan Metzmacher [Fri, 27 Jul 2007 07:19:36 +0000 (07:19 +0000)]
r24062: fix logic for broken krb5 libs which always force
sign and seal...
metze
Volker Lendecke [Thu, 26 Jul 2007 17:27:03 +0000 (17:27 +0000)]
r24058: Fix some memory leaks in ads_secrets_verify_ticket.
Jeremy, Günther, please review!
Thanks,
Volker
Volker Lendecke [Thu, 26 Jul 2007 16:39:48 +0000 (16:39 +0000)]
r24057: Fix some uninitialized variables found by the IBM checker
Volker Lendecke [Thu, 26 Jul 2007 16:01:12 +0000 (16:01 +0000)]
r24056: Another big one: This converts reply_sesssetup_and_X to the new API. As usual,
its history can be found on http://samba.org/~vlendec/sesssetup/. This very
obviously needs close review.
Volker
Gerald Carter [Thu, 26 Jul 2007 12:08:13 +0000 (12:08 +0000)]
r24055: Remove a reference to the outdated samba-docs mailing list. This entire
README really needs to be overhauled at some point.
Volker Lendecke [Thu, 26 Jul 2007 07:48:14 +0000 (07:48 +0000)]
r24054: Fix some warnings
Volker Lendecke [Wed, 25 Jul 2007 20:01:03 +0000 (20:01 +0000)]
r24050: Fix a typo
Volker Lendecke [Wed, 25 Jul 2007 18:53:16 +0000 (18:53 +0000)]
r24049: Some more 64-bit warnings
Volker Lendecke [Wed, 25 Jul 2007 18:47:40 +0000 (18:47 +0000)]
r24048: Fix the C++ warnings in our version of popt
Volker Lendecke [Wed, 25 Jul 2007 18:45:57 +0000 (18:45 +0000)]
r24047: With -Wmissing-prototypes these two always generate warnings. They
should be properly prototyped. For now, gloss over the warning.
Volker Lendecke [Wed, 25 Jul 2007 18:39:10 +0000 (18:39 +0000)]
r24046: Fix a 64-bit warning
Volker Lendecke [Wed, 25 Jul 2007 13:05:54 +0000 (13:05 +0000)]
r24044: Fix an uninitialized variable warning
Stefan Metzmacher [Wed, 25 Jul 2007 10:34:16 +0000 (10:34 +0000)]
r24042: add support for krb5 sign and seal in LDAP via "GSS-SPNEGO"
metze
Stefan Metzmacher [Wed, 25 Jul 2007 08:09:34 +0000 (08:09 +0000)]
r24039: remove unused global variable...
metze
Stefan Metzmacher [Wed, 25 Jul 2007 07:23:20 +0000 (07:23 +0000)]
r24037: only setup sasl wrapping after a successful bind
metze
Jeremy Allison [Tue, 24 Jul 2007 22:28:19 +0000 (22:28 +0000)]
r24036: Fix dfs rename bug in smbclient reported by Thomas Bork <tombork@web.de>.
Couldn't rename file as we weren't DFS enabling the target path.
Jeremy.
Volker Lendecke [Tue, 24 Jul 2007 11:50:54 +0000 (11:50 +0000)]
r24034: Print the full cluster pid in print_lock_struct
Volker Lendecke [Tue, 24 Jul 2007 11:48:35 +0000 (11:48 +0000)]
r24033: We need to be able to cope with packet_handler calling itself
recursively
Volker Lendecke [Tue, 24 Jul 2007 11:47:37 +0000 (11:47 +0000)]
r24032: It helps testing tremendously if the cluster messaging actually sends
and receives messages to other nodes... :-)
Volker Lendecke [Tue, 24 Jul 2007 11:45:29 +0000 (11:45 +0000)]
r24031: Fix some 64 bit warnings
Stefan Metzmacher [Tue, 24 Jul 2007 10:35:10 +0000 (10:35 +0000)]
r24029: merge from samba.org/~tridge/samba_3_2_ctdb/:
the claim_connection() must come after the sockets are open
metze
Stefan Metzmacher [Tue, 24 Jul 2007 10:24:27 +0000 (10:24 +0000)]
r24027: merge from people.samba.org/bzr/metze/samba/3_2-ctdb-metze/:
add in any cluster addresses. We need to response to these,
but not listen on them. This allows us to run nmbd on every
node in the cluster, and have all of them register with a
WINS server correctly
metze
Stefan Metzmacher [Tue, 24 Jul 2007 09:47:26 +0000 (09:47 +0000)]
r24025: packet_send() expects DATA_BLOB elements as vaargs
and not TDB_DATA
metze
Günther Deschner [Tue, 24 Jul 2007 09:46:21 +0000 (09:46 +0000)]
r24024: Minor cleanup in ads_parse_gp_ext().
Guenther
Günther Deschner [Tue, 24 Jul 2007 09:42:15 +0000 (09:42 +0000)]
r24023: Correctly support REG_BINARY in registry_push_value() and
registry_pull_value().
Guenther
Stefan Metzmacher [Tue, 24 Jul 2007 09:32:05 +0000 (09:32 +0000)]
r24021: use MSG_BROADCAST_PID_STR as value for broadcast messages
to fix the cluster case
vl: please check, if this works with clustering = no
metze
Stefan Metzmacher [Tue, 24 Jul 2007 09:20:23 +0000 (09:20 +0000)]
r24019: merge from people.samba.org/bzr/metze/samba/3_2-ctdb-metze/:
use a timed event to make sure the timelimit is correctly
handled in smbcontrol when waiting for messages
metze
Stefan Metzmacher [Tue, 24 Jul 2007 08:59:36 +0000 (08:59 +0000)]
r24017: merge from samba.org/~tridge/samba_3_2_ctdb/:
add add_trusted_domain() can return NULL
metze
Stefan Metzmacher [Tue, 24 Jul 2007 08:42:21 +0000 (08:42 +0000)]
r24015: merge RHEL4-CTDB packaging stuff from
http://people.samba.org/bzr/metze/samba/3_2-ctdb-metze/
metze
Stefan Metzmacher [Tue, 24 Jul 2007 08:04:42 +0000 (08:04 +0000)]
r24013: merge from samba.org/~tridge/samba_3_2_ctdb/:
fixed prototype
metze
Volker Lendecke [Mon, 23 Jul 2007 19:46:48 +0000 (19:46 +0000)]
r24009: Revert to the 3.0.25 logic for parsing the client's protocols. hpisgr8
with gcc still gives timeouts which worry me.
Volker
Volker Lendecke [Mon, 23 Jul 2007 19:09:19 +0000 (19:09 +0000)]
r24008: Fix Bug 4792. Thanks to David Gajewski <dgajews@math.utoledo.edu> and to
Timur I. Bakeyev for bugging me :-)
Volker
Volker Lendecke [Mon, 23 Jul 2007 15:29:56 +0000 (15:29 +0000)]
r24007: Attempt to fix the build on host "gwen". The Makefile ended up with an
empty line.
Volker Lendecke [Mon, 23 Jul 2007 14:36:54 +0000 (14:36 +0000)]
r24006: Some more paranoia in reply_negprot
Some hosts see the smb_bufrem(req->inbuf, p) as an unsigned int. And as
the p += strlen(p) + 2 went one beyond the buffer, this was a very
large positive. Also take the chance to add one more consistency check.
Volker Lendecke [Mon, 23 Jul 2007 13:47:17 +0000 (13:47 +0000)]
r24005: Attempt to fix the build on host deckchair
Volker Lendecke [Mon, 23 Jul 2007 12:03:58 +0000 (12:03 +0000)]
r24004: Convert reply_checkpath to the new API
Volker Lendecke [Mon, 23 Jul 2007 11:38:29 +0000 (11:38 +0000)]
r24003: Convert reply_tcon_and_X to the new API
Volker Lendecke [Mon, 23 Jul 2007 11:18:20 +0000 (11:18 +0000)]
r24002: Convert reply_negprot to the new API
Volker Lendecke [Mon, 23 Jul 2007 11:08:43 +0000 (11:08 +0000)]
r24001: Separate out the parsing of the client's requested protocols
This way the range checking only needs to be done once
Volker Lendecke [Mon, 23 Jul 2007 10:52:39 +0000 (10:52 +0000)]
r24000: Add message_push_blob() and message_push_string().
The proposed new API convention is to start with a 0 bcc length and then
push things step by step. These routines reallocate the outbuf and
adjust the length and bcc fields as necessary.
Volker Lendecke [Mon, 23 Jul 2007 09:54:36 +0000 (09:54 +0000)]
r23999: Convert reply_open_and_X
This is an example of chained code that is executed in make test
Volker Lendecke [Mon, 23 Jul 2007 09:53:06 +0000 (09:53 +0000)]
r23998: Convert reply_close to the new API
Volker Lendecke [Mon, 23 Jul 2007 09:36:09 +0000 (09:36 +0000)]
r23997: Check in the infrastructure for getting rid of the global InBuffer/OutBuffer
The complete history of this patch can be found under
http://www.samba.org/~vlendec/inbuf-checkin/.
Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only
checking into 3_2 at the moment, as it currently will slow down operations for
all non-converted (i.e. all at this moment) operations, as it will copy the
talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort
to convert everything necessary for the normal operations an XP box does.
I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More
to come, but I would appreciate some help here.
Volker
Volker Lendecke [Mon, 23 Jul 2007 08:20:44 +0000 (08:20 +0000)]
r23996: One more const
Volker Lendecke [Sun, 22 Jul 2007 17:13:46 +0000 (17:13 +0000)]
r23992: Some const
Volker Lendecke [Sun, 22 Jul 2007 13:51:39 +0000 (13:51 +0000)]
r23991: Some const
Volker Lendecke [Sun, 22 Jul 2007 11:38:11 +0000 (11:38 +0000)]
r23990: Reformatting for 80 cols and trailing whitespace
Volker Lendecke [Sun, 22 Jul 2007 11:18:49 +0000 (11:18 +0000)]
r23989: For testing purposes, add "echo" to smbclient
Volker Lendecke [Sat, 21 Jul 2007 22:29:55 +0000 (22:29 +0000)]
r23988: Looks a lot more scary than it is: This just unwraps the else-branch of
if (smb_messages[type].fn == NULL) { into the function top-level. Makes
this function a bit easier to understand IMO.
Volker
Volker Lendecke [Sat, 21 Jul 2007 22:00:09 +0000 (22:00 +0000)]
r23987: Remove static pid in switch_message()
There's no point in duplicating functionality that exists in
sys_getpid() that also only used in a debug statement
Volker Lendecke [Sat, 21 Jul 2007 21:56:33 +0000 (21:56 +0000)]
r23986: Some const
Michael Adam [Fri, 20 Jul 2007 16:39:42 +0000 (16:39 +0000)]
r23981: Make tdb_validate_and_backup try harder to end up with a valid tdb:
If restoring a backup fails due to lack of space, remove the
corrupt tdb previously moved away to "name.corrupt", and retry.
If restoring still fails, move the backup in place instead of
copying it.
Michael
Michael Adam [Fri, 20 Jul 2007 16:31:32 +0000 (16:31 +0000)]
r23980: Fix one more use of pwrite in expand_file.
Michael
Michael Adam [Fri, 20 Jul 2007 15:00:58 +0000 (15:00 +0000)]
r23979: Fix another occurence of (written != requested) as an
error condition to write. This is in tdb_new_database.
Fix one call to tdb_new_database in tdb_open_ex to not
overwrite the newly propagated errno (typically ENOSPC).
Michael
Michael Adam [Fri, 20 Jul 2007 14:23:12 +0000 (14:23 +0000)]
r23977: Im prove the pwrite-patch to tdb_expand_file of r23972:
* prevent infinite loops due to 0 bytes written:
try once more. if we still get 0 as return,
set errno to ENOSPC and return -1 (error)
* replace int by correct types (ssize_t and size_t).
* print a warning log message in case "written < requested to write"
usually this means, that the next call to pwrite will fail
with return value -1 and set errno accordingly.
Note that the former error condition "written != requested to write"
is not a correct error condition of write/pwrite. If this is due
to an error, a subsequent call to (p)write will reveal the cause
(typically "no space left on device" - ENOSPC).
Michael
Günther Deschner [Thu, 19 Jul 2007 14:49:08 +0000 (14:49 +0000)]
r23976: Move authdata.o to LIBADS_SERVER_OBJ.
Guenther
Michael Adam [Thu, 19 Jul 2007 14:22:24 +0000 (14:22 +0000)]
r23975: Enhance some debug output.
Volker Lendecke [Thu, 19 Jul 2007 14:08:01 +0000 (14:08 +0000)]
r23974: Fix Coverity ID 361. num_rids == 0 is caught on function entry
Günther Deschner [Thu, 19 Jul 2007 13:47:53 +0000 (13:47 +0000)]
r23973: For debugging, add (undocumented) net ads kerberos commands (kinit, renew,
pac).
Guenther
Michael Adam [Thu, 19 Jul 2007 13:46:26 +0000 (13:46 +0000)]
r23972: Fix a bug in pwrite error detection in tdb_expand_file():
The proper error condition is (ret == -1) instead of
(ret != number_of_byte_told_to_write).
Michael
Günther Deschner [Thu, 19 Jul 2007 13:37:49 +0000 (13:37 +0000)]
r23971: Prevent build failures.
Guenther
Günther Deschner [Thu, 19 Jul 2007 13:36:41 +0000 (13:36 +0000)]
r23970: Allow to set the debuglevel at which to dump the PAC logon info.
Guenther
Günther Deschner [Thu, 19 Jul 2007 13:34:45 +0000 (13:34 +0000)]
r23969: Some helper routines to retrieve a PAC and PAC elements.
Guenther
Günther Deschner [Thu, 19 Jul 2007 13:07:22 +0000 (13:07 +0000)]
r23968: Harmonize net's password prompts.
Guenther
Volker Lendecke [Thu, 19 Jul 2007 10:23:36 +0000 (10:23 +0000)]
r23967: Memleak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!
Volker
James Peach [Thu, 19 Jul 2007 04:37:38 +0000 (04:37 +0000)]
r23962: Linux oplock support is conditional on HAVE_KERNEL_OPLOCKS_LINUX,
not plain old LINUX.
Michael Adam [Wed, 18 Jul 2007 14:38:18 +0000 (14:38 +0000)]
r23957: Use tdb_open_log instead of tdb_open.
Michael
Stefan Metzmacher [Wed, 18 Jul 2007 14:03:46 +0000 (14:03 +0000)]
r23956: merge from 3_2-ctdb-tridge:
fixed a bug with dead share mode entries
jra: please tell me if it's ok to merge this to 3_2_0.
metze
Stefan Metzmacher [Wed, 18 Jul 2007 13:52:20 +0000 (13:52 +0000)]
r23954: merge from 3_0-ctdb-tridge:
don't display dead share mode entries in smbstatus
metze
Volker Lendecke [Wed, 18 Jul 2007 12:28:32 +0000 (12:28 +0000)]
r23953: Some C++ warnings
Michael Adam [Wed, 18 Jul 2007 11:43:50 +0000 (11:43 +0000)]
r23952: Streamline and improve the logic of tdb_validate_and backup:
- call tdb_validate on the given tdb.
- if validation is successful, create a backup
return 0 (success) even if the backup fails.
- if validation fails:
- move tdb to name.corrupt (don't exit if this fails)
- look for a valid backup
- if a valid backup is found, restore it, else return -1 (failure)
if restoring succeeds, return 0 (success), else -1 (failure)
Summing up:
If 0 is returned, there is a valid tdb at the given location:
either the original one ore one restrored from a backup.
If -1 is returned, there is no valid tdb at the given location:
Either there is no file at all, or the original file is still
in place (if moving it away failed).
Michael
Günther Deschner [Wed, 18 Jul 2007 11:21:21 +0000 (11:21 +0000)]
r23951: Fix segfault.
Guenther
Michael Adam [Wed, 18 Jul 2007 08:29:00 +0000 (08:29 +0000)]
r23950: unlink before rename is superfluous.
Michael
Stefan Metzmacher [Wed, 18 Jul 2007 08:19:13 +0000 (08:19 +0000)]
r23948: add gsskrb5 sign and seal support for LDAP connections
NOTE: only for the "GSSAPI" SASL mech yet
metze
Stefan Metzmacher [Wed, 18 Jul 2007 08:15:42 +0000 (08:15 +0000)]
r23946: add support for NTLMSSP sign and seal
NOTE: windows servers are broken with sign only...
metze
Stefan Metzmacher [Wed, 18 Jul 2007 07:45:16 +0000 (07:45 +0000)]
r23945: add infrastructure to select plain, sign or seal LDAP connection
metze
Stefan Metzmacher [Wed, 18 Jul 2007 07:30:41 +0000 (07:30 +0000)]
r23943: - always provide ads_setup_sasl_wrapping() function
- read/write returning 0 means EOF and we need to return direct
metze
Jeremy Allison [Wed, 18 Jul 2007 01:27:03 +0000 (01:27 +0000)]
r23942: Fix issue found by Shlomi Yaakobovich <Shlomi@exanet.com> where
invalid names sent as a resume name were incorrectly mapped into
. and .. Ensure they really *are . and ..
Jeremy.
Jeremy Allison [Wed, 18 Jul 2007 00:18:57 +0000 (00:18 +0000)]
r23941: Don't use "False" when you mean "MARSHALL".
Jeremy.
Jeremy Allison [Tue, 17 Jul 2007 23:57:13 +0000 (23:57 +0000)]
r23940: Added missing line that was deleted accidently.
Should fix the build.
Jeremy.
Jeremy Allison [Tue, 17 Jul 2007 23:01:02 +0000 (23:01 +0000)]
r23939: Fixes for notify returns. Returned param value must fix inside
max_param or return NT_STATUS_OK.
Jeremy.
Michael Adam [Tue, 17 Jul 2007 21:55:31 +0000 (21:55 +0000)]
r23938: Add a debug message.
Günther Deschner [Tue, 17 Jul 2007 20:28:31 +0000 (20:28 +0000)]
r23937: Use ads_config_path() when we need to know the configration context.
Guenther
Jeremy Allison [Tue, 17 Jul 2007 18:48:39 +0000 (18:48 +0000)]
r23935: We were lying to the client in the case of POSIX_UNLINK
if a Windows client had the file open. We were setting
delete on close and returning "ok". The POSIX client then
believed the file was gone (and it wasn't). Fix this to
return SHARING_VIOLATION if there is an existing NTcreateX
open on the file and someone calls POSIX_UNLINK. Still one
more Cthon test to fix but getting closer now. Should
be in 3.0.25c also.
Jeremy.
Stefan Metzmacher [Tue, 17 Jul 2007 14:08:53 +0000 (14:08 +0000)]
r23933: - implement ctrl SASL wrapping hook
- pass down sign or seal hooks
- some sasl wrapping fixes
metze
Michael Adam [Tue, 17 Jul 2007 13:06:29 +0000 (13:06 +0000)]
r23932: Fill extended status with information in case the validation traverse
functions did not do so but returned an error. (This is the case when
error occurred deeper than at the level of the content checking done by
the per entry validate_fn.)
Michael
Michael Adam [Tue, 17 Jul 2007 12:51:43 +0000 (12:51 +0000)]
r23931: Use the new tdb_validate_and_backup function instead of pure tdb_validate
in winbindd cache validation.
Michael
Michael Adam [Tue, 17 Jul 2007 12:49:22 +0000 (12:49 +0000)]
r23930: Introduce tdb_validate_and_backup:
This is a wrapper around tdb_validate, that does backup handling:
* if the given tdb is valid, a backup is created (name.bak)
* if the tdb is invalid, if a valid bakup is found (validated
with the same validation function) under the name "name.bak"
the orignal tdb is moved to name.corrupt and the backup
is restored.
For the backup handling, a variant of the backup_tdb function
from lib/tdb/tools/tdbbackup.c is included in lib/util_tdb.c.
The copy function for the traverse action eliminates the need
to maintain a global success state by using a struct wrapping
the target tdb and a success flag as the private data.
Michael
Günther Deschner [Tue, 17 Jul 2007 11:52:23 +0000 (11:52 +0000)]
r23929: Deleting gpo_sd_check_trustee_in_sid_token() as nt_token_check_sid() is what we
need here.
Guenther
Günther Deschner [Tue, 17 Jul 2007 11:47:17 +0000 (11:47 +0000)]
r23928: Merge all "copy-info3-groups-to-sid-array" blocks to a sid_array_from_info3()
function.
Guenther
Stefan Metzmacher [Tue, 17 Jul 2007 11:14:42 +0000 (11:14 +0000)]
r23926: implement output buffer handling for the SASL write wrapper
metze