Gerald Carter [Wed, 11 Apr 2007 12:32:58 +0000 (12:32 +0000)]
r22173: BUG 4491, 4501: Additional fixes for protecting against
crashes in allocate_id().
BUG 4501: Fix segv in idmap_ad caused by resetting the
entry iterator when parsing search results.
Alexander Bokovoy [Wed, 11 Apr 2007 12:32:07 +0000 (12:32 +0000)]
r22172: FSCTL_RECALL_FILE is 0x90117 according to my traces. Record it here.
Jeremy Allison [Wed, 11 Apr 2007 05:27:00 +0000 (05:27 +0000)]
r22164: Fix missing lock count release in transaction cancel.
Found by Taj Khattra <taj.khattra@gmail.com>.
Jeremy.
Jeremy Allison [Wed, 11 Apr 2007 05:05:33 +0000 (05:05 +0000)]
r22163: Pure reformatting. I hate 4 space tabstops :-).
Jeremy.
Gerald Carter [Tue, 10 Apr 2007 22:59:42 +0000 (22:59 +0000)]
r22159: BUG 4501 (second half of fix): Just disable the
uid/gid allocation if no idmap alloca backend has been
defined and we are not using a 3.0.24 idmap backend
compatible configuration.
Gerald Carter [Tue, 10 Apr 2007 21:14:44 +0000 (21:14 +0000)]
r22158: BUG 4501 (partial): Fix a crash caused by not using the
nss_info_{rfc2307,sfu} plugin with idmap_ad.
Jeremy Allison [Tue, 10 Apr 2007 20:35:30 +0000 (20:35 +0000)]
r22157: Fix bug #3634 - stop nmbd segfaulting with bad interface line.
Jeremy.
Jeremy Allison [Tue, 10 Apr 2007 18:21:37 +0000 (18:21 +0000)]
r22155: Fixed warning #4498 from jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Tue, 10 Apr 2007 18:12:25 +0000 (18:12 +0000)]
r22154: Make struct smbdb_ctx an opaque pointer so users of the API
don't need to have tdb.h.
Jeremy.
Stefan Metzmacher [Tue, 10 Apr 2007 16:04:22 +0000 (16:04 +0000)]
r22153: fix LDAP SASL "GSSAPI" bind against w2k3, this isn't critical
because we try "GSS-SPNEGO" first and all windows version support
that.
metze
Stefan Metzmacher [Tue, 10 Apr 2007 15:59:39 +0000 (15:59 +0000)]
r22151: remove netgr functions from libreplace they're not used
in samba4 currently and samba3 has explicit configure checks for them.
should fix bug #4496
metze
Gerald Carter [Tue, 10 Apr 2007 15:41:23 +0000 (15:41 +0000)]
r22149: BUG 4500: patch from Jorge Santos <jorge_a_santos@hotmail.com>
to fix compile bug ni quotas.c (typo calling unbecome_root()).
Jim McDonough [Tue, 10 Apr 2007 15:41:22 +0000 (15:41 +0000)]
r22148: Fix gpfs module on posix-acl test. Adds gpfsacl_sys_set_fd (calls
_file). Thanks to Gomati Mohanan.
Volker Lendecke [Tue, 10 Apr 2007 07:36:58 +0000 (07:36 +0000)]
r22147: Next try
Volker Lendecke [Tue, 10 Apr 2007 07:33:14 +0000 (07:33 +0000)]
r22146: Attempt to fix the build
Jeremy Allison [Mon, 9 Apr 2007 21:01:46 +0000 (21:01 +0000)]
r22145: Fix bug #4494 - reported by Kevin Jamieson <bugzilla@kevinjamieson.com>.
If returning a mapped UNIX error from sendfile, don't call chain_reply.
Jeremy.
Volker Lendecke [Mon, 9 Apr 2007 10:38:55 +0000 (10:38 +0000)]
r22135: Check in most of Michael Adam's net conf utility. A good share of this patch
is moving functions around to fix some linker dependencies for the registry.
Michael, I've renamed your auth_utils2.c to token_utils.c.
Thanks!
Volker
Jeremy Allison [Sun, 8 Apr 2007 19:41:47 +0000 (19:41 +0000)]
r22132: I hate inefficiency. Don't call conv_str_size()
on every pread/sendfile call, initialize these
variables in an allocated struct at connection
time and just refer to them directly.
Jeremy.
Derrell Lipman [Sun, 8 Apr 2007 16:41:24 +0000 (16:41 +0000)]
r22130: - Ensure that the libsmbclient example programs link with the libsmbclient
library that's part of the current tree, not with whatever happens to have
been previously installed.
Jeremy Allison [Sun, 8 Apr 2007 04:54:44 +0000 (04:54 +0000)]
r22129: Fix the nttrans create extended response for pipes
and files (tested with Win32 code). Bug #4404 should
now be dead :-).
Jeremy.
Jeremy Allison [Sun, 8 Apr 2007 00:47:49 +0000 (00:47 +0000)]
r22128: Fix the pipe open response with EXTENDED_RESPONSE_REQUIRED
set. Only the NTTrans create left to fix for csc.
Jeremy.
James Peach [Sat, 7 Apr 2007 21:13:29 +0000 (21:13 +0000)]
r22127: Wrap the AC_TRY_RUN detection for Linux getgrouplist in an
AC_CACHE_CHECK, so it can be cross-compiled.
Volker Lendecke [Sat, 7 Apr 2007 19:35:13 +0000 (19:35 +0000)]
r22126: Fix a bogus uninitialized variable warning
Volker Lendecke [Sat, 7 Apr 2007 13:22:49 +0000 (13:22 +0000)]
r22125: Fix a warning
Jeremy Allison [Sat, 7 Apr 2007 06:59:32 +0000 (06:59 +0000)]
r22124: Wow - NTCreateX sets the word count to 42, but returns 50 on
the wire. Strange.... But now we're returning Windows compatible
extended info. Next to fix the pipe returns and NTTrans Creates.
Jeremy.
Jeremy Allison [Sat, 7 Apr 2007 06:38:45 +0000 (06:38 +0000)]
r22123: Try and fix the csc (#4404) bug by supporting the extended
response to NTCreateX - need to fix this also for
pipe open and NTTransCreate as well so this isn't
finished.
Jeremy.
Jeremy Allison [Sat, 7 Apr 2007 05:49:24 +0000 (05:49 +0000)]
r22122: Start to fix csc issue with Vista. Make smbd support
the extended 7 word response for tconX rather than the
3 word one we supported previously.
Jeremy.
Jeremy Allison [Fri, 6 Apr 2007 22:08:44 +0000 (22:08 +0000)]
r22113: Fix core dump when configfile in same directory.
From Steven Danneman <steven.danneman@isilon.com>.
Jeremy.
Jeremy Allison [Fri, 6 Apr 2007 21:55:44 +0000 (21:55 +0000)]
r22112: Fix memleak pointed out by Steven Danneman <steven.danneman@isilon.com>.
Jeremy.
Jeremy Allison [Fri, 6 Apr 2007 21:12:44 +0000 (21:12 +0000)]
r22111: Allow readahead params to use size suffixes as K,M, etc.
Jeremy.
Gerald Carter [Fri, 6 Apr 2007 21:05:55 +0000 (21:05 +0000)]
r22110: don't cache the S-1-22-{1,2} domain SID/uig/gid lookups in idmap_cache
Simo Sorce [Fri, 6 Apr 2007 19:55:45 +0000 (19:55 +0000)]
r22109: Readonly is automatically set in the generic init code, let's just log the fact there
and remove the specific, but redundant, code in idmap_ad.c
Jeremy Allison [Fri, 6 Apr 2007 19:38:35 +0000 (19:38 +0000)]
r22108: Fix from <don.mccall@hp.com> to try and fix the HPUX builds.
Jeremy.
James Peach [Fri, 6 Apr 2007 19:17:15 +0000 (19:17 +0000)]
r22107: Fix typo.
Jeremy Allison [Fri, 6 Apr 2007 19:09:53 +0000 (19:09 +0000)]
r22106: Fix the module name - it's vfs_readahead not vfs_linux_readahead.
Jeremy.
Jeremy Allison [Fri, 6 Apr 2007 18:56:47 +0000 (18:56 +0000)]
r22105: Added vfs_readahead module that appears to do wonderful things
for copying files from Samba when using Windows Vista Windows
explorer.... :-). By default if you add this I can go on my
vmware sessions from 7MB/sec to 12MB/sec (+1 extra MB/sec if
I turn sendfile on).
Jeremy.
Gerald Carter [Fri, 6 Apr 2007 18:52:30 +0000 (18:52 +0000)]
r22104: BUG 4439: Fix the object picket on x64 WIndopws XP/2003.
Enable the DsRoleGetPrimaryDomainInfo() server code.
Tested by Win2000/XP/2003/Vista (x86) and WinXP (x64)
Lars Müller [Fri, 6 Apr 2007 16:42:37 +0000 (16:42 +0000)]
r22103: No code change. This is a spring time end of line clesnup checkin.
Lars Müller [Fri, 6 Apr 2007 16:27:28 +0000 (16:27 +0000)]
r22102: Remove obsoleted SHLIBS_PROGS from {Makefile,configure}.in.
As NSS_MODULES is added to the all rule the resulting set of binaries
are the same.
Gerald Carter [Fri, 6 Apr 2007 16:23:55 +0000 (16:23 +0000)]
r22101: remove RedHat 9 packaging files after annoncement on the samba ml
Lars Müller [Fri, 6 Apr 2007 15:39:34 +0000 (15:39 +0000)]
r22099: Revert parts of revision 22056 as proto_exists is not required by
@WINBIND_NSS@, bin/pam_winbind.@SHLIBEXT@, and bin/pam_smbpass.@SHLIBEXT@.
Jeremy Allison [Fri, 6 Apr 2007 01:09:19 +0000 (01:09 +0000)]
r22097: Add detection for linux readahead() syscall.
Jeremy.
Jeremy Allison [Thu, 5 Apr 2007 23:56:10 +0000 (23:56 +0000)]
r22096: become_root_uid_only() is unneeded - it's only used in
messages.c. Refactor to use become_root() instead and
make it local to messages.c
Jeremy.
Gerald Carter [Thu, 5 Apr 2007 19:56:08 +0000 (19:56 +0000)]
r22095: BUG 4484: Add more checks to set %a for Vista clients (based on absence of native OS and Lanman strings in the session setup request)
James Peach [Thu, 5 Apr 2007 19:49:29 +0000 (19:49 +0000)]
r22094: Clarify that SMB_VFS_LOCK should not be used to get lock status.
Stefan Metzmacher [Thu, 5 Apr 2007 12:36:10 +0000 (12:36 +0000)]
r22093: send also the correct OID_KERBEROS5 not only the broken
OID_KERBEROS_OLD one.
metze
Stefan Metzmacher [Thu, 5 Apr 2007 12:30:23 +0000 (12:30 +0000)]
r22092: - make spnego_parse_auth_response() more generic and
not specific for NTLMSSP
- it's possible that the server sends a mechOID and authdata
if negResult != SPNEGO_NEG_RESULT_INCOMPLETE, but we still
force the mechOID to be present if negResult == SPNEGO_NEG_RESULT_INCOMPLETE
metze
Volker Lendecke [Thu, 5 Apr 2007 11:13:25 +0000 (11:13 +0000)]
r22091: Fix an uninitialized variable warning
Jeremy Allison [Wed, 4 Apr 2007 23:33:07 +0000 (23:33 +0000)]
r22080: Fix directory recycle module bug #4486.
Jeremy.
Jeremy Allison [Wed, 4 Apr 2007 17:38:12 +0000 (17:38 +0000)]
r22079: Tsk, tsk, Metze didn't compile before check-in :-).
Merge the memory leak fix (with fix :-) to 3.0.25.
Jeremy.
Stefan Metzmacher [Wed, 4 Apr 2007 14:50:39 +0000 (14:50 +0000)]
r22078: fix memory leak in not often used code, we only use it if the server
doesn't support GSS-SPNEGO in SASL
can someone please review this, maybe it's also for 3.0.25
metze
Andrew Bartlett [Wed, 4 Apr 2007 06:03:54 +0000 (06:03 +0000)]
r22071: Make the error message for incorrect use of '-c' show the parameter as used.
This means that smbpasswd -c user (which in htpasswd creates a new file)
and smbpasswd -c /not/my/smb.conf should give errors an admin will
think to chase down.
Andrew Bartlett
Gerald Carter [Wed, 4 Apr 2007 04:28:28 +0000 (04:28 +0000)]
r22069: BUG 4447: Fix compile failure on AIX 5.2 (patch from William Jojo <jojowil@hvcc.edu>)
Stefan Metzmacher [Wed, 4 Apr 2007 03:54:30 +0000 (03:54 +0000)]
r22067: - fix --with-fhs, where confdir is set to \${sysconfdir}
but sysconfdir wasn't defined in our Makefile
- add localstatedir for completeness
metze
Gerald Carter [Wed, 4 Apr 2007 02:57:01 +0000 (02:57 +0000)]
r22066: Ensure that winbind can resolve SIDs in the S-1-22-{1,2}
domain to a uid.gid using the idmap_passdb backend.
Jeremy Allison [Wed, 4 Apr 2007 00:03:12 +0000 (00:03 +0000)]
r22065: First logic change I've found :-(. We were being too
restrictive about strings being NULL. If an info level
doesn't use a subformat the subformat string may be
missing (null). Add debug statements to help track
this.
Jeremy
Jeremy Allison [Tue, 3 Apr 2007 22:59:55 +0000 (22:59 +0000)]
r22064: Fix the DFS code to work better with Vista clients. Allow
"host msdfs = true" to be set in the [global] section
and allow Vista to see shares with "msdfs root = yes"
and "msdfs root = no" off the same server. Down
to an error message really :-).
Jeremy.
Jeremy Allison [Tue, 3 Apr 2007 19:47:19 +0000 (19:47 +0000)]
r22062: Fix the parsing of info level 3. Flags is not a flags
field, but an offset. Fixed 64-bit display of ACLs on
printers.
Jeremy.
Gerald Carter [Tue, 3 Apr 2007 18:32:25 +0000 (18:32 +0000)]
r22061: Fix the krb5 user ticket refresh event timeout in winbindd
Jeremy Allison [Tue, 3 Apr 2007 17:10:52 +0000 (17:10 +0000)]
r22060: Fix for AIX quotas from Heinrich Mislik <Heinrich.Mislik@univie.ac.at>.
Jeremy.
Volker Lendecke [Tue, 3 Apr 2007 14:16:56 +0000 (14:16 +0000)]
r22059: Over-allocate and NULL out 100 bytes for lanman.c.
Volker
Günther Deschner [Tue, 3 Apr 2007 13:30:43 +0000 (13:30 +0000)]
r22058: Add test_nss_modules to check NSS modules for unresolved symbols.
Guenther
Günther Deschner [Tue, 3 Apr 2007 13:25:14 +0000 (13:25 +0000)]
r22056: Adding some missing proto_exists calls (for PAM and NSS modules)
Guenther
Jelmer Vernooij [Tue, 3 Apr 2007 12:28:40 +0000 (12:28 +0000)]
r22055: Port the endpoint mapper (and functions it requires) to Samba 3.
Stefan Metzmacher [Tue, 3 Apr 2007 10:15:15 +0000 (10:15 +0000)]
r22054: merge from samba4:
remove broken samba3 specific stuff from tdbtool
metze
Stefan Metzmacher [Tue, 3 Apr 2007 07:00:53 +0000 (07:00 +0000)]
r22051: use libreplace headers
metze
Jeremy Allison [Tue, 3 Apr 2007 04:52:09 +0000 (04:52 +0000)]
r22050: Fix a couple of off-by-one errors in the rap
call patch. Jerry, this works now for displaying
shares on Win9x (and hopefully everything else
as well :-).
Jeremy.
Jeremy Allison [Mon, 2 Apr 2007 23:07:06 +0000 (23:07 +0000)]
r22049: HPUX build fixes from <don.mccall@hp.com>.
Jeremy.
Jeremy Allison [Mon, 2 Apr 2007 20:10:21 +0000 (20:10 +0000)]
r22045: As Volker noticed, skip_string's last argument is
redundent. Remove it.
Jeremy.
Volker Lendecke [Mon, 2 Apr 2007 20:04:05 +0000 (20:04 +0000)]
r22044: Remove the only skip_string(...,2) caller
Volker Lendecke [Mon, 2 Apr 2007 19:46:27 +0000 (19:46 +0000)]
r22043: Comparing lanman.c with -r22013 is now MUCH easier, thanks! This looks much
easier to review! Damn close to what I had in my tree, just the fn names were
slightly different.
This removes one unnecessary dupe.
Next thing is to get rid of the parameter "n" of skip_string, there is only
one (!) caller that does not pass in 1....
Volker
Jeremy Allison [Mon, 2 Apr 2007 19:04:57 +0000 (19:04 +0000)]
r22042: Try and clean up my own mess using the API Volker
suggested. I now use :
BOOL is_offset_safe(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_str_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
int get_safe_SVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)
int get_safe_IVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)
Volker, please criticize and comment. Thanks,
Jeremy.
Stefan Metzmacher [Mon, 2 Apr 2007 18:42:56 +0000 (18:42 +0000)]
r22039: fix compiler warnings
metze
Stefan Metzmacher [Mon, 2 Apr 2007 17:16:14 +0000 (17:16 +0000)]
r22033: remove useless line
metze
Andrew Bartlett [Mon, 2 Apr 2007 12:52:08 +0000 (12:52 +0000)]
r22026: Missed in my last commit, another case where we need to copy, not reference.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2007 06:57:37 +0000 (06:57 +0000)]
r22024: Don't leak, actually use the provided memory context...
Andrew Bartlett [Mon, 2 Apr 2007 06:26:16 +0000 (06:26 +0000)]
r22023: I don't like this cache, but I think Jeremy is right, the consequences
of the talloc heirarchy created are too subtle, particularly with
callers picking out individual members.
This might fix the faults on the build farm.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2007 05:53:34 +0000 (05:53 +0000)]
r22022: - Clarify the comments
- make sure never to free an uninitialised variable
- ensure to free result on getpwnam_alloc failure
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2007 03:46:13 +0000 (03:46 +0000)]
r22020: Make it more clear that both the vuser struct and it's contents are
talloc_free()'ed at the end of a session.
Rework the passwd cache code to use talloc_unlink and
talloc_reference, to more carefully manage the cache.
Andrew Bartlett
Volker Lendecke [Sun, 1 Apr 2007 13:50:02 +0000 (13:50 +0000)]
r22019: Jeremy, this hopefully fixes the build farm currently. But I think we need
another get_safe_offset call that also includes the required buffer size.
Volker
Herb Lewis [Sat, 31 Mar 2007 03:11:02 +0000 (03:11 +0000)]
r22018: fix compile error
Jeremy Allison [Sat, 31 Mar 2007 01:14:00 +0000 (01:14 +0000)]
r22017: After changing 2000 lines of this I think this is needed :-).
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 23:23:45 +0000 (23:23 +0000)]
r22016: Try and fix the build - move things out of proto.h
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 22:35:35 +0000 (22:35 +0000)]
r22015: Fix for memory leak from Steven Danneman <steven.danneman@isilon.com>
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 22:25:08 +0000 (22:25 +0000)]
r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
but I've no option.
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 22:19:51 +0000 (22:19 +0000)]
r22013: Move to SSPI framing (sig first in NTLM).
Jeremy
Jeremy Allison [Thu, 29 Mar 2007 22:12:28 +0000 (22:12 +0000)]
r22012: Ensure we use the same technique to pull the share mode
data out that locking/locking.c does.
Jeremy.
Jeremy Allison [Thu, 29 Mar 2007 19:46:34 +0000 (19:46 +0000)]
r22011: As Metze suggested, use 0xFF 'E' <enc ctx> instead
of 0xFF 'S' <enc ctx>.
Jeremy.
Jeremy Allison [Thu, 29 Mar 2007 19:40:59 +0000 (19:40 +0000)]
r22010: Now I'm looking at mangling again, make sure
that we mangle any illegal names before doing
any wildcard matches. That way lies least
suprises. Don't merge this for 3.0.25, too
dangerous. Thanks.
Jeremy.
Stefan Metzmacher [Thu, 29 Mar 2007 09:35:51 +0000 (09:35 +0000)]
r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users
metze
Stefan Metzmacher [Thu, 29 Mar 2007 08:24:15 +0000 (08:24 +0000)]
r22008: use string_term_tdb_data()
metze
Stefan Metzmacher [Thu, 29 Mar 2007 08:08:52 +0000 (08:08 +0000)]
r22007: make string_tdb_data(NULL) possible...
metze
Stefan Metzmacher [Thu, 29 Mar 2007 07:30:22 +0000 (07:30 +0000)]
r22006: use string_term_tdb_data()...
metze
Jeremy Allison [Wed, 28 Mar 2007 19:47:59 +0000 (19:47 +0000)]
r22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
call as smb_krb5_locate_kdc to prevent incorrect linking
and crashes on Solaris.
Jeremy.
Simo Sorce [Wed, 28 Mar 2007 14:16:34 +0000 (14:16 +0000)]
r22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
and -T argument parsing behavior (which is just insane but a separate bug)
Stefan Metzmacher [Wed, 28 Mar 2007 13:34:59 +0000 (13:34 +0000)]
r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.
also fix all the callers to prevent compiler warnings
metze
Stefan Metzmacher [Wed, 28 Mar 2007 13:31:52 +0000 (13:31 +0000)]
r22000: remove useless casts
metze
Stefan Metzmacher [Wed, 28 Mar 2007 13:26:43 +0000 (13:26 +0000)]
r21999: remove useless casts
metze
Günther Deschner [Wed, 28 Mar 2007 10:00:42 +0000 (10:00 +0000)]
r21998: Fix tdb keynames in netsamlogon_clear_cached_user().
No point in deleting U/DOMAIN/RID and UG/DOMAIN/RID keys if we only store U/SID
and UG/SID keys :-)
Next we need to verify the need of calling netsamlogon_clear_cached_user() at all.
Guenther
Jeremy Allison [Wed, 28 Mar 2007 01:11:27 +0000 (01:11 +0000)]
r21997: Implement the server side of gss seal negotiate.
Jeremy.