Andrew Bartlett [Fri, 24 Apr 2009 07:17:29 +0000 (09:17 +0200)]
s4:torture Add tests for prefixMap custom attribute handler
Andrew Bartlett [Fri, 24 Apr 2009 07:17:08 +0000 (09:17 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Jelmer Vernooij [Thu, 23 Apr 2009 16:59:37 +0000 (18:59 +0200)]
Provide a ldb_global_init() function for compatibility with older versions of LDB
(including the one in Samba 3).
Andrew Bartlett [Thu, 23 Apr 2009 16:46:24 +0000 (18:46 +0200)]
More lcov code coverage generation work
Jelmer Vernooij [Thu, 23 Apr 2009 12:31:45 +0000 (14:31 +0200)]
samba3/ldb: Update the ldb_dn API to match that of the Samba 4 LDB:
* ldb_dn_new() now takes an initial DN string
* ldb_dn_string_compose() -> ldb_dn_new_fmt()
* dummy ldb_dn_validate(), since LDB DNs in the current implementation
are always valid if they could be created.
Jelmer Vernooij [Thu, 23 Apr 2009 12:27:59 +0000 (14:27 +0200)]
ldb/samba3: Support event context argument to ldb_init().
This argument is ignored (Samba3's LDB is synchronous) but having it
there is useful for API compatibility with the LDB used by Samba 4 and
available on some systems.
nadezhda ivanova [Thu, 23 Apr 2009 14:18:23 +0000 (17:18 +0300)]
Fix of a bug in the security.descriptor.as_sddl() method
security.descriptor.as_sddl() method did not work correctly when invoked without
supplying the domain sid. Returned the same value as when the sid was provided.
Test added for this case in libcli/security/tests/bindings.py
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Thu, 23 Apr 2009 15:53:25 +0000 (17:53 +0200)]
s4:torture use common libcli/auth crypto code
Jelmer Vernooij [Thu, 23 Apr 2009 15:46:54 +0000 (17:46 +0200)]
Fix push_codepoint function without iconv_convenience.
Jelmer Vernooij [Thu, 23 Apr 2009 14:03:19 +0000 (16:03 +0200)]
charcnv: Import push_codepoint().
Jelmer Vernooij [Thu, 23 Apr 2009 13:24:38 +0000 (15:24 +0200)]
Add a new non-convenience version of push_codepoint.
Andrew Bartlett [Thu, 23 Apr 2009 15:38:42 +0000 (17:38 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Sam Liddicott [Thu, 23 Apr 2009 12:47:59 +0000 (13:47 +0100)]
Add async support for reply_tcon* and ntvfs_connect
smbsrv_tcon_backend no longer creates the ntvfs_request wrapper,
so smbsrv_reply_tcon* can now do this and then invoke ntvfs_connect
in the typical manner using SMBSRV_SETUP_NTVFS_REQUEST and
SMBSRV_CALL_NTVFS_BACKEND
Previously smbsrv_tcon_backend has been responsible for instantiating
the ntvfs_module_context to service a tree-connect request, and
then create an ntvfs_request wrapper around the smbsrv_request
and pass this to ntvfs_connect for the newly created ntvfs.
These actions could not be invoked asynchronously.
This meant that any client requests made while instantiating the
ntvfs module, including any composite's used during authentication
(or related client connections for the case of proxy modules)
would block other ntvfs modules and requests in the current process as
they executed a nested event loop to await completion.
Signed-off-by: Sam Liddicott <sam@liddicott.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 23 Apr 2009 14:46:47 +0000 (16:46 +0200)]
s4:test Include 'source4' in directories to find lcov in
Volker Lendecke [Thu, 23 Apr 2009 14:17:18 +0000 (16:17 +0200)]
Add missing prototypes
Andrew Bartlett [Thu, 23 Apr 2009 13:12:35 +0000 (15:12 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Andrew Bartlett [Thu, 23 Apr 2009 13:11:04 +0000 (15:11 +0200)]
s4:test Fix 'make lcov' in Samba4
Volker Lendecke [Thu, 23 Apr 2009 12:54:52 +0000 (14:54 +0200)]
Revert "Do not use the file system GET_REAL_FILENAME for mangled names"
This reverts commit
b5b6ecb58aeba196c28370cde21a0826f81d8da6.
Volker Lendecke [Thu, 23 Apr 2009 12:24:16 +0000 (14:24 +0200)]
Fix a couple of warnings
Volker Lendecke [Thu, 23 Apr 2009 12:23:23 +0000 (14:23 +0200)]
Fix an uninitialized variable
Volker Lendecke [Thu, 23 Apr 2009 12:14:37 +0000 (14:14 +0200)]
Fix a type-punned warning
Volker Lendecke [Wed, 22 Apr 2009 09:54:13 +0000 (11:54 +0200)]
Fix a pointless static
Andrew Bartlett [Thu, 23 Apr 2009 10:19:10 +0000 (12:19 +0200)]
s4:samr Use ldb_context * rather than void *
Jeremy Allison [Thu, 23 Apr 2009 09:51:55 +0000 (02:51 -0700)]
Fix coverity #901 - uninitialized data.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 09:05:49 +0000 (11:05 +0200)]
Fix Coverity ID 626: DEADCODE
Jeremy Allison [Thu, 23 Apr 2009 09:02:28 +0000 (02:02 -0700)]
Fix Coverity bug #902, uninitialized variable.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 08:49:41 +0000 (10:49 +0200)]
Fix Coverity ID 628, Andrew B., please check!
Jeremy Allison [Thu, 23 Apr 2009 08:47:04 +0000 (01:47 -0700)]
Fix coverity #908, #909, uninitialized variable.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 08:42:43 +0000 (10:42 +0200)]
Fix Coverity ID 884: DEADCODE
Jeremy Allison [Thu, 23 Apr 2009 08:38:21 +0000 (01:38 -0700)]
Fix coverity #910, uninitialized variable.
Jeremy.
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.
Guenther
Kai Blin [Wed, 22 Apr 2009 22:23:56 +0000 (00:23 +0200)]
errormap: Change the WBC_ERR_UNKNOWN_ERROR to map to NT_STATUS_UNSUCCESSFUL
This allows us to distinguish on NTSTATUS level if we got a
WBC_ERR_UNKNOWN_ERROR or WBC_ERR_NSS_ERROR.
Jelmer Vernooij [Wed, 22 Apr 2009 21:54:10 +0000 (23:54 +0200)]
Specify explicit path to vlp, for those not having vlp in $PATH.
Jeremy Allison [Wed, 22 Apr 2009 15:04:53 +0000 (08:04 -0700)]
Make dskattr async.
Jeremy.
Björn Jacke [Sat, 28 Mar 2009 00:21:25 +0000 (01:21 +0100)]
ѕ3/configure: fix regexp for ld version recognition
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases
Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces
When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
Simo Sorce [Tue, 21 Apr 2009 07:08:37 +0000 (03:08 -0400)]
Prevent reallocs of the talloc pool itself
Jeremy Allison [Wed, 22 Apr 2009 13:46:42 +0000 (06:46 -0700)]
Make cli_chkpath async.
Jeremy
Volker Lendecke [Wed, 22 Apr 2009 10:23:10 +0000 (12:23 +0200)]
Move serverinfo_to_SamInfo3() to rpc_server/
Normally I hate moving around stuff, but this function is only called from the
RPC server side and it pulls in passdb when trying to link in our rpc client
routines. That seems unnecessary to me.
Jeremy Allison [Wed, 22 Apr 2009 10:03:04 +0000 (03:03 -0700)]
Add comment explaining the previous fix.
Jeremy.
Jeremy Allison [Wed, 22 Apr 2009 09:54:11 +0000 (02:54 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy
Volker Lendecke [Wed, 22 Apr 2009 09:51:03 +0000 (11:51 +0200)]
Fix some nonempty blank lines
Volker Lendecke [Wed, 22 Apr 2009 09:17:38 +0000 (11:17 +0200)]
Remove some shadowed definition warnings
Brad Hards [Wed, 22 Apr 2009 08:32:53 +0000 (10:32 +0200)]
Avoid using deprecated form of AC_CHECK_TYPE.
libreplace makes use of an older form of AC_CHECK_TYPE which basically
provides a fallback definition for the type if it isn't available.
http://www.gnu.org/software/hello/manual/autoconf/Obsolete-Macros.html#Obsolete-Macros
shows why this isn't a good idea (its not so important, except for pointer types).
This patch partly addresses the issue.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Kai Blin [Thu, 16 Apr 2009 09:49:25 +0000 (11:49 +0200)]
errormap: Add wbcErr to NTSTATUS mappings
Kai Blin [Sun, 5 Apr 2009 13:38:09 +0000 (15:38 +0200)]
s4-build: Also search ../nsswitch for make (c|e)tags
Kai Blin [Fri, 17 Apr 2009 07:59:39 +0000 (09:59 +0200)]
s4 selftest: Export the WINBINDD_SOCKET_DIR env var
Björn Jacke [Fri, 3 Apr 2009 17:27:16 +0000 (19:27 +0200)]
s4:ldb: fix extrasemi compile warning
Björn Jacke [Mon, 30 Mar 2009 11:18:34 +0000 (13:18 +0200)]
s4:ldb: do talloc_free and return NULL when we have no matches to return
Björn Jacke [Mon, 30 Mar 2009 11:47:58 +0000 (13:47 +0200)]
libcli: fix a "not handled in switch" compile warning
return NULL also for RAW_CLOSE_GENERIC
Björn Jacke [Mon, 30 Mar 2009 11:39:42 +0000 (13:39 +0200)]
ѕ4: fix a "not handled in switch" compile warning
Jelmer Vernooij [Tue, 21 Apr 2009 16:15:59 +0000 (18:15 +0200)]
s3: Use common security_descriptor_equal().
Stefan Metzmacher [Tue, 21 Apr 2009 15:42:39 +0000 (17:42 +0200)]
s3:libsmb: always use the tevent_req_nomem() for checking allocation failures
This will also make sure we cleanup 'req' in case of an error.
metze
Jelmer Vernooij [Tue, 21 Apr 2009 15:19:22 +0000 (17:19 +0200)]
Fix includes for security_descriptor file for the non-merged build.
Jelmer Vernooij [Tue, 21 Apr 2009 14:50:20 +0000 (16:50 +0200)]
Fix make install; don't install drsuapi.h and fix the location of
credentials.h
Jeremy Allison [Tue, 21 Apr 2009 13:52:54 +0000 (06:52 -0700)]
Make rmdir async.
Jeremy.
Stefan Metzmacher [Tue, 21 Apr 2009 13:33:53 +0000 (15:33 +0200)]
Revert "Use an absolute path to ensure that we can always regenerate tables.c"
This reverts commit
b57c8ff4400e5f2bd0776247496b34dab68bde97.
This actually breaks the merged build...
Doing a merged build and a samba4 build within the same
checkout, without a git clean -x -d -f (this removes everything that's
not checked into git! save files you don't want to delete!) running in the
toplevel directory, is not supported.
metze
Andrew Bartlett [Tue, 21 Apr 2009 13:19:50 +0000 (15:19 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Jelmer Vernooij [Tue, 21 Apr 2009 12:27:25 +0000 (14:27 +0200)]
Move the security_descriptor utility code to the top-level.
Jelmer Vernooij [Tue, 21 Apr 2009 10:44:01 +0000 (12:44 +0200)]
Use a static copy of the samsync header file as Samba3 doesn't generate
prototype headers.
Andrew Bartlett [Tue, 21 Apr 2009 13:14:02 +0000 (15:14 +0200)]
Add the implicit [ref] to the connect_handle in EnumDomains
Andrew Bartlett [Tue, 21 Apr 2009 13:07:10 +0000 (15:07 +0200)]
Revert "pidl/python: Add explicit casts, fixing implicit cast warnings."
It was creating new objects with bogus data.
This reverts commit
210830392999691469a55f4f5e2032abcdb20b8a.
Jeremy Allison [Tue, 21 Apr 2009 12:52:34 +0000 (05:52 -0700)]
Make cli_mkdir async. Change it to return NTSTATUS.
Jeremy.
Volker Lendecke [Tue, 21 Apr 2009 10:37:47 +0000 (12:37 +0200)]
Remove "struct samr_info"
Volker Lendecke [Tue, 21 Apr 2009 10:35:53 +0000 (12:35 +0200)]
Fix _samr_QuerySecurity
Volker Lendecke [Tue, 21 Apr 2009 10:16:58 +0000 (12:16 +0200)]
Fix samr_SetSecurity
Günther Deschner [Tue, 21 Apr 2009 11:01:29 +0000 (13:01 +0200)]
s3-secdesc: remove SEC_RIGHT_MAXIMUM_ALLOWED and SEC_RIGHT_SYSTEM_SECURITY.
We had up to three incarnations of these flags in Samba3.
Guenther
Günther Deschner [Tue, 14 Apr 2009 23:30:12 +0000 (01:30 +0200)]
s3-secdesc: move all winreg access bits to IDL.
Guenther
Günther Deschner [Tue, 14 Apr 2009 23:19:30 +0000 (01:19 +0200)]
s3-secdesc: use SEC_FLAG_SYSTEM_SECURITY instead of SEC_RIGHT_SYSTEM_SECURITY.
Guenther
Günther Deschner [Tue, 14 Apr 2009 23:16:41 +0000 (01:16 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHT_MAXIMUM_ALLOWED.
Guenther
Günther Deschner [Tue, 14 Apr 2009 23:12:13 +0000 (01:12 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHTS_MAXIMUM_ALLOWED.
Guenther
Andrew Bartlett [Tue, 21 Apr 2009 10:20:37 +0000 (12:20 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Günther Deschner [Tue, 21 Apr 2009 10:10:11 +0000 (12:10 +0200)]
libgpo: use shared access bits in gpo_sd_check_agp_object().
Guenther
Andrew Bartlett [Tue, 21 Apr 2009 10:06:04 +0000 (12:06 +0200)]
Add str() for policy_handles.
Pair programmed with Jelmer
Volker Lendecke [Mon, 20 Apr 2009 17:04:20 +0000 (19:04 +0200)]
Convert the alias handles to type-safe policy handles
Volker Lendecke [Mon, 20 Apr 2009 16:27:39 +0000 (18:27 +0200)]
Convert the group handles to type-safe policy handles
Volker Lendecke [Mon, 20 Apr 2009 16:01:49 +0000 (18:01 +0200)]
Convert the user handles to type-safe policy handles
Andrew Bartlett [Tue, 21 Apr 2009 09:53:00 +0000 (11:53 +0200)]
python/dcerpc: Custom implementations of policy_handle.__init__ and policy_handle.__repr__
pair-programmed with Jelmer
Andrew Bartlett [Tue, 21 Apr 2009 09:14:11 +0000 (11:14 +0200)]
python/rpc: Add custom GUID.__str__, GUID.__repr__, GUID.__init__ and GUID.__cmp__.
Jelmer Vernooij [Mon, 20 Apr 2009 21:58:26 +0000 (23:58 +0200)]
Remove smb_mkstemp() - libreplace will now provide a secure mkstemp() if
the system one is broken.
Günther Deschner [Mon, 20 Apr 2009 21:38:11 +0000 (23:38 +0200)]
libgpo: fix the build of gpext plugins.
Guenther
Günther Deschner [Mon, 20 Apr 2009 17:15:32 +0000 (19:15 +0200)]
libgpo: Fix some minor issues.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Mon, 20 Apr 2009 14:51:33 +0000 (16:51 +0200)]
Fix ini parsing in the s3 gpext modules. Fix ini parser API. Make the build work
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Mon, 20 Apr 2009 12:57:33 +0000 (14:57 +0200)]
Move gpo_ini stuff to the main libgpo. Make gpo_ini use a common parser.
It now makes use of lib/util/param.c to parse ini files.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Mon, 20 Apr 2009 08:11:00 +0000 (10:11 +0200)]
Fix Samba 4 Makefile to also clean ../libgpo
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Mon, 20 Apr 2009 07:57:00 +0000 (09:57 +0200)]
Move some headers around to avoid confusion.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Mon, 20 Apr 2009 07:56:08 +0000 (09:56 +0200)]
Move some headers around to avoid confusion.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 15 Mar 2009 19:34:59 +0000 (20:34 +0100)]
Adjust samba 3 to the new gpo API. Still untested code.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 15 Mar 2009 03:40:12 +0000 (04:40 +0100)]
Make the gpo files build for samba 4.
Only gpt.ini remaining. Not suitable for merge yet, samba 3 is currently broken due to some changed public API.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 1 Mar 2009 18:49:42 +0000 (19:49 +0100)]
Mark the places where work needs to be done.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 1 Mar 2009 17:44:58 +0000 (18:44 +0100)]
Add nt_token_check_sid convenience function. Map NT_USER_TOKEN to struct security_token. Fix build errors.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 1 Mar 2009 15:53:07 +0000 (16:53 +0100)]
Add ../libgpo to samba4 srcdir list in rules.mk.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 1 Mar 2009 15:25:57 +0000 (16:25 +0100)]
Make gpo_ldap.c compatible with samba 4. Add ads_get_ldap_server_name() function to samba 3. Move prototypes to root libgpo where appropriate.
gpo_ldap.c now compiles for both samba 3 and 4.
Signed-off-by: Günther Deschner <gd@samba.org>
Wilco Baan Hofman [Sun, 1 Mar 2009 13:06:36 +0000 (14:06 +0100)]
Add ads convenience functions to samba 4. Move gpo_ldap.c to root libgpo.
Signed-off-by: Günther Deschner <gd@samba.org>
Jelmer Vernooij [Sun, 1 Mar 2009 01:53:42 +0000 (02:53 +0100)]
Move gpo_fetch to top-level.
Signed-off-by: Günther Deschner <gd@samba.org>
Jelmer Vernooij [Sun, 1 Mar 2009 01:44:51 +0000 (02:44 +0100)]
Move gpo_sec to top-level.
Signed-off-by: Günther Deschner <gd@samba.org>
Jelmer Vernooij [Sun, 1 Mar 2009 01:13:21 +0000 (02:13 +0100)]
Move some libgpo files to root.
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 17 Apr 2009 11:05:04 +0000 (13:05 +0200)]
pidl:Samba4/client: fix dcerpc_ndr_request_send() callers
For samba4 you need one of this:
samba/source4# make full_idl
samba/source4# make clean
samba# git clean -x -f
metze
Stefan Metzmacher [Fri, 17 Apr 2009 09:48:31 +0000 (11:48 +0200)]
s4:librpc/rpc: pass async as argument to dcerpc_ndr_request_send()
The caller should decide if async is desired it should be harcoded per call.
metze