samba.git
9 years agoctdb-build: Remove unnecessary third_party symlink
Amitay Isaacs [Thu, 21 Aug 2014 04:46:54 +0000 (14:46 +1000)]
ctdb-build: Remove unnecessary third_party symlink

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
9 years agoldb: Fix check for third_party
Amitay Isaacs [Thu, 21 Aug 2014 04:34:03 +0000 (14:34 +1000)]
ldb: Fix check for third_party

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
9 years agowafsamba: Correctly locate the 'third_party' directory
Amitay Isaacs [Thu, 21 Aug 2014 04:33:42 +0000 (14:33 +1000)]
wafsamba: Correctly locate the 'third_party' directory

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
9 years agoctdb-build: Avoid unused variable warning in output from rpcgen
Martin Schwenke [Mon, 4 Aug 2014 04:52:00 +0000 (14:52 +1000)]
ctdb-build: Avoid unused variable warning in output from rpcgen

  default/ctdb/utils/smnotify/gen_xdr.c: In function ‘xdr_status’:
  default/ctdb/utils/smnotify/gen_xdr.c:11:20: warning: unused variable ‘buf’ [-Wunused-variable]
    register int32_t *buf;
                      ^

When generating the code, change it to assign the variable to itself.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Aug 21 07:11:02 CEST 2014 on sn-devel-104

9 years agoctdb-daemon: Fix some strict-aliasing warnings
Martin Schwenke [Mon, 4 Aug 2014 04:50:17 +0000 (14:50 +1000)]
ctdb-daemon: Fix some strict-aliasing warnings

Seeing these with -Wall:

  ../server/ctdb_call.c:1117:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     record_flags = *(uint32_t *)&c->data[c->keylen + c->datalen];
     ^

memcpy() seems to be the easiest way to get fix these.  The
alternative would be to use unmarshalling functions.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
9 years agoctdb-util: Fix warning about ignored result from system()
Martin Schwenke [Wed, 30 Jul 2014 11:10:01 +0000 (21:10 +1000)]
ctdb-util: Fix warning about ignored result from system()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
9 years agoctdb: Use sys_read() and sys_write() to ensure correct signal interaction
Martin Schwenke [Wed, 30 Jul 2014 11:03:53 +0000 (21:03 +1000)]
ctdb: Use sys_read() and sys_write() to ensure correct signal interaction

... and avoid compiler warnings in some cases.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
9 years agoctdb-common: Copy functions sys_read() and sys_write() from source3
Martin Schwenke [Wed, 30 Jul 2014 10:50:59 +0000 (20:50 +1000)]
ctdb-common: Copy functions sys_read() and sys_write() from source3

We really should extricate these from source3 and into some common
code.  However, just copy them for now to help get rid of a lot of
warnings.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
9 years agoctdb-tools: Be more helpful when CTDB CLI tool is run on unconfigured node
Martin Schwenke [Wed, 20 Aug 2014 23:26:39 +0000 (09:26 +1000)]
ctdb-tools: Be more helpful when CTDB CLI tool is run on unconfigured node

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
9 years agoctdb-tools: Factor out new function find_node_xpnn() from control_xpnn()
Martin Schwenke [Fri, 8 Aug 2014 00:43:44 +0000 (10:43 +1000)]
ctdb-tools: Factor out new function find_node_xpnn() from control_xpnn()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
9 years agoreplace: Remove unused item returned by FAILED()
Martin Schwenke [Thu, 31 Jul 2014 01:03:59 +0000 (11:03 +1000)]
replace: Remove unused item returned by FAILED()

The (return) value of FAILED() is a constant 1.  However, it is never
used, so the compiler complains when run with -Wall:

  lib/replace/test/os2_delete.c: In function ‘cleanup’:
  lib/replace/test/os2_delete.c:39:163: warning: right-hand operand of comma expression has no effect [-Wunused-value]
   FAILED("system");

So just get remove the ", 1" since it is the bit that does nothing and
is never used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Aug 20 16:54:31 CEST 2014 on sn-devel-104

9 years agos4:torture:vfs_fruit: add tests for resource fork IO
Ralph Boehme [Fri, 11 Jul 2014 10:58:37 +0000 (12:58 +0200)]
s4:torture:vfs_fruit: add tests for resource fork IO

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Aug 18 20:08:32 CEST 2014 on sn-devel-104

9 years agos4:torture:vfs_fruit: add test writing Netatalk metadata
Ralph Boehme [Thu, 10 Jul 2014 14:40:28 +0000 (16:40 +0200)]
s4:torture:vfs_fruit: add test writing Netatalk metadata

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agos4:torture:vfs_fruit: add test reading Netatalk metadata
Ralph Boehme [Tue, 8 Jul 2014 03:50:09 +0000 (05:50 +0200)]
s4:torture:vfs_fruit: add test reading Netatalk metadata

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agos4:torture: add boilerplate code for vfs_fruit
Ralph Boehme [Tue, 8 Jul 2014 03:47:02 +0000 (05:47 +0200)]
s4:torture: add boilerplate code for vfs_fruit

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agos4:torture: add wrapper functions
Ralph Boehme [Tue, 8 Jul 2014 03:39:49 +0000 (05:39 +0200)]
s4:torture: add wrapper functions

Add wrapper functions that connect two trees with sharenames taken
from passed option.

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agos4:torture: add boilerplate code for testing specific VFS modules
Ralph Boehme [Tue, 8 Jul 2014 03:36:46 +0000 (05:36 +0200)]
s4:torture: add boilerplate code for testing specific VFS modules

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agos4:torture:smb2: add utility function torture_smb2_con_sopt()
Ralph Boehme [Fri, 27 Jun 2014 23:09:58 +0000 (01:09 +0200)]
s4:torture:smb2: add utility function torture_smb2_con_sopt()

Add a utility function that takes an option name as parameter and then
uses the value of the option 'torture:NAME' as share name in a tree
connect.

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agovfs_fruit: add manpage
Ralph Boehme [Mon, 23 Jun 2014 15:01:30 +0000 (17:01 +0200)]
vfs_fruit: add manpage

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agoNew VFS module vfs_fruit
Ralph Boehme [Mon, 23 Jun 2014 14:59:45 +0000 (16:59 +0200)]
New VFS module vfs_fruit

This module provides enhanced compatibility with Apple SMB clients and
interoperability with a Netatalk 3 AFP fileserver.

The module intercepts the OS X special streams "AFP_AfpInfo" and
"AFP_Resource" and handles them in a special way. All other named
streams are deferred to vfs_streams_xattr.

The OS X client maps all NTFS illegal characters to the Unicode
private range. This module optionally stores the charcters using their
native ASCII encoding.

Open modes are optionally checked against Netatalk AFP share modes.

The "AFP_AfpInfo" named stream is a binary blob containing OS X
extended metadata for files and directories. This module optionally
reads and stores this metadata in a way compatible with Netatalk 3
which stores the metadata in an EA "org.netatalk.metadata". Cf
source3/include/MacExtensions.h for a description of the binary blobs
content.

The "AFP_Resource" named stream may be arbitrarily large, thus it
can't be stored in an EA on most filesystem. ZFS on Solaris is an
exception to the rule, because it there EAs can be of any size and EAs
are first-class filesystem objects that can be used with normal file
syscalls like open(), read(), write(), fcntl() asf. This module stores
the AFP_Resource stream in an AppleDouble file, prepending "._" to the
filename. On Solaris and ZFS the stream is optionally stored in an EA
"org.netatalk.ResourceFork".

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agoFix AFP_BackupTime byte order and use ISO C99 integer types
Ralph Boehme [Thu, 10 Jul 2014 14:32:15 +0000 (16:32 +0200)]
Fix AFP_BackupTime byte order and use ISO C99 integer types

AFP_BackupTime value must be 0x80000000 and all existing defines use
native byte order, not byte swapped.

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agos4:torture: use torture_assert instead of torture_comment and return in defer_open...
Michael Adam [Mon, 18 Aug 2014 13:10:15 +0000 (15:10 +0200)]
s4:torture: use torture_assert instead of torture_comment and return in defer_open test

The fix missed one instance, as autobuild has just told me...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Aug 18 17:42:00 CEST 2014 on sn-devel-104

9 years agobuild: fix configure to honour --without-dmapi
Michael Adam [Mon, 18 Aug 2014 09:42:27 +0000 (11:42 +0200)]
build: fix configure to honour --without-dmapi

Previously, --without-dmapi would still autodetect and link a useable dmapi
library. This change allows to build without dmapi support even when a dmapi
library is found.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10369

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agotdbtorture: print details when run with -n 1
David Disseldorp [Fri, 15 Aug 2014 12:47:49 +0000 (14:47 +0200)]
tdbtorture: print details when run with -n 1

Currently tdbtorture prints the test details (processes, loops, etc.)
from the first forked child process.
When run with -n 1 (one process), the test is run from within the
parent and no details are printed. This change ensures that they are.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Aug 18 13:26:32 CEST 2014 on sn-devel-104

9 years agodsdb: Also redact the clearTextPassword input-only attribute
Andrew Bartlett [Fri, 21 Feb 2014 02:24:24 +0000 (15:24 +1300)]
dsdb: Also redact the clearTextPassword input-only attribute

We go to a great deal of effort to avoid administrators posting their
passwords in Samba logs, and one of the ways we do that is to remove
them from internal ldif dumps Samba produces while operating as an AD
DC.

clearTextPassword is not a real attribute, but it functions as one for
an input path.

Change-Id: Iaacf3354fc9bfff18d6774f49b17a9ba962347d5
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Aug 16 01:05:07 CEST 2014 on sn-devel-104

9 years agolib: Remove parser code, now replaced with tini parser.
Volker Lendecke [Fri, 15 Aug 2014 05:50:48 +0000 (05:50 +0000)]
lib: Remove parser code, now replaced with tini parser.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 15 20:34:56 CEST 2014 on sn-devel-104

9 years agolibrpc: Remove obsolete idl-deps script.
Jelmer Vernooij [Fri, 6 Dec 2013 02:15:47 +0000 (02:15 +0000)]
librpc: Remove obsolete idl-deps script.

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 15 05:47:51 CEST 2014 on sn-devel-104

9 years agoRemove iniparser.
Jeremy Allison [Wed, 13 Aug 2014 23:41:33 +0000 (16:41 -0700)]
Remove iniparser.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 14 23:52:07 CEST 2014 on sn-devel-104

9 years agoRemove popt/iniparser from .clang_complete
Jeremy Allison [Thu, 14 Aug 2014 18:12:30 +0000 (18:12 +0000)]
Remove popt/iniparser from .clang_complete

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agoDon't build iniparser anymore.
Jeremy Allison [Wed, 13 Aug 2014 23:40:40 +0000 (16:40 -0700)]
Don't build iniparser anymore.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agoReplace all uses of iniparser with tiniparser.
Jeremy Allison [Wed, 13 Aug 2014 23:36:28 +0000 (16:36 -0700)]
Replace all uses of iniparser with tiniparser.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agoAdd tiniparser - tiny version of iniparser that only implements what Samba uses.
Jeremy Allison [Wed, 13 Aug 2014 23:00:00 +0000 (16:00 -0700)]
Add tiniparser - tiny version of iniparser that only implements what Samba uses.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
9 years agoUse tini in preference.
Volker Lendecke [Wed, 13 Aug 2014 05:24:21 +0000 (07:24 +0200)]
Use tini in preference.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agoAdd tini parser.
Volker Lendecke [Tue, 12 Aug 2014 11:02:35 +0000 (13:02 +0200)]
Add tini parser.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agoctdb-readonly: Do not abort if revoke of readonly record fails on a node
Amitay Isaacs [Tue, 12 Aug 2014 13:58:00 +0000 (23:58 +1000)]
ctdb-readonly: Do not abort if revoke of readonly record fails on a node

Revoking readonly record involves first marking the record on dmaster as
RO_REVOKING_READONLY.  Then all the other nodes are sent update_record
control to get rid of RO_DELEGATION.  Once that succeeds, the record
is marked RO_REVOKING_COMPLETE.

Currently, revoking of readonly delegations on the nodes is tried only
once.  If a node goes in recovery, it can fail update_record control and
revoke code will abort ctdb.  Since database recovery would revoke all
readonly delegations anyway, there is no reason to abort.  Simply undo
the start of revoke process by resetting RO_REVOKING_READONLY flag.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Aug 13 11:24:09 CEST 2014 on sn-devel-104

9 years agoctdb-readonly: Add an early return to simplify code
Amitay Isaacs [Tue, 12 Aug 2014 13:54:39 +0000 (23:54 +1000)]
ctdb-readonly: Add an early return to simplify code

This patch makes the subsequent logic change small and easier to
understand.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
9 years agoctdb-doc: Fix default database directories in ctdbd.1
Martin Schwenke [Sun, 10 Aug 2014 09:02:42 +0000 (19:02 +1000)]
ctdb-doc: Fix default database directories in ctdbd.1

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Aug 13 07:06:42 CEST 2014 on sn-devel-104

9 years agoFixed a memory leak in cli_set_mntpoint().
Har Gagan Sahai [Wed, 6 Aug 2014 09:02:35 +0000 (14:32 +0530)]
Fixed a memory leak in cli_set_mntpoint().

Fixes bug #10759 - Memory leak in libsmbclient in cli_set_mntpoint function

https://bugzilla.samba.org/show_bug.cgi?id=10759

Signed-off-by: Har Gagan Sahai <SHarGagan@novell.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 13 04:36:50 CEST 2014 on sn-devel-104

9 years agomessaging3: Include messages_dgm.h only in messages.c
Volker Lendecke [Sun, 27 Jul 2014 10:31:21 +0000 (12:31 +0200)]
messaging3: Include messages_dgm.h only in messages.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 12 02:21:32 CEST 2014 on sn-devel-104

9 years agomessaging3: Move messaging_hdr handling to messages.c.
Volker Lendecke [Sun, 27 Jul 2014 10:29:26 +0000 (12:29 +0200)]
messaging3: Move messaging_hdr handling to messages.c.

This makes messages_dgm a simple byte-transport across processes that
knows almost nothing about server_id etc.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Only store the pid in messaging_dgm_context
Volker Lendecke [Fri, 25 Jul 2014 11:03:11 +0000 (11:03 +0000)]
messaging3: Only store the pid in messaging_dgm_context

That's all we need here

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Save 48 bytes .text
Volker Lendecke [Fri, 25 Jul 2014 10:42:19 +0000 (10:42 +0000)]
messaging3: Save 48 bytes .text

9 years agomessaging3: Remove one-context protection from messages.c
Volker Lendecke [Sat, 9 Aug 2014 15:18:04 +0000 (17:18 +0200)]
messaging3: Remove one-context protection from messages.c

messages_dgm.c takes care of it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Protect messaging_dgm against multiple contexts
Volker Lendecke [Sun, 20 Jul 2014 12:51:47 +0000 (14:51 +0200)]
messaging3: Protect messaging_dgm against multiple contexts

We can't rely on posix locking within a process

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Add messages_dgm.h
Volker Lendecke [Thu, 17 Jul 2014 11:57:51 +0000 (11:57 +0000)]
messaging3: Add messages_dgm.h

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Pass on msg_type unmasked
Volker Lendecke [Thu, 17 Jul 2014 11:56:18 +0000 (11:56 +0000)]
messaging3: Pass on msg_type unmasked

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: I don't see 2 versions running concurrently...
Volker Lendecke [Thu, 17 Jul 2014 11:55:33 +0000 (11:55 +0000)]
messaging3: I don't see 2 versions running concurrently...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Avoid "enum messaging_type" in messages_dgm
Volker Lendecke [Thu, 17 Jul 2014 11:51:13 +0000 (11:51 +0000)]
messaging3: Avoid "enum messaging_type" in messages_dgm

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Pass dir_owner to messaging_dgm_init()
Volker Lendecke [Thu, 17 Jul 2014 11:47:32 +0000 (11:47 +0000)]
messaging3: Pass dir_owner to messaging_dgm_init()

9 years agomessaging3: Pass cache_dir to messaging_dgm_init()
Volker Lendecke [Thu, 17 Jul 2014 11:38:36 +0000 (11:38 +0000)]
messaging3: Pass cache_dir to messaging_dgm_init()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Move [un]become_root() calls out of messaging_dgm_send()
Volker Lendecke [Thu, 17 Jul 2014 11:34:24 +0000 (11:34 +0000)]
messaging3: Move [un]become_root() calls out of messaging_dgm_send()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Move sec_init() call out of messaging_dgm_init()
Volker Lendecke [Thu, 17 Jul 2014 11:33:26 +0000 (11:33 +0000)]
messaging3: Move sec_init() call out of messaging_dgm_init()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Directly refer to messaging_dgm in messages.c
Volker Lendecke [Thu, 17 Jul 2014 11:23:46 +0000 (11:23 +0000)]
messaging3: Directly refer to messaging_dgm in messages.c

This removes the messaging_backend abstraction layer from messages_dgm.c. That
layer was introduced for ctdb and is still used there. But as the messaging_dgm
interface is very slim anyway, I don't think directly calling it is too bad.

Why this commit? It is another step towards making messages_dgm
independent of messages.[ch], thus it might become usable in other
contexts like ctdb and source4

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agosmbd: Use messaging_cleanup()
Volker Lendecke [Thu, 17 Jul 2014 11:05:02 +0000 (11:05 +0000)]
smbd: Use messaging_cleanup()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Add messaging_cleanup
Volker Lendecke [Thu, 17 Jul 2014 11:01:00 +0000 (11:01 +0000)]
messaging3: Add messaging_cleanup

Rename smbcontrol's dgm-cleanup to msg-cleanup. We haven't published
this UI yet :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging_dgm: Remove unused "messaging_context"
Volker Lendecke [Thu, 17 Jul 2014 09:58:50 +0000 (09:58 +0000)]
messaging_dgm: Remove unused "messaging_context"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Explicitly pass server_id to messaging_dgm_init
Volker Lendecke [Thu, 17 Jul 2014 09:56:39 +0000 (09:56 +0000)]
messaging3: Explicitly pass server_id to messaging_dgm_init

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Explicitly pass tevent_context to messaging_dgm_init
Volker Lendecke [Thu, 17 Jul 2014 09:52:28 +0000 (09:52 +0000)]
messaging3: Explicitly pass tevent_context to messaging_dgm_init

One dependency less on messaging_context()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging_dgm: Receive through a cb function
Volker Lendecke [Thu, 17 Jul 2014 09:44:41 +0000 (09:44 +0000)]
messaging_dgm: Receive through a cb function

This avoids calling messaging_dispatch_rec directly from messaging_dgm.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agosmbd: Add debugs to smbXsrv_open.c
Volker Lendecke [Mon, 7 Jul 2014 11:49:49 +0000 (11:49 +0000)]
smbd: Add debugs to smbXsrv_open.c

At one point it was pretty difficult to track a failure. Add more DEBUG
to avoid gdb

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 11 23:32:45 CEST 2014 on sn-devel-104

9 years agosmbd: Pass down "lease" to open_file_ntcreate
Volker Lendecke [Wed, 21 Aug 2013 15:58:23 +0000 (15:58 +0000)]
smbd: Pass down "lease" to open_file_ntcreate

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agosmbd: Pass down "lease" to create_file_unixpath
Volker Lendecke [Wed, 21 Aug 2013 15:56:50 +0000 (15:56 +0000)]
smbd: Pass down "lease" to create_file_unixpath

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agovfs3: Pass "lease" through SMB_VFS_CREATE_FILE
Volker Lendecke [Wed, 21 Aug 2013 13:56:14 +0000 (13:56 +0000)]
vfs3: Pass "lease" through SMB_VFS_CREATE_FILE

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agoMAINTAINERS: Remove MAINTAINERS.txt
Ira Cooper [Sun, 10 Aug 2014 15:11:26 +0000 (11:11 -0400)]
MAINTAINERS: Remove MAINTAINERS.txt

Due to the new code review rules, there is no more need for the
MAINTAINERS.txt file.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agomessaging3: Fix an error path memleak
Volker Lendecke [Sat, 9 Aug 2014 16:51:05 +0000 (16:51 +0000)]
messaging3: Fix an error path memleak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agoparam: avoid dereferencing null lp_ctx
David Disseldorp [Mon, 11 Aug 2014 15:51:58 +0000 (17:51 +0200)]
param: avoid dereferencing null lp_ctx

process_smbconf_service() calls lp_do_section() with a NULL userdata
(struct loadparm_context *) argument. Since 0864d4945, lp_do_section()
unconditionally attempts to set the lp_ctx->bInGlobalSection variable,
resulting in a segfault.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Aug 11 21:00:15 CEST 2014 on sn-devel-104

9 years agoparam: remove unimplemented find_service() check
David Disseldorp [Mon, 11 Aug 2014 15:29:27 +0000 (17:29 +0200)]
param: remove unimplemented find_service() check

Check for "default VFS service" is empty, and we don't currently provide
such a feature.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agoctdb-build: popt has moved from lib/ to third_party/
Amitay Isaacs [Mon, 11 Aug 2014 06:02:27 +0000 (16:02 +1000)]
ctdb-build: popt has moved from lib/ to third_party/

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Aug 11 10:58:43 CEST 2014 on sn-devel-104

9 years agoctdb-build: Replace indentation tabs with spaces
Amitay Isaacs [Mon, 11 Aug 2014 06:02:00 +0000 (16:02 +1000)]
ctdb-build: Replace indentation tabs with spaces

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
9 years agolib/popt: Remove non third_party popt.
Ira Cooper [Wed, 23 Jul 2014 04:11:01 +0000 (21:11 -0700)]
lib/popt: Remove non third_party popt.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Sat Aug  9 20:47:05 CEST 2014 on sn-devel-104

9 years agothird_party/popt: Initial support for popt.
Ira Cooper [Wed, 23 Jul 2014 04:34:17 +0000 (21:34 -0700)]
third_party/popt: Initial support for popt.

ctdb, ldb, and samba are supported builds for third_party popt.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agothird_party/popt: Initial copy of popt.
Ira Cooper [Wed, 23 Jul 2014 07:17:30 +0000 (00:17 -0700)]
third_party/popt: Initial copy of popt.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agolib/zlib: Remove non third_party zlib.
Ira Cooper [Wed, 23 Jul 2014 07:16:24 +0000 (00:16 -0700)]
lib/zlib: Remove non third_party zlib.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agothird_party/zlib: Initial support for zlib
Ira Cooper [Wed, 23 Jul 2014 04:27:13 +0000 (21:27 -0700)]
third_party/zlib: Initial support for zlib

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agothird_party/zlib: Initial copy of zlib.
Ira Cooper [Wed, 23 Jul 2014 04:26:40 +0000 (21:26 -0700)]
third_party/zlib: Initial copy of zlib.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agolib/iniparser: Remove non third_party iniparser.
Ira Cooper [Thu, 17 Jul 2014 22:07:31 +0000 (18:07 -0400)]
lib/iniparser: Remove non third_party iniparser.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agothird_party/iniparser: Initial support for iniparser.
Ira Cooper [Thu, 17 Jul 2014 22:04:35 +0000 (18:04 -0400)]
third_party/iniparser: Initial support for iniparser.

This is the initial support for iniparser, as well the basic
third_party framework.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agothird_party/iniparser: Initial copy of iniparser.
Ira Cooper [Thu, 17 Jul 2014 21:31:05 +0000 (17:31 -0400)]
third_party/iniparser: Initial copy of iniparser.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agonsswitch: Fix bogus #include line.
Ira Cooper [Wed, 16 Jul 2014 21:40:57 +0000 (17:40 -0400)]
nsswitch: Fix bogus #include line.

We are not allowed to reach around behind the system's back and
include the wrong headerfiles.

Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
9 years agopassdb: add missing newline to debug message in get_primary_group_sid()
Justin Maggard [Fri, 8 Aug 2014 17:19:41 +0000 (10:19 -0700)]
passdb: add missing newline to debug message in get_primary_group_sid()

Signed-off-by: Justin Maggard <jmaggard@netgear.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat Aug  9 00:44:06 CEST 2014 on sn-devel-104

9 years agoRevert "doc: Add new parameters to vfs_full_audit man page"
Christof Schmitt [Fri, 8 Aug 2014 17:00:43 +0000 (10:00 -0700)]
Revert "doc: Add new parameters to vfs_full_audit man page"

This reverts commit 685af0342ea7324086661a506e1d0ee15ab07f16.

Volker's patches already added the description to the manpage.

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Fri Aug  8 21:47:58 CEST 2014 on sn-devel-104

9 years agos4-auth: Initialize the tokens by default.
Andreas Schneider [Fri, 18 Jul 2014 10:57:20 +0000 (12:57 +0200)]
s4-auth: Initialize the tokens by default.

Found with valgrind.

Signed-off-by: Andreas Schneider <asn@samba.org>
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Aug  8 19:01:56 CEST 2014 on sn-devel-104

9 years agokrb5_wrap: Use com_err in krb5_warnx.
Andreas Schneider [Tue, 20 May 2014 12:30:16 +0000 (14:30 +0200)]
krb5_wrap: Use com_err in krb5_warnx.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-dsdb/cracknames: free realm from smb_krb5_principal_get_realm().
Günther Deschner [Thu, 15 May 2014 07:46:21 +0000 (09:46 +0200)]
s4-dsdb/cracknames: free realm from smb_krb5_principal_get_realm().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agos3-libads/krb5_setpw: free realm from smb_krb5_principal_get_realm().
Günther Deschner [Thu, 15 May 2014 07:45:32 +0000 (09:45 +0200)]
s3-libads/krb5_setpw: free realm from smb_krb5_principal_get_realm().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agolib/krb5_wrap: make sure smb_krb5_principal_get_realm returns a malloced string.
Günther Deschner [Thu, 15 May 2014 07:44:23 +0000 (09:44 +0200)]
lib/krb5_wrap: make sure smb_krb5_principal_get_realm returns a malloced string.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agowscript: Only build gensec_krb5 with heimdal.
Andreas Schneider [Thu, 7 Aug 2014 13:28:57 +0000 (15:28 +0200)]
wscript: Only build gensec_krb5 with heimdal.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agoprinting: reload printer shares on OpenPrinter
David Disseldorp [Tue, 5 Aug 2014 15:33:33 +0000 (17:33 +0200)]
printing: reload printer shares on OpenPrinter

The printer share inventory should be reloaded on open _and_
enumeration, as there are some clients, such as cupsaddsmb, that do not
perform an enumeration prior to access.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Aug  8 16:33:50 CEST 2014 on sn-devel-104

9 years agosmbd: split printer reload processing
David Disseldorp [Fri, 1 Aug 2014 14:25:59 +0000 (16:25 +0200)]
smbd: split printer reload processing

All printer inventory updates are currently done via
delete_and_reload_printers(), which handles registry.tdb updates for
added or removed printers, AD printer unpublishing on removal, as well
as share service creation and deletion.

This change splits this functionality into two functions such that
per-client smbd processes do not perform registry.tdb updates or printer
unpublishing. This is now only performed by the process that performs
the printcap cache update.

This change is similar to ac6604868d1325dd4c872dc0f6ab056d10ebaecf from
the 3.6 branch.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agoserver: remove duplicate snum_is_shared_printer()
David Disseldorp [Tue, 5 Aug 2014 16:45:24 +0000 (18:45 +0200)]
server: remove duplicate snum_is_shared_printer()

Only keep a single definition in server_reload.c

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agosmbd: only reprocess printer_list.tdb if it changed
David Disseldorp [Wed, 23 Jul 2014 12:42:00 +0000 (14:42 +0200)]
smbd: only reprocess printer_list.tdb if it changed

The per-client smbd printer share inventory is currently updated from
printer_list.tdb when a client enumerates printers, via EnumPrinters or
NetShareEnum.
printer_list.tdb is populated by the background print process, based on
the latest printcap values retrieved from the printing backend (e.g.
CUPS) at regular intervals.
This change ensures that per-client smbd processes don't reparse
printer_list.tdb if it hasn't been updated since the last enumeration.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Suggested-by: Volker Lendecke <vl@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agoprinting: return last change time with pcap_cache_loaded()
David Disseldorp [Wed, 23 Jul 2014 10:12:34 +0000 (12:12 +0200)]
printing: return last change time with pcap_cache_loaded()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agoprinting: remove pcap_cache_add()
David Disseldorp [Fri, 25 Jul 2014 10:18:54 +0000 (12:18 +0200)]
printing: remove pcap_cache_add()

All print list updates are now done via pcap_cache_replace(), which can
call into the print_list code directly.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agoprinting: reload printer_list.tdb from in memory list
David Disseldorp [Tue, 22 Jul 2014 18:17:38 +0000 (20:17 +0200)]
printing: reload printer_list.tdb from in memory list

This will allow in future for a single atomic printer_list.tdb update.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agoprinting: only reload printer shares on client enum
David Disseldorp [Fri, 11 Jul 2014 15:00:05 +0000 (17:00 +0200)]
printing: only reload printer shares on client enum

Currently, automatic printer share updates are handled in the following
way:
- Background printer process (BPP) forked on startup
- Parent smbd and per-client children await MSG_PRINTER_PCAP messages
- BPP periodically polls the printing backend for printcap data
- printcap data written to printer_list.tdb
- MSG_PRINTER_PCAP sent to all smbd processes following update
- smbd processes all read the latest printer_list.tdb data, and update
  their share listings

This procedure is not scalable, as all smbd processes hit
printer_list.tdb in parallel, resulting in a large spike in CPU usage.

This change sees smbd processes only update their printer share lists
only when a client asks for this information, e.g. via NetShareEnum or
EnumPrinters.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Suggested-by: Volker Lendecke <vl@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agoprinting: traverse_read the printer list for share updates
David Disseldorp [Wed, 9 Jul 2014 22:18:10 +0000 (00:18 +0200)]
printing: traverse_read the printer list for share updates

The printcap update procedure involves the background printer process
obtaining the printcap information from the printing backend, writing
this to printer_list.tdb, and then notifying all smbd processes of the
new list. The processes then all attempt to simultaneously traverse
printer_list.tdb, in order to update their local share lists.

With a large number of printers, and a large number of per-client smbd
processes, this traversal results in significant lock contention, mostly
due to the fact that the traversal is unnecessarily done with an
exclusive (write) lock on the printer_list.tdb database.

This commit changes the share update code path to perform a read-only
traversal.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Reported-by: Alex K <korobkin+samba@gmail.com>
Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
9 years agolib/krb5_wrap: provide krb5_warnx() replacement.
Günther Deschner [Thu, 8 May 2014 13:06:51 +0000 (15:06 +0200)]
lib/krb5_wrap: provide krb5_warnx() replacement.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug  8 08:30:50 CEST 2014 on sn-devel-104

9 years agolib/krb5_wrap: use krb5_copy_data_contents in smb_krb5_principal_set_realm.
Günther Deschner [Tue, 13 May 2014 15:33:07 +0000 (17:33 +0200)]
lib/krb5_wrap: use krb5_copy_data_contents in smb_krb5_principal_set_realm.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agolib/krb5_wrap: provide CKSUMTYPE_HMAC_MD5 type matching MIT.
Günther Deschner [Thu, 8 May 2014 12:54:06 +0000 (14:54 +0200)]
lib/krb5_wrap: provide CKSUMTYPE_HMAC_MD5 type matching MIT.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
9 years agolib/krb5_wrap: define KRB5_PW_SALT if it is not already there.
Günther Deschner [Thu, 8 May 2014 12:31:37 +0000 (14:31 +0200)]
lib/krb5_wrap: define KRB5_PW_SALT if it is not already there.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>