Stefan Metzmacher [Fri, 8 May 2009 12:33:49 +0000 (14:33 +0200)]
s3:smbd: fix posix acls when setting an ACL without explicit ACE for the owner (bug#2346)
The problem of bug #2346 remains for users exported by
winbindd, because create_token_from_username() just fakes
the token when the user is not in the local sam domain. This causes
user_in_group_sid() to give totally wrong results.
In uid_entry_in_group() we need to check if we already
have the full unix token in the current_user struct.
If so we should use the current_user unix token,
instead of doing a very complex user_in_group_sid()
which doesn't give reliable results anyway.
metze
(cherry picked from commit
b79eff843be392f3065e912edca1434081d93c44)
Jeremy Allison [Fri, 8 May 2009 18:31:34 +0000 (11:31 -0700)]
Fix bug #6330 - DFS doesn't work on AIX. Jeremy.
This was commit
3d6f4a7af in master.
Karolin Seeger [Wed, 13 May 2009 08:07:56 +0000 (10:07 +0200)]
s3/packaging: Fix build on RHEL when ccache is not available.
This fixes bug #5832.
Patch was provided by D.L. Meyer <dlmeyer [at] uiuc.edu>.
Thanks for reporting and providing the patch!
Karolin
(cherry picked from commit
42e0cb8c0a1b8470ac8e9ad1c5a741e299debb8f)
Volker Lendecke [Wed, 6 May 2009 10:00:49 +0000 (12:00 +0200)]
Fix Coverity ID 897: REVERSE_INULL
Jeremy Allison [Tue, 28 Apr 2009 18:07:51 +0000 (11:07 -0700)]
Fix bug #6291 - force user stop working. A previous fix broke the invariant that *uid is always initialized on return from create_token_from_username(). Restore it. Jeremy.
Günther Deschner [Thu, 30 Apr 2009 21:37:26 +0000 (23:37 +0200)]
s3-netapi: Fix Bug #6309: support remote unjoining of Windows 2003 or greater.
Found by David Markey <admin@dmarkey.com>. Thanks!
Guenther
(cherry picked from commit
ab4b8c9c0438bc5afca17e3ebf05dde6f98bc0aa)
Volker Lendecke [Thu, 7 May 2009 08:09:32 +0000 (10:09 +0200)]
Fix bug 6336: "net groupmap set" segfaults
Jeremy Allison [Mon, 4 May 2009 15:31:40 +0000 (08:31 -0700)]
Fix bug #6315 smbd crashes doing vfs_full_audit on IPC$ close event. The underlying problem is that once SMBulogoff is called, all server_info contexts associated with the vuid should become invalid, even if that's the context being currently used by the connection struct (tid). When the SMBtdis comes in it doesn't need a valid vuid value, but the code called inside vfs_full_audit always assumes that there is one (and hence a valid conn->server_info pointer) available.
This is actually a bug inside the vfs_full_audit and other code inside Samba,
which should only indirect conn->server_info on calls which require AS_USER to
be set in our process table. I could fix all these issues, but there's no
guarentee that someone might not add more code that fails this assumption, as
it's a hard assumption to break (it's usually true).
So what I've done is to ensure that on SMBulogoff the previously used
conn->server_info struct is kept around to be used for print debugging purposes
(it won't be used to change to an invalid user context, as such calls need
AS_USER set). This isn't strictly correct, as there's no association with the
(now invalid) context being freed and the call that causes conn->server_info to
be indirected, but it's good enough for most cases.
The hard part was to ensure that once a valid context is used again (via new
sessionsetupX calls, or new calls on a still valid vuid on this tid) that we
don't leak memory by simply replacing the stored conn->server_info pointer. We
would never actually leak the memory (as all conn->server_info pointers are
talloc children of conn), but with the previous patch a malicious client could
cause many server_info structs to be talloced by the right combination of SMB
calls. This new patch introduces free_conn_server_info_if_unused(), which
protects against the above.
Jeremy.
This was commit
e46a88ce35e1aba9d9a344773bc97a9f3f2bd616 in master.
Karolin Seeger [Wed, 6 May 2009 14:06:59 +0000 (16:06 +0200)]
s3/docs: Remove unnecessary .sp.
Karolin
(cherry picked from commit
4a4dc776b2f0ca813abcf4f47f0d5721f75f3e6a)
(cherry picked from commit
6a617a9677da9df8f70cf2039245cfb5ce3d94c3)
Günther Deschner [Wed, 6 May 2009 13:43:23 +0000 (15:43 +0200)]
s3-docs: Fix Bug #6331. Document "net dom join/net dom unjoin".
Guenther
(cherry picked from commit
e398f1e91575909d2a90fab1e6f00804815a0b2f)
Volker Lendecke [Mon, 4 May 2009 12:39:56 +0000 (14:39 +0200)]
Do not crash in ctdbd_traverse if ctdbd is not around
Volker Lendecke [Mon, 4 May 2009 10:36:13 +0000 (12:36 +0200)]
3.3: Increase debug level of "create_connection_server_info failed" message
I don't think we should unconditionally send every refused connection attempt
to a share to syslog, that's where all debug level 0 messages end up.
Michael Adam [Tue, 5 May 2009 15:02:46 +0000 (17:02 +0200)]
s3:mark registry shares without path unavailable in the server, too
This prevents users from getting access to "/" in misconfigured setups.
Michael
Michael Adam [Mon, 27 Apr 2009 23:24:27 +0000 (01:24 +0200)]
s3:loadparm: mark registry shares without path unavailable
...just as with text config.
This applies to testparm and friends.
smbd is fixed in a second patch.
Michael
Michael Adam [Mon, 27 Apr 2009 16:10:14 +0000 (18:10 +0200)]
s3:loadparm: prevent infinite include nesting.
This introduces a hard coded MAX_INCLUDE_DEPTH of 100.
When this is exceeded, handle_include (and hence lp_load) fails.
One could of course implement a more intelligent loop detection
in the include-tree, but this would require some restructuring
of the internal loadparm housekeeping. Maybe as a second improvement
step.
Michael
Björn Jacke [Sun, 8 Mar 2009 11:54:04 +0000 (12:54 +0100)]
to be portable, use options first, arguments last
Signed-off-by: Michael Adam <obnox@samba.org>
Karolin Seeger [Mon, 4 May 2009 13:54:34 +0000 (15:54 +0200)]
s3/packaging: Add keyutils-devel to build requires.
This should fiy bug #5853. Thanks to D.L. Meyer <dlmeyer [at] uiuc.edu>
for reporting.
Karolin
(cherry picked from commit
d8de7e3193143ec50d86adc704123ca240a8f549)
Karolin Seeger [Mon, 4 May 2009 13:17:30 +0000 (15:17 +0200)]
s3/docs: Fix typo.
Karolin
(cherry picked from commit
c2eb0d87a2436614741119ebd14fda05b42a2ddd)
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
3.3 samr bug 6301: fix samr_ConnectVersion enum which is 32bit not 16bit.
Port of
67ca76c288eb095ae to 3.3
Signed-off-by: Volker Lendecke <vl@samba.org>
Karolin Seeger [Sun, 3 May 2009 07:55:46 +0000 (09:55 +0200)]
s3/docs: Fix typos.
That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!
Karolin
(cherry picked from commit
eaf949947c2eb03363c4b6f588f87b70110d6ff7)
(cherry picked from commit
cea79d1fbf44b0d5bff5aa12962fb3d3cb61c367)
Karolin Seeger [Sun, 3 May 2009 07:35:55 +0000 (09:35 +0200)]
s3/docs: Fix typo.
This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz>
for reporting!
Karolin
(cherry picked from commit
579c91581f5b6d5341a12923fe6cde377223caff)
(cherry picked from commit
49caab4044e47236594c6688f202aed555b9da61)
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.
This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!
Karolin
(cherry picked from commit
3422b9c546cdd262bd747e1e737c2b6479b4d21e)
(cherry picked from commit
3da62734fffa99cde1084beeb69e94a7bc623dde)
Karolin Seeger [Tue, 28 Apr 2009 06:45:27 +0000 (08:45 +0200)]
WHATSNEW: Update changes since 3.3.3.
Karolin
Björn Jacke [Sat, 28 Mar 2009 00:21:25 +0000 (01:21 +0100)]
ѕ3/configure: fix regexp for ld version recognition
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
(commit
740c2c4366badc62d017881c9484ee5153b62f94 in master)
(commit
172ecfae44768289b98c1bafa7aa2b89dbecc312 in v3-4-test)
Günther Deschner [Fri, 24 Apr 2009 08:02:06 +0000 (10:02 +0200)]
s3-idmap: Fix bug #6286: Call init function for builtin idmap modules before probing for them as shared modules.
idmap-gurus of the world, please check.
Guenther
(cherry picked from commit
67588ca80d654183b8b7b062b9660a506a825f94)
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.
Guenther
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases
Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces
When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
Jeremy Allison [Wed, 22 Apr 2009 10:04:22 +0000 (03:04 -0700)]
Add comment explaining the previous fix.
Jeremy.
Jeremy Allison [Wed, 22 Apr 2009 09:24:27 +0000 (02:24 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy
John H Terpstra [Mon, 20 Apr 2009 15:06:33 +0000 (10:06 -0500)]
Added ability to revert to old modules for make revert.
Stefan Metzmacher [Fri, 3 Apr 2009 10:21:17 +0000 (12:21 +0200)]
s3:docs: document the --request-timeout option of net
metze
(cherry picked from commit
cdbbc81bad5d53397bf80898cf68d8867cf64cba)
(cherry picked from commit
1d1e859c4e08fed1775a170ccff459f3a18e13ba)
Stefan Metzmacher [Thu, 26 Mar 2009 19:32:55 +0000 (20:32 +0100)]
s3:net: add --request-timeout option
metze
(cherry picked from commit
257809558bfab3e45703cf8be76357596392a3ea)
(cherry picked from commit
e20b8706401d1a4eee0fe494825deef6ab23ab23)
Stefan Metzmacher [Thu, 26 Mar 2009 19:29:24 +0000 (20:29 +0100)]
s3:net_rpc: don't shutdown a cli_state passed from the caller
This fixes a crash bug if we timeout in net rpc trustdom list.
metze
(cherry picked from commit
c0dfe0cf80ee50f395912b7d6aec0d87febd34c0)
(cherry picked from commit
d87563604ca7b1c18c5a84d76726c2a99dc454f8)
Volker Lendecke [Wed, 15 Apr 2009 11:01:09 +0000 (13:01 +0200)]
Do not use the file system GET_REAL_FILENAME for mangled names
Karolin Seeger [Sat, 18 Apr 2009 09:01:36 +0000 (11:01 +0200)]
WHATSNEW: Update planned release date.
Karolin
Karolin Seeger [Sat, 18 Apr 2009 07:58:41 +0000 (09:58 +0200)]
WHATSNEW: Prepare WHATSNEW for 3.3.4.
Karolin
Karolin Seeger [Fri, 17 Apr 2009 14:15:08 +0000 (16:15 +0200)]
VERSION: Raise version number up to 3.3.4.
Karolin
Günther Deschner [Fri, 17 Apr 2009 13:46:36 +0000 (15:46 +0200)]
s3-test: enable RPC-LSA-LOOKUPSIDS and RPC-JOIN during make test.
Guenther
Michael Adam [Fri, 17 Apr 2009 09:40:17 +0000 (11:40 +0200)]
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
Jim McDonough [Fri, 17 Apr 2009 07:24:49 +0000 (09:24 +0200)]
Merge branch 'v3-3-test' of /home/jmcd/samba/git.samba.org/samba-master into 33-test
Günther Deschner [Thu, 16 Apr 2009 23:30:54 +0000 (01:30 +0200)]
s3-docs: fix typo in smb.conf.5.
Guenther
(cherry picked from commit
05ea8daacabe62b6c20770a8518192c44e7eb763)
Günther Deschner [Thu, 16 Apr 2009 11:03:35 +0000 (13:03 +0200)]
s3-docs: document warn_pwd_expire pam_winbind option in manpage.
Andreas, please check.
Guenther
(cherry picked from commit
5517c0bcddfbd8c877fd1f909407824553a20e7f)
Jeremy Allison [Thu, 16 Apr 2009 23:21:00 +0000 (16:21 -0700)]
Add torture tester to ensure we don't regress the ulogoff bug.
Jeremy.
Jeremy Allison [Thu, 16 Apr 2009 23:20:12 +0000 (16:20 -0700)]
Fix bug found by Tim Prouty, logging off and then re-using a vuid can cause smbd to
access a freed structure.
Jeremy.
Jeremy Allison [Thu, 16 Apr 2009 22:14:37 +0000 (15:14 -0700)]
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy.
Jim McDonough [Thu, 16 Apr 2009 15:04:00 +0000 (17:04 +0200)]
Don't look up local user for remote changes, even when root.
Martin Schwenke [Thu, 16 Apr 2009 00:25:29 +0000 (10:25 +1000)]
In net_conf_import, start a transaction when importing a single share.
Commit
d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction
start to be conditional but the commit is still unconditional, so an
error occurs when importing a single share.
An alternate fix would be to return the transaction start to be
unconditional but then it would occur before other error checking.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Michael Adam <obnox@samba.org>
Günther Deschner [Wed, 15 Apr 2009 23:42:35 +0000 (01:42 +0200)]
s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
Jeremy Allison [Wed, 15 Apr 2009 21:31:43 +0000 (14:31 -0700)]
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
What a difference a name makes... :-). Just because something is missnamed
SA_RIGHT_SAM_OPEN_DOMAIN, when it should actually be SA_RIGHT_SAM_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
Günther Deschner [Tue, 14 Apr 2009 20:39:36 +0000 (22:39 +0200)]
netdomjoin-gui: make sure to grey out change fields when not running as root.
Guenther
(cherry picked from commit
ca3de0103b545c86c8507dfc7d042f1838d5dfb2)
(cherry picked from commit
cb96e70a1d9112d9e4fff1fda4cf64abc7985347)
Guenther Deschner [Mon, 13 Apr 2009 16:44:54 +0000 (09:44 -0700)]
s3-loadparm: Fix resume command typo for "printing = vlp".
Volker Lendecke [Sat, 11 Apr 2009 20:54:06 +0000 (13:54 -0700)]
Fix a memleak in an unlikely error path in change_notify_create()
Jeremy Allison [Fri, 10 Apr 2009 05:46:31 +0000 (22:46 -0700)]
Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3)
has parameter "msdfs root = yes"
This was broken by the refactoring around create_file().
MSDFS pathname processing must be done FIRST.
MSDFS pathnames containing IPv6 addresses can
be confused with NTFS stream names (they contain
":" characters.
Jeremy.
Jeremy Allison [Fri, 10 Apr 2009 04:21:11 +0000 (21:21 -0700)]
Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
Günther Deschner [Wed, 8 Apr 2009 20:48:41 +0000 (22:48 +0200)]
error-codes: add some service related error codes.
Guenther
Günther Deschner [Wed, 8 Apr 2009 19:45:04 +0000 (21:45 +0200)]
s3-net: Fix Bug #5329: add "net rpc service delete/create".
Patch from Danny Tylman <danny.tylman@insightix.com>.
Guenther
(cherry picked from commit
d0c307af56006d6fb898e395613d7e9c29b84116)
Karolin Seeger [Wed, 8 Apr 2009 15:49:21 +0000 (17:49 +0200)]
s3/packaging: Add idmap_hash and idmap_adex to the list of built modules.
Karolin
(cherry picked from commit
bed4f8413435c39e37ea04940a18ee78481db48f)
(cherry picked from commit
c005bd724062273586ed9e3373826ed42ec396ce)
Karolin Seeger [Tue, 7 Apr 2009 18:01:27 +0000 (20:01 +0200)]
s3/popt.h: Fix typo.
This used to be commit
8da2fa36 in master.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 18:00:47 +0000 (20:00 +0200)]
s3/loadparm: Fiy typos.
This used to be commit
44588095 in master.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 17:58:47 +0000 (19:58 +0200)]
s3/gpo_ldap: Fix typo.
This used to be commit
a103222e in master.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 17:58:14 +0000 (19:58 +0200)]
s3/smbconf_reg: Fix typo.
This used to be commit
6343cab3 in master.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 17:55:45 +0000 (19:55 +0200)]
s3/docs: Fix typo.
Karolin
(cherry picked from commit
c002c1d776bc62bafe62e29a91e05100c5025890)
Volker Lendecke [Sun, 5 Apr 2009 05:32:03 +0000 (07:32 +0200)]
Make some functions static to vfs_gpfs.c
Volker Lendecke [Sun, 5 Apr 2009 05:31:30 +0000 (07:31 +0200)]
Fix two c++ warnings in vfs_gpfs.c
Günther Deschner [Mon, 6 Apr 2009 10:45:46 +0000 (12:45 +0200)]
s3-examples: Fix Bug #6205. Correct sample smb.conf share configuration.
Thanks to Jeffrey Riaboy <dakusan@castledragmire.com>.
Guenther
(cherry picked from commit
2b1fe2c98f4e0013dee4cbae62dc36cdd4085c7d)
Volker Lendecke [Sat, 28 Mar 2009 18:58:45 +0000 (19:58 +0100)]
Fix smbd crash for close_on_completion
handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
Volker Lendecke [Fri, 3 Apr 2009 21:24:02 +0000 (14:24 -0700)]
Use cluster-aware procid_is_me instead of comparing pid's
Volker Lendecke [Fri, 3 Apr 2009 21:03:43 +0000 (14:03 -0700)]
Use procid_str in debug messages for better cluster-debuggability
Günther Deschner [Fri, 3 Apr 2009 10:50:50 +0000 (12:50 +0200)]
s3-nsswitch: Fix Bug #6238 2nd part. zero blob pointer in wbcLogoffUserParams.
Patch from Rashid N. Achilov <citycat4@ngs.ru>.
Guenther
(cherry picked from commit
43372b27403f617897bab564c42eead4d64532e4)
Günther Deschner [Fri, 3 Apr 2009 10:06:40 +0000 (12:06 +0200)]
s3-samr: try to to fix password_expired flag handling.
Guenther
Günther Deschner [Fri, 3 Apr 2009 07:57:53 +0000 (09:57 +0200)]
s3-nsswitch: Fix Bug #6238. Make sure wbcLogoffUserParams are properly initialized before freed.
Fix inspired by patch from Rashid N. Achilov <citycat4@ngs.ru>.
Guenther
(cherry picked from commit
09265bcff5a2fac42f5abf34b8b439aa0a6998a1)
Volker Lendecke [Thu, 2 Apr 2009 19:23:18 +0000 (21:23 +0200)]
Bug #6243. Fix usrmgr.exe creating a user.
Signed-off-by: Günther Deschner <gd@samba.org>
Jeremy Allison [Thu, 2 Apr 2009 03:14:35 +0000 (20:14 -0700)]
Allow pdbedit to change a user rid/sid. Based on a fix from Alexander
Zagrebin <alexz@visp.ru>.
Jeremy.
Michael Adam [Wed, 1 Apr 2009 22:23:31 +0000 (00:23 +0200)]
s3:net conf: don't store share names as lower case, but as given.
Michael
Karolin Seeger [Wed, 1 Apr 2009 11:47:56 +0000 (13:47 +0200)]
WHATSNEW: Update changes.
Karolin
Michael Adam [Wed, 1 Apr 2009 10:23:07 +0000 (12:23 +0200)]
s3: fix the fix for bug #6195 - dont let smbd child processes panic
This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...
Michael
Karolin Seeger [Wed, 1 Apr 2009 06:50:03 +0000 (08:50 +0200)]
VERSION: Raise version number up to 3.3.3.
Karolin
Karolin Seeger [Wed, 1 Apr 2009 06:47:34 +0000 (08:47 +0200)]
WHATSNEW: Update changes since 3.3.2.
Karolin
Jeremy Allison [Wed, 1 Apr 2009 01:29:30 +0000 (18:29 -0700)]
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy.
Michael Adam [Tue, 31 Mar 2009 14:44:19 +0000 (16:44 +0200)]
s3:build: fix build of pam_winbind.so with static linking
Static talloc libs were missing since conversion to talloc.
Michael
Jeremy Allison [Mon, 30 Mar 2009 22:09:10 +0000 (15:09 -0700)]
Ensure files starting with multiple dots are hidden
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
Jeremy Allison [Sat, 28 Mar 2009 04:28:01 +0000 (21:28 -0700)]
Fix the problem of 3.0.x passdb databases being version
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
Derrell Lipman [Fri, 27 Mar 2009 22:03:36 +0000 (18:03 -0400)]
Merge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into v3-3-test
Derrell Lipman [Fri, 27 Mar 2009 20:56:33 +0000 (16:56 -0400)]
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
Fixed.
It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g. EHOSTUNREACH.
Derrell
Jeremy Allison [Fri, 27 Mar 2009 19:11:24 +0000 (12:11 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
Karolin Seeger [Fri, 27 Mar 2009 14:01:04 +0000 (15:01 +0100)]
WHATSNEW: Update changes since 3.3.2.
Karolin
Jeremy Allison [Thu, 26 Mar 2009 22:33:39 +0000 (15:33 -0700)]
Try and fix the build farm RAW-STREAMS errors. Ordering of
modules shouldn't matter, so as vfs_streams_depot doesn't
implement get/setxattrs then call into the full VFS stack
at the top.
Jeremy
Jeremy Allison [Thu, 26 Mar 2009 19:13:28 +0000 (12:13 -0700)]
Fix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run elections
Fix logic bug that causes nmbd to wait 5 minutes before
looking for a master browser. This one is *old* :-). Thanks
for Simo for bugging me on this.
Jeremy.
Tim Prouty [Thu, 26 Mar 2009 18:28:37 +0000 (11:28 -0700)]
s3: parse_packet can return NULL which is then dereferenced in match_mailslot_name
Volker Lendecke [Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)]
Fix a scary "fill_share_mode_lock failed" message
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.
Change the corresponding debug message to level 10 and explain more.
Günther Deschner [Thu, 26 Mar 2009 09:35:55 +0000 (10:35 +0100)]
s3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong information.
Guenther
Volker Lendecke [Thu, 26 Mar 2009 09:13:50 +0000 (10:13 +0100)]
Avahi disables a timer by tv=NULL in avahi_timeout_update(), do not crash
Günther Deschner [Wed, 25 Mar 2009 14:58:20 +0000 (15:58 +0100)]
s3-libnet: Fix Bug #6193: avoid messing with sync_context in libnet_samsync_delta().
We absolutely need to avoid messing with the sync_context as that breaks the
stream of replication data coming from the DC (only replicates ~350 instead of
~4000 groups).
Guenther
(cherry picked from commit
e3f7057b0942793543c215ab45176c4280bd7d51)
Volker Lendecke [Tue, 24 Mar 2009 22:25:56 +0000 (15:25 -0700)]
Fix two memleaks in the encryption code
ntlmssp_seal_packet creates its own signature data blob, which we then
have to free.
Jeremy, please check and merge appropriately (Yes, I'm asking you to do the
janitor work, I want you to *look* at this :-))
Volker
Stefan Metzmacher [Tue, 24 Mar 2009 19:36:10 +0000 (12:36 -0700)]
s3:smbd: if we allow trans2 on the IPC$ share, then we have to allow transs2 too.
Otherwise we'll confuse the client signing engine, when we reply an error to each transs2.
metze
Volker Lendecke [Tue, 24 Mar 2009 10:07:16 +0000 (11:07 +0100)]
Fix bug 6097
A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.
Thanks to Pavel <wylda@volny.cz> for the bug report!
Björn Jacke [Mon, 23 Mar 2009 11:26:03 +0000 (12:26 +0100)]
s3:dsgetdcname: use parentheses in if condition to make negation clear
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
87b428e424e2e3cca975ecd0efed327e72950a1d)
Volker Lendecke [Sun, 22 Mar 2009 14:59:33 +0000 (15:59 +0100)]
Use avahi to register _smb._tcp in smbd
Volker Lendecke [Fri, 20 Mar 2009 13:55:05 +0000 (14:55 +0100)]
Add event avahi binding