ddiss/samba.git
12 years agos3-printing: skip migration of non-existent printers
David Disseldorp [Wed, 15 Jun 2011 12:59:49 +0000 (14:59 +0200)]
s3-printing: skip migration of non-existent printers

Skip tdb migration of printer and security descriptor entries which
refer to non-existent printers.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 10:54:23 CEST 2011 on sn-devel-104
(cherry picked from commit c9e3f6ab02bdc354a9b656f62744ee66fe9e9e67)

12 years agos3-printing: fill devicemode size in migrate_printer()
David Disseldorp [Wed, 15 Jun 2011 10:46:55 +0000 (12:46 +0200)]
s3-printing: fill devicemode size in migrate_printer()

Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit a36ce0735ff6cad8124bd63a056a71d9495b238c)

12 years agos3-waf: stop building smbtortre4.
Günther Deschner [Thu, 12 May 2011 12:33:15 +0000 (14:33 +0200)]
s3-waf: stop building smbtortre4.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 15:35:02 CEST 2011 on sn-devel-104
(cherry picked from commit c1ac023b588e1ca676cbbf542ca6f93aa199ad32)

12 years agoWHATSNEW: Add changes since rc2.
Karolin Seeger [Tue, 5 Jul 2011 18:39:53 +0000 (20:39 +0200)]
WHATSNEW: Add changes since rc2.

Karolin

12 years agos3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)
Christian Ambach [Mon, 4 Jul 2011 15:55:54 +0000 (17:55 +0200)]
s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)

when smbd tries to clean up locks after a premature end of a smb2
connection, lock_db has already been freed and so it crashes

this patch changes the order in which items are freed so that
lock_db is still around when it is needed

12 years agos3:nmbd_subnetdb: close all sockets attached to a subnet in close_subnet() (bug ...
Stefan Metzmacher [Thu, 30 Jun 2011 08:09:56 +0000 (10:09 +0200)]
s3:nmbd_subnetdb: close all sockets attached to a subnet in close_subnet() (bug #8276)

metze
(cherry picked from commit 75e9f2110876137a57632d223248ac51dbfc4569)

12 years agos3:smbldap: make smbldap_connect_system self contained
Gregor Beck [Tue, 21 Jun 2011 06:16:56 +0000 (08:16 +0200)]
s3:smbldap: make smbldap_connect_system self contained

The last patches address bug #8253 (winbindd panics if verify_idpool() fails).

12 years agos3:smbldap: add a destructor to smbldap_state, just in case
Gregor Beck [Tue, 21 Jun 2011 06:06:28 +0000 (08:06 +0200)]
s3:smbldap: add a destructor to smbldap_state, just in case

12 years agos3:smbldap: let smbldap_free_struct do what it claims to
Gregor Beck [Tue, 21 Jun 2011 06:02:53 +0000 (08:02 +0200)]
s3:smbldap: let smbldap_free_struct do what it claims to

12 years agos3:smbldap: free the idle event scheduled in smbldap_open in smbldap_close
Gregor Beck [Tue, 21 Jun 2011 06:00:59 +0000 (08:00 +0200)]
s3:smbldap: free the idle event scheduled in smbldap_open in smbldap_close

12 years agos3:smbldap: use smbldap_state as memory context for idle event
Gregor Beck [Tue, 21 Jun 2011 05:51:41 +0000 (07:51 +0200)]
s3:smbldap: use smbldap_state as memory context for idle event

ensure the event is canceled if the smbldap_state gets freed
this fixes a panic of winbindd if verify_idpool fails

12 years agos3:smbd do not panic when CTDB is unhealthy (Bug #8278)
Christian Ambach [Wed, 29 Jun 2011 13:01:16 +0000 (15:01 +0200)]
s3:smbd do not panic when CTDB is unhealthy (Bug #8278)

when CTDB is unhealthy, log a message and exit cleanly
instead of creating a core file

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Jun 30 13:18:12 CEST 2011 on sn-devel-104
(cherry picked from commit 847ca0a5d791d881be8d9a0721bf30399c80013b)

12 years agos3:build: add vfs_examples to the everything target
Michael Adam [Thu, 30 Jun 2011 13:15:22 +0000 (15:15 +0200)]
s3:build: add vfs_examples to the everything target

So that one can not pass autobuild without keeping the vfs examples intact.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Jun 30 16:52:48 CEST 2011 on sn-devel-104

The last 5 patches address bug #8281 (examples/VFS/* does not build).

12 years agos3:build: add a vfs_examples target.
Michael Adam [Thu, 30 Jun 2011 11:54:52 +0000 (13:54 +0200)]
s3:build: add a vfs_examples target.

12 years agoexamples/VFS: fix skel_transparent.c in reference to shadow_copy changes
Björn Baumbach [Wed, 29 Jun 2011 14:57:27 +0000 (16:57 +0200)]
examples/VFS: fix skel_transparent.c in reference to shadow_copy changes

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agoexamples/VFS: fix skel_opaque.c in reference to shadow_copy changes
Björn Baumbach [Wed, 29 Jun 2011 14:56:45 +0000 (16:56 +0200)]
examples/VFS: fix skel_opaque.c in reference to shadow_copy changes

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agoexamples/VFS: fix shadow_copy_test.c in reference to shadow_copy changes
Björn Baumbach [Wed, 29 Jun 2011 14:53:57 +0000 (16:53 +0200)]
examples/VFS: fix shadow_copy_test.c in reference to shadow_copy changes

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3-winbind: Fix bug 7888 -- deal with buggy 3.0 based PDCs
Günther Deschner [Tue, 28 Jun 2011 21:59:11 +0000 (23:59 +0200)]
s3-winbind: Fix bug 7888 -- deal with buggy 3.0 based PDCs

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 00:42:23 CEST 2011 on sn-devel-104

12 years agoSecond part of fix for bug #8219 - SMB Panic from Windows 7 Client.
Jeremy Allison [Wed, 29 Jun 2011 16:56:47 +0000 (09:56 -0700)]
Second part of fix for bug #8219 - SMB Panic from Windows 7 Client.

Pass in the correct vector to the signing algorithm in an async
response - we must start with vector[1] which has the SMB2_HDR_BODY
length, not vector[0] which is the 4 byte packet length. Also
note we're passing in 2 vectors not 3.

Metze please review.

12 years agoFix bug #8219 - SMB Panic from Windows 7 Client
Jeremy Allison [Wed, 29 Jun 2011 00:45:49 +0000 (17:45 -0700)]
Fix bug #8219 - SMB Panic from Windows 7 Client

Caused by referencing an uninitialized variable in the
duplicated struct smbd_smb2_request when sending a signed
intermediate reply.

12 years agos3: explicitly pass domain_sid to wbint_LookupRids() (bug #7841)
Volker Lendecke [Mon, 27 Jun 2011 12:34:39 +0000 (14:34 +0200)]
s3: explicitly pass domain_sid to wbint_LookupRids() (bug #7841)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jun 27 18:21:30 CEST 2011 on sn-devel-104
(cherry picked from commit 0a74caa473f491050bc5f64b6d6956c00088c5cd)

12 years agos3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()
Stefan Metzmacher [Thu, 16 Jun 2011 10:47:22 +0000 (12:47 +0200)]
s3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()

r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it, even if it's smaller than the offered buffer size.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 14:15:47 CEST 2011 on sn-devel-104
(cherry picked from commit 67512152c007bb186e4fd8dac5d1aab89bce0689)

The last 3 patches address bug #8264 (svcctl valgrind fixes).

12 years agos3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()
Stefan Metzmacher [Thu, 16 Jun 2011 10:34:42 +0000 (12:34 +0200)]
s3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()

r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it.

If we always marshall the return buffer, we already have the needed
buffer size and don't need to call ndr_size_* functions.

metze
(cherry picked from commit 11683ccf3e68606ecb1cdfa455f7921b119803c6)

12 years agos3:rpc_server/svcctl: don't allocate return values on a temporary stackframe
Stefan Metzmacher [Thu, 16 Jun 2011 06:33:09 +0000 (08:33 +0200)]
s3:rpc_server/svcctl: don't allocate return values on a temporary stackframe

And always initialize the whole return structure.

This caused samba3.posix_s3.rpc.svcctl to be flakey.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104
(cherry picked from commit 48de3e51eacbd1051f79dc99aaac8a4ec988fde5)

12 years agoFix bug #8254 - "acl check permissions = no" does not work in all cases
Jeremy Allison [Thu, 23 Jun 2011 22:06:16 +0000 (15:06 -0700)]
Fix bug #8254 - "acl check permissions = no" does not work in all cases

Move lp_acl_check_permissions() into can_delete_file_in_directory()
where it makes sense. Remove ACL check when requesting DELETE_ACCESS
when lp_acl_check_permissions is false.

Thanks to John Janosik @ IBM for noticing this.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jun 24 01:18:11 CEST 2011 on sn-devel-104

12 years agos3:test: don't rely on pyhton being in /usr/bin/python in the sids2xids test
Michael Adam [Fri, 24 Jun 2011 14:40:17 +0000 (16:40 +0200)]
s3:test: don't rely on pyhton being in /usr/bin/python in the sids2xids test

"/usr/bin/env pyhton" should always work as long as pyhton is in the path.

12 years agos3:test: fix the smbclient_s3 test on older systems
Michael Adam [Fri, 24 Jun 2011 14:38:07 +0000 (16:38 +0200)]
s3:test: fix the smbclient_s3 test on older systems

mktemp requires precisely six Xs at the end of the template name

12 years agos3:test: fix the net registry roundtrip test on older systems
Michael Adam [Fri, 24 Jun 2011 14:37:20 +0000 (16:37 +0200)]
s3:test: fix the net registry roundtrip test on older systems

mktemp requires exactly Xs at the end of the template name on SLES8

12 years agos3-autconf Move nmbd socket directory to PREFIX/var/nmbd
Andrew Bartlett [Tue, 14 Jun 2011 05:00:32 +0000 (15:00 +1000)]
s3-autconf Move nmbd socket directory to PREFIX/var/nmbd

This is consistent with the new ncalrpc socket directory, also added
in this release.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
The last 2 patches address bug #8230 (Move .nmbd socket directory to non-hidden
name PREFIX/var/nmbd).

12 years agos3-buildoptions Show compiled-in location of the new ncaclrpc and nmbd sockets
Andrew Bartlett [Tue, 14 Jun 2011 04:56:30 +0000 (14:56 +1000)]
s3-buildoptions Show compiled-in location of the new ncaclrpc and nmbd sockets

12 years agos3:docs: fix the example in the idmap_autorid manpage to use "idmap config * : rangesize"
Michael Adam [Tue, 7 Jun 2011 13:21:34 +0000 (15:21 +0200)]
s3:docs: fix the example in the idmap_autorid manpage to use "idmap config * : rangesize"

12 years agos3:vfs_commit: fix build
Björn Jacke [Fri, 24 Jun 2011 11:37:16 +0000 (13:37 +0200)]
s3:vfs_commit: fix build

fix build

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Fri Jun 24 14:51:31 CEST 2011 on sn-devel-104
(cherry picked from commit d4ea319e7ad9ee2fc2fad0c016845f820681569a)

Fix bug #8262 (vfs_commit doesn't compile).

12 years agos3:smb2_ioctl/FSCTL_PIPE_TRANSCEIVE: generate STATUS_BUFFER_OVERFLOW if needed (bug...
Stefan Metzmacher [Fri, 24 Jun 2011 06:54:02 +0000 (08:54 +0200)]
s3:smb2_ioctl/FSCTL_PIPE_TRANSCEIVE: generate STATUS_BUFFER_OVERFLOW if needed (bug #8260)

This should fix DCERPC responses with fragments larger than 1024 bytes.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jun 24 11:25:36 CEST 2011 on sn-devel-104
(cherry picked from commit 2bb325ad913c1cff88faab55102cef75d14c04a6)

12 years agos3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share
Christian Ambach [Fri, 17 Jun 2011 19:54:30 +0000 (21:54 +0200)]
s3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share

the time_audit module uses int instead of uint64 as return value
in get_alloc_size so that sizes of files larger than 2 GB are
cut of leading to wrong replies to NtCreateAndX and Windows
clients giving up

While checking the types of all functions, I found two more wrong
return value types that needed correction

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Jun 17 23:11:10 CEST 2011 on sn-devel-104
(cherry picked from commit bb66504dadf56366ea30697ae73673de3df08132)

12 years agos3: Fix Coverity ID 2582: FORWARD_NULL
Volker Lendecke [Sun, 19 Jun 2011 17:23:47 +0000 (19:23 +0200)]
s3: Fix Coverity ID 2582: FORWARD_NULL

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 20:46:43 CEST 2011 on sn-devel-104
(cherry picked from commit 5290faca7a5ae5f3f0309a42586768a5c93bfb9d)

Fix bug #8247 (SMB2 shadow copy can be crashed remotely).

12 years agos3-spoolss: Fix some valgrind warnings.
Andreas Schneider [Mon, 20 Jun 2011 17:27:01 +0000 (19:27 +0200)]
s3-spoolss: Fix some valgrind warnings.

These are in/out values and need to be initialized.

The last 2 patches address bug #8240 (valgrind warnings in winreg/spoolss
code).

12 years agos3-rpc_client: Fix some valgrind warnings.
Andreas Schneider [Mon, 20 Jun 2011 13:39:36 +0000 (15:39 +0200)]
s3-rpc_client: Fix some valgrind warnings.

These are in/out values and need to be initialized.

12 years agos3:idmap_autorid: remove redundant code
Michael Adam [Thu, 9 Jun 2011 22:50:42 +0000 (00:50 +0200)]
s3:idmap_autorid: remove redundant code

The last 4 patches address bug #8213 (Fixes in idmap_autorid).

12 years agos3:idmap_autorid: in initialize, don't leak storedconfig to talloc_tos() in the succe...
Michael Adam [Thu, 9 Jun 2011 22:49:37 +0000 (00:49 +0200)]
s3:idmap_autorid: in initialize, don't leak storedconfig to talloc_tos() in the success case

12 years agos3:idmap_autorid: use "idmap config * : rangesize" instead of "autorid : rangesize"
Michael Adam [Thu, 9 Jun 2011 22:46:19 +0000 (00:46 +0200)]
s3:idmap_autorid: use "idmap config * : rangesize" instead of "autorid : rangesize"

12 years agos3:idmap_autorid: fail initialization if the domain is not "*"
Michael Adam [Tue, 7 Jun 2011 13:53:49 +0000 (15:53 +0200)]
s3:idmap_autorid: fail initialization if the domain is not "*"

autorid can only be used as a backend for the default idmap configuration.

12 years agos3:net-man: registry enumerate_recursive
Gregor Beck [Tue, 31 May 2011 16:26:12 +0000 (18:26 +0200)]
s3:net-man: registry enumerate_recursive

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jun  1 17:16:05 CEST 2011 on sn-devel-104

12 years agos3:net-man: registry deletekey & deletekey_recursive
Gregor Beck [Tue, 31 May 2011 16:25:53 +0000 (18:25 +0200)]
s3:net-man: registry deletekey & deletekey_recursive

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:net-man: missing dot
Gregor Beck [Tue, 31 May 2011 16:15:38 +0000 (18:15 +0200)]
s3:net-man: missing dot

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:net registry: polish output of net registry enumerate[_recursive]
Michael Adam [Mon, 30 May 2011 14:54:47 +0000 (16:54 +0200)]
s3:net registry: polish output of net registry enumerate[_recursive]

so that net registry enumerate output is as before, and
net registry enumerate_recursive is formatted more nicely
(cherry picked from commit 0d746f653e76de52985d543a15fd6ee3bf2f4823)

Fix bug: #8193

12 years agos3:net: registry: use recursive implementation for enumerate
Gregor Beck [Mon, 30 May 2011 08:24:16 +0000 (10:24 +0200)]
s3:net: registry: use recursive implementation for enumerate

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 5ec479fa0c9db4072541d46345164542d037cfc9)

Fix bug: #8193

12 years agos3:net: registry: add new command enumerate_recursive
Gregor Beck [Mon, 30 May 2011 06:58:34 +0000 (08:58 +0200)]
s3:net: registry: add new command enumerate_recursive

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 22011ddc9e72c8a201e3ca6e01745a68738d5916)

Fix bug: #8193

12 years agos3: improve WHATSNEW around kerberos changes
Andrew Bartlett [Tue, 14 Jun 2011 11:51:36 +0000 (21:51 +1000)]
s3: improve WHATSNEW around kerberos changes

12 years agos3:wb_lookupsids: add some paranoia checks to wb_lookupsids_recv()
Stefan Metzmacher [Thu, 16 Jun 2011 16:25:15 +0000 (18:25 +0200)]
s3:wb_lookupsids: add some paranoia checks to wb_lookupsids_recv()

This hopefully catches future bugs.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 19:50:16 CEST 2011 on sn-devel-104
(cherry picked from commit 5961852d9c0e5cf64cea988586d610af9d63d487)

12 years agos3:wb_lookupsids: don't ignore 'result' and check if we got useable values
Stefan Metzmacher [Thu, 16 Jun 2011 16:16:15 +0000 (18:16 +0200)]
s3:wb_lookupsids: don't ignore 'result' and check if we got useable values

The wrong fix for bug #8215 discovered this bug, as it caused
sam_rids_to_names() to always return NT_STATUS_NONE_MAPPED.

metze
(cherry picked from commit 85809ccbe3a79f307af1fdd227f33b899d8db1b4)

12 years agoRevert "s3-winbind: Fix paranoia checks in winbindd_samr.c."
Stefan Metzmacher [Thu, 16 Jun 2011 16:40:04 +0000 (18:40 +0200)]
Revert "s3-winbind: Fix paranoia checks in winbindd_samr.c."

This reverts commit 207a84d725b905c2b119d2ef0f4f4d4eb391140d.

This is the wrong fix for the problem, see bug #8215.

metze
(cherry picked from commit 283f8a7fb5089a7126f07e26315fd06ab59997d8)

12 years agos3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95...
Stefan Metzmacher [Wed, 15 Jun 2011 00:34:53 +0000 (02:34 +0200)]
s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226)

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jun 15 03:48:41 CEST 2011 on sn-devel-104
(cherry picked from commit 5d736d87778754de7043d902c7d1d5db1c46cb02)

12 years agos3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit
Stefan Metzmacher [Wed, 8 Jun 2011 17:01:13 +0000 (19:01 +0200)]
s3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit

This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.

metze
(cherry picked from commit f0ba1afe5f7dbafaf22c3028864de0f3910f675f)

The last 14 patches address the generic part of bug #8195
(rpc client code doesn't work against NT4, when we need to fragment requests).

12 years agos3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit
Stefan Metzmacher [Wed, 8 Jun 2011 16:59:39 +0000 (18:59 +0200)]
s3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit

This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.

metze
(cherry picked from commit 73128b7cc7f536f80072a19cb69527c53d9a6c2f)

12 years agos3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests
Stefan Metzmacher [Thu, 9 Jun 2011 09:57:55 +0000 (11:57 +0200)]
s3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests

This is needed to implement SMB signing correct.

metze
(cherry picked from commit 5d06b2197b5fd95aaf0394d1bdba957bac6c3570)

12 years agos3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls
Stefan Metzmacher [Wed, 8 Jun 2011 08:31:23 +0000 (10:31 +0200)]
s3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls

We now keep the primary request open for the whole logical request.
The primary request is the one that gets all incoming replies.
While secondary requests are handled as separate one-way requests.

metze
(cherry picked from commit 1dd24ac06a7472f53b06bc0aaa54cb22c8da0f78)

12 years agos3:libsmb/clitrans: use subreq2 as variable for the secondary requests
Stefan Metzmacher [Wed, 8 Jun 2011 14:41:11 +0000 (16:41 +0200)]
s3:libsmb/clitrans: use subreq2 as variable for the secondary requests

metze
(cherry picked from commit 10bb088cf1e005fd047c09afcf6b5b8999d416fe)

12 years agos3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment
Stefan Metzmacher [Wed, 8 Jun 2011 14:11:00 +0000 (16:11 +0200)]
s3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment

metze
(cherry picked from commit 5146c9ba9df063d6611abe356f9262adb027b091)

12 years agos3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests
Stefan Metzmacher [Tue, 7 Jun 2011 22:44:34 +0000 (00:44 +0200)]
s3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests

We need to align params and data to 4 byte offsets.

This also correctly recalculates the useable space after each step.

metze
(cherry picked from commit 0a8fd50bd806e925a915c74cb86733481b2144f6)

12 years agos3:libsmb/clitrans: marshall SMBnttrans[2] as the others
Stefan Metzmacher [Thu, 9 Jun 2011 10:22:59 +0000 (12:22 +0200)]
s3:libsmb/clitrans: marshall SMBnttrans[2] as the others

This is just to make the code more readable
and easier to notice how many words we're using in vwv.

metze
(cherry picked from commit 6f7af1b0388d30c8a06c495713066b90ded00780)

12 years agos3:libsmb/clitrans: use uint32_t for param and data variables
Stefan Metzmacher [Wed, 8 Jun 2011 15:08:00 +0000 (17:08 +0200)]
s3:libsmb/clitrans: use uint32_t for param and data variables

SMBnttrans uses 32-bit values there.

metze
(cherry picked from commit 428a86c92b5b35e28c7d6921f2999616cdc1bc20)

12 years agos3:libsmb/clitrans: remove unused secondary_request_ctx
Stefan Metzmacher [Tue, 7 Jun 2011 22:37:24 +0000 (00:37 +0200)]
s3:libsmb/clitrans: remove unused secondary_request_ctx

metze
(cherry picked from commit 2ae565b681a6307886b888ee5b576c12916eb0db)

12 years agos3:libsmb/async_smb: add helpers to get and set the seqnum for signing
Stefan Metzmacher [Thu, 9 Jun 2011 09:49:48 +0000 (11:49 +0200)]
s3:libsmb/async_smb: add helpers to get and set the seqnum for signing

This will be used for correct signing in [nt]trans[2][s] requests.

metze
(cherry picked from commit 3dd1ebd21ee99d130f6dd30326ddafe3f00a50d0)

12 years agos3:libsmb/async_smb: don't remove pending requests if the mid is set
Stefan Metzmacher [Wed, 8 Jun 2011 08:20:25 +0000 (10:20 +0200)]
s3:libsmb/async_smb: don't remove pending requests if the mid is set

If the mid was set explicitly, it means the request expects more than
one reply, so leave it in the pending array.

metze
(cherry picked from commit a25936f1b1300a76b08a6bd435bd7ccc388279d5)

12 years agos3:libsmb/async_smb: call cli_smb_req_unset_pending() instead of destructor directly
Stefan Metzmacher [Wed, 8 Jun 2011 12:14:24 +0000 (14:14 +0200)]
s3:libsmb/async_smb: call cli_smb_req_unset_pending() instead of destructor directly

metze
(cherry picked from commit 173fc258e443d97e4ea37f2bee99c21ad15ab484)

12 years agos3:libsmb/async_smb: let cli_smb_recv() initialize output values for one way requests
Stefan Metzmacher [Tue, 7 Jun 2011 22:40:54 +0000 (00:40 +0200)]
s3:libsmb/async_smb: let cli_smb_recv() initialize output values for one way requests

metze
(cherry picked from commit 49cdf171a5198495aead9ace43963e805331e20b)

12 years agos3:libsmb/cli_np_tstream: s/TSTREAM_CLI_NP_BUF_SIZE/TSTREAM_CLI_NP_MAX_BUF_SIZE
Stefan Metzmacher [Tue, 7 Jun 2011 16:49:55 +0000 (18:49 +0200)]
s3:libsmb/cli_np_tstream: s/TSTREAM_CLI_NP_BUF_SIZE/TSTREAM_CLI_NP_MAX_BUF_SIZE

This isn't the fixed buffer size anymore, as we use dynamic beffer
it's just the maximum size.

metze
(cherry picked from commit 957cfd23e1781e342edde07fc01dbec279088afa)

The last 3 patches address bug #8195 (rpc client code doesn't work against NT4,
when we need to fragment requests).

12 years agos3:libsmb:cli_np_tstream: use dynamic talloc buffers
Stefan Metzmacher [Tue, 7 Jun 2011 16:45:54 +0000 (18:45 +0200)]
s3:libsmb:cli_np_tstream: use dynamic talloc buffers

Having 8192 bytes on an idle connection is a bit to much,
so we better use dynamic buffers using talloc, which also
avoids a memcpy in the common SMBtrans readv codepath.

metze
(cherry picked from commit ad1cf187fdbcd726c6c74085308784fe4ecca883)

12 years agos3:libsmb/cli_np_tstream: use larger buffers to avoid a bug NT4 servers (bug #8195)
Stefan Metzmacher [Tue, 7 Jun 2011 16:27:41 +0000 (18:27 +0200)]
s3:libsmb/cli_np_tstream: use larger buffers to avoid a bug NT4 servers (bug #8195)

NT4 servers return NT_STATUS_PIPE_BUSY if we try a SMBtrans
and the SMBwriteX before hasn't transmited the whole DCERPC fragment.

W2K and above is happy with that.

As a result we try to match the behavior of Windows and older Samba clients,
they use write and read buffers of 4280 bytes instead of 1024 bytes.
On Windows only the SMBtrans based read uses 1024 (while we also use 4280
there).

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jun  7 20:25:32 CEST 2011 on sn-devel-104
(cherry picked from commit c3ac298a1fe4f5cada6d09376e2d4a3df271a093)

12 years agos3:librpc/ndr/util.h: add license/copyright header and inclusion guard
Michael Adam [Sun, 12 Jun 2011 22:07:29 +0000 (00:07 +0200)]
s3:librpc/ndr/util.h: add license/copyright header and inclusion guard

The last patches fix bug #8196 (Many (newer) header files don't have copyright /
GPL header comments).

12 years agos3:registry/reg_parse_internal.c: add copyright information
Michael Adam [Fri, 10 Jun 2011 22:20:57 +0000 (00:20 +0200)]
s3:registry/reg_parse_internal.c: add copyright information

12 years agos3:registry/reg_parse_internal.h: add copyright information
Michael Adam [Fri, 10 Jun 2011 22:20:32 +0000 (00:20 +0200)]
s3:registry/reg_parse_internal.h: add copyright information

12 years agosource3/rpc_client/util_netlogon.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:08:17 +0000 (15:08 +0200)]
source3/rpc_client/util_netlogon.h: fix licence/copyright

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jun 10 16:27:24 CEST 2011 on sn-devel-104
(cherry picked from commit cd16a1be9371448532be7362d3e5d3f2a1ae3df3)

12 years agosource3/rpc_client/init_spoolss.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:08:07 +0000 (15:08 +0200)]
source3/rpc_client/init_spoolss.h: fix licence/copyright

Guenther
(cherry picked from commit 4942aeb9b562f3621cbe6adc8e79366887f0d4b9)

12 years agosource3/rpc_client/init_samr.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:57 +0000 (15:07 +0200)]
source3/rpc_client/init_samr.h: fix licence/copyright

Guenther
(cherry picked from commit 054e54e881eeab18387ae6e94cf04ecf205ebe64)

12 years agosource3/rpc_client/init_netlogon.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:48 +0000 (15:07 +0200)]
source3/rpc_client/init_netlogon.h: fix licence/copyright

Guenther
(cherry picked from commit f3ca8ff2bfb61cfa4b9ce2e4be93653f7b309351)

12 years agosource3/rpc_client/init_lsa.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:39 +0000 (15:07 +0200)]
source3/rpc_client/init_lsa.h: fix licence/copyright

Guenther
(cherry picked from commit 9284036ce17b569c1f2203362eacd99ebc362af6)

12 years agosource3/rpc_client/cli_spoolss.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:27 +0000 (15:07 +0200)]
source3/rpc_client/cli_spoolss.h: fix licence/copyright

Guenther
(cherry picked from commit b95b1813b9ab53b9490d8b37af4f6ced7fea7bdb)

12 years agosource3/rpc_client/cli_netlogon.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:16 +0000 (15:07 +0200)]
source3/rpc_client/cli_netlogon.h: fix licence/copyright

Guenther
(cherry picked from commit 2d10c48259ec234ae110c60405a9da5e720302cb)

12 years agosource3/printing/pcap.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:03 +0000 (15:07 +0200)]
source3/printing/pcap.h: fix licence/copyright

Guenther
(cherry picked from commit ef5bcb6e23093086e1450833745b7e5b7b5d46ee)

12 years agosource3/printing/load.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:06:49 +0000 (15:06 +0200)]
source3/printing/load.h: fix licence/copyright

Guenther
(cherry picked from commit 942b2d5baf4347c796d823ad72754c302b38cdca)

12 years agosource3/libsmb/proto.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:06:36 +0000 (15:06 +0200)]
source3/libsmb/proto.h: fix licence/copyright

Guenther
(cherry picked from commit ed10726abca2194d21ea5174c2ff2cda79db499e)

12 years agosource3/libsmb/nmblib.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:06:27 +0000 (15:06 +0200)]
source3/libsmb/nmblib.h: fix licence/copyright

Guenther
(cherry picked from commit 005930411ccbb2793023d2a4d29bdb536d822aba)

12 years agosource3/libsmb/libsmb.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:06:17 +0000 (15:06 +0200)]
source3/libsmb/libsmb.h: fix licence/copyright

Guenther
(cherry picked from commit 81b5d8538a00181af814e98af83718ef5f413868)

12 years agosource3/libsmb/errormap_wbc.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:06:07 +0000 (15:06 +0200)]
source3/libsmb/errormap_wbc.h: fix licence/copyright

Guenther
(cherry picked from commit c1058ad47607c089ba630b21df1f6b72a24a861c)

12 years agosource3/libsmb/clidgram.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:05:57 +0000 (15:05 +0200)]
source3/libsmb/clidgram.h: fix licence/copyright

Guenther
(cherry picked from commit 1e9f2bdb2f7f9e809dd3044dc94018e0b5b6e8d3)

12 years agosource3/libnet/libnet_join.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:05:47 +0000 (15:05 +0200)]
source3/libnet/libnet_join.h: fix licence/copyright

Guenther
(cherry picked from commit 81f269211a80c17a33ec9f05c7847dd29b8c4251)

12 years agosource3/libads/ldap_schema.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:05:37 +0000 (15:05 +0200)]
source3/libads/ldap_schema.h: fix licence/copyright

Guenther
(cherry picked from commit 183835d05515b5b437bbeff5ff7685a4f08415ad)

12 years agosource3/libads/cldap.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:05:27 +0000 (15:05 +0200)]
source3/libads/cldap.h: fix licence/copyright

Guenther
(cherry picked from commit 59e878ff625989d4d2e04ea017f92d29a40f4c44)

12 years agosource3/libads/ads_status.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:05:18 +0000 (15:05 +0200)]
source3/libads/ads_status.h: fix licence/copyright

Guenther
(cherry picked from commit d5c5aa1c5fcc0e3c74cf1216cce7a8c767a6df2a)

12 years agosource3/libads/ads_ldap_protos.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:05:09 +0000 (15:05 +0200)]
source3/libads/ads_ldap_protos.h: fix licence/copyright

Guenther
(cherry picked from commit f2d4252dfa790b65031fe3221afe89d0e285ebd7)

12 years agosource3/lib/privileges.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:04:59 +0000 (15:04 +0200)]
source3/lib/privileges.h: fix licence/copyright

Guenther
(cherry picked from commit 5672d83b23e89f716300940126bef0a738aa3599)

12 years agosource3/lib/netapi/libnetapi.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:04:48 +0000 (15:04 +0200)]
source3/lib/netapi/libnetapi.h: fix licence/copyright

Guenther
(cherry picked from commit 387ddc2c295e92363c83dcd29353cdd4c56984ab)

12 years agosource3/intl/lang_tdb.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:04:36 +0000 (15:04 +0200)]
source3/intl/lang_tdb.h: fix licence/copyright

Guenther
(cherry picked from commit 3ec4966942dc468cfd6e32bf221d4427cc6aba86)

12 years agosource3/include/smb_ldap.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:04:26 +0000 (15:04 +0200)]
source3/include/smb_ldap.h: fix licence/copyright

Guenther
(cherry picked from commit e14b60c7ee6a76c444f12b8987740602c7b5f1d3)

12 years agosource3/include/smb_krb5.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:04:16 +0000 (15:04 +0200)]
source3/include/smb_krb5.h: fix licence/copyright

Guenther
(cherry picked from commit 769f8793cff7d336ab04442208039f87147388bd)

12 years agosource3/include/mangle.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:04:05 +0000 (15:04 +0200)]
source3/include/mangle.h: fix licence/copyright

Guenther
(cherry picked from commit d357b5ce2a1eeead19760ecfad8c7d2bbf9e7622)

12 years agosource3/include/krb5_protos.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:03:55 +0000 (15:03 +0200)]
source3/include/krb5_protos.h: fix licence/copyright

Guenther
(cherry picked from commit ef84a5b2aafa7c90c2aaff82006a69dec485d2ab)

12 years agosource3/include/krb5_env.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:03:43 +0000 (15:03 +0200)]
source3/include/krb5_env.h: fix licence/copyright

Guenther
(cherry picked from commit 0d7581b22b76774a1ef58a7eeb71df9c5bd69943)

12 years agonsswitch/winbind_client.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:03:31 +0000 (15:03 +0200)]
nsswitch/winbind_client.h: fix licence/copyright

Guenther
(cherry picked from commit 850460c96c6337695dae8e601d4e1aa9d676f32d)