Jeremy Allison [Fri, 6 Nov 2009 22:08:09 +0000 (14:08 -0800)]
Fix bug 6875 - trans2 FIND_FIRST2 response --> FIND_FIRST2 Data -> Fille Attributes are returned as 0x220 for LANMAN2.1 dialect Jeremy.
Matt Kraai [Wed, 26 Aug 2009 21:50:28 +0000 (14:50 -0700)]
s3: Do not redefine strupr.
Fixes bug #6751 (Fails to compile on QNX because of conflicting types for
strupr).
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
6657598168724d4fe076f9014c2b5c16a034fe52)
Jeremy Allison [Mon, 9 Nov 2009 18:45:50 +0000 (10:45 -0800)]
Fix bug 6880 - cannot list workgroup servers reported by Alban Browaeys <prahal@yahoo.com> with fix. Revert
2e989bab0764c298a2530a2d4c8690258eba210c with extra comments - this broke workgroup enumeration. Jeremy.
Günther Deschner [Wed, 4 Nov 2009 14:58:08 +0000 (15:58 +0100)]
s3: Fix Bug #6869: Various annoying build warnings.
Guenther
Jeremy Allison [Mon, 2 Nov 2009 20:53:46 +0000 (12:53 -0800)]
Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a directory with a lot of files. Jeremy.
Karolin Seeger [Tue, 27 Oct 2009 15:29:20 +0000 (16:29 +0100)]
s3:configure: Fix typo in libtalloc check.
Fix bug #6849. Thanks to Mike Frysinger <vapier@gentoo.org> for reporting
and providing the patch!
Karolin
Karolin Seeger [Fri, 30 Oct 2009 15:47:22 +0000 (16:47 +0100)]
s3/docs: Fix typo.
Fix bug #4250. Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
Karolin
(cherry picked from commit
d1ad143a707b36b3aafcbb498554b73d2013f6e8)
(cherry picked from commit
5087e0ce311c68420c68c285fcdffc5174690621)
Karolin Seeger [Fri, 30 Oct 2009 15:31:55 +0000 (16:31 +0100)]
s3/docs: Remove reference to nonexistent file.
Fix bug #4252. Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
Karolin
(cherry picked from commit
52aa522a550de45aa28969d0a679ff4e9b6575d6)
(cherry picked from commit
f6a1bcb69aea271a7afed409530da02595064f71)
Stefan Metzmacher [Wed, 28 Oct 2009 10:21:27 +0000 (11:21 +0100)]
s3:configure: only check for gpfs_gpl.h
The header is everything we need in order to build vfs_gpfs.
metze
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
ee13e9c0becc2b4a4d3b233613d5e3e9bfb54938)
Fix bug #6856.
Karolin Seeger [Tue, 27 Oct 2009 15:04:35 +0000 (16:04 +0100)]
s3/docs: Document new pdbedit -K option.
Karolin
(cherry picked from commit
354038f170f2541318336aa72c9f2a0426c6607e)
Part of a fix for bug #6851.
Michael Adam [Mon, 26 Oct 2009 15:07:58 +0000 (16:07 +0100)]
s3: pdbedit: add option --kickoff-time/-K to set the user's kickoff time
Use "never" as argument to set this to unlimited.
Michael
(cherry picked from commit
8fdef14305ae1e32d61c80cb10859d41c5754023)
Fix bug #6851.
Karolin Seeger [Thu, 29 Oct 2009 10:50:23 +0000 (11:50 +0100)]
WHATSNEW: Start 3.4.4 release notes.
Karolin
Karolin Seeger [Thu, 29 Oct 2009 10:48:22 +0000 (11:48 +0100)]
VERSION: Raise version number up to 3.4.4.
Karolin
Karolin Seeger [Thu, 29 Oct 2009 07:48:35 +0000 (08:48 +0100)]
Revert "s3:configure: Fix typo in libtalloc check."
This reverts commit
3e90a5977e8e95dd6cd90031fcb753480c55142b.
This was pushed by accident and needs review first.
Karolin
Karolin Seeger [Thu, 29 Oct 2009 07:45:36 +0000 (08:45 +0100)]
WHATSNEW: Complete release notes.
Karolin
Karolin Seeger [Tue, 27 Oct 2009 15:29:20 +0000 (16:29 +0100)]
s3:configure: Fix typo in libtalloc check.
Fix bug #6849. Thanks to Mike Frysinger <vapier@gentoo.org> for reporting
and providing the patch!
Karolin
Karolin Seeger [Mon, 26 Oct 2009 11:02:40 +0000 (12:02 +0100)]
WHATSNEW: Update release notes.
Karolin
Karolin Seeger [Mon, 26 Oct 2009 09:14:51 +0000 (10:14 +0100)]
s3:docs: Public is not a synonym for access based shareenum.
Fix build warning.
Karolin
(cherry picked from commit
35dc481289c28a77f354dd76193d6298de32c66d)
(cherry picked from commit
7601427a2db1263b0192c1a78d8bacb7eb0b74da)
Bo Yang [Sat, 24 Oct 2009 01:20:00 +0000 (09:20 +0800)]
s3: Fix crash in pam_winbind, another reference to freed memory.
Fix bug #6840.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
b9a3f1dd85d168c15df846dba525f4f882d1acf8)
Jeremy Allison [Thu, 22 Oct 2009 22:30:47 +0000 (15:30 -0700)]
Fix bug 6829 - smbclient does not show special characters properly. All successful calls to cli_session_setup() *must* be followed by calls to cli_init_creds() to stash the credentials we successfully connected with. There were 2 codepaths where this was missing. This caused smbclient to be unable to open the \srvsvc pipe to do an RPC netserverenum, and cause it to fall back to a RAP netserverenum, which uses DOS codepage conversion rather than the full UCS2 of RPC, so the returned characters were not correct (unless the DOS codepage was set correctly). Phew. That was fun to track down :-). Includes logic simplification in libsmb_server.c Jeremy.
Jeremy Allison [Wed, 21 Oct 2009 01:10:30 +0000 (18:10 -0700)]
Fix bug 6828 - infinite timeout occurs when byte lock held outside of samba Jeremy.
Bo Yang [Wed, 14 Oct 2009 22:23:48 +0000 (06:23 +0800)]
s3: Don't fail authentication when one or some group of require-membership-of is invalid.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
31f1a36901b5b8959dc51401c09c114829b50392)
Fix bug #6826.
Karolin Seeger [Thu, 22 Oct 2009 14:22:10 +0000 (16:22 +0200)]
WHATSNEW: Update changes since 3.4.2.
Karolin
Günther Deschner [Thu, 15 Oct 2009 14:01:36 +0000 (16:01 +0200)]
s3-spnego: Fix Bug #6815. Windows 2008 R2 SPNEGO negTokenTarg parsing failure.
When parsing a SPNEGO session setup retry (falling back from KRB5 to NTLMSSP),
we failed to parse the ASN1_ENUMERATED negResult in the negTokenTarg, thus
failing spnego_parse_auth() completely.
Guenther
Günther Deschner [Thu, 15 Oct 2009 14:00:57 +0000 (16:00 +0200)]
s3-spnego: avoid NULL talloc context in read_spnego_data().
Guenther
Karolin Seeger [Mon, 19 Oct 2009 12:56:44 +0000 (14:56 +0200)]
WHATSNEW: Start release notes for Samba 3.4.3.
Karolin
Karolin Seeger [Mon, 19 Oct 2009 12:54:37 +0000 (14:54 +0200)]
VERSION: Raise version number up to 3.4.3.
Karolin
Björn Jacke [Sun, 18 Oct 2009 15:01:57 +0000 (17:01 +0200)]
s3:configure: fix avahi activation
Avahi was correctly found but not activated since
e4a26c942.
(cherry picked from commit
718d2801d6bafedfe91d7b475294d69e2d6a77a4)
Fix bug #6824.
Jeremy Allison [Mon, 19 Oct 2009 06:39:23 +0000 (08:39 +0200)]
Fix symlink calls in all vfs modules.
Additional patch to fix bug #6769.
Karolin Seeger [Fri, 16 Oct 2009 14:00:26 +0000 (16:00 +0200)]
s3:packaging: Fix building RHEL packages.
Fix bug #6721.
Thanks to Eero Volotinen <eero.volotinen@medicel.com> for providing the patch!
Karolin
(cherry picked from commit
79c2c61b99eb7c47c8bfbbb479d9d2197d1ad1fb)
(cherry picked from commit
11a6d88ea387fa50690880561f0ffffefbeb8956)
Jeff Layton [Wed, 14 Oct 2009 14:59:00 +0000 (10:59 -0400)]
cifs.upcall: do a brute-force search for KRB5 credcache
A few weeks ago, I added some code to cifs.upcall to take the pid sent
by the kernel and use that to get the value of the $KRB5CCNAME
environment var for the process. That works fine on the initial mount,
but could be problematic on reconnect.
There's no guarantee on a reconnect that the process that initiates the
upcall will have $KRB5CCNAME pointed at the correct credcache. Because
of this, the current scheme isn't going to be reliable enough and we
need to use something different.
This patch replaces that scheme with one very similar to the one used by
rpc.gssd in nfs-utils. It searches the credcache dir (currently
hardcoded to /tmp) for a valid credcache for the given uid. If it finds
one then it uses that as the credentials cache. If it finds more than
one, it uses the one with the latest TGT expiration.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Addresses bug #6810.
Jeff Layton [Wed, 14 Oct 2009 14:58:56 +0000 (10:58 -0400)]
cifs.upcall: make using ip address conditional on new option
Igor Mammedov pointed out that reverse resolving an IP address to get
the hostname portion of a principal could open a possible attack
vector. If an attacker were to gain control of DNS, then he could
redirect the mount to a server of his choosing, and fix the reverse
resolution to point to a hostname of his choosing (one where he has
the key for the corresponding cifs/ or host/ principal).
That said, we often trust DNS for other reasons and it can be useful
to do so. Make the code that allows trusting DNS to be enabled by
adding --trust-dns to the cifs.upcall invocation.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:58:48 +0000 (10:58 -0400)]
cifs.upcall: switch to getopt_long
...to allow long option names.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:58:48 +0000 (10:58 -0400)]
cifs.upcall: fix IPv6 addrs sent to upcall to have colon delimiters
Current kernels don't send IPv6 addresses with the colon delimiters, add
a routine to add them when they're not present.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:58:48 +0000 (10:58 -0400)]
cifs.upcall: use ip address passed by kernel to get server's hostname
Instead of using the hostname given by the upcall to get the server's
principal, take the IP address given in the upcall and reverse resolve
it to a hostname.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:58:47 +0000 (10:58 -0400)]
cifs.upcall: clean up flag handling
Add a new stack var to hold the flags returned by the decoder routine
so that we don't need to worry so much about preserving "rc".
With this, we can drop privs before trying to find the location of
the credcache.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:58:20 +0000 (10:58 -0400)]
cifs.upcall: try getting a "cifs/" principal and fall back to "host/"
cifs.upcall takes a "-c" flag that tells the upcall to get a principal
in the form of "cifs/hostname.example.com@REALM" instead of
"host/hostname.example.com@REALM". This has turned out to be a source of
great confusion for users.
Instead of requiring this flag, have the upcall try to get a "cifs/"
principal first. If that fails, fall back to getting a "host/"
principal.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:44:40 +0000 (10:44 -0400)]
cifs.upcall: declare a structure for holding decoded args
The argument list for the decoder is becoming rather long. Declare an
args structure and use that for holding the args. This also simplifies
pointer handling a bit.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:44:22 +0000 (10:44 -0400)]
cifs.upcall: formatting cleanup
Clean up some unneeded curly braces, and fix some indentation.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 14 Oct 2009 14:43:18 +0000 (10:43 -0400)]
cifs.upcall: clean up logging and add debug messages
Change the log levels to be more appropriate to the messages being
logged. Error messages should be LOG_ERR and not LOG_WARNING, for
instance.
Add some LOG_DEBUG messages that we can use to diagnose problems with
krb5 upcalls. With these, someone can set up syslog to log daemon.debug
and should be able to get more info when things aren't working.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Volker Lendecke [Wed, 14 Oct 2009 14:42:46 +0000 (10:42 -0400)]
Attempt to fix the build -- jlayton, please check!
Jeff Layton [Wed, 14 Oct 2009 14:42:28 +0000 (10:42 -0400)]
cifs.upcall: use pid value from kernel to determine KRB5CCNAME to use
If the kernel sends the upcall a pid of the requesting process, we can
open that process' /proc/<pid>/environ file and scrape the KRB5CCNAME
value out of it.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeremy Allison [Wed, 14 Oct 2009 18:11:26 +0000 (11:11 -0700)]
Final part of fix for bug 6793 - winbindd crash with "INTERNAL ERROR: Signal 6" Don't use mapped_user uninitialized. Jeremy.
Olaf Flebbe [Tue, 6 Oct 2009 09:09:28 +0000 (11:09 +0200)]
s3/aio: Correctly handle aio_error() and errno.
Fix bug #6805.
Bo Yang [Wed, 14 Oct 2009 19:45:16 +0000 (12:45 -0700)]
Fix bug 6811 - pam_winbind references freed memory. s3: Fix reference to freed memory in pam_winbind.
Volker Lendecke [Sat, 10 Oct 2009 09:15:42 +0000 (11:15 +0200)]
s3: Fix bug 6606
This is a port of
1f34ffa0caae5 and
24309bdb2efc to 3.4.
Fix file corruption using smbclient with NT4 server.
Volker Lendecke [Tue, 13 Oct 2009 18:56:28 +0000 (20:56 +0200)]
s3:winbind: Fix a double-free
Part of a fix for bug #6793.
Volker Lendecke [Fri, 9 Oct 2009 20:05:37 +0000 (22:05 +0200)]
s3:winbind: Fix bug 6793 -- segfault in winbindd_pam_auth
Volker Lendecke [Tue, 13 Oct 2009 13:56:00 +0000 (15:56 +0200)]
s3:net: Fix a segfault in "net rpc trustdom list" for overlong domain names
That was a complicated way to say "%-20.s"... But that code was from 2002 ...
(cherry picked from commit
8a27fdea89bc54aa35e363a376836662103c7cb7)
Fix Bug #6807.
Olaf Flebbe [Tue, 13 Oct 2009 09:39:49 +0000 (11:39 +0200)]
s3/loadparm: Fix hpux compiler issue.
Fixes bug #6804.
Volker Lendecke [Fri, 9 Oct 2009 20:58:14 +0000 (22:58 +0200)]
s3: Fix a memleak reported by dmarkey
(cherry picked from commit
5aeb954ba9382e1975c64ac96f1e377ed6af3ae0)
Fix bug #6797.
Jeremy Allison [Fri, 9 Oct 2009 19:50:26 +0000 (12:50 -0700)]
Fix bug 6796 - Deleting an event context on shutdown can cause smbd to crash.
Sync's tevent signal code with 3.5.x tree.
Protects against ev pointer being NULL.
Jeremy
Jeremy Allison [Fri, 9 Oct 2009 17:01:29 +0000 (10:01 -0700)]
Fix bug 6774 - smbd crashes if "aio write behind" is set.
Don't dereference a talloc_move'd pointer.
Jeremy.
Olaf Flebbe [Wed, 30 Sep 2009 12:55:58 +0000 (14:55 +0200)]
s3/aio: allow for outstanding_aio_calls to be decremented.
Fixes bug #6772.
Karolin Seeger [Fri, 9 Oct 2009 06:58:55 +0000 (08:58 +0200)]
s3/Makefile: BUG 6791: Fix link order for libwbclient.
Patch was provided by Buchan Milne <bgmilne@mandriva.org>.
Signed-off-by: Björn Jacke <bj@sernet.de>
Karolin Seeger [Fri, 9 Oct 2009 06:55:53 +0000 (08:55 +0200)]
s3/Makefile: BUG 6791: Fix linking order in cifs.upcall.
Patch was originally provided by Buchan Milne <bgmilne@mandriva.org>.
Signed-off-by: Björn Jacke <bj@sernet.de>
Jeremy Allison [Wed, 7 Oct 2009 22:46:57 +0000 (15:46 -0700)]
Correct fix for bug 6781 - Cannot rename subfolders in Explorer view with recent versions of Samba. Without this fix, renaming a directory ./a to ./b, whilst a directory ./aa was already open would fail. Simplifies logic of earlier code. Jeremy.
Jeremy Allison [Thu, 8 Oct 2009 23:40:26 +0000 (16:40 -0700)]
Fix bug 6769 - symlink unlink does nothing. Jeremy.
Volker Lendecke [Wed, 7 Oct 2009 12:06:53 +0000 (14:06 +0200)]
s3:winbind: Only ever handle one event after a select call
While handling an fd event, the situation with other fds can change. I've just
seen a winbind stuck in the accept() call on the privileged pipe. I can only
imagine this happen because under high load we first handled other requests and
meanwhile the client on the privileged pipe went away.
Jeremy Allison [Mon, 5 Oct 2009 21:22:05 +0000 (14:22 -0700)]
Fix bug 6776 - Running overlapping Byte Lock test will core dump Samba daemon. Re-write core of POSIX locking logic. Jeremy.
Andrew Klosterman [Tue, 8 Sep 2009 15:38:37 +0000 (17:38 +0200)]
s3:smbd: Fix bug 6690, wrong error check
Stefan Metzmacher [Fri, 25 Sep 2009 04:20:33 +0000 (06:20 +0200)]
s3:winbindd: only notify the client when we exist, if the connection isn't dead already
This is similar to commit
83edf3e43e86781872a07d8eb53084f59ad7384c.
metze
Stefan Metzmacher [Thu, 24 Sep 2009 19:35:38 +0000 (21:35 +0200)]
s3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED
metze
(cherry picked from commit
bfd3a6f13aa935950142a24bf331feb98f987bde)
Stefan Metzmacher [Sun, 20 Sep 2009 21:29:11 +0000 (23:29 +0200)]
s3:rpc_client: don't randomly fragment rpc pdu's in developer mode
This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.
metze
(cherry picked from commit
68b8149d1fb26b2fe1138c99d971754b0a30378b)
Stefan Metzmacher [Sun, 20 Sep 2009 21:29:34 +0000 (23:29 +0200)]
s3:lib/select: don't overwrite errno in the signal handler
metze
(cherry picked from commit
00e378f17c39c52689601bc622b9cd78a0cdce12)
Stefan Metzmacher [Mon, 21 Sep 2009 01:16:18 +0000 (03:16 +0200)]
tevent: make sure we don't set errno within the signal handler function.
metze
(cherry picked from commit
d13dfbeb6c6ab5b20277439da5b95f1a7f2850eb)
Stefan Metzmacher [Thu, 24 Sep 2009 04:38:08 +0000 (06:38 +0200)]
s3:rpc_server: we need to make a copy of my_name in serverinfo_to_SamInfo_base()
This is important for the case the server_info already contains a logon_server.
metze
(This is similar to commit
9ef39406d8072a1a102813fb4448af76e9020fcd)
Volker Lendecke [Wed, 23 Sep 2009 04:23:50 +0000 (06:23 +0200)]
s3:winbind: Fix an uninitialized variable (cherry picked from commit
0724649a8a7c04d015317d9dc2ae43ee87c1bd25)
Günther Deschner [Thu, 17 Sep 2009 07:43:36 +0000 (09:43 +0200)]
s3-winbindd: Fix Bug #6711: trusts to windows 2008 (2008 r2) not working.
Winbindd should always try to use LSA via an schannel authenticated ncacn_ip_tcp
connection when talking to AD for LSA lookup calls.
In Samba <-> W2k8 interdomain trust scenarios, LookupSids3 and LookupNames4 via an
schannel ncacn_ip_tcp LSA connection are the *only* options to successfully resolve
sids and names.
Guenther
(cherry picked from commit
6a8ef6c424c52be861ed2a9806f917a64ec892a6)
Günther Deschner [Sat, 12 Sep 2009 21:30:39 +0000 (23:30 +0200)]
s3-winbindd: add cm_connect_lsa_tcp().
Guenther
(cherry picked from commit
58f2deb94024f002e3c3df47f45454edc97f47e1)
Günther Deschner [Thu, 17 Sep 2009 07:42:49 +0000 (09:42 +0200)]
s3-rpc_client: fix non initialized structure in rpccli_lsa_lookup_sids_noalloc.
Guenther
(cherry picked from commit
a4b5c792c55ef90648a528d279beec32f86a9b22)
Günther Deschner [Sat, 12 Sep 2009 22:28:49 +0000 (00:28 +0200)]
s3-rpc_client: add rpccli_lsa_lookup_sids3 wrapper.
Guenther
(cherry picked from commit
2f9adf04e4b3e16c046cb371a428a8a70d5de041)
Günther Deschner [Fri, 11 Sep 2009 17:35:14 +0000 (19:35 +0200)]
s3-rpc_client: add rpccli_lsa_lookup_names4 wrapper.
Guenther
(cherry picked from commit
ff968712bab6c2635ef74723c6f52b0fdac4b424)
Günther Deschner [Thu, 17 Sep 2009 06:06:34 +0000 (08:06 +0200)]
s3-winbindd: add and use winbindd_lookup_names().
Guenther
(cherry picked from commit
99c3fc19587431efda1ae6161453d84673b32071)
Günther Deschner [Thu, 17 Sep 2009 05:59:25 +0000 (07:59 +0200)]
s3-winbindd: add and use winbindd_lookup_sids().
Guenther
(cherry picked from commit
f0b52b8c3133e3696db361d9d0e7d1fff0fab991)
Günther Deschner [Thu, 10 Sep 2009 20:23:21 +0000 (22:23 +0200)]
s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_schannel().
Guenther
(cherry picked from commit
bea8e5fa6038d5abd2ec1e12f9005c4a04abb79f)
Günther Deschner [Thu, 10 Sep 2009 20:23:21 +0000 (22:23 +0200)]
s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_spnego_ntlmssp and cli_rpc_pipe_open_ntlmssp.
Guenther
(cherry picked from commit
032e01e7c13724d057b5744d7d79613449c2f24f)
Günther Deschner [Tue, 4 Nov 2008 17:40:24 +0000 (18:40 +0100)]
s3-rpc_client: add cli_rpc_pipe_open_noauth_transport.
Guenther
(cherry picked from commit
87f61a144b8d25c90b847940ca03ced1f77b036c)
Günther Deschner [Thu, 10 Sep 2009 17:59:37 +0000 (19:59 +0200)]
s3-rpc_client: add enum dcerpc_transport_t to rpc_cli_transport struct.
Guenther
(cherry picked from commit
393a1f594d5f03a51448cdc465f92c599a93904c)
Jeremy Allison [Fri, 2 Oct 2009 10:23:32 +0000 (12:23 +0200)]
Second part of a fix for bug #6235.
Domain enumeration breaks if master browser has space in name.
Derrell Lipman [Fri, 2 Oct 2009 10:22:25 +0000 (12:22 +0200)]
Fix bug #6532.
Domain enumeration breaks if master browser has space in name.
Simo Sorce [Fri, 25 Sep 2009 14:59:04 +0000 (10:59 -0400)]
Fixing timeval calculation
The code was always doubling microseconds when attempting to round up.
Fix bug #6764.
Volker Lendecke [Tue, 29 Sep 2009 12:34:16 +0000 (14:34 +0200)]
s3: Document the "share:fake_fscaps" parameter, fix bug 6765
(cherry picked from commit
21794b0dd28a80b149342b3218d7ebb4c8791e09)
Volker Lendecke [Wed, 9 Sep 2009 19:58:47 +0000 (21:58 +0200)]
s3:smbd: Add a "hidden" parameter "share:fake_fscaps"
This is needed to support some special app I've just come across where I had to
set the SPARSE_FILES bit (0x40) to make it work against Samba at all. There
might be others to fake. This is definitely a "Don't touch if you don't know
what you're doing" thing, so I decided to make this an undocumented parametric
parameter.
I know this sucks, so feel free to beat me up on this. But I don't think it
will hurt.
(cherry picked from commit
a5cace128d1dcabd6cc90dda71a09dfa8ee8c6f6)
Fix bug #6765.
Jeremy Allison [Wed, 30 Sep 2009 12:17:40 +0000 (14:17 +0200)]
Fix for CVE-2009-2906.
Summary:
Specially crafted SMB requests on
authenticated SMB connections can send smbd
into a 100% CPU loop, causing a DoS on the
Samba server.
(cherry picked from commit
7439cd5efa50058741c57857109690e4a104f9f0)
Karolin Seeger [Wed, 30 Sep 2009 11:54:22 +0000 (13:54 +0200)]
WHATSNEW: Update release notes.
Karolin
(cherry picked from commit
9851a27b2f73e16c730983f60f7d580de897da95)
Karolin Seeger [Mon, 28 Sep 2009 11:38:32 +0000 (13:38 +0200)]
WHATSNEW: Update release date.
Karolin
(cherry picked from commit
cc0829c00d527ba0e707efe0f57d637a38b03dee)
Jeremy Allison [Mon, 28 Sep 2009 11:26:37 +0000 (13:26 +0200)]
Fix for CVE-2009-2813.
===========================================================
== Subject: Misconfigured /etc/passwd file may share folders unexpectedly
==
== CVE ID#: CVE-2009-2813
==
== Versions: All versions of Samba later than 3.0.11
==
== Summary: If a user in /etc/passwd is misconfigured to have
== an empty home directory then connecting to the home
== share of this user will use the root of the filesystem
== as the home directory.
===========================================================
(cherry picked from commit
ac075bd679fd59e93ea13780f6651a431002edd0)
Jeff Layton [Fri, 25 Sep 2009 11:03:07 +0000 (07:03 -0400)]
mount.cifs: don't leak passwords with verbose option
When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.
Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.
Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.
Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Part 2/2 of a fix for CVE-2009-2948.
(cherry picked from commit
2a422f453dd3ad9978e6ec0ac40c122163c028ed)
Jeff Layton [Fri, 25 Sep 2009 10:51:01 +0000 (06:51 -0400)]
mount.cifs: check access of credential files before opening
It's possible for an unprivileged user to pass a setuid mount.cifs a
credential or password file to which he does not have access. This can cause
mount.cifs to open the file on his behalf and possibly leak the info in the
first few lines of the file.
Check the access permissions of the file before opening it.
Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Part 1/2 of a fix for CVE-2009-2948.
(cherry picked from commit
42351937b00f6aa013d16c2a4dbd0b37e7e9ed11)
Karolin Seeger [Mon, 28 Sep 2009 11:21:07 +0000 (13:21 +0200)]
WHATSNEW: Prepare release notes for 3.4.2.
Karolin
(cherry picked from commit
53ba0b36d0d3bb2fb4b2fc5335920487060ed284)
Karolin Seeger [Thu, 24 Sep 2009 12:29:43 +0000 (14:29 +0200)]
Raise version number up to 3.4.2.
Karolin
(cherry picked from commit
d805592d6fb1fa841a74c547945226a916494a2d)
Lars Müller [Mon, 2 Feb 2009 20:38:38 +0000 (21:38 +0100)]
Adjust regex to match variable names including underscores
This is required to get the CIFSUPCALL_PROGS setting extracted from
config.log.
(cherry picked from commit
5148eefe1ea6e215dcbf4ffaa642860bd8dab45f)
Fix for bug #6710.
Bo Yang [Wed, 16 Sep 2009 15:57:01 +0000 (23:57 +0800)]
s3: Don't overwrite password in pam_winbind, subsequent pam modules might use the old password and new password.
Signed-off-by: Bo Yang <boyang@samba.org>
Fix bug #6735.
Volker Lendecke [Wed, 16 Sep 2009 01:20:49 +0000 (03:20 +0200)]
s3: Fix reading beyond the end of a named stream in xattr_streams
This was found thanks to a test by Sivani from Microsoft against Samba at the
SDC plugfest
(cherry picked from commit
444a05c28df693a745809fef73ae583a78be7c8f)
Fix bug #6731.
Björn Jacke [Tue, 15 Sep 2009 04:48:49 +0000 (06:48 +0200)]
s3: BSD needs sys/sysctl.h included to build properly
FreeBSD (and other BSDs, too) need sys/sysctl.h inclueded to use sysctlbyname().
Thanks to Timur Bakeyev for that.
Fix bug #6728.
Volker Lendecke [Fri, 18 Sep 2009 16:27:16 +0000 (18:27 +0200)]
s3:smbstatus: Fix bug 6703, allow smbstatus as non-root
We only require a ctdb connection when clustering is enabled. This limits the
restriction for only-root smbstatus to the clustering case.
Björn Jacke [Tue, 7 Jul 2009 20:11:50 +0000 (22:11 +0200)]
s3: QNX doesn't know uint - replace with uint_t
(cherry picked from commit
a28596964b44f20d794999541d38fe4bae64b56b)
Jeremy Allison [Tue, 15 Sep 2009 07:40:48 +0000 (09:40 +0200)]
s3/libsmb: SIVAL should have been an SVAL.
Fix bug #6726.
Marc Aurele La France [Thu, 10 Sep 2009 16:52:11 +0000 (09:52 -0700)]
Fix bug 6707 - 3.4.1 segfault in parsing configs.
Fixes an occasional segfault caused by an out-of-bounds reference in config file parsing.
(cherry picked from commit
7c00227f00a83345035c4c0a6716b46864f2da8d)