Andrew Tridgell [Wed, 4 Jul 2001 07:15:53 +0000 (07:15 +0000)]
The big character set handling changeover!
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
Andrew Bartlett [Wed, 4 Jul 2001 06:31:15 +0000 (06:31 +0000)]
This brings HEAD into line with SAMBA_2_2, they now both use bindir.
Andrew Bartlett
Andrew Tridgell [Wed, 4 Jul 2001 04:39:52 +0000 (04:39 +0000)]
removed some debug code
Andrew Tridgell [Wed, 4 Jul 2001 04:17:58 +0000 (04:17 +0000)]
check for bad usernames early in session setup
Tim Potter [Wed, 4 Jul 2001 04:04:17 +0000 (04:04 +0000)]
Removed bogus server_n local variable in connect_one() function.
Jeremy Allison [Wed, 4 Jul 2001 01:01:02 +0000 (01:01 +0000)]
Ensure we correctly round down to 2 second boundary if dos filetime
set for a share.
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 22:00:11 +0000 (22:00 +0000)]
Small warning removal tidyup.
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 21:32:23 +0000 (21:32 +0000)]
Remove the exit_server() calls that stop nmbd linking.
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 21:07:26 +0000 (21:07 +0000)]
Fixed warnings and made const-safe so it has the correct prototype.
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 19:34:18 +0000 (19:34 +0000)]
Removed the default addition of /include to the directory given in
--with-sslinc. Should allow building on RH7.1 when set correctly.
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 18:34:41 +0000 (18:34 +0000)]
Updated to latest from gnu.org.
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 18:33:16 +0000 (18:33 +0000)]
Added #define of int32 to int for cray. This will almost certainly cause
the rpc code to fail on the cray....
Jeremy.
Jeremy Allison [Tue, 3 Jul 2001 17:40:43 +0000 (17:40 +0000)]
Fixed incorrect debug parameters for lock_pid.
Jeremy.
Tim Potter [Tue, 3 Jul 2001 06:46:37 +0000 (06:46 +0000)]
Split pam_winbind out of WINBIND progs so it can be build separately
only if --with-pam is specified.
Andrew Bartlett [Tue, 3 Jul 2001 04:29:50 +0000 (04:29 +0000)]
See if we can stick to slightly valid C..
(With thanks to tpot)
Andrew Bartlett
Tim Potter [Tue, 3 Jul 2001 04:09:09 +0000 (04:09 +0000)]
Fixed incorrect comment for cli_NetServerEnum()
Andrew Bartlett [Tue, 3 Jul 2001 04:06:10 +0000 (04:06 +0000)]
Running torture-RANDOMIPC on the build farm doesn't go down as a 'good idea' as its logsfiles are BIG!
Andrew Tridgell [Tue, 3 Jul 2001 03:56:49 +0000 (03:56 +0000)]
fixed socketpair_tcp for OpenBSD
Tim Potter [Tue, 3 Jul 2001 02:46:50 +0000 (02:46 +0000)]
Reran autoconf.
Tim Potter [Tue, 3 Jul 2001 02:27:17 +0000 (02:27 +0000)]
Fixed quoting bug - shell programming sucks.
Jeremy Allison [Tue, 3 Jul 2001 01:01:12 +0000 (01:01 +0000)]
Adding Michael Sweet's LSB packaging.
Jeremy.
Simo Sorce [Tue, 3 Jul 2001 00:54:55 +0000 (00:54 +0000)]
- sorry, forgot to check a pointer
Jeremy Allison [Tue, 3 Jul 2001 00:52:56 +0000 (00:52 +0000)]
Applied Michael Sweet's patch, with one minor signal change.
Jeremy.
Simo Sorce [Tue, 3 Jul 2001 00:23:38 +0000 (00:23 +0000)]
- sorry, forgot to test a pointer
Jeremy Allison [Mon, 2 Jul 2001 22:17:58 +0000 (22:17 +0000)]
Made talloc_realloc() semantics match realloc(). JF was complaining :-).
realloc(NULL) == malloc. realloc(p,0) == free() - a no-op in talloc.
Jeremy.
Jeremy Allison [Mon, 2 Jul 2001 21:56:20 +0000 (21:56 +0000)]
Missing prs_align() was causing Win9x nexus tools to fail. security_info_sent
was being miss-parsed.
Jeremy.
Jeremy Allison [Mon, 2 Jul 2001 21:23:13 +0000 (21:23 +0000)]
Fixed auto-alloc of dispinfo code when unmarshalling.
Jeremy.
Jeremy Allison [Mon, 2 Jul 2001 18:37:39 +0000 (18:37 +0000)]
Fixed extra file_free calls - my fault :-(.
Jeremy.
Christopher R. Hertel [Mon, 2 Jul 2001 16:25:00 +0000 (16:25 +0000)]
Very minor cleanup. I was looking for another problem and found some bits
of code that were unclear.
Chris -)-----
Andrew Bartlett [Mon, 2 Jul 2001 13:43:46 +0000 (13:43 +0000)]
This fix from Eelco Vriezekolk <eelco@nexus.com.na> is for a SIG11 bug where we
would always file_free(fsp) twice, once in close_file and once afterwoulds.
The bug was reported in SAMBA_2_2, but a code inspection shows it to be in HEAD
as well. (Unfortunetly I don't have the facilites to actualy check this, but
the change is quite simple, makes sence and compiles).
Andrew Bartlett
Andrew Bartlett [Mon, 2 Jul 2001 09:10:32 +0000 (09:10 +0000)]
Fix the torture test, we had the wrong file-name in the tests
Andrew Bartlett
Tim Potter [Mon, 2 Jul 2001 09:10:15 +0000 (09:10 +0000)]
Re-ran configure.
Tim Potter [Mon, 2 Jul 2001 08:58:57 +0000 (08:58 +0000)]
Only build the pam_winbind module if --with-pam used.
Replaced extra shell variable with_pam_for_crypto with a check against
$with_pam
Andrew Bartlett [Mon, 2 Jul 2001 07:20:00 +0000 (07:20 +0000)]
We need strict locking to pass LOCK4
Andrew Bartlett
Andrew Bartlett [Mon, 2 Jul 2001 07:18:49 +0000 (07:18 +0000)]
Start of smbtorture based testing. Not all of smbtorture's facilites
are used, but these ones should pass.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Jul 2001 04:47:55 +0000 (04:47 +0000)]
Not all OSs have setbuffer, so we better check for it.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Jul 2001 03:21:17 +0000 (03:21 +0000)]
Make smbtorture return status values for use in the build_farm tests.
This should not have changed behaviour, and it has been tested.
Andrew Bartlett
Jeremy Allison [Mon, 2 Jul 2001 02:42:41 +0000 (02:42 +0000)]
Fixed the nastiest locking bug to track down.... smb_pids are sent in the
lockingX calls - use that instead of smb_pid in the packet.
Jeremy.
Jeremy Allison [Mon, 2 Jul 2001 00:33:15 +0000 (00:33 +0000)]
Insure caught the fact that PTRDIFFs were being done between two unrelated
pointers.
Jeremy.
Simo Sorce [Sun, 1 Jul 2001 23:24:08 +0000 (23:24 +0000)]
"netbios aliases" and "interfaces" options change from P_STRING to P_LIST
Jeremy Allison [Sun, 1 Jul 2001 20:01:32 +0000 (20:01 +0000)]
Fix for building --with-profile for new vfscalls.
Jeremy.
Andrew Tridgell [Sun, 1 Jul 2001 13:18:35 +0000 (13:18 +0000)]
cli_read() was reading too many bytes.
Simo Sorce [Sun, 1 Jul 2001 10:39:37 +0000 (10:39 +0000)]
- fix bug in reply_nt- fix bug in reply_nt1
Richard Sharpe [Sat, 30 Jun 2001 11:08:06 +0000 (11:08 +0000)]
Make sure we compile with gcc by default.
Richard Sharpe [Sat, 30 Jun 2001 04:01:51 +0000 (04:01 +0000)]
Add a static linking target to the examples Makefile so I can test out static linking ...
Jeremy Allison [Sat, 30 Jun 2001 03:11:44 +0000 (03:11 +0000)]
Ensure we return correct error on trying to unlock a region not locked.
Jeremy.
Richard Sharpe [Sat, 30 Jun 2001 03:01:09 +0000 (03:01 +0000)]
Fix another small problem with Makefile.in ... not doing the correct
check for whether or not we should build a shared library.
Andrew Bartlett [Sat, 30 Jun 2001 02:45:16 +0000 (02:45 +0000)]
This should return the build to normallity.
When you update an #ifdef'ed function, also update its matching null function
or all hell breaks loose on the build farm!
Andrew Bartlett
Jeremy Allison [Sat, 30 Jun 2001 01:59:48 +0000 (01:59 +0000)]
Fixed the first locking error (test #8 found by locktest code from
Clarion locktest.
Jeremy.
Richard Sharpe [Sat, 30 Jun 2001 01:40:51 +0000 (01:40 +0000)]
Modified Makefile.in to work properly. Define BLDSHARED as a variable in the makefile now.
Richard Sharpe [Fri, 29 Jun 2001 23:30:01 +0000 (23:30 +0000)]
These changes cause the libsmbclient stuff to always build a non-shared library and to build a shared library only for the four OSes that we currently like.
I will probably add HP/UX and AIX support based on the CUPS stuff soon ...
Jeremy Allison [Fri, 29 Jun 2001 23:12:55 +0000 (23:12 +0000)]
Added LsaGetConnectedCredentials patch from Manoj Naik <manoj@almaden.ibm.com>.
Jeremy.
Jeremy Allison [Fri, 29 Jun 2001 22:32:24 +0000 (22:32 +0000)]
Ensured all the system calls in msdfs.c go through the vfs layer.
Added vfs calls to symlink() and readlink() with appropriate configure
checks.
Jeremy.
Jeremy Allison [Fri, 29 Jun 2001 18:41:31 +0000 (18:41 +0000)]
From JF....
hi jeremy,
can you commit the following patch against HEAD. I can't do it right now
Thanks Tim for me. He changed the SAM_DISPINFO_1 array without checking if
he didn't break the server code. And he did.
So on my way I cleaned info_1, 2, .. 5
it may break winbind. I leave to tim the pleasure to fix it ;-)
jf.
I added some talloc changes and checks for alloc fails.
Jeremy.
Tim Potter [Fri, 29 Jun 2001 08:04:12 +0000 (08:04 +0000)]
Experimental support for joining a domain without creating an account in
server manager first. Just use the -U parameter to smbpasswd when joining
the domain:
smbpasswd -r PDC -j DOMAIN -U administrator%password
Should also work with domain users with the 'add workstation to domain'
user right.
Tim Potter [Fri, 29 Jun 2001 07:55:41 +0000 (07:55 +0000)]
Removed another silly static array.
Tim Potter [Fri, 29 Jun 2001 01:58:48 +0000 (01:58 +0000)]
Win9x weirdness. When setting the named pipe handle state on a Unicode
server, Win9x only sends \PIPE instead of \PIPE\. Looks suspiciously like
an off-by one bug in the Win9x dce/rpc pipe code.
Tim Potter [Fri, 29 Jun 2001 01:15:28 +0000 (01:15 +0000)]
Replaced memcpy() with memmove() to make safe_strcpy() safe for overlapping
source and destination.
Jeremy Allison [Fri, 29 Jun 2001 00:22:22 +0000 (00:22 +0000)]
Use a logical cli_read(), removed the cli_read_one() hack.
Jeremy.
Jeremy Allison [Thu, 28 Jun 2001 23:21:43 +0000 (23:21 +0000)]
param/loadparm.c: Fix for bad volume label, found by TAKAHASHI Motonobu
Samba Users Group Japan. Ensure same as in 2.2.x codebase.
Jeremy.
Christopher R. Hertel [Thu, 28 Jun 2001 20:49:47 +0000 (20:49 +0000)]
Added info to some of the debug messages to get a better handle on a problem
people are reporting regarding multiple responses to queries on <1D> names.
There should only ever be one LMB but some users are seeing multiple replies
to queries for the LMB name. This is probably due to nodes on the LAN that
have NetBIOS over NetBEUI and/or IPX enabled. Previously, the debug message
did not include the IP address associated with the name. It *did* include
the source address of the packet, but in the examples I've seen all of these
were the same, eg:
[2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (2) responses received for a query on subnet
129.130.10.136 for name NT.CIS.KSU.EDU<1d>. This response was from IP
129.130.10.24
[2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (3) responses received for a query on subnet
129.130.10.136 for name NT.CIS.KSU.EDU<1d>. This response was from IP
129.130.10.24
[2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (4) responses received for a query on subnet
129.130.10.136 for name NT.CIS.KSU.EDU<1d>. This response was from IP
129.130.10.24
[2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (5) responses received for a query on subnet
129.130.10.136 for name NT.CIS.KSU.EDU<1d>. This response was from IP
129.130.10.24
Note that all of the above are reported as having come from 129.130.10.24.
This should never happen. If 129.130.10.24 is a WINS server it should
send a Negative Name Query Response for a <1D> name query (wierd but true).
So, are all of the above coming from different systems, all of which
think are the LMB? Are they all coming from one system that is, for some
strange reason, replying five times to the same query?
Anyway, I needed more info so I've changed the debug messages.
Chris -)-----
Jeremy Allison [Thu, 28 Jun 2001 19:23:43 +0000 (19:23 +0000)]
Properly instrument print_job_start()/print_job_end() so every fail case
logs a debug. We need this to track fail cases.
Jeremy
Andrew Tridgell [Thu, 28 Jun 2001 05:57:56 +0000 (05:57 +0000)]
fixed guest account for build farm boxes
Andrew Tridgell [Thu, 28 Jun 2001 03:03:11 +0000 (03:03 +0000)]
temporarily made smbclient a non-error target so that builds will succeed when it fails. This will give richard a chance to fix problems without breaking the tree
Jeremy Allison [Wed, 27 Jun 2001 17:26:29 +0000 (17:26 +0000)]
Syncup between 2.2 and HEAD.
Jeremy.
Andrew Bartlett [Wed, 27 Jun 2001 13:58:58 +0000 (13:58 +0000)]
Jigger around with the tests a bit more
We now test security=share, security=user, security=server for both the
positive and negitive case (good/bad pw) and check that guest shares work for
share level security.
The server level security stuff seems to test positive without actualy
contating a server (another LIBSMB_PROG based smbd) - I will need to look into that...
Andrew Bartlett
Andrew Tridgell [Wed, 27 Jun 2001 13:58:44 +0000 (13:58 +0000)]
on sco2 socketpair_tcp needs a bind
Andrew Tridgell [Wed, 27 Jun 2001 10:44:14 +0000 (10:44 +0000)]
handle EISCONN in socketpair_tcp
this should get the auto-tests working on IRIX
Andrew Bartlett [Wed, 27 Jun 2001 07:59:09 +0000 (07:59 +0000)]
Add the generic funcions file for the basicsmb tests
Andrew Bartlett
Tim Potter [Wed, 27 Jun 2001 04:43:55 +0000 (04:43 +0000)]
Added some missing entries to usage().
Added -d option to set debug level.
Richard Sharpe [Wed, 27 Jun 2001 04:41:01 +0000 (04:41 +0000)]
Added back the automatic build of libsmbclient.so in head.
This is so I can find out what platforms it fails on. I will pull it again tomorrow if there are too many problems, like > 2 platforms that it fails to build on, but will pop it back in again as I resolve platforms.
Tim Potter [Wed, 27 Jun 2001 04:40:12 +0000 (04:40 +0000)]
Added doco for the -d parameter.
Richard Sharpe [Wed, 27 Jun 2001 04:06:13 +0000 (04:06 +0000)]
Fix a stupid typo ...
Andrew Bartlett [Wed, 27 Jun 2001 00:32:52 +0000 (00:32 +0000)]
Changed some of the tests around, made failures for parts actualy count
Andrew Bartlett
Herb Lewis [Tue, 26 Jun 2001 20:23:45 +0000 (20:23 +0000)]
SGI compiler fixes.
Jeremy
Martin Pool [Tue, 26 Jun 2001 07:44:02 +0000 (07:44 +0000)]
Add check for working AF_LOCAL sockets, which are borken
on RH7.0 with _LARGEFILE64_SOURCE, and probably not
present on non-Unix systems like VMS.
Andrew Bartlett [Tue, 26 Jun 2001 07:41:40 +0000 (07:41 +0000)]
Added the basic tests of smb functionality for HEAD
This works with the new build farm system
Andrew Bartlett
Jeremy Allison [Tue, 26 Jun 2001 06:31:55 +0000 (06:31 +0000)]
Ensure we always have a valid pointer on unmarshalling an SD with zero
ace entries.
Jeremy.
Tim Potter [Tue, 26 Jun 2001 06:26:05 +0000 (06:26 +0000)]
Put an 0x in front of a hex number.
Tim Potter [Tue, 26 Jun 2001 06:11:40 +0000 (06:11 +0000)]
Fixed bug introduced by changeover of security descriptor code from
malloc() to talloc(). Previously, creating an ACL containing zero ACEs
would return a non-NULL pointer to zero bytes of memory. The talloc() code
would return a NULL pointer making the ACL a NULL ACL instead of an empty
one. The difference is a NULL ACL allows all access and an empty ACL
denies all access.
We solve this by calling talloc(ctx, sizeof(SEC_ACE) * num_aces + 1).
Heh.
Jeremy Allison [Tue, 26 Jun 2001 06:06:42 +0000 (06:06 +0000)]
Always use DOMAIN\user first that this is the more specific case.
Jeremy.
Andrew Tridgell [Tue, 26 Jun 2001 05:38:24 +0000 (05:38 +0000)]
fixed build
don't rush commits :)
Andrew Tridgell [Tue, 26 Jun 2001 05:21:49 +0000 (05:21 +0000)]
fall back to "unsigned" for uint32 on systems that don't have one
Andrew Bartlett [Tue, 26 Jun 2001 03:45:45 +0000 (03:45 +0000)]
Remove warning about trapdoor systems for non-root mode.
Andrew Bartlett
Jeremy Allison [Mon, 25 Jun 2001 21:29:33 +0000 (21:29 +0000)]
Ensure numeric group or user names don't get misinterpreted.
Jeremy.
Jeremy Allison [Mon, 25 Jun 2001 20:44:04 +0000 (20:44 +0000)]
Added Andrew's pam password change stuff. Needs some testing but looks good !
Jeremy.
Jeremy Allison [Mon, 25 Jun 2001 19:08:30 +0000 (19:08 +0000)]
Fixed stupid typo that would stop trusted domains working.
Jeremy.
Tim Potter [Mon, 25 Jun 2001 06:13:27 +0000 (06:13 +0000)]
Cosmetic fixups found while playing with the server manager. Added support
for NET_SRV_SET_INFO rpc call which is made when double-clicking on a
computer in the server manager and changing the description. We always
return NT_STATUS_NOPROBLEMO as NT doesn't seem to decode any error messages
passed back.
Maybe the changed comment string could be stored in a tdb and regurgitated
instead of the "server string" smb.conf parameter?
Andrew Tridgell [Mon, 25 Jun 2001 03:36:09 +0000 (03:36 +0000)]
got rid of the date headers off all text docs
Andrew Tridgell [Mon, 25 Jun 2001 02:53:13 +0000 (02:53 +0000)]
fixed usage of socklen_t and also tidied up SIG_ATOMIC_T, using a typedef instead of a define
Andrew Tridgell [Mon, 25 Jun 2001 01:20:47 +0000 (01:20 +0000)]
make sure we have BOOL in autoconf usage of util_sec.c
Andrew Tridgell [Mon, 25 Jun 2001 01:15:17 +0000 (01:15 +0000)]
added a -L option to smbpasswd to force it to run locally so we can test smbpasswd as non-root
Andrew Tridgell [Mon, 25 Jun 2001 00:46:34 +0000 (00:46 +0000)]
- make the regresison test mode code build in by default. This should
allow us to have test targets without special configure options
- fixed make proto so that it actually does something
Simo Sorce [Sun, 24 Jun 2001 01:41:38 +0000 (01:41 +0000)]
fixed error
using wrong pointer to test and free s/str/s/
Jeremy Allison [Sat, 23 Jun 2001 20:01:23 +0000 (20:01 +0000)]
Log debug before and after netbios names copied so we know if they've been
changed.
Jeremy.
Simo Sorce [Sat, 23 Jun 2001 15:27:04 +0000 (15:27 +0000)]
uhm some pointer went wrong
Simo Sorce [Sat, 23 Jun 2001 15:01:34 +0000 (15:01 +0000)]
handle P_LIST parameters
Simo Sorce [Sat, 23 Jun 2001 14:58:38 +0000 (14:58 +0000)]
fix compiler warnings
Simo Sorce [Sat, 23 Jun 2001 14:13:32 +0000 (14:13 +0000)]
fix compiler warnings
Jeremy Allison [Sat, 23 Jun 2001 07:22:16 +0000 (07:22 +0000)]
Added other_safe_chars to alpha_strcpy(). Needs testing but is a better
fix for the problem.
Jeremy.