Simo Sorce [Wed, 30 Jun 2010 16:19:41 +0000 (12:19 -0400)]
s3-spoolss: Allocate printer entries on the pipe struct.
Signed-off-by: Andreas Schneider <asn@samba.org>
Simo Sorce [Wed, 30 Jun 2010 16:07:44 +0000 (12:07 -0400)]
s3-spoolss: Rename session counter structure and use talloc.
Signed-off-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 3 Dec 2008 09:40:04 +0000 (10:40 +0100)]
s3-dsgetdcname: cleanup receive_getdc_response a little.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:51:32 +0000 (11:51 +0200)]
s3-build: use proper RPC_X_OBJ target names.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:49:49 +0000 (11:49 +0200)]
s3-waf: use proper RPC_X_SRC names.
This allows to build using waf without --enable-developer and should also fix
support for rpc server modules.
Guenther
Anatoliy Atanasov [Fri, 10 Sep 2010 10:44:20 +0000 (13:44 +0300)]
s4/fsmo: Change return type from NTSTATUS to WERROR for drepl_takeFSMOrole
This removed an unnecessary conversion of the return type in
drepl_take_FSMO_role.
Anatoliy Atanasov [Fri, 10 Sep 2010 06:00:56 +0000 (09:00 +0300)]
s4/fsmo: Fix callback declaration
Kamen Mazdrashki [Thu, 9 Sep 2010 23:05:27 +0000 (02:05 +0300)]
s4-drs: return DRSUAPI_EXOP_ERR_SUCCESS in extended_ret
in case we are handling extended operation.
It seems that windows accept both DRSUAPI_EXOP_ERR_SUCCESS
and DRSUAPI_EXOP_ERR_NONE, but Samba is a little bit
more picky on this.
Kamen Mazdrashki [Thu, 9 Sep 2010 23:02:56 +0000 (02:02 +0300)]
s4-drs: Hanlde extended operations only once
Most of extended operations I know of work like:
1. do extended operation
2. collect a set of objects to return and start replication cycle
3. continue returning object as we have no more to give
This way we ensure we are doing 1. only once
Kamen Mazdrashki [Thu, 9 Sep 2010 22:59:21 +0000 (01:59 +0300)]
s4-dreplsrv: fix 'dn' for partition object being created
Kamen Mazdrashki [Thu, 9 Sep 2010 22:58:07 +0000 (01:58 +0300)]
s4-drs-fsmo: try to dispatch ops in queue as soon as possible
In most cases this will transfer of schema master role to
look like a synchronous operation.
Anatoliy Atanasov [Wed, 8 Sep 2010 07:25:54 +0000 (10:25 +0300)]
s4/fsmo: Added python tests for schema master transfer op
Andrew Tridgell [Thu, 9 Sep 2010 06:16:05 +0000 (16:16 +1000)]
s4-fsmo: update FSMO changes for recent IRPC work
the IRPC API has changed
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Anatoliy Atanasov [Thu, 26 Aug 2010 08:19:24 +0000 (11:19 +0300)]
s4/drs: update repsFrom only when we are not in getncchanges extended op
Nadezhda Ivanova [Thu, 26 Aug 2010 08:09:58 +0000 (11:09 +0300)]
s4-ldap: Added support for FSMO role transfer via LDAP by modify on rootDSE
GetNCChanges with the corresponding extended operation is initiated and added to
the queue when a modify request is received on becomeSchemaMaster, becomeRidMaster,
becomeNamingMaster, becomeInfrastructureMaster and becomePDC attributes in
rootDSE.
Nadezhda Ivanova [Thu, 26 Aug 2010 07:59:02 +0000 (10:59 +0300)]
s4-rpc: Added handling of fsmo role transfer to GetNCChanges
This adds support for DRSUAPI_EXOP_FSMO_REQ_ROLE, DRSUAPI_EXOP_FSMO_RID_REQ_ROLE
and DRSUAPI_EXOP_FSMO_REQ_PDC.
Developed in collaboration with Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
Nadezhda Ivanova [Tue, 24 Aug 2010 21:26:28 +0000 (00:26 +0300)]
s4-irpc: Added internal rpc call DREPL_TAKEFSMOROLE
It schedules a getncchanges with extended op 6, to be used when a modify request on
becomeROLEMaster atteibute on rootDSE is received.
Nadezhda Ivanova [Tue, 24 Aug 2010 21:22:16 +0000 (00:22 +0300)]
s4-drs: Implementation of GetNCChanges extended op 6 - fsmo role transfer
Basically the candidate owner makes a getncchanges call with extended op 6 when they want to
become the new owner. The current owner then updates the corresponding fSMORoleOwner attribute
in its database with the new owner, and replicates the change to the candidate, who then becomes the
owner.
The patch was made in cooperation with Anatoliy Atanasov <anatoliy.atanasov@postpath.com> who
kindly helped to debug it.
Nadezhda Ivanova [Tue, 24 Aug 2010 20:01:43 +0000 (23:01 +0300)]
s4-drs: Refactored drepl_service and send_ridalloc_request so that the structures can be used for other extended ops
Björn Jacke [Fri, 10 Sep 2010 09:51:15 +0000 (11:51 +0200)]
s4/torture: use time_mono for deltas in lock test
Günther Deschner [Fri, 10 Sep 2010 09:28:54 +0000 (11:28 +0200)]
s3-build: only link LIBNDR_XATTR_OBJ where needed.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:28:38 +0000 (11:28 +0200)]
s3-waf: only link LIBNDR_XATTR_SRC where needed.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:27:52 +0000 (11:27 +0200)]
s3-build: link ndr_notify only where needed.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:26:35 +0000 (11:26 +0200)]
s3-waf: link ndr_notify only where needed.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:24:28 +0000 (11:24 +0200)]
s3-build: link ndr_named_pipe_auth only where needed.
Guenther
Günther Deschner [Fri, 10 Sep 2010 09:23:59 +0000 (11:23 +0200)]
s3-waf: link ndr_named_pipe_auth only where needed.
Guenther
Günther Deschner [Thu, 2 Sep 2010 11:19:02 +0000 (13:19 +0200)]
s3-spoolss: allow a short printername w/o servername.
Verified with RPC-SPOOLSS-PRINTSERVER-enumprinters_old test.
Guenther
Jeremy Allison [Thu, 9 Sep 2010 22:29:03 +0000 (15:29 -0700)]
Fox missing SMB_MALLOC return checks noticed by "Andreas Moroder <andreas.moroder@gmx.net>".
Jeremy.
Jeremy Allison [Thu, 9 Sep 2010 22:28:43 +0000 (15:28 -0700)]
More paranoia to ensure SD's can't be set on read-only shares.
Jeremy.
Günther Deschner [Thu, 2 Sep 2010 11:39:12 +0000 (13:39 +0200)]
s3-selftest: rename printer "print4" to "lp".
This should trigger a false error condition in our code.
Guenther
Günther Deschner [Thu, 9 Sep 2010 22:16:30 +0000 (00:16 +0200)]
s4-smbtorture: add spoolss_OpenPrinter with unc and printername in RPC-SPOOLSS-PRINTSERVER.
Guenther
Volker Lendecke [Thu, 9 Sep 2010 14:57:01 +0000 (16:57 +0200)]
s3: Fix messsssages
Volker Lendecke [Thu, 9 Sep 2010 14:25:09 +0000 (16:25 +0200)]
s3: Ensure NULL termination for "workstation" in auth_crap
Günther Deschner [Thu, 9 Sep 2010 21:13:33 +0000 (23:13 +0200)]
s3-nmbd: use NETLOGON_NT_VERSION_1 in LOGON_PRIMARY_RESPONSE.
Guenther
Volker Lendecke [Thu, 9 Sep 2010 14:02:38 +0000 (16:02 +0200)]
s3: These assignments are overwritten immediately
Dump them
Günther Deschner [Wed, 8 Sep 2010 16:55:27 +0000 (18:55 +0200)]
s3-nmbd: use autogenerated marshalling for LOGON_SAM_LOGON_REQUEST.
Guenther
Günther Deschner [Thu, 9 Sep 2010 11:16:21 +0000 (13:16 +0200)]
s3-nmbd: use autogenerated marshalling for LOGON_PRIMARY_QUERY.
Couldn't find any reproducer for a short request, so removing it for now.
Guenther
Günther Deschner [Thu, 9 Sep 2010 20:39:05 +0000 (22:39 +0200)]
s3-nmbd: use autogenerated marshalling for LOGON_REQUEST.
Guenther
Günther Deschner [Thu, 9 Sep 2010 20:38:37 +0000 (22:38 +0200)]
s3-nmbd: handle source_name in one location in nmbd_process_logon().
Guenther
Günther Deschner [Tue, 7 Sep 2010 09:41:05 +0000 (11:41 +0200)]
s3-nmbd: use nbt_netlogon_packet in process_logon_packet().
Guenther
Günther Deschner [Wed, 8 Sep 2010 09:58:04 +0000 (11:58 +0200)]
libcli/netlogon: add LOGON_REQUEST handling to pull_nbt_netlogon_response().
Guenther
Günther Deschner [Wed, 8 Sep 2010 16:59:19 +0000 (18:59 +0200)]
libcli/netlogon: add LOGON_RESPONSE2 to pull_nbt_netlogon_response().
Guenther
Günther Deschner [Tue, 7 Sep 2010 20:41:44 +0000 (22:41 +0200)]
libcli/netlogon: add NETLOGON_RESPONSE2 to push_nbt_netlogon_response().
Guenther
Matthias Dieter Wallnöfer [Thu, 9 Sep 2010 19:29:21 +0000 (21:29 +0200)]
s4:client/cifsdd.c - restore Solaris cc compatibility
"static const struct"s need to be global in order to work with Solaris cc.
Matthias Dieter Wallnöfer [Thu, 9 Sep 2010 19:26:43 +0000 (21:26 +0200)]
s4:torture/rpc/winreg.c - restore Solaris cc compatibility
"static const struct"s need to be global in order to work with Solaris cc.
Matthias Dieter Wallnöfer [Thu, 9 Sep 2010 18:31:38 +0000 (20:31 +0200)]
s4:libcli/security/*.c - fix some wrong typed counters
According to "librpc/gen_ndr/security.h" they need to be "uint32_t".
Kamen Mazdrashki [Wed, 8 Sep 2010 22:43:01 +0000 (01:43 +0300)]
s4-dreplsrv: Do allocations on long-living context so that callback gets called
Kamen Mazdrashki [Wed, 8 Sep 2010 21:55:51 +0000 (00:55 +0300)]
s4-drs-test: Add 'reset' and 'replace' tests for drsuapi_DsReplicaUpdateRefs
At first I got the impression we are not handling those cases,
but after those tests surprisingly passed I saw that
we have correct behavior implemented in a helper function.
So I decided to commit those tests in case someone change the
strange-looking check for DRSUAPI_DRS_ADD_REF flag in
a function that handles delete operation :)
Kamen Mazdrashki [Tue, 7 Sep 2010 22:07:44 +0000 (01:07 +0300)]
s4-dreplsrv: Call dreplsrv_out_operation::callback in case we fail to even run the operation
Operation was scheduled already, so we need to call
the callback function for it to be able to do its job.
For instance, if we are blocking an rpc call until an
operation is completed and there is no memory, then
client will be blocked without knowing what is going on
with the server.
Kamen Mazdrashki [Tue, 7 Sep 2010 19:24:24 +0000 (22:24 +0300)]
s4-dsdb/repl/drepl_out_pull.c: Remove unused code
Kamen Mazdrashki [Tue, 7 Sep 2010 19:18:53 +0000 (22:18 +0300)]
s4-drepl_service.c: Update (C)
and remove few trailing white spaces
Kamen Mazdrashki [Tue, 7 Sep 2010 18:22:47 +0000 (21:22 +0300)]
s4-drepsrv: Dump more info when drepl_replica_sync() fails
There are many spots where this function may fail
and I find it very useful to know where exactly function
fails and what are the input parameters during testing.
REPLICA_SYNC_FAIL() macro now dumps an error message
so we may remove extra DEBUG() dump in implementation.
Andreas Schneider [Thu, 9 Sep 2010 14:39:33 +0000 (16:39 +0200)]
s3-printing: Make missing auth_serversupplied_info const.
Andreas Schneider [Thu, 9 Sep 2010 09:22:06 +0000 (11:22 +0200)]
s3-spoolss: Use systerm server_info for winreg connection.
This will ensure that we have the rights we need to access the regsitry.
Andreas Schneider [Thu, 9 Sep 2010 09:21:43 +0000 (11:21 +0200)]
s3-spoolss: Make auth_serversupplied_info const.
Andreas Schneider [Thu, 9 Sep 2010 09:32:03 +0000 (11:32 +0200)]
s3-printing: Make auth_serversupplied_info const.
Andreas Schneider [Thu, 9 Sep 2010 09:37:49 +0000 (11:37 +0200)]
s3-msdfs: Make auth_serversupplied_info const.
Andreas Schneider [Thu, 9 Sep 2010 09:35:50 +0000 (11:35 +0200)]
s3-rpcint: Make auth_serversupplied_info const.
Andreas Schneider [Thu, 9 Sep 2010 09:00:18 +0000 (11:00 +0200)]
s3-auth: Added get_server_info_system function.
Andreas Schneider [Wed, 8 Sep 2010 17:39:36 +0000 (19:39 +0200)]
s3-spoolss: Fixed some build warnings.
Andrew Tridgell [Thu, 9 Sep 2010 11:38:01 +0000 (21:38 +1000)]
s4-rodc: cope with missing searchFlags
this can be missing after the schema tests
Andrew Bartlett [Thu, 9 Sep 2010 05:20:48 +0000 (15:20 +1000)]
s4-dsdb Change debug levels for startup messages
We should make the 'common' error not show up, but the unusal case fatal.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Sep 2010 04:58:06 +0000 (14:58 +1000)]
s4-setup Make krb5.conf use DNS by default
We set up our DNS pretty well these days, and I think the previous setting
was only there because Andrew Kroeger copied this out of our selftest code
in
bf3f3af92677bce8f03b0dd2be552d6c8c730ca1.
Andrew Bartlett
Andrew Tridgell [Thu, 9 Sep 2010 08:06:33 +0000 (18:06 +1000)]
s4-test: added a RODC test using rpcecho
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 9 Sep 2010 08:02:31 +0000 (18:02 +1000)]
s4-test: added a RODC to our testing
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 9 Sep 2010 08:02:08 +0000 (18:02 +1000)]
s4-rodc: get the domain name from the partitions DN
don't rely on the netbios domain name being the first part of the
realm
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 9 Sep 2010 07:59:40 +0000 (17:59 +1000)]
pyldb: expose PyLdbDn_FromDn()
This is needed by the dsdb python interface
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 9 Sep 2010 07:35:14 +0000 (17:35 +1000)]
s4-provision: fixed error format string
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 9 Sep 2010 07:34:55 +0000 (17:34 +1000)]
s4-pydsdb: expose samdb_partitions_dn() as get_partitions_dn() in python
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 7 Sep 2010 05:25:45 +0000 (15:25 +1000)]
s4-rodc: s->schema need initialisation
this fixes a segfault in net rodc preload
Günther Deschner [Thu, 9 Sep 2010 09:10:01 +0000 (11:10 +0200)]
lib/util: remove some unused_result warnings.
Guenther
Günther Deschner [Thu, 9 Sep 2010 09:09:35 +0000 (11:09 +0200)]
s3-utils: remove unused variable in smbget.
Guenther
Volker Lendecke [Thu, 9 Sep 2010 02:12:21 +0000 (19:12 -0700)]
s3: Remove "mem_ctx" from a few functions
Volker Lendecke [Thu, 9 Sep 2010 02:09:21 +0000 (19:09 -0700)]
s3: Remove "mem_ctx" from wcache_save_creds()
Volker Lendecke [Thu, 9 Sep 2010 02:03:15 +0000 (19:03 -0700)]
s3: Remove "mem_ctx" from lookup_cached_name()
Volker Lendecke [Thu, 9 Sep 2010 02:01:11 +0000 (19:01 -0700)]
s3: Remove a nested if-statement
Volker Lendecke [Thu, 9 Sep 2010 01:09:07 +0000 (18:09 -0700)]
s3: Fill in workstation in winbindd_pam_auth_crap_send
Volker Lendecke [Thu, 9 Sep 2010 01:07:31 +0000 (18:07 -0700)]
s3: Fill in domain in winbindd_pam_auth_crap_send
Volker Lendecke [Thu, 9 Sep 2010 00:56:55 +0000 (17:56 -0700)]
s3: Remove redundant flag checks
We're checking these in the parent already (winbindd_pam_auth_send and
winbindd_pam_auth_crap_send). No point in doing it in the child as well
Volker Lendecke [Wed, 8 Sep 2010 23:58:21 +0000 (16:58 -0700)]
s3: Remove unused arg "user_sid" from winbindd_store_creds
All callers have passed in NULL
Volker Lendecke [Wed, 8 Sep 2010 23:54:50 +0000 (16:54 -0700)]
s3: Remove unused winbindd_update_creds_by_sid
Volker Lendecke [Wed, 8 Sep 2010 17:04:53 +0000 (10:04 -0700)]
s3: Remove unused winbindd_dual_show_sequence()
Jeremy Allison [Thu, 9 Sep 2010 03:54:38 +0000 (20:54 -0700)]
Don't rely on the underlying ACL modules to enforce share level
security when setting ACLs, check at the call level as well.
Jeremy.
Jeremy Allison [Wed, 8 Sep 2010 23:55:24 +0000 (16:55 -0700)]
Optimization suggested by Metze. Without this patch,
FindFirst with 'path\to\some\dir\with\files\*'
triggers the following stat calls
path\to\some\dir\with\files\* => ENOENT
path\
path\to\
path\to\some\
path\to\some\dir\
path\to\some\dir\with\
path\to\some\dir\with\files\
path\to\some\dir\with\files\* => ENOENT
With this patch we get :
path\to\some\dir\with\files\* => ENOENT
path\to\some\dir\with\files = OK
Jeremy.
Volker Lendecke [Wed, 8 Sep 2010 13:29:32 +0000 (15:29 +0200)]
s3: "== false" looks wrong :-)
Jeremy Allison [Wed, 8 Sep 2010 22:13:45 +0000 (15:13 -0700)]
Fix warnings caused by double ";;" at the end of the time_mono() fixes.
Günther Deschner [Wed, 8 Sep 2010 21:23:09 +0000 (23:23 +0200)]
s4-waf: fix bin/python/samba/dcerpc/nbt.so.
Thanks to Brad Hards for pointing this out.
Guenther
Jelmer Vernooij [Wed, 8 Sep 2010 20:45:12 +0000 (22:45 +0200)]
wafsamba: Eliminate sys.path updating if installing to a standard python
path.
Björn Jacke [Wed, 8 Sep 2010 20:29:00 +0000 (22:29 +0200)]
s3: use time_mono throughout in smbget
Björn Jacke [Mon, 6 Sep 2010 23:04:10 +0000 (01:04 +0200)]
s3/ldap: use monotonic clock for timeouts in smbldap
tevent would need monotonic clock features to make also smbldap's idle handling
aware of backward clock jumps. Other areas in smbldap are clock jump save now.
Jelmer Vernooij [Wed, 8 Sep 2010 20:11:55 +0000 (22:11 +0200)]
setup: Use standard octal ints rather than harcoding.
Jelmer Vernooij [Wed, 8 Sep 2010 20:11:23 +0000 (22:11 +0200)]
popt_common: Add missing dependency on libsamba-hostconfig.
Volker Lendecke [Wed, 8 Sep 2010 10:07:42 +0000 (12:07 +0200)]
s3: Make winbind_add_failed_connection_entry static
Volker Lendecke [Wed, 8 Sep 2010 18:59:46 +0000 (20:59 +0200)]
s3: Fix a typo
Günther Deschner [Wed, 8 Sep 2010 09:18:40 +0000 (11:18 +0200)]
s4-smbtorture: add torture ndr nbt testsuite.
Guenther
Günther Deschner [Tue, 7 Sep 2010 20:41:06 +0000 (22:41 +0200)]
nbt: add nbt_netlogon_response2 to IDL.
Guenther
Günther Deschner [Tue, 7 Sep 2010 11:16:27 +0000 (13:16 +0200)]
nbt: add NETLOGON_LOGON_REQUEST.
Guenther
Günther Deschner [Wed, 8 Sep 2010 09:19:48 +0000 (11:19 +0200)]
nbt: add decode_nbt_netlogon_packet() to IDL.
Guenther
Günther Deschner [Tue, 7 Sep 2010 09:50:39 +0000 (11:50 +0200)]
s3-nmbd: fix indentation in process_logon_packet().
purely cosmetic, no code change.
Guenther
Günther Deschner [Wed, 8 Sep 2010 17:01:10 +0000 (19:01 +0200)]
s3-nmbd: remove trailing whitespace in nmbd_processlogon.c
Guenther