Jeremy Allison [Thu, 8 Sep 2011 20:48:27 +0000 (13:48 -0700)]
Second part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
Be smarter about setting default permissions when a ACL_USER_OBJ isn't given. Use the principle of least surprises for the user.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 9 00:26:08 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 8 Sep 2011 19:51:18 +0000 (12:51 -0700)]
First part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
create_default_mode() is not needed - it's taken care of by code
inside ensure_canon_entry_valid().
Jeremy Allison [Fri, 3 Jun 2011 21:28:33 +0000 (14:28 -0700)]
Fix bug #8203 - winbindd needs to reset the DC connection if an RPC times out.
Based on Volker's original code.
(cherry picked from commit
5b5ef7f20d34f4c6c1d3d02530ac7b13e051c960)
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 21:29:53 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 8 Sep 2011 07:56:16 +0000 (09:56 +0200)]
s3:torture: make use of CLI_FULL_CONNECTION_DONT_SPNEGO
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 8 19:23:32 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 8 Sep 2011 07:24:11 +0000 (09:24 +0200)]
s3:torture: make use of CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
metze
Stefan Metzmacher [Thu, 8 Sep 2011 07:49:26 +0000 (09:49 +0200)]
s3:libsmb: add CLI_FULL_CONNECTION_FORCE_ASCII
metze
Stefan Metzmacher [Thu, 8 Sep 2011 07:18:45 +0000 (09:18 +0200)]
s3:libsmb: add CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
metze
Stefan Metzmacher [Thu, 8 Sep 2011 15:26:30 +0000 (17:26 +0200)]
s3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_full_connection()
This is already done by cli_state_create().
metze
Stefan Metzmacher [Thu, 8 Sep 2011 15:26:30 +0000 (17:26 +0200)]
s3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_start_connection()
This is already done by cli_state_create().
metze
Andrew Bartlett [Thu, 8 Sep 2011 11:41:12 +0000 (21:41 +1000)]
s4-param void function cannot return value
This is even if the returned function is void, on Solaris.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep 8 16:38:30 CEST 2011 on sn-devel-104
Andrew Tridgell [Tue, 26 Jul 2011 02:21:00 +0000 (12:21 +1000)]
s3-loadparm: fixed re-application of cmdline parametric options
this ensures that cmdline parametric options are re-applied when we
reload smb.conf
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 02:19:58 +0000 (12:19 +1000)]
s3-loadparm: fixed a memory leak in parametric options
before we memset the Globals structure we need to free any global
parametrics
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 01:01:36 +0000 (11:01 +1000)]
nsswitch: make the wbcSidsToUnixIds() parser more robust
this allows it to handle new types of responses
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 00:52:59 +0000 (10:52 +1000)]
s4-winbindd: implement WINBINDD_SIDS_TO_XIDS
this fixes wbinfo --sids-to-unix-ids
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 00:51:31 +0000 (10:51 +1000)]
s4-winbindd: fixed handling of extra_data in s3 requests
extra_data in s3 winbind requests is appended to the end of the
request, but does not change the length header of the packet. Instead
you need to get it from the extra_len element of the request
structure.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 00:50:22 +0000 (10:50 +1000)]
s4-winbind: added count argument to wb_sids2xids_recv()
this allows callers to know how many SIDs were mapped
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Thu, 8 Sep 2011 11:15:21 +0000 (13:15 +0200)]
s3: Fix a debug message
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Sep 8 15:08:43 CEST 2011 on sn-devel-104
Volker Lendecke [Thu, 8 Sep 2011 10:01:42 +0000 (12:01 +0200)]
s3: Fix a typo
Andrew Bartlett [Thu, 8 Sep 2011 09:07:47 +0000 (19:07 +1000)]
build: Add duplicate symbol checking as part of make test
This ensures we do not get duplicate symbols again, when run as
./configure.developer on non-build farm machines.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep 8 13:37:40 CEST 2011 on sn-devel-104
Andrew Bartlett [Thu, 8 Sep 2011 07:14:44 +0000 (17:14 +1000)]
build: netapi does not depend on TOKEN_UTIL
This means we avoid dupliate symbols between libgpo and netapi.
Andrew Bartlett
Andrew Bartlett [Thu, 8 Sep 2011 07:10:27 +0000 (17:10 +1000)]
build: make LIBWBCLIENT_OLD and auth_unix_token libraries
This assists with avoiding duplicate symbols.
Andrew Bartlett
Andrew Bartlett [Thu, 8 Sep 2011 07:09:47 +0000 (17:09 +1000)]
librpc: put NDR_NTPRINTING into ndr-samba grouping library
This assists with avoiding duplicate symobls now that ntprinting_migrate is a library.
Andrew Bartlett
Andrew Bartlett [Thu, 8 Sep 2011 07:08:52 +0000 (17:08 +1000)]
libgpo: call security_token_has_sid() directly
Stefan Metzmacher [Wed, 7 Sep 2011 18:35:51 +0000 (20:35 +0200)]
s3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 8 10:21:50 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 7 Sep 2011 19:10:24 +0000 (21:10 +0200)]
s3:libsmb: pass CLI_FULL_CONNECTION_* flags to cli_state_create()
metze
Stefan Metzmacher [Thu, 8 Sep 2011 06:01:30 +0000 (08:01 +0200)]
lib/replace: include <sys/uio.h> in "system/filesys.h" in order to have struct iovec
This is needed on some platforms, e.g. NetBSD5.
metze
Jeremy Allison [Thu, 8 Sep 2011 05:18:18 +0000 (22:18 -0700)]
Revert "Part 4 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set (Invalid argument)"
This belongs as part of the bugfix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
Not as part of #7509.
This reverts commit
2a1453e2318af77a79180f3137f8a8d3f1240233.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 08:50:12 CEST 2011 on sn-devel-104
Andrew Tridgell [Wed, 7 Sep 2011 07:18:24 +0000 (17:18 +1000)]
s4-cracknames: use consistent search for crossRef objects
This matches the search in other places
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Sep 8 05:02:54 CEST 2011 on sn-devel-104
Andrew Tridgell [Wed, 7 Sep 2011 07:12:37 +0000 (17:12 +1000)]
pidl: adjust expected output for new flag checking
Andrew Tridgell [Wed, 7 Sep 2011 06:25:48 +0000 (16:25 +1000)]
s4-dsdb: prevent crash on bad DN in construct_parent_guid()
this was found by a flakey test in autobuild
Andrew Tridgell [Wed, 7 Sep 2011 05:37:22 +0000 (15:37 +1000)]
torture-drs: fixed NDR tests for DRS blobs
this also adds new tests for trustAuthInOutBlob blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:36:57 +0000 (15:36 +1000)]
torture-ndr: fixed NDR tests for NTLMSSP blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:36:38 +0000 (15:36 +1000)]
torture-ndr: fixed NDR tests for NBT blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:36:22 +0000 (15:36 +1000)]
torture-ndr: fixed NDR tests for DFS blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:35:55 +0000 (15:35 +1000)]
torture-ndr: added support for testing push functions
this allows us to check the symmetry of pull/push functions in NDR
tests
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:34:43 +0000 (15:34 +1000)]
pidl: added checking of NDR flags in generated code
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:34:20 +0000 (15:34 +1000)]
libndr: add checking to all pull/push functions of base types
this checks that the passed in ndr_flags are valid
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:29:32 +0000 (15:29 +1000)]
libndr: moved the NDR_* flags to have less overlap
We have 3 different types of flags values in our NDR layer. We've
recently found bugs where these types of flags have been mixed up,
especially by people adding hand written ndr code for tricky
structures. We previously got away with this because (for example)
NDR_SCALARS and NDR_IN had the same value, so mixing up the two
concepts sometimes worked. Unfortunately it also led to bugs where we
didn't do what was expected, such as in our smbtorture ndr test suite,
where passing a ndr_flags value of zero led to only checking that two
empty structures were equal.
This changes the values of the NDR_IN|NDR_OUT and
NDR_SCALARS|NDR_BUFFERS values to be in different bit ranges, and adds
macros for checking the validity of passed in flags. A followup patch
modifies the ndr calls to use these macros, and pidl to generate
them. This should catch misuse of the APIs.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:28:42 +0000 (15:28 +1000)]
lib: added base64_decode_data_blob_talloc()
its nice to be able to allocate on other than NULL
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 5 Sep 2011 07:07:22 +0000 (17:07 +1000)]
s4-dsdb: fixed compiler warning
sid can be const
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Jeremy Allison [Wed, 7 Sep 2011 21:57:11 +0000 (14:57 -0700)]
Tidy up previous patch for bug #8442 - NFSv4 DENY ACLs always include SYNCHRONIZE flag - blocking renames.
aceType is an enum field, not a bitmask.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 03:34:39 CEST 2011 on sn-devel-104
Amitay Isaacs [Tue, 6 Sep 2011 06:22:45 +0000 (16:22 +1000)]
s4-provision: Fill msDS-NC-Replica-Locations attribute in DNS provisioning
This attribute is required by the hosting requirement.
[MS_ADTS].pdf 7.1.2.3.1 DC and Application NC Replica
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep 8 02:04:51 CEST 2011 on sn-devel-104
Amitay Isaacs [Mon, 5 Sep 2011 06:19:37 +0000 (16:19 +1000)]
s4-provision: Make DNS entries consistent with dns_update script
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:19:02 +0000 (16:19 +1000)]
s4-provision: Reworked DNS provisioning to support AD DNS schema
This changes configure DNS partitions used by AD DNS and populate
with relevant entries. This has an advantage that Windows can
replicate these partitions and set up dns server using them.
In addition, these partitions are used by bind9_dlz module to query
zone information directly and do not need to create text database
for dynamic zones.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:11:57 +0000 (16:11 +1000)]
s4-provision: LDIF files to set up AD DNS schema
This files set up DomainDnsZones and ForestDnsZones partitions and
other configuration parameters for replication.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:09:59 +0000 (16:09 +1000)]
s4-provision: Add DNS backend option to provision
This option is introduced temporarily to test bind9 backend with
and without dlz_dlopen module.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 05:52:53 +0000 (15:52 +1000)]
s4-provision: exit is not imported directed, use sys.exit
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 05:48:27 +0000 (15:48 +1000)]
s4-provision: Extract dns account creation as separate ldif
MicrosoftDNS container and LDAP entries for root servers will be
added by sambadns.py directly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Jelmer Vernooij [Wed, 7 Sep 2011 18:31:05 +0000 (20:31 +0200)]
samba-tool: Avoid use of "except .. as" construction introduced in python2.6.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Sep 8 00:34:22 CEST 2011 on sn-devel-104
Ira Cooper [Wed, 7 Sep 2011 19:24:22 +0000 (12:24 -0700)]
Fix bug #8442 - NFSv4 DENY ACLs always include SYNCHRONIZE flag - blocking renames.
Thanks to Youzhong Yang for discovering this issue.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 7 22:56:06 CEST 2011 on sn-devel-104
Michael Adam [Wed, 7 Sep 2011 15:38:42 +0000 (17:38 +0200)]
s3:winbind: put winbindd_cache into the state dir, not the cache dir
Despite the name, in winbind offline logon mode, this is a database
that contains valuable information and should not be cleared.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Sep 7 21:17:37 CEST 2011 on sn-devel-104
Gregor Beck [Mon, 5 Sep 2011 15:07:37 +0000 (17:07 +0200)]
s3:dbwrap_ctdb: improve error message in transaction destructor
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Wed, 31 Aug 2011 08:19:18 +0000 (10:19 +0200)]
s3: let g_lock_unlock() return more specific status codes on failure
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 7 Sep 2011 16:08:50 +0000 (18:08 +0200)]
s3: Fix Coverity ID 2611, UNINIT
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Sep 7 19:47:49 CEST 2011 on sn-devel-104
Volker Lendecke [Wed, 7 Sep 2011 16:07:36 +0000 (18:07 +0200)]
s3: Fix Coverity ID 2612, UNINIT
Stefan Metzmacher [Wed, 7 Sep 2011 13:59:05 +0000 (15:59 +0200)]
s3:smb2cli: let smb2cli_req_create() use the give pid, uid and tid values
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 7 18:19:43 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 30 Aug 2011 22:32:48 +0000 (00:32 +0200)]
s3:smb2cli: pass the uid to the SMB2_SESSION_SETUP to support multi-leg-auth
metze
Volker Lendecke [Wed, 7 Sep 2011 12:36:39 +0000 (14:36 +0200)]
talloc: Remove an unused variable
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Sep 7 16:47:26 CEST 2011 on sn-devel-104
Christian Ambach [Wed, 31 Aug 2011 16:28:51 +0000 (18:28 +0200)]
s3:idmap/autorid add a small alloc pool to autorid
this is needed to allocate gids for BUILTIN\Users and
BUILTIN\Administrators
gids are stored at the start of the first domain
as RIDs start with values over 500, we have some room there
so we do not need to allocate a range
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Wed Sep 7 15:15:09 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 7 Sep 2011 02:21:00 +0000 (12:21 +1000)]
s4-s3-upgrade: convert password age policies to the negative NTTIME format
This previously caused all accounts to be locked out.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Sep 7 13:44:44 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 7 Sep 2011 04:43:51 +0000 (14:43 +1000)]
lib/addns: Remove unused TALLOC_ macros
Amitay Isaacs [Wed, 7 Sep 2011 07:22:22 +0000 (17:22 +1000)]
build: Replace mkbuildoptions-waf awk script with waf target
Amitay Isaacs [Tue, 6 Sep 2011 06:15:04 +0000 (16:15 +1000)]
samba-tool: Add --filter option to ldapcmp to ignore specified attributes
Amitay Isaacs [Tue, 6 Sep 2011 06:13:44 +0000 (16:13 +1000)]
s4-kcc: Fix the list of NCs for DRS replica information
AD DNS partitions (DomainDnsZones and ForestDnsZones) are listed
under msDs-hasMasterNCs attribute for post-2003 windows servers.
Stefan Metzmacher [Tue, 6 Sep 2011 12:14:52 +0000 (14:14 +0200)]
s3:smb2_server: return OBJECT_NAME_INVALID if the path is terminated in SMB2_FIND/QUERY_DIRECTORY
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 7 12:15:51 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 6 Sep 2011 12:14:52 +0000 (14:14 +0200)]
s3:smb2_server: return OBJECT_NAME_INVALID if the path is terminated in SMB2_CREATE
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:14:52 +0000 (14:14 +0200)]
s3:smb2_server: return BAD_NETWORK_NAME if the path is terminated in SMB2_TCON
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_write.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_setinfo.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_read.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_notify.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_lock.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_keepalive.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_ioctl.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_getinfo.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_flush.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_find.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_create.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_close.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_break.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_tcon.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_sesssetup.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)]
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_negprot.c
metze
Stefan Metzmacher [Tue, 6 Sep 2011 12:00:04 +0000 (14:00 +0200)]
s3:smb2_server: add smbd_smb2_request_verify_sizes()
metze
Stefan Metzmacher [Wed, 7 Sep 2011 08:32:53 +0000 (10:32 +0200)]
s3:torture: relax TRANS2 midmight time checking
It's possible that the test runs on a full hour, e.g. Tue Sep 6 03:00:00 2011.
So better check that the a_time is different from the current time.
metze
Stefan Metzmacher [Wed, 7 Sep 2011 08:32:53 +0000 (10:32 +0200)]
s4:torture/basic: relax base.trans2 midmight time checking
It's possible that the test runs on a full hour, e.g. Tue Sep 6 03:00:00 2011.
So better check that the a_time is different from the current time.
metze
Stefan Metzmacher [Wed, 7 Sep 2011 06:15:00 +0000 (08:15 +0200)]
s3:smb2cli: fix marshalling of smb2_create_blobs in smb2cli_create()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 7 10:21:55 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: don't terminate the pathname in smb2cli_query_directory()
Windows generates NT_STATUS_OBJECT_NAME_INVALID otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: don't terminate the pathname in smb2cli_create()
Windows generates NT_STATUS_OBJECT_NAME_INVALID otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: don't terminate the pathname in smb2cli_tcon()
Windows generates NT_STATUS_BAD_NETWORK_NAME otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: SMB2_TCON needs one dyn byte to that the structure size check works.
Windows generates NT_STATUS_INVALID_PARAMETER otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: SMB2_WRITE needs one dyn byte to that the structure size check works.
Windows generates NT_STATUS_INVALID_PARAMETER otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: SMB2_READ needs one dyn byte to that the structure size check works.
Windows generates NT_STATUS_INVALID_PARAMETER otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: SMB2_QUERY_DIRECTORY needs one dyn byte to that the structure size check works.
Windows generates NT_STATUS_INVALID_PARAMETER otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: SMB2_CREATE needs one dyn byte to that the structure size check works.
Windows generates NT_STATUS_INVALID_PARAMETER otherwise.
metze
Stefan Metzmacher [Mon, 5 Sep 2011 16:22:57 +0000 (18:22 +0200)]
s3:smb2cli: SMB2_SESSION_SETUP needs one dyn byte to that the structure size check works.
Windows generates NT_STATUS_INVALID_PARAMETER otherwise.
metze
Jeremy Allison [Tue, 6 Sep 2011 21:08:01 +0000 (14:08 -0700)]
Revert "Part 5 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set (Invalid argument)"
This reverts commit
17f6e0272370f764d4a0053c8e74f20b0444c721.
Using the existing default permissions for group access is incorrect
when no such permissions are given in the incoming ACL.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 7 03:50:21 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 5 Sep 2011 22:14:35 +0000 (08:14 +1000)]
s4-s3-upgrade Handle expected errors, error out on unexpected ones
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Sep 7 02:22:56 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 5 Sep 2011 12:38:15 +0000 (22:38 +1000)]
s4-s3-upgrade Fix group member addition
Volker Lendecke [Tue, 6 Sep 2011 16:33:35 +0000 (18:33 +0200)]
s3: Make winbindd_lookup_names static
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Sep 6 20:03:56 CEST 2011 on sn-devel-104