Björn Jacke [Tue, 13 Oct 2009 22:22:08 +0000 (00:22 +0200)]
s3:net: simplify padding to single printf call
Björn Jacke [Tue, 13 Oct 2009 22:19:35 +0000 (00:19 +0200)]
s3:net simplify padding to single printf call
Volker Lendecke [Tue, 13 Oct 2009 13:56:00 +0000 (15:56 +0200)]
s3:net: Fix a segfault in "net rpc trustdom list" for overlong domain names
That was a complicated way to say "%-20.s"... But that code was from 2002 ...
Jeremy Allison [Tue, 13 Oct 2009 20:28:57 +0000 (13:28 -0700)]
Remove use of "int ret" when we already have errcode.
Jeremy.
Jeremy Allison [Tue, 13 Oct 2009 20:03:39 +0000 (13:03 -0700)]
Catch one more erroneous use of errno.
Jeremy.
Olaf Flebbe [Tue, 13 Oct 2009 13:48:19 +0000 (15:48 +0200)]
correctly handle aio_error() and errno
Volker Lendecke [Mon, 12 Oct 2009 15:29:45 +0000 (17:29 +0200)]
s3:torture: Add a notify-bench test
This is a test that creates and deletes files in a directory as fast as the
network allows it. At the same time, it opens a filechangenotify. This test is
done to just torture handling a single directory together with the notify
infrastructure.
Volker Lendecke [Mon, 12 Oct 2009 14:43:19 +0000 (16:43 +0200)]
s3:libsmb: Add cli_notify
Volker Lendecke [Sat, 3 Oct 2009 13:33:12 +0000 (15:33 +0200)]
s3:rpc: Fix is_known_pipename for dynamically loaded pipes
Volker Lendecke [Sun, 4 Oct 2009 14:52:08 +0000 (16:52 +0200)]
s3: Fix some nonempty blank lines
Andrew Tridgell [Wed, 16 Sep 2009 01:22:56 +0000 (03:22 +0200)]
s3: Fix vfs_shadow_copy2 to allow in-path @GMT-xxx
Olaf Flebbe [Tue, 13 Oct 2009 12:13:06 +0000 (14:13 +0200)]
s3/loadparm: Fix severe HPUX compiler issue.
Members of struct should be initialized explictly.
Fixes bug #6804.
Matthias Dieter Wallnöfer [Tue, 13 Oct 2009 15:36:58 +0000 (17:36 +0200)]
s4:hdb-samba4 - Don't double-free "db"
"db" is freed anyway after the destructor terminates so this does really make
no sense here (rather it makes code crash).
Should fix bug #6801.
Matthias Dieter Wallnöfer [Tue, 13 Oct 2009 15:29:52 +0000 (17:29 +0200)]
s4:dcesrv_samr - add another constant
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 22:48:15 +0000 (00:48 +0200)]
s4:dcesrv_samr - prevent "ldb_modify" on a possibly empty message
In this code part under certain circumstances we can end up with an empty message.
Since our new behaviour denies them (like the real AD) we need to bypass them
on LDB modify calls.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 22:45:26 +0000 (00:45 +0200)]
s4:dcesrv_samr - Add additional "talloc_free"s
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 22:15:19 +0000 (00:15 +0200)]
s4:dcesrv_samr - Cosmetics
Make more use of constants and add some braces around "if" blocks
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 21:39:40 +0000 (23:39 +0200)]
s4:ldb_tdb - Revert some introduced "trivial gotos"
I hope that this makes abartlet & simo happy again (consider mailing list).
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 21:25:17 +0000 (23:25 +0200)]
Enhance ".gitignore" file for s4
Günther Deschner [Tue, 6 Oct 2009 16:26:33 +0000 (18:26 +0200)]
s3-winbindd: add wbint_ChangeMachineAccount implementation.
Guenther
Günther Deschner [Tue, 6 Oct 2009 16:20:23 +0000 (18:20 +0200)]
docs: document wbinfo -c.
Guenther
Günther Deschner [Tue, 6 Oct 2009 16:18:00 +0000 (18:18 +0200)]
nsswitch: add wbinfo -c (change trust account passwords).
Guenther
Günther Deschner [Tue, 6 Oct 2009 16:15:08 +0000 (18:15 +0200)]
libwbclient: add wbcChangeTrustCredentials.
Guenther
Günther Deschner [Tue, 13 Oct 2009 10:24:57 +0000 (12:24 +0200)]
docs: document wbinfo -t --domain DOMAIN behavior.
Guenther
Günther Deschner [Wed, 7 Oct 2009 22:34:53 +0000 (00:34 +0200)]
netlogon: add NL_PASSWORD_VERSION to IDL.
Guenther
Günther Deschner [Tue, 13 Oct 2009 08:15:34 +0000 (10:15 +0200)]
s3: use enum netr_SchannelType all over the place.
Guenther
Günther Deschner [Wed, 7 Oct 2009 22:39:40 +0000 (00:39 +0200)]
s3-netlogon: allow to change any type of trust account password in trust_pw_find_change_and_store_it().
Guenther
Andrew Tridgell [Tue, 13 Oct 2009 02:09:07 +0000 (13:09 +1100)]
s4-repl: check that a DsGetNCChanges is a continuation, and fix sorting
When we indicate that a getncchanges request is not complete, we set
the more_data flag to true in the response. The client usually then
asks for the next block of data. If the client decides it wants to
skip that replication and do a different replication then we need to
make sure that the next call is in fact a continuation of the existing
call, and not a new call.
This relies on returning the results sorted by uSNChanged, as the
client uses the tmp_highest_usn in each result to see if progress is
being made.
Andrew Tridgell [Mon, 12 Oct 2009 23:03:57 +0000 (10:03 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Mon, 12 Oct 2009 23:03:27 +0000 (10:03 +1100)]
pidl: don't warn for compatible scalar types in unions
When we have an enum that is used as a union discriminator, what
matters is that the scalar mappings are the same, not if the types are
the same (otherwise we get warnings about uint1632).
Thanks to gd for noticing this.
Günther Deschner [Wed, 7 Oct 2009 22:34:05 +0000 (00:34 +0200)]
s3-netlogon: pass down account name to remote password set functions.
Guenther
Björn Jacke [Mon, 12 Oct 2009 20:37:34 +0000 (22:37 +0200)]
ѕ3: fix domain trust documentation confusion
fix some trusted/trusting mixups, make documentation more precise
and man page more verbose.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 17:21:55 +0000 (19:21 +0200)]
s4:provision.py - simplify the "realm" variable handling a bit
(Remove unneeded "upper"s)
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 15:32:24 +0000 (17:32 +0200)]
s4:objectclass ldb module - Check for empty messages
I think the check for empty messages fits best here.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 14:28:34 +0000 (16:28 +0200)]
s4:wbclient.h - add compatibility constants
This is the result of a discussion on samba-technical on how to deal best with
existing programs which don't support my changes in the interface yet. Metze
pointed out this "defines" as a possibility and simo and I agreed.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 14:19:04 +0000 (16:19 +0200)]
Revert "s4:ldb - add a check which has to be done on beginning of a "modify" operation"
This reverts commit
f9990e9b391f330a8e6c5c158ee4e4eaa50f6176.
abartlet claims that this behaviour is too AD specific to put here. Btw I had
also some doubts if this is clean enough. I put it only here to make "ldap.py"
pass.
I'll try to find a new solution soon.
Günther Deschner [Mon, 12 Oct 2009 12:28:53 +0000 (14:28 +0200)]
s3-docs: remove xml artefact from net.8.xml.
Guenther
Andrew Bartlett [Mon, 12 Oct 2009 09:11:03 +0000 (20:11 +1100)]
s4:ldb Allow a NULL module list
Karolin Seeger [Mon, 12 Oct 2009 10:52:29 +0000 (12:52 +0200)]
s3/proto.h: Add lp_ldap_ref_follow prototype.
Fix build of smbldap.
Karolin
Jan Engelhardt [Mon, 12 Oct 2009 09:34:58 +0000 (11:34 +0200)]
s3/smbldap: add option to disable following LDAP refs
Fix bug #6717.
Andrew Bartlett [Fri, 9 Oct 2009 22:35:39 +0000 (09:35 +1100)]
Allow (and ignore) distinguishedName on special records
They are not stored, so we can ignore them (makes copying records much
easier)
Andrew Bartlett
Andrew Bartlett [Mon, 12 Oct 2009 02:17:09 +0000 (13:17 +1100)]
s4:schema Add some error checking to the schema load
Andrew Bartlett [Mon, 12 Oct 2009 02:10:00 +0000 (13:10 +1100)]
s4:dsdb Make dsdb_read_prefixes_from_ldb static
Andrew Bartlett [Fri, 9 Oct 2009 22:14:37 +0000 (09:14 +1100)]
s4:ldb Reload the 'ltdb_cache' when @OPTIONS changes
(Otherwise setting the check base on search option is not applied
until after a reload).
Andrew Bartlett
Andrew Bartlett [Fri, 9 Oct 2009 22:12:54 +0000 (09:12 +1100)]
s4:ldb Allow a module string of ""
(We may have no modules set)
Andrew Bartlett
Andrew Bartlett [Fri, 9 Oct 2009 22:10:03 +0000 (09:10 +1100)]
s4:dsdb Search for the schema with dsdb_module_search(), in schema_fsmo
This avoids using an ldb_search(), which would run from the top of the
module stack. This will help us load the schema before the partitions
are initialised.
Andrew Bartlett
Andrew Bartlett [Fri, 9 Oct 2009 22:06:07 +0000 (09:06 +1100)]
s4:dsdb Add new functions to help modules do an ldb_search()
These take an ldb_module argument, and avoid doing the search from the
top of the stack again.
(This will help when modules are initialised before being added to the
partition set)
Andrew Bartlett
Andrew Bartlett [Mon, 12 Oct 2009 05:44:19 +0000 (16:44 +1100)]
s4:provision Remove all references to samba4LocalDomain
This was a bad idea all along, as Simo said at the time. With the
full MS schema and enforcement of it, it is an even worse idea.
This fixes the provision of the member server in 'make test'
Andrew Bartlett
Andrew Bartlett [Tue, 6 Oct 2009 03:12:04 +0000 (14:12 +1100)]
s4:provision Clarify that we set, rather than modify, objectGUID values
Andrew Tridgell [Mon, 12 Oct 2009 05:14:02 +0000 (16:14 +1100)]
s4-selftest: don't run benchmarks on the build farm hosts
Andrew Tridgell [Mon, 12 Oct 2009 05:11:53 +0000 (16:11 +1100)]
torture: fixed socket leak in BENCH-TCON test
The BENCH-TCON test was leaving the socket open. A smbclie_tdis()
closes the tree connection, but does not close the socket.
This caused the build farm to run out of file descriptors
Andrew Tridgell [Mon, 12 Oct 2009 02:31:34 +0000 (13:31 +1100)]
scripts: handle non-C files in minimal_includes.pl
Andrew Tridgell [Mon, 12 Oct 2009 02:30:52 +0000 (13:30 +1100)]
s4-drs: make DsBind a bit less verbose
Simo Sorce [Sun, 11 Oct 2009 13:42:59 +0000 (09:42 -0400)]
Fix builds with external tdb
Make sure we do not reference our internal tdb directly.
Let configure define what tdb.h file to use so that builds that use an
extrenal tdb do not include 2 different versions of the tdb header.
Matt Kraai [Thu, 17 Sep 2009 14:07:42 +0000 (07:07 -0700)]
Use the method used by build_env.sh to discover the user name.
so try USERNAME, then LOGNAME, then whoami, then id -un to find out who we
are.
Steven Danneman [Fri, 9 Oct 2009 21:01:33 +0000 (14:01 -0700)]
s4/torture: fix build break "implicit declaration of function 'isprint'"
Volker Lendecke [Fri, 9 Oct 2009 20:58:14 +0000 (22:58 +0200)]
s3: Fix a memleak reported by dmarkey
Simo Sorce [Fri, 9 Oct 2009 17:14:08 +0000 (13:14 -0400)]
Fix builds with external talloc
Make sure we do not reference our internal talloc directly.
Let configure define what talloc.h file to use so that builds that use an
extrenal talloc do not include 2 different versions of the talloc header.
John H Terpstra [Fri, 9 Oct 2009 12:00:11 +0000 (07:00 -0500)]
Change recommended bu PC Oota.
Karolin Seeger [Fri, 9 Oct 2009 09:27:06 +0000 (11:27 +0200)]
asn1_tests: Fix typo in comment.
Karolin
Jeremy Allison [Thu, 8 Oct 2009 22:36:36 +0000 (15:36 -0700)]
Cope with old CIFSFS clients that use SMBunlink to remove
symlinks instead of trans2:posix_unlink.
Jeremy.
Jeremy Allison [Thu, 8 Oct 2009 22:36:24 +0000 (15:36 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Björn Jacke [Thu, 8 Oct 2009 22:21:34 +0000 (00:21 +0200)]
s3: make linking of libwbclient --as-needed safe
Partly fixes #6791. Thanks to Buchan Milne!
Jeremy Allison [Thu, 8 Oct 2009 17:01:51 +0000 (10:01 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
John H Terpstra [Thu, 8 Oct 2009 13:27:21 +0000 (08:27 -0500)]
Fix typos. Thank-you PC Oota.
Volker Lendecke [Thu, 8 Oct 2009 12:02:39 +0000 (14:02 +0200)]
s3: Fix shadow copy display on Windows 7
Windows 7 is a bit more picky on our NT_STATUS_BUFFER_TOO_SMALL. Announce the
right buffer size, the same amount we later check for.
Matthias Dieter Wallnöfer [Thu, 8 Oct 2009 08:57:51 +0000 (10:57 +0200)]
winbind: adapt the new reject constants also there
Please note: in the past the value "0" was misinterpreted as other error. This
isn't true. "0" means no error.
Therefore a solution for this one has to found.
Günther Deschner [Thu, 8 Oct 2009 08:35:02 +0000 (10:35 +0200)]
s3-winbindd: NDR_WBINT_CHECKMACHINEACCOUNT should not be cacheable.
Guenther
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 20:44:00 +0000 (22:44 +0200)]
s3/s4 - Adapt the IDL changes on various locations
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 20:41:14 +0000 (22:41 +0200)]
s3/s4:samr.idl - Corrects the "userPwdChangeFailureInformation" structure
This I've done according to WSPP doc MS-SAMR 2.2.7.23.
Jeremy Allison [Wed, 7 Oct 2009 23:52:29 +0000 (16:52 -0700)]
Exteded RAW-RENAME test to catch regressions in bug 6781.
Jeremy.
Jeremy Allison [Wed, 7 Oct 2009 22:43:43 +0000 (15:43 -0700)]
Oops. Don't break the build..
Jeremy.
Jeremy Allison [Wed, 7 Oct 2009 22:39:38 +0000 (15:39 -0700)]
Make the logic a lot clearer and fix the comment to match.
Jeremy
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 07:28:38 +0000 (09:28 +0200)]
s4:ldb - SQLite: port some constraints from the TDB backend also to the SQLITE one
Matthias Dieter Wallnöfer [Wed, 7 Oct 2009 10:38:00 +0000 (12:38 +0200)]
s4:subtree_delete - Make the initialisation of the child counter more clear
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 15:18:04 +0000 (17:18 +0200)]
s4:ldap.py - Further enhancements
- Enhance test for "distinguishedName"
- Add a test for single-valued attributes
- Add a test for multi-valued attributes
- Add a test for empty messages
- Add a test for empty attributes
Matthias Dieter Wallnöfer [Wed, 7 Oct 2009 21:49:29 +0000 (23:49 +0200)]
s4:ldb - add a check which has to be done on beginning of a "modify" operation
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 19:53:05 +0000 (21:53 +0200)]
s4:ldap server - remove unused error handlings
Those error cases should be handled by LDB itself to be available on all
connection methods and not only over LDAP.
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 07:30:53 +0000 (09:30 +0200)]
s4:ldb_tdb - Rework/Various
- Unify the error handling method with "done" mark in all longer functions
- Fix up result codes to match more the real MS AD
- Some cosmetic fixups
Jeremy Allison [Wed, 7 Oct 2009 22:14:50 +0000 (15:14 -0700)]
Correct fix for bug 6781 - Cannot rename subfolders in Explorer view with recent versions of Samba.
Without this fix, renaming a directory ./a to ./b, whilst a directory ./aa was already open
would fail.
Jeremy.
Aravind Srinivasan [Wed, 7 Oct 2009 03:16:38 +0000 (20:16 -0700)]
s4/torture: Ported SMBv1 RAW-OPEN tests to SMB2-CREATE
Four tests were ported from raw/open.c
One new tests added LEADING-SLASH, which tests that a server provides
the proper error when a relative path is given to a CREATE PDU
with a leading "/".
Aravind Srinivasan [Wed, 7 Oct 2009 03:12:09 +0000 (20:12 -0700)]
s4/torture: convert all printf to torture_comments
Aravind Srinivasan [Wed, 7 Oct 2009 03:25:15 +0000 (20:25 -0700)]
s4/torture: Ported SMBv1 RAW-STREAMS tests to SMB2-STREAMS
Kai Blin [Wed, 7 Oct 2009 13:45:17 +0000 (15:45 +0200)]
AD-Bench: A first go at an Active Directory benchmark.
Günther Deschner [Tue, 6 Oct 2009 15:46:25 +0000 (17:46 +0200)]
s3-winbindd: libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials().
Guenther
Günther Deschner [Wed, 7 Oct 2009 08:43:53 +0000 (10:43 +0200)]
wbinfo: allow to check trusts via "wbinfo -t --domain DOMAINNAME".
Guenther
Günther Deschner [Tue, 6 Oct 2009 15:45:24 +0000 (17:45 +0200)]
libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials().
Guenther
Günther Deschner [Tue, 6 Oct 2009 15:50:15 +0000 (17:50 +0200)]
s3-netlogon: pure cosmetic indent fixes in _netr_LogonControl2Ex().
Guenther
Günther Deschner [Wed, 7 Oct 2009 08:34:15 +0000 (10:34 +0200)]
s3: re-run make samba3-idl.
Guenther
Andrew Tridgell [Wed, 7 Oct 2009 05:21:28 +0000 (16:21 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Wed, 7 Oct 2009 05:20:16 +0000 (16:20 +1100)]
s4-drs: fixed a memory error introduced yesterday
ids is retrurned via _ids, so it needs to be on the passed in mem_ctx
Steven Danneman [Sat, 3 Oct 2009 00:02:20 +0000 (17:02 -0700)]
s4/torture: Add server target of OneFS
I've added a "--target=onefs" which lists expected deviation in the
OneFS SMB server implementation compared to a Windows machine.
I've added this in a generic way using a list of module specific
parameters. This list currently only contains the absence of
SACL support but will be added to as additional server differences
are defined.
I'd liked to use this abstraction for defining the differences between
a WinXP and Win7 server as well.
Aravind Srinivasan [Tue, 6 Oct 2009 23:57:34 +0000 (16:57 -0700)]
s4/torture: Add SMB sharemode/access mask tests
Test several thousand permutations of create mask and sharemodes on file
and directory opens.
These tests use a checked-in results table derived from a WinXP server to
verify correct server behavior.
CREATEX_ACCESS
CREATEX_SHAREMODES_FILE
CREATEX_SHAREMODES_DIR
MAXIMUM_ALLOWED
Aravind Srinivasan [Tue, 6 Oct 2009 23:43:43 +0000 (16:43 -0700)]
s4/torture: change comments to torture_failures
This allows the frameworks that wrap smbtorture to detect errors
better.
Jeremy Allison [Wed, 7 Oct 2009 00:18:15 +0000 (17:18 -0700)]
Test creating and deleting a bad symlink using the POSIX calls. Ensure
we don't regress on bug 6769.
Jeremy.
Andrew Tridgell [Tue, 6 Oct 2009 23:55:35 +0000 (10:55 +1100)]
torture: disable the ValidatePassword test
This test causes problems on non-sealed connections against windows
Andrew Tridgell [Tue, 6 Oct 2009 23:05:26 +0000 (10:05 +1100)]
s4-torture: removed an accidental commit of a local test hack
Sorry about that ....
Andrew Tridgell [Tue, 6 Oct 2009 19:39:03 +0000 (06:39 +1100)]
tdr: teach TDR about uint1632 enums
TDB doesn't have NDR64, but it needs to know how to map the new types
from pidl
Andrew Tridgell [Tue, 6 Oct 2009 09:49:14 +0000 (20:49 +1100)]
pidl: update PIDL tests for uint1632 enums
Andrew Tridgell [Tue, 6 Oct 2009 09:47:42 +0000 (20:47 +1100)]
idl: recompile IDL for uint1632 change