metze/samba/wip.git
11 years agobuild: Update config.guess 2012-12-30 and config.sub to 2013-01-11
Mathieu Parent [Sun, 13 Jan 2013 13:15:20 +0000 (14:15 +0100)]
build: Update config.guess 2012-12-30 and config.sub to 2013-01-11

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
(This used to be ctdb commit 3c6a9b73364c9543366fa033c778145dc7a152a9)

11 years agodoc: allows to -> allows one to
Mathieu Parent [Sat, 12 Jan 2013 15:43:03 +0000 (16:43 +0100)]
doc: allows to -> allows one to

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
(This used to be ctdb commit 95fc493a7d4145f976cb3fe928d9e92faec4dd71)

11 years agobuild: Add missing LDFLAGS
Mathieu Parent [Sat, 12 Jan 2013 14:14:48 +0000 (15:14 +0100)]
build: Add missing LDFLAGS

Original Author: Simon Ruderich <simon@ruderich.org>

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
(This used to be ctdb commit 506ecd186759675a1cf50a0a05a285fee03fc51e)

11 years agoChanges for unobtrusive recovery and new method for health check.
Srikrishan Malik [Wed, 9 Jan 2013 10:41:39 +0000 (16:11 +0530)]
Changes for unobtrusive recovery and new method for health check.

Unobtrusive recovery: Ganesha will not be restarted on failovers.

Ganesha health: Use the counters in /var/lib/nfs/ganesha_local to track progress
instead of the null call which can timeout if the server is too busy.

Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
Signed-off-by: Lance Russell <lancerus@us.ibm.com>
(This used to be ctdb commit 0e651e9da0f1f3c836b4474612ab13d0ccd272d9)

11 years agorecoverd: Create recoverd monitoring timed events off recoverd context
Amitay Isaacs [Wed, 9 Jan 2013 05:22:39 +0000 (16:22 +1100)]
recoverd: Create recoverd monitoring timed events off recoverd context

This ensures that when shutting down CTDB, all the timed events
associated with monitoring recoverd are destroyed and recoverd
is not restarted.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 7393e2b290f9879ff72d5c5a9ce933034129f0e8)

11 years agodaemon: Protect against double free of callback state while shutting down
Amitay Isaacs [Mon, 29 Oct 2012 03:56:10 +0000 (14:56 +1100)]
daemon: Protect against double free of callback state while shutting down

When CTDB is shut down and monitoring has been stopped, monitor_context
gets freed and all the callback states hanging off it.  This includes
callback state for current_monitor, if the current monitor event has
not yet finished.  As a result, when the shutdown event is called,
current_monitor->callback state is not NULL, but it's actually freed
and it's a dangling reference.

So before executing callback function and freeing callback state check
if ctdb->monitor->monitor_context is not NULL.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 7d8546ee4353851f0543d0ca2c4c67cb0cc75aea)

11 years agodaemon: On shutdown, destroy timed events that check if recoverd is active
Amitay Isaacs [Tue, 4 Dec 2012 04:05:44 +0000 (15:05 +1100)]
daemon: On shutdown, destroy timed events that check if recoverd is active

When CTDB is shutting down, recovery daemon is stopped, but the
event that checks if recovery daemon is still alive is not destroyed.
So recovery master is restarted during shutdown if CTDB daemon takes
longer to shutdown.

There are two processes that check if recovery daemon is working.

1. ctdb_check_recd() - which checks every 30 seconds if the recovery
   daemon process exists.

2. ctdb_recd_ping_timeout() - which is triggered when recovery daemon
   fails to ping CTDB daemon.

Both the events are periodic and need to be destroyed when shutting down.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 746168df2e691058e601016110fae818c6a265c3)

11 years agotests: Add a test for recovery of persistent databases
Amitay Isaacs [Tue, 18 Dec 2012 01:52:39 +0000 (12:52 +1100)]
tests: Add a test for recovery of persistent databases

Ensure that RSN based recovery and __db_sequence_number__ based recovery
methods for persistent databases work correctly.  They should not cause
corruption of the database.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 45d439a1ab093b420c27b1502ef109021833c7af)

11 years agotools/ctdb: Add setdbseqnum command to set __db_sequence_number__
Amitay Isaacs [Wed, 19 Dec 2012 04:14:42 +0000 (15:14 +1100)]
tools/ctdb: Add setdbseqnum command to set __db_sequence_number__

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit efaac27a9ed52ed0f436c7e194013fd06e8b02b3)

11 years agotools/ctdb: Re-factor code to check if db exists given name or id
Amitay Isaacs [Wed, 19 Dec 2012 03:43:26 +0000 (14:43 +1100)]
tools/ctdb: Re-factor code to check if db exists given name or id

Most of the commands related to database operations can now use the
common code (db_exists()) to refer to database with either name or id.

In addition to return db_id for db_name, the function returns all the
flags set for the database.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit ca6e7eccc90f2869c220231666bf284798342bce)

11 years agotools/ctdb: Add pdelete command to delete a record from persistent database
Amitay Isaacs [Mon, 17 Dec 2012 03:46:14 +0000 (14:46 +1100)]
tools/ctdb: Add pdelete command to delete a record from persistent database

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit d23adec89b69e7c6f96c8e1417ef4ca4c9edc57e)

11 years agodaemon: Update the comment and remove redundant check in ctdb_start_transport()
Amitay Isaacs [Tue, 4 Dec 2012 03:58:30 +0000 (14:58 +1100)]
daemon: Update the comment and remove redundant check in ctdb_start_transport()

ctdb_start_transport() is called just before "setup" event, when CTDB
is ready to process the requests. "startup" event happens much later
after a successful recovery.

Transport method ctdb->methods is successfully initialized before
ctdb_start_transport() is called.  No need to check again.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 9a70a4d23d00f6cb996c061ba3dfb7c47b4f6a4f)

11 years agoeventscripts: Fail the setup event if CTDB does not become ready
Martin Schwenke [Tue, 8 Jan 2013 05:49:56 +0000 (16:49 +1100)]
eventscripts: Fail the setup event if CTDB does not become ready

Currently it silently continues without attempting to set tunables.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 735ec99b99c7bb579851ce8293011aaf1dcc552a)

11 years agoscripts: Make script_log() use supplied message, stop logger from hanging
Martin Schwenke [Fri, 4 Jan 2013 02:52:01 +0000 (13:52 +1100)]
scripts: Make script_log() use supplied message, stop logger from hanging

When using syslog any provided message arguments are ignored and not
passed to logger.  This means that logger blocks waiting on stdin.
That's bad.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 50abf597cefe6f8ea2a2ff7694bf84641344a9b1)

11 years agoscripts: Rework ctdb-crash-cleanup.sh so that it uses existing functions
Martin Schwenke [Fri, 4 Jan 2013 00:41:03 +0000 (11:41 +1100)]
scripts: Rework ctdb-crash-cleanup.sh so that it uses existing functions

This improves maintainability.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit e2aaa64925cca359c71520e01a18fc9461b0da4d)

11 years agoscripts: Make drop_all_public_ips() more robust
Martin Schwenke [Fri, 4 Jan 2013 00:23:29 +0000 (11:23 +1100)]
scripts: Make drop_all_public_ips() more robust

Incorporate some of the logic from ctdb-crash-cleanup.sh that ensures
IPs are deleted even if they have the wrong netmask or are on the
wrong interface.

Factoring out some of the code will allow it to be used elsewhere.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 03356fd5ae7a3ac35fde0289cbea7c71ecf07367)

11 years agoctdbd: Default value for debug_hung_script should use ETCDIR
Martin Schwenke [Thu, 3 Jan 2013 05:02:52 +0000 (16:02 +1100)]
ctdbd: Default value for debug_hung_script should use ETCDIR

That is, it should use whatever was specified in ./configure and
should not hardcode /etc.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 13e5e609b262847b607e7af7e0685f44e7cb8e36)

11 years agoscripts: debug-hung-script.sh doesn't need functions/loadconfig
Martin Schwenke [Thu, 3 Jan 2013 04:33:57 +0000 (15:33 +1100)]
scripts: debug-hung-script.sh doesn't need functions/loadconfig

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 8507303b525d20c74e8ec4e7c4f5f275945cd3b6)

11 years agoscripts: statd-callout should calculate CTDB_BASE if it is not set
Martin Schwenke [Thu, 3 Jan 2013 04:33:10 +0000 (15:33 +1100)]
scripts: statd-callout should calculate CTDB_BASE if it is not set

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 376015ba5ad6b7703ae9949a1d40a0c72dfaba0c)

11 years agoeventscripts: Each script should set CTDB_BASE if it is not set
Martin Schwenke [Thu, 3 Jan 2013 04:26:12 +0000 (15:26 +1100)]
eventscripts: Each script should set CTDB_BASE if it is not set

This makes it easier to run the scripts externally.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 740ea8ea5084149c8b552a01ee1c98c558b12384)

11 years agoscripts: Move drop_all_public_ips() to the functions file
Martin Schwenke [Thu, 3 Jan 2013 04:07:07 +0000 (15:07 +1100)]
scripts: Move drop_all_public_ips() to the functions file

... so it can be improved and used elsewhere.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit b23c30253cc9eb274b895cac0f8c65245ba0a200)

11 years agotests/simple: Add test to check recovery daemon IP verification
Martin Schwenke [Fri, 12 Oct 2012 05:12:38 +0000 (16:12 +1100)]
tests/simple: Add test to check recovery daemon IP verification

Also update ips_are_on_nodeglob() to handle negation.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 13a5944f8a27d43006acfffba76958693cae7702)

11 years agotests/eventscripts: Ratchet down debug level for ctdb_takeover_tests
Martin Schwenke [Mon, 7 Jan 2013 23:21:49 +0000 (10:21 +1100)]
tests/eventscripts: Ratchet down debug level for ctdb_takeover_tests

The default IP allocation algorithm used by ctdb_takeover_tests
changed from "non-deterministic IPs" to "LCP2".  The latter generates
a lot more debug output.  ctdb_takeover_tests is used by the ctdb tool
stub to calculate IP address changes for failovers.  This resulted in
unexpected debug output that caused tests to fail.  Since eventscript
tests don't care how IP allocations are arrived at, the best solution
is to turn down the debug level.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 3cc596d2b459d834f9785b3a98027e46431ff2b9)

11 years agorecoverd: Separate each IP allocation algorithm into its own function
Martin Schwenke [Fri, 14 Dec 2012 06:12:01 +0000 (17:12 +1100)]
recoverd: Separate each IP allocation algorithm into its own function

This makes the code much more readable and maintainable.

As a side effect, fix a memory leak in LCP2.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 6a1d88a17321f7e1dc84b4823d5e7588516a6904)

11 years agorecoverd: New function unassign_unsuitable_ips()
Martin Schwenke [Thu, 13 Dec 2012 02:23:32 +0000 (13:23 +1100)]
recoverd: New function unassign_unsuitable_ips()

Move the code into a new function so it can be called from a number of
places.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 8adb255e62dbe60d1e983047acd7b9c941231d11)

11 years agorecoverd: Move failback retry loop into basic_failback() and lcp2_failback()
Martin Schwenke [Thu, 13 Dec 2012 01:15:32 +0000 (12:15 +1100)]
recoverd: Move failback retry loop into basic_failback() and lcp2_failback()

The retry loop is currently in ctdb_takeover_run_core().  Pushing it
into each function will make it possible to put each algorithm into a
separate top-level function.  This will make the code much clearer and
more maintainable.

Also keep associated test code compatible.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit f6ce18d011dd9043b04256690d826deb2640cd89)

11 years agorecoverd: Trying to failback more IPs no longer allocates unassigned IPs
Martin Schwenke [Tue, 11 Dec 2012 04:49:17 +0000 (15:49 +1100)]
recoverd: Trying to failback more IPs no longer allocates unassigned IPs

Neither basic_failback() nor lcp2_failback() unassign IPs anymore, so
there's no point looping back that far.

Also fix a unit test that now fails because looping back to handle
unassigned IPs is no longer logged.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit c09aeaecad7d3232b1c07bab826b96818756f5e0)

11 years agorecoverd: basic_failback() can call find_takeover_node() directly
Martin Schwenke [Tue, 11 Dec 2012 04:43:36 +0000 (15:43 +1100)]
recoverd: basic_failback() can call find_takeover_node() directly

Instead of unassigning, looping back and depending on
basic_allocate_unassigned.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 4dc08e37dec464c8785a2ddae15c7c69d3c81ac3)

11 years agorecoverd: Don't do failback at all when deterministic IPs are in use
Martin Schwenke [Tue, 11 Dec 2012 04:01:12 +0000 (15:01 +1100)]
recoverd: Don't do failback at all when deterministic IPs are in use

This seems to be the right thing to do instead of calling into the
failback code and continually skipping the release of an IP.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 4c87e7cb3fa2cf2e034fa8454364e0a7fe0c8f81)

11 years agorecoverd: Move the test for both 'DeterministicIPs' and 'NoIPFailback' set
Martin Schwenke [Fri, 14 Dec 2012 06:10:41 +0000 (17:10 +1100)]
recoverd: Move the test for both 'DeterministicIPs' and 'NoIPFailback' set

If this is done earlier then some other logic can be improved.  Also,
this should be a warning since no error condition is set.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit e06476e07197b7327b8bdac9c0b2e7281798ffec)

11 years agorecoverd: Fix a memory leak in IP allocation
Martin Schwenke [Fri, 14 Dec 2012 06:10:05 +0000 (17:10 +1100)]
recoverd: Fix a memory leak in IP allocation

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit bcd5f587aff3ba536cb0b5ef00d2d802352bae25)

11 years agotests/takeover: Add some LCP2 tests for case when no node are healthy
Martin Schwenke [Thu, 20 Dec 2012 05:27:27 +0000 (16:27 +1100)]
tests/takeover: Add some LCP2 tests for case when no node are healthy

3 tests should assign IPs to all nodes.

3 tests set NoIPTakeoverOnDisabled=1 and should drop all IPs.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit edda58a45915494027785608126b5da7c98fee85)

11 years agotests/takeover: Initial tests for deterministic IPs
Martin Schwenke [Thu, 20 Dec 2012 05:26:42 +0000 (16:26 +1100)]
tests/takeover: Initial tests for deterministic IPs

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 5c820b2398a42af0e94bc524854a1ad144a63f7b)

11 years agotests/takeover: Do output filtering for deterministic IPs algorithm too
Martin Schwenke [Thu, 20 Dec 2012 05:25:53 +0000 (16:25 +1100)]
tests/takeover: Do output filtering for deterministic IPs algorithm too

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 98bd58a98d34ecca89c9042417d7527a18a5ecf9)

11 years agotests/takeover: Support testing of NoIPTakeoverOnDisabled
Martin Schwenke [Thu, 20 Dec 2012 05:24:58 +0000 (16:24 +1100)]
tests/takeover: Support testing of NoIPTakeoverOnDisabled

Via $CTDB_SET_NoIPTakeoverOnDisabled.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit d357d52dbd533444a4af6151d04ba119a1533068)

11 years agotests/takeover: IP allocation now selected via $CTDB_IP_ALGORITHM
Martin Schwenke [Thu, 20 Dec 2012 03:52:05 +0000 (14:52 +1100)]
tests/takeover: IP allocation now selected via $CTDB_IP_ALGORITHM

Default to LCP2, like ctdbd.  Also support "det" for deterministic
IPs.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 20631f5f29859920844dd8f410e24917aabd3dfd)

11 years agotests/takeover: Support valgrinding the takeover code
Martin Schwenke [Thu, 13 Dec 2012 09:29:22 +0000 (20:29 +1100)]
tests/takeover: Support valgrinding the takeover code

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 06ad6b8a19f830472b0ed65cb52e7c3ea74ed1dc)

11 years agotests: new simple integration test for delip interface garbage collection
Martin Schwenke [Fri, 30 Nov 2012 05:38:08 +0000 (16:38 +1100)]
tests: new simple integration test for delip interface garbage collection

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 1a5410e8349cdb96fdc51aa5ecd4f5734f6798a5)

11 years agotests: new function ip2ipmask() for integration testing
Martin Schwenke [Fri, 30 Nov 2012 05:37:28 +0000 (16:37 +1100)]
tests: new function ip2ipmask() for integration testing

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 8164d9b29bf9080ccc76b1305fb6c07f1ed61d55)

11 years agoctdbd: Clean up orphaned interfaces when an IP is deleted
Martin Schwenke [Fri, 23 Nov 2012 09:09:07 +0000 (20:09 +1100)]
ctdbd: Clean up orphaned interfaces when an IP is deleted

Add a new function ctdb_remove_orphaned_ifaces() and call it in
ctdb_control_del_public_address().

ctdb_remove_orphaned_ifaces() uses a naive implementation that does
things in a very obvious way.  There are many ways to improve the
performance - some are mentioned in a comment in the code.  However, I
doubt that this will be a bottleneck even with a large number of
public IPs.  Running the eventscript is likely to outweigh the cost of
this cleanup.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>

(This used to be ctdb commit cc1a3ae911d3fee8b87fda5de5ab6d9499d7510a)

11 years agotests/complex: Add NFS test when CTDB is killed on one of the nodes
Amitay Isaacs [Mon, 7 Jan 2013 01:00:34 +0000 (12:00 +1100)]
tests/complex: Add NFS test when CTDB is killed on one of the nodes

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit b849fb4923d6a34141fe19006a974de81508ceda)

11 years agoEventscripts: Change the default reconfigure action to do nothing
Martin Schwenke [Tue, 4 Dec 2012 04:00:44 +0000 (15:00 +1100)]
Eventscripts: Change the default reconfigure action to do nothing

A default action of restarting the service doesn't obey the principle
of least surprise.  It cause the NFS service to be implicitly
reintroduced.

This allows no-op functions to be removed from some eventscripts and
service restart functions to be added to others.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit c75b5e5b4d000f5c7dab403df8238ceed390c1c0)

11 years agoEventscripts: Do not restart NFS on reconfigure
Martin Schwenke [Tue, 4 Dec 2012 03:52:25 +0000 (14:52 +1100)]
Eventscripts: Do not restart NFS on reconfigure

It looks like this restart was accidentally reintroduced in commit
fc0678d351187cfa4c71123f97c0f493aacd5d16 when $service_reconfigure
became unset so the default action of restarting the service would
occur.  From there cleanups have explicitly reintroduced it and
carried it through the code.

Also update the unit tests affected by this change.

The restart was originally removed in commit
bc481c3f1a44c50648488c4f8a7f15ec395d446f.

The default reconfigure action of restarting a service is clearly
suboptimal and will be addressed in a separate patch.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 2629de72e1f37b5e46772c2ef8d8d0012fc4ed37)

11 years agoctdbd: Initialise the node flags in just one place
Martin Schwenke [Tue, 4 Dec 2012 03:28:06 +0000 (14:28 +1100)]
ctdbd: Initialise the node flags in just one place

Currently flags are initialised in 2 places.  One of them is in
ctdb_tcp_listen_automatic(), which just seems wrong.  This makes the
code easier to follow by just doing it in ctdb_start_daemon().

This means that the flags are now initialised later than previously.
However, it is still done before the transport is started and before
clients can connect.

In future it might make sense to do a similar thing with setting the
PNN.  However, the current optimisation is reasonably obvious...

Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>

(This used to be ctdb commit 2bbee8ac23ad5b7adf7122d8c91d5f0d54582507)

11 years agoctdbd: Remove debug option --node-ip, use --listen instead
Martin Schwenke [Mon, 3 Dec 2012 04:44:12 +0000 (15:44 +1100)]
ctdbd: Remove debug option --node-ip, use --listen instead

This effectively reverts d96cb02c2c24f9eabbc53d3d38e90dea49cff3e0

Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>

(This used to be ctdb commit 496387a585b2c5778c808cf02b8e1435abde4c3e)

11 years agotests: Local daemons should use --listen instead of --node-ip
Martin Schwenke [Mon, 3 Dec 2012 04:32:49 +0000 (15:32 +1100)]
tests: Local daemons should use --listen instead of --node-ip

Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>

(This used to be ctdb commit 3221fce9ee2f6fdd3bb17a5e1629ad52a32f90d6)

11 years agoInitscript: when checking status, print output of "ctdb ping" if it fails
Martin Schwenke [Fri, 30 Nov 2012 01:59:35 +0000 (12:59 +1100)]
Initscript: when checking status, print output of "ctdb ping" if it fails

At the moment the caller has no idea why it thinks CTDB isn't running
and we can't debug failures...

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 776590bf84d221092298346a28d7fc0552a67c9d)

11 years agoctdb:recover: fix a comment typo
Michael Adam [Tue, 20 Nov 2012 10:20:34 +0000 (11:20 +0100)]
ctdb:recover: fix a comment typo

Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit 5067392d2e06795559f25828b65c129608b65c0b)

11 years agoevents/50.samba: fix testparm background update
Michael Adam [Fri, 21 Dec 2012 16:52:57 +0000 (11:52 -0500)]
events/50.samba: fix testparm background update

creating the smb.conf cache with "-v" results in a cache file
that fails to load with "testparm -s ..." later on due to
"copy = " not being processable. (Copying the empty service name fails).

Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit 81788cfabe960497b050c5ee4e4e487ee061012a)

11 years agodaemon: Add a tunable to enable automatic database priority setting
Amitay Isaacs [Fri, 4 Jan 2013 03:32:55 +0000 (14:32 +1100)]
daemon: Add a tunable to enable automatic database priority setting

Samba versions 3.6.x and older do not set the database priority.
This can cause deadlock between Samba and CTDB since the locking order
of database will be different. A hack was added for automatic promotion
of priority for specific databases to avoid deadlock.  This code should
not be invoked with Samba version 4.x which correctly specifies the
priority for each database.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit 4a9e96ad3d8fc46da1cd44cd82309c1b54301eb7)

11 years agodaemon: Check if log_latency_ms is set before using it
Amitay Isaacs [Fri, 30 Nov 2012 01:21:30 +0000 (12:21 +1100)]
daemon: Check if log_latency_ms is set before using it

This fixes a bug where wrong variable is checked.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit f81e9add466b1d9b2796c09c6ba63b77296ea149)

11 years agoGit should ignore generated include/version.h file
Martin Schwenke [Fri, 23 Nov 2012 01:51:47 +0000 (12:51 +1100)]
Git should ignore generated include/version.h file

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 905cd1293aa97dc7839a59b4f68eca02981f0891)

11 years agovacuum: Avoid some tallocs in ctdb recovery
Volker Lendecke [Thu, 22 Nov 2012 14:27:51 +0000 (15:27 +0100)]
vacuum: Avoid some tallocs in ctdb recovery

In a heavily loaded and volatile database a lot of SCHEDULE_FOR_DELETION
requests can come in between fast vacuuming runs. This can lead to
significant ctdb cpu load due to the cost of doing talloc_free. This
reduces the number of objects a bit by coalescing the two objects
of delete_record_data into one. It will also avoid having to allocate
another talloc header for a SCHEDULE_FOR_DELETION key. Not the full fix
for this problem, but it might contribute a bit.

(This used to be ctdb commit 9a02f61547ddf74629aca21639d8fb61c1df7cbb)

11 years agodoc: Update ping_pong documentation to add -c option
Amitay Isaacs [Wed, 21 Nov 2012 06:03:37 +0000 (17:03 +1100)]
doc: Update ping_pong documentation to add -c option

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit d05faf294e58e22ae3fbc76162258f1ae8178129)

11 years agoutils:ping_pong: add a -c switch to check the lock before reading/writing
Michael Adam [Tue, 6 Nov 2012 00:26:05 +0000 (01:26 +0100)]
utils:ping_pong: add a -c switch to check the lock before reading/writing

This is to verify that the fcntl F_GETLK call reports F_UNLCK if called
from a process already holding a lock. This is for example used by samba's
strict locking code in combination with "posix locking = true".

Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit 4f42d17b74ce891691eee1cead498959cc8e4837)

11 years agorecovery: data corruption of persistent DBs after recoveries: don't delete emtpy...
Michael Adam [Mon, 19 Nov 2012 16:28:03 +0000 (17:28 +0100)]
recovery: data corruption of persistent DBs after recoveries: don't delete emtpy records

The record-by-record mode of recovery deletes empty records.
For persistent databases, this can lead to data corruption
by deleting records that should be there:

- Assume the cluster has been running for a while.

- A record R in a persistent database has been created and
  deleted a couple of times, the last operation being deletion,
  leaving an empty record with a high RSN, say 10.

- Now a node N is turned off.

- This leaves the local database copy of D on N with the empty
  copy of R and RSN 10. On all other nodes, the recovery has deleted
  the copy of record R.

- Now the record is created again while node N is turned off.
  This creates R with RSN = 1 on all nodes except for N.

- Now node N is turned on again. The following recovery will chose
  the older empty copy of R due to RSN 10 > RSN 1.

==> Hence the record is gone after the recovery.

On databases like Samba's registry, this can damage the higher-level
data structures built from the various tdb-level records.

This patch fixes that problem by not deleting empty records in recoveries
for persistent databases.

Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit 6860c79aea416f56cfd7a6af790bbdf495dbc54e)

11 years agorecoverd: fix a comment typo
Michael Adam [Mon, 19 Nov 2012 16:20:11 +0000 (17:20 +0100)]
recoverd: fix a comment typo

Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit 909269a4a3690e1245117ca1af935401455785e6)

11 years agovacuum: fix a comment typo
Michael Adam [Fri, 16 Nov 2012 13:33:41 +0000 (14:33 +0100)]
vacuum: fix a comment typo

Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be ctdb commit bab744e3c49efef2e05dc09e8ea9bd3e3fa58716)

11 years agoEventscripts: 10.interface should list configured interfaces
Martin Schwenke [Fri, 16 Nov 2012 09:21:15 +0000 (20:21 +1100)]
Eventscripts: 10.interface should list configured interfaces

The current code lists available interfaces.  If IPs are configured in
some other way than the public addresses file (e.g. ctdb addip) and their
interfaces default to being marked down then, since down interfaces are
not available, these interfaces can never be marked up.

The configured interfaces should be listed instead.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit d8f010355b715e49709836e057a5d0f110919897)

11 years agoctdbd: Make the link status of new interfaces more flexible
Martin Schwenke [Fri, 16 Nov 2012 08:43:14 +0000 (19:43 +1100)]
ctdbd: Make the link status of new interfaces more flexible

Neither up nor down is a good default value for the link status of a
new interface.  Up means that IPs can be assigned to interfaces before
the true state is known and they can move away quickly if the interface
is actually down.  Down means that IPs can't be assigned to an interface
for a variable amount of time - until a monitor cycle occurs - and this
can result in imbalanced IPs.

This is a neat compromise.  Before the startup event completes, IPs
can't be assigned to interfaces because all interfaces begin in a down
state.  As soon as the startup event completes, IPs can be allocated
to any interface that has been marked up by the eventscript.  Later,
during normal operation, newly added IPs can be assigned to new
interfaces immediately.  The IPs will still move away if an interface
is noticed to be down in the next monitor cycle, but that is the
exception rather than the rule.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 9275a69a414482f1053ae14528d5972575b9214e)

11 years agolocking: Do not use RECLOCK for tracking DB locks and latencies
Amitay Isaacs [Wed, 14 Nov 2012 04:51:59 +0000 (15:51 +1100)]
locking: Do not use RECLOCK for tracking DB locks and latencies

RECLOCK is for recovery lock in CTDB. Do not override the meaning for
tracking locks on databases.  Database lock latency has nothing to do
with recovery lock latency.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 54e24a151d2163954e5a2a1c0f41a2b5c19ae44b)

11 years agotools/ctdb: Do not use function return value as pnn
Amitay Isaacs [Tue, 6 Nov 2012 06:06:54 +0000 (17:06 +1100)]
tools/ctdb: Do not use function return value as pnn

This fixes the wrong code where same variable 'ret' is used to track the pnn
and the return value of a function call.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 718233c445cd6627ab3962b6565c2655f1f8efd0)

11 years agorecoverd: Track the nodes that fail takeover run and set culprit count
Amitay Isaacs [Tue, 23 Oct 2012 05:23:12 +0000 (16:23 +1100)]
recoverd: Track the nodes that fail takeover run and set culprit count

If any of the nodes fail takeover run (either due to timeout or failure
to complete within takeover_timeout interval) from main loop, recovery
master will give up trying takeover run with following message:

  "Unable to setup public takeover addresses. Try again later"

And as a side-effect the monitoring is disabled on all the nodes. Before
ctdb_takeover_run() is called from main loop, monitoring get disabled via
startrecovery event. Since ctdb_takeover_run() fails, it never runs
recovered event and monitoring does not get re-enabled.

In main_loop, ctdb_takeover_run() is called with a takeover_fail_callback.
This callback will get called if any of the nodes fail in handling
takeip/releaseip/ipreallocated events in ctdb_takeover_run().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit a5c6bb1fffb8dc3960af113957a1fd080cc7c245)

11 years agoEventscripts: 10.interface startup event should only process interfaces once
Martin Schwenke [Tue, 13 Nov 2012 23:37:15 +0000 (10:37 +1100)]
Eventscripts: 10.interface startup event should only process interfaces once

Provided that monitor_interfaces() sets the state of each interface,
there's no need to mark all interfaces as up before running
monitor_interfaces() in the startup event.  monitor_interfaces() will
set the true status of each interface anyway.  The duplication is
unnecessary and may cause extra action in the recovery daemon because
the state of some interfaces is changed an extra time.

Instead, add a comment at the top of the loop in monitor_interfaces()
to warn against early loop exits.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit f243a916ee71013f7402b9c396c2ead88eb3aab0)

11 years agobuild: Fix the build with old system-installed tevent
Volker Lendecke [Tue, 6 Nov 2012 15:17:22 +0000 (16:17 +0100)]
build: Fix the build with old system-installed tevent

We depend on the tracing callback mechanism in ctdb.

(This used to be ctdb commit 5f58c811127a89f162b6a41ddcd6e944801740a5)

11 years agoctdbd: Fix compilation warning in locking code
Martin Schwenke [Wed, 31 Oct 2012 01:33:25 +0000 (12:33 +1100)]
ctdbd: Fix compilation warning in locking code

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit cd64035d71ddff6aebe6c15a49e09527283425d2)

11 years agoweb: Update instructions for building from tarball
Amitay Isaacs [Wed, 31 Oct 2012 01:17:27 +0000 (12:17 +1100)]
web: Update instructions for building from tarball

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit ceac026713a7ee30ea865ed4a9422900ed76fdf6)

11 years agotests: Do not check release suffix in ctdb version test
Amitay Isaacs [Wed, 31 Oct 2012 01:10:22 +0000 (12:10 +1100)]
tests: Do not check release suffix in ctdb version test

release suffix added by RPM is to track packaging changes. Core CTDB
version does not include the release suffix.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit aad1584da8a8425bc6f5163c95810e9d2390dc91)

11 years agopackaging: Use maketarball.sh script to create tarball for RPM
Amitay Isaacs [Tue, 30 Oct 2012 00:54:52 +0000 (11:54 +1100)]
packaging: Use maketarball.sh script to create tarball for RPM

This removes the duplicate code for building tarball and reuses existing
script.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 16a91c2a4d03b46743611e2fe844bb2cef95e46a)

11 years agopackaging: Use optional argument as targetdir when creating tarball
Amitay Isaacs [Tue, 30 Oct 2012 00:52:19 +0000 (11:52 +1100)]
packaging: Use optional argument as targetdir when creating tarball

In addition, do not modify CTDB version string with extra suffix.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 3d4838db51dd8199b9c29aebb6e7bfbd2a27b8bb)

11 years agotool/ctdb: Always support ctdb version command, don't make it optional
Amitay Isaacs [Tue, 30 Oct 2012 00:49:28 +0000 (11:49 +1100)]
tool/ctdb: Always support ctdb version command, don't make it optional

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit f8af7d8de76e68e5c4bde15f832a31ce9107e8c7)

11 years agobuild: Add rules to create include/version.h when building from git tree
Amitay Isaacs [Tue, 30 Oct 2012 00:48:23 +0000 (11:48 +1100)]
build: Add rules to create include/version.h when building from git tree

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 8df7ea6b20417833792932487a082b3c71bb6837)

11 years agopackaging: Create include/version.h to define CTDB_VERSION_STRING
Amitay Isaacs [Tue, 30 Oct 2012 00:47:24 +0000 (11:47 +1100)]
packaging: Create include/version.h to define CTDB_VERSION_STRING

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit b151f9b62299ec5b887c62cef780547a39c0ba9d)

11 years agoAdd a \n to an error message
Volker Lendecke [Tue, 23 Oct 2012 19:49:34 +0000 (21:49 +0200)]
Add a \n to an error message

(This used to be ctdb commit 9be3b23adbfc844b71bf1d4ddf0fbc3b269f15fa)

11 years agoAvoid a bashism in 60.ganesha
Volker Lendecke [Tue, 23 Oct 2012 11:45:42 +0000 (13:45 +0200)]
Avoid a bashism in 60.ganesha

This file is #!/bin/sh. On sn-devel at least, with this /bin/sh the
shell does not like == for string equality.

(This used to be ctdb commit e2213db479129ce9c2b2fb88ec8c53cbd33d54b3)

11 years agoweb: Update broken links to manpages
Amitay Isaacs [Wed, 24 Oct 2012 01:58:57 +0000 (12:58 +1100)]
web: Update broken links to manpages

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit e94070de52232d6cefae0c6276df88b8fc380a4e)

11 years agopackaging: Bundle README, COPYING and html version of manpages
Amitay Isaacs [Mon, 22 Oct 2012 07:04:09 +0000 (18:04 +1100)]
packaging: Bundle README, COPYING and html version of manpages

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 6871415f6cb50c4f9753067359f0e264d3f93871)

11 years agodoc: Do not keep the built version of manpages in version control
Amitay Isaacs [Mon, 22 Oct 2012 06:43:32 +0000 (17:43 +1100)]
doc: Do not keep the built version of manpages in version control

Generated docs will be bundled with release tarballs. No need to keep
them in git. This avoids the need to commit the generated doc version
if source xml is modified.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit f3888712298f1de7cc7eb51f50c22080fa64e3c0)

11 years agopackaging: Use common code to generate VERSION string
Amitay Isaacs [Mon, 22 Oct 2012 04:12:50 +0000 (15:12 +1100)]
packaging: Use common code to generate VERSION string

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 0019291371af1e63ee132ed173ba7f52a0291a44)

11 years agopackaging: Factor out the code to genreate VERSION string
Amitay Isaacs [Mon, 22 Oct 2012 04:08:41 +0000 (15:08 +1100)]
packaging: Factor out the code to genreate VERSION string

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 19fb26346567d2249b1237f92d871022db2ba8cd)

11 years agopackaging: Build docs and include them in tarball
Amitay Isaacs [Mon, 22 Oct 2012 04:55:33 +0000 (15:55 +1100)]
packaging: Build docs and include them in tarball

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 69f0473b72aadab5bd5791ccff2facd0cd469d43)

11 years agobuild: Extract building of manpages in a separate Makefile
Amitay Isaacs [Tue, 16 Oct 2012 23:09:26 +0000 (10:09 +1100)]
build: Extract building of manpages in a separate Makefile

This can then be used to build manpages/html when creating tarball.
Do not build docs during a regular build, but only for install.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 3274cffe2052953b34141a82de6053b747532a88)

11 years agodoc: README - add information about CTDB, license and website
Amitay Isaacs [Sun, 21 Oct 2012 23:52:06 +0000 (10:52 +1100)]
doc: README - add information about CTDB, license and website

(This used to be ctdb commit db987eeb3c6e10552a1c1334bf263eb66fcad9ab)

11 years agoweb: Add posix locking information to prerequisites
Amitay Isaacs [Wed, 17 Oct 2012 00:27:32 +0000 (11:27 +1100)]
web: Add posix locking information to prerequisites

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit b3eac871895cc586bcc671835e882b136e466b98)

11 years agoweb: Add the links to ftp/http ctdb download area
Amitay Isaacs [Wed, 17 Oct 2012 00:26:52 +0000 (11:26 +1100)]
web: Add the links to ftp/http ctdb download area

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 12e4a3e2953842b4c3842bf920fe2086df4fe46c)

11 years agoweb: Remove reference to non-existent config files
Amitay Isaacs [Wed, 17 Oct 2012 00:25:46 +0000 (11:25 +1100)]
web: Remove reference to non-existent config files

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 4250c7ebe369e73cf29ff910bb9bfc929735408c)

11 years agodoc: getlog and clearlog changes for recovery daemon logs
Martin Schwenke [Mon, 22 Oct 2012 01:19:07 +0000 (12:19 +1100)]
doc: getlog and clearlog changes for recovery daemon logs

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit c18ec8ec234cb71da6cc77b1aadc398f57187947)

11 years agotests: Local daemons should use the logging ringbuffer
Martin Schwenke [Thu, 18 Oct 2012 03:15:09 +0000 (14:15 +1100)]
tests: Local daemons should use the logging ringbuffer

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 7547e011005f0dd5bd38e67572280126cf16e229)

11 years agotools/ctdb: Merge recoverd log handling into getlog/clearlog
Martin Schwenke [Thu, 18 Oct 2012 03:13:30 +0000 (14:13 +1100)]
tools/ctdb: Merge recoverd log handling into getlog/clearlog

We don't need extra commands for these.

Also, allow a default value of NOTICE for the getlog level.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 7197e600f46f2d1638f6c45c0149f109ea25a47c)

11 years agotools/ctdb: Add log ringbuffer handling for recoverd
Martin Schwenke [Tue, 16 Oct 2012 09:57:31 +0000 (20:57 +1100)]
tools/ctdb: Add log ringbuffer handling for recoverd

This adds commands rdgetlog and rdclearlog

These are analogous to getlog and clearlog but operate on the logs for
the recovery daemon.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit ef55e06192819d840c09b65741bab737223ac34c)

11 years agorecoverd: Add CTDB_SRVID_GETLOG and CTDB_SRVID_CLEARLOG
Martin Schwenke [Tue, 16 Oct 2012 09:54:39 +0000 (20:54 +1100)]
recoverd: Add CTDB_SRVID_GETLOG and CTDB_SRVID_CLEARLOG

These support getting and clearing logs from the ring-buffer in the
recovery daemon.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit cbca233d1e03b2410e0bb63b936328d4a8b3c7b4)

11 years agobuild: Set CTDB_PATH to /tmp/ctdb.socket if SOCKPATH is not defined
Amitay Isaacs [Sun, 21 Oct 2012 22:01:27 +0000 (09:01 +1100)]
build: Set CTDB_PATH to /tmp/ctdb.socket if SOCKPATH is not defined

When building samba with CTDB, if samba configure/waf does not support
setting of SOCKPATH, fallback to /tmp/ctdb.socket.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit a9511cf5ecd5bc39b0070f0afa8ac4d4926c6cab)

11 years agoBuild: Set the default ctdb socket path at configure time
David Disseldorp [Thu, 18 Oct 2012 14:55:19 +0000 (16:55 +0200)]
Build: Set the default ctdb socket path at configure time

The ctdb socket path currently defaults to /tmp/ctdb.socket and can be
modified at runtime using the --socket=filename option, common to both
ctdb and ctdbd binaries.

This change allows the default path to be set at configure time using
the --with-socketpath=FILE argument. When not specified, the default
path remains /tmp/ctdb.socket, documentation remains unchanged as a
result.

Signed-off-by: David Disseldorp <ddiss@samba.org>
(This used to be ctdb commit f92b9c83a2f39fba9a141417a88de96fc8c592ff)

11 years agolocking: Do not use ctdb_kill() to kill smbd processes
Amitay Isaacs [Tue, 25 Sep 2012 07:29:50 +0000 (17:29 +1000)]
locking: Do not use ctdb_kill() to kill smbd processes

ctdb_kill() is used to terminate processes spawned by CTDB.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 7d025281ee70c91ebcd4d9a908de1045a689786b)

11 years agolocking: Add database priority handling for older versions of samba
Amitay Isaacs [Wed, 11 Jul 2012 05:15:41 +0000 (15:15 +1000)]
locking: Add database priority handling for older versions of samba

In samba versions 3.6.x and older, database priorities are not set.
later_db() function implements higher database priority (locking order)
for these databases -
   brlock, g_lock, notify_onelevel, serverid, xattr_tdb

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit edbc8a6669b594d3c413d603e1c9fada9244c2ee)

11 years agolocking: Schedule a new lock request everytime a lock is released
Amitay Isaacs [Mon, 9 Jul 2012 07:37:35 +0000 (17:37 +1000)]
locking: Schedule a new lock request everytime a lock is released

Since the number of active lock requests is limited to
MAX_LOCK_PROCESSES_PER_DB (= 100), any new requests won't get scheduled
when they are created. So schedule a pending request once current active
request is done.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit c8eb4a3170ab8524e638047053831ba547e9cce8)

11 years agoctdbd: Replace lockwait with locking API and remove ctdb_lockwait.c
Amitay Isaacs [Thu, 14 Jun 2012 06:12:48 +0000 (16:12 +1000)]
ctdbd: Replace lockwait with locking API and remove ctdb_lockwait.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 2126795153dacb255e441abcb36ee05107b6282a)

11 years agoctdb_recover: Replace static locking functions with locking API
Amitay Isaacs [Wed, 9 May 2012 05:17:21 +0000 (15:17 +1000)]
ctdb_recover: Replace static locking functions with locking API

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 4456a01d8f54ca6c771d7488048de5f638477d21)

11 years agoctdb_freeze: Replace locking functions with locking API
Amitay Isaacs [Wed, 9 May 2012 05:09:51 +0000 (15:09 +1000)]
ctdb_freeze: Replace locking functions with locking API

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit 01ee86d2aafbcda658ef6acc2bba6d6781ae4047)

11 years agoctdbd_test: Include ctdb_lock.c code for test stubs
Amitay Isaacs [Wed, 9 May 2012 05:10:20 +0000 (15:10 +1000)]
ctdbd_test: Include ctdb_lock.c code for test stubs

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
(This used to be ctdb commit caff197edf6f928494028ac6c993901954aaa36f)