jake [Wed, 8 Jul 2009 05:24:55 +0000 (05:24 +0000)]
Drop obsolete --enable-gtk2 CFLAG
Make fakeroot actually work by setting proper LD_LIBRARY_PATH
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29009
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 8 Jul 2009 05:22:47 +0000 (05:22 +0000)]
Drop non-existing omniidl from wireshark-dev dependancy list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29008
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 8 Jul 2009 05:20:30 +0000 (05:20 +0000)]
Add missing packaging file (according to Debian Policy Manual).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29007
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 Jul 2009 00:57:01 +0000 (00:57 +0000)]
Recommend the expert mechanism, rather than DISSECTOR_ASSERT(), for
checks that really check whether the packet is valid; DISSECTOR_ASSERT()
should only be used for cases where the dissector is making an
assumption about its internal state.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29006
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 8 Jul 2009 00:28:54 +0000 (00:28 +0000)]
Fix several dissector assertions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29005
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 22:53:44 +0000 (22:53 +0000)]
radius: dictionary.nortel: Update as per the 2009-07-01 FreeRadius reposistory commit
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29004
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Jul 2009 22:22:05 +0000 (22:22 +0000)]
NULL is zero on all platforms we run on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29003
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 22:20:56 +0000 (22:20 +0000)]
radius: dictionary.wimax; Actually add the missing END-VENDOR statement
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29002
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 22:14:25 +0000 (22:14 +0000)]
Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3c: wimax
- As is from the FreeRadius release except added missing VENDOR-END
- Note: Attribute WiMAX-MN-hHA-MIP4-SPI [11] had a type of "octets"
in the previous Wireshark repository version of this file.
whereas this attribute in the FreeRadius version of tis file
has an attribute type of "integer".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29001
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 20:55:01 +0000 (20:55 +0000)]
Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3b: microsoft
FreeRadius v 2.1.6 dictionary.microsoft modified based upon
Wireshark commit SVN #17706.
Essentailly: Add "VALUES" for
ATTRIBUTE MS-MPPE-Encryption-Policy and
ATTRIBUTE MS-MPPE-Encryption-Types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29000
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 20:40:28 +0000 (20:40 +0000)]
Removed header_field.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28999
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 19:40:17 +0000 (19:40 +0000)]
Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3a: cablelabs
dictionary.cablelabs from FreeRadius v 2.1.6 updated based upon:
PacketCable(TM) 1.5 Specification: Event Messages [PKT-SP-EM1.5-I03-070412]
PacketCable(TM) Specification: Multimedia Specification [PKT-SP-MM-I04-080522]
Also: Added additional comments and changes related to Wireshark use of this file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28998
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 18:22:23 +0000 (18:22 +0000)]
Removed flags_set_truth
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28997
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 17:52:03 +0000 (17:52 +0000)]
Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 2:
Modified files w/o conflicts with current Wireshark radius dictionary files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28996
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 7 Jul 2009 17:07:24 +0000 (17:07 +0000)]
Add expert item to warn of AM data PDUs that don't have any data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28995
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 17:03:11 +0000 (17:03 +0000)]
Fix the esl protocol enable/disable handling issue introduced in SVN #28986:
Use the standard "if (!initialized)..." logic in proto_reg_handoff().
Also: use "true_false_string flags_yes_no" as in the original patch.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28994
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 16:13:25 +0000 (16:13 +0000)]
Revert r28985 to fix tfs prototypes, as it doesn't work...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28993
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 16:04:26 +0000 (16:04 +0000)]
Added some casts for true_false_string's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28992
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 15:21:36 +0000 (15:21 +0000)]
Do not use tfs true_string and false_string directly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28991
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 14:58:25 +0000 (14:58 +0000)]
Removed unused flags_set_truth.
Fixed some capitalizations.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28990
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 14:54:15 +0000 (14:54 +0000)]
Changed flags_set_truth -> tfs_set_notset
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28989
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 7 Jul 2009 14:38:14 +0000 (14:38 +0000)]
Add preference for turning off LTE RRC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28988
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 14:34:33 +0000 (14:34 +0000)]
No need to include tfs.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28987
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Jul 2009 14:26:38 +0000 (14:26 +0000)]
Various fixes:
1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin;
2. proto_reg_handoff: remove unneeded code;
3. Change the prefs callback to call a function which just enables/disables
the protocol; (using proto_reg_handoff means that the dissector
was re-registered each time the pref was changed);
4. packet-esl.h: use #if 0 instead of /* ... */ to comment out code;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28986
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 14:23:49 +0000 (14:23 +0000)]
Fix prototypes for default tfs sets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28985
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 14:13:45 +0000 (14:13 +0000)]
From Kovarththanan Rajaratnam:
Move hf/ett into proto_register_jxta() and do some field cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28984
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 12:21:25 +0000 (12:21 +0000)]
Added Kovarththanan Rajaratnam.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28983
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 12:14:47 +0000 (12:14 +0000)]
From Kovarththanan Rajaratnam:
Duplicate name/blurb removal from packet-fix.h (and template)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28982
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 11:58:23 +0000 (11:58 +0000)]
From Kovarththanan Rajaratnam:
Move hf/ett into proto_register_amqp() and do some field cleanup
(duplicate name/blurb removal)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28981
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 11:52:53 +0000 (11:52 +0000)]
Added credits for Lua BitOp.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28980
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 11:40:40 +0000 (11:40 +0000)]
From Kovarththanan Rajaratnam:
Move hf/ett definitions from packet-infiniband.h -> packet-infiniband.c to
align it with the rest of the bunch
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28979
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 11:37:15 +0000 (11:37 +0000)]
From Kovarththanan Rajaratnam:
Remove trailing spaces in protocol/field names
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28978
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 11:33:55 +0000 (11:33 +0000)]
Added Richard Kummel.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28977
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 11:13:22 +0000 (11:13 +0000)]
From Richard Kummel:
- New dissector for EtherCAT Switch Link Header added to EtherCAT plugin
- Changed filtering of EtherCAT commands to the abbreviated form:
e.g. ecat.cmd = APWR
From me:
- Mark unused variables
- Fixed a string warning
- Do not initialize a static struct
- Use tfs_yes_no
- Reorder files in Makefile
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28976
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 10:12:15 +0000 (10:12 +0000)]
From Kovarththanan Rajaratnam:
More header field info cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28975
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 10:07:42 +0000 (10:07 +0000)]
Remove some check_col() calls.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28974
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Jul 2009 09:42:09 +0000 (09:42 +0000)]
Introduce se_address_to_str()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28973
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Jul 2009 09:27:52 +0000 (09:27 +0000)]
Cleanup header_field_info definitions
- Regenerating x420 seems to have fixed the "last" problem :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28972
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 09:02:59 +0000 (09:02 +0000)]
From Kovarththanan Rajaratnam:
More FT_XXX cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28971
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 09:00:33 +0000 (09:00 +0000)]
From Kovarththanan Rajaratnam:
More FT_XXX cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28970
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 08:27:15 +0000 (08:27 +0000)]
From Julián Lastiri via bug 3656:
ClassifierID should be before Priority field in the Extended Classifier of
PacketCable Multimedia Protocol. Also the reference to PacketCable Multimedia
document PKT-SP-MM-I02-040930 is wrong because there is no definition about
Extended Classifier. My fix is based on PacketCable Multimedia
PKT-SP-MM-I04-080522 document.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28969
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 07:46:57 +0000 (07:46 +0000)]
From Kovarththanan Rajaratnam via bug 3548:
Minor hf cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28968
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Jul 2009 07:45:32 +0000 (07:45 +0000)]
From Kovarththanan Rajaratnam via bug 3548:
Move header_field.h into packet-unistim.c to align it with all other
dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28967
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Jul 2009 05:43:43 +0000 (05:43 +0000)]
Delete obsolete protocol dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28966
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Jul 2009 05:10:20 +0000 (05:10 +0000)]
Add holding|spa to the strings removed from manuf names.
manuf will be automatically rebuilt on Sunday.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28965
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Jul 2009 04:41:53 +0000 (04:41 +0000)]
From Kovarththanan Rajaratnam:
More "Cleanup header_field_info definitions"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28964
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 6 Jul 2009 20:23:32 +0000 (20:23 +0000)]
From Kovarththanan Rajaratnam via bug 3652:
This patch protects against malformed Unique ID lengths (>= 252 bytes) and
defer all tvb_xxx related calls to when we actually need them. This allows us
to dissects as much as possible before bailing out (in case of a malformed
length).
From me:
Add a link to the protocol specification. Remove packet-miop.h along
with some struct definitions. (Don't tvb_memcpy over structs!) Remove
some more tvbuffs. Don't call proto_item_add_subtree if we're not going
to use the trees. Call proto_tree_add_item instead of
proto_tree_add_text Remove a bunch of unused ett_ variables. Add an
expert item for the protocol version. Register the field array with the
correct length.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28963
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 18:36:00 +0000 (18:36 +0000)]
From Kovarththanan Rajaratnam:
More "Cleanup header_field_info definitions"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28962
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 18:35:05 +0000 (18:35 +0000)]
From Kovarththanan Rajaratnam:
More "Cleanup header_field_info definitions"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28961
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 6 Jul 2009 17:49:33 +0000 (17:49 +0000)]
Shorten a few variables for values read from the packet.
Inspired by Kovarththanan Rajaratnam's patch for bug 3665
which in turn was a duplicate for the (fixed) bug 3660.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28960
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 6 Jul 2009 17:45:40 +0000 (17:45 +0000)]
Move edp to the top level tree instead of inside the ismp
tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28959
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 6 Jul 2009 17:44:02 +0000 (17:44 +0000)]
OK, nobody cared about the waring, so just remove the
test for now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28958
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 17:37:03 +0000 (17:37 +0000)]
CFLOW decoding is wrong for IPv6 fields.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3328
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28957
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 6 Jul 2009 17:13:41 +0000 (17:13 +0000)]
Fix a couple of typos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28956
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 15:37:29 +0000 (15:37 +0000)]
Initialize memory to zero.
(is NULL = zero on all platforms?)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28955
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 6 Jul 2009 14:14:13 +0000 (14:14 +0000)]
Rewrite non-ASCII characters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28954
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 14:09:52 +0000 (14:09 +0000)]
Small editorial changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28953
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 6 Jul 2009 14:05:37 +0000 (14:05 +0000)]
Radius: Additional attribute handling:
- implement "ether" attribute;
- parse "abinary" attribute [uses existing radius_abinary()]
Also: add a comment in packet-radius.h about the meaning of the encrypt flag.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28952
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 6 Jul 2009 13:59:09 +0000 (13:59 +0000)]
From Joakim Wiberg via bug 3670:
This patch correctes serveral minor things.
1. Adds decoding of generic services to classes that have a separate dissect
function.
2. Adds new error codes.
3. Adds new CIP objects.
4. Extends the VendorID list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28951
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 6 Jul 2009 13:53:01 +0000 (13:53 +0000)]
Removed an incorrect optimalization for invalidating packet in row 0.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28950
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 13:34:30 +0000 (13:34 +0000)]
Revert checkin made by misstake(don't use new packet list).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28949
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 6 Jul 2009 13:00:04 +0000 (13:00 +0000)]
Fix for bug 3660: Length (guint32) could become 0 or very large
(overflow).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28948
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 6 Jul 2009 12:50:12 +0000 (12:50 +0000)]
Decode error for network-id in BICC BCU-ID
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3648
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28947
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 6 Jul 2009 12:39:58 +0000 (12:39 +0000)]
Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 1: New files
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28946
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 6 Jul 2009 09:46:28 +0000 (09:46 +0000)]
fix install step
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28945
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 5 Jul 2009 16:22:20 +0000 (16:22 +0000)]
gtk_tree_view_set_fixed_height_mode() is GTK 2.6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28944
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 5 Jul 2009 15:03:31 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-07-05]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28941
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 5 Jul 2009 11:49:36 +0000 (11:49 +0000)]
From Kovarththanan Rajaratnam:
Cleanup header_field_info definitions
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28940
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 4 Jul 2009 15:15:51 +0000 (15:15 +0000)]
A fix for:
"ANSI ISUP Cause indicators with coding standard=ANSI fail to dissect."
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3654
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28939
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 3 Jul 2009 17:12:36 +0000 (17:12 +0000)]
Set save_fragmented regardless of whether we're reassembling or not, as
we restore it regardless of whether we're reassembling or not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28938
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 3 Jul 2009 16:03:02 +0000 (16:03 +0000)]
From: Tobias Witek: Fix processing of radius 'vendor specific attributes'
In the RADIUS dissector, the function radius_register_avp_dissector() registers
vendors that are not already present in the dictionary hash-table. As far as I
can see, there are two problems with this:
1. The function does not set the number of type/length octets and the has_flags
variable for that AVP, which is required to correctly decode AVP/VSA values
2. In some situations, the function is called _before_ radius_load_dictionary()
is called (for example for the vendor 3GPP (ID: 10415))
Therefore, all vendor entries that are created by calling
radius_register_avp_dissector() leave their type_octets and length_octets un-initialized,
which causes incorrect decoding.
[Result: Radius dissector displays messages such as:
"Malformed Packet: RADIUS" and "Error/Malformed: Malformed Packet(Exception occurred)"]
The attached patch fixes this problem by assuming that the dictionary knows the
'ground truth' about the type/length octet and the has_flags information and allows it to
overwrite these values even for vendors that have already been loaded.
Also: (from Bill Meier): set the type/length octet and the has_flags variables to default
"standard" values (1,1,FALSE) in radius_register_avp_dissector().
Fixes Bug #3651 (and Bug #3635).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3651
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3635
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28937
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 3 Jul 2009 13:05:45 +0000 (13:05 +0000)]
Fix:
packet-ndmp.c:562: warning: unused parameter 'pinfo'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28936
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 3 Jul 2009 11:45:42 +0000 (11:45 +0000)]
From Chris Costa:
NDMP fragmentation fix.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3395
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28935
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 3 Jul 2009 10:29:45 +0000 (10:29 +0000)]
Make the compiler on Mac OS X happy...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28934
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 3 Jul 2009 09:35:40 +0000 (09:35 +0000)]
ignore copied ws.css for commits
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28933
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 3 Jul 2009 09:12:43 +0000 (09:12 +0000)]
update to the latest PROFINET drafts
(defragmentation of RT fragments "FRAG-PDU" is still not implemented)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28932
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 3 Jul 2009 01:11:23 +0000 (01:11 +0000)]
From Kovarththanan Rajaratnam: Fixes for bug #3536
(plus some additional changes by me).
Handle BASE_RANGE_STRING display types properly
We always treat header field info strings as value_string's undiscriminated.
However, if the header field info display is marked as BASE_RANGE_STRING, we
need to treat them as range_string's. This wasn't properly handled in the
filter expression dialog and in the filter toolbar which would cause a crash
upon referencing any fields marked as BASE_RANGE_STRING.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28931
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 3 Jul 2009 00:17:06 +0000 (00:17 +0000)]
Try to allocate enough memory on all platforms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28930
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 2 Jul 2009 22:04:22 +0000 (22:04 +0000)]
Get it compiling with -DNEW_PACKET_LIST on Mac OS X.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28929
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 2 Jul 2009 21:06:24 +0000 (21:06 +0000)]
Allow the new packet list's columns to be moved back
and forth while the packet list is open without having
to go into the preferences. The new column ordering is
not saved for next time though. Perhaps it should be.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28928
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 2 Jul 2009 20:35:58 +0000 (20:35 +0000)]
From Kovarththanan Rajaratnam via bug 3567:
The template cache contains pointers that are session-scope (only freed in
netflow_reinit()) but still we use g_malloc(). This patch changes that so we
now use se_alloc(). With this patch I'm able to reproduce the crash
("Per-session memory corrupted").
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28927
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 2 Jul 2009 20:35:46 +0000 (20:35 +0000)]
Update documentation links.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28926
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 Jul 2009 20:10:05 +0000 (20:10 +0000)]
Don't dump out the raw link-layer type when noting that
KHciLoggerDatalinkTypeBCSP and KHciLoggerDatalinkTypeH5 aren't supported
- just explicitly say "BSCP" or "H5".
For unknown link-layer types, say "unknown or unsupported", as other
Wiretap modules do.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28925
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 2 Jul 2009 19:52:47 +0000 (19:52 +0000)]
Patch from Alex Badea for Bug 3645.
This fix will be included in Wireshark 1.2.1.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28924
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 2 Jul 2009 19:50:35 +0000 (19:50 +0000)]
mkstemp cleanups.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28923
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 2 Jul 2009 18:24:26 +0000 (18:24 +0000)]
This time with the comment...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28922
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 2 Jul 2009 18:22:41 +0000 (18:22 +0000)]
Don't resort the list for every row, the list will be in packet order any way. And "clicking" on the column titles will resort the list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28921
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 2 Jul 2009 17:20:27 +0000 (17:20 +0000)]
Pull mkstemp() into tempfile.c. That's the only place we use it now, and
it's arguably the only place we _should_ use it. Add create_tempdir() to
tempfile.c and use it to create a temp directory for IP maps. This
should fix bug 3530.
(This still doesn't work on IE 8 / Vista here. IE gives an access denied
error in OpenLayers.js, but this is a separate issue).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28920
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 2 Jul 2009 16:54:20 +0000 (16:54 +0000)]
From Radek Vokál:
Support for new NFSv4 features.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3258
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28919
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 2 Jul 2009 09:08:11 +0000 (09:08 +0000)]
Move updating menus with new recent values to a point after we have created
the new packet list, because we relay on the columns for time values.
This fixes bug 3640.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28918
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 2 Jul 2009 06:51:27 +0000 (06:51 +0000)]
From Albert Chin:
Small patch to make it compile on AIX.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28917
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 2 Jul 2009 02:50:24 +0000 (02:50 +0000)]
Fix the build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28916
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 1 Jul 2009 23:36:51 +0000 (23:36 +0000)]
Updates to create_tempfile:
- Use g_get_tmp_dir, just like get_tempfile_path.
- Don't make the caller worry about the path buffer length.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28915
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 1 Jul 2009 23:36:35 +0000 (23:36 +0000)]
Fix a couple of labels.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28914
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 1 Jul 2009 21:20:18 +0000 (21:20 +0000)]
Added error value tables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28913
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 1 Jul 2009 20:56:03 +0000 (20:56 +0000)]
Add a couple of IPFIX labels where they differ from Netflow.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28912
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 1 Jul 2009 19:36:24 +0000 (19:36 +0000)]
Try to fix fuzzing errors in bug 3636. When dissecting an options
template, differentiate between Netflow v9 and IPFIX, which require
different interpretations. Add other minor fixes and comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28911
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 1 Jul 2009 17:40:08 +0000 (17:40 +0000)]
Thou shalt not call assert() in dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28910
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 1 Jul 2009 17:39:19 +0000 (17:39 +0000)]
Realy make the new packet list compile under Windows...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28909
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 1 Jul 2009 15:56:12 +0000 (15:56 +0000)]
Fix a key entry bug in the decryption key dialog. Remove some unused /
unnecessary functions. Clean up code in a couple of places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28908
f5534014-38df-0310-8fa8-
9805f1628bb7