David Disseldorp [Wed, 26 Jan 2011 22:32:01 +0000 (14:32 -0800)]
Looking into printer driver issues, I ran across some peculiarities in
copy_file():
- Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
returned.
- Secondly, the conditional lseek is confusing. It fires when
OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
necessary in this case.
- Finally, the lseek error path also results in NT_STATUS_DISK_FULL.
Proposed fix for first and third point below.
(cherry picked from commit
aa3bba8d778862c82e48a7c6f7bd51f5c78c7d90)
Andreas Schneider [Wed, 19 Jan 2011 22:15:21 +0000 (23:15 +0100)]
s3-utils: Fixed a resource leak in net_afs.
s3-utils: Fixed a resource leak in net_afs.
(cherry picked from commit
92f8a5747bf74adedc97ea3a63819d6e58f010c3)
Andreas Schneider [Wed, 19 Jan 2011 22:13:47 +0000 (23:13 +0100)]
s3-utils: Fixed a resource leak in smbta-util.
s3-utils: Fixed a resource leak in smbta-util.
(cherry picked from commit
4fc75c755d0b20ba4f4e1c42471a0355fd85990d)
Andreas Schneider [Wed, 19 Jan 2011 22:07:33 +0000 (23:07 +0100)]
s3-utils: Fixed possible resource leak in net_usershare.
s3-utils: Fixed possible resource leak in net_usershare.
(cherry picked from commit
f419c2b0911788cdd0474bd543ebdbfa52954889)
Andreas Schneider [Wed, 19 Jan 2011 14:18:10 +0000 (15:18 +0100)]
s3-utils: Fixed possible resource leak in smbget.
s3-utils: Fixed possible resource leak in smbget.
(cherry picked from commit
de4ef101c165cf735938f914f7da620daea91762)
Andreas Schneider [Wed, 19 Jan 2011 14:20:34 +0000 (15:20 +0100)]
s3-utils: Fixed possible resource leak in smbfilter.
s3-utils: Fixed possible resource leak in smbfilter.
(cherry picked from commit
08dc51d3caabcebf9cc2dc02aac74632831c09b7)
Andreas Schneider [Wed, 19 Jan 2011 22:11:32 +0000 (23:11 +0100)]
s3-modules: Fixed the for-loop code block.
s3-modules: Fixed the for-loop code block.
(cherry picked from commit
f6f0dac4271b2bd1304c2b592c4d2dcbc795afaf)
Andreas Schneider [Wed, 19 Jan 2011 22:04:13 +0000 (23:04 +0100)]
s3-lib: Fixed a missing return value in tldap.
s3-lib: Fixed a missing return value in tldap.
(cherry picked from commit
2c47368d682ee908e79bc43d5c865049397440e1)
Kai Blin [Wed, 26 Jan 2011 21:17:43 +0000 (22:17 +0100)]
errormap: Add unix_to_werror() function
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.
Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104
(cherry picked from commit
278c6f8fc538ad8ee069f0682229fad34abb3513)
Jeremy Allison [Wed, 26 Jan 2011 18:50:44 +0000 (10:50 -0800)]
Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.c
(cherry picked from commit
de53c1e30ddbc640fd0755cf38a40e9e0acac309)
Stefan Metzmacher [Wed, 26 Jan 2011 07:48:34 +0000 (08:48 +0100)]
pidl:Typelist: fix perl warnings about recursiv function calls
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 26 10:59:04 CET 2011 on sn-devel-104
(cherry picked from commit
34664338f3c0bd9acbb2ada3d92d482e30cbdf1c)
Stefan Metzmacher [Tue, 25 Jan 2011 18:46:18 +0000 (19:46 +0100)]
pidl:Samba3/ServerNDR: correctly initialise ndr_push struct
We need to copy the ptr_count from the ndr_pull struct to the ndr_push struct,
otherwise we'll reuse full pointer ids, which will cause the client to
fail in the ndr unmarshalling.
metze
(cherry picked from commit
4b068bb91994a0fc3a76abd45bff4e2fe53e9a34)
Jeremy Allison [Wed, 26 Jan 2011 16:43:43 +0000 (08:43 -0800)]
From Metze - make sure we're using the same string length for the hash.
(cherry picked from commit
30065ac02e825bd0202294202069a0bc890cbdf1)
Günther Deschner [Mon, 24 Jan 2011 19:52:24 +0000 (20:52 +0100)]
s3-winbind: share a common winbind_samlogon_retry_loop().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 26 12:41:14 CET 2011 on sn-devel-104
(cherry picked from commit
abb7c07de5d07d5378dafbfdf0d0213a2b0e0b05)
Günther Deschner [Mon, 24 Jan 2011 19:45:35 +0000 (20:45 +0100)]
Revert "s3: These assignments are overwritten immediately"
This reverts commit
18962ea3852d0d0fc7371e99813bebd54fae0a19.
(cherry picked from commit
035a0d2fb36af2be655a19103bc3e01e036375a4)
Günther Deschner [Mon, 24 Jan 2011 19:43:56 +0000 (20:43 +0100)]
Revert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains."
This reverts commit
cea36aeacf8778493463f31e6afc3f58384639e2.
(cherry picked from commit
36cfa1792ed1d13268de792cb4df20d6743d1e55)
Jeremy Allison [Tue, 25 Jan 2011 22:59:44 +0000 (14:59 -0800)]
Missed one debug printf of name_hash. Ensure always use %x.
(cherry picked from commit
9e67184d0f5cc151091faa8e5db24d5569a3fead)
Jeremy Allison [Tue, 25 Jan 2011 22:23:19 +0000 (14:23 -0800)]
Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved.
Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.
(cherry picked from commit
44732734cca2328a8aceb2db9b577c923920f644)
Jeremy Allison [Tue, 25 Jan 2011 21:57:38 +0000 (13:57 -0800)]
Add uint32_t name_hash argument (currently unused) to get_file_infos().
Will be used when we store more than one delete on close token.
(cherry picked from commit
a65bce4e38d0b940286c7c93c226651e5fb45082)
Jeremy Allison [Tue, 25 Jan 2011 22:01:52 +0000 (14:01 -0800)]
Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path).
(cherry picked from commit
b97f1ce68a512cb0da71ee1de9ddaa49dd466068)
Jeremy Allison [Tue, 25 Jan 2011 21:49:01 +0000 (13:49 -0800)]
Add name_hash to files_struct. Set within fsp_set_smb_fname().
(cherry picked from commit
76418e23bcde1eba4dfefbc10c51c083567a52e6)
Björn Baumbach [Thu, 20 Jan 2011 13:38:30 +0000 (14:38 +0100)]
s3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 25 11:41:53 CET 2011 on sn-devel-104
(cherry picked from commit
07ccc2905dc5d0d74dc688ff830f504ea9665029)
Björn Baumbach [Thu, 20 Jan 2011 13:08:42 +0000 (14:08 +0100)]
s3-masktest: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
5d8ada549e629cfe53ed973d66f5fcf0a3bd0a8c)
Björn Baumbach [Mon, 17 Jan 2011 11:02:39 +0000 (12:02 +0100)]
s3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
09c612f377749b79b850ee6c52ae49699e256359)
Björn Baumbach [Mon, 17 Jan 2011 12:03:05 +0000 (13:03 +0100)]
s3-torture: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
99f8f5e5945c5cd694dbb37fa947c04a24e25957)
Björn Baumbach [Mon, 17 Jan 2011 08:51:45 +0000 (09:51 +0100)]
s3-docs: fix deldriver option
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
3bb212a3a96164121d345a8c8f81294b0f988261)
Björn Baumbach [Fri, 14 Jan 2011 11:35:55 +0000 (12:35 +0100)]
s3-docs: add some long opts to smbclient(1) man
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
b8d5ee9de3bb8c24efd2a7fab89d7d814b98aa2d)
Günther Deschner [Tue, 25 Jan 2011 01:42:59 +0000 (02:42 +0100)]
idl: add file_id idl.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 25 12:27:00 CET 2011 on sn-devel-104
(cherry picked from commit
c9f4fad75cf9749709cbebfe55c59f3c2d01858e)
Günther Deschner [Tue, 25 Jan 2011 01:52:18 +0000 (02:52 +0100)]
s3-libndr: remove cmdline_lp_ctx.
Guenther
(cherry picked from commit
f0b3c72bcc119f497a4379c549bc55fb1031ce90)
Günther Deschner [Tue, 25 Jan 2011 01:01:56 +0000 (02:01 +0100)]
waf: share libndr.so between samba3 and samba4.
Guenther
(cherry picked from commit
dd35fe181c2397a970fa956afa5f4da534841b99)
Günther Deschner [Mon, 24 Jan 2011 23:52:10 +0000 (00:52 +0100)]
libndr: move ndr_print_bool to ndr_basic.c
Guenther
(cherry picked from commit
7eac3100ea77eca64152444336180418938d5843)
Günther Deschner [Mon, 24 Jan 2011 23:47:05 +0000 (00:47 +0100)]
s3-waf: add PKGCONFIGDIR.
Guenther
(cherry picked from commit
62e1c80cf532681c02ecd2ddcb7c920381a0465e)
Matthieu Patou [Sat, 20 Nov 2010 15:06:12 +0000 (18:06 +0300)]
idl: remove protected storage
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
9d9c2128585a1d5fdb9090215750427df6a883ff)
Matthieu Patou [Sat, 20 Nov 2010 15:19:06 +0000 (18:19 +0300)]
idl: Add IDL for remote key backup protocol (rkbp)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
25ae380fabfd2d7e5141dadb48b8e30b5b723c1f)
Günther Deschner [Mon, 24 Jan 2011 15:55:05 +0000 (16:55 +0100)]
s3-build: remove source4 include path for autoconf build as well.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 17:40:56 CET 2011 on sn-devel-104
(cherry picked from commit
39ea30de0fb9ebf64b7c7ab8f6731fcf98ed294b)
Günther Deschner [Fri, 21 Jan 2011 15:58:32 +0000 (16:58 +0100)]
s3-rpcclient: allow to define validation level for samlogon.
Guenther
(cherry picked from commit
99437614fa8028d60356ee79611d94051ec756ec)
Stefan Metzmacher [Wed, 12 Jan 2011 14:48:30 +0000 (15:48 +0100)]
drsuapi.idl: add some more DRSUAPI_ATTID_* values
These will be use for "net rpc vampire passwd" in source3.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 12 19:51:53 CET 2011 on sn-devel-104
(cherry picked from commit
c39e80094b91ac7055faee61a8137d47e9e76c43)
Matthias Dieter Wallnöfer [Thu, 23 Dec 2010 11:42:37 +0000 (12:42 +0100)]
lib/replace/testsuite.c - fix test output
(cherry picked from commit
da78e24ca201dcdac8a498a5d0da8c30154d4d9a)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jelmer Vernooij [Wed, 5 Jan 2011 12:52:34 +0000 (13:52 +0100)]
tdbrestore: Update to GPLv3+, remove old FSF address.
(cherry picked from commit
24d5a7202ab521b92eb07c93647ae2d381e181a5)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Sat, 15 Jan 2011 01:24:51 +0000 (02:24 +0100)]
s4-dns: disable segfault handling in dlz_bind9
we don't want bind9 calling the Samba segv handler
(cherry picked from commit
da5c328b4b4a793053a8b1c942ceda56da01625c)
Only the lib/util part...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Wed, 22 Dec 2010 08:53:27 +0000 (09:53 +0100)]
lib/util/time.c - make the "strftime" output locale independant ("%c" is not)
So that it also works on Solaris.
(cherry picked from commit
07bcf6197d9fbdc038513ae3db7f83a9bb8a6cd9)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Mon, 6 Dec 2010 10:28:22 +0000 (11:28 +0100)]
Revert "lib/util:tests/time.c - "test_timestring" - fix it on Solaris"
This reverts commit
654e0102ddb0acaaf45fb55c15818722235fcc9f.
This should better be handled by the replace library.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Dec 6 12:17:31 CET 2010 on sn-devel-104
(cherry picked from commit
bd3e5804a41fdfc8a43bebd95c53e4f0ff1d7a10)
Matthias Dieter Wallnöfer [Sun, 5 Dec 2010 21:20:06 +0000 (22:20 +0100)]
lib/util:tests/time.c - "test_timestring" - fix it on Solaris
Solaris returns "Thu Jan 01" and not "Thu Jan 1" - therefore proof for
both.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Dec 5 23:09:13 CET 2010 on sn-devel-104
(cherry picked from commit
654e0102ddb0acaaf45fb55c15818722235fcc9f)
Günther Deschner [Mon, 24 Jan 2011 14:27:52 +0000 (15:27 +0100)]
s3-waf: fix lib/addns include path.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 16:15:58 CET 2011 on sn-devel-104
(cherry picked from commit
ef0a3903f007cee5a564699fc9750d6e8a472d7d)
Günther Deschner [Mon, 24 Jan 2011 14:26:11 +0000 (15:26 +0100)]
s3-waf: no need anymore to include "source4" globally.
Guenther
(cherry picked from commit
c675b1c827f792e19cbacd91d2356e0df2ee87e3)
Stefan Metzmacher [Mon, 24 Jan 2011 12:29:14 +0000 (13:29 +0100)]
libcli/ldap: use lib/ldb_compat.h for the s3 build
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 24 14:55:50 CET 2011 on sn-devel-104
(cherry picked from commit
0dc1eee0b8174d591ea02de40bb564088a25fd97)
Günther Deschner [Mon, 24 Jan 2011 10:48:36 +0000 (11:48 +0100)]
s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains.
After failing the netr_LogonSamLogonEx, we failed to retry with
netr_LogonSamLogon.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 12:35:42 CET 2011 on sn-devel-104
(cherry picked from commit
cea36aeacf8778493463f31e6afc3f58384639e2)
Volker Lendecke [Mon, 24 Jan 2011 08:25:01 +0000 (09:25 +0100)]
Revert "s3: Fix an infinite loop"
This reverts commit
61f7d7cdeccb1f733590e8bdb8229b32363a815e.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 24 10:10:43 CET 2011 on sn-devel-104
Volker Lendecke [Sun, 23 Jan 2011 08:12:43 +0000 (09:12 +0100)]
s3: Fix an infinite loop
If select returns EBADF (which should NEVER happen), then we loop infinitely
because the select masks seem all active.
I've been given an strace where smbd floods syslog with inotify-related
error messages. The strace shows that select returns EBADF, and we're calling
the inotify event callback. It then complains there's no data on the inotify
fd.
Metze, please check!
We might need to fix this in 3.4 and 3.5 as well. And we need to find the
deeper reason where we close a file descriptor and don't tell the events
system about it.
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 23 10:05:39 CET 2011 on sn-devel-104
Volker Lendecke [Sat, 22 Jan 2011 15:22:42 +0000 (16:22 +0100)]
s3: Fix connecting to port-139 only servers
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
Günther Deschner [Fri, 21 Jan 2011 14:35:11 +0000 (15:35 +0100)]
s3-torture: fix uninitialized status code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:52:34 CET 2011 on sn-devel-104
(cherry picked from commit
6ee39a2f42e83768f99e742f76dd4a1b785fcdae)
Günther Deschner [Fri, 21 Jan 2011 15:02:18 +0000 (16:02 +0100)]
s3-rpc_client: fix dcerpc_try_samr_connects().
Only return when both results are ok.
Guenther
(cherry picked from commit
6923cc801669ad31741a9e2a024e0d35f1a16d58)
Günther Deschner [Fri, 21 Jan 2011 15:00:31 +0000 (16:00 +0100)]
s3-rpc_client: no need to include gen_ndr/cli_samr.h anymore.
Guenther
(cherry picked from commit
e873ce9b651b665b1b0e3755b016587f02a9f99d)
Günther Deschner [Fri, 21 Jan 2011 14:51:05 +0000 (15:51 +0100)]
s3-rpc_client: fix uninitialized variable found by -O3.
Guenther
(cherry picked from commit
1f26b101ed594ed55f9679fe595ddba2ef1ecee0)
Günther Deschner [Tue, 18 Jan 2011 22:16:42 +0000 (23:16 +0100)]
s3-waf: remove RPCCLI_SPOOLSS subsystem.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:06:40 CET 2011 on sn-devel-104
(cherry picked from commit
5e89574dceb80b170444631bcffdf02fc8f7af76)
Günther Deschner [Tue, 18 Jan 2011 22:16:24 +0000 (23:16 +0100)]
s3-build: remove RPCCLI_SPOOLSS subsystem.
Guenther
(cherry picked from commit
24c51a7d2a3e6cdcf8cf55278d3e4151b7271d3b)
Günther Deschner [Tue, 18 Jan 2011 21:10:30 +0000 (22:10 +0100)]
s3-rpcclient: prefer dcerpc_spoolss_X functions.
Guenther
(cherry picked from commit
cf7a78b64f83be4c2ccc0b1fd2b074954179bcb1)
Günther Deschner [Tue, 18 Jan 2011 17:37:52 +0000 (18:37 +0100)]
s3-rpc_client: prefer dcerpc_spoolss_X functions.
Guenther
(cherry picked from commit
e94ffc790e7206f76d9ea43d0620511143547457)
Günther Deschner [Tue, 18 Jan 2011 23:43:33 +0000 (00:43 +0100)]
s3-lanman: remove trailing whitespace.
Guenther
(cherry picked from commit
831f3eec16623e8c96aa58a4e03db5f0fcda8b5c)
Andreas Schneider [Thu, 13 Jan 2011 16:30:52 +0000 (17:30 +0100)]
tdb: Added doxygen documentation.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 11:26:34 CET 2011 on sn-devel-104
(cherry picked from commit
b42afa0edf375c944d39a888f4db422e8d2b13cf)
Andreas Schneider [Wed, 12 Jan 2011 14:51:49 +0000 (15:51 +0100)]
s3-rpc_client: Added dcerpc_try_samr_connects.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 15:19:01 CET 2011 on sn-devel-104
(cherry picked from commit
5db115a3041faee7c924cf26c1635f6028ae7df8)
Andreas Schneider [Wed, 12 Jan 2011 14:36:19 +0000 (15:36 +0100)]
s3-rpc_client: Rename get_query_dispinfo_params.
(cherry picked from commit
089c25cbbb44547bbb03d54ec4e2c1f5ebd10f86)
Andreas Schneider [Wed, 12 Jan 2011 14:14:35 +0000 (15:14 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user3.
(cherry picked from commit
e6475f2151eb94b2e9010f9e0f4d3d8c2c315b81)
Andreas Schneider [Wed, 12 Jan 2011 08:04:19 +0000 (09:04 +0100)]
s3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap.
(cherry picked from commit
200772653ae295b4c5142d943faf7a2c878121a9)
Andreas Schneider [Wed, 12 Jan 2011 07:46:28 +0000 (08:46 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user2.
(cherry picked from commit
3de564b9b6559690578ca649f8acf52d82bc592e)
Andreas Schneider [Tue, 11 Jan 2011 12:07:02 +0000 (13:07 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user.
(cherry picked from commit
78c4f72c311fb23ab37ed892fe67b75421736803)
Andreas Schneider [Tue, 11 Jan 2011 11:56:44 +0000 (12:56 +0100)]
s3-rpc_client: Added header information to cli_samr.h.
(cherry picked from commit
8b1ffc770c50b789ce923f585b20a74d9b42f2ee)
Andreas Schneider [Tue, 11 Jan 2011 11:56:08 +0000 (12:56 +0100)]
s3-rpc_client: Added header information to cli_lsarpc.h.
(cherry picked from commit
1efa9b1cbd5576e1985a909afa43d24cc3fa2bb0)
Stefan Metzmacher [Sat, 15 Jan 2011 11:06:09 +0000 (12:06 +0100)]
s3:printing: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 13:14:49 CET 2011 on sn-devel-104
(cherry picked from commit
7a2fa9fc1cf5b26419c9cd915e85030c7f14e764)
Stefan Metzmacher [Sat, 15 Jan 2011 10:55:39 +0000 (11:55 +0100)]
s3:srv_spoolss: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
1f8332526102e879c8a8f847d6b43efaf69d03ba)
Stefan Metzmacher [Sat, 15 Jan 2011 10:53:11 +0000 (11:53 +0100)]
s3:smbd: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
e830e37c9c0ef6597e92e31915b2f41310ac1cad)
Stefan Metzmacher [Sat, 15 Jan 2011 10:50:59 +0000 (11:50 +0100)]
s3:net: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
81443447a116460911a9235a8f9a60e3c8dea502)
Stefan Metzmacher [Sat, 15 Jan 2011 10:44:23 +0000 (11:44 +0100)]
s3:libads: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
a34aa148ca9789ddd7f1f09d548e7c2668876151)
Michael Adam [Fri, 21 Jan 2011 12:49:06 +0000 (13:49 +0100)]
s3:docs: document "winbind max domain connections"
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 14:33:57 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 7 Apr 2010 15:45:12 +0000 (17:45 +0200)]
s3:winbind: Fork multiple children per domain
This makes us scale better with many simultaneous winbind requests,
some of which might be slow.
This implementation breaks offline logons, as the cached credentials are
maintained in a child (this needs fixing). So, if the offline logons are
active, only allow one DC connection.
Probably the offline logon and the scalable file server cases are
separate enough so that this patch is useful even with the restriction.
Volker Lendecke [Fri, 21 Jan 2011 09:30:13 +0000 (10:30 +0100)]
s3: Fix a deadlock between smbd and ctdbd
Do the notification after we released the share mode lock. Inside notify_fname
we take out another tdb lock. With ctdb also accessing our databases, this can
lead to deadlocks. Putting this notify after the TALLOC_FREE(lck) above we
avoid locking two records simultaneously. Notifies are async and informational
only, so calling the notify_fname without holding the share mode lock should
not do any harm.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 21 12:29:21 CET 2011 on sn-devel-104
Michael Adam [Fri, 21 Jan 2011 08:46:42 +0000 (09:46 +0100)]
s3:vfs:shadow_copy2: fix indentation in _SHADOW2_NEXT_SMB_FNAME
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 10:57:45 CET 2011 on sn-devel-104
Volker Lendecke [Thu, 16 Dec 2010 11:26:02 +0000 (04:26 -0700)]
s3:vfs:shadow_copy2: Fix shadow-copy module for drag&drop from a snapshot
We have to return NT_STATUS_NOT_SAME_DEVICE to trigger the Windows client to
start a copy itself. Unbeknownst to us via the ACLs snapshots are read-only, so
a rename would trigger a EACCES. Unfortunately the MacOS/X finder does not do
the smart NOT_SAME_DEVICE fallback that Windows does.
Christian Ambach [Thu, 9 Dec 2010 10:25:17 +0000 (11:25 +0100)]
s3:registry correct a debug level
this is not a level 0 message, move it to 10
Volker Lendecke [Tue, 23 Nov 2010 13:49:12 +0000 (14:49 +0100)]
s3:winbind: Protect against invalid winbindd_cache entries in lookuprids
Gregor Beck [Wed, 29 Sep 2010 13:13:55 +0000 (15:13 +0200)]
s3-net: add roundtrip tests for registry import/export
Volker Lendecke [Mon, 8 Mar 2010 16:59:35 +0000 (17:59 +0100)]
packaging(RHEL-CTDB): explicitly build the tsm vfs module.
Volker Lendecke [Thu, 3 Dec 2009 00:55:52 +0000 (01:55 +0100)]
s3: Fix the code to immediately disconnect from a non-working ctdbd
Rusty Russell [Fri, 20 Nov 2009 09:39:57 +0000 (10:39 +0100)]
s3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!)
On my autocluster setup, it's not set. Maybe it should be? Otherwise
smbclient and some Windows client programs will get errors like:
# smbclient //localhost/data -Uadministrator%XXX
Domain=[VSOFS1] OS=[Unix] Server=[Samba 3.4.2-ctdb-10]
smb: \> put /etc/resolv.conf resolv.conf
NT_STATUS_ACCESS_DENIED closing remote file \resolv.conf
smb: \>
Caused by attempting to update the time on close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
Günther Deschner [Fri, 21 Jan 2011 09:38:23 +0000 (10:38 +0100)]
s3-spoolss: make it more obvious what winreg_create_printer() does.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 11:43:29 CET 2011 on sn-devel-104
(cherry picked from commit
8db3258983bcf4ad73679a5bd5a554adc062a324)
Günther Deschner [Fri, 21 Jan 2011 09:34:38 +0000 (10:34 +0100)]
s3-rpcclient: rename duplicate enumkey command to winreg_enumkey.
Guenther
(cherry picked from commit
621fb88e331bb247d1726e7ffcd2a3c4819e6e14)
Günther Deschner [Wed, 19 Jan 2011 13:39:50 +0000 (14:39 +0100)]
s3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode minus the driverdata extra size.
Jeremy, please check.
Guenther
(cherry picked from commit
be884c1bfdfec24c067705af132a4d7dce807376)
Günther Deschner [Wed, 19 Jan 2011 13:39:36 +0000 (14:39 +0100)]
s4-smbtorture: make sure there is always driverextra data in spoolss devmode size tests.
Guenther
(cherry picked from commit
1f3fb30ed938d1ffdf4fbdcbc8b429becbbdb801)
Günther Deschner [Wed, 19 Jan 2011 12:49:51 +0000 (13:49 +0100)]
s3-spoolss: disallow storing an invalid devmode size.
Guenther
(cherry picked from commit
9b1878e538a39b5459a74790b371ef5c098e0642)
Günther Deschner [Wed, 19 Jan 2011 12:48:17 +0000 (13:48 +0100)]
s4-smbtorture: add tests for the size member of spoolss devicemodes.
Guenther
(cherry picked from commit
aefbec52703a10ebe49ddd4883ea728116825114)
Günther Deschner [Wed, 19 Jan 2011 12:44:46 +0000 (13:44 +0100)]
s4-smbtorture: prepare devicemode test for expected result tests.
Guenther
(cherry picked from commit
7a7b61ef082070de9407c937a86e299a98a6ef58)
Günther Deschner [Tue, 18 Jan 2011 23:15:09 +0000 (00:15 +0100)]
s4-smbtorture: add some paranoia checks for 0 sized devmodes.
Guenther
(cherry picked from commit
bb51c050149c2e2ea5bf81f283da862fc1e840d2)
Andrew Tridgell [Wed, 19 Jan 2011 00:04:05 +0000 (11:04 +1100)]
waf: change private libraries to use the same soname as public libraries
See
http://lists.samba.org/archive/samba-technical/2011-January/075816.html
for a description of the reason behind this change
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Jan 19 02:21:06 CET 2011 on sn-devel-104
(cherry picked from commit
7d8e9706f7829feaef928424e76bd7df6e223762)
Stefan Metzmacher [Wed, 8 Dec 2010 11:02:51 +0000 (12:02 +0100)]
buildtools: add the PRIVATE_EXTENSION for private libraries
metze
(cherry picked from commit
aee086c4d5a5b591814e7e78b3f24420a8ffff48)
Jelmer Vernooij [Tue, 21 Dec 2010 22:52:15 +0000 (23:52 +0100)]
wafsamba: Allow newer or the same python module versions to be installed,
not older.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Dec 22 00:42:23 CET 2010 on sn-devel-104
(cherry picked from commit
e43de85b97dfa584ba9cfb7b18ed302fddb767ae)
Stefan Metzmacher [Wed, 5 Jan 2011 11:16:15 +0000 (12:16 +0100)]
buildtools/wafsamba: import 'sys' and 'Logs' if we use them
We should avoid generating a backtrace in a normal
error case, just because sys.exit(1) isn't known.
metze
(cherry picked from commit
e0a9b58de8bd86122d17c0330cb1f0330207c023)
Jeremy Allison [Fri, 21 Jan 2011 00:32:57 +0000 (16:32 -0800)]
Remove all uses of "./" in pathnames - make canonical. This will become important when we need to guarantee canonical names for hashing.
(cherry picked from commit
f278cc1a1f253b6492ef60c2879bdae6a2730084)
Jeremy Allison [Fri, 21 Jan 2011 00:30:28 +0000 (16:30 -0800)]
Ensure we don't use "./" in findfirst pathnames. Use a directory open of "." instead.
(cherry picked from commit
de4b09ca01b1747c49bb0058147977ff39d054bb)
Jeremy Allison [Fri, 21 Jan 2011 00:27:56 +0000 (16:27 -0800)]
Make processing of incoming stream rename paths common between reply_mv and ntrename. Ensure we don't depend on "./" in the streams module.
(cherry picked from commit
bb54f72b94dca9206bf377b0d6a4b669e389e339)
Stefan Metzmacher [Tue, 26 Oct 2010 20:49:46 +0000 (22:49 +0200)]
s3:smbd: use anonymous_shared_free() for shared memory signing state
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 07:48:29 CET 2011 on sn-devel-104
(cherry picked from commit
c3ad9bf1572abda699d88f48eabec680094b30de)
Signed-off-by: Stefan Metzmacher <metze@samba.org>