Michael Adam [Mon, 7 Jul 2008 16:12:02 +0000 (18:12 +0200)]
build: fix typo in use of cleanlibsmbclient target
Michael
(cherry picked from commit
5712062d22237768a671aa918e39a22d290b0f0a)
conflicts resolved
Michael Adam [Mon, 7 Jul 2008 12:04:32 +0000 (14:04 +0200)]
build: add a cleanlibaddns target and use it in "make clean"
Michael
(cherry picked from commit
39a447a232d0afbef55437a995f557553cbc8a0e)
conflicts resolved
Michael
Michael Adam [Mon, 7 Jul 2008 11:57:34 +0000 (13:57 +0200)]
build: handle libaddns by SMB_LIBRARY() and correctly create SONAME file.
Create .so file as a symlink.
Michael
(cherry picked from commit
bbf665ad5790e89ff01867e2762fe2b94db7277d)
Michael Adam [Mon, 7 Jul 2008 11:55:31 +0000 (13:55 +0200)]
build: extend SMB_LIBRARY() to optionally take default value.
The default value defaults to "yes".
If no is specified, an optional third argument contains the
reason why building of the shared library is turned off by default.
Michael
(cherry picked from commit
af971f79c7d736eb5b7ae8fcd4b2bf7ccf4834f3)
Michael Adam [Mon, 7 Jul 2008 16:28:53 +0000 (18:28 +0200)]
build: move LIBADDNS_OBJ0 up again -- needed for NET_OBJ :-\
Michael
(cherry picked from commit
b871cb0cb6d32e5e97666bd429d0fb9940ae4b2e)
conflicts resolved
Michael Adam [Mon, 7 Jul 2008 09:59:10 +0000 (11:59 +0200)]
build: move libaddns related bits to the libaddns section in Makefile.in
Michael
(cherry picked from commit
61157cb92ec2c12e565fb088170c7f430e3b5b77)
conflicts resolved
Michael Adam [Mon, 7 Jul 2008 07:26:21 +0000 (09:26 +0200)]
build: create cleanlibsmbsharemodes target and use it in "make clean".
Michael
(cherry picked from commit
20a5053f0e75176e9ec1d4fd5a18626bbe3a0267)
conflicts resolved
Michael Adam [Sun, 6 Jul 2008 22:41:23 +0000 (00:41 +0200)]
build: handle libsmbsharemodes by SMB_LIBRARY() and correctly create SONAME file.
Create libsmbsharemodes.so as a symlink.
Michael
(cherry picked from commit
1157048146084e9ab34d7c2e77e8d00b22df53a4)
Michael Adam [Sun, 6 Jul 2008 22:23:57 +0000 (00:23 +0200)]
build: move libsmbsharemodes related vars and targets to libsmbsharemodes section in Makefile.in
Michael
(cherry picked from commit
278dde8a6c486505c2d7403103ba011e1abb039e)
Michael Adam [Sun, 6 Jul 2008 22:20:47 +0000 (00:20 +0200)]
build: add structuring comment for libbigballofmud
(cherry picked from commit
879b000fd3ad123f64017071a6aaa17cdc926995)
Michael Adam [Sun, 6 Jul 2008 22:06:28 +0000 (00:06 +0200)]
build: add cleanlibsmbclient target and use it in make clean.
Michael
(cherry picked from commit
95a7d21d3150ca9c24d48cf6a2976dcc1dfaaa05)
conflicts resolved
Michael Adam [Sun, 6 Jul 2008 22:02:50 +0000 (00:02 +0200)]
build: handle libsmbclient by SMB_LIBRARY() and correctly create soname file.
Create libsmbclient.so as a symlink to libsmbclient.so.0.
Michael
(cherry picked from commit
c463bd0cb9927176eec89e25788c6ea78eafdd16)
Michael Adam [Sun, 6 Jul 2008 21:37:06 +0000 (23:37 +0200)]
build: slightly change and extend the logic of SMB_LIBRARY().
Only call the install/uninstall targets (from make (un)install)
for libraries configured with SMB_LIBRARY(), when the user did
not set --with-libname=no.
Make sure to always (at least) build the static version of the library.
Michael
(cherry picked from commit
f440538c9480134ff05cf9c9f78a565808161101)
Michael Adam [Sun, 6 Jul 2008 20:10:23 +0000 (22:10 +0200)]
build: rename (un)installclientlib to (un)installlibsmbclient
keeping old targets as aliases for backward compatibility
Michael
(cherry picked from commit
40ff40de5780fb17567b8d5ea75f5bb7f8d811c4)
Michael Adam [Sun, 6 Jul 2008 20:08:28 +0000 (22:08 +0200)]
build: move libsmbclient related variables and targets to libsmbclient section
Michael
(cherry picked from commit
ed3c35d307456601ca00d88a5cc278d6604681e1)
Michael Adam [Sun, 6 Jul 2008 19:27:18 +0000 (21:27 +0200)]
build: move definition of SHLIBS to libraries section
Michael
(cherry picked from commit
36c99a3cad3c938a874f9b9f37c2265045957099)
Michael Adam [Sun, 6 Jul 2008 19:23:11 +0000 (21:23 +0200)]
build: add a cleanlibwbclient target to Makefile.in and use it for make clean.
Michael
(cherry picked from commit
e01a1d8d651f680ca58b809dc569ff74592d53a9)
conflicts resolved
Michael Adam [Sun, 6 Jul 2008 19:20:54 +0000 (21:20 +0200)]
build: add uninstalllibwbclient to Makefile.in and use it for uninstall
Michael
(cherry picked from commit
2712dade9d6495f3dbb75876ec32d73f8bb93f9f)
Michael Adam [Sun, 6 Jul 2008 19:14:17 +0000 (21:14 +0200)]
build: fix the installlibwbclient target to use defined variables and install the symlink
Michael
(cherry picked from commit
922b136ada1c502edcbbb89e9cca155cd6ad376c)
Michael Adam [Sun, 6 Jul 2008 18:48:00 +0000 (20:48 +0200)]
build: fix creation of libwbclient shared lib by crating soname file
and adding .so file as a symlink
Michael
(cherry picked from commit
beab1a31484836014aab5d2bcb38995435f6218b)
Michael Adam [Thu, 14 Aug 2008 12:44:30 +0000 (14:44 +0200)]
Revert "build: fix creation of libsmbsharemodes.a - don't link in libtdb.a."
This reverts commit
4fc57a0a90390ede1161fd6f231ea274c9c74b20.
In preparation of picking libraray creation/install fixes.
To be re-added later in upstream form.
Michael
Michael Adam [Thu, 14 Aug 2008 12:43:58 +0000 (14:43 +0200)]
Revert "build: fix creation of libsmbclient.a - don't link in libtalloc.a"
This reverts commit
dcf986937ccf5e6947c4214aa0838733ed7f3b9b.
In preparation of picking libraray creation/install fixes.
To be re-added later in upstream form.
Michael
Michael Adam [Thu, 14 Aug 2008 12:43:31 +0000 (14:43 +0200)]
Revert "build: fix creation of libaddns.a - don't link in libtalloc.a"
This reverts commit
396310775e69baeee06b2e6469854a5ddf759a91.
In preparation of picking libraray creation/install fixes.
To be re-added later in upstream form.
Michael
Michael Adam [Thu, 14 Aug 2008 12:43:05 +0000 (14:43 +0200)]
Revert "build: fix build on systems with picky make and without shared libwbclient"
This reverts commit
fd9b4bcaa5302d3d6245eb7b21ce0ef9994f718d.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:42:49 +0000 (14:42 +0200)]
Revert "build: use $(POPT_LIBS) instad of @POPT_LIBS@ in rules."
This reverts commit
2d2b48749e885d2a529dab273c8419c5445568d3.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:40:54 +0000 (14:40 +0200)]
Revert "build: use $(LIBTALLOC_LIBS) instead of @LIBTALLOC_LIBS@ in rules."
This reverts commit
15dd9f78650b0b853cb6955429ae58656be3945e.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:40:37 +0000 (14:40 +0200)]
Revert "build: use $(LIBTDB_LIBS) instead of @LIBTDB_LIBS@ in rules."
This reverts commit
0f609e55d8c58285de73fa0955df951042dfd9a0.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:40:11 +0000 (14:40 +0200)]
Revert "build: link in $(WINBIND_LIBS) instead of @LIBWBCLIENT_SHARED@"
This reverts commit
a60d295d3ac4a6e7a055927951f7207f09a3df7c.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:39:54 +0000 (14:39 +0200)]
Revert "build: use $(LIBNETAPI_LIBS) instead of @LIBNETAPI_LIBS@ in rules."
This reverts commit
22d0f686eb6649b3d4a8c7f142257e303c54568e.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:39:37 +0000 (14:39 +0200)]
Revert "build: use $(LDAP_LIBS) instead of @LDAP_LIBS@ in rules."
This reverts commit
a7ee1c16c234ad5d0aa8853081d8f5f4f763614b.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:39:20 +0000 (14:39 +0200)]
Revert "build: use $(WINBIND_NSS_EXTRA_LIBS) instead of @WINBIND_NSS_EXTRA_LIBS@ in rules."
This reverts commit
7420f409c2fbfd5f90d45a4a435489fe31016581.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:38:59 +0000 (14:38 +0200)]
Revert "build: use $(WINBIND_NSS_PTHREAD) instead of @WINBIND_NSS_PTHREAD@ in rules."
This reverts commit
1aad6661adc5800243969b761c653b57ff280f69.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Thu, 14 Aug 2008 12:38:02 +0000 (14:38 +0200)]
Revert "build: use $(PAM_WINBIND_EXTRA_LIBS) instead of @PAM_WINBIND_EXTRA_LIBS@ in rules."
This reverts commit
9a2870e936a967b82a100b1e26200d3665311f85.
In preparation of picking libraray creation/install fixes.
To be re-added later.
Michael
Michael Adam [Sun, 6 Jul 2008 18:44:27 +0000 (20:44 +0200)]
build: move libwbclient related target to libwbclient section in Makefile.in
Michael
(cherry picked from commit
8f64706b095b9ca0e2a8f39cc3133bfd02f86158)
resolved conflicts
Michael Adam [Sun, 6 Jul 2008 18:39:45 +0000 (20:39 +0200)]
build: move libtdb target further down following common schema like with libtalloc
Michael
(cherry picked from commit
f94b07f0c56928f890ffb1e2aca2c8bfcc954dd5)
Michael Adam [Sun, 6 Jul 2008 18:38:03 +0000 (20:38 +0200)]
build: fix uninstalllibnetapi target - handle symlink libnetapi.so
and use the defined variables instead of hardcoded bits.
Also move the target into the libnetapi section (forgotten last time).
Michael
(cherry picked from commit
21b6164795344cea45161bc01828ec1127b5b6ab)
Michael Adam [Sun, 6 Jul 2008 18:35:13 +0000 (20:35 +0200)]
build: fix installlibnetapi target - install symlink libnetapi.so (if appropriate)
Michael
(cherry picked from commit
59e7827e557c5096fb363051a4cf1835b2a53223)
Michael Adam [Sun, 6 Jul 2008 18:28:43 +0000 (20:28 +0200)]
build: add a cleanlibnetapi target and use it in make clean
Michael
(cherry picked from commit
ff62887a94a7dd6f09995c820db7d825828bacad)
resolved conflicts
Michael Adam [Sun, 6 Jul 2008 18:25:16 +0000 (20:25 +0200)]
build: fix creation of the libnetapi shared lib: create soname library
and add the .so file as symlink
Michael
(cherry picked from commit
d9af2f7ab6b839e8074a69ce5d1fe66548c08e52)
Michael Adam [Sun, 6 Jul 2008 18:11:50 +0000 (20:11 +0200)]
build: move libnetapi related definitions and targets together into the libnetapi section.
in Makefile.in
Michael
(cherry picked from commit
da29e1ce44d4f99b876259fbad892691e2c7d7e0)
resolved conflicts
Michael Adam [Sun, 6 Jul 2008 12:43:12 +0000 (14:43 +0200)]
build: add an uninstalllibtdb target.
Michael
(cherry picked from commit
c50c847f4b9772261f8011f32eec97d8244dccdd)
Michael Adam [Sun, 6 Jul 2008 12:42:30 +0000 (14:42 +0200)]
build: fix the installlibtdb target to install the soname file of libtdb.
and create the .so file as a symlink (if appropriate)
Michael
(cherry picked from commit
5c090762f769b645c411333aef2085362bb2e6cb)
Michael Adam [Sun, 6 Jul 2008 12:37:29 +0000 (14:37 +0200)]
build: create a cleanlibtdb target and use it in target clean.
Michael
(cherry picked from commit
ebfe13b79b24791bd9c854ac2f239f02796da6bb)
resolved conflicts
Michael Adam [Sun, 6 Jul 2008 12:32:36 +0000 (14:32 +0200)]
build: fix creation of the libtdb shared library.
Create the libtdb.so.1 file and create the .so file as the symlink.
Not vice versa.
Michael
(cherry picked from commit
662d666b41b11ae70daf7422b1ced5f86209e608)
Michael Adam [Sun, 6 Jul 2008 11:07:54 +0000 (13:07 +0200)]
build: move libtdb related definitions and targets to libtdb section in Makefile.in
Michael
(cherry picked from commit
a4de301af48f4e5b4898751e8836bdb434d047a6)
Michael Adam [Sun, 6 Jul 2008 11:02:40 +0000 (13:02 +0200)]
build: move all libtalloc related definitions into the libtalloc section in Makefile.in
Michael
(cherry picked from commit
b330892f4b2f9f50fd192e37720217d15fedf1f0)
Michael Adam [Sun, 6 Jul 2008 10:53:21 +0000 (12:53 +0200)]
build: move top level targets for the libs into the corresponding sections in Makefile.in
Michael
(cherry picked from commit
4092059ff0bbb638c937c3f2b977ad431d868331)
Michael Adam [Sun, 6 Jul 2008 10:51:04 +0000 (12:51 +0200)]
build: add more structuring comments to Makefile.in
for several shared libs and shared modules section
Michael
(cherry picked from commit
53cc6a3225c0c7baea4d8ea04eefc61283650434)
Michael Adam [Fri, 23 May 2008 11:42:40 +0000 (13:42 +0200)]
build: add a "make shlibs" target to build all the shared libraries.
Michael
(cherry picked from commit
5a99f59d7514edadbab081dc0c5c28a6ea26972a)
Michael Adam [Sun, 6 Jul 2008 10:39:24 +0000 (12:39 +0200)]
build: add structuring comments for libraries and libtalloc section.
Michael
(cherry picked from commit
3de000890447dd15962fbd6a9b1b3504b9bd1175)
Michael Adam [Mon, 7 Jul 2008 14:16:28 +0000 (16:16 +0200)]
build: fix installlibtalloc to not install symlink if the library is not there
Michael
(cherry picked from commit
52ccb52c8e42e748fcc05337849945ddc30d5efa)
Michael Adam [Sun, 6 Jul 2008 00:52:09 +0000 (02:52 +0200)]
build: move libtalloc related targets together.
Michael
(cherry picked from commit
01b1e642d72ecccac5277b5f071aab8f6df04c0d)
Michael Adam [Sun, 6 Jul 2008 00:48:39 +0000 (02:48 +0200)]
build: add a cleanlibtalloc target.
Michael
(cherry picked from commit
5d3c6c3c1c08747c521292ef09648ad528c2dca9)
resolved conflicts
Michael Adam [Sun, 6 Jul 2008 00:40:19 +0000 (02:40 +0200)]
build: add an uninstalllibtalloc target
Michael
(cherry picked from commit
4b6ef6202cd9b6e1e8949c43d0c45c04d4b97438)
Michael Adam [Sun, 6 Jul 2008 00:32:09 +0000 (02:32 +0200)]
build: fix creation of link libtalloc.so on some systems.
ln -s -f seem to be unknown on some solaris versions (e.g.).
so if there is an old libtalloc.so around, this will fail.
use rm -f prior to creating the link to circumvent this.
Michael
(cherry picked from commit
d913b1e7316e84c1430f9d577f49d3c3e4e7719b)
Michael Adam [Sun, 6 Jul 2008 00:30:38 +0000 (02:30 +0200)]
build: fix the installlibtalloc target to install SONAME and \.so versions of shared lib.
Michael
(cherry picked from commit
49919889892f258cc669b08417e7569e8f5efaf4)
Michael Adam [Sun, 6 Jul 2008 00:29:02 +0000 (02:29 +0200)]
build: fix creation of talloc shared lib.
link the libtalloc.so.1 file and create libtalloc.so as a link
Michael
(cherry picked from commit
946537e6bec904d4a7937eeb6085dfac19c3e2b5)
Michael Adam [Sun, 6 Jul 2008 00:26:57 +0000 (02:26 +0200)]
build: add ability to use library files of the form NAME.so.VERSION to create version script name.
Michael
(cherry picked from commit
b8d13f8773f61863b71bfc9df468f0018b0db0d1)
Jelmer Vernooij [Sun, 18 May 2008 16:39:48 +0000 (18:39 +0200)]
Add double-colon where it makes sense.
(cherry picked from commit
256200e951476ff31c95a7d5621a50ba297ea6e4)
Conflicts resolved (obnox)
Michael Adam [Thu, 14 Aug 2008 09:48:23 +0000 (11:48 +0200)]
Revert "build: fix bug #5608: link creation for libtalloc.so.1 (and friends) on solaris 8"
This reverts commit
f4d26db5dfccb962f5ca2cc03e9012a9883e16d8.
In preparation of the library cration / installation changes.
Michael
Karolin Seeger [Thu, 14 Aug 2008 06:52:36 +0000 (08:52 +0200)]
WHATSNEW: Update changes since 3.2.1.
Karolin
Jeremy Allison [Wed, 13 Aug 2008 23:53:28 +0000 (16:53 -0700)]
Fix coverity CID: 594. Resource leak on error path.
Jeremy.
Jeremy Allison [Wed, 13 Aug 2008 23:46:49 +0000 (16:46 -0700)]
Fix for bug #5688 from SATOH Fumiyasu <fumiyas@osstech.co.jp>. LPQ process is orphaned if socket address parameter is invalid.
If the "socket address" parameter is a null string that is an invalid value for Samba 3.2 but valid for Samba 3.0.
Jeremy.
Jeremy Allison [Wed, 13 Aug 2008 22:48:26 +0000 (15:48 -0700)]
Fix for bug #5617, reported and patched by Bartosz Antosik antosik@gmail.com.
xp/2003 explorer freezes browsing shares on samba ipv6 hosts. Caused by missing
reply packet to SMB printclose packet.
Jeremy
Jim McDonough [Wed, 13 Aug 2008 22:03:51 +0000 (18:03 -0400)]
Prevent NT_STATUS 0xF1000000 errors from appearing when
dos errors are used and there is no error. It should
be mapped directly to NT_STATUS_OK. smbclient to older
servers didn't work.
Karolin Seeger [Wed, 13 Aug 2008 14:38:18 +0000 (16:38 +0200)]
WHATSNEW: Update changes since 3.2.1.
Karolin
Günther Deschner [Tue, 12 Aug 2008 17:38:22 +0000 (19:38 +0200)]
netapi: add c++ guard.
Guenther
Volker Lendecke [Tue, 12 Aug 2008 20:31:52 +0000 (22:31 +0200)]
Attempt to fix bug 5684
With the ctdb checkin
dde9f3f006 tdb optimized out write lock checks for
write-enabled transaction. Sadly, this also removed the possibility to ever
remove dead records left over from tdb_delete calls within a transaction.
Tridge, please check this! Did
dde9f3f006 have any reason beyond performance
optimizations?
Thanks,
Volker
Andrew Tridgell [Sun, 10 Aug 2008 00:43:36 +0000 (10:43 +1000)]
I found lots of places where we assume error will be set when calling
one of our virtualised functions, such as db_open(), but error is only
set when a system call fails, and it is not uncommon for us to fail a
function internally without ever making a system call. That led to us
passing back success when a function had in fact failed.
I found two places where we relied on map_nt_error_from_unix()
returning success when errno==0, but lots and lots of places where we
relied on the reverse, so I fixed those two places.
map_nt_error_from_unix() will now always return an error, returning
NT_STATUS_UNSUCCESSFUL if errno is 0
(cherry picked from commit
69d40ca4c1af925d4b0e59ddc69ef8c26e6501d1)
Jeremy Allison [Tue, 12 Aug 2008 21:10:52 +0000 (14:10 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Michael Adam [Tue, 12 Aug 2008 12:59:59 +0000 (14:59 +0200)]
Fix unix_convert() for "*" after changing map_nt_error_from_unix().
map_nt_error_from_unix() now assumes that it is called in
an error path and returns an error even for a given errno == 0.
The original behaviour of unix_convert() used the mapping
of errno == 0 ==> NT_STATUS_OK to return success through
an error path.
I think this must have been an oversight, and unix_convert() worked
only by coincidence (or because explicitly using the knowledge
of the conceptually wrong working of map_nt_error_from_unix().
This patch puts this straight by not interpreting errno == 0
as an error condition and proceeding in that case.
Jeremy - please check!
Michael
Michael Adam [Tue, 12 Aug 2008 13:19:17 +0000 (15:19 +0200)]
Make sure to always set errno on error path in OpenDir (and hence scan_directory).
Michael
Herb Lewis [Tue, 12 Aug 2008 20:55:50 +0000 (13:55 -0700)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into my32-test
Herb Lewis [Tue, 12 Aug 2008 20:38:51 +0000 (13:38 -0700)]
print correct test status
Jeremy Allison [Tue, 12 Aug 2008 20:34:00 +0000 (13:34 -0700)]
Fix bug 5686 - libsmbclient segfaults with more than one SMBCCTX.
Here is a patch to allow many subsystems to be re-initialized. The only
functional change I made was to remove the null context tracking, as the memory
allocated here is designed to be left for the complete lifetime of the program.
Freeing this early (when all smb contexts are destroyed) could crash other
users of talloc.
Jeremy.
Günther Deschner [Mon, 11 Aug 2008 09:20:38 +0000 (11:20 +0200)]
fix build warning.
Guenther
Karolin Seeger [Mon, 11 Aug 2008 14:46:15 +0000 (16:46 +0200)]
WHATSNEW: Update changes since 3.2.1.
Karolin
Volker Lendecke [Sun, 10 Aug 2008 15:53:35 +0000 (17:53 +0200)]
fix smb_len calculation for chained requests
I think chain_reply() is one of the most tricky parts of Samba. This recursion
needs to go away, we need to sequentially walk the chain list.
Volker Lendecke [Sun, 10 Aug 2008 15:37:08 +0000 (17:37 +0200)]
Fix andx offset calculation for more than 2 chained requests
Untested code is broken code.... Test follows later, it's quite an intrusive
change to libsmb/
Jeremy Allison [Fri, 8 Aug 2008 23:08:36 +0000 (16:08 -0700)]
One more build fix. Ensure we have KRB5_AUTH_CONTEXT_USE_SUBKEY defined before we compile the new code.
Jeremy.
Jeremy Allison [Fri, 8 Aug 2008 22:16:04 +0000 (15:16 -0700)]
Try and fix the build for systems that don't have krb5_auth_con_set_req_cksumtype().
Jeremy.
Jeremy Allison [Fri, 8 Aug 2008 21:33:00 +0000 (14:33 -0700)]
Add Derrick Schommer's <dschommer@F5.com> kerberos delegation patch. Some
work by me and advice by Love.
Jeremy.
Yannick Bergeron [Fri, 8 Aug 2008 17:32:15 +0000 (13:32 -0400)]
using NGROUPS_MAX instead of 32 for the max group value in rep_initgroups() subroutine in lib/replace/replace.c
Jeremy Allison [Fri, 8 Aug 2008 00:56:50 +0000 (17:56 -0700)]
Fix bug #5675 with a varient of Tim Waugh's patch,
as proposed by James Peach.
Jeremy.
Yannick Bergeron [Wed, 6 Aug 2008 17:23:00 +0000 (13:23 -0400)]
Solve an IBM XL C/C++ compiler error encountered in get_exit_code() auth_errors array initialization in client/smbspool.c
Andrew Tridgell [Wed, 6 Aug 2008 06:35:43 +0000 (16:35 +1000)]
fixed permissions on ctdb databases
(cherry picked from commit
123fc3980a83d956bffaa689f3af81bbf81ce1c1)
Andrew Tridgell [Wed, 6 Aug 2008 04:02:45 +0000 (14:02 +1000)]
fixed a fd leak when trying to regain contact to a domain controller
in winbind
When a w2k3 DC is rebooted the 139/445 ports come up before the
udp/389 cldap port. During this brief period, winbind manages to
connect to 139/445 but not to udp 389. It then enters a tight loop
where it leaks one fd each time. In a couple of seconds it runs out of
file descriptors, and leaves winbind crippled after the DC does
finally come up
(cherry picked from commit
57187cafbcc053e75bb54750494df9feabe3a738)
Michael Adam [Tue, 5 Aug 2008 21:38:56 +0000 (23:38 +0200)]
dbwrap: add comment describing behaviour of dbwrap_change_int32_atomic().
Michael
(cherry picked from commit
f8f21c8e3922806230e240cb54205fc2db7a3619)
Michael Adam [Tue, 5 Aug 2008 21:14:05 +0000 (23:14 +0200)]
secrets: fix replacemend random seed generator (security issue).
This is a regression introduced by the change to dbwrap.
The replacement dbwrap_change_int32_atomic() does not
correctly mimic the behaviour of tdb_change_int32_atomic():
The intended behaviour is to use *oldval as an initial
value when the entry does not yet exist in the db and to
return the old value in *oldval.
The effect was that:
1. get_rand_seed() always returns sys_getpid() in *new_seed
instead of the incremented seed from the secrets.tdb.
2. the seed stored in the tdb is always starting at 0 instead
of sys_getpid() + 1 and incremented in subsequent calls.
In principle this is a security issue, but i think the danger is
low, since this is only used as a fallback when there is no useable
/dev/urandom, and this is at most called on startup or via
reinit_after_fork.
Michael
(cherry picked from commit
bfc5d34a196f667276ce1e173821db478d01258b)
Michael Adam [Tue, 5 Aug 2008 21:13:06 +0000 (23:13 +0200)]
dbwrap: add comment describing behaviour of dbwrap_change_uint32_atomic().
Michael
(cherry picked from commit
7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0)
Michael Adam [Tue, 5 Aug 2008 20:38:44 +0000 (22:38 +0200)]
idmap_tdb2: fix a race condition in idmap_tdb2_allocate_id().
The race is a regression introduced by the change to dbwrap.
It might have led to two concurrent processes returning the same id.
This fix is achieved by changing dbwrap_change_uint32_atomic() to
match the original behaviour of tdb_change_uint32_atomic(), which
is the following: *oldval is used as initial value when
the value does not yet exist and that the old value should be
returned in *oldval.
dbwrap_change_uint32_atomic() is used (only) in idmap_tdb2.c,
to get new ids.
Michael
(cherry picked from commit
72bd83fea7572a6202027b200d192c05023aa633)
Andrew Bartlett [Tue, 17 Jun 2008 12:45:29 +0000 (22:45 +1000)]
Without stdlib.h we don't get a prototype for free().
This test fails if GCC emits any warnings (presumably to detect the
function propertly), but unless we include this message then free()
fail. Why we need to call free in a configure test is probably
something to blame on valgrind...
Andrew Bartlett
(cherry picked from commit
d013f6fadc3e80fabb4a1784207dabc84f9b7dc2)
Karolin Seeger [Tue, 5 Aug 2008 13:14:51 +0000 (15:14 +0200)]
WHATSNEW: Start WHATSNEW for 3.2.2.
Karolin
Karolin Seeger [Tue, 5 Aug 2008 13:13:13 +0000 (15:13 +0200)]
VERSION: Raise version number up to 3.2.2.
Karolin
Karolin Seeger [Tue, 5 Aug 2008 12:20:32 +0000 (14:20 +0200)]
man pages: Improve description of boolean values in smb.conf.5.
This fixes bug #5378.
Thanks Morton K. Poulsen <morten+bugzilla.samba.org [at] afdelingp.dk>
for reporting!
Karolin
(cherry picked from commit
8195ca2132cbdba396dc35e9d04d4bdc3a8a666c)
Karolin Seeger [Tue, 5 Aug 2008 12:10:11 +0000 (14:10 +0200)]
man pages: Add documentation about smbclient command "rename".
This fixes bug #5268.
Thanks to Alexander Franz <a.franz [at] gmx.net> for reporting!
Karolin
(cherry picked from commit
0a93fd2dedfa7fed1ad0b8a5e079bf7be72a4bd5)
Karolin Seeger [Tue, 5 Aug 2008 06:21:13 +0000 (08:21 +0200)]
WHATSNEW: Update changes since 3.2.0.
Karolin
Yannick Bergeron [Mon, 4 Aug 2008 17:21:02 +0000 (13:21 -0400)]
Compile error on AIX 6.1
Karolin Seeger [Fri, 1 Aug 2008 12:10:28 +0000 (14:10 +0200)]
Samba3 HowTo: Fix duplicate chapter id.
Karolin
(cherry picked from commit
f67b6fd97e177a527e896861f337c2e70541f697)
Karolin Seeger [Thu, 31 Jul 2008 07:39:58 +0000 (09:39 +0200)]
WHATSNEW: Update changes since 3.2.0.
Karolin