Jeremy Allison [Tue, 19 Jul 2005 20:59:52 +0000 (20:59 +0000)]
r8615: Added "acl group control". Defaults to off. Docs to follow.
Jeremy.
Jeremy Allison [Tue, 19 Jul 2005 17:44:44 +0000 (17:44 +0000)]
r8610: If I'm going to do a debug level zero, at least make it useful.
Jeremy.
Jeremy Allison [Tue, 19 Jul 2005 17:38:38 +0000 (17:38 +0000)]
r8609: Fix for bugid #2889. I think the problem is that the top 16 bits of the "server state" field must be
non-zero. As we're using the 32 bit field as an offset then normally this field
will be zero. W2K3 fills this field with a counter enumerating the number of
SMBsearch calls on this directory - starting at 1. Add back the 1<<31 bit flag
DPTR_MASK to ensure this is non-zero - with better checks on use.
Jeremy.
Gerald Carter [Tue, 19 Jul 2005 16:22:42 +0000 (16:22 +0000)]
r8607: BUG 2900 more compiler warnings
Gerald Carter [Tue, 19 Jul 2005 14:51:20 +0000 (14:51 +0000)]
r8606: BUG 2899: fix compiler warning in regfio routine
Gerald Carter [Tue, 19 Jul 2005 12:57:02 +0000 (12:57 +0000)]
r8604: BUG 2890: fix unitialized variable reported by Jason Mader <jason@ncac.gwu.edu>
Tim Potter [Tue, 19 Jul 2005 10:15:10 +0000 (10:15 +0000)]
r8597: Use UNI_STR_TERMINATE (an enum value) instead of STR_TERMINATE (a
#define) to quieten a warning. Bugzilla #2892.
Tim Potter [Tue, 19 Jul 2005 10:01:32 +0000 (10:01 +0000)]
r8596: Don't wrap non-existent functions. Bugzilla #2895.
Tim Potter [Tue, 19 Jul 2005 09:59:37 +0000 (09:59 +0000)]
r8595: Delete unused prototypes.
Tim Potter [Tue, 19 Jul 2005 09:37:42 +0000 (09:37 +0000)]
r8592: I'm pretty sure this should be != instead of =!. Bugzilla #2893.
Tim Potter [Tue, 19 Jul 2005 03:54:01 +0000 (03:54 +0000)]
r8573: Fix set but not used warning in srvsvc server-side code.
Another bugzilla (#2891) from Jason Mader.
Tim Potter [Tue, 19 Jul 2005 02:37:04 +0000 (02:37 +0000)]
r8572: Remove crufty #define NO_SYSLOG as it's not used at all anymore.
Jeremy Allison [Tue, 19 Jul 2005 00:59:25 +0000 (00:59 +0000)]
r8564: Sometimes we're too dumb to live... Fix samr calls where we were
using USER_INFO_XX structs and functions where XX was sometimes
in hex and sometimes in decimal. Now it's all in decimal (should
be no functionality change).
Jeremy.
Jeremy Allison [Mon, 18 Jul 2005 22:32:35 +0000 (22:32 +0000)]
r8556: Fix bug #2878 - Norton commander not running on OS/2 client - we were
not correctly returning the requested open mode. Thanks to alex@infobit.ru
for reporting this.
Jeremy.
Jeremy Allison [Mon, 18 Jul 2005 22:10:20 +0000 (22:10 +0000)]
r8553: Another compile warning fix from jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Mon, 18 Jul 2005 20:47:38 +0000 (20:47 +0000)]
r8552: Warning fix from jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Mon, 18 Jul 2005 19:55:55 +0000 (19:55 +0000)]
r8547: Code tidyup from Jason Mader <jason@ncac.gwu.edu>. Bugid #2885.
Jeremy.
Jeremy Allison [Mon, 18 Jul 2005 18:50:13 +0000 (18:50 +0000)]
r8545: Fix oplock bug introduced by oplock code "simplification" :-).
We *always* reply to an exclusive oplock break message even if
we have no record of the oplock (and we always did before 3.0.20pre2).
Jeremy.
Gerald Carter [Mon, 18 Jul 2005 14:18:39 +0000 (14:18 +0000)]
r8543: merge volker's nt_printing_init() fix from trunk (r8526)
but make sure to write the new version to the ntdrivers.tdb.
Günther Deschner [Mon, 18 Jul 2005 13:16:52 +0000 (13:16 +0000)]
r8542: - (re-)add better search-semantics: look for Interdomain trust accounts
below the machine-suffix (this is where we create them)) to avoid
digging through thousands of user-accounts just to find a handful of
trust-accounts in the enumdomusers-samr-call.
- don't access freed data in DEBUG-statement
Guenther
Günther Deschner [Mon, 18 Jul 2005 08:25:21 +0000 (08:25 +0000)]
r8538: honour CC in python build.
Guenther
Volker Lendecke [Sun, 17 Jul 2005 21:01:17 +0000 (21:01 +0000)]
r8531: Fix a memleak
Volker Lendecke [Sun, 17 Jul 2005 09:56:25 +0000 (09:56 +0000)]
r8521: Another micro-step: Don't pass down a flag where not necessary.
Volker
Gerald Carter [Fri, 15 Jul 2005 21:36:00 +0000 (21:36 +0000)]
r8510: Don't include the valgrind headers on 64bit linux systems.
Several incarnations of gcc bork with
Compiling dynconfig.c
/tmp/ccXd94O5.s: Assembler messages:
/tmp/ccXd94O5.s:1202: Error: suffix or operands invalid for `mov'
/tmp/ccXd94O5.s:1289: Error: suffix or operands invalid for `mov'`
Thanks to Bent Vangli for the the leg work and suggestions.
Volker Lendecke [Fri, 15 Jul 2005 19:32:56 +0000 (19:32 +0000)]
r8508: Rename EXCLUSIVE_BREAK_SENT to BREAK_TO_NONE_SENT.
Volker
Gerald Carter [Fri, 15 Jul 2005 18:13:40 +0000 (18:13 +0000)]
r8507: BUG 2557: don't give and rpc fault when you get an unsupported SetPrinter() level
Gerald Carter [Fri, 15 Jul 2005 17:38:55 +0000 (17:38 +0000)]
r8506: BUG 2853: don't strip out characters like '$' from printer names
when substituting for the lpq command.
Gerald Carter [Fri, 15 Jul 2005 14:26:11 +0000 (14:26 +0000)]
r8501: * disable printer handle object cache (was mostly used
for NT4 clients enumerating printer data on slow CPUs)
* fix pinter and secdesc record upgrade to normalize the key
(rev'd printer tdb version)
* fixed problem that was normalizing the printername name field
in general, this should fix the issues upgrading print servers
from 3.0.14a to 3.0.20
Günther Deschner [Fri, 15 Jul 2005 11:56:16 +0000 (11:56 +0000)]
r8493: According to MSKB 141714 the %LOGONSERVER% variable should be
substituted like our %L-variable.
Guenther
Volker Lendecke [Fri, 15 Jul 2005 11:52:07 +0000 (11:52 +0000)]
r8492: open_mode_check does not use the parameter p_flags, so remove it.
Volker
Gerald Carter [Thu, 14 Jul 2005 18:15:10 +0000 (18:15 +0000)]
r8478: remove unused printmode command from smbclient (noticed by kalim@samba.org)
Gerald Carter [Thu, 14 Jul 2005 14:40:30 +0000 (14:40 +0000)]
r8475: BUG 2872: fix cut-n-paste error when checking pointer value in ntlmssp_set_workstation()
Gerald Carter [Thu, 14 Jul 2005 14:39:27 +0000 (14:39 +0000)]
r8472: abartlet's patch for parallel ntlmssp supporttrunk/source/smbd/sesssetup.c
Jeremy Allison [Thu, 14 Jul 2005 08:51:48 +0000 (08:51 +0000)]
r8457: Fix from Marcel Müller <mueller@maazl.de> to ensure
we correctly set the return packet size to include
the pad bytes in reply_readbmpx().
Jeremy.
Günther Deschner [Thu, 14 Jul 2005 08:02:10 +0000 (08:02 +0000)]
r8454: Fix Bug #2502
Removing deprecated lp_min_password_length (the same functionality is
provided by the account policy).
Note that we now allow to set passwords less then 5 chars (if the admins
decides to do so by setting the account policy).
Thanks to Daniel Beschorner <db@unit-netz.de>
Guenther
Lars Müller [Wed, 13 Jul 2005 21:10:12 +0000 (21:10 +0000)]
r8435: Use OPENX_FILE_EXISTS_OPEN instead of FILE_EXISTS_OPEN.
Jim McDonough [Wed, 13 Jul 2005 20:04:26 +0000 (20:04 +0000)]
r8432: Fix #2077 - login to trusted domain doesn't allow home drive map and login
scripts to be executed.
We were filling in our name as the server which processed the login, even
when it was done by a trusted DC.
Thanks to John Janosik <jpjanosi@us.ibm.com> for the fix.
Lars Müller [Wed, 13 Jul 2005 16:47:42 +0000 (16:47 +0000)]
r8431: Ensure to use dev_private and not private after Jeremy's CPP reserved
names rename.
Jerry: I'm not sure if we have to use the string 'dev_private' instead
of 'private' as second arg to PyDict_SetItemString().
Günther Deschner [Wed, 13 Jul 2005 14:46:57 +0000 (14:46 +0000)]
r8428: some more old printerdb stuff.
Guenther
Günther Deschner [Wed, 13 Jul 2005 14:44:12 +0000 (14:44 +0000)]
r8427: Printerdb has been moved into a tmp branch.
Guenther
Günther Deschner [Wed, 13 Jul 2005 00:26:52 +0000 (00:26 +0000)]
r8402: allow to build with --enable-aio-support.
Guenther
Günther Deschner [Tue, 12 Jul 2005 23:52:32 +0000 (23:52 +0000)]
r8398: Fix segfault in the client addprinterex-call. Found with "net rpc
printer"-functions.
Thanks to Thomas Di Naro (Novell) for the detailed debug-logs.
Guenther
Günther Deschner [Tue, 12 Jul 2005 23:02:31 +0000 (23:02 +0000)]
r8396: fix some compile warnings.
Guenther
Gerald Carter [Tue, 12 Jul 2005 17:23:19 +0000 (17:23 +0000)]
r8388: fix typo in installman script
Gerald Carter [Tue, 12 Jul 2005 16:37:39 +0000 (16:37 +0000)]
r8387: moving wins_hook to scripts directory
Gerald Carter [Tue, 12 Jul 2005 16:34:44 +0000 (16:34 +0000)]
r8384: merging clutter fixes from release branch
Volker Lendecke [Tue, 12 Jul 2005 09:18:50 +0000 (09:18 +0000)]
r8366: Root-level files don't have a slash, but acls need to be settable on
them. Thanks to Brent Trotter for reminding me to commit this :-)
Volker
Volker Lendecke [Tue, 12 Jul 2005 08:05:15 +0000 (08:05 +0000)]
r8360: Some ioctl constants, found by Björn Jacke <bj@sernet.de> with
msbackup&filemon.
Thanks,
Volker
Gerald Carter [Mon, 11 Jul 2005 20:05:00 +0000 (20:05 +0000)]
r8330: moving onto 3.0.20rc1-SVN
Gerald Carter [Mon, 11 Jul 2005 19:18:15 +0000 (19:18 +0000)]
r8327: * don't use unitialized variables
Gerald Carter [Mon, 11 Jul 2005 18:59:54 +0000 (18:59 +0000)]
r8326: factor out the delete printer code to a delete_printer_hook() for reuse
Gerald Carter [Mon, 11 Jul 2005 18:37:15 +0000 (18:37 +0000)]
r8325: * punt....don't normalize the printer name in the RegCreateKey().
Print Migrator now works as long as the addprinter command can
handle the name
Gerald Carter [Mon, 11 Jul 2005 18:27:22 +0000 (18:27 +0000)]
r8324: * initial cut at creating printers via the registry API
Need to add delete_key support
Gerald Carter [Mon, 11 Jul 2005 17:17:50 +0000 (17:17 +0000)]
r8323: * convert RegSetValue() calls immediately beneath the printer
key to PRINTER_INFO_2 fields.
Gerald Carter [Mon, 11 Jul 2005 16:55:10 +0000 (16:55 +0000)]
r8322: * get RegSetValue() working for printer subkey values
(not immediate values below the <printer name> key yet.
Jeremy Allison [Sun, 10 Jul 2005 16:40:06 +0000 (16:40 +0000)]
r8292: Tidy up function comments.
Jeremy.
Jeremy Allison [Sun, 10 Jul 2005 16:37:32 +0000 (16:37 +0000)]
r8290: Fix for bug in SMBwriteBraw where we incorrectly
returned the number of bytes written. Patch from
Marcel Müller <mueller@maazl.de>.
Jeremy.
Volker Lendecke [Fri, 8 Jul 2005 07:54:28 +0000 (07:54 +0000)]
r8231: Patch from James Peach to fix the IRIX build.
Thanks,
Volker
Jeremy Allison [Fri, 8 Jul 2005 04:51:27 +0000 (04:51 +0000)]
r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the torture
tests on this as it's very late NY time (just wanted to get this work
into the tree). I'll test this over the weekend....
Jerry - in looking at the difference between the two trees there
seem to be some printing/ntprinting.c and registry changes we might
want to examine to try keep in sync.
Jeremy.
Günther Deschner [Thu, 7 Jul 2005 14:19:51 +0000 (14:19 +0000)]
r8207: Fix my NT_STATUS_IS_OK mismatch.
Guenther
Günther Deschner [Thu, 7 Jul 2005 13:42:09 +0000 (13:42 +0000)]
r8205: try to improve readability of smbldap_search_domain_info()
Guenther
Jim McDonough [Wed, 6 Jul 2005 21:02:43 +0000 (21:02 +0000)]
r8189: commit vampire ldif patch, mostly from Don Watson (dwatson@us.ibm.com). Yes,
that's my copyright...that's just how we have to do things at big blue.
Adds subcommand to vampire to allow data to be put into an ldif file instead
of actually writing to the passdb. See "net rpc help vampire" for usage
info. This should be added to docs as well.
John Terpstra [Wed, 6 Jul 2005 19:21:43 +0000 (19:21 +0000)]
r8188: Update from Dave Collier-Brown.
Gerald Carter [Wed, 6 Jul 2005 14:46:36 +0000 (14:46 +0000)]
r8184: fix build issue on Solaris in smbclient
Günther Deschner [Mon, 4 Jul 2005 19:16:34 +0000 (19:16 +0000)]
r8155: ops, add missing function.
Guenther
Gerald Carter [Mon, 4 Jul 2005 16:52:29 +0000 (16:52 +0000)]
r8152: * remove commented out structure
* use SAMBA_PRINTER_PORT_NAME in registry values for builtin printer
port
Lars Müller [Mon, 4 Jul 2005 16:39:11 +0000 (16:39 +0000)]
r8151: Add support to create position independent executable (PIE) code if the
compiler supports it.
We have to compile with -fPIE and not -fpie. Else ppc and s390(x) will
fail (to small GOT).
It's possible to disable configure's PIE detection with --disable-pie
Günther Deschner [Mon, 4 Jul 2005 13:57:54 +0000 (13:57 +0000)]
r8145: When inventing a new parameter for SFU-support, be aware of Volker's
upcoming changes for "unixinfo"-pipe.
Therefor (after speaking with Volker) replace "winbind sfu support" with
the list-parameter "winbind nss info" which defaults to "template". For
SFU-support set it to "winbind nss info = template sfu".
Note that nss_info_use() is just a dummy function at the moment.
Guenther
Günther Deschner [Mon, 4 Jul 2005 13:51:17 +0000 (13:51 +0000)]
r8144: remove unused parameter leftover.
Guenther
Günther Deschner [Mon, 4 Jul 2005 13:36:41 +0000 (13:36 +0000)]
r8143: Fix generate_parm_table.py:
* Correctly substitute "\" as default winbind separator.
* Use default testparm-location.
Guenther
Gerald Carter [Mon, 4 Jul 2005 13:19:05 +0000 (13:19 +0000)]
r8141: Update volker's valgrind fix in r8097. Same effect, just helps me
to remember what is going on here better.
Gerald Carter [Mon, 4 Jul 2005 12:43:05 +0000 (12:43 +0000)]
r8140: adding missing module
Günther Deschner [Mon, 4 Jul 2005 09:56:27 +0000 (09:56 +0000)]
r8133: Got approval from Luke Howard (PADL) to change the company copyright to
to a personal one.
Thanks Luke!
Guenther
Volker Lendecke [Sun, 3 Jul 2005 12:05:07 +0000 (12:05 +0000)]
r8093: Next round. Now it compiles with --enable-socket-wrapper.
Volker
Volker Lendecke [Sun, 3 Jul 2005 10:20:03 +0000 (10:20 +0000)]
r8092: Attempt to fix the socket wrapper stuff for Samba 3.
Volker
Gerald Carter [Sun, 3 Jul 2005 02:05:01 +0000 (02:05 +0000)]
r8089: successfully delete printer subkeys via the registry....now for values
John Terpstra [Sat, 2 Jul 2005 19:17:29 +0000 (19:17 +0000)]
r8085: Updating info.
Gerald Carter [Sat, 2 Jul 2005 01:23:21 +0000 (01:23 +0000)]
r8066: * had to modify the printer data storage slightly in ntprinters.tdb
when packing values. It is a compatible change though and will
not require a tdb version upgrade
* Can successfully create new printer subkeys via winreg that
are immediately available via spoolss calls. Still cannot delete
keys yet though. That comes next.
Gerald Carter [Fri, 1 Jul 2005 22:24:00 +0000 (22:24 +0000)]
r8064: * add the REG_XXX error codes to the pretty error messages
* more work on the store_values() functions for the Printers key
* add Control\Print\Monitors key to list for reg_db
Volker Lendecke [Fri, 1 Jul 2005 19:23:50 +0000 (19:23 +0000)]
r8062: Remove some unused code
Gerald Carter [Fri, 1 Jul 2005 19:15:07 +0000 (19:15 +0000)]
r8061: * mostly cleanup and refactoring for better readability
* move to registry.tdb for port listing (at least via the winreg ops)
If no one opposes on the samba list, we'll move to a registry
lookup for enumerating ports rather than the 'enumports command'.
This means that there is a bit of a disconnect between EnumPorts() and
RegEnumKey('hklm\software\microsoft\windows nt\currentversion\ports').
Günther Deschner [Fri, 1 Jul 2005 10:28:31 +0000 (10:28 +0000)]
r8048: Replace "done" with "failed".
Guenther
Volker Lendecke [Fri, 1 Jul 2005 10:20:28 +0000 (10:20 +0000)]
r8047: "oid" is defined in a heimdal header. With my gcc this generates a ton of
shadowed variable warnings. Fix that.
Volker
John Terpstra [Thu, 30 Jun 2005 23:44:18 +0000 (23:44 +0000)]
r8031: Adding contributed mklogon scripts.
Volker Lendecke [Thu, 30 Jun 2005 21:25:41 +0000 (21:25 +0000)]
r8029: Fix bug 2841. Thanks to Brett Trotter.
Volker
Gerald Carter [Thu, 30 Jun 2005 20:16:16 +0000 (20:16 +0000)]
r8027: driver information is now back via winreg
Gerald Carter [Thu, 30 Jun 2005 19:43:53 +0000 (19:43 +0000)]
r8026: * more fixes to the printing registry interface
(still not completely back to the read functionality
we previously had but the cleanup is progressing)
Gerald Carter [Thu, 30 Jun 2005 19:33:47 +0000 (19:33 +0000)]
r8025: *how* can this code have been around so long and
nver normalized the string used for printer and
sec_desc key lookups ?????
normalized sharename to lower case before storing/fetching
from tdb.
Need to look at drivers and forms tdb as well (perhaps).
Gerald Carter [Thu, 30 Jun 2005 17:46:06 +0000 (17:46 +0000)]
r8022: * implement default actions rather than having to define functions
for every fetch/store callback (some keys should never have a value)
Günther Deschner [Thu, 30 Jun 2005 15:19:54 +0000 (15:19 +0000)]
r8019: Better give a hint that we are failing share-manipulation due to missing
scripts.
Guenther
Gerald Carter [Thu, 30 Jun 2005 03:29:48 +0000 (03:29 +0000)]
r8008: * start adding logic for restricting subkey paths
e.g. 'hklm\software\microsoft\windows nt\currentversion\ports'
should have no subkeys. Return an error if a client tries
to open a path below here
Gerald Carter [Thu, 30 Jun 2005 02:59:29 +0000 (02:59 +0000)]
r8007: * cleanup unused structure from reg_objects.h
* make regdb_store_XXX() and regdb_fetch_XXX() functions non-static
* use case sensitive string lookups in reg_dynamic.c since the
keys have already been normalized
* move to new design for making printing related data available
via the winreg pipe (with the intent of allowing writes)
Volker Lendecke [Wed, 29 Jun 2005 20:17:05 +0000 (20:17 +0000)]
r7998: Fix usage message
Gerald Carter [Wed, 29 Jun 2005 17:19:04 +0000 (17:19 +0000)]
r7997: Pointers don't kill people, people with pointers kill people...
"Honest office! It was a mistake! I thought the safety lock was on!"
* Fix problem setting registry values in in-memory objects
I now have printmig.exe successfully creating all of the printer
registry keys (in the tdb backend) which means that the top level
semantics are correct.
Gerald Carter [Wed, 29 Jun 2005 16:35:32 +0000 (16:35 +0000)]
r7995: * privileges are local except when they're *not*
printmig.exe assumes that the LUID of the SeBackupPrivlege
on the target server matches the LUID of the privilege
on the local client. Even though an LUID is never guaranteed
to be the same across reboots. How *awful*! My cat could
write better code! (more on my cat later....)
* Set the privelege LUID in the global PRIVS[] array
* Rename RegCreateKey() to RegCreateKeyEx() to better match MSDN
* Rename the unknown field in RegCreateKeyEx() to disposition
(guess according to MSDN)
* Add the capability to define REG_TDB_ONLY for using the reg_db.c
functions and stress the RegXXX() rpc functions.
Günther Deschner [Wed, 29 Jun 2005 14:03:53 +0000 (14:03 +0000)]
r7994: This adds support in Winbindd's "security = ads"-mode to retrieve the POSIX
homedirectory and the loginshell from Active Directory's "Services for Unix".
Enable it with:
winbind sfu support = yes
User-Accounts without SFU-Unix-Attributes will be assigned template-based
Shells and Homedirs as before.
Note that it doesn't matter which version of Services for Unix you use (2.0,
2.2, 3.0 or 3.5). Samba should detect the correct attributes (msSFULoginShell,
msSFU30LoginShell, etc.) automatically.
If you also want to share the same uid/gid-space as SFU then also use PADL's
ad-idmap-Plugin:
idmap backend = ad
When using the idmap-plugin only those accounts will appear in Name Service
Switch that have those UNIX-attributes which avoids potential uid/gid-space
clashes between SFU-ids and automatically assigned idmap-ids.
Guenther
Günther Deschner [Wed, 29 Jun 2005 13:49:29 +0000 (13:49 +0000)]
r7992: Adding PADL's idmap_ad plugin (taken from the latest
xad_oss_plugins-tarball).
Guenther
Gerald Carter [Tue, 28 Jun 2005 22:39:18 +0000 (22:39 +0000)]
r7987: map generic bits to specific bits in open requests
Jeremy Allison [Tue, 28 Jun 2005 21:48:09 +0000 (21:48 +0000)]
r7985: Add "acl map full control", true by default, to allow people to change
mapping of rwx to full control or not. Requested feature at SambaXP.
Jeremy.
Gerald Carter [Tue, 28 Jun 2005 20:29:34 +0000 (20:29 +0000)]
r7983: clean up some use of un-initialized variables found by valgrind