Michael Adam [Tue, 21 Aug 2007 21:55:51 +0000 (21:55 +0000)]
r24609: Fix the fix of r23668 for win2k giving one zero byte
instead of a 2-byte zero character. I can't recall what
rode me when I put that "2" there. But now I think I
have got it right... :-)
Michael
Stefan Metzmacher [Tue, 21 Aug 2007 19:23:05 +0000 (19:23 +0000)]
r24605: remove some stuff samba3 doesn't need any more
metze
Simo Sorce [Tue, 21 Aug 2007 18:45:45 +0000 (18:45 +0000)]
r24603: In case of error we need to free prefix_cache otherwise on re-init the first
statement will return positively but prefix_cache_hashes would be NULL
Michael Adam [Tue, 21 Aug 2007 14:47:15 +0000 (14:47 +0000)]
r24602: Add function lp_string_is_valid_boolean() to check if a string
contains a correct representation of a boolean value (in the
understanding of loadparm.c).
Make set_boolean() catch passing NULL for the boolean target.
Michael
Lars Müller [Tue, 21 Aug 2007 14:42:36 +0000 (14:42 +0000)]
r24601: Fix if statements where we still expected cli_connect() to return BOOL.
Stefan Metzmacher [Tue, 21 Aug 2007 14:22:16 +0000 (14:22 +0000)]
r24599: patch from Karolin Seeger <ks@sernet.de>:
smbd, nmbd and winbindd can be started with invalid options currently.
The first patch attached would be a possible solution.
It contains an exit if an invalid option has been used. The main problem
is, that existing setups with wrong options or missing arguments in start
scripts will break (which is the right behaviour from my point of view).
metze
Stefan Metzmacher [Tue, 21 Aug 2007 14:06:46 +0000 (14:06 +0000)]
r24597: - talloc request structure for the samba3 server bindings
and make that the primary context for the request
which the implementations can also use.
- go via functions pointers in the ndr_interface_table
instead of calling functions directly.
metze
Volker Lendecke [Tue, 21 Aug 2007 12:58:10 +0000 (12:58 +0000)]
r24595: Fix Coverity ID 393
In this error case we would have used "start" not having it initialized
Stefan Metzmacher [Tue, 21 Aug 2007 12:20:33 +0000 (12:20 +0000)]
r24594: pass down the ndr_interface_table in the samba3 client bindings
instead of the pull and push functions
metze
Jeremy Allison [Tue, 21 Aug 2007 02:04:24 +0000 (02:04 +0000)]
r24590: Reformatting to coding standards. Added my (C) in places it already should
have been :-).
Jeremy.
Jeremy Allison [Tue, 21 Aug 2007 01:43:22 +0000 (01:43 +0000)]
r24589: Refactor our vuid code so that we keep the same
vuid that was allocated whilst the connection is
being constructed and after the connection has been set up.
This is what Windows does and at least one client
(and HP printer) depends on this behaviour. As it
depends on the req struct not yet ported to SAMBA_3_2_0
(Volker, hint hint.... :-) I am not yet adding this
to that branch, but will investigate that tomorrow.
Jeremy.
Günther Deschner [Mon, 20 Aug 2007 15:53:56 +0000 (15:53 +0000)]
r24584: Merge all pam post-processing code (in particular all extra_data code) into
append_data().
Guenther
Günther Deschner [Mon, 20 Aug 2007 15:46:56 +0000 (15:46 +0000)]
r24583: Make sure we don't accept invalid request options.
Thanks to Michael for his bit-magic.
Guenther
Günther Deschner [Mon, 20 Aug 2007 12:45:09 +0000 (12:45 +0000)]
r24579: Merge error reporting to the end of winbindd_pam_auth().
Guenther
Günther Deschner [Mon, 20 Aug 2007 12:29:07 +0000 (12:29 +0000)]
r24578: Fix build warning.
Guenther
Günther Deschner [Mon, 20 Aug 2007 09:47:13 +0000 (09:47 +0000)]
r24573: Fix build without LDAP. Thanks Volker for pointing this out.
Guenther
Michael Adam [Mon, 20 Aug 2007 09:32:30 +0000 (09:32 +0000)]
r24572: Allow for functions map_parameter_canonical() and is_synonym_of() to
be called with inverse == NULL.
Add a new function lp_parameter_is_canonical() to check whether a
parameter name is the canonical name (as apposed to an alias).
Michael
Volker Lendecke [Mon, 20 Aug 2007 07:59:22 +0000 (07:59 +0000)]
r24571: Only look at errno if the close call actually failed
Patch from Ofir Azoulay <Ofir.Azoulay@expand.com> -- thanks
Stefan Metzmacher [Sun, 19 Aug 2007 22:24:45 +0000 (22:24 +0000)]
r24564: regenerate after pidl changes...
metze
Stefan Metzmacher [Sun, 19 Aug 2007 22:10:11 +0000 (22:10 +0000)]
r24561: merge from SAMBA_4_0:
rename some DCERPC_ prefixes into NDR_
metze
Stefan Metzmacher [Sun, 19 Aug 2007 21:23:28 +0000 (21:23 +0000)]
r24558: merge from SAMBA_4_0:
rename 'dcerpc_table_' -> 'ndr_table_'
metze
Stefan Metzmacher [Sun, 19 Aug 2007 20:47:31 +0000 (20:47 +0000)]
r24552: merge from SAMBA_4_0:
rename dcerpc_interface_table -> ndr_interface_table
rename dcerpc_interface_list -> ndr_interface_list
and move them to libndr.h
metze
Volker Lendecke [Sun, 19 Aug 2007 20:09:16 +0000 (20:09 +0000)]
r24550: Attempt to fix the non-LDAP build
For example host "bigboy" doesn't have it.
Günther, please fix it properly and merge to 3_2_0
Thanks,
Volker
Volker Lendecke [Sun, 19 Aug 2007 20:00:43 +0000 (20:00 +0000)]
r24549: Fix unix_convert to return the already converted part
This API will change anyway when moving away from pstrings.
It took so long to fix, because that rename bug I just fixed gave make
test failures that had nothing to do with this one.
I have samba4 tests for both bugs, will check them in when the build
farm has caught up
Volker Lendecke [Sun, 19 Aug 2007 19:57:55 +0000 (19:57 +0000)]
r24548: Fix the case-changing renames
This was broken when I changed reply_mv to wrap in a open_file_ntcreate
call, unix_convert on the destination was called twice
Volker Lendecke [Sun, 19 Aug 2007 19:52:18 +0000 (19:52 +0000)]
r24547: Fix #4897, patch from David S. Collier-Brown <davecb@spamcop.net> -- Thanks!
Derrell Lipman [Sat, 18 Aug 2007 17:29:39 +0000 (17:29 +0000)]
r24543: Apply missing portion of correction for bug 4750
Stefan Metzmacher [Sat, 18 Aug 2007 12:25:59 +0000 (12:25 +0000)]
r24541: merge from SAMBA_4_0:
rename struct dcerpc_endpoint_list/struct dcerpc_authservice_list
into ndr_interface_string_array and move it to libndr.h
metze
Stefan Metzmacher [Sat, 18 Aug 2007 10:33:44 +0000 (10:33 +0000)]
r24538: merge from SAMBA_4_0:
rename struct dcerpc_interface_call -> struct ndr_interface_call
and move it to librpc/ndr/libndr.h
metze
Stefan Metzmacher [Sat, 18 Aug 2007 10:32:53 +0000 (10:32 +0000)]
r24537: regenerate after pidl fixes
metze
Stefan Metzmacher [Sat, 18 Aug 2007 08:18:38 +0000 (08:18 +0000)]
r24533: merge from SAMBA_4_0:
rename dcerpc_syntax_id -> ndr_syntax_id
metze
Michael Adam [Fri, 17 Aug 2007 16:03:18 +0000 (16:03 +0000)]
r24527: Add a function lp_canonicalize_parameter_with_value that turns
a parameter and value into the canonical paramter with the value
inverted if it was in invers boolean synonym.
Make net conf use this function when storing parameters.
Michael
Michael Adam [Fri, 17 Aug 2007 15:38:19 +0000 (15:38 +0000)]
r24526: Refactor determiniation of the index of the canonical form of a
parameter given in string representation into a function of its
own (map_parameter_canonical).
Michael
Michael Adam [Fri, 17 Aug 2007 14:10:49 +0000 (14:10 +0000)]
r24525: Add output of synonym information to show_parameter_list().
Also simplify lp_canonicalize_parameter by making use of
the new function "is_synonym_of".
Michael
Note: If anything depends on the exact former output format of
show_parameter list, I would trigger the output of synonym information
by a boolean verbose switch (that could be passed to testparm
via the "-v" command line switch).
Michael Adam [Fri, 17 Aug 2007 13:07:52 +0000 (13:07 +0000)]
r24519: Refactor printing of one parameter into a helper function of its own.
Michael Adam [Fri, 17 Aug 2007 11:06:37 +0000 (11:06 +0000)]
r24513: Reformatting: eliminate trailing spaces, overly long lines
and adjust some formattings to standard.
Michael
Volker Lendecke [Fri, 17 Aug 2007 10:05:14 +0000 (10:05 +0000)]
r24512: Fix RAW-NOTIFY
With the inbuf consistency checks we have to more correctly fake the
inbuf
Michael Adam [Fri, 17 Aug 2007 09:09:04 +0000 (09:09 +0000)]
r24510: Fix logic. Thanks to Volker for the hint!
Michael
Jeremy Allison [Fri, 17 Aug 2007 01:55:58 +0000 (01:55 +0000)]
r24501: Added bcc test for reply_tcon & removed Vl's comment :-).
Jeremy.
Jeremy Allison [Thu, 16 Aug 2007 23:53:51 +0000 (23:53 +0000)]
r24500: Add check that bcc is correct in an incoming packet.
Jeremy.
Jeremy Allison [Thu, 16 Aug 2007 17:42:34 +0000 (17:42 +0000)]
r24498: More extra code into a function, reply_openerror.
Jeremy.
Volker Lendecke [Thu, 16 Aug 2007 15:44:13 +0000 (15:44 +0000)]
r24497: Revert r24485 -- this needs more thought
Michael Adam [Thu, 16 Aug 2007 15:32:00 +0000 (15:32 +0000)]
r24496: Add initial synonym handling to "net conf":
When storing parameters in the smbconf portion of the registry,
up to now, synonyms could be misused to store a parameter twice.
Now this is prevented by canonicalizing the paramter name first.
Also, the value for a boolean parameter checked for validity
before storing the bool in registry.
(The canonicalization should finally go into the registry smbconf
code to also prevent e.g. "regedit" or "net rpc registry" from
storing synonyms. - This is in the making.)
Michael
Michael Adam [Thu, 16 Aug 2007 15:27:06 +0000 (15:27 +0000)]
r24495: Add a function lp_canonicalize_parameter: It takes a name of a parameter
and produces the "canonical" (or main) name of the parameter (the one
synonym that does not have the flag FLAG_HIDE). The function also sets
a flag as to whether the synonym is a reverse boolean synonym.
Add some functions for the handling of string representations of boolean
values: return the canonical string representation of a bool, invert
a bool given as a string, canonicalize a bool given as a string.
Michael
Volker Lendecke [Thu, 16 Aug 2007 12:15:52 +0000 (12:15 +0000)]
r24485: Even in the failure case unix_convert must pass the already converted
part of the string to the caller.
Stefan Metzmacher [Thu, 16 Aug 2007 09:14:43 +0000 (09:14 +0000)]
r24481: copy .bzrignore => .gitignore
metze
Jeremy Allison [Thu, 16 Aug 2007 00:37:07 +0000 (00:37 +0000)]
r24476: Fix the mappings in reply_opeXXX calls. Now to test renames.
Jeremy.
Jeremy Allison [Thu, 16 Aug 2007 00:22:35 +0000 (00:22 +0000)]
r24475: Fix the error mapping for SMB_POSIX_PATH_OPEN.
Jeremy.
Jeremy Allison [Wed, 15 Aug 2007 23:56:08 +0000 (23:56 +0000)]
r24474: Map error value NT_STATUS_OBJECT_NAME_COLLISION
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate.
Jeremy.
Jeremy Allison [Wed, 15 Aug 2007 23:05:49 +0000 (23:05 +0000)]
r24470: Start fixing up the mapping of OBJECT_NAME_COLLISION
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
Jeremy Allison [Wed, 15 Aug 2007 19:43:26 +0000 (19:43 +0000)]
r24468: Don't forget the +4 for length :-).
Jeremy.
Jeremy Allison [Wed, 15 Aug 2007 19:25:38 +0000 (19:25 +0000)]
r24467: Do range checking on incoming smb request.
Jeremy.
Derrell Lipman [Wed, 15 Aug 2007 17:40:26 +0000 (17:40 +0000)]
r24466: - Sort ACEs according to support.microsoft.com/kb/269175 so that
Windows Explorer doesn't complain about the order (and so that they get
interpreted properly).
Derrell
Jeremy Allison [Wed, 15 Aug 2007 16:58:29 +0000 (16:58 +0000)]
r24464: Now Volker removed the readbmpx we don't need cached errors any more.
Jeremy.
Derrell Lipman [Wed, 15 Aug 2007 13:44:44 +0000 (13:44 +0000)]
r24462: - Removing all ACEs was causing removal of the DACL entirely. Win2000 ignored
the request, presumably due to the PROTECTED flag not being set. Setting
that flag (in make_sec_desc()) has much wider implications than just to
libsmbclient, so instead of modifying that, we'll remove security
descriptors by setting the number of ACEs to zero. At some point, we might
want to look into whether we should actually be setting the PROTECTED flag
in the DACL.
Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true
Derrell
Volker Lendecke [Wed, 15 Aug 2007 13:44:34 +0000 (13:44 +0000)]
r24461: Fix Bug 4852, thank to anto <sistemac@prosoft.ba> for reporting it.
Stefan Metzmacher [Wed, 15 Aug 2007 10:30:44 +0000 (10:30 +0000)]
r24458: regenerate pidl output after pidl fixes:
fixes winreg_EnumValues()
metze
Volker Lendecke [Wed, 15 Aug 2007 10:29:47 +0000 (10:29 +0000)]
r24457: Convert reply_tcon to the new API
Jeremy, I really apologize for doing this, but I just wanted to enjoy
converting the last SMB call :-)
I've left one little task for you there, I'm not certain that checking
the inbuf length is correct here.
Volker
Volker Lendecke [Wed, 15 Aug 2007 09:52:09 +0000 (09:52 +0000)]
r24453: Remove the read and write bmpx calls
Talked to both Tridge and Jeremy about this, Tridge said that there is a
special error message persuading OS/2 to fall back to other methods.
The calls now checked in always return the error message we used to
return when "read bmpx = False" was set (the default): ERRSRV, ERRuseSTD.
If someone has a reproducable test case where this is really needed, we
can always dig it up from version control and convert it to the new API.
But that time without that silly parameter, and with a torture test case
for "make test" please :-)
Volker
Stefan Metzmacher [Wed, 15 Aug 2007 09:12:53 +0000 (09:12 +0000)]
r24450: merge from SAMBA_4_0:
length_is() isn't supported without size_is().
I assume what we need is an array of strings,
so the code isn't used and broken anyway without
a testsuite...just get rid of the pidl warning
metze
Jeremy Allison [Wed, 15 Aug 2007 01:54:37 +0000 (01:54 +0000)]
r24445: Convert SMBwritebraw. No test suite unfortunately.... I need to write one for this.
Jeremy
Volker Lendecke [Tue, 14 Aug 2007 21:53:48 +0000 (21:53 +0000)]
r24444: Convert reply_find[n]close to the new API
Volker Lendecke [Tue, 14 Aug 2007 21:32:52 +0000 (21:32 +0000)]
r24443: Convert reply_search/fclose to the new API
Volker Lendecke [Tue, 14 Aug 2007 21:21:52 +0000 (21:21 +0000)]
r24442: Convert reply_copy to the new API
Volker Lendecke [Tue, 14 Aug 2007 21:13:05 +0000 (21:13 +0000)]
r24441: Convert reply_ioctl to the new API
Volker Lendecke [Tue, 14 Aug 2007 21:07:44 +0000 (21:07 +0000)]
r24440: Convert the reply_sendXX functions to the new API
Volker Lendecke [Tue, 14 Aug 2007 20:55:24 +0000 (20:55 +0000)]
r24439: Convert reply_get/setattrE to the new API
Günther Deschner [Tue, 14 Aug 2007 20:43:02 +0000 (20:43 +0000)]
r24438: Use dump_data_pw() instead of dump_data() on sensitive data in winbindd.
Guenther
Günther Deschner [Tue, 14 Aug 2007 20:26:35 +0000 (20:26 +0000)]
r24437: Remove "done" in winbindd_raw_kerberos_login() as well.
Guenther
Volker Lendecke [Tue, 14 Aug 2007 20:20:51 +0000 (20:20 +0000)]
r24436: Convert reply_lockread/writeunlock to the new API
Günther Deschner [Tue, 14 Aug 2007 20:11:47 +0000 (20:11 +0000)]
r24435: Fix typo.
Guenther
Günther Deschner [Tue, 14 Aug 2007 20:06:11 +0000 (20:06 +0000)]
r24434: Simplify winbindd_raw_kerberos_login().
Guenther
Volker Lendecke [Tue, 14 Aug 2007 20:02:11 +0000 (20:02 +0000)]
r24433: Convert reply_ntrename to the new API
Günther Deschner [Tue, 14 Aug 2007 19:47:57 +0000 (19:47 +0000)]
r24432: Expand kerberos_return_pac() so that it can be used in winbindd.
Guenther
Volker Lendecke [Tue, 14 Aug 2007 19:45:24 +0000 (19:45 +0000)]
r24431: Convert the reply_printXX calls to the new API
Volker Lendecke [Tue, 14 Aug 2007 19:29:02 +0000 (19:29 +0000)]
r24430: Convert reply_writeclose to the new API
Volker Lendecke [Tue, 14 Aug 2007 19:20:25 +0000 (19:20 +0000)]
r24429: reply_setdir is not used...
Volker Lendecke [Tue, 14 Aug 2007 19:09:37 +0000 (19:09 +0000)]
r24428: Convert reply_unlock to the new API
Volker Lendecke [Tue, 14 Aug 2007 18:52:58 +0000 (18:52 +0000)]
r24427: Convert reply_lock to the new API
Volker Lendecke [Tue, 14 Aug 2007 18:33:29 +0000 (18:33 +0000)]
r24426: Convert reply_read to the new API
Volker Lendecke [Tue, 14 Aug 2007 18:16:04 +0000 (18:16 +0000)]
r24425: Convert reply_write to the new API
Günther Deschner [Tue, 14 Aug 2007 16:04:37 +0000 (16:04 +0000)]
r24424: Fix the build.
Guenther
Volker Lendecke [Tue, 14 Aug 2007 16:04:31 +0000 (16:04 +0000)]
r24423: Convert reply_lseek to the new API
Volker Lendecke [Tue, 14 Aug 2007 15:42:39 +0000 (15:42 +0000)]
r24422: Convert reply_ctemp to the new API
Günther Deschner [Tue, 14 Aug 2007 15:40:49 +0000 (15:40 +0000)]
r24421: Ignore long #defines (like for registry keys).
Guenther
Günther Deschner [Tue, 14 Aug 2007 15:34:34 +0000 (15:34 +0000)]
r24420: Pure pedantism: the talloc_init could have failed...
Guenther
Günther Deschner [Tue, 14 Aug 2007 15:31:36 +0000 (15:31 +0000)]
r24419: Hm, I think this protoype is not required here.
Guenther
Günther Deschner [Tue, 14 Aug 2007 15:29:42 +0000 (15:29 +0000)]
r24418: Adding reg_deleteallvalues().
Guenther
Volker Lendecke [Tue, 14 Aug 2007 15:26:54 +0000 (15:26 +0000)]
r24417: Convert reply_setatr to the new API
Günther Deschner [Tue, 14 Aug 2007 15:17:50 +0000 (15:17 +0000)]
r24416: Some more minor edits for libgpo, mostly reformatting and moving of functions.
Guenther
Volker Lendecke [Tue, 14 Aug 2007 15:09:49 +0000 (15:09 +0000)]
r24415: Convert reply_getatr to the new API
Volker Lendecke [Tue, 14 Aug 2007 14:50:49 +0000 (14:50 +0000)]
r24414: Convert reply_mv to the new API
Günther Deschner [Tue, 14 Aug 2007 14:47:08 +0000 (14:47 +0000)]
r24413: Minor edits for libgpo.
Guenther
Volker Lendecke [Tue, 14 Aug 2007 14:31:55 +0000 (14:31 +0000)]
r24412: Convert reply_open to the new API
Derrell Lipman [Tue, 14 Aug 2007 14:27:42 +0000 (14:27 +0000)]
r24410: - I got tricked by function naming. Contrary to what seemed obvious to me,
prs_mem_free() is not the function to be called to free memory allocated by
prs_alloc_mem(). I've added a comment so others may not get bitten too.
- Remove incorrect memory free calls added yesterday to replace SAFE_FREE.
The memory is actually now on a talloc context, so gets freed by the caller
when that context is freed. We don't need to free it iternally.
Derrell
Volker Lendecke [Tue, 14 Aug 2007 13:57:36 +0000 (13:57 +0000)]
r24409: Check wct in reply_open
Volker Lendecke [Tue, 14 Aug 2007 13:38:14 +0000 (13:38 +0000)]
r24408: Remove reply_prep_legacy from reply_lockingX
Volker Lendecke [Tue, 14 Aug 2007 10:47:47 +0000 (10:47 +0000)]
r24406: Push reply_prep_legacy into reply_lockingX
Volker Lendecke [Tue, 14 Aug 2007 10:27:27 +0000 (10:27 +0000)]
r24405: Check wct in reply_lockingX
Volker Lendecke [Tue, 14 Aug 2007 10:06:33 +0000 (10:06 +0000)]
r24404: Remove get_OutBuffer usage from blocking.c