ddiss/samba.git
13 years agolibsmbconf: Document smbconf_set_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:47:41 +0000 (11:47 +0200)]
libsmbconf: Document smbconf_set_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_global_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:45:14 +0000 (11:45 +0200)]
libsmbconf: Document smbconf_get_global_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:44:22 +0000 (11:44 +0200)]
libsmbconf: Document smbconf_get_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_global_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:38:31 +0000 (11:38 +0200)]
libsmbconf: Document smbconf_delete_global_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:37:59 +0000 (11:37 +0200)]
libsmbconf: Document smbconf_delete_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_global_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:36:36 +0000 (11:36 +0200)]
libsmbconf: Document smbconf_get_global_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:35:11 +0000 (11:35 +0200)]
libsmbconf: Document smbconf_get_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_set_global_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:32:06 +0000 (11:32 +0200)]
libsmbconf: Document smbconf_set_global_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_set_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:31:17 +0000 (11:31 +0200)]
libsmbconf: Document smbconf_set_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_share().
Andreas Schneider [Thu, 14 Apr 2011 09:28:00 +0000 (11:28 +0200)]
libsmbconf: Document smbconf_delete_share().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_share().
Andreas Schneider [Thu, 14 Apr 2011 09:27:03 +0000 (11:27 +0200)]
libsmbconf: Document smbconf_get_share().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_create_share().
Andreas Schneider [Thu, 14 Apr 2011 09:25:07 +0000 (11:25 +0200)]
libsmbconf: Document smbconf_create_share().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_share_exists().
Andreas Schneider [Thu, 14 Apr 2011 09:23:56 +0000 (11:23 +0200)]
libsmbconf: Document smbconf_share_exists().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_share_names().
Andreas Schneider [Thu, 14 Apr 2011 09:22:25 +0000 (11:22 +0200)]
libsmbconf: Document smbconf_get_share_names().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_config().
Andreas Schneider [Thu, 14 Apr 2011 09:19:36 +0000 (11:19 +0200)]
libsmbconf: Document smbconf_get_config().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_drop().
Andreas Schneider [Thu, 14 Apr 2011 09:13:49 +0000 (11:13 +0200)]
libsmbconf: Document smbconf_drop().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_changed().
Andreas Schneider [Thu, 14 Apr 2011 09:12:27 +0000 (11:12 +0200)]
libsmbconf: Document smbconf_changed().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_shutdown().
Andreas Schneider [Thu, 14 Apr 2011 09:05:09 +0000 (11:05 +0200)]
libsmbconf: Document smbconf_shutdown().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_is_writeable().
Andreas Schneider [Thu, 14 Apr 2011 09:04:15 +0000 (11:04 +0200)]
libsmbconf: Document smbconf_is_writeable().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_backend_requires_messaging().
Andreas Schneider [Thu, 14 Apr 2011 09:02:49 +0000 (11:02 +0200)]
libsmbconf: Document smbconf_backend_requires_messaging().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3-waf: Create a public libsmconf.
Andreas Schneider [Tue, 12 Apr 2011 09:02:07 +0000 (11:02 +0200)]
s3-waf: Create a public libsmconf.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3-waf: Create a registry private library.
Andreas Schneider [Tue, 12 Apr 2011 08:59:20 +0000 (10:59 +0200)]
s3-waf: Create a registry private library.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_config() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 15:43:10 +0000 (17:43 +0200)]
libsmbconf: Convert smbconf_get_config() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_transaction_*() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 15:24:13 +0000 (17:24 +0200)]
libsmbconf: Convert smbconf_transaction_*() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_delete_includes() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 14:01:22 +0000 (16:01 +0200)]
libsmbconf: Convert smbconf_delete_includes() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_set_includes() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 13:14:52 +0000 (15:14 +0200)]
libsmbconf: Convert smbconf_set_includes() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_includes() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 12:52:52 +0000 (14:52 +0200)]
libsmbconf: Convert smbconf_get_includes() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_delete_parameter() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 12:20:32 +0000 (14:20 +0200)]
libsmbconf: Convert smbconf_delete_parameter() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_parameter() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 11:50:53 +0000 (13:50 +0200)]
libsmbconf: Convert smbconf_get_parameter() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_set_parameter() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 11:23:26 +0000 (13:23 +0200)]
libsmbconf: Convert smbconf_set_parameter() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_delete_share() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 09:39:03 +0000 (11:39 +0200)]
libsmbconf: Convert smbconf_delete_share() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_share() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 15:20:35 +0000 (17:20 +0200)]
libsmbconf: Convert smbconf_get_share() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_create_share() to smbErr.
Andreas Schneider [Fri, 8 Apr 2011 13:48:01 +0000 (15:48 +0200)]
libsmbconf: Convert smbconf_create_share() to smbErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_share_names() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 12:19:15 +0000 (14:19 +0200)]
libsmbconf: Convert smbconf_get_share_names() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_drop() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 08:40:02 +0000 (10:40 +0200)]
libsmbconf: Convert smbconf_drop() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_open() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 08:28:17 +0000 (10:28 +0200)]
libsmbconf: Convert smbconf_open() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_init() to sbcErr.
Andreas Schneider [Thu, 7 Apr 2011 15:19:03 +0000 (17:19 +0200)]
libsmbconf: Convert smbconf_init() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Added a sbcErrorString() function.
Andreas Schneider [Thu, 7 Apr 2011 13:27:52 +0000 (15:27 +0200)]
libsmbconf: Added a sbcErrorString() function.

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit b34e1768b762ae46e4fe761d9691ed09d285c9a9)

13 years agolibsmbconf: Introduce a sbcErrType.
Andreas Schneider [Thu, 7 Apr 2011 13:27:26 +0000 (15:27 +0200)]
libsmbconf: Introduce a sbcErrType.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3-printing: make cups_pull_comment_location() work again.
Günther Deschner [Wed, 11 May 2011 08:30:42 +0000 (10:30 +0200)]
s3-printing: make cups_pull_comment_location() work again.

we deal with lp_cups_server in cups_connect() already, inside the URI all our
other cups functions we use ipp://localhost, do the same here.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 11 11:36:07 CEST 2011 on sn-devel-104
(cherry picked from commit f99d6f079a0060e4d08d7384bdf230d4d2c62b86)

13 years agos3-printing: Fix double free of cups request.
Günther Deschner [Tue, 10 May 2011 13:49:05 +0000 (15:49 +0200)]
s3-printing: Fix double free of cups request.

We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):

"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."

Revert "Fix a memory leak in cups_pull_comment_location"

This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632.

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
(cherry picked from commit 019f11dd5b3240d05c1abe30dec3d793d6919313)

13 years agos3-printing: very obvious fix for cups_pull_comment_location().
Günther Deschner [Tue, 10 May 2011 13:48:25 +0000 (15:48 +0200)]
s3-printing: very obvious fix for cups_pull_comment_location().

This has been in there since 2008...

Guenther
(cherry picked from commit 3ba3f68e03510e3bb5b7627c200af0395e853bc2)

13 years agos3-events: tevent_internal.h is not a public header
Andrew Tridgell [Tue, 10 May 2011 12:55:45 +0000 (14:55 +0200)]
s3-events: tevent_internal.h is not a public header

We need to use the "foo.h" form instead of the <foo.h> form for
headers that are not installed publicly. Otherwise when an external
version of tevent is used we won't find the header and the build will
fail.

Note that this creates a structure dependency between the
tevent structures in the external library and the headers in our
source tree. That is not ideal, but is currently OK as the waf build
will only use the external library if it is at least the same version
as the internal tree, which means it will actually be the same
version, as we release the external version from our tree.

We should come up with a better solution, but for now this allows
openchange to build again.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue May 10 16:06:40 CEST 2011 on sn-devel-104
(cherry picked from commit 628fcd111af9b51020191a6ee916896c127c88c1)

13 years agos3: Use tevent_req_ntstatus properly in a few places
Volker Lendecke [Tue, 10 May 2011 09:05:47 +0000 (11:05 +0200)]
s3: Use tevent_req_ntstatus properly in a few places

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 10 13:11:10 CEST 2011 on sn-devel-104
(cherry picked from commit 44cc1656276d99816614408b5cd846e6a57eacf0)

13 years agos3: Use tevent_req_ntstatus properly in a few places
Volker Lendecke [Tue, 10 May 2011 09:05:47 +0000 (11:05 +0200)]
s3: Use tevent_req_ntstatus properly in a few places
(cherry picked from commit 06a2ff579692ea062944e5bd90d3526327004954)

13 years agoasync_smb.c: convert cli->timeout properly
Rusty Russell [Tue, 10 May 2011 08:03:11 +0000 (17:33 +0930)]
async_smb.c: convert cli->timeout properly

I have a test failure on my 32-bit Ubuntu system, in that
samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than
waiting 5 seconds for the child).

Debugging revealed this code: timeout is in ms and is set to > 1000 in
various places.  The code dates from 2002, and other perturbations didn't
reveal why it breaks now, but fix it anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104
(cherry picked from commit 87e35421744df568721a7f9c7fa141d62665d183)

13 years agoA couple more off-by-one calculations with strlcpy.
Jeremy Allison [Fri, 6 May 2011 14:54:18 +0000 (07:54 -0700)]
A couple more off-by-one calculations with strlcpy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 18:39:17 CEST 2011 on sn-devel-104
(cherry picked from commit f7b3909103a0acd5ee0426b85112f2c9ed4e7730)

13 years agos3-waf: add vfs_gpfs_hsm_notify to the build.
Günther Deschner [Wed, 4 May 2011 16:01:04 +0000 (18:01 +0200)]
s3-waf: add vfs_gpfs_hsm_notify to the build.

Volker, can you please check this is correct ?

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May  4 19:03:45 CEST 2011 on sn-devel-104
(cherry picked from commit 0d1b2d2033e9cc33accea29a4c3a8fafd3d75aa2)

13 years agotdb: fix a build warning.
Günther Deschner [Thu, 5 May 2011 10:52:05 +0000 (12:52 +0200)]
tdb: fix a build warning.

Guenther
(cherry picked from commit 73c31f044e32103276558a194698ea6cf876b4f2)

13 years agolibcli/security: fix build warning, cr_descr_log_acl() is not used currently.
Günther Deschner [Thu, 5 May 2011 10:52:29 +0000 (12:52 +0200)]
libcli/security: fix build warning, cr_descr_log_acl() is not used currently.

Guenther
(cherry picked from commit 03b9a9938b934ff774ad49c5b409c7060e66b999)

13 years agos3-spoolss: remove unused struct in construct_notify_printer_info().
Günther Deschner [Thu, 5 May 2011 19:52:57 +0000 (21:52 +0200)]
s3-spoolss: remove unused struct in construct_notify_printer_info().

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 12:07:17 CEST 2011 on sn-devel-104
(cherry picked from commit ab8219a6f39360da742d0f3ca702f2173d798538)

13 years agos3-proto: remove some duplicate prototypes.
Günther Deschner [Fri, 6 May 2011 12:03:00 +0000 (14:03 +0200)]
s3-proto: remove some duplicate prototypes.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 16:21:08 CEST 2011 on sn-devel-104
(cherry picked from commit 41134f7f4bb6cd2ff84422782dfb82845d881950)

13 years agos3: Fix a typo
Volker Lendecke [Thu, 5 May 2011 13:09:09 +0000 (15:09 +0200)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May  5 16:10:35 CEST 2011 on sn-devel-104
(cherry picked from commit 1c407da7c357d7cad693a152c0eecafc3dc97c61)

13 years agos3: Fix dup_smb2_vec3
Volker Lendecke [Thu, 5 May 2011 10:17:41 +0000 (12:17 +0200)]
s3: Fix dup_smb2_vec3

Metze, Jeremy, please check!

Thanks,

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May  5 13:39:40 CEST 2011 on sn-devel-104
(cherry picked from commit 82b9fa3a199031217bd98d846f2386b556911fa2)

13 years agoFix off-by-one when used with safe_strcpy.
Jeremy Allison [Tue, 3 May 2011 20:57:30 +0000 (13:57 -0700)]
Fix off-by-one when used with safe_strcpy.
(cherry picked from commit 18582016d96e3f41f8828f0539969678ad7d233e)

13 years agoBUGFIX when converting from safe_strcpy to strlcpy.
Jeremy Allison [Tue, 3 May 2011 20:49:28 +0000 (13:49 -0700)]
BUGFIX when converting from safe_strcpy to strlcpy.

We must have a blob legth > 0 in order to safely copy
the (possibly) 16 bytes + 1 byte zero character safely.
(cherry picked from commit 265338c194ceab2520ed1df0f64b62e7169406dd)

13 years agoRemove unused function parse_add_domuser().
Jeremy Allison [Tue, 3 May 2011 19:55:42 +0000 (12:55 -0700)]
Remove unused function parse_add_domuser().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May  4 20:05:42 CEST 2011 on sn-devel-104
(cherry picked from commit 54727f93163f1529eb78dfab5ac605e138391797)

13 years agos3-vfs: make vfswrap_llistxattr and vfswrap_flistxattr static.
Günther Deschner [Tue, 3 May 2011 19:42:04 +0000 (21:42 +0200)]
s3-vfs: make vfswrap_llistxattr and vfswrap_flistxattr static.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May  4 12:31:10 CEST 2011 on sn-devel-104
(cherry picked from commit b8eaec6b666b1f0d3711540c492edd79cd02b1fe)

13 years agoAlways build before commit ... :-)
Volker Lendecke [Wed, 4 May 2011 15:48:12 +0000 (17:48 +0200)]
Always build before commit ... :-)
(cherry picked from commit d4d3d7383a9e3c2c0910a848f33755ca54c32b99)

13 years agoRHEL-CTDB: Build vfs_gpfs_hsm_notify
Volker Lendecke [Wed, 4 May 2011 14:02:15 +0000 (16:02 +0200)]
RHEL-CTDB: Build vfs_gpfs_hsm_notify

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 17:12:14 CEST 2011 on sn-devel-104
(cherry picked from commit 3e211510034dd3854017e1b35ef5e1964085df5d)

13 years agovfs_gpfs: Properly notify the offline->online changes
Volker Lendecke [Wed, 4 May 2011 13:48:27 +0000 (15:48 +0200)]
vfs_gpfs: Properly notify the offline->online changes

This needs to be a separate module that cooperates with vfs_gpfs. If aio_fork
is used early in the module chain it (correctly) does not propagate the aio ops
down, so vfs_gpfs does not see them. This slim module must come early in the
chain for notifies to work properly.
(cherry picked from commit 3f68b43dd56b8f338a18074741162bf6437ae78d)

13 years agovfs_gpfs: Block sendfile for offline files
Volker Lendecke [Wed, 4 May 2011 13:47:42 +0000 (15:47 +0200)]
vfs_gpfs: Block sendfile for offline files
(cherry picked from commit 41bde55821a6c18ace24330aede8d4928215e658)

13 years agovfs_gpfs: Store the winattrs in st.vfs_private
Volker Lendecke [Wed, 4 May 2011 13:42:54 +0000 (15:42 +0200)]
vfs_gpfs: Store the winattrs in st.vfs_private

This avoids a considerable amount of gpfs_winattr calls
(cherry picked from commit 2329fb56a701804585d866817586b4d567966b92)

13 years agos3: Properly deal with exited winbind children
Volker Lendecke [Wed, 4 May 2011 10:11:04 +0000 (12:11 +0200)]
s3: Properly deal with exited winbind children

When a winbind child exits, we need to immediately close the socket. If not,
the next request to that child will be sent to a socket without a listener,
leading to a failed request. This failed request will then trigger a proper
re-init.

This patch avoids the one failed request.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 13:32:16 CEST 2011 on sn-devel-104
(cherry picked from commit d08414b6799747f224ba02300585c8b15ac6bc0e)

13 years agos3: Filter out duplicates in name_query()
Volker Lendecke [Tue, 3 May 2011 19:28:37 +0000 (21:28 +0200)]
s3: Filter out duplicates in name_query()

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 00:03:47 CEST 2011 on sn-devel-104
(cherry picked from commit 7febcb5ffeb2d92f2a4f8abe2c0dac91f5c8a53e)

13 years agos3-includes: when MADVISE support was reverted back in 2009, someone forgot this...
Günther Deschner [Tue, 3 May 2011 14:28:44 +0000 (16:28 +0200)]
s3-includes: when MADVISE support was reverted back in 2009, someone forgot this hunk.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May  3 22:06:20 CEST 2011 on sn-devel-104
(cherry picked from commit c616379e14f7db35429ac849bbc6eb3d4dc641ec)

13 years agoѕ3/configure: move out generic CPPFLAGS in the solaris case here
Björn Jacke [Wed, 20 Apr 2011 21:40:30 +0000 (23:40 +0200)]
ѕ3/configure: move out generic CPPFLAGS in the solaris case here

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 862ff644ee564b2b3ed316da8c19df2f958aef66)

13 years agoѕ3/configure: move out generic LDFLAGS in the solaris case here
Björn Jacke [Wed, 20 Apr 2011 21:32:12 +0000 (23:32 +0200)]
ѕ3/configure: move out generic LDFLAGS in the solaris case here

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 9738f35f2cef0af11c3390162a9c2a3841d6073b)

13 years agos3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path
Björn Jacke [Wed, 20 Apr 2011 22:11:21 +0000 (00:11 +0200)]
s3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue May  3 13:04:11 CEST 2011 on sn-devel-104
(cherry picked from commit cd9a7c143c87fa0f1fda8a6c9b331b21ae6148a2)

13 years agos3: Handle EINTR from sys_poll correctly
Volker Lendecke [Tue, 3 May 2011 15:04:06 +0000 (17:04 +0200)]
s3: Handle EINTR from sys_poll correctly

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May  3 18:06:48 CEST 2011 on sn-devel-104
(cherry picked from commit 023260487517e835edd7f16c8485f9e84cf44667)

13 years agos3: Tune broadcast namequeries for unique names
Volker Lendecke [Mon, 2 May 2011 21:35:06 +0000 (23:35 +0200)]
s3: Tune broadcast namequeries for unique names

If we get a unique name via a broadcast query, there's no point in waiting the
full timeout. A unique name is just what its name says: unique. No point in
waiting longer.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May  3 00:57:24 CEST 2011 on sn-devel-104
(cherry picked from commit 8da8c36b53cc115f0d446b666fc24fc9423d808e)

13 years agos3: Make name_resolve_bcast return sockaddr_storage
Volker Lendecke [Sat, 30 Apr 2011 17:23:55 +0000 (19:23 +0200)]
s3: Make name_resolve_bcast return sockaddr_storage

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 20:40:46 CEST 2011 on sn-devel-104
(cherry picked from commit d87427973c0f43d85546f5875b223929ac1a50d4)

13 years agos3: Remove ip_sevice from get_ipc_connect_master_ip
Volker Lendecke [Sat, 30 Apr 2011 15:10:35 +0000 (17:10 +0200)]
s3: Remove ip_sevice from get_ipc_connect_master_ip

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 18:16:28 CEST 2011 on sn-devel-104
(cherry picked from commit 020b691cf842f30ff42474c2b0102751b5fa17ac)

13 years agoAdd POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a...
Jeremy Allison [Fri, 29 Apr 2011 23:18:14 +0000 (16:18 -0700)]
Add POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a directory are denied with EISDIR.

Don't strip access bits from wire flags when opening a directory.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 02:21:24 CEST 2011 on sn-devel-104
(cherry picked from commit de87f549b75d05a1198c490f6aa5c7e62c3fd4a5)

13 years agoFix bug #8112 - POSIX extension opens of a directory are denied with EISDIR.
Jeremy Allison [Fri, 29 Apr 2011 23:15:55 +0000 (16:15 -0700)]
Fix bug #8112 - POSIX extension opens of a directory are denied with EISDIR.

Ensure create_options are passed down to SMB_VFS_CREATE_FILE().
Correctly set create_options is SMB_O_DIRECTORY is set or pathname
is known to be a directory.

Jeremy.
(cherry picked from commit 2cb53f066e0e42d923be89dd3a7e18ea7a1b7340)

13 years agos4:libcli/util/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
s4:libcli/util/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May  2 15:02:56 CEST 2011 on sn-devel-104
(cherry picked from commit 6dd97ac093ee00281ed029d549d5882d76c2735d)

13 years agos3:libsmb/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
s3:libsmb/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE

metze
(cherry picked from commit 76b3867547dd61d4ac9eda1551945c7c76087f4c)

13 years agolibcli/util/ntstatus: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
libcli/util/ntstatus: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE

metze
(cherry picked from commit aae1f86952ceea7be0594ca44bf86536fb9aea37)

13 years agotalloc: use TC_UNDEFINE_SHRINK_CHUNK() instead of TC_INVALIDATE_SHRINK_CHUNK() for...
Stefan Metzmacher [Mon, 2 May 2011 11:50:52 +0000 (13:50 +0200)]
talloc: use TC_UNDEFINE_SHRINK_CHUNK() instead of TC_INVALIDATE_SHRINK_CHUNK() for realloc path

If we optimize on top of raw realloc() we need
TC_INVALIDATE_SHRINK_CHUNK together with TC_UNDEFINE_GROW_CHUNK
(with was missing and caused false positive valgrind warnings).

But that is really slow, as we do a lot of talloc_realloc calls in samba.

That's why we only to TC_UNDEFINE_SHRINK_CHUNK() for now.

metze
(cherry picked from commit f0f5ac18e55062dcde28003cebc09fa3eb6ae6a5)

13 years agotorture test for bug #8111 - CIFS VFS: unexpected error on SMB posix open.
Jeremy Allison [Fri, 29 Apr 2011 21:27:45 +0000 (14:27 -0700)]
torture test for bug #8111 - CIFS VFS: unexpected error on SMB posix open.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 00:33:40 CEST 2011 on sn-devel-104
(cherry picked from commit 440d71f6c76a4363f69eaf70cada69bdcb98c7bf)

13 years agoFix bug 8111 - CIFS VFS: unexpected error on SMB posix open
Jeremy Allison [Fri, 29 Apr 2011 21:27:32 +0000 (14:27 -0700)]
Fix bug 8111 - CIFS VFS: unexpected error on SMB posix open

We are conflating the O_CREAT|O_EXCL with the O_TRUNC
processing, they need to be separate. We need to chose
using (O_CREAT|O_EXCL) first, then modify if O_TRUNC is
set. This needs two separate switch statements.

Jeremy
(cherry picked from commit 76739435fc8abf1f47193ec4db35a567b564c785)

13 years agos3: Avoid a potential 100% CPU loop in winbindd
Volker Lendecke [Fri, 29 Apr 2011 11:00:14 +0000 (13:00 +0200)]
s3: Avoid a potential 100% CPU loop in winbindd

In the clustering case if ctdb is unhappy, winbindd_reinit_after_fork fails.
This can lead to an endless loop depending on the scheduling of the parent vs
child. Parent forks, child is immediately scheduled and exits. Parent gets
SIGCHLD, parent is then scheduled before it sends the request out to the child.
Parent tries to fork again immediately.

The code before this patch did not really take into account that
reinit_after_fork can fail. The code now sends the result of
winbindd_reinit_after_fork to the parent and the parent only considers the
child alive when it got NT_STATUS_OK.

This was seen in 3.4 winbind. winbind has changed significantly since then, so
it might be possible that this does not happen anymore in exactly this way. But
passing up the status of reinit_after_fork and only consider the child alive
when that's ok is the correct thing to do anyway.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr 29 17:58:19 CEST 2011 on sn-devel-104
(cherry picked from commit df099e66240c7670c9f7b7dcccb1c38216bac3ec)

13 years agos3: Make winbindd_reinit_after_fork return NTSTATUS
Volker Lendecke [Fri, 29 Apr 2011 10:53:13 +0000 (12:53 +0200)]
s3: Make winbindd_reinit_after_fork return NTSTATUS
(cherry picked from commit aa5abcaf7e2844e3bd3d8e8fe26488673ad3c00e)

13 years agos3: In winbind, close parent/child sockets
Volker Lendecke [Thu, 28 Apr 2011 11:26:57 +0000 (13:26 +0200)]
s3: In winbind, close parent/child sockets

This should further reduce fd load in winbind children
(cherry picked from commit 0757688eb34ec1a22bf8c28f72416d6684756647)

13 years agos3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH
Andrew Bartlett [Fri, 29 Apr 2011 02:00:57 +0000 (12:00 +1000)]
s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 0520da2bbe246c45d89bfdec0d399862ecb867ba)

13 years agos3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR
Andrew Bartlett [Fri, 29 Apr 2011 01:57:02 +0000 (11:57 +1000)]
s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 0eca33bbf620678759bbe39efaa74f33f96efb74)

13 years agos3-smb Use FILE_ATTRIBUTE_VOLUME intead of aVOLID
Andrew Bartlett [Fri, 29 Apr 2011 01:52:48 +0000 (11:52 +1000)]
s3-smb Use FILE_ATTRIBUTE_VOLUME intead of aVOLID

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 08c90d6f2df85499f43c5766a62839e80437290f)

13 years agos3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM
Andrew Bartlett [Fri, 29 Apr 2011 03:23:14 +0000 (13:23 +1000)]
s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 0a3c84b554f3862b3e558f62e67ceb8311b248ce)

13 years agos3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN
Andrew Bartlett [Fri, 29 Apr 2011 01:43:35 +0000 (11:43 +1000)]
s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 317e19aeb3fbdb21573b6ef1bc8c2af646a7e61e)

13 years agos3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY
Andrew Bartlett [Fri, 29 Apr 2011 01:36:14 +0000 (11:36 +1000)]
s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY

This means we use just one constant for this file attribute.

Andrew Bartlett
(cherry picked from commit 7f66ebde2e2975b079f6c135b131d064dab38624)

13 years agoAdd FILE_ATTRIBUTE_VOLUME.
Jeremy Allison [Fri, 29 Apr 2011 16:08:20 +0000 (09:08 -0700)]
Add FILE_ATTRIBUTE_VOLUME.

13 years agos3-tevent: only include ../lib/util/tevent wrappers where needed.
Günther Deschner [Thu, 28 Apr 2011 15:38:09 +0000 (17:38 +0200)]
s3-tevent: only include ../lib/util/tevent wrappers where needed.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
(cherry picked from commit 50883cfeb4eed3d538f71443060745f8747044c9)

13 years agos3-tsocket: only include ../lib/tsocket/tsocket.h where needed.
Günther Deschner [Thu, 28 Apr 2011 15:26:40 +0000 (17:26 +0200)]
s3-tsocket: only include ../lib/tsocket/tsocket.h where needed.

Guenther
(cherry picked from commit 12476223c6aa7473c55bcf529639eefce8450680)

13 years agos3-build: remove some unused headers.
Günther Deschner [Thu, 28 Apr 2011 14:37:05 +0000 (16:37 +0200)]
s3-build: remove some unused headers.

Guenther
(cherry picked from commit bc6f24e89f2dd6204209fc9bacc7bfa9c22d0a57)

13 years agos3: Close the winbind client fds after forking
Volker Lendecke [Wed, 27 Apr 2011 15:52:30 +0000 (17:52 +0200)]
s3: Close the winbind client fds after forking

In an overload situation, the winbind helper child process inherits all those
hundreds of fd's which it will never talk to. Close them.

We (Christian Ambach and me) just saw a crash in libkrb5. Christian's analysis
showed that libkrb5 also does select, probably exceeding FD_SETSIZE and
crashing due to that reason. The parent winbind in theory does not do Kerberos
at all, so this should fix that problem.

The crash is interesting because the child process did not really crash.
Somewhere in glibc backtrace() is called, probably due to an assert() or some
explicit consistency check. This then somehow generates a signal probably due
to corrupted memory structures. That signal triggers Samba to again call
backtrace(). This blocks hard on a ptrace_once(). Sorry for the long backtrace
here, but this *is* interesting.

The child process blocking and not really crashing makes the situation worse:
The parent process does not get told the child has crashed and more client
sockets pile up.

This patch is intended to put some relief on this problem by closing the
majority of sockets the parent holds.

(gdb) bt
\#0  0x00002ad686a2b07b in pthread_once () from /lib64/libpthread.so.0
\#1  0x00002ad6867adf87 in backtrace () from /lib64/libc.so.6
\#2  0x00002ad683eab27c in log_stack_trace () at lib/util.c:1580
\#3  0x00002ad683eab34b in smb_panic (why=0x2ad6841c6ec3 "internal error") at lib/util.c:1481
\#4  0x00002ad683e9af3e in fault_report (sig=1) at lib/fault.c:52
\#5  sig_fault (sig=1) at lib/fault.c:75 #6  <signal handler called>
\#7  0x00002ad68673b005 in _int_malloc () from /lib64/libc.so.6
\#8  0x00002ad68673c95d in calloc () from /lib64/libc.so.6
\#9  0x00002ad684503e25 in _dl_new_object () from /lib64/ld-linux-x86-64.so.2
\#10 0x00002ad6844ffadc in _dl_map_object_from_fd () from /lib64/ld-linux-x86-64.so.2
\#11 0x00002ad684501d43 in _dl_map_object () from /lib64/ld-linux-x86-64.so.2
\#12 0x00002ad68450ac8d in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
\#13 0x00002ad684506ed6 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2
\#14 0x00002ad68450a68c in _dl_open () from /lib64/ld-linux-x86-64.so.2
\#15 0x00002ad6867d0ba0 in do_dlopen () from /lib64/libc.so.6
\#16 0x00002ad684506ed6 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2
\#17 0x00002ad6867d0d07 in __libc_dlopen_mode () from /lib64/libc.so.6
\#18 0x00002ad6867adeea in init () from /lib64/libc.so.6
\#19 0x00002ad686a2b083 in pthread_once () from /lib64/libpthread.so.0
\#20 0x00002ad6867adf87 in backtrace () from /lib64/libc.so.6
\#21 0x00002ad68673285f in __libc_message () from /lib64/libc.so.6
\#22 0x00002ad68673a30f in _int_free () from /lib64/libc.so.6
\#23 0x00002ad68673a76b in free () from /lib64/libc.so.6
\#24 0x00002ad6853fe346 in krb5int_sendto () from /usr/lib64/libkrb5.so.3
\#25 0x00002ad6853fe511 in krb5_sendto_kdc () from /usr/lib64/libkrb5.so.3
\#26 0x00002ad6853df7c4 in ?? () from /usr/lib64/libkrb5.so.3
\#27 0x00002ad6853e0919 in krb5_get_init_creds () from /usr/lib64/libkrb5.so.3
\#28 0x00002ad6853e2a94 in krb5_get_init_creds_password () from /usr/lib64/libkrb5.so.3
\#29 0x00002ad684169ff1 in kerberos_kinit_password_ext (principal=0x2ad684702180 "<sanitized>", password=0x2ad6844c5bb0 "<sanitized>", time_offset=0, expire_time=0x2ad6846bf380, renew_till_time=0x0, cache_name=0x2ad6843cb3e0 "MEMORY:winbind_ccache", request_pac=false, add_netbios_addr=false, renewable_time=<value optimized out>, ntstatus=0x0) at libads/kerberos.c:223
\#30 0x00002ad68416a223 in ads_kinit_password (ads=0x2ad6846bf330) at libads/kerberos.c:327
\#31 0x00002ad68415f725 in ads_sasl_spnego_bind (ads=0x2ad6846bf330) at libads/sasl.c:812
\#32 0x00002ad68415dbc1 in ads_sasl_bind (ads=0x2ad6846bf330) at libads/sasl.c:1114
\#33 0x00002ad68415c09b in ads_connect (ads=0x2ad6846bf330) at libads/ldap.c:711
\#34 0x00002ad683e1b8f7 in ads_cached_connection (domain=0x2ad6846b07c0) at winbindd/winbindd_ads.c:124
\#35 0x00002ad683e1bc85 in sequence_number (domain=0x2ad6846b07c0, seq=0x2ad6846b0cd8) at winbindd/winbindd_ads.c:1233
\#36 0x00002ad683dffdd7 in refresh_sequence_number (domain=0x2ad6846b07c0, force=128) at winbindd/winbindd_cache.c:510
\#37 0x00002ad683e00520 in wcache_fetch (cache=<value optimized out>, domain=0x2ad6846b07c0, format=0x2ad68419901e "U/%s") at winbindd/winbindd_cache.c:638
\#38 0x00002ad683e04ac8 in query_user (domain=0x2ad6846b07c0, mem_ctx=0x2ad6846bc920, user_sid=0x7fff1d0cb8c0, info=0x7fff1d0cb810) at winbindd/winbindd_cache.c:1910
\#39 0x00002ad683df2d38 in winbindd_dual_userinfo (domain=0x2ad6846b07c0, state=0x7fff1d0cc9c0) at winbindd/winbindd_user.c:173
\#40 0x00002ad683e232e0 in fork_domain_child (child=0x2ad6846c2440) at winbindd/winbindd_dual.c:485
\#41 schedule_async_request (child=0x2ad6846c2440) at winbindd/winbindd_dual.c:319
\#42 0x00002ad683e229f2 in async_request_fail (state=0x2ad6846c1d00) at winbindd/winbindd_dual.c:214
\#43 0x00002ad683ebabec in run_events (ev=0x2ad6846aebf0, selrtn=0, read_fds=0x7fff1d0ce910, write_fds=<value optimized out>) at lib/events.c:123
\#44 0x00002ad683df08cb in process_loop (argc=<value optimized out>, argv=<value optimized out>, envp=<value optimized out>) at winbindd/winbindd.c:1113
\#45 main (argc=<value optimized out>, argv=<value optimized out>, envp=<value optimized out>) at winbindd/winbindd.c:1437

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Apr 28 12:06:12 CEST 2011 on sn-devel-104
(cherry picked from commit 2e1522f3785d542c429fce83264ad67f35bcef68)

13 years agos3: Fix a strange German translation
Volker Lendecke [Thu, 28 Apr 2011 08:12:47 +0000 (10:12 +0200)]
s3: Fix a strange German translation
(cherry picked from commit a672707a185277343e06ca37fe85caf3bbfd6168)

13 years agoRemove another fstring in this code.
Jeremy Allison [Thu, 28 Apr 2011 00:16:36 +0000 (17:16 -0700)]
Remove another fstring in this code.
(cherry picked from commit d808d55af1bf86f2c89078aba8f8d4dbf7282b9f)

13 years agoFixup (C) - we've both worked lots on this :-).
Jeremy Allison [Tue, 26 Apr 2011 23:31:28 +0000 (16:31 -0700)]
Fixup (C) - we've both worked lots on this :-).

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 27 21:56:29 CEST 2011 on sn-devel-104
(cherry picked from commit af599b3d90e10ea8858bd9ae6b44028c814690c4)

13 years agoRemove fstrings from client struct. Properly talloc strings (ensuring we never end...
Jeremy Allison [Wed, 27 Apr 2011 19:06:25 +0000 (12:06 -0700)]
Remove fstrings from client struct. Properly talloc strings (ensuring we never end up with a NULL pointer).
(cherry picked from commit 1815f0298f33c949f78e181477e8474a37663ccd)

13 years agos3: Make cli_session_setup_lanman2 async
Volker Lendecke [Thu, 28 Apr 2011 00:02:37 +0000 (17:02 -0700)]
s3: Make cli_session_setup_lanman2 async