metze/samba/wip.git
16 years agor13718: There is even no need to use AC_MSG_WARN in the case the user did not
Lars Müller [Mon, 27 Feb 2006 16:18:32 +0000 (16:18 +0000)]
r13718: There is even no need to use AC_MSG_WARN in the case the user did not
request to build mount.cifs/ umount.cifs and we're not on Linux.
(This used to be commit 23293089307a2c6166ee53e5e1e6b3135e4303ed)

16 years agor13717: Use AC_MSG_WARN if we did not called --with-cifsmount on a non Linux
Lars Müller [Mon, 27 Feb 2006 15:33:19 +0000 (15:33 +0000)]
r13717: Use AC_MSG_WARN if we did not called --with-cifsmount on a non Linux
system to report we're not on Linux.
(This used to be commit 1c66c4e4b82907146928396fe79d18bdaade079f)

16 years agor13715: Put back the code that actually modify the account,
Simo Sorce [Mon, 27 Feb 2006 14:45:27 +0000 (14:45 +0000)]
r13715: Put back the code that actually modify the account,
removed, I presume by mistake, by Jerry in the recent
patch the removes the primary group SID stuff.

set_user_info_21 is called to update many other things
like the description of a user for example (that's what
failed on me).

Jerry, please review this one.
(This used to be commit 239a37d201168d095f600042b1ffcd047f18ba8a)

16 years agor13714: Set MOUNT_CIFS_VENDOR_SUFFIX if _SAMBA_BUILD_ is set to
Lars Müller [Mon, 27 Feb 2006 14:18:52 +0000 (14:18 +0000)]
r13714: Set MOUNT_CIFS_VENDOR_SUFFIX if _SAMBA_BUILD_ is set to
"-"SAMBA_VERSION_OFFICIAL_STRING"-"SAMBA_VERSION_VENDOR_SUFFIX if
SAMBA_VERSION_VENDOR_SUFFIX is set or "-"SAMBA_VERSION_OFFICIAL_STRING
only if MOUNT_CIFS_VENDOR_SUFFIX is undefined.

This results in: mount.cifs -V
mount.cifs version: 1.10-3.1.2pre1-SVN-build-13706-foovendor
or
mount.cifs version: 1.10-3.1.2pre1-SVN-build-13706

Steve: If this is to long or you do not like it, we might add something
lile -VV to report the added part.
(This used to be commit 3c277c7a3cce14f185db7fede7c0c4ab77769670)

16 years agor13713: Added installcifsmount and uninstallcifsmount rules for mount.cifs and
Lars Müller [Mon, 27 Feb 2006 14:10:14 +0000 (14:10 +0000)]
r13713: Added installcifsmount and uninstallcifsmount rules for mount.cifs and
unmount.cifs.  This is controlled via CIFSMOUNT_PROGS which is set by
configure by default to yes on linux systems only.  It's possible to
disable with --without-cifsmount anyhow.

Added ROOTSBINDIR to the Makefile to allow us an install to /sbin and
not $prefix/sbin.  Configurable with --with-rootsbindir.
(This used to be commit a2ab4cc824995cbe172c9179edf9002d17de7f74)

16 years agor13711: * Correctly handle acb_info/acct_flags as uint32 not as uint16.
Günther Deschner [Mon, 27 Feb 2006 10:32:45 +0000 (10:32 +0000)]
r13711: * Correctly handle acb_info/acct_flags as uint32 not as uint16.
* Fix a couple of related parsing issues.
* in the info3 reply in a samlogon, return the ACB-flags (instead of
  returning zero)

Guenther
(This used to be commit 5b89e8bc24f0fdc8b52d5c9e849aba723df34ea7)

16 years agor13706: Fix typo in typo fix. (-:
Tim Potter [Mon, 27 Feb 2006 02:44:41 +0000 (02:44 +0000)]
r13706: Fix typo in typo fix.  (-:
(This used to be commit 06be7711269acbcd481ebdef5b9493dab138c81c)

16 years agor13705: Fix a typo (and janitor for myself).
Tim Potter [Mon, 27 Feb 2006 02:14:26 +0000 (02:14 +0000)]
r13705: Fix a typo (and janitor for myself).
(This used to be commit 37b0166d3f15bfcf155b0c3d927cc838b8f55c3c)

16 years agor13704: Janitor for tpot.
Jeremy Allison [Mon, 27 Feb 2006 02:03:53 +0000 (02:03 +0000)]
r13704: Janitor for tpot.
Jeremy
-------------
Slightly smaller version of pdb_get_methods() patch.  Turns out that
callers to initialize_password_db() use the reload parameter so this
has turned in to a smaller cleanup than I thought.
(This used to be commit 7e243104eb57d656adf7b5a322fc8dde9e3c2868)

16 years agor13697: Remove unneeded header (header not present on all Linux either) for umount...
Steve French [Sun, 26 Feb 2006 16:21:30 +0000 (16:21 +0000)]
r13697: Remove unneeded header (header not present on all Linux either) for umount.cifs.c
(This used to be commit d294b28f1c9ed931efe29ebce1c8847215fc03dc)

16 years agor13695: Make code consistent with documentation. :-)
Alexander Bokovoy [Sun, 26 Feb 2006 15:02:16 +0000 (15:02 +0000)]
r13695: Make code consistent with documentation. :-)
smbcontrol was sending messages designated for nmbd and winbindd to smbd. Thus, nmbd and winbindd
were "unshutdownable".
(This used to be commit 52e9b5f89f4889ad97a049eade4957fb15f7b8a5)

16 years agor13694: Committing patch from Aleksey Fedoseev <aleksey at fedoseev dot net> to NULL
Volker Lendecke [Sun, 26 Feb 2006 14:20:29 +0000 (14:20 +0000)]
r13694: Committing patch from Aleksey Fedoseev <aleksey at fedoseev dot net> to NULL
out a pointer after talloc_destroy().

Volker
(This used to be commit 788e52eb5d17a8f5b41b6ad5244ccf448fc81a36)

16 years agor13693: More Solaris/LDAP fixes from Bjoern <bjoern@j3e.de>
Volker Lendecke [Sun, 26 Feb 2006 12:25:34 +0000 (12:25 +0000)]
r13693: More Solaris/LDAP fixes from Bjoern <bjoern@j3e.de>
(This used to be commit 7c098ca0ae4c7e11c7100fb09b42ce716beffb56)

16 years agor13690: Check in Björn's LDAP Solaris fix.
Volker Lendecke [Sun, 26 Feb 2006 01:41:02 +0000 (01:41 +0000)]
r13690: Check in Björn's LDAP Solaris fix.
(This used to be commit d6c6363517513cc66a8933a6e4f95c5ce5cf1cb4)

16 years agor13688: Revert change to set DAT_FILES and SWAT_MSG_FILES in the Makefile.
Lars Müller [Sat, 25 Feb 2006 17:58:52 +0000 (17:58 +0000)]
r13688: Revert change to set DAT_FILES and SWAT_MSG_FILES in the Makefile.
Instead check for *.dat and *.msg files as done before.  Then added
files are installed and removed as soon as we have some in the
filesystem.  It's simpler and less error prone.
(This used to be commit 5119472cdcdc4a0e422d49290c3007527fefd6a2)

16 years agor13683: Fix the 'valid users = +users' problem I introduced.
Volker Lendecke [Fri, 24 Feb 2006 22:26:53 +0000 (22:26 +0000)]
r13683: Fix the 'valid users = +users' problem I introduced.

Volker
(This used to be commit dbdb8bdb9993b0136322530f0b8462bb9477dbf1)

16 years agor13682: Actually give a developer a prayer of finding out where
Jeremy Allison [Fri, 24 Feb 2006 22:04:07 +0000 (22:04 +0000)]
r13682: Actually give a developer a prayer of finding out where
random error messages are coming from. Yes I'm pissed as
I'm working on a live issue right now...
Jeremy.
(This used to be commit 07d1037e17d782ce10dc6f4d15dcd686730c0b92)

16 years agor13679: Commiting the rm_primary_group.patch posted on samba-technical
Gerald Carter [Fri, 24 Feb 2006 21:36:40 +0000 (21:36 +0000)]
r13679: Commiting the rm_primary_group.patch posted on samba-technical

* ignore the primary group SID attribute from struct samu*
* generate the primary group SID strictlky from the Unix
  primary group when dealing with passdb users
* Fix memory leak in original patch caused by failing to free a
  talloc *
* add wrapper around samu_set_unix() to prevent exposing the create
  BOOL to callers.  Wrappers are samu_set_unix() and samu-allic_rid_unix()
(This used to be commit bcf269e2ec6630b78d909010fabd3b69dd6dda84)

16 years agor13678: Remove unneeded braces
Volker Lendecke [Fri, 24 Feb 2006 20:50:13 +0000 (20:50 +0000)]
r13678: Remove unneeded braces
(This used to be commit faf1d832a1b4c59e36814d560bdc5e9838309ca2)

16 years agor13677: patch from Max N. Boyarov <m.boyarov@sam-solutions.net>
Gerald Carter [Fri, 24 Feb 2006 17:53:25 +0000 (17:53 +0000)]
r13677: patch from Max N. Boyarov <m.boyarov@sam-solutions.net>
Prevent div/0 when sysconf(_SC_NPROCESSORS_ONLN) fails.
(This used to be commit 9a335255529d0e93dabbb6b0910f10fa162f9d4a)

16 years agor13676: have to return a value from a non-void function
Gerald Carter [Fri, 24 Feb 2006 16:06:18 +0000 (16:06 +0000)]
r13676: have to return a value from a non-void function
(This used to be commit 70e7c9de9dee9317164c0f96a44827ae8b959254)

16 years agor13675: * patch from Bjoern JACKE <samba@j3e.de> to remove the
Gerald Carter [Fri, 24 Feb 2006 16:00:53 +0000 (16:00 +0000)]
r13675: * patch from Bjoern JACKE <samba@j3e.de> to remove the
  artificial RO bit on directories in user profiles when
  profile acls = yes.
(This used to be commit b698e83a82f96db4a4a6ffa4b61af50c943deff0)

16 years agor13671: fix return value in (void)fn()
Gerald Carter [Fri, 24 Feb 2006 06:29:15 +0000 (06:29 +0000)]
r13671: fix return value in (void)fn()
(This used to be commit 249dba0386833803805a742aa6697cc75566f05c)

16 years agor13669: Get rid of poor errno mapping table. Bounce through NTSTATUS instead.
Jeremy Allison [Fri, 24 Feb 2006 05:47:19 +0000 (05:47 +0000)]
r13669: Get rid of poor errno mapping table. Bounce through NTSTATUS instead.
DO NOT MERGE FOR 3.0.21c PLEASE.
Jeremy.
(This used to be commit 3de0d9af6925e3dc0328c02c2a30127ea5c82a83)

16 years agor13664: Fix the cli_error codes to always detect a socket error.
Jeremy Allison [Fri, 24 Feb 2006 05:05:09 +0000 (05:05 +0000)]
r13664: Fix the cli_error codes to always detect a socket error.
This code needs a tidyup and common code with libsmb/errormap.c
merging. Should fix the winbindd crash Jerry found (I hope).
Jeremy.
(This used to be commit e81227d044fbe7c73c121e540ccafc7f6517c4ea)

16 years agor13663: make uninstall DESTDIR=/somewhere no longer leaves files. This is done
Lars Müller [Fri, 24 Feb 2006 00:30:09 +0000 (00:30 +0000)]
r13663: make uninstall DESTDIR=/somewhere no longer leaves files.  This is done
with the new rules: uninstallservers uninstalldat, uninstallswat (calles
uninstallmsg), uninstallmodules, uninstallclientlib, and
uninstalllibmsrpc.

We still leave directories.  We might try to remove the dirs we created
in reverse order.

The new uninstall scripts are sym links to the respective install
scripts.  Inside we set mode to install or uninstall.

installservers is now used to install the servers.  These are no longer
installed with installbin.
(This used to be commit 43549301b937c060742840054017b31bf3781e04)

16 years agor13660: Attempt to better handle the failure that we cannot find our sid upon
Günther Deschner [Thu, 23 Feb 2006 16:51:53 +0000 (16:51 +0000)]
r13660: Attempt to better handle the failure that we cannot find our sid upon
startup; don't panic, shutdown instead.

Guenther
(This used to be commit f209192e26c12fd48feb6195b724715fbada8b85)

16 years agor13657: Let winbindd try to obtain the gecos field from the msSFU30Gecos
Günther Deschner [Thu, 23 Feb 2006 14:28:41 +0000 (14:28 +0000)]
r13657: Let winbindd try to obtain the gecos field from the msSFU30Gecos
attribute when "winbind nss info = sfu" is set. Fixes #3539.

Guenther
(This used to be commit ffce0461de130828345c44293e564ca03227607d)

16 years agor13656: Use the new installdirs.sh syntax for all calls.
Lars Müller [Thu, 23 Feb 2006 13:08:14 +0000 (13:08 +0000)]
r13656: Use the new installdirs.sh syntax for all calls.
(This used to be commit a606d11056551dee57451ea60f78a86d1f225161)

16 years agor13648: Duh.
Tim Potter [Thu, 23 Feb 2006 01:58:27 +0000 (01:58 +0000)]
r13648: Duh.
(This used to be commit 48cd81074e5a7cbba5892eedd62fff4ce0d826b5)

16 years agor13647: Fix for standalone Samba servers and XP clients. Reverts
Jeremy Allison [Thu, 23 Feb 2006 01:53:26 +0000 (01:53 +0000)]
r13647: Fix for standalone Samba servers and XP clients. Reverts
part of the PocketPC bugfix. I'm trying to get someone who
has a pocketpc to test this.
Jeremy.
(This used to be commit ce25e6b002f39ba084c3430ca832ad4990cf1994)

16 years agor13645: Revert debug output.
Lars Müller [Thu, 23 Feb 2006 01:43:39 +0000 (01:43 +0000)]
r13645: Revert debug output.
(This used to be commit 3a6c9999b4d2327cfb45a2b2839e07a2b682278f)

16 years agor13644: Do not shift anything inside the for loop away. We ineterate over $@.
Lars Müller [Thu, 23 Feb 2006 01:38:00 +0000 (01:38 +0000)]
r13644: Do not shift anything inside the for loop away.  We ineterate over $@.
(This used to be commit 3aa75f0ff589a3fdeaa9daa5ae75b3381c3e8eea)

16 years agor13643: Enable script debug output to get some more details why some hosts
Lars Müller [Thu, 23 Feb 2006 01:05:51 +0000 (01:05 +0000)]
r13643: Enable script debug output to get some more details why some hosts
return with !=0 after calling installmodules.sh AUTH_MODULES.
(This used to be commit 5a67b4f5be9960b24f5bb2ba0adcc25121c8a486)

16 years agor13642: Fix install* scripts to use DESTDIR.
Lars Müller [Wed, 22 Feb 2006 21:41:14 +0000 (21:41 +0000)]
r13642: Fix install* scripts to use DESTDIR.

Always pass the INSTALLPERMS and DESTDIR as first and second arg to the
scripts.

No longer prepend DESTDIR to the remaining args.

To fix bug #3282 it is important _not_ to prepend DESTDIR to the source
of the sym link pointing to smbmount.
(This used to be commit c38adf71317f2c898ee10cad8068e942835199c9)

16 years agor13641: Finish fix for #3510. Don't use client schannel when told
Jeremy Allison [Wed, 22 Feb 2006 21:18:23 +0000 (21:18 +0000)]
r13641: Finish fix for #3510. Don't use client schannel when told
not to, cope with a server that doesn't offer schannel also.
Jeremy
(This used to be commit 68005f6bdb70883eace0d9067c76c3360a803023)

16 years agor13639: Never overwrite the acct_flags in rpccli_netlogon_sam_network_logon().
Günther Deschner [Wed, 22 Feb 2006 20:40:24 +0000 (20:40 +0000)]
r13639: Never overwrite the acct_flags in rpccli_netlogon_sam_network_logon().

Guenther
(This used to be commit c201e51de387d3d49880ed519eb9d825df92f5af)

16 years agor13625: Now that Heimdal 0.7.2 is released, we reenable our strict checking for
Günther Deschner [Wed, 22 Feb 2006 11:47:41 +0000 (11:47 +0000)]
r13625: Now that Heimdal 0.7.2 is released, we reenable our strict checking for
c++ reserved names.

Guenther
(This used to be commit e0b50d008728cfc66f6b1eefdadf8a708f4d9500)

16 years agor13622: Allow to rename machine accounts in a Samba Domain. This still uses the
Günther Deschner [Wed, 22 Feb 2006 10:28:02 +0000 (10:28 +0000)]
r13622: Allow to rename machine accounts in a Samba Domain. This still uses the
"rename user script" to do the rename of the posix machine account (this
might be changed later). Fixes #2331.

Guenther
(This used to be commit b2eac2e6eb6ddd1bcb4ed5172e7cd64144c18d16)

16 years agor13614: First part of the bugfix for #3510 - net join fails
Jeremy Allison [Wed, 22 Feb 2006 04:56:53 +0000 (04:56 +0000)]
r13614: First part of the bugfix for #3510 - net join fails
against server with schannel disabled. Second part
will come tomorrow (fixing net_rpc_join_ok()).
Jeremy.
(This used to be commit 7de1ee18619bf99c5db45692e085d0646e52378f)

16 years agor13612: #define NO_SYSLOG is dead as a doornail.
Tim Potter [Wed, 22 Feb 2006 03:12:00 +0000 (03:12 +0000)]
r13612: #define NO_SYSLOG is dead as a doornail.
(This used to be commit 1d23067e68f914ffb42374532b6454a0aaa7c657)

16 years agor13610: Patch from Bjoern JACKE <samba@j3e.de>. Don't default to
Jeremy Allison [Wed, 22 Feb 2006 01:31:43 +0000 (01:31 +0000)]
r13610: Patch from Bjoern JACKE <samba@j3e.de>. Don't default to
/tmp if there is no path in the share, make it unavailable.
All printer shares should have a path and IPC$ is already
explicitly set to tmpdir().
Jeremy.
(This used to be commit b1915a0591d9842b4c95f527363a807e8a756697)

16 years agor13607: Fix compile - don't ref auto variable in a structure initialization.
Jeremy Allison [Wed, 22 Feb 2006 00:34:35 +0000 (00:34 +0000)]
r13607: Fix compile - don't ref auto variable in a structure initialization.
Fix from Richard Bollinger <rabollinger@gmail.com>.
Jeremy.
(This used to be commit 02da5189f1c2a07a7ac02cf51e23782f70829f34)

16 years agor13604: Fix for bug #3512 "use spnego=no" and "server signing=auto" cause client...
Jeremy Allison [Tue, 21 Feb 2006 23:21:28 +0000 (23:21 +0000)]
r13604: Fix for bug #3512 "use spnego=no" and "server signing=auto" cause client to disconnect after negprot"
We missed one case of ignoring "BSRSPYL ".
Merge for 3.0.21c.
Jeremy.
(This used to be commit 7d21cf420fdecaee43408ad5cc192cc0715d95a2)

16 years agor13601: * Remove unused code from pdb_ldap.c
Gerald Carter [Tue, 21 Feb 2006 19:22:49 +0000 (19:22 +0000)]
r13601: * Remove unused code from pdb_ldap.c
* Add a 'struct passwd *' to the struct samu for later reference
  (I know this may be controversial but its easily reverted which is
  is why I'm checking this is as a seaparate patch before I get
  too deep).
* Remove unix_homedir from struct samu {} and update the pdb wrapper
  functions associated with it.
(This used to be commit 92c251fdf0f1f566cfeca3c75ba2284b644aef5d)

16 years agor13600: Move functions local to tdbsam to pdb_tdb.c
Gerald Carter [Tue, 21 Feb 2006 19:02:22 +0000 (19:02 +0000)]
r13600: Move functions local to tdbsam to pdb_tdb.c
(This used to be commit e3489f7eddb21981bb74cd8792aca869ae6790e1)

16 years agor13599: krb5 error codes are defined as long. Also for the other direction.
Lars Müller [Tue, 21 Feb 2006 17:48:20 +0000 (17:48 +0000)]
r13599: krb5 error codes are defined as long.  Also for the other direction.
(This used to be commit 7b8ea1499124d1e1efe325339419a66ab8885b38)

16 years agor13598: Defining KRB5KRB_ERR_RESPONSE_TOO_BIG if not defined which is the case
Lars Müller [Tue, 21 Feb 2006 17:35:52 +0000 (17:35 +0000)]
r13598: Defining KRB5KRB_ERR_RESPONSE_TOO_BIG if not defined which is the case
for older krb5 implementations.

Patch slightly modified from the version provided by Björn Jacke <bjoern
at j3e dot de> at the samba-technical list after discussion on the list
and by IRC.  Thanks Björn!
(This used to be commit 49e6431c06c70088907c31e2da1ec83a09377015)

16 years agor13597: krb5 error codes are defined as long.
Lars Müller [Tue, 21 Feb 2006 17:19:20 +0000 (17:19 +0000)]
r13597: krb5 error codes are defined as long.
(This used to be commit bab8c156a464c1beaa022e0026184e0de84c0bf9)

16 years agor13594: Got sense of NTSTATUS check reversed.
Jeremy Allison [Tue, 21 Feb 2006 17:00:00 +0000 (17:00 +0000)]
r13594: Got sense of NTSTATUS check reversed.
Jeremy.
(This used to be commit cd821079893dc6ff486d0c5f0bd756e78caa4e89)

16 years agor13593: consolidate pdb_set_sam_sids() into samu_set_unix() which
Gerald Carter [Tue, 21 Feb 2006 16:46:21 +0000 (16:46 +0000)]
r13593: consolidate pdb_set_sam_sids() into samu_set_unix() which
was the only place it was called from.
(This used to be commit 6568c9cb03ca378ea7d08190ca3cfcc3e380ee4e)

16 years agor13591: I really have no idea how this code ever worked. And I have
Gerald Carter [Tue, 21 Feb 2006 15:47:19 +0000 (15:47 +0000)]
r13591: I really have no idea how this code ever worked.  And I have
no idea why no one (including myself) caught this with a compiler
warning....Make sure new_chunk() actually returns a pointer
to the allocated memory.

SAMBA_3_0 now works again on Solaris.
(This used to be commit cf9140ad266a8a710651570d0af8dc6188fafed0)

16 years agor13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()
Gerald Carter [Tue, 21 Feb 2006 14:34:11 +0000 (14:34 +0000)]
r13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()
* replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix()
(This used to be commit 6f1afa4acc93a07d0ee9940822d7715acaae634f)

16 years agor13589: Make sure we only try to close the tdbsam file in endsampwent() when we
Gerald Carter [Tue, 21 Feb 2006 14:03:15 +0000 (14:03 +0000)]
r13589: Make sure we only try to close the tdbsam file in endsampwent() when we
have a valid pwent list from a setsampwent().  Fixes a bug with the
reference count on the open tdb.
(This used to be commit 77332f0738423d16a2b5e21af6aaf92b029da0ef)

16 years agor13588: Second attempt to fix Bug #3330 - treat the string as a
Jeremy Allison [Tue, 21 Feb 2006 03:29:02 +0000 (03:29 +0000)]
r13588: Second attempt to fix Bug #3330 - treat the string as a
uint8 array and copy as such. Gunther please check (sorry
I reverted your earlier fix).
Jeremy.
(This used to be commit 7a17b39c80703909f102487690d2117d874b0e15)

16 years agor13585: Sorry Gunther, had to revert this. It's got a buffer
Jeremy Allison [Tue, 21 Feb 2006 03:08:42 +0000 (03:08 +0000)]
r13585: Sorry Gunther, had to revert this. It's got a buffer
overrun. Spoke to Jerry about the correct fix. Will add
this after.
Jeremy.
(This used to be commit 33e13aabd3825c59d15dc897536e2ccf8c8f6d5e)

16 years agor13581: Correctly parse a non-null terminated, little-endian UCS2 string in the
Günther Deschner [Mon, 20 Feb 2006 23:22:56 +0000 (23:22 +0000)]
r13581: Correctly parse a non-null terminated, little-endian UCS2 string in the
PAC_LOGON_NAME structure. This was broken on big-endian machines
(Solaris SPARC and ppc). Fixes Bug #3330.

Jerry, this should be in 3.0.21c.

Guenther
(This used to be commit 9732490811f8f02ee547ddc6e2694e1122a3a518)

16 years agor13579: Next try to fix the AIX build. Thanks to Björn for nagging...
Volker Lendecke [Mon, 20 Feb 2006 21:58:33 +0000 (21:58 +0000)]
r13579: Next try to fix the AIX build. Thanks to Björn for nagging...

Volker
(This used to be commit 4cf5109c7a1355f0adb42891ff490f03ae677347)

16 years agor13576: This is the beginnings of moving the SAM_ACCOUNT data structure
Gerald Carter [Mon, 20 Feb 2006 20:09:36 +0000 (20:09 +0000)]
r13576: This is the beginnings of moving the SAM_ACCOUNT data structure
to make full use of the new talloc() interface.  Discussed with Volker
and Jeremy.

* remove the internal mem_ctx and simply use the talloc()
  structure as the context.
* replace the internal free_fn() with a talloc_destructor() function
* remove the unnecessary private nested structure
* rename SAM_ACCOUNT to 'struct samu' to indicate the current an
  upcoming changes.  Groups will most likely be replaced with a
  'struct samg' in the future.

Note that there are now passbd API changes.  And for the most
part, the wrapper functions remain the same.

While this code has been tested on tdb and ldap based Samba PDC's
as well as Samba member servers, there are probably still
some bugs.  The code also needs more testing under valgrind to
ensure it's not leaking memory.

But it's a start......
(This used to be commit 19b7593972480540283c5bf02c02e5ecd8d2c3f0)

16 years agor13574: fix build; talloctort.c should not use the TALLOC_FREE() macro
Gerald Carter [Mon, 20 Feb 2006 18:55:15 +0000 (18:55 +0000)]
r13574: fix build; talloctort.c should not use the TALLOC_FREE() macro
(This used to be commit af57e4a4cc5efc9c7aba35790cf10377c76b5e4a)

16 years agor13573: removing wrepld from SAMBA_3_0. The Samba 4 work is more current and any...
Gerald Carter [Mon, 20 Feb 2006 18:24:30 +0000 (18:24 +0000)]
r13573: removing wrepld from SAMBA_3_0.  The Samba 4 work is more current and any integration into Samba 3 would most likely be from scratch
(This used to be commit 028b1f26aeebc46d6ae433fc3d2eae69e493c312)

16 years agor13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
Gerald Carter [Mon, 20 Feb 2006 17:59:58 +0000 (17:59 +0000)]
r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)

16 years agor13566: Fix EA support for AIX.
Günther Deschner [Mon, 20 Feb 2006 11:57:47 +0000 (11:57 +0000)]
r13566: Fix EA support for AIX.
Patch from Bjoern Jacke <bjacke-at-sernet-dot-de>.

Guenther
(This used to be commit 69fb189a6b9947069afebb15d6ee6f2f20d15171)

16 years agor13564: Remove trailing backslash. Makes other than GNU make choke on this.
James Peach [Mon, 20 Feb 2006 05:45:09 +0000 (05:45 +0000)]
r13564: Remove trailing backslash. Makes other than GNU make choke on this.
(This used to be commit 5e7efe304b2514224243ed0ac80f7fdf09c45a82)

16 years agor13563: Fix bug #3526 found and diagnosed by corinna@vinschen.de.
Jeremy Allison [Sun, 19 Feb 2006 21:01:21 +0000 (21:01 +0000)]
r13563: Fix bug #3526 found and diagnosed by corinna@vinschen.de.
trans2findfirst recognises two info levels *not* recognised
by trans2findnext. Add them. Needed for 3.0.21c.
Jeremy.
(This used to be commit bcb87271d60acd4efe666dd061ea2c09b72fd497)

16 years agor13559: Fix bug #3522 reported by Sandeep Tamhankar <sandman@electric-cloud.com>.
Jeremy Allison [Sat, 18 Feb 2006 02:02:11 +0000 (02:02 +0000)]
r13559: Fix bug #3522 reported by Sandeep Tamhankar <sandman@electric-cloud.com>.
mkdir foo returns the wrong error message when file foo exists.
Jeremy.
(This used to be commit c8185e7f94cbcf2125bf0e84db02fb8d19111f60)

16 years agor13557: (Hopefully) get the creds store/restore key right from
Jeremy Allison [Sat, 18 Feb 2006 01:21:18 +0000 (01:21 +0000)]
r13557: (Hopefully) get the creds store/restore key right from
the correct part of the netlogon and schannel packets.
Jeremy.
(This used to be commit 4877f336b257e6f59833a6e0679959a2ec879974)

16 years agor13556: Ensure that any potential creds operation are protected
Jeremy Allison [Sat, 18 Feb 2006 00:39:31 +0000 (00:39 +0000)]
r13556: Ensure that any potential creds operation are protected
by schannel if "server schannel = true" was set.
Jeremy.
(This used to be commit fd84d9703ed01feb010df4ebb7e9ceb0d063780b)

16 years agor13553: Fix all our warnings at -O6 on an x86_64 box.
Jeremy Allison [Sat, 18 Feb 2006 00:27:31 +0000 (00:27 +0000)]
r13553: Fix all our warnings at -O6 on an x86_64 box.
Jeremy.
(This used to be commit ea82958349a57ef4b7ce9638eec5f1388b0fba2a)

16 years agor13552: Make sure we're using the same name to load the stored
Jeremy Allison [Fri, 17 Feb 2006 23:57:28 +0000 (23:57 +0000)]
r13552: Make sure we're using the same name to load the stored
creds under all circumstances. This may be wrong, but
at least we're now consistent.
Jeremy.
(This used to be commit 09f0b3e1a366ba3eef4ab9a8e302daabd4f36936)

16 years agor13550: remove pdb_guest
Gerald Carter [Fri, 17 Feb 2006 23:16:13 +0000 (23:16 +0000)]
r13550: remove pdb_guest
(This used to be commit db575c764127d7bea92fc12e5aa73c96c9ee5e2f)

16 years agor13548: Always use the get_remote_macinhe_name() as the key
Jeremy Allison [Fri, 17 Feb 2006 21:32:31 +0000 (21:32 +0000)]
r13548: Always use the get_remote_macinhe_name() as the key
for the creds store. This should fix the problems
Jerry reported (but I have still to run tests :-).
Jeremy.
(This used to be commit 43f095a38d66caa774d80fe32e1b96ec25dd1f07)

16 years agor13547: add earlier checks to deny deleting a printer driver. The previous
Gerald Carter [Fri, 17 Feb 2006 21:07:26 +0000 (21:07 +0000)]
r13547: add earlier checks to deny deleting a printer driver.  The previous
code relied upon file permissions alone.  Now we check that
the user is a printer administrator and that the share has not been
marked read only for that user.
(This used to be commit 117d9fd9e16a7afbc6772506a4f8c33ff99d33f7)

16 years agor13546: NSS soname merge from trunk
Gerald Carter [Fri, 17 Feb 2006 19:19:25 +0000 (19:19 +0000)]
r13546: NSS soname merge from trunk
(This used to be commit 380d89d148548b4658f705e900d874094a123359)

16 years agor13545: A patch which I think it's time has come. VOlker, we can talk about
Gerald Carter [Fri, 17 Feb 2006 19:07:58 +0000 (19:07 +0000)]
r13545: A patch which I think it's time has come.  VOlker, we can talk about
this more but it gets around the primary group issue.

* don't map a SID to a name from the group mapping code if
  the map doesn't have a valid gid.  This is only an issue
  in a tdb setup
* Always allow S-1-$DOMAIN-513 to resolve (just like Windows)
* if we cannot resolve a users primary GID to a SID, then set
  it to S-1-$DOMAIN-513
* Ignore the primary group SID inside pdb_enum_group_memberships().
  Only look at the Unix group membersip.

Jeremy, this fixes a fresh install startup for smbd as far as my tests
are concerned.
(This used to be commit f79f4dc4c58a6172bf69d37469fdd8de05a812df)

16 years agor13544: -O1 janitor work :-)
Volker Lendecke [Fri, 17 Feb 2006 17:20:53 +0000 (17:20 +0000)]
r13544: -O1 janitor work :-)
(This used to be commit a95d7d722273863efa820674672393fe6e5a33b7)

16 years agor13542: Don't reuse a pointer we just freed (Doh!).
Jeremy Allison [Fri, 17 Feb 2006 15:51:25 +0000 (15:51 +0000)]
r13542: Don't reuse a pointer we just freed (Doh!).
Jeremy.
(This used to be commit e755155b0e665cb6d10c28fe7fc6c1f6699d18e6)

16 years agor13541: we have to wrap pen_enum_group_memberships() in become/unbecome_root()
Gerald Carter [Fri, 17 Feb 2006 13:30:34 +0000 (13:30 +0000)]
r13541: we have to wrap pen_enum_group_memberships() in become/unbecome_root()
blocks.  This fixes the problem I had with missing groups in the
net_samlogon() reply from a Samba PDC.
(This used to be commit 06b83fe35048c84dfd68be2ee656317c51e89bce)

16 years agor13539: Add 128 bit creds processing client and server. Thanks to Andrew Bartlett's
Jeremy Allison [Fri, 17 Feb 2006 04:22:32 +0000 (04:22 +0000)]
r13539: Add 128 bit creds processing client and server. Thanks to Andrew Bartlett's
Samba4 code.
Jeremy.
(This used to be commit a2fb436fc5dd536cfe860be93f55f9cb58139a0e)

16 years agor13538: Make sure we store all 16 bytes of credentials session
Jeremy Allison [Fri, 17 Feb 2006 01:26:21 +0000 (01:26 +0000)]
r13538: Make sure we store all 16 bytes of credentials session
key and delete records that are old. We will need this
for the full 16 byte session key support.
Jeremy.
(This used to be commit cef240d571f9ba1cdf596cd4cab4ec0790f943a0)

16 years agor13535: Fix #2353 based on a patch by William Jojo.
Jeremy Allison [Thu, 16 Feb 2006 23:08:12 +0000 (23:08 +0000)]
r13535: Fix #2353 based on a patch by William Jojo.
Jeremy.
(This used to be commit fe63a6ee06149195032320dd0fb9b6c7dfb460d3)

16 years agor13532: Add SWAT welcome _no_ doc page default page. This is required by
Lars Müller [Thu, 16 Feb 2006 21:49:22 +0000 (21:49 +0000)]
r13532: Add SWAT welcome _no_ doc page default page.  This is required by
revision 13383.
(This used to be commit 6e212e2a5d63422130bb5e745603f5e11998520d)

16 years agor13530: Fix from William Jojo for #1970. Make nmblookup do
Jeremy Allison [Thu, 16 Feb 2006 20:50:41 +0000 (20:50 +0000)]
r13530: Fix from William Jojo for #1970. Make nmblookup do
a node status on all IP's when requested.
Jeremy.
(This used to be commit 1fcac478cb5ba432282612fbb785caaed4d2f9b8)

16 years agor13529: No functional, line break changes to let it fit into 80 chares screen
Lars Müller [Thu, 16 Feb 2006 20:22:54 +0000 (20:22 +0000)]
r13529: No functional, line break changes to let it fit into 80 chares screen
width again.
(This used to be commit 7716c697291246f427c60a0aa20d861929feb87c)

16 years agor13528: Mention the tools and commandline option names used.
Lars Müller [Thu, 16 Feb 2006 18:33:08 +0000 (18:33 +0000)]
r13528: Mention the tools and commandline option names used.
(This used to be commit 5db7e9a42ab27871891be8a1314c32e13620da36)

16 years agor13527: Adjust copyright header with information got from the 2.2 cvs tree.
Lars Müller [Thu, 16 Feb 2006 18:28:04 +0000 (18:28 +0000)]
r13527: Adjust copyright header with information got from the 2.2 cvs tree.
(This used to be commit e00505cc942dd5cf755aa6b5d2f565eeff95629e)

16 years agor13526: Remove superfuous extra spaces at EOL.
Lars Müller [Thu, 16 Feb 2006 17:36:35 +0000 (17:36 +0000)]
r13526: Remove superfuous extra spaces at EOL.
(This used to be commit 66990adface697a75f7e25f8df83375e8dd8b72b)

16 years agor13525: This is only a cleanup to have the memset() and SAFE_FREE() only one
Lars Müller [Thu, 16 Feb 2006 16:45:58 +0000 (16:45 +0000)]
r13525: This is only a cleanup to have the memset() and SAFE_FREE() only one
time in the code.

Even if we now have an additional if statement after the free I prefer
this solution in opposite to the duplicated code we had before.
(This used to be commit 4272419b1146b1c03e070655f3a31d027c00ad20)

16 years agor13524: Add -t|--password-from-stdin option to pdbedit as we had with Samba 2.2.
Lars Müller [Thu, 16 Feb 2006 16:22:44 +0000 (16:22 +0000)]
r13524: Add -t|--password-from-stdin option to pdbedit as we had with Samba 2.2.

This fixes bug #1386.

The initial changes had been made by Carsten Höger <choeger at
open-xhange dot com> for Samba 2.2 while being at SuSE. *sigh*

To not duplicate code from smbpasswd in pdbedit stdin_new_passwd() and
get_pass() are moved from smbpasswd to utils/passwd_util.c.
(This used to be commit dbdc5ba497c6010dbad47c9d77fc8bec5557a328)

16 years agor13523: Fix indent.
Günther Deschner [Thu, 16 Feb 2006 15:51:04 +0000 (15:51 +0000)]
r13523: Fix indent.

Guenther
(This used to be commit 85435bf96114679253551a3e6c5db046b8320611)

16 years agor13522: Add SAMR_GET_USRDOM_PWINFO client-side.
Günther Deschner [Thu, 16 Feb 2006 13:18:17 +0000 (13:18 +0000)]
r13522: Add SAMR_GET_USRDOM_PWINFO client-side.

Guenther
(This used to be commit 290a581b7567eab82b18fbadae9aa2ab29e95069)

16 years agor13521: Implement LOOKUPNAME3 and 4.
Jeremy Allison [Thu, 16 Feb 2006 01:06:21 +0000 (01:06 +0000)]
r13521: Implement LOOKUPNAME3 and 4.
Jeremy.
(This used to be commit 6ec0e9124a1a7b19c9853b8e26075cbbb8751f10)

16 years agor13519: Fix the credentials chaining across netlogon pipe disconnects.
Jeremy Allison [Wed, 15 Feb 2006 23:15:55 +0000 (23:15 +0000)]
r13519: Fix the credentials chaining across netlogon pipe disconnects.
I mean it this time :-).
Jeremy.
(This used to be commit 80f4868944d349015d2b64c2414b06466a8194aa)

16 years agor13517: Fix typo -- thanks to Karolin Seeger <ks@sernet.de>
Volker Lendecke [Wed, 15 Feb 2006 21:54:58 +0000 (21:54 +0000)]
r13517: Fix typo -- thanks to Karolin Seeger <ks@sernet.de>
(This used to be commit d0efb435e51ee4d5454b55aee1596355ecc4a2c6)

16 years agor13515: Make sure to store the correct domain name in the server affinity cache.
Gerald Carter [Wed, 15 Feb 2006 18:45:25 +0000 (18:45 +0000)]
r13515: Make sure to store the correct domain name in the server affinity cache.
(This used to be commit a918e4ac2426d4cb3cd526c4fad7480b832e6a12)

16 years agor13514: fix small glitch in the update procedure from /var/cache/samba mishap
Gerald Carter [Wed, 15 Feb 2006 18:41:35 +0000 (18:41 +0000)]
r13514: fix small glitch in the update procedure from /var/cache/samba mishap
(This used to be commit 3857d3693a2c14917df88f4338ac9b78abba9ca1)

16 years agor13513: Changing defaults:
Gerald Carter [Wed, 15 Feb 2006 18:27:06 +0000 (18:27 +0000)]
r13513: Changing defaults:

  * enable privileges = yes
  * enable asu support = no

Remove unused function after the tdbsam rewrite.
(This used to be commit 5385a01ee19d9c7e00b4dd7a6ab3ec1d4b03b558)

16 years agor13512: Rewrite tdbsam code to use a reference count based open/close
Gerald Carter [Wed, 15 Feb 2006 18:26:06 +0000 (18:26 +0000)]
r13512: Rewrite tdbsam code to use a reference count based open/close
on the tdb file.  This allow recusive calls to succeed
without complaining about failed opens since a tdb can
only be opened once per process.  We probably still need to backport
the transaction support from Samba 4 here though.
(This used to be commit 94c37e06522bfc1753cc8f3c6c7bd4329587007e)

16 years agor13511: Fix bug in the samr dispinfo enumeration code.
Gerald Carter [Wed, 15 Feb 2006 18:24:16 +0000 (18:24 +0000)]
r13511: Fix bug in the samr dispinfo enumeration code.
Make sure to associate the DOMAIN dispinfo cache
with a User/Group SAMR handle (not the SID of the user or group).
Ensure that enumeration after deleting a user works.
(This used to be commit 7967f89caa17ea93cb7e9d8695f1904ccb9a2864)

16 years agor13510: plug memory leak in WINS server code.
Gerald Carter [Wed, 15 Feb 2006 18:22:00 +0000 (18:22 +0000)]
r13510: plug memory leak in WINS server code.
(This used to be commit 381c327a65489bf8b0fd4935662ca1df6f9e1183)