Kamen Mazdrashki [Fri, 23 Apr 2010 20:03:17 +0000 (23:03 +0300)]
s4: Fix few comments
Kamen Mazdrashki [Fri, 23 Apr 2010 13:35:21 +0000 (16:35 +0300)]
s4/dsdb: schemaInfo revision may be 0
In case schemaInfo value is still not set, WinAD supplies
schemaInfo blob with revision = 0 and GUID_ZERO
Kamen Mazdrashki [Fri, 23 Apr 2010 12:37:10 +0000 (15:37 +0300)]
s4/dsdb: remove unused dsdb_schema_info_create() function
Kamen Mazdrashki [Thu, 22 Apr 2010 15:11:39 +0000 (18:11 +0300)]
s4/dsdb: Update Schema cache with updated schemaInfo value
Error checking is simplified and my leave leeks.
I did it this way to make code more readable, and if we
get error in those lines, it will be WERR_NOMEM in which
case we are in a much deeper troubles than delayed freeing
of few bytes.
Kamen Mazdrashki [Thu, 22 Apr 2010 14:59:22 +0000 (17:59 +0300)]
s4/samldb: Create initial schemaInfo value if it doesn't exists yet
Kamen Mazdrashki [Thu, 22 Apr 2010 14:24:15 +0000 (17:24 +0300)]
s4/dsdb: Use default schemaInfo value when no such value is given
Having no value for schemaInfo is totally OK as it turns out.
In such cases, we should use a default value with
all fields set to 0.
Kamen Mazdrashki [Thu, 22 Apr 2010 01:39:04 +0000 (04:39 +0300)]
s4/test: schemaInfo may not to be set yet
On newly provisioned Forest schemaInfo is not initially set.
It should be created after firs Schema modification
Kamen Mazdrashki [Wed, 21 Apr 2010 23:55:03 +0000 (02:55 +0300)]
Revert "s4/dsdb: Set schemaInfo attribute value during provisioning"
This reverts commit
8149094eddebd9a0e8b7c123c2ed54d00164bb26.
Windows implementation does not set schemaInfo attribute value
until first Schema update request.
This way, newly provisioned forest returns no schemaInfo value.
I think it won't be bad for us to have this value preset, but
I want to mimic Win AD behavior as close as possible.
Kamen Mazdrashki [Tue, 13 Apr 2010 23:15:50 +0000 (02:15 +0300)]
s4/selftest: Fix wrong comment
Kamen Mazdrashki [Tue, 13 Apr 2010 23:15:27 +0000 (02:15 +0300)]
s4/selftest: Fix 'net vampire' command invocation
- 'net vampire' no longer accepts '--realm' option
- 'vampire' command must follow 'bin/net' on command line
so that Python commands are searched for 'vampire' command
- '--target-dir' option must be used
Andrew Bartlett [Tue, 13 Apr 2010 01:08:41 +0000 (11:08 +1000)]
s4:selftest Fix 'net vampire' command invocation
The change to allowing subcommands in 'net' to use their own options
parser means that we can't use this argument order any more. We need
to put global options before commands.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Mar 2010 23:44:05 +0000 (10:44 +1100)]
s4:selftest Run RPC-DSSYNC against the vampired DC
Andrew Bartlett [Wed, 10 Mar 2010 22:38:37 +0000 (09:38 +1100)]
s4:selftest Run the RPC echo earlier, so to start the member and vampire DC
This means that the vampire DC is running while the other tests are
doing modifications, which will trigger more traffic and test out the
code better.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Mar 2010 20:26:41 +0000 (07:26 +1100)]
s4:selftest Add test of the vampire'ed DC
Andrew Bartlett
Andrew Bartlett [Thu, 11 Mar 2010 23:36:12 +0000 (10:36 +1100)]
s4:selftest Add vampire_dc test environment
This starts a domain controller, after running 'net vampire' to
populate it.
Andrew Bartlett
Kamen Mazdrashki [Wed, 6 Jan 2010 11:36:27 +0000 (13:36 +0200)]
ECLIPSE + PyDev Project
Andrew Tridgell [Mon, 26 Apr 2010 05:46:37 +0000 (15:46 +1000)]
s4-ddb: don't create partitions with the UNINSTANT flag set
these partitions and not on the server we are replicating from. Also
check for deleted partitions.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 26 Apr 2010 06:44:44 +0000 (16:44 +1000)]
s4-drs: allow getncchanges requests to non WRIT_REP partitions for extended ops
Needed for RID allocation
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 26 Apr 2010 07:02:25 +0000 (17:02 +1000)]
s4-drs: don't send uninstantiated objects in getncchanges
This includes deleted partitions
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 26 Apr 2010 08:43:46 +0000 (18:43 +1000)]
s4-drepl: don't send an UpdateRefs unless its a plain replication
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 26 Apr 2010 09:04:33 +0000 (19:04 +1000)]
build: cope with realname for install of non-python libs
this fixes the install of mit_samba.so
Andrew Tridgell [Mon, 26 Apr 2010 04:39:15 +0000 (14:39 +1000)]
s4-drs: make links to foreign partitions non-fatal
DN links outside the set of partitions we are replication should be
allowed.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 26 Apr 2010 03:24:10 +0000 (13:24 +1000)]
build: automatically run autogen-waf.sh when needed
Andrew Tridgell [Mon, 26 Apr 2010 01:12:05 +0000 (11:12 +1000)]
s4-heimdalbuild: remove LIBNETIF dependency from HEIMDAL_GSSAPI
this avoids the s3compat layer from getting duplicate interfaces code
Andrew Tridgell [Mon, 26 Apr 2010 01:11:21 +0000 (11:11 +1000)]
build: normalise paths in unique source checking
Andrew Tridgell [Sun, 25 Apr 2010 11:00:44 +0000 (21:00 +1000)]
build: a library is only empty if it has no deps
Andrew Tridgell [Sun, 25 Apr 2010 02:58:52 +0000 (12:58 +1000)]
build: use option_group() not add_option_group()
option_group() ensures we don't end up with duplicate groups
Andrew Tridgell [Sun, 25 Apr 2010 02:41:41 +0000 (12:41 +1000)]
build: cope with duplicates in source lists
Volker Lendecke [Sun, 25 Apr 2010 09:42:44 +0000 (11:42 +0200)]
s3: async_domain_request is no longer used
Volker Lendecke [Sun, 25 Apr 2010 09:40:30 +0000 (11:40 +0200)]
s3: Convert add_trusted_domains() to wb_domain_request_send()
Volker Lendecke [Sun, 25 Apr 2010 08:36:58 +0000 (10:36 +0200)]
s3: Simplify trustdom_state
Don't store information explicitly as boolean flags that can be easily
retrieved from the domain when it's actually needed.
Volker Lendecke [Sun, 25 Apr 2010 08:25:55 +0000 (10:25 +0200)]
s3: Make "struct trustdom_state" its own talloc context
Volker Lendecke [Sun, 25 Apr 2010 08:15:43 +0000 (10:15 +0200)]
libwbclient: Talloc is no longer used
Stefan Metzmacher [Sat, 24 Apr 2010 17:36:01 +0000 (19:36 +0200)]
Revert "tsocket: not all systems have IPV6_V6ONLY"
This reverts commit
63fc3978089df403d7e63462593784ff3d05e6e7.
We now don't support IPv6 when IPV6_V6ONLY isn't available,
as we rely on the behavior.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 11:07:50 +0000 (13:07 +0200)]
lib/replace/wscript: make sure IPV6_V6ONLY is available for IPv6 support
We really on IPV6_V6ONLY being supported.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 11:07:50 +0000 (13:07 +0200)]
lib/replace: make sure IPV6_V6ONLY is available for IPv6 support
We really on IPV6_V6ONLY being supported.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 17:28:48 +0000 (19:28 +0200)]
lib/replace/wscript: add replacement for IPV6_V6ONLY on linux systems with broken headers
This is needed on SLES8.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 17:02:22 +0000 (19:02 +0200)]
lib/replace: add replacement for IPV6_V6ONLY on linux systems with broken headers
This is needed on SLES8.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 16:10:37 +0000 (18:10 +0200)]
buildtools/wafsamba: inline defines during configure into the tests
There 2 reasons for this change:
- This is how autoconf tests work and it makes config.log much more useful
- The waf c preprocessor ignored changes in bin/default/__confdefs.h when using
waf configure -C, because is outside of the configure tests project path
and handled like a system header.
Many thanks to ita for pointing out the fix.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 18:02:44 +0000 (20:02 +0200)]
buildtools/wafsamba: make sure we create bin/default/ before trying to create symlinks in it
metze
Matthieu Patou [Fri, 23 Apr 2010 13:27:05 +0000 (17:27 +0400)]
s4 dns: Allow to specify static grant entries to be added to the dynamicaly generated named.conf.update
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Tim Potter [Sat, 24 Apr 2010 01:04:32 +0000 (11:04 +1000)]
s4-smbd: Fix compiler warning in prefork smbd.
My first patch in a while...
Tim.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 23 Apr 2010 06:11:44 +0000 (08:11 +0200)]
lib/zlib/wscript: fix system zlib detection
metze
Volker Lendecke [Sat, 24 Apr 2010 10:40:10 +0000 (12:40 +0200)]
Revert "nsswitch: Fix a memleak in wbinfo"
This reverts commit
a97f2a0a9c0f1c148a0152202296bb078103b40c.
This was not a memleak, it was a valgrind false positive. We store "details" in
a static.
Volker Lendecke [Sat, 24 Apr 2010 09:11:45 +0000 (11:11 +0200)]
s3: sendto_domain() is lo longer used
Volker Lendecke [Sat, 24 Apr 2010 08:49:06 +0000 (10:49 +0200)]
s3: Simplify (bool != True) to !bool
Jeremy Allison [Sat, 24 Apr 2010 07:29:41 +0000 (00:29 -0700)]
Implement oplocks within SMB2. Plumb into the existing SMB1 oplock system.
Seems to work but needs more tests (to be added).
Jeremy.
Jeremy Allison [Fri, 23 Apr 2010 22:35:34 +0000 (15:35 -0700)]
When sending the initial async response, this is never part of a chain.
Get the reply flags correct.
Jeremy.
Jeremy Allison [Fri, 23 Apr 2010 22:34:58 +0000 (15:34 -0700)]
Don't free the entire tevent_req on cancel, only the part we need (the immediate event).
Jeremy.
Volker Lendecke [Fri, 23 Apr 2010 17:46:03 +0000 (19:46 +0200)]
libwbclient: Test WBC_CHANGE_PASSWORD_LEVEL_RESPONSE
Volker Lendecke [Fri, 23 Apr 2010 17:44:05 +0000 (19:44 +0200)]
s3: Allow pdb password change using WINBINDD_PAM_CHNG_PSWD_AUTH_CRAP
Volker Lendecke [Fri, 23 Apr 2010 17:42:33 +0000 (19:42 +0200)]
s3: init_dc_connection() can't init for internal domains
This fixes a crash in winbindd_dual_pam_chng_pswd_auth_crap when given
global_sam_name() in the domain field
Volker Lendecke [Fri, 23 Apr 2010 17:41:29 +0000 (19:41 +0200)]
libwbclient: Actually copy something in wbcChangeUserPasswordEx
The length argument for memcpy was initialized to 0 and not initialized
Volker Lendecke [Tue, 20 Apr 2010 18:37:35 +0000 (20:37 +0200)]
s3: replace some data_blob_talloc by data_blob_const
Volker Lendecke [Tue, 20 Apr 2010 14:07:13 +0000 (16:07 +0200)]
libwbclient: Remove some pointless BAIL_ON_WBC_ERROR macro calls
Volker Lendecke [Tue, 20 Apr 2010 09:11:19 +0000 (11:11 +0200)]
s3: Convert WINBINDD_PAM_CHNG_PSWD_AUTH_CRAP to the new async API
Simo Sorce [Fri, 23 Apr 2010 21:26:33 +0000 (14:26 -0700)]
s3-smbd: group print relate data in own structure
Jeremy Allison [Fri, 23 Apr 2010 20:10:15 +0000 (13:10 -0700)]
Allow smb2 create requests to be cancelled.
Jeremy.
Ira Cooper [Fri, 23 Apr 2010 17:55:46 +0000 (10:55 -0700)]
Fix bug #7384 - dptr_Close has a bitmap leak.
s3: Fix to dptr_Close
This fixes a bitmap "leak" in dptr_Close by making it use the same internal
routines the rest of the code does.
Jeremy Allison [Fri, 23 Apr 2010 17:53:44 +0000 (10:53 -0700)]
At simo's request return struct tevent_req *treq -> treq. For consistency :-(.
Jeremy Allison [Fri, 23 Apr 2010 17:29:48 +0000 (10:29 -0700)]
Rename - no functional change. Stop all variables being called "req".
tevent_req -> treq
struct smb_request -> smb1req
struct smbd_smb2_request -> smb2req
Jeremy.
Andreas Schneider [Wed, 21 Apr 2010 15:13:02 +0000 (17:13 +0200)]
s3-spoolss: Added a winreg_get_printer function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 21 Apr 2010 10:56:39 +0000 (12:56 +0200)]
s3-spoolss: Added a winreg_create_printer function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 15 Apr 2010 15:53:39 +0000 (17:53 +0200)]
s3-spoolss: Added a winreg_update_printer function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Tue, 20 Apr 2010 01:50:52 +0000 (21:50 -0400)]
s3-spoolss: Added a winreg_get_driver_list function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Tue, 20 Apr 2010 01:01:38 +0000 (21:01 -0400)]
s3-spoolss: Added a winreg_del_driver function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:38:39 +0000 (09:38 -0400)]
s3-spoolss: Added a winreg_get_driver function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:37:08 +0000 (09:37 -0400)]
s3-spoolss: Added a winreg_add_driver function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 15 Apr 2010 00:46:55 +0000 (20:46 -0400)]
s3-spoolss: Move info_ctr conversion to a public helper.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 23 Apr 2010 12:45:48 +0000 (14:45 +0200)]
s3-spoolss: Fixed winreg_delete_printer_key if key is NULL or emtpy.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:58:51 +0000 (09:58 -0400)]
s3-spoolss: Add date and version winreg helpers.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 21 Apr 2010 16:12:50 +0000 (18:12 +0200)]
s3-spoolss: Added more winreg hepler functions.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:51:37 +0000 (09:51 -0400)]
s3-spoolss: Added winreg helper functions
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 12 Apr 2010 13:54:01 +0000 (15:54 +0200)]
s3-spoolss: Added a winreg function to query a dword.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 15 Apr 2010 19:51:16 +0000 (21:51 +0200)]
s3-spoolss: Added a function to get the ChangeID from a printer.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 15 Apr 2010 13:18:26 +0000 (15:18 +0200)]
s3-spoolss: Added a function to update the ChangeID of a printer.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 9 Apr 2010 10:36:37 +0000 (12:36 +0200)]
s3-spoolss: Added winreg helper functions to write registry values.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 9 Apr 2010 07:26:24 +0000 (09:26 +0200)]
s3-spoolss: Fixed return values of winreg_printer_deleteform1.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 9 Apr 2010 07:26:08 +0000 (09:26 +0200)]
s3-spoolss: Added missing return value to winreg_printer_enumforms1 docs.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 21 Apr 2010 15:59:55 +0000 (17:59 +0200)]
s3-spoolss: Use const values for notify functions.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 22 Apr 2010 10:33:29 +0000 (12:33 +0200)]
s3-time: Added a function to get the startup time of the server.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 23 Apr 2010 13:31:21 +0000 (15:31 +0200)]
s3-lanman: fix uninitialized variable in api_RDosPrintJobDel().
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:52:57 +0000 (13:52 +0200)]
s3-selftest: enable RPC-SPOOLSS-DRIVER against s3.
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:52:19 +0000 (13:52 +0200)]
s4-smbtorture: skip tests when no local driver directory is around.
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:51:33 +0000 (13:51 +0200)]
s3-selftest: add print$ share with two arch dirs.
(make test variant)
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:51:02 +0000 (13:51 +0200)]
s3-selftest: add print$ share with two arch dirs.
Guenther
Günther Deschner [Fri, 23 Apr 2010 10:17:04 +0000 (12:17 +0200)]
s3-winbind: fix setup_domain_child() callers.
Volker, please check.
Guenther
Günther Deschner [Fri, 23 Apr 2010 09:39:12 +0000 (11:39 +0200)]
s4-smbtorture: use server_name for all printerdriver delete and enum operations.
With this s3 passes the RPC-PRINTER-DRIVER test.
Guenther
Günther Deschner [Fri, 23 Apr 2010 09:33:51 +0000 (11:33 +0200)]
s3-spoolss: make switch in _spoolss_AddPrinterDriver() a bit more clear.
Guenther
Günther Deschner [Fri, 23 Apr 2010 09:27:51 +0000 (11:27 +0200)]
s4-smbtorture: allow to upload or remove any file belonging to a driver.
Guenther
Volker Lendecke [Wed, 21 Apr 2010 15:04:49 +0000 (17:04 +0200)]
s3: Fix a winbind crash when scanning trusts
add_trusted_domain() for a new domain always needs to be followed by a
setup_domain_child(). This was not always done, in particular not when walking
to the forest root for additional trusts.
This is a minimal patch, we need to fix add_trusted_domain().
Jeremy Allison [Fri, 23 Apr 2010 06:52:19 +0000 (23:52 -0700)]
Make deferred opens (NT_STATUS_SHARING_VIOLATION) work over SMB2.
Makes SMB2Create call re-entrant internally.
Now this infrastructure is in place, oplocks will follow shortly.
Tested with Win7 client and with W2K8R2.
Jeremy.
Volker Lendecke [Fri, 23 Apr 2010 05:06:03 +0000 (07:06 +0200)]
s3: Fix a cut&paste error in a debug message in check_oem_password()
Günther Deschner [Fri, 23 Apr 2010 01:04:47 +0000 (03:04 +0200)]
s3-spoolss: make sure AddPrinterDriver calls into AddPrinterDriverEx.
Not vice versa. Also disable some info levels in AddPrinterDriver according to
MS-RPRN 3.1.4.4.1.
Found by torture test.
Guenther
Günther Deschner [Fri, 23 Apr 2010 01:03:59 +0000 (03:03 +0200)]
s4-smbtorture: fix test_EnumPrinterDrivers_findone().
Guenther
Günther Deschner [Fri, 23 Apr 2010 00:49:42 +0000 (02:49 +0200)]
s4-smbtorture: samba currently supports level 3 and 6 driver adds.
Guenther
Günther Deschner [Fri, 23 Apr 2010 00:34:43 +0000 (02:34 +0200)]
s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
Found by torture test.
Guenther
Günther Deschner [Thu, 22 Apr 2010 23:58:02 +0000 (01:58 +0200)]
s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
Guenther
Günther Deschner [Thu, 22 Apr 2010 16:47:27 +0000 (18:47 +0200)]
s4-smbtorture: allow to upload and later remove printer driver files in RPC-SPOOLSS-DRIVER.
Guenther
Günther Deschner [Thu, 2 Jul 2009 19:49:15 +0000 (21:49 +0200)]
s4-smbtorture: add RPC-SPOOLSS-DRIVER test.
Guenther