Karolin Seeger [Thu, 30 Apr 2009 07:33:43 +0000 (09:33 +0200)]
WHATSNEW: Add new net service subcommands to the WHATSNEW.
Karolin
(cherry picked from commit
b7c4a63d034f8c33b3a4857cae41270bd55e270f)
Karolin Seeger [Thu, 30 Apr 2009 07:27:43 +0000 (09:27 +0200)]
WHATSNEW: Add some WHATSNEW improvements.
Karolin
(cherry picked from commit
b59f79fd262b9dbb97db90e8cafe7642fd6b6317)
Karolin Seeger [Wed, 29 Apr 2009 12:44:59 +0000 (14:44 +0200)]
WHATSNEW: Correct WHATSNEW.
Karolin
(cherry picked from commit
83c7d8697a8df92ff1592af9c382f483354eeb0f)
Günther Deschner [Wed, 29 Apr 2009 12:29:25 +0000 (14:29 +0200)]
s3-test: make it possible to find the built vlp in "make test".
Guenther
(cherry picked from commit
3316ae9d75dfe6c7a960938c9503367880510079)
(cherry picked from commit
0146649cf95ad27a583057df300fe5712b89e806)
Jelmer Vernooij [Wed, 22 Apr 2009 21:54:10 +0000 (23:54 +0200)]
Specify explicit path to vlp, for those not having vlp in $PATH.
(cherry picked from commit
79177c1d36e125b08aa4d6e0e42e9a97f625b3c8)
(cherry picked from commit
f51a4b95b472496f58759dae75ff1369324c0a29)
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.
This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!
Karolin
(cherry picked from commit
3422b9c546cdd262bd747e1e737c2b6479b4d21e)
(cherry picked from commit
3da62734fffa99cde1084beeb69e94a7bc623dde)
Karolin Seeger [Wed, 29 Apr 2009 10:45:39 +0000 (12:45 +0200)]
WHATSNEW: Update WHATSNEW.
Karolin
(cherry picked from commit
245b859dfb0e1de4c453cf9de97e6d50b163daa4)
Karolin Seeger [Wed, 29 Apr 2009 10:38:28 +0000 (12:38 +0200)]
s3/docs: Remove documentation of "use kerberos keytab".
This parameter has been removed with
d96248a9b4655.
Karolin
(cherry picked from commit
b6eab68c20f0914cb946f05ebae2faba67f32806)
(cherry picked from commit
644d45ef4878e396fe62918e35e7103465eeb971)
Günther Deschner [Mon, 13 Apr 2009 22:01:03 +0000 (00:01 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
Guenther
(cherry picked from commit
6900d61d369961e0c11e590ccdc102169f21cef3)
(cherry picked from commit
41dae8256cdddd9557ae7a00b1282a0eb05d4f36)
Günther Deschner [Mon, 13 Apr 2009 22:00:37 +0000 (00:00 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
Guenther
(cherry picked from commit
5e563ee508d0b3cc87d72ad52d777946ee0537b1)
(cherry picked from commit
c3f1cbd26792928970b6a60d82746719fea688d7)
Günther Deschner [Mon, 13 Apr 2009 21:58:59 +0000 (23:58 +0200)]
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
Guenther
(cherry picked from commit
d76837f6da2cf735d2b18c97f3b46ae2f04b750d)
(cherry picked from commit
d845a971ee32c8e9adb4717abe546355eb7153c9)
Günther Deschner [Wed, 29 Apr 2009 09:46:43 +0000 (11:46 +0200)]
s3-docs: document "net eventlog" in net manpage.
Guenther
(cherry picked from commit
664ff081cadd29a1e750b349ecb23e8402d977cb)
(cherry picked from commit
65d4acdb1b7f9cd78d38c23a00267688dc156da6)
Günther Deschner [Wed, 29 Apr 2009 09:46:12 +0000 (11:46 +0200)]
s3-net: make "net eventlog" help output a little more appropriate.
Guenther
(cherry picked from commit
e89cc775e660183e7126bcfa8fb37496074cf5a1)
(cherry picked from commit
e26efbd2c8a49012383032fef07cddec76561aa3)
Michael Adam [Tue, 28 Apr 2009 23:49:53 +0000 (01:49 +0200)]
s3:smbd/service: switch load_registry_service/shares to use loadparm routines
instead of reading the registry directly with tdb and activating the
configure options by hand.
This eliminates the need for repeating checks done in loadparm.
For instance it disables registry shares without path in the server
as is the case with text based shares.
Michael
(cherry picked from commit
077bcc11257697b243916fbb02cd72b3a122b9ba)
(cherry picked from commit
502bfe9352d36ee909d7210a9d0ec0b6c7db5149)
Michael Adam [Tue, 28 Apr 2009 23:31:03 +0000 (01:31 +0200)]
s3:loadparm: refactor process_registry_service out or process_registry_globals
Michael
(cherry picked from commit
fb3b6576127ce837ac711e87c293d1f4cf97473c)
(cherry picked from commit
480af4e0ead10241aa94f4095c7fa580240fec00)
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
samr: fix samr_ConnectVersion enum which is 32bit not 16bit.
Volker, please check.
Rafal, haven't we seen this in your tests at sambaxp as well ?
Guenther
(cherry picked from commit
67ca76c288eb095ae59e98927317d51c96c89551)
(cherry picked from commit
59e75824e81ffb6d05e624a5344123c585998904)
Günther Deschner [Tue, 28 Apr 2009 23:49:26 +0000 (01:49 +0200)]
svcctl: Fix IDL for svcctl_StartServiceW().
Guenther
(cherry picked from commit
a23fb4663df11b237e94683510d282c286bbeed6)
(cherry picked from commit
d49e69d49a41d193d6e1dd342c653d9a8bc3b140)
Michael Adam [Tue, 28 Apr 2009 10:18:23 +0000 (12:18 +0200)]
pm_process():raise level of debug message
Michael
(cherry picked from commit
664da577f931dfd47573d3d77a95afb573fba855)
(cherry picked from commit
caa1f05420191d934c2ea1c2acaa75702c8e5c2e)
Michael Adam [Mon, 27 Apr 2009 16:10:14 +0000 (18:10 +0200)]
s3:loadparm: prevent infinite include nesting.
This introduces a hard coded MAX_INCLUDE_DEPTH of 100.
When this is exceeded, handle_include (and hence lp_load) fails.
One could of course implement a more intelligent loop detection
in the include-tree, but this would require some restructuring
of the internal loadparm housekeeping. Maybe as a second improvement
step.
Michael
(cherry picked from commit
d5f2bbdc489b751331e86afae58b0d80c5fedb9c)
(cherry picked from commit
bfd10fd322fe1721b8b45256cd988ed83b18a8a6)
Günther Deschner [Mon, 27 Apr 2009 12:39:02 +0000 (14:39 +0200)]
s3-net: make sure to call libnetapi init functions at the top of "net rpc" command.
Without the initialization "net rpc password" will prompt twice for passwords
and will not allow to define the name of the connection admin user.
In the long run we should probably only have one place where to initialize
libnetapi.
Kai, please check.
Guenther
(cherry picked from commit
09ec85715b0e99740156ebb7213eddd1edfea631)
(cherry picked from commit
0c5f19fbea7a6419a84ac0137a9a09995ef7a933)
Michael Adam [Mon, 27 Apr 2009 23:24:27 +0000 (01:24 +0200)]
s3:mark registry shares without path unavailable just as with text config
This prevents users from getting access to "/" in misconfigured setups.
Michael
(cherry picked from commit
d16e40b5ef9add630d027ff92e440c44bfb88ef0)
(cherry picked from commit
3bdb4342225444055b084908083e003e0e272e10)
Volker Lendecke [Tue, 28 Apr 2009 09:16:19 +0000 (11:16 +0200)]
Fix annoying debug messages when no snapshots are used
Not being able to open the shadow copy directory is the same as having no
shadow copy support at all. The VFS module should in this case not log with
debug level 0 and set ENOSYS to indicate "no shadow copies used" to the higher
levels.
(cherry picked from commit
4982483cdd2a4d37f96574c19dd3aade236c1b93)
Günther Deschner [Mon, 27 Apr 2009 23:08:31 +0000 (01:08 +0200)]
s3-svcctl: Fix crash in _svcctl_EnumServicesStatusW().
The resume handle is a unique pointer, always check before dereference.
Guenther
(cherry picked from commit
dd33abf649f4e1479365a2ccc2b41134270ff4ac)
(cherry picked from commit
1e117c6ebc6322b7fac4928d84bc5e714e559ea5)
Günther Deschner [Tue, 21 Apr 2009 14:18:51 +0000 (16:18 +0200)]
s3-svcctl: indicate that the spooler is already running if it does.
Guenther
(cherry picked from commit
16b2f4b55a80314aa733dd7f23543c1c3926223c)
(cherry picked from commit
265e1fca1228776a0a7556ef854bfcc4130085b4)
Günther Deschner [Fri, 10 Apr 2009 19:39:45 +0000 (21:39 +0200)]
s3-svcctl: fix _svcctl_ControlService.
Guenther
(cherry picked from commit
aa26bdd71969610a4b6a5bdfdd735a1dab31a12c)
(cherry picked from commit
32e4e65e61e627100a8201b5aba273c2e8b63de8)
Günther Deschner [Fri, 10 Apr 2009 19:10:07 +0000 (21:10 +0200)]
s4-smbtorture: add test_ControlService() to RPC-SVCCTL.
Guenther
(cherry picked from commit
a263eaca499cf2b8a89c3ab04c6ef5e7e9aea396)
(cherry picked from commit
d9d4e769a4d4a2978656ef77e9e91308152a9483)
Günther Deschner [Fri, 10 Apr 2009 18:55:10 +0000 (20:55 +0200)]
s4-smbtorture: add test_StartServiceW() to RPC-SVCCTL.
Guenther
(cherry picked from commit
f926a4e390e7108dad36ecfffaddb628b23436c0)
(cherry picked from commit
16f3e855d056e5951fa6136a61c13d09fa9a74c1)
Günther Deschner [Mon, 20 Apr 2009 14:49:01 +0000 (16:49 +0200)]
s4-smbtorture: change default service to spooler in RPC-SVCCTL.
Guenther
(cherry picked from commit
ae5dd1219a14e939cb1e3674e6daba7885cc9d51)
(cherry picked from commit
f783489d73d044433b911c673acca0aaf0fb70c8)
Björn Jacke [Sat, 28 Mar 2009 00:21:25 +0000 (01:21 +0100)]
ѕ3/configure: fix regexp for ld version recognition
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
(cherry picked from commit
740c2c4366badc62d017881c9484ee5153b62f94)
(cherry picked from commit
172ecfae44768289b98c1bafa7aa2b89dbecc312)
Günther Deschner [Fri, 24 Apr 2009 08:02:06 +0000 (10:02 +0200)]
s3-idmap: Fix bug #6286: Call init function for builtin idmap modules before probing for them as shared modules.
idmap-gurus of the world, please check.
Guenther
(cherry picked from commit
67588ca80d654183b8b7b062b9660a506a825f94)
(cherry picked from commit
76e2e56e256695c1d52bd67d1b07bce0c7e0f37c)
Volker Lendecke [Thu, 23 Apr 2009 12:56:55 +0000 (14:56 +0200)]
Revert "Do not use the file system GET_REAL_FILENAME for mangled names"
This reverts commit
c8cc6da0ab4441ce7b22cf00eed05290e91530c4.
(cherry picked from commit
c7d5e046d8fa4097fc16a3dee10e95b83a8c8e55)
Jeremy Allison [Thu, 23 Apr 2009 09:51:55 +0000 (02:51 -0700)]
Fix coverity #901 - uninitialized data.
Jeremy.
(cherry picked from commit
aa09344a77a686466371725e6f1c3f2ebaca684a)
Volker Lendecke [Thu, 23 Apr 2009 09:05:49 +0000 (11:05 +0200)]
Fix Coverity ID 626: DEADCODE
(cherry picked from commit
eb247d6eb727b451727f454b0ec207f255341671)
Volker Lendecke [Thu, 23 Apr 2009 08:49:41 +0000 (10:49 +0200)]
Fix Coverity ID 628, Andrew B., please check!
(cherry picked from commit
d8703a064e70bd56b2f0ddcde73af14045deed8c)
Jeremy Allison [Thu, 23 Apr 2009 08:47:04 +0000 (01:47 -0700)]
Fix coverity #908, #909, uninitialized variable.
Jeremy.
(cherry picked from commit
7f8e21ad459dbe5fdd20d3040d017787198de21d)
Volker Lendecke [Thu, 23 Apr 2009 08:42:43 +0000 (10:42 +0200)]
Fix Coverity ID 884: DEADCODE
(cherry picked from commit
cb8c7f2291897cc6d9bffdb48f4baca80161c2f8)
Jeremy Allison [Thu, 23 Apr 2009 08:38:21 +0000 (01:38 -0700)]
Fix coverity #910, uninitialized variable.
Jeremy.
(cherry picked from commit
7310c258a07f9f9da0ba736919f9021ab8125f66)
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.
Guenther
(cherry picked from commit
59fe99027d0ac972d0d74a24842d6423119c0d21)
(cherry picked from commit
abac431ce164c3ce3fcf53fbc77d0486347e22f1)
Simo Sorce [Wed, 22 Apr 2009 13:12:58 +0000 (09:12 -0400)]
Fix profile acls in some corner cases
Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
(cherry picked from commit
5d8f374ad75e06354ac27f34e3f44b3d459ac2ef)
Simo Sorce [Wed, 22 Apr 2009 10:15:21 +0000 (06:15 -0400)]
Avoid duplicate aces
When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
(cherry picked from commit
89dfbdba515b5be32f535a112a7f1019884aa651)
Jeremy Allison [Wed, 22 Apr 2009 10:03:04 +0000 (03:03 -0700)]
Add comment explaining the previous fix.
Jeremy.
(cherry picked from commit
0b0bb2c7eb44b403e6fd50cf480ed8b2fb24a7d5)
Jeremy Allison [Wed, 22 Apr 2009 09:54:11 +0000 (02:54 -0700)]
Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning LDAP_SUCCESS but not returning a result.
Jeremy
(cherry picked from commit
9ebc15bed8c05d0729066d97d3bfaade9fcbacb7)
Günther Deschner [Tue, 21 Apr 2009 11:01:29 +0000 (13:01 +0200)]
s3-secdesc: remove SEC_RIGHT_MAXIMUM_ALLOWED and SEC_RIGHT_SYSTEM_SECURITY.
We had up to three incarnations of these flags in Samba3.
Guenther
(cherry picked from commit
d94bbb3167f3a18d6b8a311557f228e2977249ea)
(cherry picked from commit
b0c4be0e2b856326e5790f4aef54e6b792f8f089)
Günther Deschner [Tue, 14 Apr 2009 23:30:12 +0000 (01:30 +0200)]
s3-secdesc: move all winreg access bits to IDL.
Guenther
(cherry picked from commit
38264bb3b86a3c9da941070f29ec08227c471d2b)
(cherry picked from commit
904bc5011fc7df40111f493ff28972640b95c0d1)
Günther Deschner [Tue, 14 Apr 2009 23:19:30 +0000 (01:19 +0200)]
s3-secdesc: use SEC_FLAG_SYSTEM_SECURITY instead of SEC_RIGHT_SYSTEM_SECURITY.
Guenther
(cherry picked from commit
da92e54236293460e307edd52ca7f1e20c6f23ef)
(cherry picked from commit
3e9ee3fa54b514987f40a477b3049b18e87390e9)
Günther Deschner [Tue, 14 Apr 2009 23:16:41 +0000 (01:16 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHT_MAXIMUM_ALLOWED.
Guenther
(cherry picked from commit
1bb093aea9a4c5996514b10adc39a130cc6859ba)
(cherry picked from commit
2f691302b3fe6b5b710b228ae149e0807ef5d5dc)
Günther Deschner [Tue, 14 Apr 2009 23:12:13 +0000 (01:12 +0200)]
s3-secdesc: use SEC_FLAG_MAXIMUM_ALLOWED instead of SEC_RIGHTS_MAXIMUM_ALLOWED.
Guenther
(cherry picked from commit
b5bec1a6d73f5939b306e157937d027a7286163c)
(cherry picked from commit
c7d5e0a19057b6ad7301a390fc766bb438967eb2)
John H Terpstra [Mon, 20 Apr 2009 15:10:20 +0000 (10:10 -0500)]
Added ability to revert to old modules for make revert.
(cherry picked from commit
e39255311a61897c53e00cc27df65790f83e132b)
Volker Lendecke [Wed, 15 Apr 2009 11:01:09 +0000 (13:01 +0200)]
Do not use the file system GET_REAL_FILENAME for mangled names
(cherry picked from commit
c8cc6da0ab4441ce7b22cf00eed05290e91530c4)
Günther Deschner [Fri, 17 Apr 2009 22:58:12 +0000 (00:58 +0200)]
s3-printing: use ARRAY_SIZE() macro in forms functions.
Guenther
(cherry picked from commit
62480385c1e551448e40b01fff8e9dee318c29c1)
(cherry picked from commit
fea535368e4d62606b522031afc773d4963dbb91)
Günther Deschner [Sun, 19 Apr 2009 22:57:53 +0000 (00:57 +0200)]
s3-printing: use sec_initial_uid() instead "0" in print_access_check().
Another babystep in order to make us pass RPC-SPOOLSS.
Guenther
(cherry picked from commit
d9aaf3759ac7fd6ce07a347a0138bdfb27a6f929)
(cherry picked from commit
63d4f5a5893dfcf8ff346bad100e8bd7052089ee)
Günther Deschner [Mon, 13 Apr 2009 21:56:59 +0000 (23:56 +0200)]
s4-smbtorture: test all levels in test_GetJob().
Guenther
(cherry picked from commit
5f0c9c57f53f9b0026b4f58f68442a72103c0d7d)
(cherry picked from commit
feec2a814ee09800c26ae4c1f637796737b7ad2a)
Günther Deschner [Fri, 17 Apr 2009 21:18:24 +0000 (23:18 +0200)]
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
(cherry picked from commit
81b18464be170528d5e1549868bcbddbbcd60e1e)
(cherry picked from commit
6689b0da85ac3b2f146c5e9851b73cf7d1e21c2b)
Günther Deschner [Mon, 13 Apr 2009 22:01:21 +0000 (00:01 +0200)]
s3-selftest: enable RPC-SPOOLSS.
Guenther
(cherry picked from commit
6f90cdaf63b5b584c96b9ffc388c9e8df172db67)
(cherry picked from commit
4677976a2081e4384b61d163d104c651e7a1f569)
Günther Deschner [Fri, 17 Apr 2009 15:21:19 +0000 (17:21 +0200)]
s4-smbtorture: Skip Job pause and resume on paused printers for Samba 3 for now.
Guenther
(cherry picked from commit
fe2828c3536eac18902a059049dd12b9b103f731)
(cherry picked from commit
4c3b05d8486ddff87ed665d9b37f6bc47fc2a96b)
Günther Deschner [Fri, 17 Apr 2009 15:19:38 +0000 (17:19 +0200)]
s4-smbtorture: rework test_EnumPrinterDrivers() a little to succeed with s3.
Yes, I feel dirty for this but promise to come back and fix appropriately.
Guenther
(cherry picked from commit
cb9c0cefaf61cf2c03f92a212dbf6673caa755dd)
(cherry picked from commit
f070e1d305f1b5abc9bc8f87ed552dbf9c1ea293)
Günther Deschner [Fri, 17 Apr 2009 15:14:20 +0000 (17:14 +0200)]
s4-smbtorture: Fix RPC-SPOOLSS-WIN for printers with a lot of jobs in the queue.
Guenther
(cherry picked from commit
81253ec14623ed480905433e5bf5df7982cfbfa4)
(cherry picked from commit
17c2e74370a9f748e33371c2a15597c415b50c1e)
Stefan Metzmacher [Fri, 3 Apr 2009 10:21:17 +0000 (12:21 +0200)]
s3:docs: document the --request-timeout option of net
metze
(cherry picked from commit
cdbbc81bad5d53397bf80898cf68d8867cf64cba)
(cherry picked from commit
1d1e859c4e08fed1775a170ccff459f3a18e13ba)
Stefan Metzmacher [Thu, 26 Mar 2009 19:32:55 +0000 (20:32 +0100)]
s3:net: add --request-timeout option
metze
(cherry picked from commit
257809558bfab3e45703cf8be76357596392a3ea)
(cherry picked from commit
e20b8706401d1a4eee0fe494825deef6ab23ab23)
Stefan Metzmacher [Thu, 26 Mar 2009 19:29:24 +0000 (20:29 +0100)]
s3:net_rpc: don't shutdown a cli_state passed from the caller
This fixes a crash bug if we timeout in net rpc trustdom list.
metze
(cherry picked from commit
c0dfe0cf80ee50f395912b7d6aec0d87febd34c0)
(cherry picked from commit
d87563604ca7b1c18c5a84d76726c2a99dc454f8)
Michael Adam [Fri, 17 Apr 2009 13:53:38 +0000 (15:53 +0200)]
s3: make installmo and uninstallmo scripts executable
Michael
(cherry picked from commit
9deb558c5a3c380c7e4964e6fd2fc1b948115078)
Michael Adam [Fri, 17 Apr 2009 13:29:10 +0000 (15:29 +0200)]
s3: Fix uninstallmo
Michael
(cherry picked from commit
81dca118cd94988f55a5b4c43436a97d04309b48)
Günther Deschner [Fri, 17 Apr 2009 13:13:33 +0000 (15:13 +0200)]
s3-selftest: samba 3 also passes RPC-JOIN so enable it.
Guenther
(cherry picked from commit
4f9d3400e5aa310e8071c0bb5d62ddaed1d846ee)
(cherry picked from commit
c33e3b84a706fa429ceeea81fb17c434e8f6cb4e)
Michael Adam [Fri, 17 Apr 2009 09:40:17 +0000 (11:40 +0200)]
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
(cherry picked from commit
74385e90fa72b132088861d864cb275909ed7f6f)
Günther Deschner [Fri, 17 Apr 2009 09:21:20 +0000 (11:21 +0200)]
s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().
Volker, please check.
Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with
this fix).
Guenther
(cherry picked from commit
0ba833f3eedff5dec272eb71f3b09becd8707156)
(cherry picked from commit
4c8d90a077901f7901b8202abed54746679aa3a9)
Günther Deschner [Fri, 17 Apr 2009 09:14:14 +0000 (11:14 +0200)]
s3-selftest: enable RPC-SAMR-PASSWORDS-PWDLASTSET whilte testing Samba3.
Guenther
(cherry picked from commit
490f6c418d8b1280d0a3b85773a72b2047122c12)
(cherry picked from commit
7f6094fe8238f7a146fe7c45ab31f0e2244704bd)
Günther Deschner [Fri, 17 Apr 2009 09:04:44 +0000 (11:04 +0200)]
s4-smbtorture: disable CreateUser2 tests when running RPC-SAMR-PASSWORDS-PWDLAST
against Samba3.
Samba 3 does not (yet) get all the ACB_flag settings right upon creation.
Guenther
(cherry picked from commit
32add69632ed4a2b877043c8df1185008516c299)
(cherry picked from commit
93f4a4f89448f33dbcf67ebb92fd94e65579b3c4)
Günther Deschner [Thu, 16 Apr 2009 23:30:54 +0000 (01:30 +0200)]
s3-docs: fix typo in smb.conf.5.
Guenther
(cherry picked from commit
05ea8daacabe62b6c20770a8518192c44e7eb763)
(cherry picked from commit
edf797fb614271c17bc005a661af8c8e8b913d81)
Günther Deschner [Thu, 16 Apr 2009 23:30:16 +0000 (01:30 +0200)]
s3-selftest: enable RPC-LSA-LOOKUPSIDS against samba 3.
Guenther
(cherry picked from commit
deb719a62e0909d476b9817c45a32766dc9709d7)
(cherry picked from commit
cfb5e97b88aae1780b5ef14baa15d9c692d157ab)
Günther Deschner [Thu, 16 Apr 2009 23:28:41 +0000 (01:28 +0200)]
s4-smbtorture: add LSA-LOOKUPSIDS to verify bug #6263.
Guenther
(cherry picked from commit
c794ba71b762676c1cfe1eba40b4a254f16ad06a)
(cherry picked from commit
e9af8e25f2c65decaf1a9e3c452c1a4c38042b48)
Günther Deschner [Thu, 16 Apr 2009 23:26:40 +0000 (01:26 +0200)]
s4-smbtorture: Fix crash in RPC-LSA-LOOKUP
Guenther
(cherry picked from commit
b0a0d2a0ae16929efa392705c3d7823da16f4d55)
(cherry picked from commit
a0c16dbb46ef334126db771d7adb908d822eac6d)
Günther Deschner [Thu, 16 Apr 2009 11:03:35 +0000 (13:03 +0200)]
s3-docs: document warn_pwd_expire pam_winbind option in manpage.
Andreas, please check.
Guenther
(cherry picked from commit
5517c0bcddfbd8c877fd1f909407824553a20e7f)
(cherry picked from commit
ed95e2978dd8b3c4a7e72569419748156ab5c760)
Jeremy Allison [Thu, 16 Apr 2009 23:21:31 +0000 (16:21 -0700)]
Add torture tester to ensure we don't regress the ulogoff bug.
Jeremy.
(cherry picked from commit
4ee6b7934e91b87122ff7bad4c89a0ab9bdd3bf0)
Jeremy Allison [Thu, 16 Apr 2009 23:19:10 +0000 (16:19 -0700)]
Fix bug found by Tim Prouty, logging off and then re-using a vuid can cause smbd to
access a freed structure.
Jeremy.
(cherry picked from commit
e023058f5b774ddbb61e8187aa7dbd2e6e25804d)
Jeremy Allison [Thu, 16 Apr 2009 22:15:10 +0000 (15:15 -0700)]
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy.
(cherry picked from commit
be46b98ee38e17e4561ab58fe9b6ecc6b7919392)
Jim McDonough [Thu, 16 Apr 2009 15:14:20 +0000 (17:14 +0200)]
Don't look up local user for remote changes, even when root.
(cherry picked from commit
583d7c97bb5f9b62fab17ce2466442ece648331f)
Michael Adam [Thu, 16 Apr 2009 09:13:24 +0000 (11:13 +0200)]
fix the build of net: dos_errstr is replaced by win_errstr...
I had the patch locally but forgot to commit before pushing - sorry...
Michael
(cherry picked from commit
986a36fd30f7f65c7ef79b945f7b95014872f30f)
Martin Schwenke [Thu, 16 Apr 2009 00:25:29 +0000 (10:25 +1000)]
In net_conf_import, start a transaction when importing a single share.
Commit
d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction
start to be conditional but the commit is still unconditional, so an
error occurs when importing a single share.
An alternate fix would be to return the transaction start to be
unconditional but then it would occur before other error checking.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
e344341ddd46e45b2ecdaf604cdd5d64adab6343)
Günther Deschner [Wed, 15 Apr 2009 23:42:35 +0000 (01:42 +0200)]
s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
(cherry picked from commit
1c9266c8caa59e287b993393b6050732a0b33547)
Jeremy Allison [Wed, 15 Apr 2009 22:40:00 +0000 (15:40 -0700)]
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
(cherry picked from commit
1994a8a5db5c3abd6292b81aa975e7b8fe8311d0)
Günther Deschner [Wed, 15 Apr 2009 20:47:15 +0000 (22:47 +0200)]
s4-smbtorture: Fix crash bugs in RPC-SAMR_ACCESSMASK.
Also disable security descriptor based tests while testing samba3.
Guenther
(cherry picked from commit
e6aa3f2d09bd004341dde28b15ef769a09401f26)
(cherry picked from commit
148fa23d95af164babd9135fc40d528ec147e372)
Günther Deschner [Wed, 15 Apr 2009 15:07:48 +0000 (17:07 +0200)]
s3-examples: make sure to match correct key name in adssearch.
Guenther
(cherry picked from commit
6fe012ff78caf10f4bf5503b27030cd54563ad0b)
(cherry picked from commit
6afb9614381f926b590c627f44cf5a93e11068ec)
Günther Deschner [Tue, 14 Apr 2009 21:30:13 +0000 (23:30 +0200)]
s4-smbtorture: define TORTURE_DEFAULT_SERVICE and set to netlogon.
Guenther
(cherry picked from commit
f1fd39c09f0e094c882775367b1e4c5772d7ee51)
(cherry picked from commit
9c914cf1bd4ce2d7abba6a4e94e393cb930f259e)
Karolin Seeger [Wed, 15 Apr 2009 09:05:22 +0000 (11:05 +0200)]
s3/WHATSNEW: Rewording.
Karolin
(cherry picked from commit
db49a0cf2c9b9b108ec10d9b962026032910f4e4)
Karolin Seeger [Wed, 15 Apr 2009 08:49:07 +0000 (10:49 +0200)]
s3/WHATSNEW: Add tevent to the list of internal changes.
Karolin
(cherry picked from commit
83a9cbece9d1f3141c4f6bf7586a80f0eae6e37f)
Karolin Seeger [Wed, 15 Apr 2009 08:20:07 +0000 (10:20 +0200)]
s3/WHATSNEW: Correct description.
Karolin
(cherry picked from commit
459aa55885edc03707d58eedd15bd54227729bee)
Karolin Seeger [Wed, 15 Apr 2009 08:11:22 +0000 (10:11 +0200)]
s3/WHATSNEW: Add Günther's spools conversion.
Karolin
(cherry picked from commit
d8de3f43ef4d4e399c4c55fd9738539f0ff97145)
Volker Lendecke [Wed, 15 Apr 2009 07:51:20 +0000 (09:51 +0200)]
Remove the so-far unused lua-stuff for the 3.4 release
(cherry picked from commit
0349dad1633cd9574e0d8c7d2054e4c7dd0fdc21)
Karolin Seeger [Wed, 15 Apr 2009 07:52:23 +0000 (09:52 +0200)]
s3/configure: Disable the automatic merged build.
Karolin
(cherry picked from commit
3b028d8609d29de2610d1c91d3098aa6002b90c4)
Karolin Seeger [Wed, 15 Apr 2009 07:51:45 +0000 (09:51 +0200)]
s3/WHATSNEW: Add some more Franky specific stuff.
Karolin
(cherry picked from commit
4d5306d047674676fe8f4e788cac88def055841a)
Karolin Seeger [Wed, 15 Apr 2009 07:27:02 +0000 (09:27 +0200)]
s3/WHATSNEW: Add reference to Franky.
Karolin
(cherry picked from commit
0df89b9a991adf692b26f2c5e50d0ed90e244849)
Günther Deschner [Tue, 14 Apr 2009 21:19:25 +0000 (23:19 +0200)]
s3-spoolss: Fix format of description string in spoolss_PrinterInfo1.
This is what windows does and should get us closer to show the appropriate
printer location string in explorer.
Guenther
(cherry picked from commit
4721be488ceb8229d564e4b63ca9937603394e51)
(cherry picked from commit
90643d5d5457959cf18a4b99f6ecb1bb88886fe0)
Günther Deschner [Tue, 14 Apr 2009 20:39:36 +0000 (22:39 +0200)]
netdomjoin-gui: make sure to grey out change fields when not running as root.
Guenther
(cherry picked from commit
ca3de0103b545c86c8507dfc7d042f1838d5dfb2)
(cherry picked from commit
cb96e70a1d9112d9e4fff1fda4cf64abc7985347)
Günther Deschner [Tue, 14 Apr 2009 14:27:05 +0000 (16:27 +0200)]
libwbclient: Fix undocumented arguments doxygen warnings.
Guenther
(cherry picked from commit
f2b3fbf0c04a6f9484853da263174a472eb6bb6d)
Günther Deschner [Tue, 14 Apr 2009 12:55:24 +0000 (14:55 +0200)]
s3-nsswitch: fix make test_wbpad.
Guenther
(cherry picked from commit
1b9384a11f2957bcfbe9f23e023c79535d4a7bc9)
(cherry picked from commit
e7c9c2f279eaa424ba7cfecd0bfd827520640f5d)
Stefan Metzmacher [Tue, 14 Apr 2009 10:45:48 +0000 (12:45 +0200)]
socket_wrapper: fix the build on systems without ipv6 support
metze
(cherry picked from commit
74707e8e8e1be2cbaa71fb0442957be2e663cbde)
(cherry picked from commit
b5faa34596eed3ada7f45db991ef0beb0391ce82)
Günther Deschner [Tue, 14 Apr 2009 10:10:22 +0000 (12:10 +0200)]
s4-smbtorture: make sure samba3 does not regress in EnumServicesStatusW call.
Guenther
(cherry picked from commit
a2ef1fee69771f58c27604ef213405031f42ff96)
(cherry picked from commit
3368cd38f710b9d21a3382bfd8971f0f6517eec1)
Günther Deschner [Tue, 14 Apr 2009 10:08:55 +0000 (12:08 +0200)]
s3-svcctl: fix memcpy in _svcctl_EnumServicesStatusW().
Make sure we are not copying more than what we have as valid data.
Fix from Jeremy. Thanks a lot for watching this so closely!
Guenther
(cherry picked from commit
fa302020ee39bf39bf324983cf8e381232691e76)
(cherry picked from commit
5fc2656e600791667835775c94a86f788abbcc1a)
Günther Deschner [Tue, 14 Apr 2009 10:00:39 +0000 (12:00 +0200)]
s3-spoolss: remove unused dup_nt_devicemode().
Guenther
(cherry picked from commit
e3ceb0c65333cb870463971021e3af24d82abf26)
(cherry picked from commit
0f48d27d6fb45bc61899916037a5133e3022ec59)
Günther Deschner [Mon, 13 Apr 2009 23:08:23 +0000 (01:08 +0200)]
s4-smbtorture: print SPOOLSS_JOB_CONTROL flags in RPC-SPOOLSS test.
Guenther
(cherry picked from commit
4a2dfbf3c94c8fc4c2cbcbea3b138c5a9674f951)
(cherry picked from commit
f78af6c1f1bab5299ef286ada2477e849cf5ba97)