inet: fix NULL pointer Oops in fib(6)_rule_suppress
authorStefan Tomanek <stefan.tomanek@wertarbyte.de>
Tue, 10 Dec 2013 22:21:25 +0000 (23:21 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Dec 2013 22:54:23 +0000 (17:54 -0500)
commit673498b8ed4c4d4b7221c5309d891c5eac2b7528
treeb0e29c809ae12246f544fa3c6552af71acd361e7
parentd323e92cc3f4edd943610557c9ea1bb4bb5056e8
inet: fix NULL pointer Oops in fib(6)_rule_suppress

This changes ensures that the routing entry investigated by the suppress
function actually does point to a device struct before following that pointer,
fixing a possible kernel oops situation when verifying the interface group
associated with a routing table entry.

According to Daniel Golle, this Oops can be triggered by a user process trying
to establish an outgoing IPv6 connection while having no real IPv6 connectivity
set up (only autoassigned link-local addresses).

Fixes: 6ef94cfafba15 ("fib_rules: add route suppression based on ifgroup")
Reported-by: Daniel Golle <daniel.golle@gmail.com>
Tested-by: Daniel Golle <daniel.golle@gmail.com>
Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_rules.c
net/ipv6/fib6_rules.c