Fix nesting tdb_traverse in a transaction
authorVolker Lendecke <vl@samba.org>
Tue, 20 May 2008 19:54:36 +0000 (21:54 +0200)
committerVolker Lendecke <vl@samba.org>
Tue, 20 May 2008 19:59:44 +0000 (21:59 +0200)
commit6ed27edbcd3ba1893636a8072c8d7a621437daf7
tree670cce297e9dad1a82131778b2153134c400f6d7
parent8ca459e067c3d4f3495e0a6dafea7296e3dfb2ab
Fix nesting tdb_traverse in a transaction

Calling tdb_traverse inside a transaction led to the transaction lock being
held indefinitely. This was caused by the tdb_transaction_lock/unlock inside
tdb_traverse: The transaction code holds the global lock at offset
TRANSACTION_LOCK. The call to tdb_transaction_lock does nothing because the
transaction_lock is already being held. tdb_transaction_unlock inside tdb_wrap
resets tdb->have_transaction_lock but does not release the kernel-level fcntl
lock. transaction_commit later on does not release that fcntl lock either,
because tdb->have_transaction_lock was already reset by tdb_transaction().

This patch does fix that problem for me. An alternative would be to make
tdb->have_transaction_lock a counter that can cope with proper nesting, maybe
in other places as well.

Volker
(This used to be commit 80e700e3bd73f2ffa38046bdcba7f532e25198ef)
source3/lib/tdb/common/traverse.c