rtlwifi: rtl8821ae: fix firmware is not ready to run
authorPing-Ke Shih <pkshih@realtek.com>
Thu, 28 Jun 2018 02:02:27 +0000 (10:02 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 29 Jun 2018 07:08:47 +0000 (10:08 +0300)
commit9a98302de19991d51e067b88750585203b2a3ab6
treeca7bf3712330d745330da2db60061b9705c3f495
parent92963318a255fd5df94159767cd4750e55d98cb0
rtlwifi: rtl8821ae: fix firmware is not ready to run

Without this patch, firmware will not run properly on rtl8821ae, and it
causes bad user experience. For example, bad connection performance with
low rate, higher power consumption, and so on.

rtl8821ae uses two kinds of firmwares for normal and WoWlan cases, and
each firmware has firmware data buffer and size individually. Original
code always overwrite size of normal firmware rtlpriv->rtlhal.fwsize, and
this mismatch causes firmware checksum error, then firmware can't start.

In this situation, driver gives message "Firmware is not ready to run!".

Fixes: fe89707f0afa ("rtlwifi: rtl8821ae: Simplify loading of WOWLAN firmware")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Cc: Stable <stable@vger.kernel.org> # 4.0+
Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/core.c