s3: smbd: Use separate flag to track become_root()/unbecome_root() state.
authorJeremy Allison <jra@samba.org>
Wed, 17 Jun 2015 17:23:30 +0000 (10:23 -0700)
committerJeremy Allison <jra@samba.org>
Thu, 25 Jun 2015 20:14:58 +0000 (22:14 +0200)
commite2c4b8967d33b610f9f076c614352e4b8fc7c558
treef7d3c3231f7901f95ad572f29e09fe71dd8e52b5
parentc0364fa07599f0b20dec53958f498308067c368b
s3: smbd: Use separate flag to track become_root()/unbecome_root() state.

Early function exit can mean backup_priv is set but we haven't called
become_root(). *Lots* of work by the reviewers went in to checking this
isn't a security issue.

Found by Codenomicon at the Redmond plugfest.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11339

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jun 25 22:14:58 CEST 2015 on sn-devel-104
source3/smbd/trans2.c